[Mesa-dev] [PATCH] aubinator: Don't skip the first field in each subgroup

2017-11-11 Thread Jason Ekstrand
The previous iteration algorithm would advance the field pointer right after we advance the group. This meant that you would end up with skipping the first field of the group. In the common case, where the only field is a struct (e.g. 3DSTATE_VERTEX_BUFFERS), it would get skipped entirely. --- s

[Mesa-dev] [PATCH v2 1/2] nv50/ir: optimize signed integer modulo by pow-of-2

2017-11-11 Thread Ilia Mirkin
It's common to use signed int modulo in GLSL. As it happens, the GLSL specs allow the result to be undefined, but that seems fairly surprising. It's not that much more effort to get it right, at least for positive modulo operators. Signed-off-by: Ilia Mirkin --- v1 -> v2: - fix SHLADD folding

[Mesa-dev] [Bug 103674] u_queue.c:173:7: error: implicit declaration of function 'timespec_get' is invalid in C99

2017-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103674 Mauro Rossi changed: What|Removed |Added CC||issor.or...@gmail.com --- Comment #1 from

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-11 Thread Miklós Máté
On 12/11/17 00:06, Timothy Arceri wrote: On 12/11/17 04:10, Miklós Máté wrote: Hi, this breaks a few things. The patch below gets rid of the assertion failures, but the reference counting needs a proper fix, and swrast draws blackness when ATIfs is enabled. Thanks for testing :) Is there so

Re: [Mesa-dev] [PATCH] RFC: meson: Add a new build-dev-tools option

2017-11-11 Thread Rob Clark
On Sat, Nov 11, 2017 at 5:39 PM, Jason Ekstrand wrote: > On Sat, Nov 11, 2017 at 10:30 AM, Rob Clark wrote: >> >> On Sat, Nov 11, 2017 at 12:42 PM, Jason Ekstrand >> wrote: >> > A variety of the different drivers in mesa have some sort of developer >> > tools to go along with them. Normal users

Re: [Mesa-dev] [PATCH 2/2] intel/tools: Fix program disassembly in aubinator_error_decode.

2017-11-11 Thread Lionel Landwerlin
:( The intention was to deal with cases where we've encountered more than MAX_NUM_PROGRAMS (actually happened to me). So we start by the index + 1 assuming this is the oldest program because we're in a rolling window of programs. This is obviously broken with the < 4096 programs case. Maybe w

Re: [Mesa-dev] [PATCH 1/2] intel/tools: Fix detection of enabled shader stages.

2017-11-11 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 11/11/17 00:55, Kenneth Graunke wrote: We renamed "Function Enable" to "Enable", which broke our detection of whether shaders are enabled or not. So, we'd see a bunch of HS/DS packets with program offsets of 0, and think that was a valid TCS/TES. Fixes: c032c

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-11 Thread Timothy Arceri
On 12/11/17 04:10, Miklós Máté wrote: Hi, this breaks a few things. The patch below gets rid of the assertion failures, but the reference counting needs a proper fix, and swrast draws blackness when ATIfs is enabled. Thanks for testing :) Is there something freely available I can test this

Re: [Mesa-dev] [PATCH] RFC: meson: Add a new build-dev-tools option

2017-11-11 Thread Jason Ekstrand
On Sat, Nov 11, 2017 at 10:30 AM, Rob Clark wrote: > On Sat, Nov 11, 2017 at 12:42 PM, Jason Ekstrand > wrote: > > A variety of the different drivers in mesa have some sort of developer > > tools to go along with them. Normal users don't want these but devs do. > > This commit adds a new build-

[Mesa-dev] [PATCH] i965: Capture INTEL_DEBUG alongside the hanging batch

2017-11-11 Thread Chris Wilson
Similar to how we create a growing state buffer to live alongside the batch buffer, also create a debug buffer that is submitted and recreated on every batch. This allows us to emit debugging information about this batch that will be captured alongside the hanging batch for aide in post-mortem debu

[Mesa-dev] [PATCH 1/2] meson: Stop requiring platforms for Vulkan

2017-11-11 Thread Jason Ekstrand
It should be perfectly valid to build a completely headless Vulkan driver. We don't need to require a platform. --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index 1f6658b..e4d0e0f 100644 --- a/meson.build +++ b/meson.build @@ -306,9 +306,6 @@ if

[Mesa-dev] [PATCH 2/2] meson: Move -Dvulkan-drivers handling higher in the file

2017-11-11 Thread Jason Ekstrand
The window-system auto-detection code (specifically for glx) relies on with_any_vk being available. This fixes the Vulkan-only build. Also, this puts it up near the handling of -Ddri-drivers and -Dgallium-drivers which seems to make a bit more sense. --- meson.build | 46 +++-

Re: [Mesa-dev] [PATCH] RFC: meson: Add a new build-dev-tools option

2017-11-11 Thread Rob Clark
On Sat, Nov 11, 2017 at 12:42 PM, Jason Ekstrand wrote: > A variety of the different drivers in mesa have some sort of developer > tools to go along with them. Normal users don't want these but devs do. > This commit adds a new build-dev-tools option which causes these tools > to be built and ins

[Mesa-dev] [PATCH] RFC: meson: Add a new build-dev-tools option

2017-11-11 Thread Jason Ekstrand
A variety of the different drivers in mesa have some sort of developer tools to go along with them. Normal users don't want these but devs do. This commit adds a new build-dev-tools option which causes these tools to be built and installed. Cc: Rob Clark Cc: Dylan Baker --- meson.build

Re: [Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

2017-11-11 Thread Jason Ekstrand
On Sat, Nov 11, 2017 at 8:11 AM, Dylan Baker wrote: > I sent a patch to fix this as did Rob, I think his landed already. > Yeah... I still kind-of like the way my patch works. I personally think it's way nicer to predicate build targets on boolean configure flags rather than setting build_by_d

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-11 Thread Miklós Máté
Hi, this breaks a few things. The patch below gets rid of the assertion failures, but the reference counting needs a proper fix, and swrast draws blackness when ATIfs is enabled. MM diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index faf5b7fa28..b71917d7b1 100644 --- a

Re: [Mesa-dev] [PATCH] st/atifs: remove unrequired initialisation of gl_program fields

2017-11-11 Thread Miklós Máté
Reviewed-by: Miklós Máté MM On 10/11/17 09:49, Timothy Arceri wrote: As far as I can tell these fields are only used to query arb program info and are not related to ATI_fragment_shader. Cc: Miklós Máté --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 4 1 file changed, 4 deletions(-

Re: [Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

2017-11-11 Thread Rob Clark
hmm, well autotools build built it by default, and it's contribution to build time is negligible vs addition of even more config options.. perhaps it is really only useful for debug builds, so I'd be ok with the approach of only building it for debug builds BR, -R On Sat, Nov 11, 2017 at 11:11

Re: [Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

2017-11-11 Thread Dylan Baker
I sent a patch to fix this as did Rob, I think his landed already. I'm not sure it's a good idea to build tools by default. Personally I'd rather see an extra option added if compiling via ninja src/gallium/drivers/freedreno/ir3compiler is too tedious. Dylan On November 10, 2017 11:10:37 PM PS

Re: [Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

2017-11-11 Thread Rob Clark
sorry 'bout that.. this should already fix it: https://cgit.freedesktop.org/mesa/mesa/commit/?id=881f6e741fe0f63df1aa6aadba7e2eb64269cb20 On Sat, Nov 11, 2017 at 2:10 AM, Jason Ekstrand wrote: > Setting build_by_default to true makes it suddenly pull in freedreno and > all of gallium uncondition

[Mesa-dev] [Bug 103683] Account request for Alex Smith

2017-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103683 --- Comment #1 from Alex Smith --- Created attachment 135396 --> https://bugs.freedesktop.org/attachment.cgi?id=135396&action=edit PGP key -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for t

[Mesa-dev] [Bug 103683] Account request for Alex Smith

2017-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103683 Bug ID: 103683 Summary: Account request for Alex Smith Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 10/17] main: Allow non-zero NUM_PROGRAM_BINARY_FORMATS

2017-11-11 Thread Tapani Pälli
On 11/11/2017 10:14 AM, Jordan Justen wrote: On 2017-11-09 03:16:46, Tapani Pälli wrote: On 11/09/2017 08:42 AM, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/main/get_hash_params.py | 2 +- src/mesa/main/mtypes.h | 3 +++ 2 files changed, 4 insertions(+),

Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-11 Thread Andy Furniss
Zhang, Boyuan wrote: diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c b/src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c index 5170c67..c6dc420 100644 --- a/src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c +++ b/src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c @@ -362,6 +362,233 @@ stat

Re: [Mesa-dev] [PATCH 2/3] etnaviv: Add TS_SAMPLER formats to etnaviv_format

2017-11-11 Thread Wladimir
On Tue, Nov 7, 2017 at 5:43 PM, Wladimir J. van der Laan wrote: > Sampler TS introduces yet another format enumeration for renderable > formats. Introduce it into etnaviv_format as unobtrusively as possible. > > Signed-off-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_

Re: [Mesa-dev] [PATCH 00/17] i965 ARB_get_program_binary support

2017-11-11 Thread Jordan Justen
On 2017-11-10 23:46:39, Timothy Arceri wrote: > On 09/11/17 21:46, Timothy Arceri wrote: > > On 09/11/17 17:42, Jordan Justen wrote: > >> git://people.freedesktop.org/~jljusten/mesa i965-get-program-binary-v1 > >> > >> This series adds i965 support for ARB_get_program_binary with greater > >> than

Re: [Mesa-dev] [PATCH 10/17] main: Allow non-zero NUM_PROGRAM_BINARY_FORMATS

2017-11-11 Thread Jordan Justen
On 2017-11-09 03:16:46, Tapani Pälli wrote: > > > On 11/09/2017 08:42 AM, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/mesa/main/get_hash_params.py | 2 +- > > src/mesa/main/mtypes.h | 3 +++ > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff