[Mesa-dev] [PATCH] r600/shader: handle bitfield extract semantics properly.

From: Dave Airlie Fixes: tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-bitfieldExtract.shader_test Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 57 +++--- 1 file changed, 53 insertions(+), 4 deletions(-) diff --git a/src/gall

[Mesa-dev] [PATCH] r600: handle bitfieldInsert corner case.

From: Dave Airlie This handles the bits >= 32 corner case in bitfieldInsert. Fixes: tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-bitfieldInsert.shader_test. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 40 +- 1 file chan

[Mesa-dev] [PATCH] r600: fix isoline tess factor component swapping.

From: Dave Airlie As per radeonsi, the tess factor components for isolines are reversed. Fixes: tests/spec/arb_tessellation_shader/execution/isoline.shader_test Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/

[Mesa-dev] [PATCH 1/2] r600/shader: reserve first register of vertex shader.

From: Dave Airlie r0 in input into vertex shaders contains things like vertexid, we need to reserve it even if we have no inputs. This fixes a bunch of tessellation piglits. --- src/gallium/drivers/r600/r600_shader.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 2/2] r600: add gs tri strip adjacency fix.

From: Dave Airlie Like radeonsi: generate GS prolog to (partially) fix triangle strip adjacency rotation evergreen hw suffers from the same problem, so rotate the geometry inputs to fix this. This fixes: ./bin/glsl-1.50-geometry-primitive-types GL_TRIANGLE_STRIP_ADJACENCY on evergreen. Signed

Re: [Mesa-dev] [PATCH v2] configure.ac: Define HAVE_ZLIB if zlib is found

On Fri, Nov 10, 2017, at 14:50, Emil Velikov wrote: > On 10 November 2017 at 22:18, Jordan Justen > wrote: > > v2: > > * Keep zlib required for autotools & meson (Emil) > > > > Cc: Emil Velikov > > Cc: Dylan Baker > > Signed-off-by: Jordan Justen > > --- > > configure.ac | 8 +++- > > m

[Mesa-dev] Has anyone stressed radeonsi memory?

Hi! I am on a Radeon RX 560 2GB; using mesa git-57c8ead0cd (So... not too new not too old), Kernel 4.12.10 I've been having complaints about our WIP branch of Ogre 2.2 about out of memory crashes, and I fixed them. I made a stress test where 495 textures with very different resolutions (most

[Mesa-dev] [PATCH 2/4] st/glsl_to_tgsi: make use of tgsi_get_gl_varying_semantic()

--- src/mesa/state_tracker/st_program.c | 82 + 1 file changed, 11 insertions(+), 71 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index e3649a8b7c..3bc15bccc0 100644 --- a/src/mesa/state_tracker/st_program

[Mesa-dev] [PATCH 4/4] st/glsl_to_tgsi: use tgsi_get_gl_varying_semantic() for gs/tes outputs

--- src/mesa/state_tracker/st_program.c | 96 ++--- 1 file changed, 5 insertions(+), 91 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index 3bc15bccc0..6b3da028c5 100644 --- a/src/mesa/state_tracker/st_program.

[Mesa-dev] [PATCH 1/4] gallium/tgsi: add prim id to tgsi_get_gl_varying_semantic()

--- src/gallium/auxiliary/tgsi/tgsi_from_mesa.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c b/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c index b7a21f29ba..31be7d946b 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c +++ b/src/gallium

[Mesa-dev] [PATCH 3/4] gallium/tgsi: add tess output supoort to tgsi_get_gl_varying_semantic()

--- src/gallium/auxiliary/tgsi/tgsi_from_mesa.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c b/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c index 31be7d946b..c014115918 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c +++ b/src/gal

[Mesa-dev] [PATCH] gallium/radeon: disable the cache when nir backend enabled

--- src/gallium/drivers/radeon/r600_pipe_common.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index 68bde2ad18..ce612113c5 100644 --- a/src/gallium/drivers/radeon/r600_pipe_common.c +++ b/src

[Mesa-dev] [PATCH] intel/genxml: Delete empty groups

They serve no purpose other than to just fill empty space in the packet so each dword has something. Just disallowing empty groups is a bit easier on some of the tools. This does not change the generated packing headers in any way. Cc: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 2 -- s

Re: [Mesa-dev] [PATCH] aubinator: Don't skip the first field in each subgroup

On Sun, Nov 12, 2017 at 3:29 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 12/11/17 05:45, Jason Ekstrand wrote: > >> The previous iteration algorithm would advance the field pointer right >> after we advance the group. This meant that you would end up with >> skipping the fi

Re: [Mesa-dev] [PATCH 03/10] spirv: Import the latest 1.0.12 header and JSON from Khronos

On Friday, 2017-11-10 14:32:43 -0800, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/compiler/spirv/spirv.core.grammar.json | 417 > - > src/compiler/spirv/spirv.h | 56 ++-- > 2 files changed, 201 insertions(+)

Re: [Mesa-dev] [PATCH] radv: keep a stage mask per pipeline.

Reviewed-by: Bas Nieuwenhuizen Maybe time to index shaders based on HW stage instead of API stage? On Mon, Nov 6, 2017 at 5:57 AM, Dave Airlie wrote: > From: Dave Airlie > > This should reduce some pointless loops. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_cmd_buffer.c | 51

Re: [Mesa-dev] [PATCH 2/2] radv: emit esgs ring size in one place.

Reviewed-by: Bas Nieuwenhuizen for the series, if you hadn't forgotten/pushed this yet. Sorry for the delay. On Mon, Nov 6, 2017 at 3:05 AM, Dave Airlie wrote: > From: Dave Airlie > > This register is the same on all gpus so far, so emit it in one > place and also for the pre-gfx9 gpus set the

Re: [Mesa-dev] [PATCH 8/8] radv: add unlikely() around radv_save_descriptors()

For the series: Reviewed-by: Bas Nieuwenhuizen On Fri, Nov 10, 2017 at 9:18 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/src/a

Re: [Mesa-dev] [PATCH 2/2] radv: make radv_emit_framebuffer_state() static

Reviewed-by: Bas Nieuwenhuizen for the series. On Wed, Nov 8, 2017 at 12:52 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 +- > src/amd/vulkan/radv_private.h| 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --gi

Re: [Mesa-dev] [PATCH 3/3] radv: prefetch VBO descriptors at the right place

Reviewed-by: Bas Nieuwenhuizen for the series. On Wed, Nov 8, 2017 at 12:12 PM, Samuel Pitoiset wrote: > Just after the vertex shader. > > This seems to give a minor boost for, at least, Serious Sam > Fusion 2017 and Dawn of War 3. I don't see any real impacts > with The Talos Principle. > > Si

[Mesa-dev] [PATCH 2/2] c11/haiku: Define missing timespec_get on Haiku

--- include/c11/threads_posix.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/c11/threads_posix.h b/include/c11/threads_posix.h index 7bf6a0f6ef..2d7ac1326d 100644 --- a/include/c11/threads_posix.h +++ b/include/c11/threads_posix.h @@ -382,7 +382,7 @@ tss_set(tss_t ke

[Mesa-dev] [PATCH 1/2] egl/haiku: Correct invalid void* conversion in calloc

--- src/egl/drivers/haiku/egl_haiku.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/haiku/egl_haiku.cpp b/src/egl/drivers/haiku/egl_haiku.cpp index 237cebf056..287760661e 100644 --- a/src/egl/drivers/haiku/egl_haiku.cpp +++ b/src/egl/drivers/haiku/egl_hai

Re: [Mesa-dev] [PATCH v2 1/2] nv50/ir: optimize signed integer modulo by pow-of-2

On 11/12/17 4:16 PM, Ilia Mirkin wrote: On Sun, Nov 12, 2017 at 9:09 AM, Tobias Klausmann wrote: On 11/12/17 3:53 AM, Ilia Mirkin wrote: It's common to use signed int modulo in GLSL. As it happens, the GLSL specs allow the result to be undefined, but that seems fairly surprising. It's not tha

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

https://bugs.freedesktop.org/show_bug.cgi?id=103586 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net -- You are receivi

[Mesa-dev] [AppVeyor] mesa master #6127 completed

Build mesa 6127 completed Commit 4a9aad96aa by Rob Clark on 11/11/2017 3:50 PM: freedreno/a5xx: fix SSBO emit for non-zero offset\n\nSigned-off-by: Rob Clark Configure your notification preferences ___ mes

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 Bug ID: 103699 Summary: Latest mesa breaks firefox on kde plasma with compositing on Product: Mesa Version: git Hardware: Other OS: All Status:

Re: [Mesa-dev] [PATCH v2 1/2] nv50/ir: optimize signed integer modulo by pow-of-2

On Sun, Nov 12, 2017 at 9:09 AM, Tobias Klausmann wrote: > > On 11/12/17 3:53 AM, Ilia Mirkin wrote: >> >> It's common to use signed int modulo in GLSL. As it happens, the GLSL >> specs allow the result to be undefined, but that seems fairly >> surprising. It's not that much more effort to get it

[Mesa-dev] [Bug 103697] [regression] shared memory size 64k -> 32k?

https://bugs.freedesktop.org/show_bug.cgi?id=103697 Kenneth Graunke changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

Re: [Mesa-dev] [PATCH 1/2] st/mesa: move st_init_driver_flags() earlier in file

For the series: Reviewed-By: Gert Wollny On 11.11.2017 03:40, Brian Paul wrote: > To get rid of forward declaration. > --- > src/mesa/state_tracker/st_context.c | 123 > ++-- > 1 file changed, 62 insertions(+), 61 deletions(-) > > diff --git a/src/mesa/state_tr

Re: [Mesa-dev] [PATCH 2/2] nv50/ir: add optimization for modulo by a non-power-of-2 value

On 11/11/17 4:12 AM, Ilia Mirkin wrote: We can still use the optimized division methods which make use of multiplication with overflow. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v2 1/2] nv50/ir: optimize signed integer modulo by pow-of-2

On 11/12/17 3:53 AM, Ilia Mirkin wrote: It's common to use signed int modulo in GLSL. As it happens, the GLSL specs allow the result to be undefined, but that seems fairly surprising. It's not that much more effort to get it right, at least for positive modulo operators. Signed-off-by: Ilia Mir

[Mesa-dev] [PATCH 20/23] gallium/aux/util/u_blit.c: Fix -Wunused-param warnings

Annotate the parameters accordingly. --- src/gallium/auxiliary/util/u_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blit.c b/src/gallium/auxiliary/util/u_blit.c index 3e49667029..ee8d89d9ff 100644 --- a/src/gallium/auxiliary/util/u_blit.c

[Mesa-dev] [PATCH 22/23] gallium/aux/os/os_thread.h: Silence -Wunused-param.

With --disable-debug a parameter is not used. Silence this warning by fake-using it. --- src/gallium/auxiliary/os/os_thread.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/os/os_thread.h b/src/gallium/auxiliary/os/os_thread.h index d9c685922a..f2629c5ffe 100644 --- a

[Mesa-dev] [PATCH 16/23] gallium/aux/util/u_transfer.c: Fix some -Wunused-param warnings.

Decorate the params with "UNUSED" accordingly. --- src/gallium/auxiliary/util/u_transfer.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/gallium/auxiliary/util/u_transfer.c b/src/gallium/auxiliary/util/u_transfer.c index ba4b9dcc6b..10dc59a926 1006

[Mesa-dev] [PATCH 15/23] gallium/aux/util/u_threaded_context.c: Fix some warnings

* Decorate the params accordingly with UNUSED or MAYBE_UNUSED (for params that are used in debug mode) to fix -Wunused-param warnings. * Enclose if body with braces, since it is empty in release mode to fix -Wparentheses warning. --- src/gallium/auxiliary/util/u_threaded_context.c | 19 ++

[Mesa-dev] [PATCH 18/23] mesa/main/texcompress_s3tc_tmp.h: Fix two -Wparam-unused warnings.

Decorate the params accordingly with "UNUSED". --- src/mesa/main/texcompress_s3tc_tmp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/texcompress_s3tc_tmp.h b/src/mesa/main/texcompress_s3tc_tmp.h index 61630f2475..c02f6242fc 100644 --- a/src/mesa/main/texco

[Mesa-dev] [PATCH 23/23] gallium/aux/util/u_async_debug.c: Fix -Wtype-limits warning.

Use size_t instread of unsigned for new_max. realloc later expects size_t as parameter anyway. --- src/gallium/auxiliary/util/u_async_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_async_debug.c b/src/gallium/auxiliary/util/u_async_debug.c

[Mesa-dev] [PATCH 14/23] gallium/aux/util/u_surface.c: Silence a -Wsign-compare warning.

Explicitely convert one value to compare. --- src/gallium/auxiliary/util/u_surface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_surface.c b/src/gallium/auxiliary/util/u_surface.c index 0a79a25a43..c66f279dc2 100644 --- a/src/gallium/auxiliary/

[Mesa-dev] [PATCH 12/23] gallium/aux/util/u_mm.c: Fix one -Wparam-unused warning.

Decorate the unused param accordingly with "UNUSED". --- src/gallium/auxiliary/util/u_mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_mm.c b/src/gallium/auxiliary/util/u_mm.c index 7a45e29192..71c079f8fe 100644 --- a/src/gallium/auxiliary/util

[Mesa-dev] [PATCH 19/23] src/util/simple_mtx.h: Fix two -Wunused-param warnings.

Decorate the parameters accordingly with "UNUSED" or "MAYBE_UNUSED" (for the param that is used in debug mode, but not in release mode). --- src/util/simple_mtx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/simple_mtx.h b/src/util/simple_mtx.h index cd24b6f9eb.

[Mesa-dev] [PATCH 17/23] mesa/main/framebuffer.h: Fix one -Wsign-compare warning in ?: construct.

Explicitely convert on value to the target type. --- src/mesa/main/framebuffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/framebuffer.h b/src/mesa/main/framebuffer.h index bc6e7bc31a..bffa21dcea 100644 --- a/src/mesa/main/framebuffer.h +++ b/src/mesa/main/f

[Mesa-dev] [PATCH 21/23] gallium/aux/util/u_debug_refcnt.h: Fix -Wunused-param warnings

Annotate the according parameters accordingly. --- src/gallium/auxiliary/util/u_debug_refcnt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_debug_refcnt.h b/src/gallium/auxiliary/util/u_debug_refcnt.h index cf04777666..daccdb2cc1 100644 ---

[Mesa-dev] [PATCH 10/23] gallium/aux/util/u_format_rgtc.c: Fix a number of -Wunused-param warnings

Decorate the params accordingly with "UNUSED". --- src/gallium/auxiliary/util/u_format_rgtc.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_rgtc.c b/src/gallium/auxiliary/util/u_format_rgtc.c index 1596917435..8

[Mesa-dev] [PATCH 11/23] gallium/aux/util/u_format_yuv.c: Fix a number of -Wunused-param warnings.

Decorate the params accordingly with "UNUSED". --- src/gallium/auxiliary/util/u_format_yuv.c | 232 +++--- 1 file changed, 116 insertions(+), 116 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_yuv.c b/src/gallium/auxiliary/util/u_format_yuv.c index 55f8ad68

[Mesa-dev] [PATCH 09/23] gallium/aux/util/u_format_other.c: Fix various -Wunused-param warnings.

Decorate the unused params with "UNUSED". --- src/gallium/auxiliary/util/u_format_other.c | 34 ++--- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_other.c b/src/gallium/auxiliary/util/u_format_other.c index c53bf55

[Mesa-dev] [PATCH 13/23] gallium/aux/util/u_pstipple.c: Fix one -Wsign-compare warning in ?: construct.

Silence the warning by making the conversion to int explicit. --- src/gallium/auxiliary/util/u_pstipple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_pstipple.c b/src/gallium/auxiliary/util/u_pstipple.c index ae4cfa1d76..77b0458dc0 100644 --- a

[Mesa-dev] [PATCH 06/23] gallium/aux/util/u_format.c: Fix one -Wunused-param warning

This warning was issued only in release mode. Fix it by fake-using the parameter. --- src/gallium/auxiliary/util/u_format.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/util/u_format.c b/src/gallium/auxiliary/util/u_format.c index 0fc3231654..369b4c3126 100644 --- a

[Mesa-dev] [PATCH 01/23] gallium/aux/util/u_blitter.c: Silence some warnings

* Annotate three parameters that are not used in release mode. * explicitely convert an int to unsigned in an ?: construct. --- src/gallium/auxiliary/util/u_blitter.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/galliu

[Mesa-dev] [PATCH 04/23] gallium/aux/util/u_dump_defines.c: Fix -Wsign-compare warning

u_bit_scan may return -1 that then may be interpreted as (unsigned)-1 in the following comparison, since num_names is unsigned. Convert the latter to be int as well. --- src/gallium/auxiliary/util/u_dump_defines.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxi

[Mesa-dev] [PATCH 08/23] gallium/aux/util/u_format_latc.c: Fix various -Wunused-param warnings,

Decorate the unused params with "UNUSED". --- src/gallium/auxiliary/util/u_format_latc.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_latc.c b/src/gallium/auxiliary/util/u_format_latc.c index 31d72b5a0a..ce693713

[Mesa-dev] [PATCH 03/23] gallium/aux/util/u_debug_stack.c: Silence -Wunused-result warning

asprintf is decorated with the attrbute "warn_unused_result", and if the function call fails, the pointer "temp" will be undefined, but since it is used later it should contain some usable value. Test return value of asprintf and assign some save value to "temp" if the call failed. --- src/gallium

[Mesa-dev] [PATCH 07/23] gallium/aux/util/u_format_etc.c: Fix eight -Wunused-param warnings

Decorate the parameters accordingly with "UNUSED". --- src/gallium/auxiliary/util/u_format_etc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_etc.c b/src/gallium/auxiliary/util/u_format_etc.c index 63e03ff5cc..8da933cf3d 100644 --

[Mesa-dev] [PATCH 02/23] gallium/aux/util/u_debug_describe.c: Silence an -Wunused-param warning

* Annotate the unused parameter. --- src/gallium/auxiliary/util/u_debug_describe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_debug_describe.c b/src/gallium/auxiliary/util/u_debug_describe.c index f428d22d20..9a8e0cc392 100644 --- a/src/galliu

[Mesa-dev] [PATCH 05/23] gallium/aux/util/u_dump_state.c: Fix two -Wunused-paramter warnings

--- src/gallium/auxiliary/util/u_dump_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_dump_state.c b/src/gallium/auxiliary/util/u_dump_state.c index 2725d50cd9..512fb677d3 100644 --- a/src/gallium/auxiliary/util/u_dump_state.c +++ b/src

[Mesa-dev] [PATCH 00/23] Silence some warnings that show up when compiling gallium/aux/util

Hello all, this might be a bit over-zealos, but I usually prefer to compile with -Wall -Wextra, and with mesa this gives many warnings. This series silences most of the warnings that are issued when compiling the C files in gallium/aux/util. Most fixes relate to -Wunused-param and are silenc

Re: [Mesa-dev] [PATCH 11/11] intel/tools/error: Decode compute shaders.

On 12/11/17 08:35, Kenneth Graunke wrote: This is a bit more annoying than your average shader - we need to look at MEDIA_INTERFACE_DESCRIPTOR_LOAD in the batch buffer, then hop over to the dynamic state buffer to read the INTERFACE_DESCRIPTOR_DATA, then hop over to the instruction buffer to deco

Re: [Mesa-dev] [PATCH 10/11] intel/tools/error: Use do-while for field iterator loops.

I think I sneaked the exact same fix in f5e5ca1e210c2e0f505ea154ca553275157dda73 (bottom of the patch). Reviewed-by: Lionel Landwerlin On 12/11/17 08:35, Kenneth Graunke wrote: while loops skip the first field of the instruction/structure, which is not what the code intended. It works out be

Re: [Mesa-dev] [PATCH 09/11] intel/tools/error: Decode shaders while decoding batch commands.

On 12/11/17 08:35, Kenneth Graunke wrote: This makes aubinator_error_decode's shader dumping work like aubinator. Instead of printing them after the fact, it prints them right inside the 3DSTATE_VS/HS/DS/GS/PS packet that references them. This saves you the effort of cross-referencing things and

[Mesa-dev] [Bug 103697] [regression] shared memory size 64k -> 32k?

https://bugs.freedesktop.org/show_bug.cgi?id=103697 Bug ID: 103697 Summary: [regression] shared memory size 64k -> 32k? Product: Mesa Version: 17.3 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Seve

Re: [Mesa-dev] [PATCH] aubinator: Don't skip the first field in each subgroup

On 12/11/17 05:45, Jason Ekstrand wrote: The previous iteration algorithm would advance the field pointer right after we advance the group. This meant that you would end up with skipping the first field of the group. In the common case, where the only field is a struct (e.g. 3DSTATE_VERTEX_BUFF

Re: [Mesa-dev] [PATCH 09/11] intel/tools/error: Decode shaders while decoding batch commands.

Quoting Kenneth Graunke (2017-11-12 08:35:10) > This makes aubinator_error_decode's shader dumping work like aubinator. > Instead of printing them after the fact, it prints them right inside the > 3DSTATE_VS/HS/DS/GS/PS packet that references them. This saves you the > effort of cross-referencing

Re: [Mesa-dev] [PATCH 08/11] intel/tools/error: Save error state sections and decode them later.

Quoting Kenneth Graunke (2017-11-12 08:35:09) > This lets us complete parsing and storing of each buffer's data before > we begin decoding the batchbuffer. This makes it possible to inspect > the state buffer and program buffer, so we can properly decode any > indirect state or shader programs. A

Re: [Mesa-dev] [PATCH 07/11] intel/tools/error: Fix null termination of ring name string.

Quoting Kenneth Graunke (2017-11-12 08:35:08) > Ported from intel_error_decode. We don't want to run off the end. Should never happen, but C and strings deserve healthy paranoia. Reviewed-by: Chris Wilson -Chris ___ mesa-dev mailing list mesa-dev@list

Re: [Mesa-dev] [PATCH 06/11] intel/tools/error: Drop unused MAX_RINGS #define.

Quoting Kenneth Graunke (2017-11-12 08:35:07) > Dead code. Reviewed-by: Chris Wilson -Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/11] intel/tools/error: Refactor buffer matching, add more buffers.

Quoting Kenneth Graunke (2017-11-12 08:35:06) > Based on a similar patch to intel_error_decode by Chris Wilson. > > While we're de-duplicating the gtt_offset calculation, we can simplify > it to assume two hex digits are there - the kernel has done this since > v4.6, and we already require error s

Re: [Mesa-dev] [PATCH 04/11] intel/tools/error: Only decode a few sections of error states.

Quoting Kenneth Graunke (2017-11-12 08:35:05) > These three are the only we can reasonably decode with genxml. Makes sense, I would recommend putting those into an array for ease of future expansion. Maybe also strcasecmp? Reviewed-by: Chris Wilson (Note to self, aubinator will be specialiased f

Re: [Mesa-dev] [PATCH 03/11] intel/tools/error: Drop unused parameters from decode() helper.

Quoting Kenneth Graunke (2017-11-12 08:35:04) > Also change count from a pointer into a value. We were supposed to > be resetting it to 0 (and failed to), but that's gone since we dropped > the pre-ascii85 handling. Reviewed-by: Chris Wilson -Chris ___

Re: [Mesa-dev] [PATCH 02/11] intel/tools/error: Drop support for non-ascii85 encoded error states.

Quoting Kenneth Graunke (2017-11-12 08:35:03) > Error state files used to look like: > >render ring --- gtt_offset = 0x0e8f6000 > : 6904 >0004 : 7909 >... >7ffc : >--- ringbuffer = 0x1000 > > There were thousands of lines between sec

Re: [Mesa-dev] [PATCH 01/11] intel/tools/error: Do ascii85 decode first.

Quoting Kenneth Graunke (2017-11-12 08:35:02) > The dashes "---" may occur within an ascii85 block, but only an ascii85 > block starts with ':' or '~'. > > Ported from Chris Wilson's intel-gpu-tools commit: > bceec7e1d8a160226b783c6344eae8cbf4ece144 Reviewed-by: Chris Wilson -Chris __

Re: [Mesa-dev] [PATCH 00/11] Make aubinator_error_decode support extra buffers

Quoting Kenneth Graunke (2017-11-12 08:35:01) > The only downside - and it's a pretty major one - is that I eliminated > support for error states generated on pre-4.10 kernels. The code to > handle that was already a giant mess, and I wasn't sure how to do this > rework without making it even more

Re: [Mesa-dev] [PATCH 02/11] intel/tools/error: Drop support for non-ascii85 encoded error states.

Quoting Kenneth Graunke (2017-11-12 08:35:03) > Error state files used to look like: > >render ring --- gtt_offset = 0x0e8f6000 > : 6904 >0004 : 7909 >... >7ffc : >--- ringbuffer = 0x1000 > > There were thousands of lines between sec

Re: [Mesa-dev] [PATCH] egl: EXT_pixel_format_float plumbing

Hi; On 11/09/2017 07:03 PM, Eric Engestrom wrote: On Thursday, 2017-11-09 09:40:43 +0200, Tapani Pälli wrote: Patch adds support and capability to match with new surface attribute, component type. Currently no configs with floating point type are exposed. Have you tested android O with this p

Re: [Mesa-dev] [PATCH 2/2] intel/tools: Fix program disassembly in aubinator_error_decode.

On Saturday, November 11, 2017 3:35:21 PM PST Lionel Landwerlin wrote: > :( > > The intention was to deal with cases where we've encountered more than > MAX_NUM_PROGRAMS (actually happened to me). > So we start by the index + 1 assuming this is the oldest program because > we're in a rolling win

[Mesa-dev] [PATCH 10/11] intel/tools/error: Use do-while for field iterator loops.

while loops skip the first field of the instruction/structure, which is not what the code intended. It works out because the field we're looking for doesn't happen to be first, but we ought to do it right regardless. Found while writing the next patch, where Kernel Start Pointer is the first fiel

[Mesa-dev] [PATCH 11/11] intel/tools/error: Decode compute shaders.

This is a bit more annoying than your average shader - we need to look at MEDIA_INTERFACE_DESCRIPTOR_LOAD in the batch buffer, then hop over to the dynamic state buffer to read the INTERFACE_DESCRIPTOR_DATA, then hop over to the instruction buffer to decode the program. Now that we store all the b

[Mesa-dev] [PATCH 09/11] intel/tools/error: Decode shaders while decoding batch commands.

This makes aubinator_error_decode's shader dumping work like aubinator. Instead of printing them after the fact, it prints them right inside the 3DSTATE_VS/HS/DS/GS/PS packet that references them. This saves you the effort of cross-referencing things and jumping back and forth. It also reduces a

[Mesa-dev] [PATCH 08/11] intel/tools/error: Save error state sections and decode them later.

This lets us complete parsing and storing of each buffer's data before we begin decoding the batchbuffer. This makes it possible to inspect the state buffer and program buffer, so we can properly decode any indirect state or shader programs. --- src/intel/tools/aubinator_error_decode.c | 95 +

[Mesa-dev] [PATCH 01/11] intel/tools/error: Do ascii85 decode first.

The dashes "---" may occur within an ascii85 block, but only an ascii85 block starts with ':' or '~'. Ported from Chris Wilson's intel-gpu-tools commit: bceec7e1d8a160226b783c6344eae8cbf4ece144 --- src/intel/tools/aubinator_error_decode.c | 60 +++- 1 file changed, 29

[Mesa-dev] [PATCH 07/11] intel/tools/error: Fix null termination of ring name string.

Ported from intel_error_decode. We don't want to run off the end. --- src/intel/tools/aubinator_error_decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c index 9cd0fa761dd..f9d14cc20d5 100644 --- a/src/i

[Mesa-dev] [PATCH 05/11] intel/tools/error: Refactor buffer matching, add more buffers.

Based on a similar patch to intel_error_decode by Chris Wilson. While we're de-duplicating the gtt_offset calculation, we can simplify it to assume two hex digits are there - the kernel has done this since v4.6, and we already require error states from v4.10. --- src/intel/tools/aubinator_error_d

[Mesa-dev] [PATCH 03/11] intel/tools/error: Drop unused parameters from decode() helper.

Also change count from a pointer into a value. We were supposed to be resetting it to 0 (and failed to), but that's gone since we dropped the pre-ascii85 handling. --- src/intel/tools/aubinator_error_decode.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/to

[Mesa-dev] [PATCH 06/11] intel/tools/error: Drop unused MAX_RINGS #define.

Dead code. --- src/intel/tools/aubinator_error_decode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c index 0b0a308a317..9cd0fa761dd 100644 --- a/src/intel/tools/aubinator_error_decode.c +++ b/src/intel/too

[Mesa-dev] [PATCH 00/11] Make aubinator_error_decode support extra buffers

Hello, This series does a pretty substantial rework of aubinator_error_decode (the new error state decoder). The first few patches fix a whole bunch of bugs in the decoding, where we parsed the file wrong, decoded the wrong data in the wrong places, or decoded non-batch data as commands (generall

[Mesa-dev] [PATCH 02/11] intel/tools/error: Drop support for non-ascii85 encoded error states.

Error state files used to look like: render ring --- gtt_offset = 0x0e8f6000 : 6904 0004 : 7909 ... 7ffc : --- ringbuffer = 0x1000 There were thousands of lines between sections. The file format changed with Kernel 4.10, and now has a si

[Mesa-dev] [PATCH 04/11] intel/tools/error: Only decode a few sections of error states.

These three are the only we can reasonably decode with genxml. --- src/intel/tools/aubinator_error_decode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c index 94436e957d4..ae9f08f1d2b 100

[Mesa-dev] [AppVeyor] mesa master #6126 failed

Build mesa 6126 failed Commit 9a0465b3a3 by Kenneth Graunke on 11/10/2017 11:36 PM: intel/tools: Fix detection of enabled shader stages.\n\nWe renamed "Function Enable" to "Enable", which broke our detection\nof whether shaders are enabled or not. So, we'd see