Re: [Mesa-dev] [PATCH 4/5] egl/wayland: move teardown code to the platform file

Hey Emil, this commit breaks mesa pretty badly, wflinfo segfaults: 40a01c9a0ef2c8110d79c284976ef34c0f73be92 is the first bad commit commit 40a01c9a0ef2c8110d79c284976ef34c0f73be92 Author: Emil Velikov Date: Thu Nov 9 19:04:25 2017 + egl/drm: move teardown

[Mesa-dev] [PATCH 2/2] egl: Express eglGetDisplay in terms of _eglGetPlatformDisplayCommon

The latter is now the one place where we initialize an _EGLDisplay. Signed-off-by: Adam Jackson --- src/egl/main/eglapi.c | 67 ++- 1 file changed, 45 insertions(+), 22 deletions(-) diff --git a/src/egl/main/eglapi.c

[Mesa-dev] [PATCH 1/2] egl: Convert int to attrib in eglGetPlatformDisplay

... because converting attrib to int truncates, and that's bad. Signed-off-by: Adam Jackson --- src/egl/main/eglapi.c | 29 ++--- src/egl/main/egldisplay.c | 15 --- src/egl/main/egldisplay.h | 8 3 files changed, 26

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

On Thu, Nov 16, 2017 at 12:26:05PM -0500, Ilia Mirkin wrote: > On Thu, Nov 16, 2017 at 7:15 AM, Wladimir wrote: > The point of the texcoord semantics is precisely point sprite > replacement. NVIDIA hardware (Fermi+) can only do point sprite > replacement on certain

[Mesa-dev] [PATCH] util: add new ASSERT_BITFIELD_SIZE() macro (v3)

For checking that bitfields are large enough to hold the largest expected value. v2: move into existing util/macros.h header where STATIC_ASSERT() lives. v3: add MAYBE_UNUSED to variable declaration --- src/util/macros.h | 17 + 1 file changed, 17 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] genxml: Fix PIPELINE_SELECT on G45/Ironlake.

We've establish over IRC that I was confused by the documentation (also some of it isn't accurate :( ) On 16/11/17 08:36, Kenneth Graunke wrote: Original 965 sets bits 28:27 to 0, while G45 and later set it to 1. Also, there's no GPGPU pipeline on Gen5, and the pipeline to select is a single

[Mesa-dev] [PATCH mesa v3] REVIEWERS: add Jérôme & Alexander as a reviewer for Haiku files

There's been some Haiku-related activity lately, so let's document who to cc on these patches. Cc: Jérôme Duval Signed-off-by: Eric Engestrom Acked-by: Alexander von Gluck IV --- Jérôme, are you ok with that? "ack" to

Re: [Mesa-dev] [PATCH mesa v2] REVIEWERS: add Jérôme & Alexander as a reviewer for Haiku files

On Thursday, 2017-11-16 11:05:27 -0600, kallisti5 wrote: > On 2017-11-16 10:18, Eric Engestrom wrote: > > Cc: Alexander von Gluck IV > > Cc: Jérôme Duval > > Signed-off-by: Eric Engestrom > > --- > > There's been some

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

On Thu, Nov 16, 2017 at 7:15 AM, Wladimir wrote: >> I think it would be reasonable to re-emit the shader state (or maybe >> just the varyings) when the primitive type changes from points to >> non-points. It virtually never happens that the same shader combo is >> used for

Re: [Mesa-dev] [PATCH] genxml: Fix PIPELINE_SELECT on G45/Ironlake.

On 16/11/17 08:36, Kenneth Graunke wrote: Original 965 sets bits 28:27 to 0, while G45 and later set it to 1. Also, there's no GPGPU pipeline on Gen5, and the pipeline to select is a single bit - bit 1 is reserved. Are you sure you haven't mixed them? --- src/intel/genxml/gen45.xml | 4

Re: [Mesa-dev] [PATCH v2 17/29] mesa/main/framebuffer.h: Fix one -Wsign-compare warning in ?: construct.

On 16 November 2017 at 15:09, Gert Wollny wrote: > Explicitely convert on value to the target type. > > Signed-off-by: Gert Wollny > Reviewed-by: Brian Paul > --- > src/mesa/main/framebuffer.h | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH mesa v2] REVIEWERS: add Jérôme & Alexander as a reviewer for Haiku files

On 2017-11-16 10:18, Eric Engestrom wrote: Cc: Alexander von Gluck IV Cc: Jérôme Duval Signed-off-by: Eric Engestrom --- There's been some Haiku-related activity lately, so let's document who to cc on these patches.

Re: [Mesa-dev] [PATCH v2] mesa/teximage: add TEXTURE_CUBE_MAP_ARRAY target for CompressedTexImage3D

On Wed, Nov 15, 2017 at 05:56:00PM -0500, Ilia Mirkin wrote: > On Wed, Nov 15, 2017 at 5:49 PM, Nanley Chery wrote: > > On Wed, Nov 15, 2017 at 12:08:58PM -0500, Ilia Mirkin wrote: > >> On Wed, Nov 15, 2017 at 11:54 AM, Juan A. Suarez Romero > >>

Re: [Mesa-dev] [PATCH v3] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

The problem that I’m seeing with timespec_get is that centos6 does not have it. I’ve put some changes out for review that actually remove timespec_get() in favor of using a variation of os_time_get_nano(). It’s good to always use the same time functions, and not have multiple ways of doing

[Mesa-dev] [PATCH 1/2] util: Remove dependency on gallium header file

Do not depend on gallium/include/pipe/p_config.h for PIPE_OS_* defines. Use standard OS defines instead. --- src/util/os_time.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/src/util/os_time.c b/src/util/os_time.c index 72dc7e4..1c34bfd 100644 ---

Re: [Mesa-dev] [PATCH v2 29/29] gallium/aux/util/u_tests.c: Fix warnigns triggered -Wmissing-field-initializers

On 16 November 2017 at 15:10, Gert Wollny wrote: > * Use a designated initializer to silence the warning. > * fix one intention that was using tabs instead of spaces > Sigh, -Wmissing-field-initalizers warnings - it's perhaps the most annoying and inconsistent warning I've

[Mesa-dev] [AppVeyor] mesa master #6178 completed

Build mesa 6178 completed Commit d25123e23a by Kai Wasserbäch on 11/16/2017 11:58 AM: docs: Point to apt.llvm.org for development snapshot packages\n\nSigned-off-by: Kai Wasserbäch \nReviewed-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] docs: Point to apt.llvm.org for development snapshot packages

On Thursday, 2017-11-16 13:49:43 +0100, Kai Wasserbäch wrote: > Can you push for me? I don't have access. Sure, just did :) You currently have 36 commits in mesa, that's enough to request an account [1], if you'd like :) [1] https://www.freedesktop.org/wiki/AccountRequests/ > > Eric Engestrom

[Mesa-dev] [PATCH mesa v2] REVIEWERS: add Jérôme & Alexander as a reviewer for Haiku files

Cc: Alexander von Gluck IV Cc: Jérôme Duval Signed-off-by: Eric Engestrom --- There's been some Haiku-related activity lately, so let's document who to cc on these patches. Jérôme, Alexander, are you ok with that? "ack"

Re: [Mesa-dev] [PATCH 3/3] RFC: vulkan/wsi: Rework the way prime support works

On Thu, Nov 16, 2017 at 3:47 AM, Mike Lothian wrote: > Will this allow us to select between iGPU and dGPU like we can with > OpenGL? Or is it just going to force radv like before? > I don't think we have a good selection method yet. > On Thu, 16 Nov 2017 at 10:09

Re: [Mesa-dev] [PATCH] i915: add missing extensions.h include

On 16 November 2017 at 15:55, Emil Velikov wrote: > From: Emil Velikov > > Otherwise we'll bail with due to -Werror=implicit-function-declaration. > It went unnoticed since the we had a bug which did consistently set the > compiler flag. > >

[Mesa-dev] [PATCH 1/2] util: Remove dependency on gallium header file

Do not depend on gallium/include/pipe/p_config.h for PIPE_OS_* defines. Use standard OS defines instead. --- src/util/os_time.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/src/util/os_time.c b/src/util/os_time.c index 72dc7e4..1c34bfd 100644 ---

Re: [Mesa-dev] [PATCH] i915: add missing extensions.h include

Reviewed-by: Marek Olšák Marek On Thu, Nov 16, 2017 at 4:55 PM, Emil Velikov wrote: > From: Emil Velikov > > Otherwise we'll bail with due to -Werror=implicit-function-declaration. > It went unnoticed since the we had

Re: [Mesa-dev] [PATCH mesa] REVIEWERS: add Jérôme Duval as a reviewer for Haiku files

On 16 November 2017 at 16:03, Eric Engestrom wrote: > Cc: Jérôme Duval > Signed-off-by: Eric Engestrom > --- > There's been some Haiku-related activity lately, so let's document who > to cc on these patches. > Jérôme,

Re: [Mesa-dev] [PATCH v2 29/29] gallium/aux/util/u_tests.c: Fix warnigns triggered -Wmissing-field-initializers

In the subject "warnings" I can fix that before pushing. For the series, Reviewed-by: Brian Paul On 11/16/2017 08:10 AM, Gert Wollny wrote: * Use a designated initializer to silence the warning. * fix one intention that was using tabs instead of spaces Signed-off-by:

[Mesa-dev] [PATCH mesa] REVIEWERS: add Jérôme Duval as a reviewer for Haiku files

Cc: Jérôme Duval Signed-off-by: Eric Engestrom --- There's been some Haiku-related activity lately, so let's document who to cc on these patches. Jérôme, are you ok with that? "ack" to make it formal :) --- REVIEWERS | 9 + 1 file

Re: [Mesa-dev] [PATCH] i915: add missing extensions.h include

This is: Reviewed-by: Andres Gomez On Thu, 2017-11-16 at 15:55 +, Emil Velikov wrote: > From: Emil Velikov > > Otherwise we'll bail with due to -Werror=implicit-function-declaration. > It went unnoticed since the we had a bug which did

[Mesa-dev] [PATCH] i915: add missing extensions.h include

From: Emil Velikov Otherwise we'll bail with due to -Werror=implicit-function-declaration. It went unnoticed since the we had a bug which did consistently set the compiler flag. Cc: Marek Olšák Fixes: ba8a347f932 ("mesa: split extensions overrides

Re: [Mesa-dev] [AppVeyor] mesa master #6163 failed

On Thursday, 2017-11-16 14:20:03 +, Jose Fonseca wrote: > On 16/11/17 14:08, Jose Fonseca wrote: > > On 15/11/17 12:20, Eric Engestrom wrote: > > > On Wednesday, 2017-11-15 10:35:04 +, Jose Fonseca wrote: > > > > I could post a remark on AppVeyor's forums, but it sounds from the > > > >

Re: [Mesa-dev] [PATCH] mesa: document _mesa_extension_override_* variables

This is: Reviewed-by: Andres Gomez On Thu, 2017-11-16 at 14:22 +, Emil Velikov wrote: > From: Emil Velikov > > Currently there are no users of these outside of extensions.c. > Provide some information why they exist and how to use them. > >

[Mesa-dev] [PATCH v4] egl/wayland: Support for KHR_partial_update

This passes 33/37 deqp tests related to partial_update, 4 are not supported. Tests not supported: dEQP-EGL.functional.negative_partial_update.not_postable_surface dEQP-EGL.functional.negative_partial_update.not_current_surface dEQP-EGL.functional.negative_partial_update.buffer_preserved

Re: [Mesa-dev] [PATCH 10/24] spirv_extensions: add GL_ARB_spirv_extensions boilerplate

Hi Eduardo, On 15 November 2017 at 13:22, Eduardo Lima Mitev wrote: > --- a/src/mapi/glapi/gen/gl_API.xml > +++ b/src/mapi/glapi/gen/gl_API.xml > @@ -8404,6 +8404,8 @@ > > xmlns:xi="http://www.w3.org/2001/XInclude"/> > Nit: Please mention the gap here - 191-193 > +

[Mesa-dev] [PATCH v2 28/29] gallium/aux/util/u_surface.c: Silence warnings and remove unneeded MAYBE_UNUSED

* Explicitely convert values to int in comparison. * Remove one MAYBE_UNUSED that is actually not needed. Signed-off-by: Gert Wollny --- src/gallium/auxiliary/util/u_surface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH v2 17/29] mesa/main/framebuffer.h: Fix one -Wsign-compare warning in ?: construct.

Explicitely convert on value to the target type. Signed-off-by: Gert Wollny Reviewed-by: Brian Paul --- src/mesa/main/framebuffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/framebuffer.h

[Mesa-dev] [PATCH v2 25/29] gallium/aux/util/u_debug.c: Silence warnings -Wunused-param

Silence warnings by decoration the parameters with UNUSED. Signed-off-by: Gert Wollny --- src/gallium/auxiliary/util/u_debug.c | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/src/gallium/auxiliary/util/u_debug.c

[Mesa-dev] [PATCH v2 26/29] gallium/aux/util/u_debug_flush.c: Silence warnings -Wunused-param

Decorate the unused parameters with UNUSED. Signed-off-by: Gert Wollny --- src/gallium/auxiliary/util/u_debug_flush.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_debug_flush.c

[Mesa-dev] [PATCH v2 22/29] gallium/aux/os/os_thread.h: Silence -Wunused-param.

With --disable-debug a parameter is not used. Silence this warning by fake-using it. Signed-off-by: Gert Wollny Reviewed-by: Brian Paul --- src/gallium/auxiliary/os/os_thread.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH v2 16/29] gallium/aux/util/u_transfer.c: Fix some -Wunused-param warnings.

Decorate the params with "UNUSED" accordingly. v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_transfer.c | 20 ++-- 1 file changed,

[Mesa-dev] [PATCH v2 27/29] gallium/aux/util/u_debug_image.c: Silence warnings -Wunused-param

Decorate the according parameters with UNUSED. Signed-off-by: Gert Wollny --- src/gallium/auxiliary/util/u_debug_image.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_debug_image.c

[Mesa-dev] [PATCH v2 29/29] gallium/aux/util/u_tests.c: Fix warnigns triggered -Wmissing-field-initializers

* Use a designated initializer to silence the warning. * fix one intention that was using tabs instead of spaces Signed-off-by: Gert Wollny --- src/gallium/auxiliary/util/u_tests.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH v2 24/29] gallium/aux/util/u_format_table.py: Add UNUSED decoration to the generated function headers

Signed-off-by: Gert Wollny --- src/gallium/auxiliary/util/u_format_pack.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_format_pack.py b/src/gallium/auxiliary/util/u_format_pack.py index a2327196e6..c9b8cd7abc 100644 ---

[Mesa-dev] [PATCH v2 19/29] src/util/simple_mtx.h: Fix two -Wunused-param warnings.

Decorate the parameters accordingly with "UNUSED" or "MAYBE_UNUSED" (for the param that is used in debug mode, but not in release mode). v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul

[Mesa-dev] [PATCH v2 15/29] gallium/aux/util/u_threaded_context.c: Fix some -Wunused-param warnings.

Decorate the params accordingly with UNUSED or MAYBE_UNUSED (for params that are used in debug mode). v2: move *UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) ---

[Mesa-dev] [PATCH v2 23/29] gallium/aux/util/u_async_debug.c: Fix -Wtype-limits warning.

Use size_t instread of unsigned for new_max. realloc later expects size_t as parameter anyway. Signed-off-by: Gert Wollny Reviewed-by: Brian Paul --- src/gallium/auxiliary/util/u_async_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH v2 18/29] mesa/main/texcompress_s3tc_tmp.h: Fix two -Wparam-unused warnings.

Decorate the params accordingly with "UNUSED". v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/mesa/main/texcompress_s3tc_tmp.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[Mesa-dev] [PATCH v2 20/29] gallium/aux/util/u_blit.c: Fix -Wunused-param warnings

Annotate the parameters accordingly. v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny v1: Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH v2 21/29] gallium/aux/util/u_debug_refcnt.h: Fix -Wunused-param warnings

Annotate the according parameters accordingly. v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_debug_refcnt.h | 4 ++-- 1 file changed, 2

[Mesa-dev] [PATCH v2 14/29] gallium/aux/util/u_surface.c: Silence a -Wsign-compare warning.

Explicitely convert one value to compare. Signed-off-by: Gert Wollny Reviewed-by: Brian Paul --- src/gallium/auxiliary/util/u_surface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_surface.c

[Mesa-dev] [PATCH v2 13/29] gallium/aux/util/u_pstipple.c: Fix one -Wsign-compare warning in ?: construct.

Silence the warning by making the conversion to int explicit. Signed-off-by: Gert Wollny Reviewed-by: Brian Paul --- src/gallium/auxiliary/util/u_pstipple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2 12/29] gallium/aux/util/u_mm.c: Fix one -Wparam-unused warning.

Decorate the unused param accordingly with "UNUSED". v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_mm.c | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH v2 02/29] gallium/aux/util/u_debug_describe.c: Silence an -Wunused-param warning

Annotate the unused parameter. v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_debug_describe.c | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH v2 03/29] gallium/aux/util/u_debug_stack.c: Silence -Wunused-result warning

asprintf is decorated with the attrbute "warn_unused_result", and if the function call fails, the pointer "temp" will be undefined, but since it is used later it should contain some usable value. Test return value of asprintf and assign some save value to "temp" if the call failed. Signed-off-by:

[Mesa-dev] [PATCH v2 09/29] gallium/aux/util/u_format_other.c: Fix various -Wunused-param warnings

Decorate the unused params with "UNUSED". v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_format_other.c | 34 ++--- 1 file

[Mesa-dev] [PATCH v2 01/29] gallium/aux/util/u_blitter.c: Silence some warnings

* Annotate three parameters that are not used in release mode. * explicitely convert an int to unsigned in an ?: construct. v2: move MAYBE_UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) ---

[Mesa-dev] [PATCH v2 11/29] gallium/aux/util/u_format_yuv.c: Fix a number of -Wunused-param warnings.

Decorate the params accordingly with "UNUSED". v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_format_yuv.c | 232 +++--- 1

[Mesa-dev] [PATCH v2 07/29] gallium/aux/util/u_format_etc.c: Fix eight -Wunused-param warnings (v2)

Decorate the parameters accordingly with "UNUSED". v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_format_etc.c | 8 ++-- 1 file changed, 6

[Mesa-dev] [PATCH v2 06/29] gallium/aux/util/u_format.c: Fix one -Wunused-param warning

This warning was issued only in release mode. Fix it by fake-using the parameter. Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_format.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH v2 05/29] gallium/aux/util/u_dump_state.c: Fix two -Wunused-paramter warnings

v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_dump_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v2 10/29] gallium/aux/util/u_format_rgtc.c: Fix a number of -Wunused-param warnings

Decorate the params accordingly with "UNUSED". v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_format_rgtc.c | 68 +- 1

[Mesa-dev] [PATCH v2 04/29] gallium/aux/util/u_dump_defines.c: Fix -Wcompare-unsigned warning

u_bit_scan may return -1 that then may be interpreted as (unsigned)-1 in the following comparison, since num_names is unsigned. Convert the latter to be int as well. Signed-off-by: Gert Wollny Reviewed-by: Brian Paul ---

[Mesa-dev] [PATCH v2 00/29] Silence some warnings that show up when compiling gallium/aux/util

Dear all, I've cleaned up the patch according to Brian's and Emil's pointers. I tried to keep close to the original formatting, unless the original lines were overly long (+90 chars on a line). I think keeping the 78 columns limit like suggested by Brian makes the code look a bit too ugly at

[Mesa-dev] [PATCH v2 08/29] gallium/aux/util/u_format_latc.c: Fix various -Wunused-param warnings, (v2)

Decorate the unused params with "UNUSED". v2: move UNUSED decoration in front of parameter declaration Signed-off-by: Gert Wollny Reviewed-by: Brian Paul (v1) --- src/gallium/auxiliary/util/u_format_latc.c | 24 +--- 1 file

Re: [Mesa-dev] [PATCH v3] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

On 15 November 2017 at 20:58, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Tested with Travis and Appveyor. > > v2: add HAVE_TIMESPEC_GET for non-Windows Scons builds > v3: use check_functions in Scons (Eric) > > Cc: Rob Herring

Re: [Mesa-dev] [PATCH v3 09/15] meson: extend install_megadrivers script to handle symmlinking

On 14 November 2017 at 22:05, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-14 06:47:33) >> On Monday, 2017-11-13 17:09:13 -0800, Dylan Baker wrote: >> > which is required for the gallium media state trackers. >> > --- >> > bin/install_megadrivers.py | 6 ++ >> >

Re: [Mesa-dev] [PATCH v3 07/15] autotools: set XA versions in configure.ac and configure header file

On 14 November 2017 at 01:09, Dylan Baker wrote: > -AC_SUBST([XA_VERSION], "$XA_MAJOR.$XA_MINOR.$XA_TINY") > +AC_SUBST([XA_VERSION], "$XA_MAJOR.$XA_MINOR.$XA_PATCH") > This was meant to be be part of 08/15. With that 7 and 8 are Reviewed-by: Emil Velikov

[Mesa-dev] [PATCH] mesa: document _mesa_extension_override_* variables

From: Emil Velikov Currently there are no users of these outside of extensions.c. Provide some information why they exist and how to use them. Cc: Jordan Justen Signed-off-by: Emil Velikov ---

Re: [Mesa-dev] [PATCH mesa] egl: fix var type

On 2017-11-16 04:16 AM, Eric Engestrom wrote: queryImage() takes an `int*`, compiler is warning about the signed<->unsigned pointer mismatch. Fixes: 0db36caa192b129cb4f2 "egl/wayland: Add a fallback when fourcc query isn't supported" Signed-off-by: Eric Engestrom

Re: [Mesa-dev] [AppVeyor] mesa master #6163 failed

On 16/11/17 14:08, Jose Fonseca wrote: On 15/11/17 12:20, Eric Engestrom wrote: On Wednesday, 2017-11-15 10:35:04 +, Jose Fonseca wrote: I could post a remark on AppVeyor's forums, but it sounds from the logs the issue could be on our (freedesktop.org's) side. I've reconfigured AppVeyor

Re: [Mesa-dev] [AppVeyor] mesa master #6163 failed

On 15/11/17 12:20, Eric Engestrom wrote: On Wednesday, 2017-11-15 10:35:04 +, Jose Fonseca wrote: I could post a remark on AppVeyor's forums, but it sounds from the logs the issue could be on our (freedesktop.org's) side. I've reconfigured AppVeyor to use

[Mesa-dev] [AppVeyor] mesa master #6175 completed

Build mesa 6175 completed Commit 8ceccbf80d by Jon Turney on 11/13/2017 10:13 AM: meson: Don't define HAVE_PTHREAD only on linux\n\nI'm not sure of the reason for this. I don't see anything like this in\nconfigure.ac\n\nIn include/c11/threads.h the cases

[Mesa-dev] [AppVeyor] mesa master #6174 failed

Build mesa 6174 failed Commit ff018a3f55 by Rob Clark on 11/16/2017 1:37 PM: freedreno: also mark images used by draw/grid\n\nSigned-off-by: Rob Clark Configure your notification preferences

Re: [Mesa-dev] [PATCH] vulkan/wsi: use function ptr definitions from the spec.

On Thursday, 2017-11-16 08:46:41 +1000, Dave Airlie wrote: > From: Dave Airlie > > This just seems cleaner, and we may expand this in future. > > Signed-off-by: Dave Airlie Reviewed-by: Eric Engestrom > --- >

Re: [Mesa-dev] [PATCH 3/4] meson: Fix TODO for missing dl_iterate_phdr function

On 16 November 2017 at 01:11, Dylan Baker wrote: > This function is required for both the Intel "Anvil" vulkan driver and > the i965 GL driver. Error out if either of those is enabled but this > function isn't found. > > Signed-off-by: Dylan Baker >

Re: [Mesa-dev] [PATCH] docs: Point to apt.llvm.org for development snapshot packages

Can you push for me? I don't have access. Eric Engestrom wrote on 16.11.2017 13:04: > On Thursday, 2017-11-16 12:58:50 +0100, Kai Wasserbäch wrote: >> Cc: Eric Engestrom > > Thanks! > Reviewed-by: Eric Engestrom > >> Signed-off-by: Kai

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

> I think it would be reasonable to re-emit the shader state (or maybe > just the varyings) when the primitive type changes from points to > non-points. It virtually never happens that the same shader combo is > used for points and non-points. Thinking about it, this might even simplify some

Re: [Mesa-dev] [PATCH] docs: Point to apt.llvm.org for development snapshot packages

On Thursday, 2017-11-16 12:58:50 +0100, Kai Wasserbäch wrote: > Cc: Eric Engestrom Thanks! Reviewed-by: Eric Engestrom > Signed-off-by: Kai Wasserbäch > --- > docs/llvmpipe.html | 6 ++ > 1 file changed, 6

[Mesa-dev] [PATCH] docs: Point to apt.llvm.org for development snapshot packages

Cc: Eric Engestrom Signed-off-by: Kai Wasserbäch --- docs/llvmpipe.html | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html index e4676920ed..12dccb5eae 100644 --- a/docs/llvmpipe.html +++

Re: [Mesa-dev] [PATCH 1/4] meson: Enable SSE4.1 optimizations

On Wednesday, 2017-11-15 17:10:59 -0800, Dylan Baker wrote: > This patch checks for an and then enables sse4.1 optimizations if the > host machine will be x86/x86_64. > > Signed-off-by: Dylan Baker > --- > meson.build | 27 ++- >

Re: [Mesa-dev] [PATCH 3/3] RFC: vulkan/wsi: Rework the way prime support works

Will this allow us to select between iGPU and dGPU like we can with OpenGL? Or is it just going to force radv like before? On Thu, 16 Nov 2017 at 10:09 Grazvydas Ignotas wrote: > On Thu, Nov 16, 2017 at 12:33 AM, Dave Airlie wrote: > > On 15 November 2017

Re: [Mesa-dev] [PATCH 2/4] meson: disable x86 asm in fewer cases.

On Wednesday, 2017-11-15 17:11:00 -0800, Dylan Baker wrote: > This patch allows building asm for x86 on x86_64 platforms, when the > operating system is the same. Previously cross compile always turned off > assembly. This allows using a cross file to cross compile x86 binaries > on x86_64 with

Re: [Mesa-dev] [PATCH mesa] egl: fix var type

On 16 November 2017 at 10:16, Eric Engestrom wrote: > queryImage() takes an `int*`, compiler is warning about the > signed<->unsigned pointer mismatch. > > Fixes: 0db36caa192b129cb4f2 "egl/wayland: Add a fallback when fourcc >query isn't supported" >

Re: [Mesa-dev] [PATCH] util: add new ASSERT_BITFIELD_SIZE() macro (v2)

On Wednesday, 2017-11-15 17:16:52 -0700, Brian Paul wrote: > For checking that bitfields are large enough to hold the largest > expected value. > > v2: move into existing util/macros.h header where STATIC_ASSERT() lives. > --- > src/util/macros.h | 16 > 1 file changed, 16

Re: [Mesa-dev] [PATCH 1/4] meson: Enable SSE4.1 optimizations

Hi Dylan, On 16 November 2017 at 01:10, Dylan Baker wrote: > This patch checks for an and then enables sse4.1 optimizations if the > host machine will be x86/x86_64. > Hell yeah, SSE is coming to town :-) Will this work if the user disables SSE4.1, say via

Re: [Mesa-dev] [PATCH mesa 2/2] egl: drop EGL driver `name`

On 15 November 2017 at 21:13, Eric Engestrom wrote: > On Wednesday, 2017-11-15 16:51:29 +, Kai Wasserbäch wrote: >> I'm still good with this, thanks for reapplying! > > To be clear, is that an ack, or an r-b? :P > For the series: Reviewed-by: Emil Velikov

Re: [Mesa-dev] Has anyone stressed radeonsi memory?

On Wednesday, 2017-11-15 17:39:26 +0100, Kai Wasserbäch wrote: > Hey Matias, > Matias N. Goldberg wrote on 15.11.2017 16:51: > >> Why, doesn't your distro have LLVM development packages? > > They aren't as up to date. Keeping up-to-date with everything mesa needs is > > exhausting. > > I started

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

>> What if the PS doesn't use the point coordinate, e.g. to render solid >> points? >> >> I thought about that, but I don't think it's general enough. >> >> Could we make the blitter label texture coordinates properly? > > We could do that, but still most texcoord varyings from actual GLSL >

Re: [Mesa-dev] [PATCH] genxml: Fix PIPELINE_SELECT on G45/Ironlake.

On 16/11/17 08:36, Kenneth Graunke wrote: Original 965 sets bits 28:27 to 0, while G45 and later set it to 1. Also, there's no GPGPU pipeline on Gen5, and the pipeline to select is a single bit - bit 1 is reserved. Are you sure you haven't mixed them? --- src/intel/genxml/gen45.xml | 4

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

Am Donnerstag, den 16.11.2017, 11:36 +0100 schrieb Wladimir: > On Thu, Nov 16, 2017 at 11:29 AM, Lucas Stach > wrote: > > > Or maybe we can just scan the input > > varyings and if we find a PCOORD varying assume that we are going > > to > > render points, but I don't

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

On Thu, Nov 16, 2017 at 11:29 AM, Lucas Stach wrote: > Or maybe we can just scan the input > varyings and if we find a PCOORD varying assume that we are going to > render points, but I don't know if this assumption holds for all cases. What if the PS doesn't use the

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

Am Mittwoch, den 15.11.2017, 19:55 +0100 schrieb Wladimir J. van der Laan: > > Sorry for noticing before, but this breaks glmark2 texture. I > > didn't > > yet dig into the issue but it's definitely caused by this commit. > > > > To reproduce, simply run > > glmark2-es2-drm -b

Re: [Mesa-dev] [PATCH mesa] egl: fix var type

Reviewed-by: Tapani Pälli On 11/16/2017 12:16 PM, Eric Engestrom wrote: queryImage() takes an `int*`, compiler is warning about the signed<->unsigned pointer mismatch. Fixes: 0db36caa192b129cb4f2 "egl/wayland: Add a fallback when fourcc query isn't supported"

Re: [Mesa-dev] [PATCH mesa] egl: fix var type

Reviewed-by: Frank Binns From: mesa-dev [mesa-dev-boun...@lists.freedesktop.org] on behalf of Eric Engestrom [eric.engest...@imgtec.com] Sent: 16 November 2017 10:16 To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH

[Mesa-dev] [PATCH mesa] egl: fix var type

queryImage() takes an `int*`, compiler is warning about the signed<->unsigned pointer mismatch. Fixes: 0db36caa192b129cb4f2 "egl/wayland: Add a fallback when fourcc query isn't supported" Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_wayland.c

Re: [Mesa-dev] [PATCH 3/3] RFC: vulkan/wsi: Rework the way prime support works

On Thu, Nov 16, 2017 at 12:33 AM, Dave Airlie wrote: > On 15 November 2017 at 04:40, Jason Ekstrand wrote: >> This commit significantly reworks the way prime support works and lets >> us pull it even further into radv. The old mechanism required the >>

Re: [Mesa-dev] [PATCH] radv: inline radv_upload_{compute, graphics}_shader_descriptors()

I suspect this doesn't do what you'd expect. IIRC specifying online in a function in a .c file is pretty much useless because it only changes linking mode, not actually online's it. On 15 Nov 2017 15:43, "Samuel Pitoiset" wrote: > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH] radv: get rid of another api bypass in the wsi code.

This patch doesn't apply with current master. On 11/16/2017 12:11 AM, Dave Airlie wrote: From: Dave Airlie This just uses the vulkan api to get the fd from the memory. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_wsi.c | 14 -- 1

Re: [Mesa-dev] [PATCH] radv/wsi: don't use a helper for blit, just call copy image.

Reviewed-by: Samuel Pitoiset On 11/15/2017 11:55 PM, Dave Airlie wrote: From: Dave Airlie We ignore layout currently, not sure what would be correct to pass. (this is based on Jason's last wsi rfc) Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH] vulkan/wsi: use function ptr definitions from the spec.

Reviewed-by: Samuel Pitoiset On 11/15/2017 11:46 PM, Dave Airlie wrote: From: Dave Airlie This just seems cleaner, and we may expand this in future. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_wsi.c | 3

[Mesa-dev] [PATCH] genxml: Fix PIPELINE_SELECT on G45/Ironlake.

Original 965 sets bits 28:27 to 0, while G45 and later set it to 1. Also, there's no GPGPU pipeline on Gen5, and the pipeline to select is a single bit - bit 1 is reserved. --- src/intel/genxml/gen45.xml | 4 ++-- src/intel/genxml/gen5.xml | 5 ++--- 2 files changed, 4 insertions(+), 5

[Mesa-dev] [PATCH] i965: Upload invariant state once at the start of the batch on Gen4-5.

We want to emit invariant state at the start of a render batch. In the past, this more or less happened: a new batch flagged BRW_NEW_CONTEXT (because we don't have hardware contexts), which triggered the brw_invariant_state atom. So, it would be emitted before any 3D drawing. (Technically,

<    1   2   3   >