Re: [Mesa-dev] [PATCH] i965/nir: do int64 lowering before optimization

On Tue, 2017-12-12 at 08:20 +0100, Iago Toral wrote: > On Mon, 2017-12-11 at 08:01 -0800, Jason Ekstrand wrote: > > On Mon, Dec 11, 2017 at 12:55 AM, Iago Toral > > wrote: > > > This didn't get any reviews yet. Any takers? > > > > > > > > > > > > On Fri, 2017-12-01 at 13:46

Re: [Mesa-dev] [PATCH] i965: Don't allocate an MCS for 16x MSAA and width > 8192.

Thanks Ken! Reviewed-by: Iago Toral Quiroga On Wed, 2017-12-13 at 12:25 -0800, Kenneth Graunke wrote: > The hardware doesn't support this, and isl_surf_get_mcs_surf will > fail. > > I feel a bit bad replicating this logic, but we want to decide up > front. > > This fixes

Re: [Mesa-dev] [PATCH 4/4] mesa: enable GL_EXT_disjoint_timer_query extension

On 12/12/2017 07:00 PM, Ian Romanick wrote: On 11/19/2017 11:18 PM, Tapani Pälli wrote: Add GL_GPU_DISJOINT_EXT and enable extension when ARB_timer_query is supported by the driver. Following dEQP cases pass: dEQP-EGL.functional.get_proc_address.extension.gl_ext_disjoint_timer_query

[Mesa-dev] [PATCH] st/st_glsl_to_nir: call nir_lower_64bit_pack

Fixes 56 crashes in radeonsi. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 7c9e76a2dce..5683dfe 100644 ---

Re: [Mesa-dev] [PATCH 22/22] st/dri: Add option to control exposure of 10 bpc color configs.

On Wed, Dec 13, 2017 at 10:45 PM, Mario Kleiner wrote: > On 12/13/2017 05:27 PM, Marek Olšák wrote: >> >> Mario, can we push these patches? >> >> Marek >> > > Sorry for the late response and thanks for the reviews! Was a bit sick the > last days, so couldn't think or

[Mesa-dev] [PATCH] st/glsl_to_nir: call post opt functions after opts have finished

We need to move this to a separate loop because nir_compact_varyings() can alter the IR of a previous stage. Fixes: 6648bd68fd27 "st/glsl_to_nir: enable NIR link time opts" --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 22/22] st/dri: Add option to control exposure of 10 bpc color configs.

On 12/13/2017 05:27 PM, Marek Olšák wrote: Mario, can we push these patches? Marek Sorry for the late response and thanks for the reviews! Was a bit sick the last days, so couldn't think or do anything about the recent comments so far. I think all patches have a r-b by you and/or Tapani,

Re: [Mesa-dev] [PATCH] gallium/docs: document behavior of set_sample_mask()

On Wed, Dec 13, 2017 at 4:43 AM, Roland Scheidegger wrote: > Am 13.12.2017 um 04:34 schrieb Brian Paul: >> The sample mask is used even if msaa is not explicity enabled when we >> have a framebuffer with multisampled surfaces. That's DX behavior and >> what the Radeon drivers

[Mesa-dev] [PATCH 1/2] i965/draw: Do resolves properly for textures used by TXF

--- src/mesa/drivers/dri/i965/brw_draw.c | 41 1 file changed, 41 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index 4945dec..9fd44e4 100644 --- a/src/mesa/drivers/dri/i965/brw_draw.c +++

[Mesa-dev] [PATCH 2/2] i965: Enable CCS_E sampling of sRGB textures as UNORM

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index b87d356..e21e1da 100644 ---

Re: [Mesa-dev] [PATCH 3/3] Revert "i965: Disable regular fast-clears (CCS_D) on gen9+"

Better commit message: Re-enable regular fast-clears (CCS_D) on gen9+ This reverts commit ee57b15ec764736e2d5360beaef9fb2045ed0f68, "i965: Disable regular fast-clears (CCS_D) on gen9+". How taht we've fixed the issue with too many different aux usages in the render cache, it

[Mesa-dev] [PATCH 3/3] Revert "i965: Disable regular fast-clears (CCS_D) on gen9+"

This reverts commit ee57b15ec764736e2d5360beaef9fb2045ed0f68. Cc: "17.3" --- src/mesa/drivers/dri/i965/brw_meta_util.c | 10 - src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 57 --- 2 files changed, 25 insertions(+), 42

[Mesa-dev] [PATCH 2/3] i965: Track format and aux usage in the render cache

This lets us perform render cache flushes whenever a surface goes from being used with one aux+format to a different aux+format. This is the "proper" fix for https://bugs.freedesktop.org/102435. ee57b15ec764736e2d5360beaef9fb2045ed0f68 which was really just a partial revert of

[Mesa-dev] [PATCH 1/3] i965: Call brw_cache_flush_for_render in predraw_resolve_framebuffer

This makes sure we flush things out such as depth writes prior to using a surface through the render cache. Besides the overhead of a hash table look-up, this function is harmless to call repeatedly with the same arguments. Cc: "17.3" ---

Re: [Mesa-dev] [PATCH 11/29] anv/cmd_buffer: Add a mark_image_written helper

On Mon, Nov 27, 2017 at 07:06:01PM -0800, Jason Ekstrand wrote: > Currently, this helper does nothing but we call it every place where an > image is written through the render pipeline. This will allow us to > properly mark the aux state so that we can handle resolves correctly. > --- >

[Mesa-dev] [Bug 103852] Rendering errors when running dolphin-emu with Vulkan backend, radv (Super Smash Bros. Melee)

https://bugs.freedesktop.org/show_bug.cgi?id=103852 Ben Clapp changed: What|Removed |Added Version|17.2|17.3 -- You are

[Mesa-dev] [Bug 103852] Rendering errors when running dolphin-emu with Vulkan backend, radv (Super Smash Bros. Melee)

https://bugs.freedesktop.org/show_bug.cgi?id=103852 --- Comment #1 from Ben Clapp --- I've done some testing with mesa 17.3.0 on my computer with the RX 580 (using the mesa 17.3.0-1 package available in debian unstable). All of the previously mentioned bugs are still

[Mesa-dev] [PATCH] st/glsl_to_nir: add patch support to st_nir_assign_var_locations()

--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 70c5daaa225..be34031bfb5 100644 ---

[Mesa-dev] [Bug 104251] st_update_single_texture: Assertion `texObj' failed.

https://bugs.freedesktop.org/show_bug.cgi?id=104251 Bug ID: 104251 Summary: st_update_single_texture: Assertion `texObj' failed. Product: Mesa Version: 17.3 Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH v2 3/4] meson: build clover

On Wed, 2017-12-13 at 17:23 -0500, Jan Vesely wrote: > On Wed, 2017-12-13 at 13:54 -0800, Dylan Baker wrote: > > Quoting Jan Vesely (2017-12-13 12:53:25) > > > On Wed, 2017-12-13 at 09:47 -0800, Dylan Baker wrote: > > > > +if (with_gallium_va or with_gallium_vdpau or with_gallium_omx or > > > > +

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

Hi Robert, Thanks for looking into this! We need to decide if we want: (1) A common struct that implementations can subclass, i.e: struct blah_gralloc_handle { alloc_handle_t alloc_handle; int x, y, z; } (2) An accessor library that vendors can implement, i.e: struct

Re: [Mesa-dev] [PATCH v2 3/4] meson: build clover

Quoting Jan Vesely (2017-12-13 14:23:21) > On Wed, 2017-12-13 at 13:54 -0800, Dylan Baker wrote: > > Quoting Jan Vesely (2017-12-13 12:53:25) > > > On Wed, 2017-12-13 at 09:47 -0800, Dylan Baker wrote: > > > > +if (with_gallium_va or with_gallium_vdpau or with_gallium_omx or > > > > +

Re: [Mesa-dev] [PATCH v2 3/4] meson: build clover

On Wed, 2017-12-13 at 13:54 -0800, Dylan Baker wrote: > Quoting Jan Vesely (2017-12-13 12:53:25) > > On Wed, 2017-12-13 at 09:47 -0800, Dylan Baker wrote: > > > +if (with_gallium_va or with_gallium_vdpau or with_gallium_omx or > > > +with_gallium_xvmc or with_dri) > > > +

Re: [Mesa-dev] [PATCH] meson: warn if building a non-debug build with asserts

Quoting Eric Engestrom (2017-12-13 13:43:24) > On Wednesday, 2017-12-13 10:33:05 -0800, Dylan Baker wrote: > > cc: Jason Ekstrand > > Signed-off-by: Dylan Baker > > --- > > meson.build | 9 + > > 1 file changed, 9 insertions(+) > > >

Re: [Mesa-dev] [PATCH v2 3/4] meson: build clover

Quoting Jan Vesely (2017-12-13 13:36:25) > On Wed, 2017-12-13 at 13:01 -0800, Francisco Jerez wrote: > > Jan Vesely writes: > > > > autotools build works OK with no-rtti build of llvm, I've been running > like that for some time. LLVM_CXXFLAGS which include fno-rtti are

Re: [Mesa-dev] [PATCH v2 3/4] meson: build clover

Dylan Baker writes: > Quoting Francisco Jerez (2017-12-13 13:01:29) >> Jan Vesely writes: >> > meson asked for libdrm_amdgpu dependency even though I'm only building >> > clover+r600g driver. >> > after a bit of fiddling with PATH and PK_CONFIG_PATH

Re: [Mesa-dev] [PATCH v2 3/4] meson: build clover

Quoting Francisco Jerez (2017-12-13 13:01:29) > Jan Vesely writes: > > meson asked for libdrm_amdgpu dependency even though I'm only building > > clover+r600g driver. > > after a bit of fiddling with PATH and PK_CONFIG_PATH to pick up the latest > > llvm/liblclc > >

Re: [Mesa-dev] [PATCH v2 3/4] meson: build clover

Quoting Jan Vesely (2017-12-13 12:53:25) > On Wed, 2017-12-13 at 09:47 -0800, Dylan Baker wrote: > > +if (with_gallium_va or with_gallium_vdpau or with_gallium_omx or > > +with_gallium_xvmc or with_dri) > > + pipe_loader_link_with += libgalliumvl > > +else > > + pipe_loader_link_with +=

Re: [Mesa-dev] [PATCH] i965: Don't allocate an MCS for 16x MSAA and width > 8192.

On Wed, Dec 13, 2017 at 12:25 PM, Kenneth Graunke wrote: > The hardware doesn't support this, and isl_surf_get_mcs_surf will fail. > > I feel a bit bad replicating this logic, but we want to decide up front. > I do too. One of these days, I'd like to move things around

Re: [Mesa-dev] [PATCH] Android: fix missing generation of vtn_gather_types.c

Rb On Wed, Dec 13, 2017 at 1:08 PM, Rob Herring wrote: > Commit bb1e6ff161c9 ("spirv: Add a prepass to set types on vtn_values") > added generation of vtn_gather_types.c, but forgot to add it to the > Android build files. > > Fixes: bb1e6ff161c9 ("spirv: Add a prepass to set

Re: [Mesa-dev] [PATCH] meson: warn if building a non-debug build with asserts

On Wednesday, 2017-12-13 10:33:05 -0800, Dylan Baker wrote: > cc: Jason Ekstrand > Signed-off-by: Dylan Baker > --- > meson.build | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/meson.build b/meson.build > index

Re: [Mesa-dev] [PATCH v2 3/4] meson: build clover

Jan Vesely writes: > On Wed, 2017-12-13 at 13:01 -0800, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > On Wed, 2017-12-13 at 09:47 -0800, Dylan Baker wrote: >> > > This has only been compile tested. >> > > >> > > v2: - Have a single option

Re: [Mesa-dev] [PATCH v2 3/4] meson: build clover

On Wed, 2017-12-13 at 13:01 -0800, Francisco Jerez wrote: > Jan Vesely writes: > > > On Wed, 2017-12-13 at 09:47 -0800, Dylan Baker wrote: > > > This has only been compile tested. > > > > > > v2: - Have a single option for opencl (Eric E) > > > - fix typo "tgis" ->

[Mesa-dev] [Bug 104231] DispatchSanity_test.GL30 regression

https://bugs.freedesktop.org/show_bug.cgi?id=104231 Dylan Baker changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH v2 3/4] meson: build clover

Jan Vesely writes: > On Wed, 2017-12-13 at 09:47 -0800, Dylan Baker wrote: >> This has only been compile tested. >> >> v2: - Have a single option for opencl (Eric E) >> - fix typo "tgis" -> "tgsi" (Curro) >> - Don't add "lib" prefix to pipe loader libraries,

Re: [Mesa-dev] [PATCH v2] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

On Wed, Dec 13, 2017 at 11:58 AM, Robert Foss wrote: > Hey Rob, > > I've chatted to both of you about this patch, and it seemed acceptable > to both of you. > > Can I have a s-o-b for either of you? I've applied it and pushed to master. Rob

[Mesa-dev] [PATCH] Android: fix missing generation of vtn_gather_types.c

Commit bb1e6ff161c9 ("spirv: Add a prepass to set types on vtn_values") added generation of vtn_gather_types.c, but forgot to add it to the Android build files. Fixes: bb1e6ff161c9 ("spirv: Add a prepass to set types on vtn_values") Cc: Jason Ekstrand Signed-off-by: Rob

Re: [Mesa-dev] [PATCH] mesa: Add glSpecializeShaderARB to common_desktop_functions

Thank you for the perfectly timed fix. :) Reviewed-by: Ian Romanick On 12/12/2017 11:50 AM, Dylan Baker wrote: > CC: Nicolai Hähnle > CC: Reviewed-by: Ian Romanick > CC: Mark Janes > Fixes:

Re: [Mesa-dev] [PATCH 3/4] meson: set opencl flags for r600

On Tuesday, 2017-12-12 11:58:14 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-12-12 06:15:58) > > On Monday, 2017-12-11 11:50:01 -0800, Dylan Baker wrote: > > > Quoting Eric Engestrom (2017-12-11 07:55:30) > > > > On Friday, 2017-12-08 16:27:21 -0800, Dylan Baker wrote: > > > > >

Re: [Mesa-dev] [PATCH v2 3/4] meson: build clover

On Wed, 2017-12-13 at 09:47 -0800, Dylan Baker wrote: > This has only been compile tested. > > v2: - Have a single option for opencl (Eric E) > - fix typo "tgis" -> "tgsi" (Curro) > - Don't add "lib" prefix to pipe loader libraries, which matches the > autotools behavior > > cc:

Re: [Mesa-dev] [RFC libdrm 3/5] android: Mark alloc_handle_t magic variable as const

On Wed, Dec 13, 2017 at 11:30 AM, Robert Foss wrote: > Mark magic member of alloc_handle_t as const. > Also bump the version of alloc_handle_t. > > Sign-off-by: Robert Foss > --- > android/alloc_handle.h | 4 ++-- > 1 file changed, 2

Re: [Mesa-dev] [RFC libdrm 1/5] android: Move gralloc handle struct to libdrm

On Wed, Dec 13, 2017 at 11:30 AM, Robert Foss wrote: > This struct is used in mesa and drm_hwcomposer. > Versions of if have been implemented in several grallocs: > drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. > > Other than the 1:1 move of the struct a new

[Mesa-dev] [PATCH] i965: Don't allocate an MCS for 16x MSAA and width > 8192.

The hardware doesn't support this, and isl_surf_get_mcs_surf will fail. I feel a bit bad replicating this logic, but we want to decide up front. This fixes the following test when run with --deqp-surface-width=16384: -

Re: [Mesa-dev] [PATCH] radv: export SampleMask from pixel shaders at full rate

On Tue, Dec 12, 2017 at 6:08 PM, Samuel Pitoiset wrote: > Use 16_ABGR instead of 32_ABGR if Z isn't written. > > Ported from RadeonSI. > > No CTS regressions on Polaris. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH v2 05/25] mesa: implement SPIR-V loading in glShaderBinary

On 30/11/2017 23:57, Ian Romanick wrote: On 11/30/2017 09:28 AM, Eduardo Lima Mitev wrote: From: Nicolai Hähnle v2: * Add a gl_shader_spirv_data member to gl_shader, which already encapsulates a gl_spirv_module where the binary will be saved. (Eduardo Lima)

[Mesa-dev] [PATCH v3 6/6] i965: enable ARB_spirv_extensions for gen8+

From: Alejandro Piñeiro --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 4d17393948a..39680ed194a 100644 ---

[Mesa-dev] [PATCH v3 5/6] spirv_extensions: i965: initialize SPIR-V extensions

From: Alejandro Piñeiro v2: Rebase update after changes on previous patches. --- src/mesa/drivers/dri/i965/brw_context.c | 9 - src/mesa/main/context.c | 2 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v3 4/6] spirv_extensions: add spirv_supported_extensions on gl_constants

From: Alejandro Piñeiro We can use it to get real values for ARB_spirv_extensions methods. v2: Rebase update after changes on previous patches. --- src/mesa/main/mtypes.h | 3 +++ src/mesa/main/spirv_extensions.c | 20 +++- 2 files changed, 22

[Mesa-dev] [PATCH v3 3/6] spirv_extensions: define spirv_extensions_supported

From: Alejandro Piñeiro Add a struct to maintain which SPIR-V extensions are supported, and an utility method to initialize it based on nir_spirv_supported_capabilities. v2: * Fixing code style (Ian Romanick) * Adding a prefix (spirv) to fill_supported_spirv_extensions

[Mesa-dev] [PATCH v3 2/6] spirv_extensions: add list of extensions and to_string method

From: Alejandro Piñeiro Ideally this should be generated somehow. One option would be gather all the extension dependencies listed on the core grammar, but there would be the possibility of not including some of the extensions. Note that spirv-tools is doing it just

[Mesa-dev] [PATCH v3 1/6] spirv_extensions: add GL_ARB_spirv_extensions boilerplate

From: Alejandro Piñeiro v2: * Mention extension gap at gl_API.xml (Emil Velikov) * Bail with INVALID_ENUM if extension not available on getStringi (Emil Velikov) * Use EXTRA_EXT macro when defining the extension at get.c/get_hash_params.py (Emil Velikov) *

[Mesa-dev] [PATCH v3 0/6] ARB_spirv_extensions support in Mesa and i965

Hi, This series is the latest version of the support for ARB_spirv_extensions on i965. It was split from a previous series that included also support for gl_spirv, but since this is an independent extension, we have chosen to send it separately to streamline review of the two series. This

[Mesa-dev] [PATCH 10/11] intel/batch-decoder: Decode registers

--- src/intel/tools/gen_batch_decoder.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/intel/tools/gen_batch_decoder.c b/src/intel/tools/gen_batch_decoder.c index ab566aa..782e9fd 100644 --- a/src/intel/tools/gen_batch_decoder.c +++ b/src/intel/tools/gen_batch_decoder.c

[Mesa-dev] [PATCH 09/11] intel/batch-decoder: Decode dynamic state

Unfortunately, in aubinator and aubinator_error_decode we don't always know how many of a given state we have, so we must guess. One day, we'll come up with a way to annotate the batch to solve this problem. --- src/intel/tools/gen_batch_decoder.c | 91 + 1

[Mesa-dev] [PATCH 11/11] intel/tools: Convert aubinator over to the common framework

--- src/intel/Makefile.tools.am | 1 + src/intel/tools/aubinator.c | 719 ++-- src/intel/tools/meson.build | 3 +- 3 files changed, 33 insertions(+), 690 deletions(-) diff --git a/src/intel/Makefile.tools.am b/src/intel/Makefile.tools.am index

[Mesa-dev] [PATCH 04/11] intel/batch-decoder: Decode vertex and index buffers

--- src/intel/common/gen_decoder.h | 2 + src/intel/tools/gen_batch_decoder.c | 159 2 files changed, 161 insertions(+) diff --git a/src/intel/common/gen_decoder.h b/src/intel/common/gen_decoder.h index d401929..2532a36 100644 ---

[Mesa-dev] [PATCH 08/11] intel/decoder: Add a gen_print_group_length helper

--- src/intel/common/gen_decoder.c | 17 ++--- src/intel/common/gen_decoder.h | 5 + 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 1f6b984..c6ddae0 100644 --- a/src/intel/common/gen_decoder.c

[Mesa-dev] [PATCH 03/11] intel/batch-decoder: Decode MEDIA_INTERFACE_DESCRIPTOR_LOAD

--- src/intel/tools/gen_batch_decoder.c | 145 1 file changed, 145 insertions(+) diff --git a/src/intel/tools/gen_batch_decoder.c b/src/intel/tools/gen_batch_decoder.c index 8d9f15e..b8c1350 100644 --- a/src/intel/tools/gen_batch_decoder.c +++

[Mesa-dev] [PATCH 07/11] intel/batch-decoder: Decode constants, binding tables, and samplers

--- src/intel/tools/gen_batch_decoder.c | 73 + 1 file changed, 73 insertions(+) diff --git a/src/intel/tools/gen_batch_decoder.c b/src/intel/tools/gen_batch_decoder.c index f7064b1..5b01879 100644 --- a/src/intel/tools/gen_batch_decoder.c +++

[Mesa-dev] [PATCH 05/11] intel/batch-decoder: Decode graphics shaders

--- src/intel/tools/gen_batch_decoder.c | 95 + 1 file changed, 95 insertions(+) diff --git a/src/intel/tools/gen_batch_decoder.c b/src/intel/tools/gen_batch_decoder.c index 5f46714..f7064b1 100644 --- a/src/intel/tools/gen_batch_decoder.c +++

[Mesa-dev] [PATCH 06/11] intel/tools: Switch aubinator_error_decode over to the gen_print_batch

The shared framework can now do everything that aubinator_error_decode ever did and more. It's time to make the switch. --- src/intel/Makefile.tools.am | 1 + src/intel/tools/aubinator_error_decode.c | 238 +-- src/intel/tools/meson.build |

[Mesa-dev] [PATCH 02/11] intel/tools: Add the start of a generic batch decoder

--- src/intel/common/gen_decoder.h | 48 +++ src/intel/tools/gen_batch_decoder.c | 258 2 files changed, 306 insertions(+) create mode 100644 src/intel/tools/gen_batch_decoder.c diff --git a/src/intel/common/gen_decoder.h

[Mesa-dev] [PATCH 01/11] intel/decoder: Expose the raw field value in the iterator

--- src/intel/common/gen_decoder.c | 3 ++- src/intel/common/gen_decoder.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 333b5ab..1f6b984 100644 --- a/src/intel/common/gen_decoder.c +++

[Mesa-dev] [PATCH 00/11] intel/tools: Unify batch decoding between aubinators

Both aubinator and aubinator_error_decode try and do the same task of decoding batches. They both have code to try and decode various things such as shaders from the batch. All of that code is completely different between the two. This little series reworks the two to use a common

Re: [Mesa-dev] [PATCH 2/2] gallium/u_blitter: enable MSAA when blitting to MSAA surfaces

I'm actually going to drop these patches for now. It seems that implicitly enabling MSAA when the sample mask != ~0 is expected behavior with D3D and some (most?) hardware, including our virtual GPU (I'm fixing a bug there). -Brian On 12/13/2017 12:35 PM, Marek Olšák wrote: Reviewed-by:

Re: [Mesa-dev] [PATCH 10/29] anv/cmd_buffer: Add an anv_genX_call macro

On Mon, Nov 27, 2017 at 07:06:00PM -0800, Jason Ekstrand wrote: > This is copied and pasted from the similar macro we added to ISL. > --- > src/intel/vulkan/anv_cmd_buffer.c | 40 > --- > 1 file changed, 25 insertions(+), 15 deletions(-) > This patch is

Re: [Mesa-dev] [PATCH 2/2] gallium/u_blitter: enable MSAA when blitting to MSAA surfaces

Reviewed-by: Marek Olšák Marek On Mon, Dec 11, 2017 at 9:09 PM, Brian Paul wrote: > If we're doing a Z -> Z MSAA blit (for example) we need to enable > msaa rasterization when drawing the quads so that we can properly > write the per-sample values. > >

Re: [Mesa-dev] [PATCH 1/2] gallium/u_blitter: add code to save/set/restore min_samples for msaa

On Mon, Dec 11, 2017 at 9:09 PM, Brian Paul wrote: > Will be used by the next patch. > --- > src/gallium/auxiliary/util/u_blitter.c | 8 > src/gallium/auxiliary/util/u_blitter.h | 11 +++ > 2 files changed, 19 insertions(+) > > diff --git

[Mesa-dev] [PATCH v3 07/10] mesa/program: Link SPIR-V shaders using the SPIR-V code-path

--- src/mesa/program/ir_to_mesa.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 29198509a6c..5d56c2ef44a 100644 --- a/src/mesa/program/ir_to_mesa.cpp +++ b/src/mesa/program/ir_to_mesa.cpp @@ -36,6

[Mesa-dev] [PATCH v3 09/10] i965: Call spirv_to_nir() instead of glsl_to_nir() for SPIR-V shaders

This is the main fork of the shader compilation code-path, where a NIR shader is obtained by calling spirv_to_nir() or glsl_to_nir(), depending on its nature.. v2: Use 'spirv_data' member from gl_linked_shader to know which method to call. (Timothy Arceri) Reviewed-by: Timothy Arceri

[Mesa-dev] [PATCH v3 06/10] mesa/glspirv: Add _mesa_spirv_link_shaders() function

This is the equivalent to link_shaders() from src/compiler/glsl/linker.cpp, but for SPIR-V programs. It just creates the program and its gl_linked_shader objects, giving drivers the opportunity to implement any linking of SPIR-V shaders they choose, at a later stage. v2: Bail out if we see more

[Mesa-dev] [PATCH v3 05/10] mesa: Add a reference to gl_shader_spirv_data to gl_linked_shader

This is a reference to the spirv_data object stored in gl_shader, which stores shader SPIR-V data that is needed during linking too. Reviewed-by: Timothy Arceri --- src/mesa/main/mtypes.h| 8 src/mesa/main/shaderobj.c | 1 + 2 files changed, 9 insertions(+)

[Mesa-dev] [PATCH v3 10/10] i965: Don't call process_glsl_ir() for SPIR-V shaders

v2: Use 'spirv_data' from gl_linked_shader instead, to check if shader is SPIR-V. (Timothy Arceri) Reviewed-by: Timothy Arceri --- src/mesa/drivers/dri/i965/brw_link.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v3 03/10] nir/spirv: add gl_spirv_validation method

From: Alejandro Piñeiro ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 "Shader Specialization", error table: INVALID_VALUE is generated if does not name a valid entry point for .

[Mesa-dev] [PATCH v3 04/10] mesa: Implement glSpecializeShaderARB

From: Nicolai Hähnle v2: * Use gl_spirv_validation instead of spirv_to_nir. This method just validates the shader. The conversion to NIR will happen later, during linking. (Alejandro Piñeiro) * Use gl_shader_spirv_data struct to store the SPIR-V data.

[Mesa-dev] [PATCH v3 01/10] mesa: add gl_constants::SpirVCapabilities

From: Nicolai Hähnle For drivers to declare which SPIR-V features they support. v2: Don't use a pointer (Ian Romanick) --- src/mesa/main/mtypes.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

[Mesa-dev] [PATCH v3 02/10] i965: initialize SPIR-V capabilities

From: Alejandro Piñeiro Needed for ARB_gl_spirv. Right now those are the same that the intel vulkan driver, but those are not shared. From the ARB_spirv_extensions spec: "3. If a new GL extension is added that includes SPIR-V support via a new SPIR-V extension does

[Mesa-dev] [PATCH v3 08/10] mesa/glspirv: Add a _mesa_spirv_to_nir() function

This is basically a wrapper around spirv_to_nir() that includes arguments setup and post-conversion validation. v2: * Rebase update (SpirVCapabilities not a pointer anymore, spirv_to_nir_options added, and others). * Code-style improvements and remove debug hunk. (Timothy Arceri)

[Mesa-dev] [PATCH v3 00/10] Initial gl_spirv support in Mesa and i965

Hi, This is the 3rd version of the series adding initial support for ARB_gl_spirv. Previous versions of this series included also support for ARB_spirv_extensions, but we have decided to split the two to ease review. So I will be sending a second series with only the patches for

Re: [Mesa-dev] [PATCH v2 1/4] meson: Build SWR driver

On Wed, 2017-12-13 at 09:47 -0800, Dylan Baker wrote: > This enables the SWR driver, but doesn't actually hook it up to any of > the targets yet. I felt like this patch was big and complicated enough > without adding that. > > v2: - Fix typo 'delemeited' -> 'delimited' (Eric E) > - Fix type

[Mesa-dev] [Bug 104229] radeon_icd.i686.json api_version is 1.0.3

https://bugs.freedesktop.org/show_bug.cgi?id=104229 mercuriete changed: What|Removed |Added Version|unspecified |17.3

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

On Mon, Nov 27, 2017 at 07:05:56PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 58 > ++ > src/intel/vulkan/anv_private.h | 5 > 2 files changed, 63 insertions(+) > > diff --git a/src/intel/vulkan/anv_image.c

Re: [Mesa-dev] [PATCH 09/29] anv/cmd_buffer: Generalize transition_color_buffer

On Mon, Nov 27, 2017 at 07:05:59PM -0800, Jason Ekstrand wrote: > This moves it to being based on layout_to_aux_usage instead of being > hard-coded based on bits of a priori knowledge of how transitions > interact with layouts. This conceptually simplifies things because > we're now using

[Mesa-dev] [PATCH 3/4] st/va: directly use idr pic flag

From: Boyuan Zhang Remove is_idr flag, and use idr_pic_flag provided by vaapi directly Signed-off-by: Boyuan Zhang Reviewed-by: Christian König --- src/gallium/state_trackers/va/picture.c | 8 +++- 1 file changed, 3

[Mesa-dev] [PATCH 4/4] vl: remove is idr flag

From: Boyuan Zhang Remove is_idr flag since not being used anymore. Signed-off-by: Boyuan Zhang Reviewed-by: Christian König --- src/gallium/include/pipe/p_video_state.h | 1 - 1 file changed, 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/4] radeon/vcn: determine idr by pic type

From: Boyuan Zhang Vaapi encode interface provides idr frame flags, where omx interface doesn't. Therefore, change to use picture type to determine idr frame, which will work for both interfaces. Signed-off-by: Boyuan Zhang Reviewed-by: Leo Liu

[Mesa-dev] [PATCH 2/4] radeon/vce: determine idr by pic type

From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vce_52.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vce_52.c b/src/gallium/drivers/radeon/radeon_vce_52.c

Re: [Mesa-dev] [PATCH 2/2] gallivm: fix an issue with NaNs with seamless cube filtering

On 13/12/17 02:34, srol...@vmware.com wrote: From: Roland Scheidegger Cube texture wrapping is a bit special since the values (post face projection) always are within [0,1], so we took advantage of that and omitted some clamps. However, we can still get NaNs (either because

[Mesa-dev] [PATCH] meson: warn if building a non-debug build with asserts

cc: Jason Ekstrand Signed-off-by: Dylan Baker --- meson.build | 9 + 1 file changed, 9 insertions(+) diff --git a/meson.build b/meson.build index 6e5ae4d24e9..b00c1ffc3dc 100644 --- a/meson.build +++ b/meson.build @@ -29,6 +29,15 @@

Re: [Mesa-dev] [PATCH v2] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

Hey Rob, I've chatted to both of you about this patch, and it seemed acceptable to both of you. Can I have a s-o-b for either of you? Rob. On Mon, 2017-12-04 at 19:22 +0100, Robert Foss wrote: > From: Tomasz Figa > > There is no API available to properly query the >

[Mesa-dev] [PATCH v2 4/4] meson: set opencl flags for r600

Signed-off-by: Dylan Baker --- src/gallium/drivers/r600/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/meson.build b/src/gallium/drivers/r600/meson.build index 2132dbb33ad..5899518a2e8 100644 ---

[Mesa-dev] [PATCH v2 3/4] meson: build clover

This has only been compile tested. v2: - Have a single option for opencl (Eric E) - fix typo "tgis" -> "tgsi" (Curro) - Don't add "lib" prefix to pipe loader libraries, which matches the autotools behavior cc: Curro Jerez cc: Jan Vesely

[Mesa-dev] [PATCH v2 2/4] meson: Turn on swr for relevant targets

Currently that's dri, libgl-xlib, and osmesa. v2: - put drivers on a separate line from normal dependencies (Eric E) Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom --- src/gallium/meson.build| 1 -

[Mesa-dev] [PATCH v2 1/4] meson: Build SWR driver

This enables the SWR driver, but doesn't actually hook it up to any of the targets yet. I felt like this patch was big and complicated enough without adding that. v2: - Fix typo 'delemeited' -> 'delimited' (Eric E) - Fix type 'errror' -> 'error' (Eric E) - Use variables to hold files

[Mesa-dev] [RFC libdrm 5/5] android: Change alloc_handle_t format from Android format to fourcc

Change the alloc_handle_t format to signify the fourcc pixel format code instead of the Android pixel format definition. This is desirable since the fourcc code is what is used within the DRM subsystem. Naturally translation will still have to happen somewhere. Also bump the alloc_handle_t

[Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, since at least 4 implementations exist, and share a lot of contents. The idea is to keep the common stuff defined in one place, and libdrm is the common codebase to all of these platforms. Additionally, having this struct defined

[Mesa-dev] [RFC libdrm 1/5] android: Move gralloc handle struct to libdrm

This struct is used in mesa and drm_hwcomposer. Versions of if have been implemented in several grallocs: drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. Other than the 1:1 move of the struct a new generic name has been chosen and variables have had comments added to them. Sign-off-by:

[Mesa-dev] [RFC libdrm 3/5] android: Mark alloc_handle_t magic variable as const

Mark magic member of alloc_handle_t as const. Also bump the version of alloc_handle_t. Sign-off-by: Robert Foss --- android/alloc_handle.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/alloc_handle.h b/android/alloc_handle.h index

[Mesa-dev] [RFC libdrm 2/5] android: Add version variable to alloc_handle_t

The version variable will be used for versioning of this struct and the corresponding accessor functions. Signed-off-by: Robert Foss --- android/alloc_handle.h | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/android/alloc_handle.h

[Mesa-dev] [RFC libdrm 4/5] android: Remove member name from alloc_handle_t

The name member of alloc_handle_t is no longer needed and has been removed. The version field has also been bumped. Signed-off-by: Robert Foss --- android/alloc_handle.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/android/alloc_handle.h

  1   2   >