Re: [Mesa-dev] [PATCH] i965: perform 2 uploads with dual slot *64*PASSTHRU formats on gen<8

The patch looks good, just some nitpicks below. On 29/01/18 01:26, Andres Gomez wrote: > The emission of vertex attributes corresponding to dvec3 and dvec4 > vertex shader input variables was not correct when the passed > to the VertexAttribL* commands was <= 2. > > In 61a8a55f557 ("i965/gen8: Fi

[Mesa-dev] [Bug 104490] [radeonsi/290x] Dota2 fails to start (can't create opengl context)

https://bugs.freedesktop.org/show_bug.cgi?id=104490 --- Comment #12 from Sebastian Parborg --- Adam, is there anything I can do to help you figure out what goes wrong? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.__

[Mesa-dev] [Bug 101556] [llvmpipe] crashes when GL context is created and a previous context was shared

https://bugs.freedesktop.org/show_bug.cgi?id=101556 Florian Link changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] i965: fix disk_cache leak when destroying context

On 01/27/2018 01:29 AM, Jordan Justen wrote: On 2018-01-26 00:48:42, Tapani Pälli wrote: ==2780== 1,024 bytes in 1 blocks are possibly lost in loss record 180 of 205 ==2780==at 0x4C31A1E: calloc (vg_replace_malloc.c:711) ==2780==by 0x13F6467E: util_queue_init (u_queue.c:309

[Mesa-dev] [PATCH v2 10/20] radv: Compute shader_z_format when emitting it.

--- src/amd/vulkan/radv_pipeline.c | 10 +++--- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 75137c8629..84d889a7c4 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/s

[Mesa-dev] [PATCH v2 12/20] radv: Split out the ia_multi_vgt_param precomputation.

Also moved everything in a struct and then return the struct from the helper function, so it is clear in the caller what part of the pipeline gets modified. --- src/amd/vulkan/radv_pipeline.c | 169 ++--- src/amd/vulkan/radv_private.h | 16 ++-- src/amd/vulkan

[Mesa-dev] [PATCH v2 16/20] radv: Split out processing the vertex input state.

--- src/amd/vulkan/radv_pipeline.c | 78 +++--- 1 file changed, 43 insertions(+), 35 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index b4339f7940..431b8da144 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd

[Mesa-dev] [PATCH] st/glsl_to_nir: remove dead io after conversion to nir

This fixes an assert in nir_lower_var_copies() for some bioshock shaders where an unused clipdistance array has no size. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl

[Mesa-dev] [PATCH v2 14/20] radv: Move blend state out of pipeline.

--- src/amd/vulkan/radv_pipeline.c | 127 +++-- src/amd/vulkan/radv_private.h | 12 2 files changed, 72 insertions(+), 67 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 549e0cec64..9211a2debc 100644 --- a/

[Mesa-dev] [PATCH v2 08/20] radv: Merge ps_input_cntl computation with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 160 - src/amd/vulkan/radv_private.h | 2 - 2 files changed, 79 insertions(+), 83 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 3862625e19..52585b0265 100644 --- a/src

[Mesa-dev] [PATCH v2 18/20] radv: Split out cliprect rule generation.

--- src/amd/vulkan/radv_pipeline.c | 57 -- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 33 insertions(+), 25 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 009a03f41f..7ad964bdb8 100644 --- a/src/

[Mesa-dev] [PATCH v2 05/20] radv: Merge binning state generation with pm4 emission.

We don't need the pipeline state struct anymore. --- src/amd/vulkan/radv_pipeline.c | 48 +- src/amd/vulkan/radv_private.h | 6 -- 2 files changed, 19 insertions(+), 35 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pip

[Mesa-dev] [PATCH 0/3] vbo: small improvements to print_draw_arrays

Just a small series adding some bits to the debug function print_draw_arrays. Andres Gomez (3): vbo: print first element of the VAO when the binding stride is 0 vbo: take into account the size when printing VAO elements vbo: provide 64bits support to print_draw_arrays src/mesa/vbo/vbo_exec

[Mesa-dev] [PATCH v2 01/20] radv: Determine unneeded dynamic states.

Which avoids setting or emitting them. --- src/amd/vulkan/radv_cmd_buffer.c | 40 -- src/amd/vulkan/radv_pipeline.c | 61 +--- src/amd/vulkan/radv_private.h| 1 + 3 files changed, 64 insertions(+), 38 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 2/3] vbo: take into account the size when printing VAO elements

When using print_draw_arrays for debugging, we were printing an "n" amount of vertex but that meant not to print all the size in the "n" vertex, depending on the stride used. Now we print the whole size in the "n" vertex. Cc: Mathias Fröhlich Cc: Brian Paul Signed-off-by: Andres Gomez --- src

[Mesa-dev] [PATCH 1/3] vbo: print first element of the VAO when the binding stride is 0

Cc: Mathias Fröhlich Cc: Brian Paul Signed-off-by: Andres Gomez --- src/mesa/vbo/vbo_exec_array.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index d990fdf7a8d..aa5f3cbf23e 100644 --- a/src/mesa/vbo/vbo

[Mesa-dev] [PATCH v2 04/20] radv: Constify some pipeline helpers.

--- src/amd/vulkan/radv_pipeline.c | 8 src/amd/vulkan/radv_private.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 8627b1122b..51452a2fd5 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/sr

[Mesa-dev] [PATCH v2 17/20] radv: Merge VGT_GS_MODE computation with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 51 +- src/amd/vulkan/radv_private.h | 2 -- 2 files changed, 25 insertions(+), 28 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 431b8da144..009a03f41f 100644 --- a/src

[Mesa-dev] [PATCH v2 11/20] radv: Split out db_shader_control computation.

--- src/amd/vulkan/radv_pipeline.c | 43 +- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 84d889a7c4..8ca3497b12 100644 --- a/src/

[Mesa-dev] [PATCH] radv/gfx9: fix block compression texture views. (v2)

From: Dave Airlie This ports a fix from amdvlk, to fix the sizing for mip levels when block compressed images are viewed using uncompressed views. My original fix didn't power the clamping, but it looks like the clamping is required to stop the sizing going too large. Fixes: dEQP-VK.image.texel

[Mesa-dev] [PATCH v2 07/20] radv: Merge vtx_reuse_depth computation with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 13 ++--- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 32c381bc49..3862625e19 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

[Mesa-dev] [PATCH v2 03/20] radv: Add PM4 pregeneration for compute pipelines.

--- src/amd/vulkan/radv_cmd_buffer.c | 60 ++-- src/amd/vulkan/radv_pipeline.c | 66 2 files changed, 68 insertions(+), 58 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

[Mesa-dev] [PATCH v2 00/20] Rework pipeline emitting.

This changes emitting pipelines to pregenerate the PM$ sequences to bind the pipeline at pipeline creation time, so we can just memcpy it in the command buffer. This gives minor CPU improvements on dota2. In the process I also refactored stuff to: 1) Not have all the state in the pipeline struct

[Mesa-dev] [Bug 104818] mesa fails to build on ia64

https://bugs.freedesktop.org/show_bug.cgi?id=104818 --- Comment #3 from Jason Duerstock --- The full build log from the Debian builder: https://buildd.debian.org/status/fetch.php?pkg=mesa&arch=ia64&ver=17.3.3-1&stamp=1516394211&raw=0 -- You are receiving this mail because: You are the QA Conta

[Mesa-dev] [PATCH v2 15/20] radv: Move tessellation state out of pipeline.

--- src/amd/vulkan/radv_pipeline.c | 95 ++ src/amd/vulkan/radv_private.h | 13 -- 2 files changed, 58 insertions(+), 50 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 9211a2debc..b4339f7940 100644 --- a

[Mesa-dev] [PATCH] i965: perform 2 uploads with dual slot *64*PASSTHRU formats on gen<8

The emission of vertex attributes corresponding to dvec3 and dvec4 vertex shader input variables was not correct when the passed to the VertexAttribL* commands was <= 2. In 61a8a55f557 ("i965/gen8: Fix vertex attrib upload for dvec3/4 shader inputs"), for gen8+ we needed to determine if the attri

[Mesa-dev] [PATCH 3/3] vbo: provide 64bits support to print_draw_arrays

Cc: Mathias Fröhlich Cc: Brian Paul Signed-off-by: Andres Gomez --- src/mesa/vbo/vbo_exec_array.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index e80c5baaf79..435f0a0851f 100644 --- a/

[Mesa-dev] [PATCH v2 19/20] radv: Move gs state out of pipeline.

--- src/amd/vulkan/radv_pipeline.c | 78 +++--- src/amd/vulkan/radv_private.h | 8 - 2 files changed, 43 insertions(+), 43 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 7ad964bdb8..9212d461e5 100644 --- a/

[Mesa-dev] [PATCH v2 13/20] radv: Split out generating VGT_SHADER_STAGES_EN.

--- src/amd/vulkan/radv_pipeline.c | 50 +++--- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 27 insertions(+), 24 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 7b7ced5cd7..549e0cec64 100644 --- a/src/

[Mesa-dev] [PATCH v2 02/20] radv: Record a PM4 sequence for graphics pipeline switches.

This gives about 2% performance improvement on dota2 for me. This is mostly a mechanical copy and replacement, but at bind time we still do: 1) Some stuff that is only based on num_samples changes. 2) Some command buffer state setting. --- src/amd/vulkan/radv_cmd_buffer.c | 454 +

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

https://bugs.freedesktop.org/show_bug.cgi?id=104820 krzys...@cybulski.info changed: What|Removed |Added Summary|White screen in SDDM after |White screen in SDDM after

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

https://bugs.freedesktop.org/show_bug.cgi?id=104820 --- Comment #1 from krzys...@cybulski.info --- Created attachment 137008 --> https://bugs.freedesktop.org/attachment.cgi?id=137008&action=edit Xorg.0.log -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [PATCH v2 20/20] radv: Merge raster state with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 115 ++--- src/amd/vulkan/radv_private.h | 10 2 files changed, 50 insertions(+), 75 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 9212d461e5..785c216b4a 100644 --- a/

[Mesa-dev] [Bug 104818] mesa fails to build on ia64

https://bugs.freedesktop.org/show_bug.cgi?id=104818 --- Comment #2 from Jason Duerstock --- This is explicitly on an ia64 machine, not on i386 or amd64. $ uname -a Linux deb-ia64 3.14-0.bpo.2-mckinley #1 SMP Debian 3.14.15-2~bpo70+1 (2014-08-21) ia64 GNU/Linux $ cat /proc/cpuinfo processor : 0

[Mesa-dev] [PATCH v2 09/20] radv: Merge depth stencil state with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 123 +++-- src/amd/vulkan/radv_private.h | 8 --- 2 files changed, 58 insertions(+), 73 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 52585b0265..75137c8629 100644 --- a/s

[Mesa-dev] [PATCH v2 06/20] radv: Merge vs state computation with PM4 generation.

--- src/amd/vulkan/radv_pipeline.c | 84 +- src/amd/vulkan/radv_private.h | 8 2 files changed, 34 insertions(+), 58 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 0dab021411..32c381bc49 100644 --- a/s

Re: [Mesa-dev] [PATCH shaderdb 1/2] run: fall back to v3.1 core ctx if v3.2 fails

On Sat, Jan 27, 2018 at 9:07 PM, Matt Turner wrote: > On Sat, Jan 27, 2018 at 4:08 PM, Rob Clark wrote: >> On Sat, Jan 27, 2018 at 7:02 PM, Matt Turner wrote: >>> On Sat, Jan 27, 2018 at 10:06 AM, Rob Clark wrote: Signed-off-by: Rob Clark --- run.c | 12 1 fil

[Mesa-dev] [Bug 104818] mesa fails to build on ia64

https://bugs.freedesktop.org/show_bug.cgi?id=104818 --- Comment #1 from Robert Wahlstedt --- Hello, ia64 may not be a platform commonly supported. From Wikipedia “The Itanium architecture is based on explicit instruction-level parallelism, in which the compiler decides which instructions to execu

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

https://bugs.freedesktop.org/show_bug.cgi?id=104820 Robert Wahlstedt changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] ac/nir: call glsl_get_sampler_dim() only once, where possible (v2)

On 27/01/18 22:07, Kai Wasserbäch wrote: Ping. This patch has a T-b by Dieter Nützel (including v2), any R-b and commit would be much appreciated. (Timothy indicated on Wednesday he would try to commit this (

Re: [Mesa-dev] [PATCH shaderdb 1/2] run: fall back to v3.1 core ctx if v3.2 fails

On Sun, Jan 28, 2018 at 11:24 AM, Rob Clark wrote: > On Sat, Jan 27, 2018 at 9:07 PM, Matt Turner wrote: >> On Sat, Jan 27, 2018 at 4:08 PM, Rob Clark wrote: >>> On Sat, Jan 27, 2018 at 7:02 PM, Matt Turner wrote: On Sat, Jan 27, 2018 at 10:06 AM, Rob Clark wrote: > Signed-off-by: Rob

Re: [Mesa-dev] [PATCH shaderdb 1/2] run: fall back to v3.1 core ctx if v3.2 fails

On Sun, Jan 28, 2018 at 11:34 AM, Rob Clark wrote: > On Sun, Jan 28, 2018 at 11:24 AM, Rob Clark wrote: >> On Sat, Jan 27, 2018 at 9:07 PM, Matt Turner wrote: >>> On Sat, Jan 27, 2018 at 4:08 PM, Rob Clark wrote: On Sat, Jan 27, 2018 at 7:02 PM, Matt Turner wrote: > On Sat, Jan 27, 20

[Mesa-dev] [PATCH 5/6] meson: osx ld doesn't support --build-id

--- meson.build | 4 src/mesa/drivers/dri/meson.build | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 8fdbaa8b8d8..655a93cecef 100644 --- a/meson.build +++ b/meson.build @@ -914,6 +914,10 @@ if cc.links('int main() { r

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade from 17.3

https://bugs.freedesktop.org/show_bug.cgi?id=104820 Bug ID: 104820 Summary: White screen in SDDM after upgrade from 17.3 Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Seve

[Mesa-dev] [PATCH 6/6] travis: add macOS meson build

--- .travis.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml index 9cecf2f615f..7e6bbfe306b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -403,6 +403,11 @@ matrix: - MAKE_CHECK_COMMAND="make check" - DRI_LOADERS="--with-platforms=x11 --disabl

[Mesa-dev] [PATCH 0/6] meson: build src/glx/apple

This also requires my "fix osx" series to actually build Dylan Baker (2): meson: find python2 on macOS meson: set apple glx defines Jon Turney (4): meson: build src/glx/apple meson: osx doesn't have librt, so don't require it meson: osx ld doesn't support --build-id travis: add macOS

[Mesa-dev] [PATCH 4/6] meson: osx doesn't have librt, so don't require it

--- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 7e194a9f10d..8fdbaa8b8d8 100644 --- a/meson.build +++ b/meson.build @@ -935,7 +935,7 @@ elif with_dri_i965 and get_option('shader-cache') endif # Determine whether or not the rt

[Mesa-dev] [PATCH 2/6] meson: set apple glx defines

From: Dylan Baker --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index 178743eddb1..7e194a9f10d 100644 --- a/meson.build +++ b/meson.build @@ -616,6 +616,8 @@ if with_platform_x11 endif if with_dri_platform == 'drm' pre_args += '-

[Mesa-dev] [PATCH 3/6] meson: build src/glx/apple

--- src/glx/apple/meson.build | 62 +++ src/glx/meson.build | 4 +++ 2 files changed, 66 insertions(+) create mode 100644 src/glx/apple/meson.build diff --git a/src/glx/apple/meson.build b/src/glx/apple/meson.build new file mode 100644 index 000

[Mesa-dev] [PATCH 6/6] travis: add osx autotools build

--- .travis.yml | 123 ++-- 1 file changed, 78 insertions(+), 45 deletions(-) diff --git a/.travis.yml b/.travis.yml index 211df3ec1ef..9cecf2f615f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -396,9 +396,39 @@ matrix: - libexp

[Mesa-dev] [PATCH 1/6] meson: find python2 on macOS

From: Dylan Baker --- meson.build | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 824e3c46bc5..178743eddb1 100644 --- a/meson.build +++ b/meson.build @@ -642,7 +642,13 @@ if with_platform_android pre_args += '-DHAVE_ANDROID_PLATFORM'

[Mesa-dev] [PATCH 4/6] glx/apple: locate dispatch table functions to wrap by name

Avoid reaching into the dispatch table internals (and thus having to deal with the complexities of remap etc.) by identifying functions to wrap by name. See: https://lists.freedesktop.org/archives/mesa-dev/2015-June/086721.html et seq. https://bugs.freedesktop.org/show_bug.cgi?id=90311 --- src/gl

[Mesa-dev] [PATCH 0/6] Fix osx build and add to CI

Jon Turney (6): configure: Default to gbm=no on osx osx: ld doesn't support --build-id glx/apple: include util/debug.h for env_var_as_boolean prototype glx/apple: locate dispatch table functions to wrap by name glx/test: fix building for osx travis: add osx autotools build .travis.yml

[Mesa-dev] [PATCH 1/6] configure: Default to gbm=no on osx

--- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index ae5162319d1..daa040d3194 100644 --- a/configure.ac +++ b/configure.ac @@ -1270,10 +1270,10 @@ AC_ARG_ENABLE([xa], [enable_xa=no]) AC_ARG_ENABLE([gbm], [AS_HELP_STRIN

[Mesa-dev] [PATCH 2/6] osx: ld doesn't support --build-id

--- configure.ac | 13 + src/mesa/drivers/dri/Makefile.am | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index daa040d3194..a54b7cb6650 100644 --- a/configure.ac +++ b/configure.ac @@ -685,6 +685,19 @@ AC_LINK_IFE

[Mesa-dev] [PATCH 3/6] glx/apple: include util/debug.h for env_var_as_boolean prototype

mesa/src/glx/glxcmds.c:1295:21: error: implicit declaration of function 'env_var_as_boolean' is invalid in C99 [-Werror,-Wimplicit-function-declaration] mesa/src/glx/apple/apple_visual.c:85:28: error: implicit declaration of function 'env_var_as_boolean' is invalid in C99 [-Werror,-Wimplicit-fun

Re: [Mesa-dev] [PATCH] mesa: remove DummyShader from atifragshader.c

On 24/01/18 17:16, Emil Velikov wrote: On 20 December 2017 at 16:33, Miklós Máté wrote: It's much cleaner to allocate a normal shader struct when GenFragmentShadersATI is called. Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 21 ++--- 1 file changed, 10 ins

Re: [Mesa-dev] [PATCH v2 18/22] clover/api: Implement CL_DEVICE_IL_VERSION_KHR

On 2018-01-23 — 14:12, Francisco Jerez wrote: > Pierre Moreau writes: > > > Signed-off-by: Pierre Moreau > > --- > > src/gallium/state_trackers/clover/api/device.cpp | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/src/gallium/state_trackers/clover/api/device.cpp > > b/src/g