[Mesa-dev] [PATCH 6/8] vbo: Simplify input array distribution for array type draws.

From: Mathias Fröhlich Using the newly introduced VAO state variable, we can simplify recalculate_input_bindings. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec_array.c | 110 +++--- 1 file changed, 27 insertions(+), 83 deletions(-) diff --git a/

[Mesa-dev] [PATCH 5/8] vbo: Use static const VERT_ATTRIB->VBO_ATTRIB maps.

From: Mathias Fröhlich Instead of each context having its own map instance for this purpose, use a global static const map. v2: s,unsigned char,GLubyte,g s,_VP_MODE_MAX,VP_MODE_MAX,g Change comment style. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_context.c| 23 ++---

[Mesa-dev] [PATCH 4/8] mesa: Track position/generic0 aliasing in the VAO.

From: Mathias Fröhlich Since the first material attribute no longer aliases with the generic0 attribute, only aliasing between generic0 and position is left and entirely dependent on the enabled state of the VAO. So introduce a gl_attribute_map_mode in the VAO that is used to track how the positi

[Mesa-dev] [PATCH 2/8] mesa: Use defines for the aliased material array attributes.

From: Mathias Fröhlich Instead of just assuming that the material attributes just overlap with the generic attributes 0-12, give them symbolic defines so that we can easier move them to an other range. Signed-off-by: Mathias Fröhlich --- src/compiler/shader_enums.h | 10 +++

[Mesa-dev] [PATCH 8/8] vbo: Simplify input array distribution for dlist type draws.

From: Mathias Fröhlich Using the newly introduced VAO array maps, we can simplify vbo_bind_vertex_list. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save_draw.c | 54 +++- 1 file changed, 8 insertions(+), 46 deletions(-) diff --git a/src/mesa/vb

[Mesa-dev] [PATCH 1/8] vbo: Correctly handle attribute offsets in dlist draw.

From: Mathias Fröhlich When executing a display list draw, for the offset list to be correct, the offset computation needs to accumulate all attribute size values in order. Specifically, if we are shuffling around the position and generic0 attributes, we may violate the order or if we do not walk

[Mesa-dev] [PATCH 7/8] vbo: Simplify input array distribution for imm type draws.

From: Mathias Fröhlich Using the newly introduced VAO array maps, we can simplify vbo_exec_bind_arrays. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec_draw.c | 81 1 file changed, 15 insertions(+), 66 deletions(-) diff --git a/src/mesa/v

[Mesa-dev] [PATCH 3/8] mesa: Put materials at the end of the generic block.

From: Mathias Fröhlich The materials are now moved to the end of the generic attributes block to the range 4-15. Before, the way the position and generic 0 attribute is handled was dependent on the presence and kind of the currently attached vertex program. With this change the way the position

[Mesa-dev] [PATCH 0/8] Partly untangle pos/generic0 aliasing dependencies v2.

From: Mathias Fröhlich Hi, Thanks for the review! This is the starting point to a patch series that I intent to feed. The aim is to get rid of some VERT_ATTRIB_MAX long loops that currently happen at about any draw call. The series tries to separate out one of the depencies of the attribute al

Re: [Mesa-dev] [PATCH 5/8] vbo: Use static const VERT_ATTRIB->VBO_ATTRIB maps.

Hi Brian, On Wednesday, 31 January 2018 17:55:37 CET Brian Paul wrote: > I wonder if it wouldn't be better to just use a small inline fnction to > do this mapping. It may be faster to evaluate than to do a memory lookup. > > static inline enum vbo_attrib > vbo_attribute_alias_map(enum vp_mode m

Re: [Mesa-dev] [PATCH 0/3] vbo: small improvements to print_draw_arrays

Hi Andres, On Monday, 29 January 2018 00:35:14 CET Andres Gomez wrote: > Just a small series adding some bits to the debug function > print_draw_arrays. > > Andres Gomez (3): > vbo: print first element of the VAO when the binding stride is 0 > vbo: take into account the size when printing VAO

Re: [Mesa-dev] [PATCH 1/8] vbo: Correctly handle attribute offsets in dlist draw.

Hi Brian, On Wednesday, 31 January 2018 17:54:55 CET Brian Paul wrote: > Nice work! It's nice to get rid of some of those attribute loops. > The series looks good to me, just assorted nit-picks and comments on a > few patches. Thanks! Past this 8 patches we still have O(VERT_ATTRIB_MAX) loops.

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: Add support for multi-planes (v2)

On Tue, Jan 9, 2018 at 6:15 PM, Tomasz Figa wrote: > Adding some folks on CC for broader distribution. > > On Tue, Jan 9, 2018 at 3:52 PM, Lepton Wu wrote: >> Gentle ping. Thanks. >> >> On Wed, Dec 27, 2017 at 11:35 PM, Lepton Wu wrote: >>> v2: address comments from Tomasz Figa >>>a) Add mor

Re: [Mesa-dev] [PATCH 00/29] blorp: Add support for more formats

On Fri, Jan 26, 2018 at 5:59 PM, Jason Ekstrand wrote: > This series adds additional format support to BLORP. In particular, > BLORP's blit and copy functions now handle: > > * Source and destination swizzles on all gens > * Blitting to RGB formats (previously we only supported copying to RGB)

[Mesa-dev] [PATCH] r600/cayman: initial attempt at gl_HelperInvocation (v2)

From: Dave Airlie This is a cayman only patch, it doesn't appear that evergreen supports the ALU on VPM. I'll try and figure it out later. All I can say for this patch is it passes the piglit test and the CTS tests. This also disable sb for helper invocations until it can handle the special ALU

[Mesa-dev] [PATCH] glsl/lower_64bit: restrict int64 conversion to int64 instructions.

From: Dave Airlie If the lowering flags for int64 were set we'd try and lower the wrong things sometimes. Signed-off-by: Dave Airlie --- src/compiler/glsl/lower_64bit.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/lower_64bit.cpp b/src/c

Re: [Mesa-dev] [PATCH] r600/cayman: initial attempt at gl_HelperInvocation (v2)

Looks good to me (albeit disabling sb is a shame). Reviewed-by: Roland Scheidegger Am 01.02.2018 um 03:19 schrieb Dave Airlie: > From: Dave Airlie > > This is a cayman only patch, it doesn't appear that > evergreen supports the ALU on VPM. I'll try and figure it out later. > > All I can say fo

[Mesa-dev] [PATCH 2/4] vbo: s/drawcount/drawcount_offset

This parameter (from the glMultiDrawArraysIndirectCountARB function) is poorly named. It's an offset into the buffer which contains the number of primitives to draw. --- src/mesa/vbo/vbo_exec_array.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git

[Mesa-dev] [PATCH 4/4] vbo: change an argument in vbo_draw_indirect_prims()

In vbo_draw_indirect_prims() pass the 'indirect_data' argument to vbo->draw_prims(). All the callers are passing ctx->DrawIndirectBuffer so this should be no functional change. Add a (temporary) assertion to be sure. --- src/mesa/vbo/vbo_context.c | 17 - 1 file changed, 12 inser

[Mesa-dev] [PATCH 1/4] vbo: use vbo local var for draw call in vbo_save_playback_vertex_list()

--- src/mesa/vbo/vbo_save_draw.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/vbo/vbo_save_draw.c b/src/mesa/vbo/vbo_save_draw.c index 906ed22..859c605 100644 --- a/src/mesa/vbo/vbo_save_draw.c +++ b/src/mesa/vbo/vbo_save_draw.c @@ -282,13 +282,13 @@

[Mesa-dev] [PATCH 3/4] vbo: add comments on the VBO draw function typedefs

And rename indirect_params -> indirect_draw_count_buffer and indirect_params_offset -> indirect_draw_count_offset to be more specific. --- src/mesa/vbo/vbo.h | 57 -- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo

[Mesa-dev] [PATCH] util/draw: draw_count not supported in util_draw_indirect()

So assert that and add a comment about it. It would be a simple project for someone to add support for both draw_count and the indirect_draw_count buffer. --- src/gallium/auxiliary/util/u_draw.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/util/u_draw.c b/src/

[Mesa-dev] [PATCH] st/mesa: rename some vars related to indirect draw count

'indirect_params' was a bit vague. Use the names that we use in gallium's pipe_draw_indirect_info. --- src/mesa/state_tracker/st_draw.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c index 2fe70

Re: [Mesa-dev] [PATCH] r600/eg: make sure we allow vpm bit on other CF ops.

Looks alright to me (albeit I still don't really understand what this bit does with the various clauses...) Reviewed-by: Roland Scheidegger Am 01.02.2018 um 03:01 schrieb Dave Airlie: > From: Dave Airlie > > the vpm bit wasn't being applied to the push/pop instructions. > > Signed-off-by: Dav

[Mesa-dev] [PATCH 4/4] svga: remove unneeded #includes in svga_pipe_draw.c

--- src/gallium/drivers/svga/svga_pipe_draw.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/gallium/drivers/svga/svga_pipe_draw.c b/src/gallium/drivers/svga/svga_pipe_draw.c index 8cd7ab0..ee4a105 100644 --- a/src/gallium/drivers/svga/svga_pipe_draw.c +++ b/src/gallium/drivers/svg

[Mesa-dev] [PATCH 3/4] svga: whitespace/formatting fixes in svga_pipe_draw.c

--- src/gallium/drivers/svga/svga_pipe_draw.c | 67 --- 1 file changed, 34 insertions(+), 33 deletions(-) diff --git a/src/gallium/drivers/svga/svga_pipe_draw.c b/src/gallium/drivers/svga/svga_pipe_draw.c index 42525c3..8cd7ab0 100644 --- a/src/gallium/drivers/svga/sv

[Mesa-dev] [PATCH 2/4] svga: clean up retry_draw_range_elements(), retry_draw_arrays()

Get rid of a bunch of goto spaghetti. Remove unneeded do_retry parameter. No Piglit changes. Also tested w/ Google Earth and other apps. --- src/gallium/drivers/svga/svga_pipe_draw.c | 81 +++ 1 file changed, 27 insertions(+), 54 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 1/4] svga: remove unused min/max_index params to draw_vgpu10()

--- src/gallium/drivers/svga/svga_draw.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/svga/svga_draw.c b/src/gallium/drivers/svga/svga_draw.c index 5771903..649bc22 100644 --- a/src/gallium/drivers/svga/svga_draw.c +++ b/src/gallium/drivers/svga/s

[Mesa-dev] [PATCH 9/9] r600/eg: set cap to denote we'd like to lower int->64bit conversions.

From: Dave Airlie Cayman has no hw to do this, try and use some common code. This fixes: KHR-GL43.gpu_shader_fp64.fp64.conversions and a bunch of uint/uvec/int/ivec -> double piglits. on cayman. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe.c | 1 + 1 file changed, 1 inser

[Mesa-dev] [PATCH 7/9] gallium: add cap denote we want to lower integer->double conversions.

From: Dave Airlie Cayman hw can't handle this, so I'd like to lower it in the GLSL compiler. TODO: add CAP to all the screens. Signed-off-by: Dave Airlie --- src/gallium/include/pipe/p_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/ga

[Mesa-dev] [PATCH 2/9] glsl: add u64->fp64 and i64->fp64 builtins.

From: Elie Tournier This adds the first two fp64 builtins. They are for int/uint to fp64 conversions. cayman hw can't do it, and this avoids me having to lower it in the backend, and also starts to provide some of the soft fp64 infrastructure. [airlied: extracted from Elie's tree] Signed-off-by

[Mesa-dev] [PATCH 8/9] st/glsl: lower int->fp64 conversion if cap is set.

From: Dave Airlie This just enables the lowering if requested. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_t

[Mesa-dev] [PATCH 6/9] glsl/lower_64bit: add flag to denote we want to lower int/uint->double

From: Dave Airlie Some hardware has no conversion for these (cayman), so we want to lower them early using the common code. This adds a flag to allow the lowering pass to take these conversions into consideration. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir_optimization.h | 2 ++ src/

[Mesa-dev] some initial fp64 lowering to fix some cayman tests

Elie has been working on soft-fp64 code in a branch for a while, and I've been slowly helping trying to get it in place so we can enable GL4.x on the evergreen GPUs. However I've discovered on cayman we don't have int->double or uint->double support, and my conversion functions which did (int->f32

[Mesa-dev] [PATCH 1/9] glsl: rename lower_int64 to lower_64bit.

From: Elie Tournier This can also be used to lower some double ops. [airlied: this is extract from Elie's work into a standalone patch] Signed-off-by: Dave Airlie --- src/compiler/Makefile.sources | 2 +- src/compiler/glsl/ir_optimization.h| 4 ++--

[Mesa-dev] [PATCH 4/9] glsl/lower_64bit: use the correct packing function for doubles

From: Dave Airlie This picks the correct double packing function. Signed-off-by: Dave Airlie --- src/compiler/glsl/lower_64bit.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/lower_64bit.cpp b/src/compiler/glsl/lower_64bit.cpp index c7c6d1cb31..

[Mesa-dev] [PATCH 3/9] glsl/lower_64bit: extract non-64bit sources from vectors.

From: Dave Airlie In order to deal with conversions properly we need to extract non-64bit sources from vectors instead of expanding them as the 64-bit code does. We need non-64bit sources for the 32->64 conversion functions. Signed-off-by: Dave Airlie --- src/compiler/glsl/lower_64bit.cpp | 3

[Mesa-dev] [PATCH 5/9] glsl/lower_64bit: add ability to handle 32-bit sources.

From: Dave Airlie If this function saw a 32-bit source it would just return the IR without doing any conversion, this adds the ability to denote where 32-bit sources are expected and will be used in subsequent patches to add 32->64 conversions. Signed-off-by: Dave Airlie --- src/compiler/glsl/

[Mesa-dev] [PATCH] r600/cayman: initial attempt at gl_HelperInvocation (v2)

From: Dave Airlie This is a cayman only patch, it doesn't appear that evergreen supports the ALU on VPM. I'll try and figure it out later. All I can say for this patch is it passes the piglit test and the CTS tests. This also disable sb for helper invocations until it can handle the special ALU

[Mesa-dev] [PATCH] r600/eg: make sure we allow vpm bit on other CF ops.

From: Dave Airlie the vpm bit wasn't being applied to the push/pop instructions. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/eg_asm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/eg_asm.c b/src/gallium/drivers/r600/eg_asm.c index f8651bd..c03a9d8 10

[Mesa-dev] [PATCH] i965: Call prepare_external after implicit window-system MSAA resolves

This fixes some rendering corruption in a couple of Android apps that use window-system MSAA. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104741 Cc: mesa-sta...@lists.freedesktop.org Cc: Chad Versace --- src/mesa/drivers/dri/i965/brw_context.c | 15 +++ 1 file changed, 15

Re: [Mesa-dev] [PATCH] r600: fix buffer resinfo opcode translation.

Ah I see now how that's supposed to work... Previous to adding GET_BUFFER_RESINFO the op was just a fixed zero, and the op for this is the same on eg/cm (and we should not hit it with r600). But indeed that looks more like the code elsewhere... Reviewed-by: Roland Scheidegger Am 01.02.2018 um 01

Re: [Mesa-dev] [PATCH v3 06/24] anv/image: Add a helper for determining when fast clears are supported

On Mon, Jan 22, 2018 at 12:19:33AM -0800, Jason Ekstrand wrote: > v2 (Jason Ekstrand): > - Return an enum instead of a boolean > > v3 (Jason Ekstrand): > - Return ANV_FAST_CLEAR_NONE instead of false (Topi) > - Rename ANV_FAST_CLEAR_ANY to ANV_FAST_CLEAR_DEFAULT_VALUE > - Add documentation for

[Mesa-dev] [PATCH] r600: fix buffer resinfo opcode translation.

From: Dave Airlie The vtx operations never got translated, so things worked by 0 being equal to 0, translate them so we can use the proper buffer resinfo code. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_asm.c| 2 +- src/gallium/drivers/r600/r600_shader.c | 2 +- 2 files c

Re: [Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

On Jan 31, 2018 11:14 PM, "Eric Anholt" wrote: Marek Olšák writes: > From: Marek Olšák > > very few drivers actually implement it. I disagree. If the hardware supports it and the API supports it, then we should support it, too. I've got a branch around somewhere for vc4 dithering. Fair en

Re: [Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

Marek Olšák writes: > From: Marek Olšák > > very few drivers actually implement it. I disagree. If the hardware supports it and the API supports it, then we should support it, too. I've got a branch around somewhere for vc4 dithering. signature.asc Description: PGP signature ___

Re: [Mesa-dev] [PATCH] st/glsl_to_nir: add more nir opts to st_nir_opts()

Timothy Arceri writes: > All of the current gallium nir driver use these optimisations but > they do so in their backends. Having these called in the backend > only can cause a number of problems: > > - Shader compile times are greater because the opts need to do > significant passes over all s

Re: [Mesa-dev] [PATCH 1/5] mesa: change ctx->Color.ColorMask into a 32-bit bitmask

On Wed, Jan 31, 2018 at 9:31 PM, Roland Scheidegger wrote: > Am 31.01.2018 um 20:55 schrieb Marek Olšák: >> From: Marek Olšák >> >> 4 bits per draw buffer, 8 draw buffers in total --> 32 bits. >> >> This is easier to work with. >> --- >> src/mesa/drivers/common/driverfuncs.c| 8 ++--

Re: [Mesa-dev] [PATCH] i965: Bump official kernel requirement to Linux v3.9.

Quoting Kenneth Graunke (2018-01-31 19:33:13) > In commit 3f353342a6b6744773c26ed66b12afed42bd57af (present in 17.3.0) > we started unconditionally using I915_EXEC_NO_RELOC, which was > introduced in Linux v3.9. ChromeOS kernel 3.8 has backported this, > so it should work too. > > Running on olde

Re: [Mesa-dev] [PATCH 1/5] mesa: change ctx->Color.ColorMask into a 32-bit bitmask

Am 31.01.2018 um 20:55 schrieb Marek Olšák: > From: Marek Olšák > > 4 bits per draw buffer, 8 draw buffers in total --> 32 bits. > > This is easier to work with. > --- > src/mesa/drivers/common/driverfuncs.c| 8 ++-- > src/mesa/drivers/common/meta.c | 41 +++--

Re: [Mesa-dev] [PATCH] st/glsl_to_nir: add more nir opts to st_nir_opts()

Reviewed-by: Marek Olšák Marek On Wed, Jan 31, 2018 at 3:00 AM, Timothy Arceri wrote: > I forgot to add that adding the opts also required some of the lowering > passes to be called slightly earlier. > > > On 31/01/18 12:58, Timothy Arceri wrote: >> >> All of the current gallium nir driver use

Re: [Mesa-dev] [PATCH] gallium/st/clover: remove unused PIPE_SHADER_IR_LLVM

Acked-by: Marek Olšák Marek On Wed, Jan 31, 2018 at 6:37 AM, Timothy Arceri wrote: > On 31/01/18 15:05, Timothy Arceri wrote: >> >> This has been unused since 100796c15c3a. >> --- >> >> Please note this is not even compile tested as I don't have clover > >> 7.0.0 repo to go with my current ll

Re: [Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

On Wed, Jan 31, 2018 at 2:59 PM, Marek Olšák wrote: > On Wed, Jan 31, 2018 at 8:58 PM, Ilia Mirkin wrote: >> nine uses it, GL uses it, a bunch of drivers implement it ... why is >> it being removed? > > very few drivers actually implement it. nv30, a2xx-a4xx, etnaviv, i915, virgl. None of the m

Re: [Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

On Wed, Jan 31, 2018 at 8:58 PM, Ilia Mirkin wrote: > nine uses it, GL uses it, a bunch of drivers implement it ... why is > it being removed? very few drivers actually implement it. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https:

Re: [Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

nine uses it, GL uses it, a bunch of drivers implement it ... why is it being removed? On Wed, Jan 31, 2018 at 2:55 PM, Marek Olšák wrote: > From: Marek Olšák > > very few drivers actually implement it. > --- > src/gallium/auxiliary/util/u_dump_state.c | 1 - > src/gallium/auxiliary/vl/vl

[Mesa-dev] [PATCH] gallium: remove pipe_blend_state::dither

From: Marek Olšák very few drivers actually implement it. --- src/gallium/auxiliary/util/u_dump_state.c | 1 - src/gallium/auxiliary/vl/vl_compositor.c | 1 - src/gallium/auxiliary/vl/vl_idct.c | 1 - src/gallium/auxiliary/vl/vl_mc.c | 1 - src/gallium/au

[Mesa-dev] [PATCH 4/5] st/mesa: don't translate blend state when color writes are disabled

From: Marek Olšák --- src/mesa/state_tracker/st_atom_blend.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_blend.c b/src/mesa/state_tracker/st_atom_blend.c index 62042a6..24ef09b 100644 --- a/src/mesa/state_tracker/st_atom_blend.c

[Mesa-dev] [PATCH 1/5] mesa: change ctx->Color.ColorMask into a 32-bit bitmask

From: Marek Olšák 4 bits per draw buffer, 8 draw buffers in total --> 32 bits. This is easier to work with. --- src/mesa/drivers/common/driverfuncs.c| 8 ++-- src/mesa/drivers/common/meta.c | 41 +++--- src/mesa/drivers/common/meta.h

[Mesa-dev] [PATCH 5/5] st/mesa: generate blend state according to the number of enabled color buffers

From: Marek Olšák Non-MRT cases always translate blend state for 1 color buffer only. MRT cases only check and translate blend state for enabled color buffers. This also avoids an assertion failure in translate_blend for: dEQP-GLES31.functional.draw_buffers_indexed.overwrite_common.common_adv

[Mesa-dev] [PATCH 3/5] st/mesa: don't translate blend state when it's disabled for a colorbuffer

From: Marek Olšák --- src/mesa/state_tracker/st_atom_blend.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_blend.c b/src/mesa/state_tracker/st_atom_blend.c index 8f644ba..62042a6 100644 --- a/src/mesa/state_tracker/st_atom_blend.c +++ b/sr

[Mesa-dev] [PATCH 2/5] st/mesa: don't check for ARB_draw_buffers_blend in update_blend

From: Marek Olšák If the GL API is missing, different blend functions can't be set through GL. --- src/mesa/state_tracker/st_atom_blend.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_blend.c b/src/mesa/state_tracker/st_

[Mesa-dev] [PATCH] mesa: don't flag _NEW_COLOR for KHR adv.blend if prog constant doesn't change

From: Marek Olšák This only affects drivers that set DriverFlags.NewBlend. v2: - fix typo advanded -> advanced - return "enum gl_advanced_blend_mode" from _mesa_get_advanced_blend_sh_constant - don't call FLUSH_VERTICES twice --- src/mesa/main/blend.c | 6 -- src/

[Mesa-dev] [PATCH] i965: Bump official kernel requirement to Linux v3.9.

In commit 3f353342a6b6744773c26ed66b12afed42bd57af (present in 17.3.0) we started unconditionally using I915_EXEC_NO_RELOC, which was introduced in Linux v3.9. ChromeOS kernel 3.8 has backported this, so it should work too. Running on older kernels would likely result in every single batch being

[Mesa-dev] [PATCH 2/2] radv: run nir_opt_shrink_load

LLVM can't shrink loads. Totals from affected shaders: SGPRS: 62528 -> 59955 (-4.11 %) VGPRS: 44708 -> 44616 (-0.21 %) Spilled SGPRs: 16 -> 8 (-50.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size: 1355528 -> 135517

[Mesa-dev] [PATCH 1/2] nir: add nir_opt_shrink_load pass

This is a very simple pass that just shrinks load_push_constant intrinsics when some components are unused. For now, it can just shrink vec4 to vec3, vec3 to vec2 and so on. Signed-off-by: Samuel Pitoiset --- src/compiler/Makefile.sources | 1 + src/compiler/nir/meson.build

[Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c v3

Don't want an overly large numBufferBarriers/numTextureBarriers to blow up the stack. v2: handle malloc errors v3: fix patch Suggested-by: Emil Velikov Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 48 +++-- 1 file changed, 42 inserti

Re: [Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c v2

On 2018-01-31 01:25 PM, Andres Rodriguez wrote: Don't want an overly large numBufferBarriers/numTextureBarriers to blow up the stack. v2: handle malloc errors Someone forgot to update his patch correctly before sending it out... Suggested-by: Emil Velikov Signed-off-by: Andres Rodriguez

Re: [Mesa-dev] [PATCH v2] i965: perform 2 uploads with dual slot *64*PASSTHRU formats on gen<8

Ugh, I had to read this change many times to understand it, but I do think it makes sense. The comments in the code helped a lot too. Reviewed-by: Rafael Antognolli On Mon, Jan 29, 2018 at 06:25:30PM +0200, Andres Gomez wrote: > The emission of vertex attributes corresponding to dvec3 and dvec4

[Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c v2

Don't want an overly large numBufferBarriers/numTextureBarriers to blow up the stack. v2: handle malloc errors Suggested-by: Emil Velikov Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/

Re: [Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c

On 31 January 2018 at 17:30, Andres Rodriguez wrote: > Don't want an overly large numBufferBarriers/numTextureBarriers to blow > up the stack. > > Suggested-by: Emil Velikov > Signed-off-by: Andres Rodriguez > --- Thanks for sorting this Andres. > src/mesa/main/externalobjects.c | 14 +

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

On Tue, Jan 30, 2018 at 05:14:39PM -0800, Jason Ekstrand wrote: > On Tue, Jan 30, 2018 at 5:03 PM, Nanley Chery wrote: > > > On Tue, Jan 30, 2018 at 04:25:59PM -0800, Jason Ekstrand wrote: > > > On Tue, Jan 30, 2018 at 2:54 PM, Nanley Chery > > wrote: > > > > > > > On Fri, Jan 19, 2018 at 03:47:

[Mesa-dev] [PATCH mesa] gallium/util: used designated initialisers in formats table

Signed-off-by: Eric Engestrom --- v2: I missed a few lines in v1 for some reason; converted as well --- src/gallium/auxiliary/util/u_format_table.py | 108 ++- 1 file changed, 55 insertions(+), 53 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_table.py b/s

[Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c

Don't want an overly large numBufferBarriers/numTextureBarriers to blow up the stack. Suggested-by: Emil Velikov Signed-off-by: Andres Rodriguez --- src/mesa/main/externalobjects.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/externalobjects.

Re: [Mesa-dev] [PATCH] docs/features: mark EXT_semaphore(_fd) as DONE v2

Reviewed-by: Samuel Pitoiset On 01/31/2018 06:04 PM, Andres Rodriguez wrote: Support for these extensions is available in radeonsi. v2: also updated relnotes Signed-off-by: Andres Rodriguez --- Let me know if the formatting for the relnotes is what is expected. I based it on the previous ve

Re: [Mesa-dev] [PATCH 2/4] ac/shader: repack ac_shader_info

Patches 1 & 2: Reviewed-by: Nicolai Hähnle On 31.01.2018 00:41, Dave Airlie wrote: From: Dave Airlie This reduces the size from 28->24 bytes. Signed-off-by: Dave Airlie --- src/amd/common/ac_shader_info.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/commo

Re: [Mesa-dev] [PATCH 12/20] mesa: implement buffer/texture barriers for semaphore signal/wait v2

On 31 January 2018 at 15:20, Jon Turney wrote: > On 23/01/2018 18:05, Andres Rodriguez wrote: >> >> Make sure memory is accessible to the external client, for the specified >> memory object, before the signal/after the wait. >> >> v2: fixed flush order with respect to wait/signal emission >> >> Si

[Mesa-dev] [PATCH] docs/features: mark EXT_semaphore(_fd) as DONE v2

Support for these extensions is available in radeonsi. v2: also updated relnotes Signed-off-by: Andres Rodriguez --- Let me know if the formatting for the relnotes is what is expected. I based it on the previous versions. docs/features.txt | 4 ++-- docs/relnotes/18.1.0.html | 3 ++-

Re: [Mesa-dev] [PATCH 1/8] vbo: Correctly handle attribute offsets in dlist draw.

On 01/31/2018 09:54 AM, Brian Paul wrote: Hi Matthias, Nice work!  It's nice to get rid of some of those attribute loops. The series looks good to me, just assorted nit-picks and comments on a few patches. Oh, and it might be good to write a new piglit test or two to exercise the POS/GENERIC

Re: [Mesa-dev] [PATCH 5/8] vbo: Use static const VERT_ATTRIB->VBO_ATTRIB maps.

On 01/31/2018 12:55 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Instead of each context having its own map instance for this purpose, use a global static const map. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_context.c| 23 ++ src/mesa/vbo/vbo_exec.

Re: [Mesa-dev] [PATCH 4/8] mesa: Track position/generic0 aliasing in the VAO.

On 01/31/2018 12:55 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Since the first material attribute no longer aliases with the generic0 attribute, only aliasing between generic0 and position is left and entirely dependent on the enabled state of the VAO. So introduce a gl_attribu

Re: [Mesa-dev] [PATCH 1/8] vbo: Correctly handle attribute offsets in dlist draw.

Hi Matthias, Nice work! It's nice to get rid of some of those attribute loops. The series looks good to me, just assorted nit-picks and comments on a few patches. -Brian On 01/31/2018 12:55 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich When executing a display list draw, fo

Re: [Mesa-dev] [PATCH 3/8] mesa: Put materials at the end of the generic block.

On 01/31/2018 12:55 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich The materials are now moved to the end of the generic attributes block to the range 4-15. Before, the way the position and generic 0 attribute is handled was dependent on the presence and kind of the currently atta

[Mesa-dev] [Bug 104836] Missing library link breaks mesa on Debian/ia64

https://bugs.freedesktop.org/show_bug.cgi?id=104836 --- Comment #3 from Emil Velikov --- Having played with this at bit - it's a massive yak exercise. It's not a new bug by any means, so I'll lower it, slightly, on my priority list. Will CC you on the series when it's finished. -- You are rece

Re: [Mesa-dev] [PATCH 4/6] meson: osx doesn't have librt, so don't require it

On 31 January 2018 at 16:07, Jon Turney wrote: > On 31/01/2018 15:21, Emil Velikov wrote: >> >> On 30 January 2018 at 20:27, Dylan Baker wrote: >>> >>> Quoting Emil Velikov (2018-01-30 10:56:42) Hi Jon, On 28 January 2018 at 14:24, Jon Turney wrote: > > --- >

Re: [Mesa-dev] [PATCH 4/6] meson: osx doesn't have librt, so don't require it

On 31/01/2018 15:21, Emil Velikov wrote: On 30 January 2018 at 20:27, Dylan Baker wrote: Quoting Emil Velikov (2018-01-30 10:56:42) Hi Jon, On 28 January 2018 at 14:24, Jon Turney wrote: --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/mes

Re: [Mesa-dev] misc pahole repacking

On 01/31/2018 01:48 AM, Tapani Pälli wrote: Reviewed-by: Tapani Pälli (I verified the 1st one and I trust you on the 2nd one.) BTW I witnessed pahole crashing when processing visit() methods of ir_print_visitor class, did you experience that? My pahole version is 1.9, it dies in /lib64/libdw

[Mesa-dev] [Bug 104777] Attaching multiple shader objects for the same stage to a GLSL program triggers a linker error

https://bugs.freedesktop.org/show_bug.cgi?id=104777 Anton Sudak changed: What|Removed |Added CC||anton.su...@gmail.com -- You are receivi

Re: [Mesa-dev] [PATCH 4/6] meson: osx doesn't have librt, so don't require it

On 30 January 2018 at 20:27, Dylan Baker wrote: > Quoting Emil Velikov (2018-01-30 10:56:42) >> Hi Jon, >> >> On 28 January 2018 at 14:24, Jon Turney wrote: >> > --- >> > meson.build | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/meson.build b/meson.build >> >

Re: [Mesa-dev] [PATCH 12/20] mesa: implement buffer/texture barriers for semaphore signal/wait v2

On 23/01/2018 18:05, Andres Rodriguez wrote: Make sure memory is accessible to the external client, for the specified memory object, before the signal/after the wait. v2: fixed flush order with respect to wait/signal emission Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h

Re: [Mesa-dev] [PATCH 4/7] glsl/tests: changes to test_disk_cache_create test

On 31 January 2018 at 13:55, Tapani Pälli wrote: > > > On 31.01.2018 15:51, Tapani Pälli wrote: >> >> >> >> On 31.01.2018 15:41, Emil Velikov wrote: >>> >>> On 31 January 2018 at 07:17, Tapani Pälli wrote: >>> - /* Before doing anything else, ensure that with -* MESA_GLSL_CACHE_DI

[Mesa-dev] [PATCH] radv: do not insert shaders in cache when it's disabled

When the application doesn't provide its own pipeline cache, the driver uses a in-memory cache but it shouldn't insert any entries when the cache is explicitely disabled by the user. Found while running my experimental pipeline-db tool with a ton of shaders, the memory footprint was just huge, and

Re: [Mesa-dev] [PATCH v2 5/7] disk cache: initialize cache path and index only when used

On 31 January 2018 at 13:39, Tapani Pälli wrote: > > > On 31.01.2018 15:18, Emil Velikov wrote: >> >> On 31 January 2018 at 07:17, Tapani Pälli wrote: >>> >>> This patch makes disk_cache initialize path and index lazily so >>> that we can utilize disk_cache without a path using callback >>> funct

Re: [Mesa-dev] [PATCH 4/7] glsl/tests: changes to test_disk_cache_create test

On 31.01.2018 15:51, Tapani Pälli wrote: On 31.01.2018 15:41, Emil Velikov wrote: On 31 January 2018 at 07:17, Tapani Pälli wrote: -   /* Before doing anything else, ensure that with -    * MESA_GLSL_CACHE_DISABLE set to true, that disk_cache_create returns NULL. -    */ -   setenv("MES

Re: [Mesa-dev] [PATCH 4/7] glsl/tests: changes to test_disk_cache_create test

On 31.01.2018 15:41, Emil Velikov wrote: On 31 January 2018 at 07:17, Tapani Pälli wrote: - /* Before doing anything else, ensure that with -* MESA_GLSL_CACHE_DISABLE set to true, that disk_cache_create returns NULL. -*/ - setenv("MESA_GLSL_CACHE_DISABLE", "true", 1); - cache =

Re: [Mesa-dev] [PATCH 4/7] glsl/tests: changes to test_disk_cache_create test

On 31 January 2018 at 07:17, Tapani Pälli wrote: > - /* Before doing anything else, ensure that with > -* MESA_GLSL_CACHE_DISABLE set to true, that disk_cache_create returns > NULL. > -*/ > - setenv("MESA_GLSL_CACHE_DISABLE", "true", 1); > - cache = disk_cache_create("test", "make_

Re: [Mesa-dev] [PATCH v2 5/7] disk cache: initialize cache path and index only when used

On 31.01.2018 15:18, Emil Velikov wrote: On 31 January 2018 at 07:17, Tapani Pälli wrote: This patch makes disk_cache initialize path and index lazily so that we can utilize disk_cache without a path using callback functionality introduced by next patch. v2: unmap mmap and destroy queue only

Re: [Mesa-dev] [PATCH v2 2/7] egl: add support for EGL_ANDROID_blob_cache

On 31.01.2018 15:07, Tapani Pälli wrote: On 31.01.2018 13:58, Emil Velikov wrote: On 31 January 2018 at 07:17, Tapani Pälli wrote: v2: cleanup, move callbacks to _egl_display struct (Emil Velikov) adapt to earlier ctx->screen changes Signed-off-by: Tapani Pälli ---   src/egl/drivers

Re: [Mesa-dev] [PATCH 1/4] mesa: don't flag _NEW_COLOR for KHR adv.blend if prog constant doesn't change

On Wed, Jan 31, 2018 at 4:34 AM, Ian Romanick wrote: > On 01/30/2018 07:48 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> This only affects drivers that set DriverFlags.NewBlend. >> --- >> src/mesa/main/blend.c | 6 -- >> src/mesa/main/blend.h | 41 >> +++

Re: [Mesa-dev] [PATCH v2 5/7] disk cache: initialize cache path and index only when used

On 31 January 2018 at 07:17, Tapani Pälli wrote: > This patch makes disk_cache initialize path and index lazily so > that we can utilize disk_cache without a path using callback > functionality introduced by next patch. > > v2: unmap mmap and destroy queue only if index_mmap exists > > Signed-off-

Re: [Mesa-dev] [PATCH] mesa: fix broken glGet*(GL_POLYGON_MODE) query

Reviewed-by: Marek Olšák Marek On Wed, Jan 31, 2018 at 3:35 AM, Brian Paul wrote: > This reverts part of the patch which introduced the GLenum16 change. > Fixes a conform regression found by Roland. > > Fixes: f96a69f916aed405 ("mesa: replace GLenum with GLenum16 in > common structures (v4)") >

  1   2   >