Re: [Mesa-dev] [PATCH] loader_dri3/glx/egl: Reinstate the loader_dri3_vtable get_dri_screen callback

2018-02-12 Thread Thomas Hellstrom
Hi! It would be good if somebody could review this so we can get the fix in. Thanks, Thomas On 02/09/2018 09:37 AM, Thomas Hellstrom wrote: Removing this callback caused rendering corruption in some multi-screen cases, so it is reinstated but without the drawable argument which was never

[Mesa-dev] [Bug 105068] vulkaninfo gives an VK_ERROR_INITIALIZATION_FAILED

2018-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105068 leigh scott changed: What|Removed |Added See Also|

Re: [Mesa-dev] [PATCH shaderdb 1/3] intel_stub: override pci-id only if INTEL_DEVID_OVERRIDE is set

2018-02-12 Thread Kenneth Graunke
On Monday, February 12, 2018 5:26:14 PM PST Dongwon Kim wrote: > To prevent a segfault, pci-id is set only if INTEL_DEVID_OVERRIDE exists. > > Signed-off-by: Dongwon Kim > --- > intel_stub.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH] ac: implement nir_intrinsic_image_samples

2018-02-12 Thread Timothy Arceri
Fixes cts test: KHR-GL45.shader_texture_image_samples_tests.image_functional_test --- src/amd/common/ac_nir_to_llvm.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 3af3dbace2..8d1eed241f 100644

Re: [Mesa-dev] [PATCH] tgsi: Recognize RET in main for tgsi_transform

2018-02-12 Thread Brian Paul
LGTM. Reviewed-by: Brian Paul On 02/12/2018 09:10 PM, srol...@vmware.com wrote: From: Roland Scheidegger Shaders coming from dx10 state trackers have a RET before the END. And the epilog needs to be placed before the RET (otherwise it will get

Re: [Mesa-dev] [PATCH] mesa: add glsl version query (v3)

2018-02-12 Thread Brian Paul
One more thing: version checks... On 02/08/2018 02:26 AM, Vadym Shovkoplias wrote: Add support for GL_NUM_SHADING_LANGUAGE_VERSIONS and glGetStringi for GL_SHADING_LANGUAGE_VERSION v2: - Combine similar functionality into _mesa_get_shading_language_version() function. - Change GLSL

[Mesa-dev] [PATCH] tgsi: Recognize RET in main for tgsi_transform

2018-02-12 Thread sroland
From: Roland Scheidegger Shaders coming from dx10 state trackers have a RET before the END. And the epilog needs to be placed before the RET (otherwise it will get ignored). Hence figure out if a RET is in main, in this case we'll place the epilog there rather than before the

[Mesa-dev] [PATCH] virgl: add ARB_sample_shading support.

2018-02-12 Thread Dave Airlie
From: Dave Airlie This enable ARB_sample_shading if the renderer supports it. Signed-off-by: Dave Airlie --- src/gallium/drivers/virgl/virgl_encode.c | 3 ++- src/gallium/drivers/virgl/virgl_protocol.h | 1 + src/gallium/drivers/virgl/virgl_screen.c

Re: [Mesa-dev] [PATCH 17/17] glsl: Suppress sign-compare warning generated by flex 2.6.1.

2018-02-12 Thread Timothy Arceri
On 13/02/18 06:59, Ian Romanick wrote: Supposedly later versions of flex fix this... or so I heard. Yes it's fixed in recent versions. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] virgl: add ARB_draw_indirect support.

2018-02-12 Thread Dave Airlie
From: Dave Airlie This relies on the renderer code landing first. Signed-off-by: Dave Airlie --- src/gallium/drivers/virgl/virgl_encode.c | 15 ++- src/gallium/drivers/virgl/virgl_protocol.h | 12

[Mesa-dev] [Bug 105067] Tesselation broken for dEQP tests

2018-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105067 Marek Olšák changed: What|Removed |Added Assignee|mar...@gmail.com

[Mesa-dev] [Bug 105068] vulkaninfo gives an VK_ERROR_INITIALIZATION_FAILED

2018-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105068 Bug ID: 105068 Summary: vulkaninfo gives an VK_ERROR_INITIALIZATION_FAILED Product: Mesa Version: 17.2 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [PATCH 2/2] anv/pipeline: Set the correct binding count for compute shaders

2018-02-12 Thread Jason Ekstrand
--- src/intel/vulkan/genX_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index 45ebe31..4aee9ec 100644 --- a/src/intel/vulkan/genX_pipeline.c +++ b/src/intel/vulkan/genX_pipeline.c @@ -1836,7

[Mesa-dev] [PATCH 1/2] intel/aubinator: Correctly decode INTERFACE_DESCRIPTOR_DATA

2018-02-12 Thread Jason Ekstrand
--- src/intel/tools/gen_batch_decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/gen_batch_decoder.c b/src/intel/tools/gen_batch_decoder.c index 78db83b..1a8794c 100644 --- a/src/intel/tools/gen_batch_decoder.c +++ b/src/intel/tools/gen_batch_decoder.c

[Mesa-dev] [PATCH 2/2] st: add NIR GL_ARB_get_program_binary support

2018-02-12 Thread Timothy Arceri
--- src/mesa/state_tracker/st_context.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index 7e721572e0..e23f9fd70b 100644 --- a/src/mesa/state_tracker/st_context.c +++

[Mesa-dev] [PATCH 1/2] st/shader_cache: add st_{de}serialise_nir_program() helpers

2018-02-12 Thread Timothy Arceri
These will be used for NIR GL_ARB_get_program_binary support. --- src/mesa/state_tracker/st_shader_cache.c | 14 ++ src/mesa/state_tracker/st_shader_cache.h | 8 2 files changed, 22 insertions(+) diff --git a/src/mesa/state_tracker/st_shader_cache.c

[Mesa-dev] [Bug 105029] simdlib_512_avx512.inl:371:57: error: could not convert ‘_mm512_mask_blend_epi32((__mmask16)(ImmT), a, b)’ from ‘__m512i’ {aka ‘__vector(8) long long int’} to ‘SIMDImpl::SIMD51

2018-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105029 George Kyriazis changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] i965: fix tessellation regressions with gl_state_index16

2018-02-12 Thread Dave Airlie
From: Dave Airlie Looks like one conversion was missed. Fixes: e149a0253 (mesa,glsl,nir: reduce gl_state_index size to 2 bytes) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105067 Signed-off-by: Dave Airlie ---

[Mesa-dev] [Bug 105067] Tesselation broken for dEQP tests

2018-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105067 Bug ID: 105067 Summary: Tesselation broken for dEQP tests Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 2/2] anv: Be more careful about fast-clear colors

2018-02-12 Thread Jason Ekstrand
On Mon, Feb 12, 2018 at 5:11 PM, Nanley Chery wrote: > On Mon, Feb 12, 2018 at 04:35:20PM -0800, Jason Ekstrand wrote: > > Previously, we just used all the channels regardless of the format. > > This is less than ideal because some channels may have undefined values > >

[Mesa-dev] [PATCH shaderdb 2/3] run: new '--pci-id' option for overriding pci-id

2018-02-12 Thread Dongwon Kim
Add a new option, '--pciid' to override a pci id of the target arch to support cross-architecture shader compilation. Not like "-p" option, it is for accepting any GFX devices supported by the driver. Setting both "-p" and "--pciid" is blocked to avoid conflict. Signed-off-by: Dongwon Kim

[Mesa-dev] [PATCH shaderdb 3/3] run: shader program file created via GetProgramBinary

2018-02-12 Thread Dongwon Kim
extraction of linked binary program to a file using glGetProgramBinary. This file is intended to be loaded by glProgramBinary in the graphic application running on the target system. A new option, '--out=' is available to be used for specifying the output file name. Signed-off-by: Dongwon Kim

[Mesa-dev] [PATCH shaderdb 1/3] intel_stub: override pci-id only if INTEL_DEVID_OVERRIDE is set

2018-02-12 Thread Dongwon Kim
To prevent a segfault, pci-id is set only if INTEL_DEVID_OVERRIDE exists. Signed-off-by: Dongwon Kim --- intel_stub.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/intel_stub.c b/intel_stub.c index ea88400..cf9ddff 100644 --- a/intel_stub.c

[Mesa-dev] [PATCH shaderdb 0/3] offline building of shader program for a desired target

2018-02-12 Thread Dongwon Kim
This series of changes are for making shaderdb as a complete standalone compiler that can create a shader program in binary form (using glGetProgramBinary), which can later be loaded on the target system specified by user (glProgramBinary). As a prerequisite, the patch "run: new '--pci-id'

[Mesa-dev] [PATCH] virgl: Support v2 caps struct (v2)

2018-02-12 Thread Dave Airlie
From: Stéphane Marchesin This struct allows us to report: - accurate max point size/line width. - accurate texel and texture gather offsets - vertex/geometry limits. Signed-off-by: Dave Airlie --- src/gallium/drivers/virgl/virgl_hw.h| 28

Re: [Mesa-dev] [PATCH 2/2] anv: Be more careful about fast-clear colors

2018-02-12 Thread Nanley Chery
On Mon, Feb 12, 2018 at 04:35:20PM -0800, Jason Ekstrand wrote: > Previously, we just used all the channels regardless of the format. > This is less than ideal because some channels may have undefined values > and this should be ok from the client's perspective. Even though the > driver should do

Re: [Mesa-dev] [PATCH 19/29] anv/cmd_buffer: Move the rest of clear_subpass into begin_subpass

2018-02-12 Thread Nanley Chery
On Thu, Feb 08, 2018 at 05:23:21PM -0800, Jason Ekstrand wrote: > On Thu, Feb 8, 2018 at 5:20 PM, Jason Ekstrand wrote: > > > On Fri, Jan 12, 2018 at 2:45 PM, Nanley Chery > > wrote: > > > >> On Mon, Nov 27, 2017 at 07:06:09PM -0800, Jason Ekstrand

[Mesa-dev] [PATCH 1/2] intel/isl: Add an isl_color_value_is_zero helper

2018-02-12 Thread Jason Ekstrand
Cc: mesa-sta...@lists.freedesktop.org --- src/intel/isl/isl.c | 20 src/intel/isl/isl.h | 3 +++ 2 files changed, 23 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 59f512f..f4b0502 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@

[Mesa-dev] [PATCH 2/2] anv: Be more careful about fast-clear colors

2018-02-12 Thread Jason Ekstrand
Previously, we just used all the channels regardless of the format. This is less than ideal because some channels may have undefined values and this should be ok from the client's perspective. Even though the driver should do the correct thing regardless of what is in the undefined value, it

Re: [Mesa-dev] [PATCH 6/7] vulkan: Add new VK_MESA_query_timestamp extension

2018-02-12 Thread Dylan Baker
Quoting Keith Packard (2018-02-09 20:45:15) > This extension adds a single function to query the current GPU > timestamp, just like glGetInteger64v(GL_TIMESTAMP, ). This > function is needed to complete the implementation of > GOOGLE_display_timing, which needs to be able to coorelate GPU and CPU

Re: [Mesa-dev] [PATCH 3/7] vulkan: Add EXT_acquire_xlib_display

2018-02-12 Thread Dylan Baker
Quoting Keith Packard (2018-02-09 20:45:12) > This extension adds the ability to borrow an X RandR output for > temporary use directly by a Vulkan application. For DRM, we use the > Linux resource leasing mechanism. > > Signed-off-by: Keith Packard > --- > configure.ac

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

2018-02-12 Thread Keith Packard
Emil Velikov writes: > A few top level comments: Thanks much for looking over this code. I realize it's a large amount of change and hence more work to review. > - using card/primary node and (missing) authentication > Current code opens the primary node when

Re: [Mesa-dev] [PATCH 04/13] mesa: decrease the array size of ctx->Texture.FixedFuncUnit to 8

2018-02-12 Thread Brian Paul
Minor nits below. Otherwise, for the series, Reviewed-by: Brian Paul On 02/08/2018 06:18 PM, Marek Olšák wrote: From: Marek Olšák GL allows doing glTexEnv on 192 texture units, while in reality, only MaxTextureCoordUnits units are used by fixed-func

[Mesa-dev] [PATCH] ac/nir_to_llvm: fix image size for arrays of arrays

2018-02-12 Thread Timothy Arceri
Fixes cts test: KHR-GL44.shader_image_size.advanced-changeSize --- src/amd/common/ac_nir_to_llvm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 15402694fc..c0a0da1656 100644 ---

Re: [Mesa-dev] [PATCH] anv: Don't resolve or ambiguate non-existent layers

2018-02-12 Thread Nanley Chery
On Mon, Feb 12, 2018 at 01:41:44PM -0800, Jason Ekstrand wrote: > The previous code was trying to avoid non-existent layers by taking a > MAX with anv_image_aux_layers. Unfortunately, it wasn't taking into ^ MIN With that fixed, this patch is Reviewed-by: Nanley Chery

[Mesa-dev] [PATCH] radeonsi/nir: fix shader ballot return value bitsize

2018-02-12 Thread Timothy Arceri
Fixes cts test: KHR-GL46.shader_ballot_tests.ShaderBallotFunctionBallot --- src/gallium/drivers/radeonsi/si_shader_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index

[Mesa-dev] [PATCH] virgl: fix caps ioctl size check.

2018-02-12 Thread Dave Airlie
From: Dave Airlie The size check seems backwards, if userspace gives us a size larger it is probably asking for a newer version of the caps, so we just fill in the caps version we have at the smaller size, and it can work it out from there. Userspace will probably still need

Re: [Mesa-dev] [PATCH] Move setting current_pipeline to cmd_state_init

2018-02-12 Thread Lionel Landwerlin
I guess the default context setup in the kernel is very 3D friendly. Reviewed-by: Lionel Landwerlin On 12/02/18 21:42, Jason Ekstrand wrote: We were setting current_pipeline to UINT32_MAX and then calling cmd_cmd_state_reset which memsets the entire state struct

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

2018-02-12 Thread Keith Packard
Eric Engestrom writes: > copy/paste error: s/drm/display/ That's actually intentional -- any system which supports 'drm' can support the display backend as it's based on that. Maybe it should use a different test? (note that I haven't been using the autotools backend

Re: [Mesa-dev] [PATCH] gallium: drop all the guard band float caps.

2018-02-12 Thread Roland Scheidegger
Looks alright to me. Not sure why they were introduced - d3d9 has queryable caps for them (d3d10 does not, allows guard band but not required). Maybe they were relevant for d3d9 software vertex processing mode at some point, but it looks like we never actually used them with gallium. Reviewed-by:

Re: [Mesa-dev] [PATCH 08/17] loader: Fix compiler warnings about truncating the PCI ID path.

2018-02-12 Thread Ian Romanick
On 02/10/2018 08:33 AM, Eric Anholt wrote: > My build was producing: > > ../src/loader/loader.c:121:67: warning: ‘%1u’ directive output may be > truncated writing between 1 and 3 bytes into a region of size 2 > [-Wformat-truncation=] > > and we can avoid this careful calculation by just using

Re: [Mesa-dev] [PATCH 09/17] spirv: Silence compiler warning about undefined srcs[0]

2018-02-12 Thread Ian Romanick
On 02/10/2018 08:33 AM, Eric Anholt wrote: > It doesn't know that elems >= 1. Does adding assume(elems >= 1) help? > Cc: Jason Ekstrand > --- > src/compiler/spirv/spirv_to_nir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH] Move setting current_pipeline to cmd_state_init

2018-02-12 Thread Jason Ekstrand
We were setting current_pipeline to UINT32_MAX and then calling cmd_cmd_state_reset which memsets the entire state struct to 0 which implicitly resets current_pipeline to 3D. I have no idea how this hasn't caused everything to explode. Fixes: cd3feea74582 "anv/cmd_buffer: Rework

[Mesa-dev] [PATCH] anv: Don't resolve or ambiguate non-existent layers

2018-02-12 Thread Jason Ekstrand
The previous code was trying to avoid non-existent layers by taking a MAX with anv_image_aux_layers. Unfortunately, it wasn't taking into account that layer_count starts at base_layer which may not be zero. Instead, we need to subtract base_layer from anv_image_aux_layers with a guard against

Re: [Mesa-dev] [PATCH] meson: use a custom target instead of a generator for i965 oa

2018-02-12 Thread Lionel Landwerlin
I ran into the same issue with gputop. Acked-by: Lionel Landwerlin On 12/02/18 20:00, Dylan Baker wrote: generators really are never the thing you want. The problem in this case is that a generator must create a file that contains any file that the generated

[Mesa-dev] [PATCH] meson: use a custom target instead of a generator for i965 oa

2018-02-12 Thread Dylan Baker
generators really are never the thing you want. The problem in this case is that a generator must create a file that contains any file that the generated target depends on. Since brw_oa.py doesn't generate such a file the generated sources are not regenerated even if the xml files they should

Re: [Mesa-dev] [PATCH 07/17] glsl: Silence warnings in the uniform initializer test about 16-bit types

2018-02-12 Thread Ian Romanick
Shutting up this warning has been (fairly low) on my to-do list for some time now... thanks for beating me to it. :) Reviewed-by: Ian Romanick On 02/10/2018 08:33 AM, Eric Anholt wrote: > They should probably get unit tests implemented, but this cleans up a > bunch of

Re: [Mesa-dev] [PATCH 11/17] glsl/tests: Fix a compiler warning about signed/unsigned loop comparison.

2018-02-12 Thread Ian Romanick
Reviewed-by: Ian Romanick On 02/10/2018 08:33 AM, Eric Anholt wrote: > Cc: Ian Romanick > Fixes: d32956935edf ("glsl: Walk a list of ir_dereference_array to mark array > elements as accessed") > --- >

Re: [Mesa-dev] [PATCH 17/17] glsl: Suppress sign-compare warning generated by flex 2.6.1.

2018-02-12 Thread Ian Romanick
Supposedly later versions of flex fix this... or so I heard. On 02/10/2018 08:33 AM, Eric Anholt wrote: > I got the following warning: > > src/compiler/glsl/glsl_lexer.cpp:1521:18: warning: comparison between signed > and unsigned integer expressions [-Wsign-compare] >for ( n = 0; n <

Re: [Mesa-dev] [PATCH 01/17] r200: Remove dead rop table

2018-02-12 Thread Ian Romanick
I thought I removed that... thanks for taking care of this. Reviewed-by: Ian Romanick On 02/10/2018 08:32 AM, Eric Anholt wrote: > Fixes: 0aaa27f29187 ("mesa: Pass the translated color logic op > dd_function_table::LogicOpcode") > Cc: Ian Romanick

Re: [Mesa-dev] [PATCH 3/6] i965: Use gen_get_pci_device_id_override

2018-02-12 Thread Jordan Justen
On 2018-02-12 10:53:47, Scott D Phillips wrote: > Jordan Justen writes: > > > Signed-off-by: Jordan Justen > > --- > > src/mesa/drivers/dri/i965/intel_screen.c | 55 > > ++-- > > 1 file changed, 3 insertions(+),

Re: [Mesa-dev] [PATCH 2/6] intel/common: Add gen_get_pci_device_id_override

2018-02-12 Thread Jordan Justen
On 2018-02-12 11:01:01, Scott D Phillips wrote: > Jordan Justen writes: > > > +/** > > + * Get the overridden PCI ID for the device. This is set with the > > + * INTEL_DEVID_OVERRIDE environment variable. > > + * > > + * Returns -1 if the override is not set. > > + */

[Mesa-dev] [PATCH] gallium: drop all the guard band float caps.

2018-02-12 Thread Dave Airlie
From: Dave Airlie Nobody queries these and nobody sets them to anything useful, the docs say TODO. Drop them until a use appears. Signed-off-by: Dave Airlie --- src/gallium/docs/source/screen.rst | 4

[Mesa-dev] [PATCH v4 12/12] meson: fix xvmc target linkage

2018-02-12 Thread Dylan Baker
This needs to link the state tracker with --whole-archive to expose the right symbols. v4: - Always add libswdri and libswkmsdri to the link_with list Fixes: 22a817af8a89eb3c7 ("meson: build gallium xvmc state tracker") Signed-off-by: Dylan Baker ---

[Mesa-dev] [PATCH v4 02/12] meson: add libswdri and libswkmsdri to link_with unconditionally

2018-02-12 Thread Dylan Baker
Fixes: 6b4c7047d571 ("meson: build gallium nine state_tracker") Signed-off-by: Dylan Baker --- src/gallium/targets/d3dadapter9/meson.build | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/gallium/targets/d3dadapter9/meson.build

[Mesa-dev] [PATCH v4 01/12] meson: define empty variables for libswdri and libswkmsdri

2018-02-12 Thread Dylan Baker
This allows these variables to unconditionally included in `link_with` lists, even if they're not used. This allows deleting duplicated logic in nearly every gallium target implemented in meson today. This also removes the now useless `build_by_default` flag from swdri and swkmsdri. v4: - add

[Mesa-dev] [PATCH v4 06/12] meson: actually link with libomxil-bellagio

2018-02-12 Thread Dylan Baker
This state tracker actually needs to link, unlike vdpau. Fixes: 1d36dc674d528b93b ("meson: build gallium omx state tracker") Signed-off-by: Dylan Baker --- meson.build | 5 - 1 file changed, 5 deletions(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v4 09/12] meson: fix va target linkage

2018-02-12 Thread Dylan Baker
The state tracker needs to be linked with whole-archive (like autotools). As a result there are symbols from libswdri and libswkmsdri that are needed, so link those as well. v4: - Always add libswdri and libswkmsdri to link_with list Fixes: 5a785d51a6d6 ("meson: build gallium va state tracker")

[Mesa-dev] [PATCH v4 00/12] meson: fix gallium media target linkage

2018-02-12 Thread Dylan Baker
The linkage of all of the gallium media targets is broken in various ways in the meson build. This series should correct that by doing more what the autotools build does. Changes since v2: - Add patch to fix va-api version checking - link xcb libs into vlwinsys instead of into each media state

[Mesa-dev] [PATCH v4 07/12] meson: Actually link xvmc target with libxvmc

2018-02-12 Thread Dylan Baker
Unlike vdpau this is required. Fixes: 22a817af8a89eb3c7 ("meson: build gallium xvmc state tracker") Signed-off-by: Dylan Baker --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index b5fa5a8..3925ec4 100644 --- a/meson.build

[Mesa-dev] [PATCH v4 11/12] meson: Fix xa target linkage

2018-02-12 Thread Dylan Baker
This needs to use --whole-archive (link_whole in meson) to properly expose symbols. v4: - Always add libswdri and libswkmsdri to link_with list Fixes: 0ba909f0f111824 ("meson: build gallium xa state tracker") Signed-off-by: Dylan Baker ---

[Mesa-dev] [PATCH v4 05/12] meson: link dri3 xcb libs into vlwinsys instead of into each target

2018-02-12 Thread Dylan Baker
This makes the dependencies easier to manage, since each media target doesn't need to worry about linking to half a dozen libraries. Fixes: b1b65397d0c4978e3 ("meson: Build gallium auxiliary") Signed-off-by: Dylan Baker --- src/gallium/auxiliary/meson.build|

[Mesa-dev] [PATCH v4 08/12] meson: fix vdpau target linkage

2018-02-12 Thread Dylan Baker
The VDPAU state tracker needs to be linked with whole-archive (autotools does this). Because we are linking the whole archive we alos need to link with libswdri and libswkmsdri if those have been enabled. v4: - Always add libswdri and libswkmsdri to link_with list Fixes: 68076b87474e7959

[Mesa-dev] [PATCH v4 03/12] meson: Unconditionally add libswdri and libswkmsdri to dri link_with

2018-02-12 Thread Dylan Baker
Fixes: b154b44ae342 ("meson: build radeonsi gallium driver") Signed-off-by: Dylan Baker --- src/gallium/targets/dri/meson.build | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/gallium/targets/dri/meson.build

[Mesa-dev] [PATCH v4 10/12] meson: Fix omx-bellagio target linkage

2018-02-12 Thread Dylan Baker
This needs to use --whole-archive (link_whole in meson) to properly expose symbols. v4: - Always add libswdri and libswkmsdri to link_with Fixes: 1d36dc674d528b93b ("meson: build gallium omx state tracker") Signed-off-by: Dylan Baker ---

[Mesa-dev] [PATCH v4 04/12] meson: use va-api version reported by pkg-config

2018-02-12 Thread Dylan Baker
Fixes: 5a785d51a6d6 ("meson: build gallium va state tracker") Signed-off-by: Dylan Baker --- meson.build | 2 +- src/gallium/state_trackers/va/meson.build | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/meson.build

Re: [Mesa-dev] [PATCH v2 0/8] The 2nd version for UVD HEVC encode

2018-02-12 Thread Zhu, James
On 2018-02-10 11:06 AM, Mark Thompson wrote: On 08/02/18 23:05, Mark Thompson wrote: On 08/02/18 22:37, Alex Deucher wrote: On Thu, Feb 8, 2018 at 5:28 PM, Mark Thompson wrote: On 06/02/18 20:05, James Zhu wrote: The whole series are the updated

Re: [Mesa-dev] [PATCH 2/6] intel/common: Add gen_get_pci_device_id_override

2018-02-12 Thread Scott D Phillips
Jordan Justen writes: > Signed-off-by: Jordan Justen > --- > src/intel/common/gen_device_info.c | 51 > ++ > src/intel/common/gen_device_info.h | 1 + > 2 files changed, 52 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 3/6] i965: Use gen_get_pci_device_id_override

2018-02-12 Thread Scott D Phillips
Jordan Justen writes: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/intel_screen.c | 55 > ++-- > 1 file changed, 3 insertions(+), 52 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] ac/shader: scan force_persample

2018-02-12 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Feb 12, 2018 at 3:57 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c | 5 ++--- > src/amd/common/ac_shader_info.c | 15

[Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

2018-02-12 Thread Daniel Stone
From: Jason Ekstrand This commit fixes two bugs in intel_from_planar. First, if the planar format was non-NULL but only had a single plane, we were falling through to the planar case. If we had a CCS modifier and plane == 1, we would return NULL instead of the CCS plane.

Re: [Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

2018-02-12 Thread Jason Ekstrand
On Mon, Feb 12, 2018 at 9:45 AM, Daniel Stone wrote: > Hi, > > On 12 February 2018 at 17:16, Jason Ekstrand wrote: > > On Mon, Feb 12, 2018 at 6:36 AM, Daniel Stone > wrote: > >> On further thought, I don't see how this could

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

2018-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104820 --- Comment #11 from Roman Gilg --- Apparently this is a bug in Qt: https://bugreports.qt.io/browse/QTBUG-66348 Workaround is to delete $HOME/.cache/qtshadercache -- You are receiving this mail because: You are the QA

Re: [Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

2018-02-12 Thread Daniel Stone
Hi, On 12 February 2018 at 17:16, Jason Ekstrand wrote: > On Mon, Feb 12, 2018 at 6:36 AM, Daniel Stone wrote: >> On further thought, I don't see how this could work at all. If we call >> fromPlanar on plane 0 of a non-planar image with an aux plane,

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

2018-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104820 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

2018-02-12 Thread Jason Ekstrand
On Mon, Feb 12, 2018 at 6:36 AM, Daniel Stone wrote: > Hi, > > On 10 February 2018 at 06:50, Jason Ekstrand wrote: > > -} else if (parent->planar_format == NULL) { > > + > > +const struct intel_image_format *f = parent->planar_format; > > +

Re: [Mesa-dev] [PATCH] disk cache: move path creation back to constructor

2018-02-12 Thread Emil Velikov
On 9 February 2018 at 05:44, Tapani Pälli wrote: > This patch moves disk cache path and index creation back to the > constructor which matches previous behavior. We still allow create > to succeed without path so that cache can be used with callback > functionality. > >

[Mesa-dev] [PATCH] Move setting current_pipeline to cmd_state_init

2018-02-12 Thread Jason Ekstrand
We were setting current_pipeline to UINT32_MAX and then calling cmd_cmd_state_reset which memsets the entire state struct to 0 which implicitly resets current_pipeline to 3D. I have no idea how this hasn't caused everything to explode. Fixes: cd3feea74582 "anv/cmd_buffer: Rework

Re: [Mesa-dev] [PATCH] gallium/hud: add pipe context parameter to extra HUD queries

2018-02-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Feb 12, 2018 at 5:05 PM, Lucas Stach wrote: > Those have been missed when the new parameter was introduced, leading to > incompatible pointer assignement warnings. > > Fixes: 3132afdf4c12 (gallium/hud: pass

Re: [Mesa-dev] [PATCH 4/4] radv: Return NULL for entrypoints when not supported.

2018-02-12 Thread Emil Velikov
Hi Bas, On 11 February 2018 at 15:29, Bas Nieuwenhuizen wrote: > This implements strict checking for the entrypoint ProcAddr > functions. > > - InstanceProcAddr with instance = NULL, only returns the 3 allowed >entrypoints. > - DeviceProcAddr does not return any

Re: [Mesa-dev] [PATCH] nir/spirv: add gl_spirv_validation method

2018-02-12 Thread Jason Ekstrand
On Tue, Jan 23, 2018 at 7:04 AM, Alejandro Piñeiro wrote: > Gentle ping to Jason, as he probably missed that I was trying (but > failed) to make a question. See below (also skipped most of the original > email) > > > On 18/01/18 13:31, Alejandro Piñeiro wrote: > > > > +

Re: [Mesa-dev] [PATCH 5/5] ac/nir: add nir_intrinsic_{load, store}_shared support

2018-02-12 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, Feb 9, 2018 at 2:48 AM, Timothy Arceri wrote: > --- > src/amd/common/ac_nir_to_llvm.c | 46 > + > 1 file changed, 46 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

2018-02-12 Thread Emil Velikov
Hi Keith, A few top level comments: - using card/primary node and (missing) authentication Current code opens the primary node when VK_KHR_display is available. Thus running a platform=drm,x11,wayland build will fail, as the client is not authenticated with the X/WL server. - reuse "drm" as a

[Mesa-dev] [PATCH] gallium/hud: add pipe context parameter to extra HUD queries

2018-02-12 Thread Lucas Stach
Those have been missed when the new parameter was introduced, leading to incompatible pointer assignement warnings. Fixes: 3132afdf4c12 (gallium/hud: pass pipe_context explicitly to most functions) CC: Signed-off-by: Lucas Stach ---

Re: [Mesa-dev] [PATCH 2/3] Revert "disk cache: initialize cache path and index only when used"

2018-02-12 Thread Marek Olšák
radeonsi uses the shader cache from multiple threads. Marek On Fri, Feb 9, 2018 at 4:59 AM, Timothy Arceri wrote: > This reverts commit 6a651b6b77b68db71a027c826abccc843ace88ef. > > This change was not thread safe. Applications are allowed to compile > multiple programs

Re: [Mesa-dev] [PATCH 3/3] Revert "i965: add __DRI2_BLOB support and set cache functions"

2018-02-12 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, Feb 9, 2018 at 4:59 AM, Timothy Arceri wrote: > This reverts commit 9d322fde9781f9fc53c3baac6995ab1cbd8d6135. > --- > src/mesa/drivers/dri/i965/intel_screen.c | 21 - > 1

[Mesa-dev] [Bug 102077] multilib mesa fail to build with "egl/drivers/dri2/platform_drm.c:542: undefined reference to `gbm_bo_get_bpp'"

2018-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102077 --- Comment #4 from Emil Velikov --- (In reply to Nix from comment #3) > This is actually a Mesa bug: the install-time link of libEGL.la is picking > up libgbm from the installation prefix rather than the

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

2018-02-12 Thread Eric Engestrom
On Friday, 2018-02-09 20:45:10 -0800, Keith Packard wrote: > This adds support for the KHR_display extension to the anv and radv > Vulkan drivers. The drivers now attempt to open the master DRM node > when the KHR_display extension is requested so that the common winsys > code can perform the

Re: [Mesa-dev] [PATCH] Haiku: convert to autotools

2018-02-12 Thread Emil Velikov
On 5 February 2018 at 22:14, kallisti5 wrote: > On 2018-02-05 15:39, Dylan Baker wrote: >> >> Quoting kallisti5 (2018-02-05 12:58:30) >>> >>> On 2017-10-24 11:47, Emil Velikov wrote: >>> > Hi Jerome, >>> > >>> > On 23 October 2017 at 16:58, Jerome Duval

Re: [Mesa-dev] [PATCH v2 4/8] radeon/uvd:add uvd hevc enc hw ib implementation

2018-02-12 Thread James Zhu
Hi Mark, thanks for point them out. [PATCH v4 3/8] / [PATCH v4 4/8] / [PATCH v4 5/8] update accordingly. James. On 2018-02-08 05:13 PM, Mark Thompson wrote: On 06/02/18 20:05, James Zhu wrote: Implement required IBs for UVD HEVC encode. Signed-off-by: James Zhu ---

[Mesa-dev] [PATCH v4 4/8] radeon/uvd:add uvd hevc enc hw ib implementation

2018-02-12 Thread James Zhu
Implement required IBs for UVD HEVC encode. Signed-off-by: James Zhu --- src/gallium/drivers/radeon/radeon_uvd_enc_1_1.c | 1131 +++ 1 file changed, 1131 insertions(+) create mode 100644 src/gallium/drivers/radeon/radeon_uvd_enc_1_1.c diff --git

[Mesa-dev] [PATCH v4 5/8] radeon/uvd:add uvd hevc enc functions

2018-02-12 Thread James Zhu
Implement UVD hevc encode functions Signed-off-by: James Zhu --- src/gallium/drivers/radeon/radeon_uvd_enc.c | 381 1 file changed, 381 insertions(+) create mode 100644 src/gallium/drivers/radeon/radeon_uvd_enc.c diff --git

[Mesa-dev] [PATCH v4 3/8] radeon/uvd:add uvd hevc enc hw interface header

2018-02-12 Thread James Zhu
Add hevc encode hardware interface for UVD Signed-off-by: James Zhu --- src/gallium/drivers/radeon/radeon_uvd_enc.h | 469 1 file changed, 469 insertions(+) create mode 100644 src/gallium/drivers/radeon/radeon_uvd_enc.h diff --git

[Mesa-dev] [PATCH] ac/shader: scan force_persample

2018-02-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 5 ++--- src/amd/common/ac_shader_info.c | 15 +++ 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

Re: [Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

2018-02-12 Thread Daniel Stone
Hi, On 10 February 2018 at 06:50, Jason Ekstrand wrote: > -} else if (parent->planar_format == NULL) { > + > +const struct intel_image_format *f = parent->planar_format; > +const int nplanes = f ? f->nplanes : 1; > + > +if (plane > nplanes) { > + if

[Mesa-dev] [PATCH] etnaviv: add useful information to BO import errors

2018-02-12 Thread Lucas Stach
From: Philipp Zabel Signed-off-by: Philipp Zabel --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c

Re: [Mesa-dev] [PATCH] nvc0: disable MS Images for sample_count == 1 on Maxwell

2018-02-12 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin I think things brings up the MSAAx1 question again. Apparently you're allowed to use a MSAAx1 image with image2DMS? Anyways, we can just avoid it all for now by not supporting it. On Mon, Feb 12, 2018 at 8:46 AM, Karol Herbst

[Mesa-dev] [PATCH] nvc0: disable MS Images for sample_count == 1 on Maxwell

2018-02-12 Thread Karol Herbst
fixes KHR-GL45.multi_bind.dispatch_bind_textures on Maxwell Suggested-by: Ilia Mirkin Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v4 2/5] android: Add version variable to gralloc_handle_t

2018-02-12 Thread Robert Foss
The version variable will be used for versioning of this struct and the corresponding accessor functions. Signed-off-by: Robert Foss Reviewed-by: Rob Herring --- android/gralloc_handle.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH v4 1/5] android: Move gralloc handle struct to libdrm

2018-02-12 Thread Robert Foss
This struct is used in mesa and drm_hwcomposer. Versions of if have been implemented in several grallocs: drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. Other than the 1:1 move of the struct a new generic name has been chosen and variables have had comments added to them. Signed-off-by:

  1   2   >