Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-21 3:03 GMT+08:00 Rob Herring : > > Perhaps worth revisiting. Given we've failed to progress at all since > then may change opinions some. We already have to handle multiple > opens share the same pipe_screen, so I don't think reusing the fd buys > us anything. > > Maybe we're close to the

[Mesa-dev] [PATCH 1/2] spirv: apply memory qualifiers to images

Signed-off-by: Samuel Pitoiset --- src/compiler/spirv/vtn_variables.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index ead68b4784..9eb85c24e9 100644 --- a/src/compiler/spirv/vtn_variable

[Mesa-dev] [PATCH 2/2] ac/nir: set GLC=1 for load/store of coherent/volatile images

This disables persistence accross wavefronts. F1 2017 and Wolfenstein 2 appear to use some coherent images but this patch doesn't seem to change anything. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

Hi Dieter, 2018-02-22 0:57 GMT+00:00 Dieter Nützel : > Making all in vulkan > make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten > make[3]: *** Keine Regel vorhanden, um das Ziel > „/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml“, > benötigt von „wsi/linux-dmabuf-unstable-v1-protocol

Re: [Mesa-dev] [PATCH v3 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

do we already have an upstream version of both dependencies we could just use? Or do we still need special branches? On Wed, Feb 21, 2018 at 11:50 PM, Pierre Moreau wrote: > Signed-off-by: Pierre Moreau > --- > > Notes: > v3: > * Bump the required version of SPIRV-Tools to the latest rel

Re: [Mesa-dev] [PATCH v3 21/21] clover: Use OpenCL 2.1 defines in place of cl_khr_il_program

I think this can be merged into patches 17 and 18, no? On Wed, Feb 21, 2018 at 11:50 PM, Pierre Moreau wrote: > Signed-off-by: Pierre Moreau > --- > src/gallium/state_trackers/clover/api/device.cpp | 3 +-- > src/gallium/state_trackers/clover/api/program.cpp | 2 +- > 2 files changed, 2 insert

Re: [Mesa-dev] [PATCH v3 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

> do we already have an upstream version of both dependencies we could > just use? Or do we still need special branches? For both we can use the master branch of the upstream version. SPIRV-Tools validator is still not perfect, but it does already catch issues in OpenCL SPIR-V binaries. And llvm-s

Re: [Mesa-dev] [PATCH v3 21/21] clover: Use OpenCL 2.1 defines in place of cl_khr_il_program

> I think this can be merged into patches 17 and 18, no? You are right, will do. > On Wed, Feb 21, 2018 at 11:50 PM, Pierre Moreau wrote: > > Signed-off-by: Pierre Moreau > > --- > > src/gallium/state_trackers/clover/api/device.cpp | 3 +-- > > src/gallium/state_trackers/clover/api/program.cp

Re: [Mesa-dev] [PATCH v3 09/21] clover: Track flags per module section

On 2018-02-21 — 20:04, Aaron Watry wrote: > On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau wrote: > > One flag that needs to be tracked is whether a library is allowed to > > received mathematics optimisations or not, as the authorisation is given > > when creating the library while the optimisati

Re: [Mesa-dev] [PATCH 2/2] ac/nir: set GLC=1 for load/store of coherent/volatile images

Ideally we find a way to also do it for buffers, but for this series Reviewed-by: Bas Nieuwenhuizen On Thu, Feb 22, 2018 at 10:25 AM, Samuel Pitoiset wrote: > This disables persistence accross wavefronts. > > F1 2017 and Wolfenstein 2 appear to use some coherent images > but this patch doesn't

Re: [Mesa-dev] [PATCH 2/2] ac/nir: set GLC=1 for load/store of coherent/volatile images

On 02/22/2018 11:45 AM, Bas Nieuwenhuizen wrote: Ideally we find a way to also do it for buffers, but for this series I didn't mention it in the commit message, but yes we should. Reviewed-by: Bas Nieuwenhuizen > On Thu, Feb 22, 2018 at 10:25 AM, Samuel P

[Mesa-dev] [Bug 105207] The Talos Principle freezes system using radv

https://bugs.freedesktop.org/show_bug.cgi?id=105207 Bug ID: 105207 Summary: The Talos Principle freezes system using radv Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: no

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On 22 February 2018 at 05:57, Tomasz Figa wrote: > On Thu, Feb 22, 2018 at 7:23 AM, Rob Herring wrote: >> >> On Wed, Feb 21, 2018 at 1:22 PM, Emil Velikov >> wrote: >> > On 21 February 2018 at 18:50, Rob Herring wrote: >> >> On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov >> >> wrote: >> >>>

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

https://bugs.freedesktop.org/show_bug.cgi?id=105171 Clemens Eisserer changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 4/5] nouveau: Add framebuffer modifier support

On Wed, Feb 21, 2018 at 11:05:45AM -0500, Ilia Mirkin wrote: > On Wed, Feb 21, 2018 at 10:30 AM, Thierry Reding > wrote: > > From: Thierry Reding > > > > This adds support for framebuffer modifiers to Nouveau. This will be > > used by the Tegra driver to share metadata about the format of buffers

Re: [Mesa-dev] [PATCH 4/5] nouveau: Add framebuffer modifier support

On Wed, Feb 21, 2018 at 04:37:45PM +, Emil Velikov wrote: > Hi Thierry, > > On 21 February 2018 at 15:30, Thierry Reding wrote: > > > > > struct pipe_resource * > > nouveau_buffer_create(struct pipe_screen *pscreen, > > - const struct pipe_resource *templ); > > +

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.4 release candidate

On 21 February 2018 at 19:14, Kenneth Graunke wrote: > On Thursday, February 8, 2018 8:47:00 PM PST Emil Velikov wrote: >> Rejected (9) >> >> Jason Ekstrand (2): >> e52a9f18d69c94b7cb7f81361cdb9e2582c3d742 i965: Replace >> draw_aux_buffer_disabled with draw_aux_usage >> 20

[Mesa-dev] [Bug 105208] [regression] (e5ff036c67 st/dri: Add support for BGR[A/X]1010102 formats) broke the mouse in mutter/shell

https://bugs.freedesktop.org/show_bug.cgi?id=105208 Bug ID: 105208 Summary: [regression] (e5ff036c67 st/dri: Add support for BGR[A/X]1010102 formats) broke the mouse in mutter/shell Product: Mesa Version: unspecif

[Mesa-dev] [Bug 105208] [regression] (e5ff036c67 st/dri: Add support for BGR[A/X]1010102 formats) broke the mouse in mutter/shell

https://bugs.freedesktop.org/show_bug.cgi?id=105208 Daniel Stone changed: What|Removed |Added CC||mar...@gmail.com, |

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

https://bugs.freedesktop.org/show_bug.cgi?id=105161 --- Comment #8 from Allan Sandfeld Jensen --- That would fix the parsing in compatibility shaders. It doesn't make it work. I found after digging into mesa code that I needed: #extension GL_ARB_fragment_coord_conventions : enable Otherwise th

Re: [Mesa-dev] [PATCH] nvc0: fix writing query results into buffer

Tested-by: Karol Herbst On Wed, Feb 21, 2018 at 6:17 AM, Ilia Mirkin wrote: > We need to mark the range as valid, and validate the resource using a > helper to ensure that the buffer status is marked properly. > > Fixes some CTS pipeline stats query tests. > > Signed-off-by: Ilia Mirkin > --- >

Re: [Mesa-dev] [PATCH] nv50,nvc0: fix clear buffer acceleration

Tested-by: Karol Herbst On Wed, Feb 21, 2018 at 5:20 AM, Ilia Mirkin wrote: > Two things were off: > - valid range was not updated, which could affect waiting for future >maps > - fencing was done manually instead of using the *_resource_validate >helper, which resulted in a missed dir

Re: [Mesa-dev] [PATCH] nv50, nvc0: fix integer MS resolves using 2d engine

Tested-by: Karol Herbst On Thu, Feb 22, 2018 at 5:34 AM, Ilia Mirkin wrote: > We don't want filtering for integer textures, same as depth/stencil. > > Fixes: KHR-GL45.direct_state_access.renderbuffers_storage_multisample > Signed-off-by: Ilia Mirkin > --- > src/gallium/drivers/nouveau/nv50/nv5

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

https://bugs.freedesktop.org/show_bug.cgi?id=105161 --- Comment #9 from Allan Sandfeld Jensen --- The problem is the check in linker.cpp (link_fs_inout_layout_qualifiers): if (linked_shader->Stage != MESA_SHADER_FRAGMENT || (prog->data->Version < 150 && !prog->ARB_fragment_coor

Re: [Mesa-dev] [PATCH 5/5] tegra: Initial support

On Wed, Feb 21, 2018 at 05:01:02PM +, Emil Velikov wrote: > Hi Thierry, > > On 21 February 2018 at 15:30, Thierry Reding wrote: > > > @@ -2595,6 +2596,11 @@ if test -n "$with_gallium_drivers"; then > > ximx) > > HAVE_GALLIUM_IMX=yes > > ;; > > +xtegr

Re: [Mesa-dev] [PATCH 5/5] tegra: Initial support

On Thu, Feb 22, 2018 at 2:23 PM, Thierry Reding wrote: > On Wed, Feb 21, 2018 at 05:01:02PM +, Emil Velikov wrote: >> Hi Thierry, >> >> On 21 February 2018 at 15:30, Thierry Reding >> wrote: >> > +static const char * >> > +tegra_screen_get_name(struct pipe_screen *pscreen) >> > +{ >> > + r

[Mesa-dev] [PATCH] intel: aubinator_error_decode: fix segfault on missing register

Some register might be missing in our genxmls. Don't try to decode them. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_error_decode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_err

[Mesa-dev] [Bug 105208] [regression] (e5ff036c67 st/dri: Add support for BGR[A/X]1010102 formats) broke the mouse in mutter/shell

https://bugs.freedesktop.org/show_bug.cgi?id=105208 Emil Velikov changed: What|Removed |Added CC||airl...@freedesktop.org,

Re: [Mesa-dev] [PATCH 5/5] tegra: Initial support

On 22 February 2018 at 13:23, Thierry Reding wrote: > On Wed, Feb 21, 2018 at 05:01:02PM +, Emil Velikov wrote: >> Hi Thierry, >> >> On 21 February 2018 at 15:30, Thierry Reding >> wrote: >> >> > @@ -2595,6 +2596,11 @@ if test -n "$with_gallium_drivers"; then >> > ximx) >> >

[Mesa-dev] [PATCH v2] glx: Properly handle cases where screen creation fails

This fixes a segfault exposed by a29d63ecf7 which occurs when swr is used on an unsupported architecture. v2: re-work to place logic in xmesa_init_display Signed-off-by: Chuck Atkins Cc: mesa-sta...@lists.freedesktop.org Cc: George Kyriazis Cc: Bruce Cherniak --- src/gallium/state_trackers/gl

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

https://bugs.freedesktop.org/show_bug.cgi?id=105171 Emil Velikov changed: What|Removed |Added Keywords||bisected, regression CC|

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glx: Properly handle cases where screen creation fails

On 22 February 2018 at 14:33, Chuck Atkins wrote: > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > used on an unsupported architecture. > > v2: re-work to place logic in xmesa_init_display > > Signed-off-by: Chuck Atkins > Cc: mesa-sta...@lists.freedesktop.org > Cc: George

[Mesa-dev] [PATCH] swr/rast: Fix index buffer overfetch issue for non-indexed draws

Populate pLastIndex, even for the non-indexed case. A zero pLastIndex can cause the index offsets inside the fetcher to have non-sensical values that can be either very large positive or very large negative numbers. cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/swr/rasterizer/cor

Re: [Mesa-dev] [PATCH 5/5] tegra: Initial support

On Thu, Feb 22, 2018 at 02:31:48PM +0100, Erik Faye-Lund wrote: > On Thu, Feb 22, 2018 at 2:23 PM, Thierry Reding > wrote: > > On Wed, Feb 21, 2018 at 05:01:02PM +, Emil Velikov wrote: > >> Hi Thierry, > >> > >> On 21 February 2018 at 15:30, Thierry Reding > >> wrote: > >> > +static const ch

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glx: Properly handle cases where screen creation fails

> > On 22 February 2018 at 14:33, Chuck Atkins > wrote: > > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > > used on an unsupported architecture. > > > > v2: re-work to place logic in xmesa_init_display > > > > Signed-off-by: Chuck Atkins > > Cc: mesa-sta...@lists.freedesk

Re: [Mesa-dev] [PATCH 03/17] intel: Disable 64-bit extensions on platforms without 64-bit types

On Wed, 2018-02-21 at 09:33 -0800, Matt Turner wrote: > On Wed, Feb 21, 2018 at 2:05 AM, Iago Toral > wrote: > > On Tue, 2018-02-20 at 21:15 -0800, Matt Turner wrote: > > > Gen11 does not support DF, Q, UQ types in hardware. As a result, > > > we > > > have > > > to disable some GL extensions unti

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glx: Properly handle cases where screen creation fails

On 22 February 2018 at 15:18, Chuck Atkins wrote: >> On 22 February 2018 at 14:33, Chuck Atkins >> wrote: >> > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is >> > used on an unsupported architecture. >> > >> > v2: re-work to place logic in xmesa_init_display >> > >> > Signed

Re: [Mesa-dev] [PATCH 00/13] RadeonSI: Reduce user SGPR usage

I don't think that adding "uint32_t userdata_XX[16];" would simplify anything. The bottom line is, patches 9-13 are prerequisites for VBO descriptors in user SGPRs, so they block that optimization as long as they sit on the mailing list. Marek On Tue, Feb 20, 2018 at 8:51 PM, Marek Olšák wrote:

[Mesa-dev] [PATCH] appveyor: Build with MSVC 2015.

The MSVC version we (at VMware) primarily care about from now on is 2015. We can drop support for building with 2013 in a future commit. I'm not aware of significant changes in C99/C11 support from MSVC 2013 to 2015, but there's no point in continuing supporting old MSVC versions when nobody care

[Mesa-dev] [PATCH 3/5] swr/rast: Consolidate TRANSLATE_ADDRESS

Translate is now part of an overloaded LOAD call which required a change to the code gen to skip the load functions in order to handle them manually to make them virtual. --- .../swr/rasterizer/codegen/gen_llvm_ir_macros.py | 3 ++- .../drivers/swr/rasterizer/jitter/builder_mem.cpp| 20 ++

[Mesa-dev] [PATCH 4/5] swr/rast: Faster frustum prim culling

Fix clipper validMask setting. We don't need to run frustum rejected primitives through the clipper. Perform frustum culling with only frustum clip codes. Guardband clip codes cannot be used because they overlap frustum codes. --- src/gallium/drivers/swr/rasterizer/core/clip.h | 10 +++--- 1

[Mesa-dev] [PATCH 1/5] swr/rast: Remove draw type from event definitions

- Have the draw type sent to DrawInfoEvent in handlers created in archrast.cpp. The draw type no longer needs to be sent during during AR_API_EVENT() call in api.cpp. - Remove draw type from event defintions in events_private.proto, no longer needed --- src/gallium/drivers/swr/rasterizer/a

[Mesa-dev] [PATCH 5/5] swr/rast: revert clip distance precision

Breaks a whole bunch of piglit tests --- src/gallium/drivers/swr/rasterizer/core/backend_impl.h | 4 +--- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 17 - 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/backend_

[Mesa-dev] [PATCH 2/5] swr/rast: Code generation cleanup

Generate more compact code from gen_llvm.hpp. --- .../swr/rasterizer/codegen/templates/gen_llvm.hpp | 36 +- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_llvm.hpp b/src/gallium/drivers/swr/rasterizer/

[Mesa-dev] [PATCH] egl/dri2: fix segfault when display initialisation fails

dri2_display_destroy() is called when platform specific display initialisation fails. However, this would typically lead to a segfault due to the dri2_egl_display vbtl not having been set up. Fixes: 2db95482964 ("loader_dri3/glx/egl: Optionally use a blit context for blitting operations") Signed-o

Re: [Mesa-dev] [PATCH] appveyor: Build with MSVC 2015.

On 02/22/2018 09:29 AM, Jose Fonseca wrote: The MSVC version we (at VMware) primarily care about from now on is 2015. We can drop support for building with 2013 in a future commit. I'm not aware of significant changes in C99/C11 support from MSVC 2013 to 2015, but there's no point in continuing

[Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

When transitioning to an htile compressed depth format, Set the full depth range, so later rasterization can pass HiZ. Previously, for depth only formats, the depth range was set to 0 to 0. This caused unwanted HiZ rejections with a VK_FORMAT_D16_UNORM depth buffer (VK_FORMAT_D32_SFLOAT was not aff

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO

https://bugs.freedesktop.org/show_bug.cgi?id=104553 Alejandro Piñeiro (freenode IRC: apinheiro) changed: What|Removed |Added CC||apinhe...@

Re: [Mesa-dev] [PATCH] intel: aubinator_error_decode: fix segfault on missing register

On Thursday, February 22, 2018 5:41:10 AM PST Lionel Landwerlin wrote: > Some register might be missing in our genxmls. Don't try to decode > them. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/aubinator_error_decode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

[Mesa-dev] [PATCH 2/4] i965: perf: query topology

With the introduction of asymmetric slices in CNL, we cannot rely on the previous SUBSLICE_MASK getparam to tell userspace what subslices are available. We introduce a new uAPI in the kernel driver to report exactly what part of the GPU are fused and require this to be available on Gen10+. Prior

[Mesa-dev] [PATCH 1/4] drm-uapi: bump headers

This commit is meant to be replaced with a proper bump from drm-next. --- include/drm-uapi/i915_drm.h | 146 +++- 1 file changed, 145 insertions(+), 1 deletion(-) diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h index 7f28eea4035..9dfe

[Mesa-dev] [PATCH 3/4] i965: perf: add support for new equation operators

Some equations of the CNL metrics started to use operators we haven't defined yet, just add those. Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_oa.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_oa.py b/src/mesa/drivers

[Mesa-dev] [PATCH 0/4] i965: add support for performance queries on CNL

Hi all, This series adds support for perf queries on CNL. It depends on a new kernel uAPI so I don't expect this to land just yet. The uAPI has received enough review this can be look after from the Mesa side. It's a bit verbose unfortunately because we have to support multiple ways to getting so

Re: [Mesa-dev] [PATCH] egl/dri2: fix segfault when display initialisation fails

On Thursday, 2018-02-22 13:37:54 +, Frank Binns wrote: > dri2_display_destroy() is called when platform specific display > initialisation fails. However, this would typically lead to a > segfault due to the dri2_egl_display vbtl not having been set up. > > Fixes: 2db95482964 ("loader_dri3/glx/

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glx: Properly handle cases where screen creation fails

> > > If there's a better way forward for having a minimal-dependency > > software-only implementation, I'd certainly be willing to try it. At the > > moment though, gallium-xlib-glx is our path for that. > > > I was merely mentioning that the xlib-glx are in worse shape than the dri > one. > > Th

[Mesa-dev] [Bug 105211] build failure after zwp_dmabuf commit if wayland-protocols is not installed

https://bugs.freedesktop.org/show_bug.cgi?id=105211 Bug ID: 105211 Summary: build failure after zwp_dmabuf commit if wayland-protocols is not installed Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] egl/dri2: fix segfault when display initialisation fails

On 22 February 2018 at 17:25, Eric Engestrom wrote: > On Thursday, 2018-02-22 13:37:54 +, Frank Binns wrote: >> dri2_display_destroy() is called when platform specific display >> initialisation fails. However, this would typically lead to a >> segfault due to the dri2_egl_display vbtl not havi

Re: [Mesa-dev] [PATCH 0/4] i965: add support for performance queries on CNL

Hi Lionel, On 22 February 2018 at 17:24, Lionel Landwerlin wrote: > One of the patch is quite big so, unlikely to make it to the ml. You > can look at this series on my github : > > i965: add performance query support on CNL > Indeed patch 4/4 seems stuck. Commit will work fine for meson, aut

[Mesa-dev] [Bug 105211] build failure after zwp_dmabuf commit if wayland-protocols is not installed

https://bugs.freedesktop.org/show_bug.cgi?id=105211 --- Comment #1 from Daniel Stone --- Yes, sorry about this, the autotools build is quite funny with wayland-protocols. At the moment, you can solve this by simply removing the linux-dmabuf lines from src/vulkan/Makefile.sources, or you can inst

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glx: Properly handle cases where screen creation fails

On 22 February 2018 at 17:36, Chuck Atkins wrote: >> > If there's a better way forward for having a minimal-dependency >> > software-only implementation, I'd certainly be willing to try it. At >> > the >> > moment though, gallium-xlib-glx is our path for that. >> > >> I was merely mentioning that

Re: [Mesa-dev] [PATCH] appveyor: Build with MSVC 2015.

Looks great. Reviewed-by: Roland Scheidegger Am 22.02.2018 um 17:29 schrieb Jose Fonseca: > The MSVC version we (at VMware) primarily care about from now on is > 2015. > > We can drop support for building with 2013 in a future commit. I'm not > aware of significant changes in C99/C11 support fr

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

On Wed, Feb 21, 2018 at 4:00 PM Alex Deucher wrote: > On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace wrote: > > On Thu 21 Dec 2017, Daniel Vetter wrote: > >> On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen < hoegsb...@google.com> wrote: > >>> On Wed, Dec 20, 2017 at 12:41 PM, Miguel Angel V

[Mesa-dev] [PATCH] fixup! nouveau: Add framebuffer modifier support

From: Thierry Reding --- src/gallium/drivers/nouveau/nouveau_buffer.c | 3 +- src/gallium/drivers/nouveau/nouveau_buffer.h | 3 +- src/gallium/drivers/nouveau/nouveau_screen.c | 10 --- src/gallium/drivers/nouveau/nv30/nv30_resource.c | 4 +- src/gallium/drivers/nouveau/nv50/nv50_

[Mesa-dev] [PATCH] fixup! tegra: Initial support

From: Thierry Reding --- configure.ac| 5 +++-- src/gallium/drivers/tegra/Makefile.am | 9 +--- src/gallium/drivers/tegra/Makefile.sources | 5 - src/gallium/drivers/tegra/tegra_context.c | 8 +++ src/gallium/drivers/tegra/

[Mesa-dev] [Bug 105211] build failure after zwp_dmabuf commit if wayland-protocols is not installed

https://bugs.freedesktop.org/show_bug.cgi?id=105211 --- Comment #2 from Alan Swanson --- No worries. But just to note that wayland-protocols does have a dependency on wayland-scanner from the main wayland build - or at least an autotools configure failure if not present (though scan.sh test scrip

[Mesa-dev] [Bug 105211] build failure after zwp_dmabuf commit if wayland-protocols is not installed

https://bugs.freedesktop.org/show_bug.cgi?id=105211 --- Comment #3 from Emil Velikov --- Daniel, let's opt for your earlier suggestion and stop shipping those generated sources. It's causing more problems than what it's worth. There was some fun when building/using the correct wayland-scanner in

[Mesa-dev] [PATCH v2 1/6] drm/fourcc: Fix fourcc_mod_code() definition

From: Thierry Reding Avoid a compiler warnings when the val parameter is an expression. This is based on commit 5843f4e02fbe86a59981e35adc6cabebee46fdc0 from Linux v4.16-rc1. Acked-by: Emil Velikov Tested-by: Andre Heider Signed-off-by: Thierry Reding --- include/drm-uapi/drm_fourcc.h | 2 +

[Mesa-dev] [PATCH v2 2/6] drm/tegra: Sanitize format modifiers

From: Thierry Reding The existing format modifier definitions were merged prematurely, and recent work has unveiled that the definitions are suboptimal in several ways: - The format specifiers, except for one, are not Tegra specific, but the names don't reflect that. - The number space i

[Mesa-dev] [PATCH v2 3/6] nouveau/nvc0: Extract common tile mode macro

From: Thierry Reding Add a new macro that can be used to extract the tiling mode from a tile_mode value. This is will be used to determine the number of GOBs used in block linear mode. Acked-by: Emil Velikov Tested-by: Andre Heider Signed-off-by: Thierry Reding --- src/gallium/drivers/nouvea

[Mesa-dev] [PATCH v2 0/6] NVIDIA Tegra support

From: Thierry Reding This series of patches implements initial support for Tegra. The first two patches import DRM UAPI from v4.16-rc1 that provide framebuffer modifiers that can be used to specify buffers shared between Nouveau and the Tegra DRM driver. Patches 3 and 4 add support for framebuff

[Mesa-dev] [PATCH v2 4/6] nouveau: Add framebuffer modifier support

From: Thierry Reding This adds support for framebuffer modifiers to Nouveau. This will be used by the Tegra driver to share metadata about the format of buffers (such as the tiling mode or compression). Changes in v2: - remove unused parameters to nouveau_buffer_create() - move format modifier q

[Mesa-dev] [PATCH v2 6/6] autotools: Add tegra to AM_DISTCHECK_CONFIGURE_FLAGS

From: Thierry Reding This allows the driver to be built on a make distcheck and makes sure that it properly builds when a distribution tarball is made. Suggested-by: Emil Velikov Signed-off-by: Thierry Reding --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Mesa-dev] [PATCH v2 5/6] tegra: Initial support

Tegra K1 and later use a GPU that can be driven by the Nouveau driver. But the GPU is a pure render node and has no display engine, hence the scanout needs to happen on the Tegra display hardware. The GPU and the display engine each have a separate DRM device node exposed by the kernel. To make th

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

On Thu, Feb 22, 2018 at 7:04 PM, Kristian Høgsberg wrote: > On Wed, Feb 21, 2018 at 4:00 PM Alex Deucher wrote: > >> On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace > wrote: >> > On Thu 21 Dec 2017, Daniel Vetter wrote: >> >> On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen < > hoegsb...@goog

Re: [Mesa-dev] [PATCH v3 06/21] clover/api: Rework the validation of devices for building

Pierre Moreau writes: > Signed-off-by: Pierre Moreau > --- > src/gallium/state_trackers/clover/api/program.cpp | 39 > +- > src/gallium/state_trackers/clover/core/program.cpp | 3 +- > 2 files changed, 25 insertions(+), 17 deletions(-) > > diff --git a/src/gallium/state_t

Re: [Mesa-dev] [PATCH v3 14/21] clover/llvm: Allow translating from SPIR-V to LLVM IR

Pierre Moreau writes: > Signed-off-by: Pierre Moreau > --- > .../state_trackers/clover/llvm/invocation.cpp | 26 > ++ > .../state_trackers/clover/llvm/invocation.hpp | 4 > src/gallium/state_trackers/clover/meson.build | 2 +- > 3 files changed, 31 ins

Re: [Mesa-dev] [PATCH v3 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

Pierre Moreau writes: >> do we already have an upstream version of both dependencies we could >> just use? Or do we still need special branches? > > For both we can use the master branch of the upstream version. SPIRV-Tools > validator is still not perfect, but it does already catch issues in Ope

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

Kristian Høgsberg writes: > On Wed, Feb 21, 2018 at 4:00 PM Alex Deucher wrote: > >> On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace > wrote: >> > On Thu 21 Dec 2017, Daniel Vetter wrote: >> >> On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen < > hoegsb...@google.com> wrote: >> >>> On Wed, D

[Mesa-dev] [PATCH v3] anv: enable VK_EXT_shader_stencil_export

v2: An attempt to support SpvExecutionModeStencilRefReplacingEXT's behavior also follows, with the interpretation to said mode being we prevent writes to the built-in FragStencilRefEXT variable when the execution mode isn't set. v3: A more cautious reading of 1db44252d01bf7539452ccc2b5210c74b8dcd5

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] intel/compiler: Memory fence commit must always be enabled for gen10+

Hi Anuj, On 7 February 2018 at 01:09, Anuj Phogat wrote: > Commit bit in the message descriptor (Bit 13) must be always set > to true in CNL+ for memory fence messages. It also fixes a piglit > GPU hang on cnl+ in simulation environment. > Piglit test: arb_shader_image_load_store-shader-mem-barri

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: perf: ensure reading config IDs from sysfs isn't interrupted

Hi Lionel, On 9 February 2018 at 10:03, Lionel Landwerlin wrote: > Fixes: 458468c136e "i965: Expose OA counters via INTEL_performance_query" > Signed-off-by: Lionel Landwerlin > Cc: "18.0" > --- > src/mesa/drivers/dri/i965/brw_performance_query.c | 3 ++- > 1 file changed, 2 insertions(+), 1 d

[Mesa-dev] [AppVeyor] mesa master #6991 failed

Build mesa 6991 failed Commit 7aa008d1d7 by Samuel Pitoiset on 2/2/2018 6:04 PM: radv: enable lowering of fpow to fexp2 and flog2\n\nThere is no fpow in hardware, so it's always lowered somewhere,\nbut it appears that lowering at NIR level is better. Figured wh

[Mesa-dev] [AppVeyor] mesa master #6992 completed

Build mesa 6992 completed Commit d6b7539206 by Samuel Pitoiset on 2/5/2018 2:51 PM: ac/nir: remove emission of nir_op_fpow\n\nfpow is now lowered at NIR level.\n\nSigned-off-by: Samuel Pitoiset \nReviewed-by: Bas Nieuwenhuizen Configure your notifica

[Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

The QT framework has a bug in their shader program cache, which is built on GL_ARB_get_program_binary. In an effort to allow them to fix the bug we don't enable more than 1 binary format for compatibility profiles. This is only being done on the 18.0 release branch. Ref: https://bugreports.qt.io

Re: [Mesa-dev] [PATCH v4] anv/blorp: multisample resolve all attachment layers

On Thu, Feb 22, 2018 at 08:23:30AM +0100, Iago Toral wrote: > On Wed, 2018-02-21 at 09:58 -0800, Nanley Chery wrote: > > On Wed, Feb 21, 2018 at 09:18:49AM +0100, Iago Toral Quiroga wrote: > > > We were only resolving the first. > > > > > > v2: > > > - Do not require that the number of layers on

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

https://bugs.freedesktop.org/show_bug.cgi?id=104654 --- Comment #7 from russianneuroman...@ya.ru --- > but apparently they are just compiled but not run, because the scene shows > visible artifacts that are not there when the compute shaders are enabled Does it looks like on screenshot in bug 10

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

On Thu, Feb 22, 2018 at 1:49 PM, Bas Nieuwenhuizen wrote: > On Thu, Feb 22, 2018 at 7:04 PM, Kristian Høgsberg > wrote: >> On Wed, Feb 21, 2018 at 4:00 PM Alex Deucher wrote: >> >>> On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace >> wrote: >>> > On Thu 21 Dec 2017, Daniel Vetter wrote: >>> >> On

[Mesa-dev] [Bug 105207] The Talos Principle freezes system using radv

https://bugs.freedesktop.org/show_bug.cgi?id=105207 --- Comment #1 from Bas Nieuwenhuizen --- Curious, I haven't noticed that and that sounds really similar to my benchmarking setup. Not being able to reboot is a generic amdgpu problem after a hang. It happening for so long as you can remember,

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

Jordan Justen writes: > The QT framework has a bug in their shader program cache, which is > built on GL_ARB_get_program_binary. > > In an effort to allow them to fix the bug we don't enable more than 1 > binary format for compatibility profiles. > > This is only being done on the 18.0 release br

Re: [Mesa-dev] [PATCH 1/2] glxinfo/wglinfo: fix indentation for listing compression formats

Reviewed-by: Andreas Boll 2018-02-21 21:09 GMT+01:00 Brian Paul : > And prefix with "GL_ARB_texture_compression:" like other sections. > --- > src/xdemos/glinfo_common.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_comm

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

Reviewed-by: Andreas Boll 2018-02-21 21:09 GMT+01:00 Brian Paul : > v2: fix indentation, prefix with "4.3:" like other sections. > --- > src/xdemos/glinfo_common.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c > i

Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

yeah, looks like I may have lifted the values from a driver which set the ZRANGE_PRECISION to 0, but this at least mirrors PAL and fixes one of the remaining transition issues there that I was aware of. Reviewed-by: Bas Nieuwenhuizen since IIRC the last change was also done due to Feral noticing

Re: [Mesa-dev] [PATCH 08/13] mesa: Make _mesa_vertex_attrib_binding public.

On 02/21/2018 10:45 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Change vertex_attrib_binding() to _mesa_vertex_attrib_binding(), add a flush_vertices argument, and make it publically available. "publicly" -Brian The function will be needed later in the series. Signed-off-b

Re: [Mesa-dev] [PATCH 04/13] mesa: Introduce a yet unused _DrawVAO.

Just a few little nit-picks. With those fixed, the series is: Reviewed-by: Brian Paul Nice work! On 02/21/2018 10:45 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich During the patch series this VAO gets populated with either the currently bound VAO or an internal VAO that will

Re: [Mesa-dev] [PATCH 12/13] mesa: Use atomics for shared VAO reference counts.

On 02/21/2018 10:45 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich VAOs will be used in the next change as immutable object across multiple contexts. Only reference counting may write concurrently on the VAO. So, make the reference count thread safe for those and only those VAO obj

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

https://bugs.freedesktop.org/show_bug.cgi?id=104654 --- Comment #8 from Darius Spitznagel --- Maybe this helps. Every "older" feral port has it's own "shader warmer". Disable it in the prefereces file in ~/.local/share/feral-interactive/AlienIsolation like below... 0 -- You are receiving thi

[Mesa-dev] [Bug 105207] The Talos Principle freezes system using radv

https://bugs.freedesktop.org/show_bug.cgi?id=105207 --- Comment #2 from pritzl3...@gmail.com --- I'm not sure for how long this has been happening. Definitely for as long as I had my Vega, so at least since the middle of october. I almost always run the latest rc kernels and used to use Mesa from

[Mesa-dev] [Bug 105207] The Talos Principle freezes system using radv

https://bugs.freedesktop.org/show_bug.cgi?id=105207 --- Comment #3 from pritzl3...@gmail.com --- Created attachment 137546 --> https://bugs.freedesktop.org/attachment.cgi?id=137546&action=edit tracefile -- You are receiving this mail because: You are the QA Contact for the bug. You are the ass

[Mesa-dev] [PATCH] anv/allocator: Unconditionally call futex_wake

There is a potential race between the __sync_fetch_and_add and the futex_wake where another thread could come in and start waiting. If we hit this case, the other thread will never get woken back up because the futex_wake doesn't get called. We can fix this by calling futex_wake unconditionally.

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

Hi Jordan, On 22 February 2018 at 19:59, Jordan Justen wrote: > The QT framework has a bug in their shader program cache, which is > built on GL_ARB_get_program_binary. > > In an effort to allow them to fix the bug we don't enable more than 1 > binary format for compatibility profiles. > Doing Nu

  1   2   >