[Mesa-dev] [AppVeyor] mesa master #7686 completed

Build mesa 7686 completed Commit 26ddc4f9e1 by Vinson Lee on 5/12/2018 7:27 AM: scons: Add PROGRAM_NIR_FILES.\n\nFix SCons build error.\n\n Linking build/linux-x86_64-debug/gallium/targets/libgl-xlib/libGL.so.1.5 ...\nbuild/linux-x86_64-debug/mesa/libmesa.a(st

[Mesa-dev] [PATCH] scons: Add PROGRAM_NIR_FILES.

Fix SCons build error. Linking build/linux-x86_64-debug/gallium/targets/libgl-xlib/libGL.so.1.5 ... build/linux-x86_64-debug/mesa/libmesa.a(st_program.os): In function `st_translate_prog_to_nir': src/mesa/state_tracker/st_program.c:392: undefined reference to `prog_to_nir' Fixes: 5c33e8c7729e

[Mesa-dev] [PATCH v2 03/21] mesa/main: add NULL name check when searching for a resource name

Since ARB_gl_spirv name reflection can be missing. piglit shader_runner does several resource checking, so this commit is useful to get even the more simple piglit tests running without crashing on SPIR-V mode. Reviewed-by: Timothy Arceri --- src/mesa/main/shader_query.cpp | 5 + 1 file chan

[Mesa-dev] [PATCH v2 01/21] mesa/main: Add a 'spirv' flag to gl_shader_program_data

From: Eduardo Lima Mitev This will be used by the linker code to differentiate between programs made out of SPIR-V or GLSL shaders. This was rejected in the past, assuming that it was equivalent to check for "shProg->_LinkedShaders[stage]->spirv_data != NULL". But: * At some points of the lin

[Mesa-dev] [PATCH v2 02/21] i965: use gl_shader_program_data::spirv

--- src/mesa/drivers/dri/i965/brw_program.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_program.c b/src/mesa/drivers/dri/i965/brw_program.c index fc77926d6e0..39c2d2a3581 100644 --- a/src/mesa/drivers/dri/i965/brw_program.c +++ b/src/mesa/driv

[Mesa-dev] [PATCH v2 04/21] nir: Add explicit_binding to nir_variable

From: Neil Roberts This is copied from the corresponding value in ir_variable. The intention is to eventually use it in a pure-NIR linker. Reviewed-by: Timothy Arceri --- src/compiler/glsl/glsl_to_nir.cpp | 1 + src/compiler/nir/nir.h| 5 + 2 files changed, 6 insertions(+) dif

[Mesa-dev] [PATCH v2 05/21] nir/lower_samplers: Limit assert to GLSL shader programs

From: Eduardo Lima Mitev Vulkan has the concept of separate image and sampler objects in the SPIR-V code whereas GL conflates them into one. nir_lower_samplers contains an assert to verify that sampler operand is not being set on the nir instruction. However when the code comes from spirv_to_nir

[Mesa-dev] [PATCH v2 06/21] nir/types: Add a glsl_get_component_slots() utility

From: Eduardo Lima Mitev It is basically a wrapper around glsl_type::component_slots(). Reviewed-by: Timothy Arceri --- src/compiler/nir_types.cpp | 6 ++ src/compiler/nir_types.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cp

[Mesa-dev] [PATCH v2 00/21] ARB_gl_spirv: support for uniforms and some extras

Hi, this is the second version for this series. The info for the original one can be read here: https://lists.freedesktop.org/archives/mesa-dev/2018-April/192512.html Some of the patches are already reviewed (thanks to Timothy Arceri). The main differences between v1 and v2 are: * The NIR link

[Mesa-dev] [PATCH v2 09/21] spirv: Get rid of vtn_variable_mode_image/sampler

From: Neil Roberts vtn_variable_mode_image and _sampler are instead replaced with vtn_variable_mode_uniform which encompasses both of them. In the few places where it was neccessary to distinguish between the two, the GLSL type of the pointer is used instead. The main reason to do this is that o

[Mesa-dev] [PATCH v2 08/21] spirv: translate default-block uniforms

From: Nicolai Hähnle They are supported by SPIR-V for ARB_gl_spirv. v2 (changes on top of Nicolai's original patch): * Handle UniformConstant storage class for uniforms other than samplers and images. (Eduardo Lima) * Handle location decoration also for samplers and images. (Eduardo

[Mesa-dev] [PATCH v2 07/21] nir/types: Add a utility wrapper to glsl_type::sampler_index()

From: Eduardo Lima Mitev I think it is more accurate to call it a sampler target (?). --- src/compiler/nir_types.cpp | 7 +++ src/compiler/nir_types.h | 1 + 2 files changed, 8 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 51ca797497e..d2b2a93b20

[Mesa-dev] [PATCH v2 10/21] anv/nir: Use nir_variable's type if interface_type is null

From: Eduardo Lima Mitev Previous patch 'spirv: Get rid of vtn_variable_mode_image/sampler' made possible that interface_type of image/sampler nir_variable may be null. This patch accounts for it and make use of the type of the variable instead of the interface_type. This prevents a number of cr

[Mesa-dev] [PATCH v2 11/21] spirv: Set nir_variable->explicit_binding

From: Neil Roberts When SpvDecorationBinding is encountered in the SPIR-V source it now sets explicit_binding on the nir_variable. This will be used to determine whether to initialise sampler and image uniforms with the binding value. --- src/compiler/spirv/vtn_private.h | 1 + src/compiler/sp

[Mesa-dev] [PATCH v2 13/21] nir/linker: Add gl_nir_link_uniforms()

From: Eduardo Lima Mitev This function will be the entry point for linking the uniforms from the nir_shader objects associated with the gl_linked_shaders of a program. This patch includes initial support for linking uniforms from NIR shaders. It is tailored for the ARB_gl_spirv needs, and it is

[Mesa-dev] [PATCH v2 12/21] compiler/link: add linker_util.h, move linker_error/warning to it

Linker utilities common to the GLSL IR and NIR linker (the latter to be used for ARB_gl_spirv). We need to move it to a new header as the NIR linker doesn't need to know about ir_variable, and others, included at linker.h. v2: move from src/compiler to src/compiler/glsl (Timothy Arceri) --- src/

[Mesa-dev] [PATCH v2 14/21] nir/linker: Set the uniform initial values

From: Neil Roberts This is based on link_uniform_initializers.cpp. v2: move from compiler/nir to compiler/glsl (Timothy Arceri) --- src/compiler/Makefile.sources | 1 + .../glsl/gl_nir_link_uniform_initializers.c| 292 + src/compiler/glsl/gl_ni

[Mesa-dev] [PATCH v2 18/21] i965: Update TexturesUsed after linking the shaders

From: Neil Roberts Otherwise if the shader is SPIR-V then SamplerUsed won’t have been initialised yet so it will end up thinking no textures are used. This was causing a crash later on if nothing causes it to regenerate TexturesUsed before the next render. --- src/mesa/drivers/dri/i965/brw_link.

[Mesa-dev] [PATCH v2 21/21] i965: Link uniforms of SPIR-V programs using the NIR linker

From: Eduardo Lima Mitev v2: nir_link_uniforms renamed to gl_nir_link_uniforms Signed-off-by: Eduardo Lima Signed-off-by: Alejandro Piñeiro --- src/mesa/drivers/dri/i965/brw_link.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/d

[Mesa-dev] [PATCH v2 16/21] nir/linker: Add nir_build_program_resource_list()

From: Eduardo Lima Mitev This function is equivalent to the linker.cpp build_program_resource_list() but will extract the resources from NIR shaders instead. For now, only uniforms and program inputs are implemented. v2: move from compiler/nir to compiler/glsl (Timothy Arceri) Signed-off-by: E

[Mesa-dev] [PATCH v2 20/21] i965: Setup glsl uniforms by index rather than name matching

From: Neil Roberts Previously when setting up a uniform it would try to walk the uniform storage slots and find one that matches the name of the given variable. However, each variable already has a location which is an index into the UniformStorage array so we can just directly jump to the right

[Mesa-dev] [PATCH v2 19/21] i965: account for NIR uniforms without name

From: Eduardo Lima Mitev Right now, the BRW linker code assumes nir_variable::name is always non-NULL, but thanks to ARB_gl_spirv we will soon be linking SPIR-V programs, and those explicitly require matching uniforms by location. The name is just a debug hint. Instead of checking for the name t

[Mesa-dev] [PATCH v2 15/21] compiler/link: move add_program_resource to linker_util

So it could be used by the GLSL and NIR linker. v2: (Timothy Arceri) * Moved from compiler to compiler/glsl * Method renamed to link_util_add_program_resource --- src/compiler/Makefile.sources | 1 + src/compiler/glsl/linker.cpp | 76 +++ src/co

[Mesa-dev] [PATCH v2 17/21] i965: Build SPIR-V programs' resource list using NIR

From: Eduardo Lima Mitev v2: tweak after nir_linker.h being renamed to gl_nir_linker.h --- src/mesa/drivers/dri/i965/brw_link.cpp | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/dri/i965/brw_link.cpp index 39fa

[Mesa-dev] [Bug 106480] A2B10G10R10_SNORM vertex attribute doesn't work.

https://bugs.freedesktop.org/show_bug.cgi?id=106480 --- Comment #5 from mais...@archlinux.us --- Yes, I should clarify that this is RX470, so Polaris. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [Bug 106480] A2B10G10R10_SNORM vertex attribute doesn't work.

https://bugs.freedesktop.org/show_bug.cgi?id=106480 --- Comment #6 from Bas Nieuwenhuizen --- That would explain, I tested on vega. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-d

Re: [Mesa-dev] [PATCH] anv, nir: add generated files to .gitignore(s)

Rb On May 11, 2018 05:12:59 Rhys Perry wrote: --- src/compiler/nir/.gitignore | 2 ++ src/intel/vulkan/.gitignore | 1 + 2 files changed, 3 insertions(+) diff --git a/src/compiler/nir/.gitignore b/src/compiler/nir/.gitignore index 64828eba6d..8faf93f0b2 100644 --- a/src/compiler/nir/.gitignore

[Mesa-dev] [Bug 106480] A2B10G10R10_SNORM vertex attribute doesn't work.

https://bugs.freedesktop.org/show_bug.cgi?id=106480 --- Comment #7 from mais...@archlinux.us --- FWIW, this also affects UNIFORM_TEXEL_BUFFER. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

[Mesa-dev] [Bug 106480] A2B10G10R10_SNORM vertex attribute doesn't work.

https://bugs.freedesktop.org/show_bug.cgi?id=106480 --- Comment #8 from Bas Nieuwenhuizen --- Yes, We'll likely "fix" that by not claiming support for R10G10B10A2 SNORM/SINT formats anymore since support is not required, and a fixup is not possible without significantly impacting perofrmance for

[Mesa-dev] [PATCH 1/2] radv: Fix up 2_10_10_10 alpha sign.

Pre-Vega HW always interprets the alpha for this format as unsigned, so we have to implement a fixup to do the sign correctly for signed formats. CC: 18.0 18.1 --- src/amd/vulkan/radv_nir_to_llvm.c | 61 --- src/amd/vulkan/radv_pipeline.c| 30 +-- src/

[Mesa-dev] [PATCH 2/2] radv: Disable texel buffers with A2 SNORM/SSCALED/SINT for pre-vega.

The hardware always interprets the alpha as unsigned and fixing it in the shader is going to add unacceptable overheads. CC: 18.0 18.1 --- src/amd/vulkan/radv_formats.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_fo

[Mesa-dev] [Bug 106480] A2B10G10R10_SNORM vertex attribute doesn't work.

https://bugs.freedesktop.org/show_bug.cgi?id=106480 --- Comment #9 from Bas Nieuwenhuizen --- This bug should be fixed by https://patchwork.freedesktop.org/series/43092/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

Re: [Mesa-dev] [RFC PATCH V2] radv: add initial support for VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT

Reviewed-by: Bas Nieuwenhuizen if you also have a spec to go with the new bit. (and add it to the headers) On Tue, May 8, 2018 at 7:58 AM, Timothy Arceri wrote: > When VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT is set we skip NIR > linking optimisations and only run over the NIR optimisation l

[Mesa-dev] [Bug 106480] A2B10G10R10_SNORM vertex attribute doesn't work.

https://bugs.freedesktop.org/show_bug.cgi?id=106480 --- Comment #10 from mais...@archlinux.us --- That would match AMDVLK, it exposes A2BGR10_SNORM for vertex, but not UNIFORM_TEXEL_BUFFER. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the b

Re: [Mesa-dev] [RFC PATCH V2] radv: add initial support for VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT

On 13/05/18 08:17, Bas Nieuwenhuizen wrote: Reviewed-by: Bas Nieuwenhuizen if you also have a spec to go with the new bit. (and add it to the headers) VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT is already part of the spec. I think you are getting confused with the previous discussion for a

Re: [Mesa-dev] [RFC PATCH V2] radv: add initial support for VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT

On Sun, May 13, 2018 at 12:46 AM, Timothy Arceri wrote: > On 13/05/18 08:17, Bas Nieuwenhuizen wrote: >> >> Reviewed-by: Bas Nieuwenhuizen >> >> if you also have a spec to go with the new bit. (and add it to the >> headers) > > > VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT is already part of the

[Mesa-dev] [PATCH 02/19] ac/nir: Implement the deref instr for shared memory.

--- src/amd/common/ac_nir_to_llvm.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index b77d62a39b0..333ecdb834e 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm

[Mesa-dev] [PATCH 07/19] radv: Add shader info support for image deref instructions.

--- src/amd/vulkan/radv_shader_info.c | 40 --- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_shader_info.c b/src/amd/vulkan/radv_shader_info.c index 57175b3d37b..5b31703f9cf 100644 --- a/src/amd/vulkan/radv_shader_info.c +++ b/src/

[Mesa-dev] [PATCH 03/19] ac/nir: Support deref instructions in get_sampler_desc.

--- src/amd/common/ac_nir_to_llvm.c | 58 - 1 file changed, 43 insertions(+), 15 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 333ecdb834e..29a7ce8e2dc 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/co

[Mesa-dev] [PATCH 01/19] fixup! anv, i965, radv, st, ir3: Call nir_lower_deref_instrs

Also apply the pass to radv meta shaders. --- src/amd/vulkan/radv_shader.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index afafea46f0c..d52471fe9e4 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader.c @

[Mesa-dev] [PATCH 00/19] AMD support for NIR deref instructions.

This implements support in radv and radeonsi for NIR deref instructions instead of deref chains. It contains 4 parts: - patch 1 is a fixup for the initial series by Jason - Add support everywhere for instruction based derefs - Stop lowering them to deref chains (may need to be synchronized with

[Mesa-dev] [PATCH 05/19] ac/nir: Implement derefs for integer gather4 lowering.

--- src/amd/common/ac_nir_to_llvm.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index c6c7af47630..1a22cadb750 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_n

[Mesa-dev] [PATCH 09/19] radv: Gather info for deref instr based load/store.

--- src/amd/vulkan/radv_shader_info.c | 64 +++ 1 file changed, 57 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_shader_info.c b/src/amd/vulkan/radv_shader_info.c index 5b31703f9cf..bdf30ead2f8 100644 --- a/src/amd/vulkan/radv_shader_info.c +++ b/src/

[Mesa-dev] [PATCH 04/19] ac/nir: Support deref instructions in tex instructions.

--- src/amd/common/ac_nir_to_llvm.c | 39 --- src/amd/vulkan/radv_shader_info.c | 13 +++ 2 files changed, 44 insertions(+), 8 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 29a7ce8e2dc..c6c7af47630 100644 --

[Mesa-dev] [PATCH 13/19] radv: Remove image_var stores.

--- src/amd/vulkan/radv_meta_bufimage.c | 40 +-- src/amd/vulkan/radv_meta_fast_clear.c | 10 +++ src/amd/vulkan/radv_meta_resolve_cs.c | 10 +++ 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/src/amd/vulkan/radv_meta_bufimage.c b/src/amd/vulkan

[Mesa-dev] [PATCH 17/19] ac/nir: Remove deref chain support.

--- src/amd/common/ac_nir_to_llvm.c | 404 1 file changed, 50 insertions(+), 354 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 762520a93a0..0fae6b799ca 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/c

[Mesa-dev] [PATCH 11/19] ac/nir: Add deref interp support.

--- src/amd/common/ac_nir_to_llvm.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index d8cb33e26ed..762520a93a0 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/com

[Mesa-dev] [PATCH 16/19] st/nir: Stop lowering deref instructions.

--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 3fdfebdc1fe..8d80c8cae22 100644 --- a/src/mesa/state_tracker/st_glsl_to_nir.cpp +++ b/src/mesa/state_track

[Mesa-dev] [PATCH 08/19] ac/nir: Add deref based var loads/stores.

--- src/amd/common/ac_nir_to_llvm.c | 207 1 file changed, 160 insertions(+), 47 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 0f27ba66374..73ac6c482d3 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/c

[Mesa-dev] [PATCH 10/19] ac/nir: Add shared atomic deref instr support.

--- src/amd/common/ac_nir_to_llvm.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 73ac6c482d3..d8cb33e26ed 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_n

[Mesa-dev] [PATCH 12/19] radv: Use deref instructions for tex derefs in meta shaders.

--- src/amd/vulkan/radv_meta.c| 20 ++ src/amd/vulkan/radv_meta_blit.c | 30 +++ src/amd/vulkan/radv_meta_blit2d.c | 21 --- src/amd/vulkan/radv_meta_bufimage.c | 22 src/amd/vulkan/radv_meta_fast_

[Mesa-dev] [PATCH 15/19] radv: Stop lowering deref instructions.

--- src/amd/vulkan/radv_shader.c | 4 1 file changed, 4 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index d52471fe9e4..72c05afef4e 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader.c @@ -179,8 +179,6 @@ radv_shader_compile_to

[Mesa-dev] [PATCH 19/19] radeonsi: Remove deref chain support in nir scan pass.

--- src/gallium/drivers/radeonsi/si_shader_nir.c | 34 +++- 1 file changed, 4 insertions(+), 30 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 21551a76d6b..c46d0ab5a82 100644 --- a/src/gallium/drivers/ra

[Mesa-dev] [PATCH 18/19] radv: Remove deref chain support in radv shader info pass.

--- src/amd/vulkan/radv_shader_info.c | 98 ++- 1 file changed, 5 insertions(+), 93 deletions(-) diff --git a/src/amd/vulkan/radv_shader_info.c b/src/amd/vulkan/radv_shader_info.c index bdf30ead2f8..ab424720de1 100644 --- a/src/amd/vulkan/radv_shader_info.c +++ b/src/

[Mesa-dev] [PATCH 14/19] radeonsi: Add deref support to the nir scan pass.

--- src/gallium/drivers/radeonsi/si_shader_nir.c | 74 1 file changed, 59 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index b4fba8b8812..21551a76d6b 100644 --- a/src/gallium/drivers/r

[Mesa-dev] [PATCH 06/19] ac/nir: Add deref support to image intrinsics.

--- src/amd/common/ac_nir_to_llvm.c | 130 1 file changed, 97 insertions(+), 33 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 1a22cadb750..0f27ba66374 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/co

[Mesa-dev] [Bug 106315] The witness + dxvk suffers flickering garbage

https://bugs.freedesktop.org/show_bug.cgi?id=106315 soredake changed: What|Removed |Added CC||fds...@krutt.org -- You are receiving this