Re: [Mesa-dev] [PATCH] glsl: Add ir_binop_vector_extract in NIR

2018-06-01 Thread Juan A. Suarez Romero
On Wed, 2018-05-30 at 15:10 -0700, Eric Anholt wrote: > "Juan A. Suarez Romero" writes: > > > Implement ir_binop_vector_extract using NIR operations. Based on SPIR-V > > to NIR approach. > > > > This fixes: > >

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #3 from Samuel Pitoiset --- Can you explain how to reproduce the crash ingame? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Brendan King
The IMG patch Eric was referring to was to dEQP. I submitted bug reports to Google and Khronos: https://issuetracker.google.com/issues/64059452 https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/594 I've attached the patch to this email. The problem is that the dEQP *resize.surface_size*

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Brendan King
The IMG patch Eric was referring to was to dEQP. I submitted bug reports to both Google and Khronos: https://issuetracker.google.com/issues/64059452 https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/594 I've attached the patch to this email. The problem is that the dEQP 

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Juan A. Suarez Romero
On Fri, 2018-06-01 at 09:39 +0100, Brendan King wrote: > The IMG patch Eric was referring to was to dEQP. I submitted bug > reports to Google and Khronos: > > https://issuetracker.google.com/issues/64059452 > > https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/594 > >

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Juan A. Suarez Romero
On Thu, 2018-05-31 at 17:24 +0100, Daniel Stone wrote: > Hi Eric, > > On 31 May 2018 at 17:13, Eric Engestrom wrote: > > On Thursday, 2018-05-31 16:57:17 +0100, Daniel Stone wrote: > > > Not initialising attached_{width,height} should not cause any problems > > > with these checks. By definition

Re: [Mesa-dev] [PATCH 0/2] Prevent regression with changes to nir_opt_if

2018-06-01 Thread Samuel Pitoiset
Thanks! I guess you are now okay with my nir_opt_if changes? I have one minor regression with one shader of RoTR but that shouldn't matter. Series is: Reviewed-by: Samuel Pitoiset On 06/01/2018 02:21 AM, Ian Romanick wrote: This series fixes the most agregious regressions caused by the

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Juan A. Suarez Romero
On Thu, 2018-05-31 at 16:57 +0100, Daniel Stone wrote: > Hi Juan, > Thanks for picking this up! > > On 31 May 2018 at 16:44, Juan A. Suarez Romero wrote: > > @@ -255,6 +257,12 @@ dri2_wl_create_window_surface(_EGLDriver *drv, > > _EGLDisplay *disp, > >goto cleanup_surf; > > } > > >

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

2018-06-01 Thread Samuel Pitoiset
On 06/01/2018 02:17 AM, Ian Romanick wrote: On 05/30/2018 10:06 AM, Samuel Pitoiset wrote: Similar for max(). Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir.h| 3 +++ src/compiler/nir/nir_opt_algebraic.py | 8 2 files changed, 11 insertions(+) diff

Re: [Mesa-dev] [PATCH 3/3] radv: Handle GFX9 merged shaders in radv_flush_constants()

2018-06-01 Thread Alex Smith
On 31 May 2018 at 21:15, Bas Nieuwenhuizen wrote: > On Thu, May 31, 2018 at 5:44 PM, Alex Smith > wrote: > > This was not previously handled correctly. For example, > > push_constant_stages might only contain MESA_SHADER_VERTEX because > > only that stage was changed by CmdPushConstants or > >

Re: [Mesa-dev] [PATCH] android: gallium/util: fix u_debug_stack_android build

2018-06-01 Thread Stuart Young
A related note on this: Seems this file (src/gallium/auxiliary/util/u_debug_stack_android.cpp) doesn't make it into the tarballs (didn't for 18.1.0). Probably needs to be added to Makefile.source and meson.build somewhere so that building the tarball finds it. I checked for commits to both since

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Juan A. Suarez Romero
On Thu, 2018-05-31 at 08:52 +0100, Daniel Stone wrote: > Hi Laura, > > On 30 May 2018 at 23:53, Laura Ekstrand wrote: > > @@ -0,0 +1,9 @@ > > +pages: > > + stage: deploy > > + script: > > + - mkdir .public > > + - cp -r docs/* .public > > + - mv .public public > > You should be able

Re: [Mesa-dev] [v4, 17/23] anv/allocator: Set the BO flags in bo_cache_alloc/import

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > It's safer to set them there because we have the opportunity to properly > handle combining flags if a BO is imported more than once. Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [v4, 18/23] anv/allocator: Support softpin in the BO cache

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > --- > src/intel/vulkan/anv_allocator.c | 54 > +++- > 1 file changed, 53 insertions(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/anv_allocator.c > b/src/intel/vulkan/anv_allocator.c > index 697da5f..f18e015 100644 > ---

Re: [Mesa-dev] [PATCH v4 22/23] anv: Soft-pin batch buffers

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > From: Scott D Phillips > > Co-authored-by: Jason Ekstrand Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [v4, 04/23] intel/common: Add an address de-cannonicalization helper

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > --- > src/intel/common/gen_gem.h | 10 ++ > 1 file changed, 10 insertions(+) > Reviewed-by: Kenneth Graunke > > diff --git a/src/intel/common/gen_gem.h b/src/intel/common/gen_gem.h > index 842a455..eef6a5e 100644 > --- a/src/intel/common/gen_gem.h > +++

Re: [Mesa-dev] [v4,19/23] anv: Soft-pin client-allocated memory

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > Now that we've done all that refactoring, addresses are now being > directly written into surface states by ISL and BLORP whenever a BO is > pinned so there's really nothing to do besides enable it. Reviewed-by: Scott D Phillips

Re: [Mesa-dev] [v4,10/23] anv: Use an anv_address in anv_buffer

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 23/23] anv: Soft-pin everything else

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > From: Scott D Phillips > > v2 (Jason Ekstrand): > - Break up Scott's mega-patch > > Reviewed-by: Jason Ekstrand Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [v4, 20/23] anv/batch_chain: Call batch_bo_finish at the end of end_batch_buffer

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > The only reason we were calling it in the middle was that one of the > cases for figuring out the secondary command buffer execution type > wanted batch_bo->length which gets set by batch_bo_finish. It's easy > enough to recalculate and now batch_bo_finish is called in

Re: [Mesa-dev] [v4, 11/23] anv/cmd_buffer: Rework surface relocation helpers

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > This commit renames add_surface_state_reloc to add_surface_reloc and > makes it takes an address. We also rename add_image_view_relocs to > add_surface_state_relocs because it takes an anv_surface_state and > doesn't really care about the image view anymore.

Re: [Mesa-dev] [v4, 07/23] anv: Use full anv_addresses in anv_surface_state

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > This refactors surface state filling to work entirely in terms of > anv_addresses instead of offsets. This should make things simpler for > when we go to soft-pin image buffers. Among other things, > add_image_view_relocs now only cares about the addresses in the

Re: [Mesa-dev] [v4, 12/23] anv: Use an address for each anv_image plane

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > This is better than having BO and offset fields. Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 05/23] anv: Add vma_heap allocators in anv_device

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > From: Scott D Phillips > > These will be used to assign virtual addresses to soft pinned > buffers in a later patch. > > Two allocators are added for separate 'low' and 'high' virtual > memory areas. Another alternative would have been to add a > double-sided allocator,

Re: [Mesa-dev] [v4, 09/23] anv/cmd_buffer: Use anv_address for handling indirect parameters

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [v4, 08/23] anv: Use an anv_address in anv_buffer_view

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > Instead of storing a BO and offset separately, use an anv_address. This > changes anv_fill_buffer_surface_state to use anv_address and we now call > anv_address_physical and pass that into ISL. Reviewed-by: Scott D Phillips

Re: [Mesa-dev] [v4,06/23] anv: Add some anv_address helpers

2018-06-01 Thread Scott D Phillips
Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [v4, 21/23] anv/batch_chain: Simplify secondary batch return chaining

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > Previously, we did this weird thing where we left space and an empty > relocation for use in a hypothetical MI_BATCH_BUFFER_START that would be > added to the secondary later. Then, when it came time to chain it into > the primary, we would back that out and emit an

Re: [Mesa-dev] [PATCH v4 13/23] anv/blorp: Write relocated values into surface states

2018-06-01 Thread Scott D Phillips
Jason Ekstrand writes: > From: Scott D Phillips > > v2 (Jason Ekstrand): > - Split the blorp bit into it's own patch and re-order a bit > - Use anv_address helpers > > Reviewed-by: Jason Ekstrand Reviewed-by: Scott D Phillips ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 2/2] nir: Lower !f2b(x) to x == 0.0

2018-06-01 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2018-05-31 at 17:21 -0700, Ian Romanick wrote: > From: Ian Romanick > > Some trivial help now, but it also prevents ~40 regressions caused by > Samuel's "nir: implement the GLSL equivalent of if simplication in > nir_opt_if" patch. > > All Gen4+

<    1   2