[Mesa-dev] [Bug 104665] r600: computer shaders break Bioshock on barts (bisected)

2018-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104665 --- Comment #5 from Gert Wollny --- Can't reproduce it any more as of git-8841c2cda51d, but I don't know which commit actually fixed the bug. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

Re: [Mesa-dev] GitLab migration update

2018-06-03 Thread Daniel Stone
Hi, On 2 June 2018 at 16:45, Jason Ekstrand wrote: > My current plan (if Daniel is amenable) is to due the migration late next > week. I'm tentatively thinking Thursday morning pacific but that may change > depending on Daniel's schedule. That works for me. > When the migration happens, there

[Mesa-dev] [Bug 106479] NDEBUG not defined for libamdgpu_addrlib

2018-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106479 --- Comment #2 from Juan A. Suarez --- Also, please verify with the latest versions. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ m

[Mesa-dev] [ANNOUNCE] mesa 18.0.5

2018-06-03 Thread Juan A. Suarez Romero
Mesa 18.0.5 is now available. In this release we have: Mesa core fixes GL_UNSIGNED_INT64_ARB usage, get rid of leak when using glUseProgram(), add glUniform*ui{v} support for display lists, and fixes texture finalizing that were causing assertions in CTS tests. Several fixes for intel/i965 drive

Re: [Mesa-dev] [ANNOUNCE] mesa 18.0.5

2018-06-03 Thread Juan A. Suarez Romero
On Sun, 2018-06-03 at 12:23 +0200, Juan A. Suarez Romero wrote: > Mesa 18.0.5 is now available. > NOTE: It is anticipated that 18.0.5 will be the final release in the 18.0 series. Users of 18.0 are encouraged to migrate to the 18.1 series in order to obtain future fixes. > In this release we ha

[Mesa-dev] [Bug 106163] r600/sb: optimizer tries to schedule access to different array elements in one instruction group

2018-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106163 mirh changed: What|Removed |Added CC||m...@protonmail.ch -- You are receiving this ma

[Mesa-dev] [Bug 106163] r600/sb: optimizer tries to schedule access to different array elements in one instruction group

2018-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106163 --- Comment #1 from Gert Wollny --- A patch fixing this has been submitted to the ML: https://patchwork.freedesktop.org/series/44053/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bu

Re: [Mesa-dev] [PATCH 6/6] r600g: fix unused variable warning

2018-06-03 Thread Gert Wollny
This patch doesn't apply, the "int i" was deleted already; I didn't find the commit though. Am Freitag, den 29.12.2017, 08:32 +0300 schrieb Konstantin Kharlamov: > Signed-off-by: Konstantin Kharlamov > --- > src/gallium/drivers/r600/r600_state_common.c | 1 - > 1 file changed, 1 deletion(-) >

Re: [Mesa-dev] [PATCH 1/6 v3] r600g: do not use "fast-clear" for small textures (v3)

2018-06-03 Thread Gert Wollny
This gives me ~200 FPS more with a 200x200 glxgears window with both, Barts and Ceder. Reviewed-by: Gert Wollny Am Montag, den 01.01.2018, 10:38 +0300 schrieb Konstantin Kharlamov: > Ported from radeonsi. Improves windowed glxgears ran as > > vblank_mode=0 glxgears -info -geometry 0+0+5

Re: [Mesa-dev] [PATCH 5/6] r600g: some -Wsign-compare fixes

2018-06-03 Thread Gert Wollny
Patches 2-4 Reviewed-By: Gert Wollny I can't push them though I'd like to add that for the future it would be better to - send the patches for st and r600 as separate series, this would make it easier to find reviewers - when fixing warning to add the specific warnings you fixed to

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-03 Thread Rob Clark
On Sat, Jun 2, 2018 at 7:49 PM, Jason Ekstrand wrote: > With all this talk of fancy looking new websites, I decided to take a crack > at being artsy and coming up with a fancy-looking logo to put on it. Here's > a first rough draft: > > https://people.freedesktop.org/~jekstrand/gears-logo-bold.pn

[Mesa-dev] [Bug 106687] radv: Fast color clears use incorrect format

2018-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106687 --- Comment #1 from Edmondo Tommasina --- This patch fixes the issue in Elex with DXVK for me. Thanks. (Polaris, RX 470, radv) -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

Re: [Mesa-dev] [PATCH 1/3] vbo: Reestablish VAO limit checking on imm VAOs.

2018-06-03 Thread Christian Gmeiner
Am Sa., 2. Juni 2018 um 08:53 Uhr schrieb : > > From: Mathias Fröhlich > > Bail out with out of memory, when the required stride exceeds the > maximum possible stride as stored in Const.MaxVertexAttribStride. > Etnaviv can only handle less than the OpenGL standard mandated > minimum of 2048. For t

[Mesa-dev] [PATCH 2/2] anv/android: Use an address for each anv_image plane

2018-06-03 Thread Mauro Rossi
Fixes to avoid building error after change in image->planes[] structure, {bo,bo_offset} has to be replaced by address.{bo,offset} and update is needed also in the assert() for debug builds. external/mesa/src/intel/vulkan/anv_android.c:188:21: error: no member named 'bo' in 'struct anv_image::(anon

[Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Mauro Rossi
Change to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few arguments to function call, expected 5, have 4 result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo); ~~~^ 1 er

Re: [Mesa-dev] [PATCH] mesa: Make sure that imm draws are flushed before other draws execute.

2018-06-03 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Jun 2, 2018 at 2:51 AM, wrote: > From: Mathias Fröhlich > > Hi all, > > The below patch fixes a recently introduced failure of my VAO rework. > I could finally reproduce the problem using the provided apitrace > (thanks Kai for the hint with the lower le

[Mesa-dev] [PATCH] nir: use num_components wrappers in print/validate.

2018-06-03 Thread Dave Airlie
From: Dave Airlie These wrappers were introduces, so start using them. --- src/compiler/nir/nir_print.c| 4 +--- src/compiler/nir/nir_validate.c | 16 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c

Re: [Mesa-dev] [PATCH] nir: use num_components wrappers in print/validate.

2018-06-03 Thread Jason Ekstrand
Rb On June 3, 2018 12:41:04 Dave Airlie wrote: From: Dave Airlie These wrappers were introduces, so start using them. --- src/compiler/nir/nir_print.c| 4 +--- src/compiler/nir/nir_validate.c | 16 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/src/compil

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Lionel Landwerlin
On 03/06/18 19:41, Mauro Rossi wrote: Change to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few arguments to function call, expected 5, have 4 result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo); ~~~

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-03 Thread Daniel Stone
Hi Laura, On 25 May 2018 at 01:27, Laura Ekstrand wrote: > When reviewing these patches, please note: > 1. This patch series does *not* touch content. Please do not bikeshed >the content of webpages here. That will be addressed in later >commits. > 2. Ple

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Mauro Rossi
Hi there, 2018-06-03 21:52 GMT+02:00 Lionel Landwerlin : > On 03/06/18 19:41, Mauro Rossi wrote: > >> Change to avoid building error: >> >> external/mesa/src/intel/vulkan/anv_android.c:131:72: >> error: too few arguments to function call, expected 5, have 4 >> result = anv_bo_cache_import(de

[Mesa-dev] [Bug 106784] 18.1.1 autotools build fail without mako

2018-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106784 Matt Turner changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |baker.dyla...@gmail.com

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Lionel Landwerlin
On 03/06/18 21:22, Mauro Rossi wrote: Hi there, 2018-06-03 21:52 GMT+02:00 Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>>: On 03/06/18 19:41, Mauro Rossi wrote: Change to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error:

[Mesa-dev] [PATCH 129.5/129] radv: Enable lower_io_to_temporaries after deref changes.

2018-06-03 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_shader.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index ff133ded722..929348d5e50 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader.c @@ -286,8 +286,6 @@ radv_shader_compile_to_

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Jason Ekstrand
On June 3, 2018 15:31:11 Lionel Landwerlin wrote: On 03/06/18 21:22, Mauro Rossi wrote: Hi there, 2018-06-03 21:52 GMT+02:00 Lionel Landwerlin : On 03/06/18 19:41, Mauro Rossi wrote: Change to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few argu

Re: [Mesa-dev] [PATCH 2/2] anv/android: Use an address for each anv_image plane

2018-06-03 Thread Lionel Landwerlin
On 03/06/18 19:41, Mauro Rossi wrote: Fixes to avoid building error after change in image->planes[] structure, {bo,bo_offset} has to be replaced by address.{bo,offset} and update is needed also in the assert() for debug builds. external/mesa/src/intel/vulkan/anv_android.c:188:21: error: no membe

[Mesa-dev] [PATCH 077.1/129] FIXUP: st, ir3, radeonsi: push lower_deref_instrs back into driver

2018-06-03 Thread Bas Nieuwenhuizen
Wrong place and we don't need it anymore anyway. --- src/gallium/drivers/radeonsi/si_compute.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index a27e6284adb..e20bae0afc4 100644 --- a/src/gallium/drivers

[Mesa-dev] [PATCH 000/129] AMD Fixups for the deref patches.

2018-06-03 Thread Bas Nieuwenhuizen
These are some fixes for v4 of Jasons deref instruction series. Furthermore patches 107-119: radv: Remove image_var stores. radv: Use deref instructions for tex derefs in meta shaders. radeonsi: Add deref support to the nir scan pass. ac/nir: Add deref interp support. ac/nir: Add shared atomic de

[Mesa-dev] [PATCH 038.1/129] FIXUP: nir: Support deref instructions in opt_undef

2018-06-03 Thread Bas Nieuwenhuizen
--- src/compiler/nir/nir_opt_undef.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_opt_undef.c b/src/compiler/nir/nir_opt_undef.c index 1439ca9c165..e42a9af2bdf 100644 --- a/src/compiler/nir/nir_opt_undef.c +++ b/src/compiler/nir/nir_opt_undef.c @

[Mesa-dev] [PATCH] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-03 Thread Mauro Rossi
Changes to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few arguments to function call, expected 5, have 4 result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo); ~~~^ 1 e

Re: [Mesa-dev] [PATCH v4 000/129] nir: Move to using instructions for derefs

2018-06-03 Thread Bas Nieuwenhuizen
On Sat, Jun 2, 2018 at 2:48 AM, Rob Clark wrote: > On Fri, Jun 1, 2018 at 1:01 AM, Jason Ekstrand wrote: >> This is something that Connor and I have been talking about for some time >> now. The basic idea is to replace the current singly linked nir_deref list >> with deref instructions. This is

[Mesa-dev] [PATCH 066.9/129] radv: Disable lower_io_to_temporaries during deref changes.

2018-06-03 Thread Bas Nieuwenhuizen
The ordering of passes is such that this already generates deref_var based stores before the lower_io_to_scalar pass is ready for it. --- src/amd/vulkan/radv_shader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 68f2a55e81

[Mesa-dev] [PATCH 070.1/129] FIXUP: nir: convert lower_io_to_scalar to deref instructions

2018-06-03 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_pipeline.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 43719449784..34249bf843d 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -2025,8 +2

[Mesa-dev] [PATCH 111.1/129] FIXUP: ac/nir: Add deref support to image intrinsics.

2018-06-03 Thread Bas Nieuwenhuizen
--- When removing the deref chain support you'll probably get a rebase conflict. src_shift + 2 has to become 3 there. src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index de477

[Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-03 Thread Mauro Rossi
Changes to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few arguments to function call, expected 5, have 4 result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo); ~~~^ 1 e

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Mauro Rossi
Hi, 2018-06-04 0:31 GMT+02:00 Lionel Landwerlin : > On 03/06/18 21:22, Mauro Rossi wrote: > > Hi there, > > 2018-06-03 21:52 GMT+02:00 Lionel Landwerlin < > lionel.g.landwer...@intel.com>: > >> On 03/06/18 19:41, Mauro Rossi wrote: >> >>> Change to avoid building error: >>> >>> external/mesa/src/

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-03 Thread Stuart Young
Perhaps just have the archive as a separate repo that gets pulled in by the main ci yaml at build, just to populate the archives directory? This avoids any possible submodule breakage (just not worth it here IMO), with no chance of accidentally pulling down all the archives. I know a few people wh

[Mesa-dev] [PATCH 073.1/129] FIXUP: nir: convert lower_io_arrays_to_elements to deref instructions

2018-06-03 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_pipeline.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 34249bf843d..375f7c357d3 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -2039,8 +2039,6 @@ void radv_cr

[Mesa-dev] [PATCH 069.1/129] FIXUP: move lower_deref_instrs

2018-06-03 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_pipeline.c | 4 ++-- src/amd/vulkan/radv_shader.c | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 59bbab714df..f4d076db795 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/am

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-03 Thread Jason Ekstrand
Looks good to me. Tapani (CCd) would know wheter we want EXEC_OBJECT_ASYNC or not. Either way (not setting EXEC_OBJECT_ASYNC won't hurt), Reviewed-by: Jason Ekstrand Sorry for the mess and thanks for fixing it! --Jason On Sun, Jun 3, 2018 at 5:38 PM, Mauro Rossi wrote: > Changes to avoid

[Mesa-dev] [Bug 106801] vma_random_test.cpp:239:18: error: non-constant-expression cannot be narrowed from type 'unsigned long' to 'uint_fast32_t' (aka 'unsigned int') in initializer list [-Wc++11-nar

2018-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106801 Bug ID: 106801 Summary: vma_random_test.cpp:239:18: error: non-constant-expression cannot be narrowed from type 'unsigned long' to 'uint_fast32_t' (aka 'unsigned i

[Mesa-dev] [PATCH] meson: fix private libs when building without glx

2018-06-03 Thread Lukas Rusak
I noticed that the generated pkg-config files will include glx and x11 dependencies even when x11 isn't a selected platform. This fixes the private libs and was tested by building kmscube --- meson.build | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/meson

Re: [Mesa-dev] [PATCH 2/2] anv/android: Use an address for each anv_image plane

2018-06-03 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Sun, Jun 3, 2018 at 11:41 AM, Mauro Rossi wrote: > Fixes to avoid building error after change in image->planes[] structure, > {bo,bo_offset} has to be replaced by address.{bo,offset} > and update is needed also in the assert() for debug builds. > > external/mesa/s

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-03 Thread Jason Ekstrand
On Sun, Jun 3, 2018 at 4:36 PM, Stuart Young wrote: > Perhaps just have the archive as a separate repo that gets pulled in by > the main ci yaml at build, just to populate the archives directory? > I was thinking something along those lines too. It would be easy enough to have a git repo for th

[Mesa-dev] [PATCH] nir: fix selection of loop terminator when two or more have the same limit

2018-06-03 Thread Timothy Arceri
We need to add loop terminators to the list in the order we come across them otherwise if two or more have the same exit condition we will select that last one rather than the first one even though its unreachable. This fix is for simple unrolls where we only have a single exit point. When unrolli

Re: [Mesa-dev] [PATCH 2/2] nir: add opt_if_loop_terminator()

2018-06-03 Thread Timothy Arceri
On 02/06/18 04:34, Ian Romanick wrote: On 05/31/2018 10:37 PM, Timothy Arceri wrote: This pass detects potential loop terminators and moves intructions from the non breaking branch after the if. This enables both the new opt_if_simplification() pass and loop unrolling to potentially progress f