Re: [Mesa-dev] [RFC][PATCH] gallivm: Clean up llvm data structures upon destruction.

This is OK but the code also needs to compile with Visual C++. Marek On Wed, Jul 18, 2018 at 4:34 PM, David Riley wrote: > Without this change, dlopen()/dlclose() of any driver results in memory > being leaked which becomes problematic if things are being reinitialized > repeatedly (eg from a fu

Re: [Mesa-dev] [PATCH V2 01/10] nir: evaluate if condition uses inside the if branches

On Thu, Jul 19, 2018 at 10:24 AM, Timothy Arceri wrote: > On 19/07/18 12:02, Connor Abbott wrote: >> >> Why not do the more general thing, and evaluate the condition in every >> block dominated by the then and else blocks? That should handle the >> loop and non-loop cases. > > > Can you explain wh

Re: [Mesa-dev] [PATCH 2/3] r600: Add R4G4B4A4 and A1B5G5R5 to supported vertex formats

On 2 July 2018 at 03:32, Gert Wollny wrote: > Below tests would fail with an error message > "Vertex format (R4G4B4A4|R5G5B5A1) not supported." > Add the formate to the translation routine to enable these formats. > > Fixes: > dEQP-GLES3.functional.texture.specification.teximage2d_pbo.rgba4_2d

Re: [Mesa-dev] [PATCH 2/3] r600: Add R4G4B4A4 and A1B5G5R5 to supported vertex formats

On 19 July 2018 at 15:07, Dave Airlie wrote: > On 2 July 2018 at 03:32, Gert Wollny wrote: >> Below tests would fail with an error message >> "Vertex format (R4G4B4A4|R5G5B5A1) not supported." >> Add the formate to the translation routine to enable these formats. >> >> Fixes: >> dEQP-GLES3.fu

Re: [Mesa-dev] [PATCH 2/2] nir: Do not use continue block after removing it.

Also, Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107275 On Wed, Jul 18, 2018 at 9:16 PM Jason Ekstrand wrote: > On Sat, Jul 14, 2018 at 4:26 PM Bas Nieuwenhuizen > wrote: > >> Reinserting code directly before a jump means the block gets split >> and merged, removing the original bl

Re: [Mesa-dev] [PATCH 1/3] nir: allow nir search type check to see through bcsel

Oh man... I was also recently looking at that same compute shader, and I wrote nearly identical patches the early part of last week. The bcsel patches caused a bit of pain for i965. I came up with a different way to handle that particular problem... either way, I eventually abandoned the whole ap

[Mesa-dev] [PATCH v3 4/4] radv: add support for VK_EXT_conditional_rendering

Inherited commands buffers are not supported. v3: - restore previous conditional rendering user state for fast clears v2: - disable predication for blit and copy commands Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 37 +++ src/amd/vulkan/ra

[Mesa-dev] [PATCH] radv: Fix incorrect assumption about ternary operator precedence

Signed-off-by: Danylo Piliaiev --- src/amd/vulkan/radv_shader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 1399005998..aac5b8a21a 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shad

Re: [Mesa-dev] [PATCH] radv: Fix incorrect assumption about ternary operator precedence

Reviewed-by: Samuel Pitoiset On 07/18/2018 10:47 AM, Danylo Piliaiev wrote: Signed-off-by: Danylo Piliaiev --- src/amd/vulkan/radv_shader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 1399005998..a

[Mesa-dev] [PATCH] glsl/ast: Fix loss of error_emitted value due to reassignment

Signed-off-by: Danylo Piliaiev --- src/compiler/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index dd60a2a87f..8a4cc56511 100644 --- a/src/compiler/glsl/ast_to_hir.cpp +++ b/src/compiler

[Mesa-dev] [PATCH] mesa: Fix copy-paste error in ConservativeRasterDilateRange initialization

Signed-off-by: Danylo Piliaiev --- src/mesa/main/context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 4243e03c5c..0ef8fe32a6 100644 --- a/src/mesa/main/context.c +++ b/src/mesa/main/context.c @@ -742,7 +742,7 @@ _mes

Re: [Mesa-dev] [PATCH v2 1/4] softpipe: Add assert verifying successful pipe_transfer_map

Thanks Brian! On 2018-07-17 16:18, Brian Paul wrote: On 07/17/2018 04:32 AM, Robert Foss wrote: This failure mode is a bit tricky to debug and manifests itself later as a null pointer dereference, for which finding the origin is needlessly tricky. Signed-off-by: Robert Foss --- Changes since

Re: [Mesa-dev] [PATCH v4 029/129] nir: Support deref instructions in lower_wpos_ytransform

Hi, I was running cppcheck on Mesa and found the issue mentioned here: This can't possibly work. The function immediately dereferences fragcoord, so it can't legally be NULL. Which then begs the question, how on earth did it work before? It would just read a non-existent variable out of the

Re: [Mesa-dev] [PATCH v3 4/4] radv: add support for VK_EXT_conditional_rendering

Reviewed-by: Bas Nieuwenhuizen Thanks for the improvements! On Wed, Jul 18, 2018 at 10:47 AM, Samuel Pitoiset wrote: > Inherited commands buffers are not supported. > > v3: - restore previous conditional rendering user state for fast clears > v2: - disable predication for blit and copy commands

Re: [Mesa-dev] [PATCH 1/4] intel/dump_gpu: Fix corner cases in PPGTT range calculations

On 18/07/18 00:05, Jason Ekstrand wrote: For large buffers which span an entire l1 page table, we got the range calculations wrong. In this case, we end up with an l1_start which is the first byte represented by the given l1 table and an l1_end which is the first byte after the range represented

[Mesa-dev] [PATCH] virgl: remove unused stride-arguments

The IOCTLs doesn't pass this along, so computing them in the first place is kinda pointless. Signed-off-by: Erik Faye-Lund --- This is just a cleanup I noticed based on some discussion with Gert. A question is, what code here expects this stride to be respected? The call-sites in virgl_*_transf

[Mesa-dev] [PATCH] shader-db: simplify and improve SSO handling

This does two things: 1. Allows cross shader optimisations to be preformed on SSO programs that contain more than one stage (seems like I don't have any of these in my shader-db collection). 2. Allows us to write compilation errors to stderr. With this change I discovered a Deus Ex: MD s

[Mesa-dev] [Bug 107275] NIR segfaults after spirv-opt

https://bugs.freedesktop.org/show_bug.cgi?id=107275 Bug ID: 107275 Summary: NIR segfaults after spirv-opt Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority:

<    1   2