Re: [Mesa-dev] [PATCH 01/14] mesa: remove incorrect change for EXT_disjoint_timer_query

Hi Marek; On 08/09/2018 02:55 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/main/queryobj.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index 7547fa1bb4d..e97a0138e96 100644 --- a/src/mesa/main/queryobj.c

[Mesa-dev] [PATCH] i965: Add a new CFL PCI ID.

One more CFL ID added to spec. Align with kernel commit d0e062ebb3a4 ("drm/i915/cfl: Add a new CFL PCI ID.") Cc: José Roberto de Souza Cc: Anuj Phogat Signed-off-by: Rodrigo Vivi --- include/pci_ids/i965_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/i965_pci_id

[Mesa-dev] [PATCH libdrm] drm/i915/cfl: Add a new CFL PCI ID.

One more CFL ID added to spec. Align with kernel commit d0e062ebb3a4 ("drm/i915/cfl: Add a new CFL PCI ID.") Cc: José Roberto de Souza Signed-off-by: Rodrigo Vivi --- intel/intel_chipset.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/intel/intel_chipset.h b/intel/i

Re: [Mesa-dev] [PATCH 14/14] radeonsi: increase the maximum UBO size to 2 GB

I'm not quite convinced you can really use huge ubos safely? At least direct addressing in tgsi can't work (you've only got a 16bit register index, and it's signed too). Roland Am 09.08.2018 um 01:55 schrieb Marek Olšák: > From: Marek Olšák > > Same as the closed driver. > > This causes a fail

Re: [Mesa-dev] [PATCH 10/14] tgsi/ureg: don't call tgsi_sanity when it's too slow

Am 09.08.2018 um 01:55 schrieb Marek Olšák: > From: Marek Olšák > > --- > src/gallium/auxiliary/tgsi/tgsi_ureg.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c > b/src/gallium/auxiliary/tgsi/tgsi_ureg.c > index 92c9

[Mesa-dev] [PATCH 4/4] imx: make use of loader_open_render_node(..) helper

Gets rid of hard-coded gpu device path. Signed-off-by: Christian Gmeiner --- src/gallium/winsys/imx/drm/imx_drm_winsys.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/imx/drm/imx_drm_winsys.c b/src/gallium/winsys/imx/drm/imx_drm_winsys.c index cd72610b

[Mesa-dev] [PATCH 2/4] loader: add loader_open_render_node(..)

This helper is almost a 1:1 copy of tegra_open_render_node(). Signed-off-by: Christian Gmeiner --- src/loader/loader.c | 65 + src/loader/loader.h | 3 +++ 2 files changed, 68 insertions(+) diff --git a/src/loader/loader.c b/src/loader/loader.c index

[Mesa-dev] [PATCH 3/4] tegra: make use loader_open_render_node(..) helper

Signed-off-by: Christian Gmeiner --- src/gallium/drivers/tegra/tegra_screen.c | 61 +--- 1 file changed, 2 insertions(+), 59 deletions(-) diff --git a/src/gallium/drivers/tegra/tegra_screen.c b/src/gallium/drivers/tegra/tegra_screen.c index 361ec034de..243bdde8d2 100644 ---

[Mesa-dev] [PATCH 1/4] tegra: fix memory leak

Signed-off-by: Christian Gmeiner --- src/gallium/drivers/tegra/tegra_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/tegra/tegra_screen.c b/src/gallium/drivers/tegra/tegra_screen.c index 034ea271ee..361ec034de 100644 --- a/src/gallium/drivers/tegra/tegra_screen.c

[Mesa-dev] [PATCH 0/4] Add and make use of loader_open_render_node(..)

Factor out tegra_open_render_node() into a helper and make use of it. Suggested-by: Emil Velikov Christian Gmeiner (4): tegra: fix memory leak loader: add loader_open_render_node(..) tegra: make use loader_open_render_node(..) helper imx: make use of loader_open_render_node(..) helper

Re: [Mesa-dev] [PATCH v4 00/15] TGSI: improved live range tracking, also including arrays

On 8 August 2018 at 06:18, Gert Wollny wrote: > Dear all, > > I'd like to get this series in the 18.3 release cycle applied. I've > been using it for quite some time without issues, and it seems to fix a > number of problems on r600. For instance, a number of dEQP-GLES31 tests > fail because of is

[Mesa-dev] [PATCH 2/8] mesa: expose AMD_gpu_shader_int64

From: Marek Olšák because the closed driver exposes it. It's equivalent to ARB_gpu_shader_int64. In this patch, I did everything the same as we do for ARB_gpu_shader_int64. --- docs/relnotes/18.3.0.html | 1 + src/compiler/glsl/builtin_functions.cpp | 3 +- src/compile

[Mesa-dev] [PATCH 5/8] mesa: expose AMD_texture_texture4

From: Marek Olšák because the closed driver exposes it. --- docs/relnotes/18.3.0.html| 1 + src/compiler/glsl/builtin_functions.cpp | 10 ++ src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++ src/mesa/main/extensions_table

[Mesa-dev] [PATCH 1/8] mesa: expose ARB_post_depth_coverage in the Compatibility profile

From: Marek Olšák It only contains GLSL changes. --- src/mesa/main/extensions_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index bdba49d5380..b4c1b203c57 100644 --- a/src/mesa/main/extensions_table

[Mesa-dev] [PATCH 3/8] mesa: expose AMD_multi_draw_indirect

From: Marek Olšák because the closed driver exposes it. This is equivalent to the ARB extension. --- docs/relnotes/18.3.0.html| 1 + src/mapi/glapi/gen/ARB_draw_indirect.xml | 20 src/mesa/main/extensions_table.h | 1 + 3 files changed, 22 insertion

[Mesa-dev] [PATCH 6/8] mesa: expose EXT_vertex_attrib_64bit

From: Marek Olšák because the closed driver exposes it. It's the same as the ARB extension. --- docs/relnotes/18.3.0.html | 1 + .../glapi/gen/EXT_vertex_attrib_64bit.xml | 70 +++ src/mapi/glapi/gen/gl_API.xml | 2 + src/mesa/main/extens

[Mesa-dev] [PATCH 4/8] mesa: expose AMD_query_buffer_object

From: Marek Olšák it's a subset of the ARB extension. --- docs/relnotes/18.3.0.html| 1 + src/mesa/main/extensions_table.h | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/18.3.0.html b/docs/relnotes/18.3.0.html index cf3bb80ceae..c0132311a25 100644 --- a/docs/relnotes

[Mesa-dev] [PATCH 7/8] st/mesa: expose EXT_disjoint_timer_query

From: Marek Olšák same cap as ARB_timer_query, no changes needed, tested by piglit --- docs/relnotes/18.3.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/18.3.0.html b/docs/relnotes/18.3.0.html index 3d6081708b

[Mesa-dev] [PATCH 0/8] Easy OpenGL extensions

Hi, This series adds these extensions: - AMD_gpu_shader_int64 - AMD_multi_draw_indirect - AMD_query_buffer_object - AMD_texture_texture4 - EXT_vertex_attrib_64bit It also exposes these extensions for gallium (radeonsi): - EXT_disjoint_timer_query - KHR_texture_compression_astc_sliced_3d It also

[Mesa-dev] [PATCH 8/8] st/mesa: expose KHR_texture_compression_astc_sliced_3d

From: Marek Olšák This is ASTC 2D LDR allowing texture arrays and 3D, compressing each slice as a separate 2D image. Tested by piglit. Trivial. --- docs/features.txt | 2 +- docs/relnotes/18.3.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 6 -- 3 fi

[Mesa-dev] [PATCH 4/4] radeonsi: implement EXT_window_rectangles

From: Marek Olšák --- docs/relnotes/18.3.0.html | 1 + src/amd/common/sid.h | 16 src/gallium/drivers/radeonsi/si_blit.c| 4 + src/gallium/drivers/radeonsi/si_get.c | 2 +- src/gallium/drivers/radeonsi/si_gfx_cs.c | 4 +

[Mesa-dev] [PATCH 2/4] noop: implement set_window_rectangles

From: Marek Olšák --- src/gallium/auxiliary/driver_noop/noop_state.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/driver_noop/noop_state.c b/src/gallium/auxiliary/driver_noop/noop_state.c index 80cfae8ad49..11e2c173a37 100644 --- a/src/gallium/auxiliary/driv

[Mesa-dev] [PATCH 3/4] gallium/u_blitter: save/restore window rectangles

From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c | 10 ++ src/gallium/auxiliary/util/u_blitter.h | 19 +++ 2 files changed, 29 insertions(+) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index a9df71108b4..fc86f

[Mesa-dev] [PATCH 1/4] ddebug: implement set_window_rectangles

From: Marek Olšák --- src/gallium/auxiliary/driver_ddebug/dd_context.c | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/auxiliary/driver_ddebug/dd_context.c b/src/gallium/auxiliary/driver_ddebug/dd_context.c index dd7b3e086cd..a1b6c971e89 100644 --- a/src/gallium/au

[Mesa-dev] [ANNOUNCE] Mesa 18.2.0-rc2

Hello list, The second release candidate for the Mesa 18.2.0 is now available. Currently we have: - 17 queued - 10 nominated (outstanding) - and 0 rejected patches In the current queue we have: Multiple fixes for the broadcom drivers while individual fixes for the swr and nouveau drivers and

[Mesa-dev] [PATCH 14/14] radeonsi: increase the maximum UBO size to 2 GB

From: Marek Olšák Same as the closed driver. This causes a failure in GL45-CTS.compute_shader.max, which has a trivial bug. --- src/gallium/drivers/radeonsi/si_get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/

[Mesa-dev] [PATCH 04/14] mesa: add ctx->Const.MaxGeometryShaderInvocations

From: Marek Olšák radeonsi wants to report a different value --- src/compiler/glsl/glsl_parser_extras.cpp | 3 ++- src/compiler/glsl/glsl_parser_extras.h | 1 + src/mesa/main/context.c | 1 + src/mesa/main/get_hash_params.py | 2 +- src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 11/14] gallium: add PIPE_CAP_MAX_GS_INVOCATIONS

From: Marek Olšák --- src/gallium/docs/source/screen.rst | 3 ++- src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 3 +++ src/gallium/drivers/i915/i915_screen.c | 3 +++ src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 12/14] gallium: add PIPE_CAP_MAX_SHADER_BUFFER_SIZE

From: Marek Olšák --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 3 +++ src/gallium/drivers/i915/i915_screen.c | 3 +++ src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 07/14] st/mesa: set ctx->Const.SubPixelBits

From: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 1c01495e937..5287dff6703 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/stat

[Mesa-dev] [PATCH 10/14] tgsi/ureg: don't call tgsi_sanity when it's too slow

From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi/tgsi_ureg.c index 92c98c763eb..c1c8851486e 100644 --- a/src/gallium/auxiliary/tgsi/t

[Mesa-dev] [PATCH 09/14] st/mesa: fix up uniform limits to be able to expose large UBOs

From: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 31 +++--- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 5e580aad2e4..1a0c4500c63 100644 --- a/src/mesa/state

[Mesa-dev] [PATCH 13/14] radeonsi: bump MAX_GS_INVOCATIONS

From: Marek Olšák same as the closed driver --- src/gallium/drivers/radeonsi/si_get.c | 4 +++- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 -- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/s

[Mesa-dev] [PATCH 05/14] mesa: make MaxCombinedUniformComponents 64-bit to allow large UBOs

From: Marek Olšák --- src/mesa/main/get_hash_params.py | 12 ++-- src/mesa/main/mtypes.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index dcfeac39190..ed5328df7cb 100644 --- a/src/m

[Mesa-dev] [PATCH 08/14] st/mesa: don't include compute resources in "Combined" limits

From: Marek Olšák The combined limits should only include shader stages that can be active at the same time. --- src/mesa/state_tracker/st_extensions.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st

[Mesa-dev] [PATCH 06/14] glsl: fix error checking against MAX_UNIFORM_LOCATIONS

From: Marek Olšák --- src/compiler/glsl/link_uniforms.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index 8d3f95fe114..434ecefb289 100644 --- a/src/compiler/glsl/link_uniforms.cpp +++ b/s

[Mesa-dev] [PATCH 03/14] mesa: don't include compute resources in MAX_COMBINED_* limits

From: Marek Olšák 5 is the maximum number of shader stages that can be used by 1 execution call at the same time (e.g. a draw call). The limit ensures that each stage can use all of its binding points. Compute is separate and doesn't need the 5x multiplier. --- src/mesa/main/config.h | 22 +

[Mesa-dev] [PATCH 00/14] Adjusting OpenGL limits and constants

Hi, The idea is to expose similar limits as our closed driver. There are also some bug fixes. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 02/14] mesa: bump GL_MAX_ELEMENTS_INDICES and GL_MAX_ELEMENTS_VERTICES

From: Marek Olšák same number as our closed GL driver --- src/mesa/main/config.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/config.h b/src/mesa/main/config.h index 6a2f766222a..fdf90d8956f 100644 --- a/src/mesa/main/config.h +++ b/src/mesa/main/config.h

[Mesa-dev] [PATCH 01/14] mesa: remove incorrect change for EXT_disjoint_timer_query

From: Marek Olšák --- src/mesa/main/queryobj.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index 7547fa1bb4d..e97a0138e96 100644 --- a/src/mesa/main/queryobj.c +++ b/src/mesa/main/queryobj.c @@ -815,22 +815,21 @@ get_q

[Mesa-dev] [Bug 107530] [Regression] widgets rendered black in gtk

https://bugs.freedesktop.org/show_bug.cgi?id=107530 Bug ID: 107530 Summary: [Regression] widgets rendered black in gtk Product: Mesa Version: 18.1 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH v2 10/11] intel: aubinator_viewer: store urb state during decoding

On 08/08/18 21:55, Rafael Antognolli wrote: t @@ -790,6 +892,7 @@ aub_viewer_render_batch(struct aub_viewer_decode_ctx *ctx, for (unsigned i = 0; i < ARRAY_SIZE(info_decoders); i++) { if (strcmp(inst_name, info_decoders[i].cmd_name) == 0) { +ctx->stage = info_de

Re: [Mesa-dev] [PATCH v2 11/11] intel: aubinator_viewer: add urb view

On 08/08/18 22:09, Rafael Antognolli wrote: + /* URB allocation */ + hovered = _Hovered(mouse_pos, window_hovered, alloc_tl, alloc_br); + ImGui::ColorConvertHSVtoRGB((2 * s) * 1.0f / (2 * n_stages), + 1.0f, hovered ? 1.0f : 0.8f, +

[Mesa-dev] [Bug 107524] Broken packDouble2x32 at llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=107524 --- Comment #2 from Dave Airlie --- Having a piglit shader_runner example test for this would be nice, if you had some time to make one. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the b

Re: [Mesa-dev] [PATCH v3 1/4] nv50/ir: add preliminary support for OP_XMAD

On Mon, Jul 23, 2018 at 12:40 PM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 26 > ++ > .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 18 +-- > .../drivers/nouveau/codegen/nv50_ir_print.cpp

Re: [Mesa-dev] [PATCH v2 07/11] intel: tools: aub_mem: reuse already mapped ppgtt buffers

On 08/08/18 20:07, Rafael Antognolli wrote: On Tue, Aug 07, 2018 at 06:35:18PM +0100, Lionel Landwerlin wrote: When we map a PPGTT buffer into a continous address space of aubinator to be able to inspect it, we currently add it to the list of BOs to unmap once we're finished. An optimization we

Re: [Mesa-dev] [PATCH v3] mesa: enable EXT_render_snorm extension

On Thu, Aug 02, 2018 at 02:14:31PM +0300, Tapani Pälli wrote: > Patch sets additional formats renderable and enables the extension > when OpenGL ES 3.1 is supported. > > v2: instead of dummy_true, have a separate toggle for extension > (Eric Anholt) > > v3: add missing checks, simplify some e

Re: [Mesa-dev] [PATCH v2 11/11] intel: aubinator_viewer: add urb view

On Tue, Aug 07, 2018 at 06:35:22PM +0100, Lionel Landwerlin wrote: > This is available through a "Show URB" button on the 3DPRIMITIVE > instructions. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/aubinator_viewer.cpp | 75 > src/intel/tools/aubinator_viewer_

Re: [Mesa-dev] [PATCH v2 10/11] intel: aubinator_viewer: store urb state during decoding

I'm not that familiar with this code yet, so take this review with a grain of salt, but it looks good to me. Reviewed-by: Rafael Antognolli Just a few comments below but nothing really important. On Tue, Aug 07, 2018 at 06:35:21PM +0100, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerl

Re: [Mesa-dev] [PATCH v2 07/11] intel: tools: aub_mem: reuse already mapped ppgtt buffers

On Tue, Aug 07, 2018 at 06:35:18PM +0100, Lionel Landwerlin wrote: > When we map a PPGTT buffer into a continous address space of aubinator > to be able to inspect it, we currently add it to the list of BOs to > unmap once we're finished. An optimization we can apply it to look up > that list befor

[Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

Commit 4434591bf56a6b0 caused substantially more URB messages in geometry and tessellation shaders. Before we can really enable this sort of optimization, We either need some way of combining them back together into vectors or we need to do cross-stage vector element elimination without splitting

Re: [Mesa-dev] [PATCH v3 14/48] meson: Make shader-cache a trillean instead of boolean

Quoting Eric Anholt (2018-08-07 10:58:52) > Dylan Baker writes: > > > So that it can be implicitly disabled on windows, where it doesn't > > compile. > > I don't see how this option successfully controls the shader cache being > built. The entire shader cache code in src/util/disk_cache.[ch] is

Re: [Mesa-dev] [PATCH v2 05/11] intel: tools: create libaub

Reviewed-by: Rafael Antognolli On Tue, Aug 07, 2018 at 06:35:16PM +0100, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/meson.build | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/src/intel/tools/meson.build b/src/in

[Mesa-dev] [PATCH] intel: Switch the order of the 2x MSAA sample positions

The Vulkan 1.1.82 spec flipped the order to better match D3D. Cc: mesa-sta...@lists.freedesktop.org --- src/intel/blorp/blorp_blit.c | 11 ++- src/intel/common/gen_sample_positions.h| 8 src/mesa/drivers/dri/i965/brw_multisample_state.h | 8 ++

[Mesa-dev] [Bug 106394] Black Mesa cannot compile shaders because of missing GL_EXT_gpu_shader4

https://bugs.freedesktop.org/show_bug.cgi?id=106394 --- Comment #6 from b...@besd.de --- While the patches allow the non-beta and beta version of Black-Mesa to start, I still get out of memory errors for both. The beta version does this right after you select to start a new game (in the loading g

[Mesa-dev] [Bug 107524] Broken packDouble2x32 at llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=107524 Roland Scheidegger changed: What|Removed |Added CC||airl...@freedesktop.org --- Commen

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

Hi Juan, On Wed, 8 Aug 2018 at 17:40, Juan A. Suarez Romero wrote: > On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > > wrote: > > > If color buffer is locked, do not set its wayland buffer to NULL; > > > otherwise it can not be fre

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

On Wed, 2018-08-08 at 18:39 +0200, Juan A. Suarez Romero wrote: > On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > > Hi Juan, > > > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > > wrote: > > > If color buffer is locked, do not set its wayland buffer to NULL; > > > otherwise it c

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

On 8 August 2018 at 17:29, Marek Olšák wrote: > On Wed, Aug 8, 2018 at 12:17 PM, Emil Velikov > wrote: >> On 8 August 2018 at 12:04, Emil Velikov wrote: >>> On 8 August 2018 at 06:42, Marek Olšák wrote: From: Marek Olšák This is needed for exposing the samplerBuffer functions u

Re: [Mesa-dev] [PATCH 0/3] Use GitLab CI to build Mesa

Hi Juan, On Wed, 8 Aug 2018 at 16:45, Juan A. Suarez Romero wrote: > This is a first part of a more complete proposal to use GitLab CI to build and > test Mesa. This first part just adds the required pieces to build Mesa, using > the > different supported tools (meson, autotools, and scons). Th

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > Hi Juan, > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > wrote: > > If color buffer is locked, do not set its wayland buffer to NULL; > > otherwise it can not be freed later. > > It can: see the 'if (i == ARRAY_SIZE(...))' branch

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

On Wed, Aug 8, 2018 at 12:17 PM, Emil Velikov wrote: > On 8 August 2018 at 12:04, Emil Velikov wrote: >> On 8 August 2018 at 06:42, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This is needed for exposing the samplerBuffer functions under >>> EXT_gpu_shader4. >>> >>> glTexBufferEXT is defin

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

Quoting Emil Velikov (2018-08-08 04:04:51) > On 8 August 2018 at 06:42, Marek Olšák wrote: > > From: Marek Olšák > > > > This is needed for exposing the samplerBuffer functions under > > EXT_gpu_shader4. > > > > glTexBufferEXT is defined in glapi, but "make check" fails. > > What am I doing wrong

Re: [Mesa-dev] [PATCH v4 2/2] wayland/egl: update surface size on window resize

Hi Juan, On Tue, 7 Aug 2018 at 16:50, Juan A. Suarez Romero wrote: > According to EGL 1.5 spec, section 3.10.1.1 ("Native Window Resizing"): > > "If the native window corresponding to _surface_ has been resized >prior to the swap, _surface_ must be resized to match. _surface_ will >norm

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

Hi Juan, On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero wrote: > If color buffer is locked, do not set its wayland buffer to NULL; > otherwise it can not be freed later. It can: see the 'if (i == ARRAY_SIZE(...))' branch inside wl_buffer_release. > This also fixes dEQP-EGL.functional.swap_b

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

On 8 August 2018 at 12:04, Emil Velikov wrote: > On 8 August 2018 at 06:42, Marek Olšák wrote: >> From: Marek Olšák >> >> This is needed for exposing the samplerBuffer functions under >> EXT_gpu_shader4. >> >> glTexBufferEXT is defined in glapi, but "make check" fails. >> What am I doing wrong?

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

Thanks. I'll remove the dispatch_sanity change. Marek On Wed, Aug 8, 2018 at 12:07 PM, Ilia Mirkin wrote: > It's not the alias itself that breaks it -- but you can only have one > entry per alias group. > > On Wed, Aug 8, 2018 at 12:03 PM, Marek Olšák wrote: >> Yes, it's aliased. It's weird, be

[Mesa-dev] [Bug 107524] Broken packDouble2x32 at llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=107524 Matwey V. Kornilov changed: What|Removed |Added CC||bri...@vmware.com -- You are rece

[Mesa-dev] [Bug 107524] Broken packDouble2x32 at llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=107524 Bug ID: 107524 Summary: Broken packDouble2x32 at llvmpipe Product: Mesa Version: git Hardware: All OS: Linux (All) Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

Quoting Eric Engestrom (2018-08-08 03:46:05) > On Tuesday, 2018-08-07 16:49:17 -0700, Dylan Baker wrote: > > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) > > > > > > anv_extensions_c = custom_target( > > > @@ -36,10 +37,11 @@ anv_extensions_c = custom_target( > > >input : ['anv_extensions_g

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

It's not the alias itself that breaks it -- but you can only have one entry per alias group. On Wed, Aug 8, 2018 at 12:03 PM, Marek Olšák wrote: > Yes, it's aliased. It's weird, because adding other aliased functions > into dispatch_sanity didn't break the test. > > Marek > > On Wed, Aug 8, 2018

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

Yes, it's aliased. It's weird, because adding other aliased functions into dispatch_sanity didn't break the test. Marek On Wed, Aug 8, 2018 at 12:00 PM, Ilia Mirkin wrote: > Sorry, I thought I was answering your question. > > If glTexBufferEXT is aliased to glTexBuffer (/glTexBufferARB), which >

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

Sorry, I thought I was answering your question. If glTexBufferEXT is aliased to glTexBuffer (/glTexBufferARB), which are already in the list of dispatch functions, you should not add the aliased name, otherwise you'll get failures. I did not, however, check if glTexBufferEXT is aliased in the disp

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

What does that mean? Marek On Wed, Aug 8, 2018 at 9:05 AM, Ilia Mirkin wrote: > Aliased functions shouldn't be added separately to the function list. > > On Wed, Aug 8, 2018 at 1:42 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> This is needed for exposing the samplerBuffer functions under

Re: [Mesa-dev] [PATCH 3/7] dri: Define DRI_MutableRenderBuffer extensions

On 07.08.2018 21:16, Chad Versace wrote: On Mon 06 Aug 2018, Chad Versace wrote: On Fri 03 Aug 2018, Tapani Pälli wrote: One tiny nit below but for patches 3,4 and 5: Reviewed-by: Tapani Pälli Special thanks for the documentation. I want to go through rest of changes within Android but I'm

[Mesa-dev] [PATCH 3/3] gitlab-ci: Build from the released tarballs

The `distcheck` stage creates a tarball ready for the distribution, and compiles it with the autotools to ensure everything works fine. But it does not try with the other tools: scons and meson. Hence, let's add a new stage that takes the generated tarball and builds it using meson and scons. Si

[Mesa-dev] [PATCH 2/3] gitlab-ci: build base images if dependencies changed

Most of times, the base and LLVM images do not require to be rebuilt, as the dependencies remains the same. To avoid rebuilding these images everytime, store in the image the Dockerfile's sha256sum: if the Dockerfile changes (because new dependencies were added or changed), then rebuild the image

[Mesa-dev] [PATCH 1/3] gitlab-ci: build Mesa using GitLab CI

Creates different Docker images containing Mesa built with different tools (autotools, meson, scons, etc). The build is done in 3 levels: the first level creates a base image with all the requirements to build Mesa. The second level (based of the first one), builds different images with different

[Mesa-dev] [PATCH 0/3] Use GitLab CI to build Mesa

Hello. This is a first part of a more complete proposal to use GitLab CI to build and test Mesa. This first part just adds the required pieces to build Mesa, using the different supported tools (meson, autotools, and scons). A second part, to be sent in the future, will use the results of the fo

Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.

On 08.08.2018 17:31, Lionel Landwerlin wrote: On 08/08/18 12:05, Lionel Landwerlin wrote: On 08/08/18 00:14, Bas Nieuwenhuizen wrote: radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this

Re: [Mesa-dev] [PATCH mesa] anv: set error in all failure paths

Reviewed-by: Lionel Landwerlin On 08/08/18 15:45, Eric Engestrom wrote: Cc: Jason Ekstrand Fixes: 5b196f39bddc689742d3 "anv/pipeline: Compile to NIR in compile_graphics" Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_pipeline.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(

[Mesa-dev] [Bug 107488] gl.h:2090: error: redefinition of typedef ‘GLeglImageOES’

https://bugs.freedesktop.org/show_bug.cgi?id=107488 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH mesa] anv: set error in all failure paths

Yep currently result is not set on this path; Reviewed-by: Tapani Pälli On 08.08.2018 17:45, Eric Engestrom wrote: Cc: Jason Ekstrand Fixes: 5b196f39bddc689742d3 "anv/pipeline: Compile to NIR in compile_graphics" Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_pipeline.c | 4 +++-

Re: [Mesa-dev] [PATCH] travis: make drivers explicit in Meson targets

On Wednesday, 2018-08-08 16:36:55 +0200, Juan A. Suarez Romero wrote: > Like in the autotools target, make the list of drivers to be built in > each of the Meson targets explicit. > > This will help to identify missing dependencies and other issues more > easily. > > CC: Emil Velikov Technicall

Re: [Mesa-dev] [PATCH] i965: Advertise 8 bits subpixel precision for viewport bounds on gen6+

Hi, Since the exact value is not important for users,  Roland offered compelling explanation and the value is also 8 on Windows - could the patch be reviewed/pushed? - Danil On 06/19/2018 03:44 PM, Roland Scheidegger wrote: My guess would be 8 because that's what the rasterization subpixel p

[Mesa-dev] [PATCH mesa] anv: set error in all failure paths

Cc: Jason Ekstrand Fixes: 5b196f39bddc689742d3 "anv/pipeline: Compile to NIR in compile_graphics" Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_pipeline.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeli

[Mesa-dev] [PATCH] travis: make drivers explicit in Meson targets

Like in the autotools target, make the list of drivers to be built in each of the Meson targets explicit. This will help to identify missing dependencies and other issues more easily. CC: Emil Velikov --- .travis.yml | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff

Re: [Mesa-dev] [PATCH mesa] intel/tools: add missing variable initialisation

On Wednesday, 2018-08-08 15:29:49 +0100, Lionel Landwerlin wrote: > Reviewed-by: Lionel Landwerlin > > bo_addr doesn't have a warning? Nope; I guess bo_type guards it perfectly ;) > > On 08/08/18 15:27, Eric Engestrom wrote: > > Cc: Lionel Landwerlin > > Signed-off-by: Eric Engestrom > > ---

Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.

On 08/08/18 12:05, Lionel Landwerlin wrote: On 08/08/18 00:14, Bas Nieuwenhuizen wrote: radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this repetition makes even less sense, so lets merge t

Re: [Mesa-dev] [PATCH mesa] intel/tools: add missing variable initialisation

On Wednesday, 2018-08-08 15:27:13 +0100, Eric Engestrom wrote: > Cc: Lionel Landwerlin Actually: Cc: Jason Ekstrand Fixes: 6a60beba4089315685b8 "intel/tools: Add an error state to aub translator" > Signed-off-by: Eric Engestrom > --- > src/intel/tools/error2aub.c | 2 +- > 1 file changed, 1 i

Re: [Mesa-dev] [PATCH mesa] intel/tools: add missing variable initialisation

Reviewed-by: Lionel Landwerlin bo_addr doesn't have a warning? On 08/08/18 15:27, Eric Engestrom wrote: Cc: Lionel Landwerlin Signed-off-by: Eric Engestrom --- src/intel/tools/error2aub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/error2aub.c b/src

[Mesa-dev] [PATCH mesa] intel/tools: add missing variable initialisation

Cc: Lionel Landwerlin Signed-off-by: Eric Engestrom --- src/intel/tools/error2aub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/error2aub.c b/src/intel/tools/error2aub.c index 3407dcec0b795168c4c8..2030593691cc4ba6dba0 100644 --- a/src/intel/tools/error2au

[Mesa-dev] [Bug 107457] [Tracker] Mesa 18.2 release tracker

https://bugs.freedesktop.org/show_bug.cgi?id=107457 Mark Janes changed: What|Removed |Added Depends on||107223 Referenced Bugs: https://bugs.fre

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

Aliased functions shouldn't be added separately to the function list. On Wed, Aug 8, 2018 at 1:42 AM, Marek Olšák wrote: > From: Marek Olšák > > This is needed for exposing the samplerBuffer functions under > EXT_gpu_shader4. > > glTexBufferEXT is defined in glapi, but "make check" fails. > What

[Mesa-dev] [Bug 106394] Black Mesa cannot compile shaders because of missing GL_EXT_gpu_shader4

https://bugs.freedesktop.org/show_bug.cgi?id=106394 --- Comment #5 from Gregor Münch --- Just tested the patch series with Black Mesa (non beta) and it started working. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 6.0

On Mon, 2018-08-06 at 11:52 +0200, Juan A. Suarez Romero wrote: > RADV now requires LLVM 6.0 or greater, and thus we can't build dist > tarball because swr requires LLVM 5.0. > > Let's bump required LLVM to 6.0 in swr too. > > Fixes: fd1121e839 ("amd: remove support for LLVM 5.0") > Cc: Tim Rowle

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 6.0

On Monday, 2018-08-06 11:52:48 +0200, Juan A. Suarez Romero wrote: > RADV now requires LLVM 6.0 or greater, and thus we can't build dist > tarball because swr requires LLVM 5.0. > > Let's bump required LLVM to 6.0 in swr too. > > Fixes: fd1121e839 ("amd: remove support for LLVM 5.0") > Cc: Tim Ro

Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.

On 08/08/18 00:14, Bas Nieuwenhuizen wrote: radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this repetition makes even less sense, so lets merge them. I took the anv generators as the templat

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

On 8 August 2018 at 06:42, Marek Olšák wrote: > From: Marek Olšák > > This is needed for exposing the samplerBuffer functions under > EXT_gpu_shader4. > > glTexBufferEXT is defined in glapi, but "make check" fails. > What am I doing wrong? There should be one in src/mapi/glapi/gen/ One of these d

Re: [Mesa-dev] [PATCH] travis: remove libedit-dev dependency in LLVM 6.0 targets

On 8 August 2018 at 11:20, Juan A. Suarez Romero wrote: > In LLVM <6.0 we added explicitly libedit-dev, as it was required to > satisfy apt dependencies. > > In LLVM 6.0, this is not required anymore, so let's remove it. > > CC: Emil Velikov Bit-by-bit we'll remove all the hacks/workarounds. Than

  1   2   >