Re: [Mesa-dev] [PATCH 2/3] radeonsi: use radeon_info::name

2018-08-12 Thread Timothy Arceri
patches 1-2: Reviewed-by: Timothy Arceri On 11/08/18 04:32, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_get.c | 49 ++ src/gallium/drivers/radeonsi/si_pipe.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.h | 1 - 3 files changed, 12

Re: [Mesa-dev] [PATCH 11/11] st/mesa: expose EXT_gpu_shader4 if GLSL 1.30 is supported

2018-08-12 Thread Timothy Arceri
I really only skimmed over patch 9. But everything seemed ok so for the series: Reviewed-by: Timothy Arceri On 08/08/18 15:42, Marek Olšák wrote: From: Marek Olšák --- docs/relnotes/18.3.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 1 + 2 files changed, 2 insertio

[Mesa-dev] [PATCH] gallium: Split out PIPE_CAP_TEXTURE_MIRROR_CLAMP_TO_EDGE.

2018-08-12 Thread Kenneth Graunke
Some hardware can do PIPE_TEX_WRAP_MIRROR_REPEAT but not PIPE_TEX_WRAP_MIRROR_CLAMP and PIPE_TEX_WRAP_MIRROR_CLAMP_TO_BORDER. Drivers for such hardware would like to advertise support for ARB_texture_mirror_clamp_to_edge but not EXT_texture_mirror_clamp. This commit adds a new PIPE_CAP_TEXTURE_MI

[Mesa-dev] [Bug 99730] Metro Redux game(s) needs override for midshader extension declaration

2018-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99730 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 99730, which changed state. Bug 99730 Summary: Metro Redux game(s) needs override for midshader extension declaration https://bugs.freedesktop.org/show_bug.cgi?id=99730 What|Removed |Ad

Re: [Mesa-dev] [PATCH 10/10] i965/nir: Use the nir copy of shader_info to handle gl_PatchVerticesIn

2018-08-12 Thread Timothy Arceri
6-10: Reviewed-by: Timothy Arceri On 09/08/18 23:43, Alejandro Piñeiro wrote: From: Neil Roberts Instead of using the copy of shader_info stored in gl_program, it now uses the one in nir_shader. This is needed for SPIR-V because the info.tess.tcs_vertices_out is filled in via _mesa_spirv_to_

Re: [Mesa-dev] [PATCH 03/10] nir: add how_declared to nir_variable.data

2018-08-12 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 09/08/18 23:43, Alejandro Piñeiro wrote: Equivalent to the already existing how_declared at GLSL IR. The only difference is that we are not adding all the declaration_type available on GLSL, only the one that we will use on the short term. We would add more mode i

Re: [Mesa-dev] [PATCH 04/10] nir/linker: take into account hidden uniforms

2018-08-12 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 09/08/18 23:43, Alejandro Piñeiro wrote: So they are not exposed through the introspection API. It is worth to note that the number of hidden uniforms of GLSL linking vs SPIR-V linking would be somewhat different due the differen order of the nir lowerings/optimi

Re: [Mesa-dev] [PATCH 01/10] spirv: fill info.gs.input_primitive too

2018-08-12 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 09/08/18 23:43, Alejandro Piñeiro wrote: info.gs.output_primitive was already being filled. Not sure why this is not needed on Vulkan, but we found to be needed for ARB_gl_spirv. Specifically, this is needed to get the following test passing: KHR-GL45.gl_spirv.sp

[Mesa-dev] [Bug 107549] dota2 vulkan crash at start

2018-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107549 Sylvain BERTRAND changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|NEW

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2018-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #8 from amonpaike --- I also forgot the ESM shadow (exponential shadow mapping) do not work, while the VSM (variance shadow mapping) work I hope you have a little knowledge of blender, they are settable in the render panel (came

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2018-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #7 from amonpaike --- (In reply to Gert Wollny from comment #6) > I've pushed the series, so this might be fixed (although I've seen new > piglits that fail with the same error also with this array split patch > series applied. hi,

[Mesa-dev] [Bug 107530] [Regression] widgets rendered black in gtk

2018-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107530 --- Comment #7 from Lukas K. --- (In reply to Lionel Landwerlin from comment #6) > You can workaround that issue by disabling the texture from pixmap mechanism > of GTK+ by setting GDK_GL=software-draw-surface. > > I'm not really experienced en

[Mesa-dev] [Bug 107530] [Regression] widgets rendered black in gtk

2018-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107530 --- Comment #6 from Lionel Landwerlin --- So I went back and compiled 18.0.5 and unfortunately it doesn't work for me. All the widgets are black outside the GLArea. Interestingly if you set LIBGL_DRI3_DISABLE=1 the rendering of the widgets some

[Mesa-dev] [Bug 107550] "0[2]" as function parameter hits assert

2018-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107550 Bug ID: 107550 Summary: "0[2]" as function parameter hits assert Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 107549] dota2 vulkan crash at start

2018-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107549 Bug ID: 107549 Summary: dota2 vulkan crash at start Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: blocker

Re: [Mesa-dev] [PATCH] mesa/st/glsl_to_tgsi: fixup copy-paste mistake

2018-08-12 Thread Gert Wollny
Indeed, thanks for checking Reviewed-By: Gert Wollny Am Sonntag, den 12.08.2018, 15:49 +0200 schrieb Erik Faye-Lund: > This is clearly a copy-paste error; if we validate the reladdr2- > pointer, we don't want to traverse to the reladdr-pointer. Especially > since the check above shows that rela

[Mesa-dev] [PATCH] mesa/st/glsl_to_tgsi: fixup copy-paste mistake

2018-08-12 Thread Erik Faye-Lund
This is clearly a copy-paste error; if we validate the reladdr2-pointer, we don't want to traverse to the reladdr-pointer. Especially since the check above shows that reladdr could be NULL here. Noticed by Coverity. CID: 1438389, 1438390 Fixes: 568bda2f2d3 ("mesa/st/glsl_to_tgsi: Split arrays who