[Mesa-dev] [Bug 107610] Dolphin emulator mis-renders shadow overlay in Super Mario Sunshine

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107610 --- Comment #4 from Samuel Pitoiset --- According to renderdoc logs you recorded the trace on NVIDIA, is that expected? The trace is incompatible. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

Re: [Mesa-dev] [PATCH] autotools: include git_sha1.h in dist tarball

2018-08-20 Thread Juan A. Suarez Romero
On Mon, 2018-08-20 at 21:32 +0100, Eric Engestrom wrote: > On Monday, 2018-08-20 14:23:28 +, Juan A. Suarez Romero wrote: > > This fixes `make distcheck`. > > > > Fixes: 471f708ed6 ("git_sha1: simplify logic") > > CC: Eric Engestrom > > --- > > src/Makefile.am | 2 +- > > 1 file changed, 1 i

[Mesa-dev] [Bug 107610] Dolphin emulator mis-renders shadow overlay in Super Mario Sunshine

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107610 --- Comment #3 from Christopher Snowhill --- Here you go, but it's from a later point in the game, and I don't know if it still triggers the issue. https://f.losno.co/delfino-plaza.rdc.xz -- You are receiving this mail because: You are the QA

[Mesa-dev] [PATCH 3/7] radeonsi: add SI_QUERY_TIME_ELAPSED_SDMA for measuring SDMA performance

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/sid.h | 4 src/gallium/drivers/radeonsi/si_dma_cs.c | 29 src/gallium/drivers/radeonsi/si_pipe.h | 2 ++ src/gallium/drivers/radeonsi/si_query.c | 21 +++-- src/gallium/drivers/radeonsi/si_que

[Mesa-dev] [PATCH 6/7] radeonsi: let internal compute dispatches tune WAVES_PER_SH

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 8 src/gallium/drivers/radeonsi/si_pipe.h| 1 + 2 files changed, 9 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index c5d3d5fcf02..e0c6902fec4 1006

[Mesa-dev] [PATCH 5/7] radeonsi: add TGSI_SEMANTIC_CS_USER_DATA for reading up to 4 SGPRs with TGSI

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c| 16 +--- src/gallium/drivers/radeonsi/si_compute.h| 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 11 +++ src/gallium/drivers/r

[Mesa-dev] [PATCH 7/7] radeonsi: add a thorough clear/copy_buffer benchmark

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/Makefile.sources | 2 +- src/gallium/drivers/radeonsi/meson.build | 2 +- src/gallium/drivers/radeonsi/si_blit.c| 2 +- src/gallium/drivers/radeonsi/si_cp_dma.c | 8 +- src/gallium/drivers/radeonsi/si_pipe.c|

[Mesa-dev] [PATCH 2/7] radeonsi: add flag L2_STREAM for minimal cache usage

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/sid.h | 2 ++ src/gallium/drivers/radeonsi/si_cp_dma.c | 16 ++-- src/gallium/drivers/radeonsi/si_pipe.h | 1 + 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/src/amd/common/sid.h b/src/amd/common/sid.h ind

[Mesa-dev] [PATCH 4/7] radeonsi: add SI_QUERY_TIME_ELAPSED_SDMA_SI for measuring DMA on SI

2018-08-20 Thread Marek Olšák
From: Marek Olšák DMA on SI doesn't support the timestamp packet, so it's emulated. --- src/gallium/drivers/radeonsi/si_query.c | 19 +++ src/gallium/drivers/radeonsi/si_query.h | 1 + 2 files changed, 20 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_query.c b/src

[Mesa-dev] [PATCH 1/7] gallium: add TGSI_MEMORY_STREAM_CACHE_POLICY

2018-08-20 Thread Marek Olšák
From: Marek Olšák For internal radeonsi shaders. --- src/gallium/auxiliary/tgsi/tgsi_strings.c | 3 ++- src/gallium/auxiliary/tgsi/tgsi_strings.h | 2 +- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 3 +++ src/gallium/include/pipe/p_shader_tokens.h| 8 ++-- 4 f

[Mesa-dev] [Bug 106590] Wrong line numbers expanded while compiling shaders

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106590 --- Comment #7 from Zhaowei Yuan --- (In reply to Kenneth Graunke from comment #6) > (In reply to Mark Janes from comment #5) > > This seems like a duplicate of > > > > https://bugs.freedesktop.org/show_bug.cgi?id=106807 > > > > My faint rec

[Mesa-dev] [Bug 107610] Dolphin emulator mis-renders shadow overlay in Super Mario Sunshine

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107610 --- Comment #2 from Christopher Snowhill --- Would that depend on the GPU installed? I kind of pulled that one out after a 6GB memtestCL caused the whole GPU to lock up. I also experienced a Spotify rendering glitch: https://imgur.com/a/TlCCio2

Re: [Mesa-dev] [PATCH 05/11] glsl: enable types for EXT_gpu_shader4

2018-08-20 Thread Marek Olšák
On Mon, Aug 13, 2018 at 1:42 PM Ian Romanick wrote: > > On 08/07/2018 10:42 PM, Marek Olšák wrote: > > From: Chris Forbes > > > > --- > > src/compiler/glsl/builtin_types.cpp | 32 ++ > > src/compiler/glsl/glsl_lexer.ll | 50 ++--- > > 2 files changed,

[Mesa-dev] [PATCH] mesa: only allow EXT_gpu_shader4 in the compatibility profile

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/extensions_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index af5edb35051..9f9038f97c6 100644 --- a/src/mesa/main/extensions_table.h +++ b/src/mesa/main/extensio

Re: [Mesa-dev] [PATCH v4] anv: add VK_EXT_sampler_filter_minmax support

2018-08-20 Thread He, Yunchao
Thanks for your review, Lionel. With the help from Clayton Craft to run the CI, this patch can pass CI: http://otc-mesa-ci.jf.intel.com/job/Richard_Yunchao/1/ Regards Yunchao -Original Message- From: Landwerlin, Lionel G Sent: Monday, August 20, 2018 11:11 AM To: He, Yunchao ; mesa-de

[Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-20 Thread Marek Olšák
From: Marek Olšák This is needed for exposing the samplerBuffer functions under EXT_gpu_shader4. v2: - expose it in the compat profile only - make it an alias of EXT_gpu_shader4 Reviewed-by: Timothy Arceri (v1) --- docs/relnotes/18.3.0.html| 1 + src/mesa/main/extensions_table.h |

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-20 Thread Marek Olšák
On Mon, Aug 13, 2018 at 12:58 PM Ian Romanick wrote: > > On 08/10/2018 08:14 PM, Marek Olšák wrote: > > On Fri, Aug 10, 2018 at 9:04 PM, Ian Romanick wrote: > >> On 08/07/2018 10:42 PM, Marek Olšák wrote: > >>> From: Marek Olšák > >>> > >>> This is needed for exposing the samplerBuffer functions

[Mesa-dev] [PATCH 4/9] radeonsi: print the shader stage name when printing LLVM IR

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 354c05e3d9d..81c825db1e4 100644 --- a/src/gallium/drivers/radeonsi/si_sh

[Mesa-dev] [PATCH 2/9] radeonsi/gfx9: fix WAITCNT flags

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader_internal.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_internal.h b/src/gallium/drivers/radeonsi/si_shader_internal.h index ac7784f7d46..6cc503690da 100644 --- a/s

[Mesa-dev] [PATCH 3/9] radeonsi: use is_merged shader in si_prolog_get_rw_buffers

2018-08-20 Thread Marek Olšák
From: Marek Olšák needed to change the input type to si_shader_context --- src/gallium/drivers/radeonsi/si_shader.c | 32 +++- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 8/9] ac,radeonsi: use ac_build_fmad

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 3 +-- src/amd/common/ac_nir_to_llvm.c | 7 ++- src/gallium/drivers/radeonsi/si_shader.c | 17 + 3 files changed, 8 insertions(+), 19 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/am

[Mesa-dev] [PATCH 7/9] radeonsi: use ac_build_imad

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 54 ++- .../drivers/radeonsi/si_shader_tgsi_mem.c | 18 +++ .../drivers/radeonsi/si_shader_tgsi_setup.c | 14 ++--- 3 files changed, 29 insertions(+), 57 deletions(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH 1/9] ac: completely remove +auto-waitcnt-before-barrier

2018-08-20 Thread Marek Olšák
From: Marek Olšák it causes corruption on several different GPU generations. Cc: 18.2 --- src/amd/common/ac_llvm_util.c | 7 ++- src/amd/common/ac_llvm_util.h | 1 - src/gallium/drivers/radeonsi/si_pipe.c | 1 - 3 files changed, 2 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 6/9] ac: add imad & fmad helpers

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 14 ++ src/amd/common/ac_llvm_build.h | 4 2 files changed, 18 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index c89bdf49faf..6d5bfb1a1be 100644 --- a/src/amd/common/ac_llvm_b

[Mesa-dev] [PATCH 9/9] ac, radeonsi: use ac_build_gather_values more

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_nir_to_llvm.c | 14 +++ src/gallium/drivers/radeonsi/si_shader.c | 8 +++--- .../drivers/radeonsi/si_shader_tgsi_mem.c | 25 +++ .../drivers/radeonsi/si_shader_tgsi_setup.c | 17 - 4 files chang

[Mesa-dev] [PATCH 5/9] ac: add ac_build_s_barrier

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 6 ++ src/amd/common/ac_llvm_build.h | 1 + src/amd/common/ac_nir_to_llvm.c | 3 +-- src/gallium/drivers/radeonsi/si_shader.c | 4 +--- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/amd/c

[Mesa-dev] [PATCH 1/2] st/mesa: help fix stencil border color for GL_DEPTH_STENCIL textures

2018-08-20 Thread Marek Olšák
From: Marek Olšák GL_STENCIL_INDEX uses GL_INTENSITY for the border color, which is nicer to hardware that doesn't read the stencil border value from the X channel. This fixes a bunch of dEQP tests on Vega & Raven. Cc: 18.1 18.2 --- src/mesa/state_tracker/st_atom_sampler.c | 3 +++ 1 file cha

[Mesa-dev] [PATCH 2/2] st/vdpau: silence an unitialized-variable warning

2018-08-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/state_trackers/vdpau/decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/decode.c b/src/gallium/state_trackers/vdpau/decode.c index 66d52257717..48dfb0e0003 100644 --- a/src/gallium/state_trackers/vdpau/

[Mesa-dev] [PATCH 1/8] mesa: expose ARB_post_depth_coverage in the Compatibility profile

2018-08-20 Thread Marek Olšák
From: Marek Olšák It only contains GLSL changes. v2: allow the layout qualifier on GLSL <= 1.30 --- src/compiler/glsl/glsl_lexer.ll | 1 + src/mesa/main/extensions_table.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/glsl_lexer.ll b/src/compiler/glsl/

Re: [Mesa-dev] [PATCH 5/8] mesa: expose AMD_texture_texture4

2018-08-20 Thread Marek Olšák
On Wed, Aug 15, 2018 at 3:10 PM Ian Romanick wrote: > > On 08/08/2018 07:12 PM, Marek Olšák wrote: > > From: Marek Olšák > > > > because the closed driver exposes it. > > Aside from AMD_texture_texture4 being really, really under-specified, > there is one big difference between the two extensions

Re: [Mesa-dev] [PATCH 2/8] mesa: expose AMD_gpu_shader_int64

2018-08-20 Thread Marek Olšák
On Wed, Aug 15, 2018 at 2:25 PM Ian Romanick wrote: > > On 08/08/2018 07:12 PM, Marek Olšák wrote: > > From: Marek Olšák > > > > because the closed driver exposes it. > > > > It's equivalent to ARB_gpu_shader_int64. > > In this patch, I did everything the same as we do for ARB_gpu_shader_int64. >

[Mesa-dev] [Bug 104843] Mesa version not updated for rebuild

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104843 Timothy Arceri changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Timothy A

[Mesa-dev] [Bug 103385] Cross compilation fails with undefined reference

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103385 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Mesa-dev] [Bug 99014] clover is broken for Oland in 12.0.4

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-20 Thread Ian Romanick
On 08/20/2018 04:02 PM, Marek Olšák wrote: > I wouldn't add _DepthClamp. Having just DepthClampNear and > DepthClampFar should be enough. Drivers not supporting the extension > can use either variable, because they will be equal. > > The glGet query can be handled as LOC_CUSTOM. Yeah, that works

Re: [Mesa-dev] [PATCH] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-20 Thread Timothy Arceri
On 20/08/18 23:31, vadym.shovkoplias wrote: From Section 4.3.4 (Inputs) of the GLSL 1.50 spec: "Only the input variables that are actually read need to be written by the previous stage; it is allowed to have superfluous declarations of input variables." Fixes: * interstag

[Mesa-dev] [Bug 107224] Incorrect Rendering in Deus Ex: Mankind Divided in-game menu

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107224 --- Comment #11 from Timothy Arceri --- (In reply to Alex Smith from comment #10) > We've just released a game data update that should fix this issue for both > AMD and Intel, as well as a shader compilation failure on 18.2. It should be > appli

Re: [Mesa-dev] [PATCH 1/3] gallium/auxiliary: Add util_format_get_depth_only() helper.

2018-08-20 Thread Eric Anholt
Kenneth Graunke writes: > This will be used by u_transfer_helper.c shortly, in order to split > packed depth-stencil into separate resources. > --- > src/gallium/auxiliary/util/u_format.h | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u

Re: [Mesa-dev] [PATCH v2 07/11] intel/nir: Use the new structure and array splitting passes

2018-08-20 Thread Caio Marcelo de Oliveira Filho
On Sat, Jul 28, 2018 at 10:44:38PM -0700, Jason Ekstrand wrote: > Shader-db results on Kaby Lake: > > total instructions in shared programs: 15177605 -> 15177605 (0.00%) > instructions in affected programs: 0 -> 0 > helped: 0 > HURT: 0 > > This is unsurprising because nir_lower_va

Re: [Mesa-dev] [PATCH v2.1 6/11] nir: Add an array splitting pass

2018-08-20 Thread Caio Marcelo de Oliveira Filho
On Mon, Jul 30, 2018 at 09:16:42AM -0700, Jason Ekstrand wrote: > This pass looks for array variables where at least one level of the > array is never indirected and splits it into multiple smaller variables. > > This pass doesn't really do much now because nir_lower_vars_to_ssa can > already see

Re: [Mesa-dev] [PATCH 3/3] gallium/u_transfer_helper: Add support for separate Z24/S8 as well.

2018-08-20 Thread Eric Anholt
Kenneth Graunke writes: > u_transfer_helper already had code to handle treating packed Z32_S8 > as separate Z32_FLOAT and S8_UINT resources, since some drivers can't > handle that interleaved format natively. > > Other hardware needs depth and stencil as separate resources for all > formats. For

Re: [Mesa-dev] [PATCH 2/3] gallium/format: Add a helper to combine separate Z24 and S8 stencil.

2018-08-20 Thread Eric Anholt
Kenneth Graunke writes: > This new function takes separate Z24 depth and S8 stencil sources, > and packs them into a single combined Z24S8 buffer. > --- > src/gallium/auxiliary/util/u_format_zs.c | 20 > src/gallium/auxiliary/util/u_format_zs.h | 2 ++ > 2 files changed, 22

Re: [Mesa-dev] [PATCH 05/12] amd/addrlib: mark physicalSliceSize as MAYBE_UNUSED in Addr::V1::EgBasedLib::HwlGetSizeAdjustmentMicroTiled

2018-08-20 Thread Marek Olšák
I've sent comments on patches 3 & 4. With those addressed, patches 1-5 are: Reviewed-by: Marek Olšák On Sat, Aug 18, 2018 at 7:16 AM Kai Wasserbäch wrote: > > Only used, when asserts are enabled. > > Fixes an unused-but-set-variable warning with GCC 8: > ../../../src/amd/addrlib/r800/egbaddrlib

Re: [Mesa-dev] [PATCH 04/12] amd/addrlib: mark numPipes as MAYBE_UNUSED in Addr::V1::EgBasedLib::SanityCheckMacroTiled

2018-08-20 Thread Marek Olšák
On Sat, Aug 18, 2018 at 7:16 AM Kai Wasserbäch wrote: > > Only used, when asserts are enabled. > > Fixes an unused-variable warning with GCC 8: > ../../../src/amd/addrlib/r800/egbaddrlib.cpp: In member function 'int > Addr::V1::EgBasedLib::SanityCheckMacroTiled(ADDR_TILEINFO*) const': > ../../.

Re: [Mesa-dev] [PATCH 03/12] amd/addrlib: mark *pEqToCheck as MAYBE_UNUSED in Addr::V2::Gfx9Lib::ComputeStereoInfo

2018-08-20 Thread Marek Olšák
On Sat, Aug 18, 2018 at 7:16 AM Kai Wasserbäch wrote: > > Only used, when asserts are enabled. > > Fixes an unused-variable warning with GCC 8: > ../../../src/amd/addrlib/gfx9/gfx9addrlib.cpp: In member function > 'ADDR_E_RETURNCODE Addr::V2::Gfx9Lib::ComputeStereoInfo(const > ADDR2_COMPUTE_SUR

Re: [Mesa-dev] [PATCH] radv: drop wrong initialization of COMPUTE_RESOURCE_LIMITS

2018-08-20 Thread Marek Olšák
You are lucky that WAVES_PER_SH was not 3. Such a low limit could decrease compute shader performance to ~2%. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC][PATCH 0/5] mesa: Add types for AMD_depth_clamp_separate.

2018-08-20 Thread Sagar Ghuge
Thank you for volunteering to test my branch. But before I point you to the branch, I will rework patches according to your comment on patch 3. Again thanks a lot for your and Ian's input. - Sagar On 08/20/2018 04:21 PM, Marek Olšák wrote: > I can try to test the extension with the radeonsi

Re: [Mesa-dev] [PATCH] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Aug 20, 2018 at 9:32 AM vadym.shovkoplias wrote: > > From Section 4.3.4 (Inputs) of the GLSL 1.50 spec: > > "Only the input variables that are actually read need to be written > by the previous stage; it is allowed to have superfluous > declar

Re: [Mesa-dev] [PATCH 4/4] amd/addrlib: mark returnCode as MAYBE_UNUSED in ElemGetExportNorm

2018-08-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Aug 17, 2018 at 10:41 AM Kai Wasserbäch wrote: > > Only used, when asserts are enabled. > > Fixes an unused-but-set-variable warning with GCC 8: > ../../../src/amd/addrlib/addrinterface.cpp: In function 'int > ElemGetExportNorm(ADDR_HANDLE, const ELEM_GET

Re: [Mesa-dev] [PATCH 1/4] util: mark s as MAYBE_UNUSED in _mesa_half_to_unorm8

2018-08-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Aug 17, 2018 at 10:41 AM Kai Wasserbäch wrote: > > Only used, when asserts are enabled. > > Fixes an unused-variable warning with gcc-8: > ../../../src/util/half_float.c: In function '_mesa_half_to_unorm8': > ../../../src/util/half_float.c:189:14: warning

Re: [Mesa-dev] [PATCH v2 05/11] nir: Add a structure splitting pass

2018-08-20 Thread Caio Marcelo de Oliveira Filho
On Sat, Jul 28, 2018 at 10:44:36PM -0700, Jason Ekstrand wrote: > This pass doesn't really do much now because nir_lower_vars_to_ssa can > already see through structures and considers them to be "split". This > pass exists to help other passes more easily see through structure > variables. If a b

Re: [Mesa-dev] [PATCH] compiler: add SYSTEM_VALUE_VARYING_COORD

2018-08-20 Thread Rob Clark
On Mon, Aug 20, 2018 at 7:20 PM Marek Olšák wrote: > > On Mon, Aug 20, 2018 at 7:06 PM Rob Clark wrote: > > > > On Mon, Aug 20, 2018 at 6:54 PM Bas Nieuwenhuizen > > wrote: > > > > > > On Tue, Aug 21, 2018 at 12:38 AM, Marek Olšák wrote: > > > > On Fri, Aug 10, 2018 at 9:26 AM Rob Clark wrote:

Re: [Mesa-dev] [RFC][PATCH 0/5] mesa: Add types for AMD_depth_clamp_separate.

2018-08-20 Thread Marek Olšák
I can try to test the extension with the radeonsi driver. Do you have a Mesa branch with the final patches? Marek On Mon, Aug 13, 2018 at 5:35 PM Sagar Ghuge wrote: > > Hi everyone, > > I am kind of stuck on this part actually. I don't have > latest AMD graphics card to test following behavior w

Re: [Mesa-dev] [PATCH] compiler: add SYSTEM_VALUE_VARYING_COORD

2018-08-20 Thread Marek Olšák
On Mon, Aug 20, 2018 at 7:06 PM Rob Clark wrote: > > On Mon, Aug 20, 2018 at 6:54 PM Bas Nieuwenhuizen > wrote: > > > > On Tue, Aug 21, 2018 at 12:38 AM, Marek Olšák wrote: > > > On Fri, Aug 10, 2018 at 9:26 AM Rob Clark wrote: > > >> > > >> Used internally in freedreno/ir3 for the vec2 value t

Re: [Mesa-dev] [PATCH] llvmpipe: add cc clobber to inline asm

2018-08-20 Thread Roland Scheidegger
Am 20.08.2018 um 23:31 schrieb Grazvydas Ignotas: > The bsr instruction modifies flags, so that needs to be indicated to the > compiler. No effect on generated code, but still needed for correctness. > --- > src/gallium/drivers/llvmpipe/lp_setup_tri.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH] compiler: add SYSTEM_VALUE_VARYING_COORD

2018-08-20 Thread Rob Clark
On Mon, Aug 20, 2018 at 6:54 PM Bas Nieuwenhuizen wrote: > > On Tue, Aug 21, 2018 at 12:38 AM, Marek Olšák wrote: > > On Fri, Aug 10, 2018 at 9:26 AM Rob Clark wrote: > >> > >> Used internally in freedreno/ir3 for the vec2 value that hw passes to > >> shader to use as coordinate for bary.f (vary

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-20 Thread Marek Olšák
I wouldn't add _DepthClamp. Having just DepthClampNear and DepthClampFar should be enough. Drivers not supporting the extension can use either variable, because they will be equal. The glGet query can be handled as LOC_CUSTOM. Marek On Sun, Aug 19, 2018 at 6:43 PM Sagar Ghuge wrote: > > > > On

Re: [Mesa-dev] [PATCH] gallium: Split out PIPE_CAP_TEXTURE_MIRROR_CLAMP_TO_EDGE.

2018-08-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Aug 13, 2018 at 1:13 AM Kenneth Graunke wrote: > > Some hardware can do PIPE_TEX_WRAP_MIRROR_REPEAT but not > PIPE_TEX_WRAP_MIRROR_CLAMP and PIPE_TEX_WRAP_MIRROR_CLAMP_TO_BORDER. > > Drivers for such hardware would like to advertise support for > ARB_textur

Re: [Mesa-dev] [PATCH] compiler: add SYSTEM_VALUE_VARYING_COORD

2018-08-20 Thread Bas Nieuwenhuizen
On Tue, Aug 21, 2018 at 12:38 AM, Marek Olšák wrote: > On Fri, Aug 10, 2018 at 9:26 AM Rob Clark wrote: >> >> Used internally in freedreno/ir3 for the vec2 value that hw passes to >> shader to use as coordinate for bary.f (varying fetch) instruction. >> This is not the same as SYSTEM_VALUE_FRAG_C

Re: [Mesa-dev] [PATCH] i965: Advertise 8 bits subpixel precision for viewport bounds on gen6+

2018-08-20 Thread Andres Gomez
Danylo, should we also include this in the stable queues ? On Mon, 2018-06-18 at 15:50 +0300, Danylo Piliaiev wrote: > We use floating-points for viewport bounds so VIEWPORT_SUBPIXEL_BITS > should reflect this. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105975 > > Signed-off-by:

Re: [Mesa-dev] [PATCH 02/13] glsl: Add built-in functions for NV_shader_atomic_float

2018-08-20 Thread Caio Marcelo de Oliveira Filho
> > Question: why some builtins care about "supported" while other care > > about the extension being "enabled"? > > There are actually two different things happening. In the cases where > we only care about the extension being supported, we're creating a > hidden intrinsic function. These are u

Re: [Mesa-dev] [PATCH] compiler: add SYSTEM_VALUE_VARYING_COORD

2018-08-20 Thread Marek Olšák
On Fri, Aug 10, 2018 at 9:26 AM Rob Clark wrote: > > Used internally in freedreno/ir3 for the vec2 value that hw passes to > shader to use as coordinate for bary.f (varying fetch) instruction. > This is not the same as SYSTEM_VALUE_FRAG_COORD. > > Signed-off-by: Rob Clark > --- > Up until now, we

Re: [Mesa-dev] [PATCH 02/13] glsl: Add built-in functions for NV_shader_atomic_float

2018-08-20 Thread Ian Romanick
On 08/20/2018 12:10 PM, Caio Marcelo de Oliveira Filho wrote: > Hi, > >> @@ -1133,6 +1159,9 @@ builtin_builder::create_intrinsics() >> _atomic_intrinsic2(buffer_atomics_supported, >> glsl_type::int_type, >> ir

[Mesa-dev] [PATCH v2] intel/tools: new i965_disasm tool

2018-08-20 Thread Sagar Ghuge
Adds a new i965 instruction disassemble tool v2: 1) fix a few nits (Matt Turner) 2) Remove i965_disasm header (Matt Turner) Signed-off-by: Sagar Ghuge --- src/intel/Makefile.tools.am | 14 +++ src/intel/tools/i965_disasm.c | 199 ++ src/intel/tools/meson.b

Re: [Mesa-dev] [PATCH 1/2] radv: place pointer length into cache uuid

2018-08-20 Thread Bas Nieuwenhuizen
On Mon, Aug 20, 2018 at 11:32 PM, Grazvydas Ignotas wrote: > Thanks to reproducible builds, binary file timestamps may be identical > for both 32bit and 64bit packages when built from the same source. > This means radv will use the same cache for both 32 and 64 bit > processes, which leads to cras

Re: [Mesa-dev] [PATCH 2/2] radv: use different builtin shader cache for 32bit

2018-08-20 Thread Bas Nieuwenhuizen
On Mon, Aug 20, 2018 at 11:32 PM, Grazvydas Ignotas wrote: > Currently if 64bit and 32bit programs are used interchangeably, radv > will keep overwriting the cache. Use separate cache files to avoid > that. I probably should also split this out per GPU for people who have different GPUs ... For

Re: [Mesa-dev] [PATCH] vulkan/wsi: fix pointer-integer conversion warnings

2018-08-20 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen Did you have access to push? On Mon, Aug 20, 2018 at 11:40 PM, Grazvydas Ignotas wrote: > For 32bit build. Trivial. > --- > src/vulkan/wsi/wsi_common_display.c | 4 ++-- > src/vulkan/wsi/wsi_common_x11.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions

Re: [Mesa-dev] [PATCH] gallivm: Detect VSX separately from Altivec

2018-08-20 Thread Roland Scheidegger
Alright, I guess it's ok then. In theory the u_cpu_detect bits could be used in different places, for instance the translate code emits its own sse code, and as long as a feature was detected properly it may make sense to disable it only for some users. Albeit llvm setup and the gallivm code need t

Re: [Mesa-dev] [PATCH] intel/tools: new i965_disasm tool

2018-08-20 Thread Sagar Ghuge
Thanks for reviewing the patch. I will make changes and send v2 accordingly. On 08/20/2018 11:34 AM, Matt Turner wrote: > On Thu, Aug 16, 2018 at 1:51 PM Sagar Ghuge wrote: >> >> Adds a new i965 instruction disassemble tool > > This looks very good. A few comments about the structure inline. >

[Mesa-dev] [PATCH] vulkan/wsi: fix pointer-integer conversion warnings

2018-08-20 Thread Grazvydas Ignotas
For 32bit build. Trivial. --- src/vulkan/wsi/wsi_common_display.c | 4 ++-- src/vulkan/wsi/wsi_common_x11.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index e6cba188dfa..1e90bba460c 100644 --

[Mesa-dev] [PATCH 2/2] radv: use different builtin shader cache for 32bit

2018-08-20 Thread Grazvydas Ignotas
Currently if 64bit and 32bit programs are used interchangeably, radv will keep overwriting the cache. Use separate cache files to avoid that. --- src/amd/vulkan/radv_meta.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/amd/vulkan/radv_meta.c b/src/amd/vul

[Mesa-dev] [PATCH 1/2] radv: place pointer length into cache uuid

2018-08-20 Thread Grazvydas Ignotas
Thanks to reproducible builds, binary file timestamps may be identical for both 32bit and 64bit packages when built from the same source. This means radv will use the same cache for both 32 and 64 bit processes, which leads to crashes. Conveniently there is a spare byte in cache_uuid, let's place

[Mesa-dev] [PATCH] llvmpipe: add cc clobber to inline asm

2018-08-20 Thread Grazvydas Ignotas
The bsr instruction modifies flags, so that needs to be indicated to the compiler. No effect on generated code, but still needed for correctness. --- src/gallium/drivers/llvmpipe/lp_setup_tri.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/llvmpipe/lp_se

Re: [Mesa-dev] [PATCH] i965/icl: Allow headerless sampler messages for pre-emptable contexts

2018-08-20 Thread Kenneth Graunke
On Monday, August 20, 2018 10:26:29 AM PDT Anuj Phogat wrote: > On Mon, Aug 20, 2018 at 12:18 AM Kenneth Graunke wrote: [snip] > > I don't know if people are trying to enable pre-emption during GPGPU > > work on pre-Gen11. If so, that probably will not work, and we'd either > > need to avoid heade

[Mesa-dev] [PATCH v3 2/3] i965/miptree: Fix can_blit_slice()

2018-08-20 Thread Nanley Chery
Check the destination's row pitch against the BLT engine's row pitch limitation as well. Fixes: 0288fe8d0417730bdd5b3477130dd1dc32bdbcd3 ("i965/miptree: Use the correct BLT pitch") v2: Fix the Fixes tag (Dylan). Check the destination row pitch (Chris). Cc: Reported-by: Dylan Baker --- I d

[Mesa-dev] [PATCH v3 3/3] intel/isl: Avoid tiling some 16K-wide render targets

2018-08-20 Thread Nanley Chery
Fix rendering issues on BDW and SKL. Fixes: 0288fe8d0417730bdd5b3477130dd1dc32bdbcd3 ("i965/miptree: Use the correct BLT pitch") Fixes the following regressions seen exclusively on SKL: * KHR-GL46.texture_barrier_ARB.disjoint-texels * KHR-GL46.texture_barrier_ARB.overlapping-texels * KHR-GL46.te

[Mesa-dev] [PATCH v3 1/3] i965/miptree: Use miptree_map in map_blit functions

2018-08-20 Thread Nanley Chery
This struct contains all the data of interest. can_blit_slice() will use it in the next patch to calculate the correct pitch. Suggested-by: Chris Wilson Cc: --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/m

Re: [Mesa-dev] [PATCH] intel/eu: print bytes instead of 32 bit hex value

2018-08-20 Thread Sagar Ghuge
On 08/20/2018 11:06 AM, Matt Turner wrote: > Cool. This looks pretty good to me. A few comments inline. > > On Wed, Aug 15, 2018 at 2:00 PM Sagar Ghuge wrote: >> >> INTEL_DEBUG=hex prints 32 bit hex value >> and due to endianness of CPU byte order is >> reversed. In order to disassemble binary

Re: [Mesa-dev] [PATCH 00/13] Implement INTEL_shader_atomic_float_minmax

2018-08-20 Thread Caio Marcelo de Oliveira Filho
> The code is here: > > > https://cgit.freedesktop.org/~idr/mesa/log/?h=INTEL_shader_atomic_float_minmax The series is Reviewed-by: Caio Marcelo de Oliveira Filho I'd consider adding some clarification about not quietizing sNaN and/or relaxing the definition in the spec (patch 3). > a

Re: [Mesa-dev] [PATCH] autotools: include git_sha1.h in dist tarball

2018-08-20 Thread Eric Engestrom
On Monday, 2018-08-20 14:23:28 +, Juan A. Suarez Romero wrote: > This fixes `make distcheck`. > > Fixes: 471f708ed6 ("git_sha1: simplify logic") > CC: Eric Engestrom > --- > src/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/Makefile.am b/src/Makefi

[Mesa-dev] [PATCH v2] intel/eu: print bytes instead of 32 bit hex value

2018-08-20 Thread Sagar Ghuge
INTEL_DEBUG=hex prints 32 bit hex value and due to endianness of CPU byte order is reversed. In order to disassemble binary files, print each byte instead of 32 bit hex value. v2: Print blank spaces in order to vertically align output of compacted instructions hex value with uncompacted instru

[Mesa-dev] [Bug 107629] [regression][bisected] Build fails with nir_load_sample_id_no_per_sample being undefined

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107629 Hi-Angel changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

Re: [Mesa-dev] [PATCH] gallivm: Detect VSX separately from Altivec

2018-08-20 Thread Vicki Pfau
I was mostly following what was done earlier in the file for Altivec. I can move it but then ideally the Alitvec check should also be moved. Vicki On 08/20/2018 08:53 AM, Roland Scheidegger wrote: u_cpu_detect should detect what's really available, not what is used (though indeed we actually

[Mesa-dev] [Bug 107629] [regression][bisected] Build fails with nir_load_sample_id_no_per_sample being undefined

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107629 --- Comment #1 from Rob Clark --- this seems like you are somehow ending up with old versions of some of the generated headers? At one point, nir_intrinsics.h was not autogenerated.. maybe you have an old copy of it lying around? Do you get th

Re: [Mesa-dev] [PATCH 02/13] glsl: Add built-in functions for NV_shader_atomic_float

2018-08-20 Thread Caio Marcelo de Oliveira Filho
Hi, > @@ -1133,6 +1159,9 @@ builtin_builder::create_intrinsics() > _atomic_intrinsic2(buffer_atomics_supported, > glsl_type::int_type, > ir_intrinsic_generic_atomic_add), > +_atomic_intrinsic2(

[Mesa-dev] [Bug 107629] [regression][bisected] Build fails with nir_load_sample_id_no_per_sample being undefined

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107629 Hi-Angel changed: What|Removed |Added CC||robcl...@freedesktop.org -- You are receivi

Re: [Mesa-dev] [PATCH v2 00/11] nir: Add some optimizations on variables

2018-08-20 Thread Jason Ekstrand
ping On Sun, Jul 29, 2018 at 12:44 AM Jason Ekstrand wrote: > This is the second version of my optimization series for variables. The > first version, including the very descriptive cover letter can be found > here: > > https://patchwork.freedesktop.org/series/47295/ > > This second version con

[Mesa-dev] [Bug 107629] [regression][bisected] Build fails with nir_load_sample_id_no_per_sample being undefined

2018-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107629 Bug ID: 107629 Summary: [regression][bisected] Build fails with nir_load_sample_id_no_per_sample being undefined Product: Mesa Version: git Hardware: Other

Re: [Mesa-dev] [PATCH 06/22] nir/format_convert: Add vec mask and sign-extend helpers

2018-08-20 Thread Jason Ekstrand
On Mon, Aug 20, 2018 at 2:42 AM Kenneth Graunke wrote: > On Friday, August 17, 2018 1:06:12 PM PDT Jason Ekstrand wrote: > > --- > > src/compiler/nir/nir_format_convert.h | 35 +-- > > 1 file changed, 27 insertions(+), 8 deletions(-) > > > > diff --git a/src/compiler/nir/

Re: [Mesa-dev] [PATCH 09/13] nir: Add floating point atomic min, max, and compare-swap instrinsics

2018-08-20 Thread Ian Romanick
On 08/17/2018 05:06 PM, Caio Marcelo de Oliveira Filho wrote: > On Fri, Jun 22, 2018 at 10:03:54PM -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> src/compiler/glsl/glsl_to_nir.cpp| 32 >> ++-- >> src/compiler/nir/

Re: [Mesa-dev] [PATCH 03/13] docs: Initial version of INTEL_shader_atomic_float_minmax spec

2018-08-20 Thread Ian Romanick
On 08/16/2018 06:02 PM, Caio Marcelo de Oliveira Filho wrote: > Hello, > >> +(add a new row after the exiting "atomicMax" table row, p. 179) >> + >> +float atomicMax(inout float mem, float data) >> + >> +Computes a new value by taking the maximum of the value of data and >> +

Re: [Mesa-dev] [PATCH] intel/tools: new i965_disasm tool

2018-08-20 Thread Matt Turner
On Thu, Aug 16, 2018 at 1:51 PM Sagar Ghuge wrote: > > Adds a new i965 instruction disassemble tool This looks very good. A few comments about the structure inline. > Signed-off-by: Sagar Ghuge > --- > src/intel/Makefile.tools.am | 15 +++ > src/intel/tools/i965_disasm.c | 202 +

Re: [Mesa-dev] [PATCH v3] intel/decoder: fix the possible out of bounds group_iter

2018-08-20 Thread Lionel Landwerlin
On 20/08/2018 17:20, asimiklit.w...@gmail.com wrote: From: Andrii Simiklit The "gen_group_get_length" function can return a negative value and it can lead to the out of bounds group_iter. v2: printing of "unknown command type" was added v3: just the asserts are added Signed-off-by: Andrii Sim

Re: [Mesa-dev] [PATCH v4] anv: add VK_EXT_sampler_filter_minmax support

2018-08-20 Thread Lionel Landwerlin
On 20/08/2018 17:29, Yunchao He wrote: This extension can be supported on SKL+. With this patch, all corresponding tests (6K+) in CTS can pass. No test fails. I verified CTS with the command below: deqp-vk --deqp-case=dEQP-VK.pipeline.sampler.view_type.*reduce* v2: 1) support all depth formats,

Re: [Mesa-dev] [PATCH] intel/eu: print bytes instead of 32 bit hex value

2018-08-20 Thread Matt Turner
Cool. This looks pretty good to me. A few comments inline. On Wed, Aug 15, 2018 at 2:00 PM Sagar Ghuge wrote: > > INTEL_DEBUG=hex prints 32 bit hex value > and due to endianness of CPU byte order is > reversed. In order to disassemble binary > files, print each byte instead of 32 bit hex > value.

[Mesa-dev] [PATCH v4] anv: add VK_EXT_sampler_filter_minmax support

2018-08-20 Thread Yunchao He
This extension can be supported on SKL+. With this patch, all corresponding tests (6K+) in CTS can pass. No test fails. I verified CTS with the command below: deqp-vk --deqp-case=dEQP-VK.pipeline.sampler.view_type.*reduce* v2: 1) support all depth formats, not depth-only formats, 2) fix a wrong i

Re: [Mesa-dev] [PATCH] i965/icl: Allow headerless sampler messages for pre-emptable contexts

2018-08-20 Thread Anuj Phogat
On Mon, Aug 20, 2018 at 12:18 AM Kenneth Graunke wrote: > > On Friday, August 17, 2018 5:13:25 PM PDT Anuj Phogat wrote: > > It fixes simulator warnings in piglit tests complaining about missing > > support for headerless sampler messages for pre-emptable contexts. > > Bit 5 in SAMPLER MODE regist

Re: [Mesa-dev] [PATCH] travis: make drivers explicit in Meson targets

2018-08-20 Thread Emil Velikov
On 20 August 2018 at 15:47, Juan A. Suarez Romero wrote: > On Mon, 2018-08-20 at 12:06 +0200, Juan A. Suarez Romero wrote: >> On Tue, 2018-08-14 at 11:00 +0100, Emil Velikov wrote: >> > On 8 August 2018 at 15:36, Juan A. Suarez Romero >> > wrote: >> > > Like in the autotools target, make the lis

Re: [Mesa-dev] [PATCH] appveyor: Set git core.autocrlf setting to true.

2018-08-20 Thread Roland Scheidegger
Looks good to me. Reviewed-by: Roland Scheidegger Am 20.08.2018 um 13:21 schrieb Jose Fonseca: > The git core.autocrlf setting defaults to true (ie, all text files get > checked out as CRLF on Windows), except on Appveyor where's set to > "input" (ie, all text files get checked out with the upstr

[Mesa-dev] [PATCH v3] intel/decoder: fix the possible out of bounds group_iter

2018-08-20 Thread asimiklit . work
From: Andrii Simiklit The "gen_group_get_length" function can return a negative value and it can lead to the out of bounds group_iter. v2: printing of "unknown command type" was added v3: just the asserts are added Signed-off-by: Andrii Simiklit --- src/intel/common/gen_decoder.c | 5 - 1

  1   2   >