[Mesa-dev] [PATCH] radv: Use build ID if available for cache UUID.

2018-09-16 Thread Bas Nieuwenhuizen
To get an useful UUID for systems that have a non-useful mtime for the binaries. I started using using SHA1 to ensure we get reasonable mixing in the various possibilities and the various build id lengths. CC: --- src/amd/vulkan/radv_device.c | 43 +--- 1 file ch

Re: [Mesa-dev] [PATCH] radv: Optimize rebinding the same descriptor set.

2018-09-16 Thread Samuel Pitoiset
On 9/16/18 2:21 AM, Bas Nieuwenhuizen wrote: Thsi makes it cheaper to just change the dynamic offsets with typo: This Sounds reasonable. Reviewed-by: Samuel Pitoiset the same descriptor sets. Suggested-by: Philip Rebohle --- src/amd/vulkan/radv_cmd_buffer.c | 8 +++- 1 file chan

[Mesa-dev] [PATCH 1/2] radv: Set the user SGPR MSB for Vega.

2018-09-16 Thread Bas Nieuwenhuizen
Otherwise using 32 user SGPRs would be broken. CC: --- src/amd/vulkan/radv_shader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index e05961339ca..51e0b7d65fc 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_s

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

2018-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106187 --- Comment #13 from gloriouseggr...@gmail.com --- Hi, I've run into this issue with DOOM 2016 recently: so I have a ryzen 2400g and an rx 580 in this system both vulkan capable for whatever reason, doom renders on my vega in my 2400g and outpu

[Mesa-dev] [PATCH 2/2] radv: Only allow 16 user SGPRs for compute on GFX9+.

2018-09-16 Thread Bas Nieuwenhuizen
Apparently for compute there are only 16 instead of the 32 for the graphics path. Fixes dEQP-VK.binding_model.descriptorset_random.sets16.noarray.ubolimitlow.sbolimitlow.imglimitlow.noiub.comp.0 CC: --- src/amd/vulkan/radv_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Mesa-dev] [Bug 107954] radv_shader_compile_to_nir doesn't check for bad entry point

2018-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107954 Bug ID: 107954 Summary: radv_shader_compile_to_nir doesn't check for bad entry point Product: Mesa Version: unspecified Hardware: Other OS: All

Re: [Mesa-dev] [PATCH 2/2] anv: add support for VK_EXT_inline_uniform_block

2018-09-16 Thread Lionel Landwerlin
Hey Tapani, Descriptors were kind of tricky to get my head around so thanks a lot for looking into this. Regarding this max values, there isn't really a limit with our hardware. I just picked the minimum required by the spec. I think the assert are somewhat unnecessary but I don't really obje

Re: [Mesa-dev] [PATCH 2/5] anv/query: Write both dwords in emit_zero_queries

2018-09-16 Thread Lionel Landwerlin
I did wonder about using a PIPE_CONTROL with WriteImmediate, but there is a workaround in gpgpu mode so not really worth it... On 15/09/2018 04:14, Jason Ekstrand wrote: Each query slot is a uint64_t and we were only zeroing half of it. Fixes: 7ec6e4e68980 "anv/query: implement multiview inter

Re: [Mesa-dev] [PATCH 1/5] anv/query: Increment an index while writing results

2018-09-16 Thread Lionel Landwerlin
This series looks great to me. Thanks for the helpers everywhere :) Reviewed-by: Lionel Landwerlin On 15/09/2018 04:14, Jason Ekstrand wrote: Instead of computing an index at the end which we hope maps to the number of things written, just count the number of things as we go. --- src/intel/v

Re: [Mesa-dev] [PATCH 2/2] anv: add support for VK_EXT_inline_uniform_block

2018-09-16 Thread Bas Nieuwenhuizen
On Tue, Sep 11, 2018 at 10:23 PM Lionel Landwerlin wrote: > > This new extension adds an implicitly allocated block of uniforms into > the descriptors sets through a new descriptor type. > > We implement this by having a single BO in the descriptor set pool > from which we source uniforms. > > Sig

[Mesa-dev] [Bug 107777] No 3D in "Vampire: The Masquerade - Bloodlines" when d3d-nine enabled

2018-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=10 --- Comment #8 from Axel Davy --- I have implemented a missing feature to resize when rendering area and window size are of different size, which may fix your 'crop' behaviour. The patch is currently on our current work-in-progress git: https://

Re: [Mesa-dev] [PATCH 2/2] anv: add support for VK_EXT_inline_uniform_block

2018-09-16 Thread Lionel Landwerlin
On 16/09/2018 21:57, Bas Nieuwenhuizen wrote: On Tue, Sep 11, 2018 at 10:23 PM Lionel Landwerlin wrote: This new extension adds an implicitly allocated block of uniforms into the descriptors sets through a new descriptor type. We implement this by having a single BO in the descriptor set pool

Re: [Mesa-dev] [PATCH] radv: Use build ID if available for cache UUID.

2018-09-16 Thread Timothy Arceri
On 16/9/18 10:58 am, Bas Nieuwenhuizen wrote: To get an useful UUID for systems that have a non-useful mtime for the binaries. I started using using SHA1 to ensure we get reasonable mixing using using - > using So did this return a build id for LLVM on your distro? Reviewed-by: Timothy Arcer

[Mesa-dev] [Bug 107765] [regression] Batman Arkham City crashes with DXVK under wine

2018-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107765 Timothy Arceri changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Timothy Arceri

Re: [Mesa-dev] [PATCH] radv: Use build ID if available for cache UUID.

2018-09-16 Thread Bas Nieuwenhuizen
On Mon, Sep 17, 2018 at 2:10 AM Timothy Arceri wrote: > > On 16/9/18 10:58 am, Bas Nieuwenhuizen wrote: > > To get an useful UUID for systems that have a non-useful mtime > > for the binaries. > > > > I started using using SHA1 to ensure we get reasonable mixing > > using using - > using Fixed lo

Re: [Mesa-dev] [PATCH 2/4] i965/tiled_memcpy: inline movntdqa loads in tiled_to_linear

2018-09-16 Thread Tapani Pälli
On 09/13/2018 06:52 PM, Dylan Baker wrote: Quoting D Scott Phillips (2018-09-13 08:28:29) Tapani Pälli writes: From: D Scott Phillips The reference for MOVNTDQA says: For WC memory type, the nontemporal hint may be implemented by loading a temporary internal buffer with the equiv

[Mesa-dev] [Bug 107942] Isaac AntiBirth under wine has invisible entities tu to clipping plane issue

2018-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107942 --- Comment #1 from Timothy Arceri --- This is a game bug. Compilation of this (and other) shaders are failing because the game is using features of later glsl versions but its not setting the required version in the shader. When the version is

Re: [Mesa-dev] [PATCH 2/2 (resend)] virgl: Pass resource size and transfer offsets

2018-09-16 Thread Tomeu Vizoso
On 09/14/2018 04:42 PM, Gert Wollny wrote: Am Freitag, den 14.09.2018, 15:26 +0300 schrieb andrey simiklit: [...] + if (vcmd == VCMD_TRANSFER_PUT2) + vtest_hdr[VTEST_CMD_LEN] += data_size + 3 / 4; Looks like a copy/paste mistake) I suppose that it is should be like: ... = (data_size + 3