[Mesa-dev] [Bug 108062] Mesa 18.2.0 and Mesa 18.2.1 RADV Freeze

https://bugs.freedesktop.org/show_bug.cgi?id=108062 Andreas Radke changed: What|Removed |Added CC||andy...@archlinux.org -- You are recei

Re: [Mesa-dev] [PATCH] mesa/st: In the precense of integer buffers enable per buffer blending

Am Dienstag, den 25.09.2018, 10:20 -0400 schrieb Ilia Mirkin: > I haven't double-checked yet, but doesn't this result in a reduction > of functionality for pre-independent-blend GPUs (like the early > NVIDIA > Tesla series)? Configuring blending for an integer RT does nothing on > NVIDIA hardware,

Re: [Mesa-dev] [PATCH 3/8] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

On Mon, Aug 27, 2018 at 2:22 AM Jason Ekstrand wrote: > On Sun, Aug 26, 2018 at 11:54 PM Tapani Pälli > wrote: > >> >> >> On 08/24/2018 05:04 PM, Jason Ekstrand wrote: >> > On Fri, Aug 24, 2018 at 12:08 AM Tapani Pälli > > > wrote: >> > >> > >> > >> > On 08/22/

Re: [Mesa-dev] [PATCH] radv: Do not use multiple draws for multisample copies.

Reviewed-by: Samuel Pitoiset On 9/26/18 8:32 AM, Bas Nieuwenhuizen wrote: Use sample rate shading instead, should give better locality. --- src/amd/vulkan/radv_meta_blit2d.c | 62 +++ 1 file changed, 5 insertions(+), 57 deletions(-) diff --git a/src/amd/vulkan/ra

Re: [Mesa-dev] [PATCH] vl: reorder H264 profiles

Am 26.09.2018 um 00:11 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang Fix the wrong h264 profiles order. Previously, the constrained baseline was added in between baseline and main profiles, which breaked the logic in radeon/vce when converting from pipe_video_profile to profile_idc I think

[Mesa-dev] [PATCH] radv: adjust the CmdUpdateBuffer threshold for optimal performance

According to my benchmark results, it appears that we should reduce the threshold to 1024. BEFORE: 1 KB: 68.656000 ms 2 KB: 118.368000 ms AFTER: 1 KB: 31.76 ms 2 KB: 29.84 ms Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_buffer.c | 2 +- src/amd/vulkan/radv_private.h

[Mesa-dev] [PATCH] radv: do not sync CP DMA when copying buffers

We already track if the DMA engine is busy/idle with a flag, and we emit a packet that waits for all CP DMA operations to be complete. This is done at end of command buffer because the kernel doesn't wait for them, and also when emitting barriers, so it should be safe. This improves small copies f

Re: [Mesa-dev] [PATCH 2/2] anv: If softpin is supported, use it with the hiz clear value bo

Reviewed-by: Jason Ekstrand On Tue, Sep 25, 2018 at 6:27 PM Jordan Justen wrote: > Signed-off-by: Jordan Justen > Cc: Nanley Chery > Cc: Jason Ekstrand > --- > src/intel/vulkan/anv_device.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/intel/vulkan/anv_device.c b/src

Re: [Mesa-dev] [PATCH v2 1/4] util: Get program name based on path when possible

On 09/25/2018 06:01 PM, Emil Velikov wrote: On 24 September 2018 at 19:18, Nicholas Kazlauskas wrote: Some programs start with the path and command line arguments in argv[0] (program_invocation_name). Chromium is an example of an application using mesa that does this. This tries to query the r

Re: [Mesa-dev] [PATCH 3/8] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

On 9/26/18 10:46 AM, Jason Ekstrand wrote: On Mon, Aug 27, 2018 at 2:22 AM Jason Ekstrand > wrote: On Sun, Aug 26, 2018 at 11:54 PM Tapani Pälli mailto:tapani.pa...@intel.com>> wrote: On 08/24/2018 05:04 PM, Jason Ekstrand wrote: > On Fr

Re: [Mesa-dev] [PATCH 3/8] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

On Wed, Sep 26, 2018 at 8:29 AM Tapani Pälli wrote: > > > On 9/26/18 10:46 AM, Jason Ekstrand wrote: > > On Mon, Aug 27, 2018 at 2:22 AM Jason Ekstrand > > wrote: > > > > On Sun, Aug 26, 2018 at 11:54 PM Tapani Pälli > > mailto:tapani.pa...@intel.com>> wrote:

Re: [Mesa-dev] [PATCH 3/8] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

On 9/26/18 4:46 PM, Jason Ekstrand wrote: On Wed, Sep 26, 2018 at 8:29 AM Tapani Pälli > wrote: On 9/26/18 10:46 AM, Jason Ekstrand wrote: > On Mon, Aug 27, 2018 at 2:22 AM Jason Ekstrand mailto:ja...@jlekstrand.net> >

[Mesa-dev] [PATCH] radeon/vce: use switch to convert profile idc

From: Boyuan Zhang The previous array logic for converting pipe video profile to profile idc relies on the order of pipe_video_profile enum defines. Adding new profile to enum defines may break the logic. Therefore, it's better to use switch helper function to acheive the same goal. Signed-off-b

Re: [Mesa-dev] [PATCH] vl: reorder H264 profiles

Yes, I was thinking either using a switch helper function or doing this 1 line change since there will be no more profile to be added. But no problem, I agree that using switch helper function is a safer way. New patch just sent. Regards, Boyuan -Original Message- From: Christian Köni

Re: [Mesa-dev] [PATCH 1/2] anv: s/batch/value_bo/ on anv_device_init_hiz_clear_batch

On Tue, Sep 25, 2018 at 04:26:57PM -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > Cc: Jason Ekstrand > --- > src/intel/vulkan/anv_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > This series is Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/anv_

[Mesa-dev] [PATCH mesa 1/6] vulkan/wsi/display: setup the connector earlier

Instead of setting it up when the swapchain is presented, set it up when creating the swapchain. This means that multiple swapchains might use the same crtc, but only one can be active at a time, and the connectors are now refcounted. This is necessary for the next commit. Signed-off-by: Eric Eng

[Mesa-dev] [PATCH mesa 4/6] vulkan/wsi/display: add comment

Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index 2a30b1139f06cbb56769..c24b58e8c240f43ac512 100644 --- a/src/vulkan/wsi/wsi_com

[Mesa-dev] [PATCH mesa 2/6] vulkan/wsi/display: also select a plane when selecting a crtc

Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 80 + 1 file changed, 80 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index 2d378afe3d36fe7cc177..6c9160a445c8f25a8ad5 100644 --- a/src/vul

[Mesa-dev] [PATCH mesa 5/6] vulkan/wsi/display: pass image's DRM modifiers to the kernel

Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index c24b58e8c240f43ac512..0b71932bfa0939039ae3 100644 --- a/src

[Mesa-dev] [PATCH mesa 3/6] vulkan/wsi/display: pass the plane's modifiers to the image

Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 95 - 1 file changed, 94 insertions(+), 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index 6c9160a445c8f25a8ad5..2a30b1139f06cbb56769 10064

[Mesa-dev] [PATCH mesa 6/6] fixup! vulkan/wsi/display: pass DRM modifiers to the kernel

(split out for review) --- src/vulkan/wsi/wsi_common_display.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c index 0b71932bfa0939039ae3..1518a1736e424319ab69 100644 --- a/src/vulkan/

Re: [Mesa-dev] [PATCH mesa 5/6] vulkan/wsi/display: pass image's DRM modifiers to the kernel

I have a feeling this should go before patch 3 On September 26, 2018 17:38:24 Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_display.c

Re: [Mesa-dev] [PATCH 1/5] util: import public domain code for integer division by a constant

On Tue, Sep 25, 2018 at 5:33 AM Jason Ekstrand wrote: > > On Mon, Sep 24, 2018 at 7:15 PM Marek Olšák wrote: >> >> This patch also handles all types, just differently. If you change the >> typedefs in the header, you'll get a different type and the code is >> exactly the same for all types, but t

Re: [Mesa-dev] [PATCH mesa 1/6] vulkan/wsi/display: setup the connector earlier

Eric Engestrom writes: > Instead of setting it up when the swapchain is presented, set it up when > creating the swapchain. This means that multiple swapchains might use > the same crtc, but only one can be active at a time, and the connectors > are now refcounted. > > This is necessary for the n

[Mesa-dev] [PATCH 5/9] intel/blorp_blit: Add blorp_copy_astc_wa

Add a function which copies blocks from one ASTC surface to another, patching them up as necessary. --- src/intel/blorp/blorp.h | 6 ++ src/intel/blorp/blorp_blit.c | 153 +++ src/intel/blorp/blorp_priv.h | 1 + 3 files changed, 160 insertions(+) diff --gi

[Mesa-dev] [PATCH 0/9] i965: Re-implement the gen9 void-extent ASTC WA with BLORP

The current workaround has two issues. It causes significant slow-downs [1] in application startup times and uses the modified ASTC blocks for non-sampling operations. This can result in incorrect texture downloads. This series addresses the latter issue by keeping two copies of an ASTC miptree: o

[Mesa-dev] [PATCH 1/9] i965: Rename intel_mipmap_tree::r8stencil_* -> ::shadow_*

Use more generic field names. We'll reuse these fields for a workaround with ASTC miptrees. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 8 src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 16 src/mesa/drivers/dri/i965/intel_mipmap_tree.h| 14 +++-

[Mesa-dev] [PATCH 2/9] i965/miptree: Allocate a shadow_mt for an ASTC WA

shadow_mt will hold a miptree with ASTC LDR void extent blocks that are modified to workaround a sampler bug. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 25 +++ src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 1 + 2 files changed, 26 insertions(+) diff --git a/src/mesa/d

[Mesa-dev] [PATCH 4/9] intel/blorp_blit: Fix ptr deref in convert_to_uncompressed

Don't access the pointers x and y if they're NULL. Nothing hits this path currently. --- src/intel/blorp/blorp_blit.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index ae3e3c50930..7c4e569e44c 100644 --- a/src/

[Mesa-dev] [PATCH 7/9] i965: Do a WA blit between ASTC main and shadow

Perform a workaround blit prior to sampling from the ASTC miptree. --- src/mesa/drivers/dri/i965/brw_blorp.c | 20 src/mesa/drivers/dri/i965/brw_blorp.h | 6 ++ src/mesa/drivers/dri/i965/brw_draw.c | 16 3 files changed, 42 insertions(+) diff --git a/sr

[Mesa-dev] [PATCH 6/9] i965/blorp: Drop tmp_surfs from surf_for_miptree

We've been using intel_mipmap_tree::surf instead. The tmp_surfs param hasn't been used since commit: bf24c3539e4b6989512968cae12da2f88d2c53e9 ("i965/miptree: Clean-up unused"). --- src/mesa/drivers/dri/i965/brw_blorp.c | 36 +-- 1 file changed, 12 insertions(+), 24 deletion

[Mesa-dev] [PATCH 3/9] i965/miptree: Track the staleness of the ASTC shadow

Track whether or not the ASTC shadow miptree will need to be updated prior to sampling. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 - src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 6 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/in

[Mesa-dev] [PATCH 9/9] i965/tex_image: Drop intelCompressedTexSubImage

Effectively revert 710b1d2e665ed654fb8d52b146fa22469e1dc3a7. This function was created to perform the ASTC void-extent workaround. Now that the workaround is handled prior to sampling, this function is no longer necessary. --- src/mesa/drivers/dri/i965/intel_tex_image.c | 87 -

Re: [Mesa-dev] [PATCH mesa 2/6] vulkan/wsi/display: also select a plane when selecting a crtc

Eric Engestrom writes: > + /* if there's a plane is active on the connector's crtc, pick it */ > + for (size_t i = 0; i < plane_res->count_planes; i++) { > + drmModePlane *plane = drmModeGetPlane(wsi->fd, plane_res->planes[i]); > + if (!plane) > + continue; I think you can

[Mesa-dev] [PATCH 8/9] i965/surface_state: Use the ASTC shadow_mt if present

When sampling from an ASTC texture in a shader, make sure to use the miptree which has had the gen9 void-extent workaround applied to it. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/

Re: [Mesa-dev] [PATCH mesa 3/6] vulkan/wsi/display: pass the plane's modifiers to the image

Eric Engestrom writes: > Signed-off-by: Eric Engestrom (I'll have to let someone familiar with the formats and modifiers stuff review this one; I'm not comfortable with that at all). -- -keith signature.asc Description: PGP signature ___ mesa-dev

Re: [Mesa-dev] [PATCH mesa 4/6] vulkan/wsi/display: add comment

Eric Engestrom writes: > - struct list_head connectors; > + struct list_head connectors; /* list of all discovered > connectors */ Yeah, definitely not the list of all connectors. Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature ___

[Mesa-dev] Where to send Crucible patches?

Hi, I was a bit unsure about where to send Crucible(*) patches, neither README or HACKING file has the answer. In #dri-devel channel people were also not sure. I've ended up sending to piglit mailing list, but found out later some potential reviewers don't subscribe to it. Where should new cont

[Mesa-dev] [Bug 108082] warning: unknown warning option '-Wno-format-truncation' [-Wunknown-warning-option]

https://bugs.freedesktop.org/show_bug.cgi?id=108082 Bug ID: 108082 Summary: warning: unknown warning option '-Wno-format-truncation' [-Wunknown-warning-option] Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH] vulkan: Disable randr lease for libxcb < 1.13

Hi All, Can we get some feedback on this patch please? At the moment, we can't compile vulkan using libxcb < 1.13 due to the use of the RandR lease mechanism. Dave Airlie (cc'd) did some work previously to allow things to be compiled with libxcb 1.11/1.12, mainly by ifdef'ing certain code with HA

Re: [Mesa-dev] [PATCH] radv: do not sync CP DMA when copying buffers

Reviewed-by: Bas Nieuwenhuizen On Wed, Sep 26, 2018 at 11:19 AM Samuel Pitoiset wrote: > > We already track if the DMA engine is busy/idle with a flag, > and we emit a packet that waits for all CP DMA operations > to be complete. This is done at end of command buffer because > the kernel doesn't

Re: [Mesa-dev] [PATCH] radv: adjust the CmdUpdateBuffer threshold for optimal performance

Huh, this even seems an improvement on Raven, at least for "VRAM". Reviewed-by: Bas Nieuwenhuizen On Wed, Sep 26, 2018 at 11:09 AM Samuel Pitoiset wrote: > > According to my benchmark results, it appears that we should > reduce the threshold to 1024. > > BEFORE: > 1 KB: 68.656000 ms > 2 KB: 118.

Re: [Mesa-dev] [PATCH] vulkan: Disable randr lease for libxcb < 1.13

On Thu, 27 Sep 2018 at 15:40, Stuart Young wrote: > > Hi All, > > Can we get some feedback on this patch please? > > At the moment, we can't compile vulkan using libxcb < 1.13 due to the use of > the RandR lease mechanism. Dave Airlie (cc'd) did some work previously to > allow things to be compi