[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #21 from Samuel Pitoiset --- What settings are you using? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing

Re: [Mesa-dev] [PATCH] ac/surface: remove the overallocation workaround for Vega12

2018-11-07 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 11/8/18 3:13 AM, Marek Olšák wrote: From: Marek Olšák not needed anymore (probably since the tile_swizzle fix) --- src/amd/common/ac_surface.c | 4 1 file changed, 4 deletions(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c in

[Mesa-dev] [PATCH] nir: add support for removing redundant stores to copy prop var

2018-11-07 Thread Timothy Arceri
For example the following type of thing is seen in TCS from a number of Vulkan and DXVK games: vec1 32 ssa_557 = deref_var &oPatch (shader_out float) vec1 32 ssa_558 = intrinsic load_deref (ssa_557) () vec1 32 ssa_559 = deref_var &oPatch@42 (shader_out float) vec1 3

Re: [Mesa-dev] [PATCH] nir/constant_folding: fix incorrect bit-size check

2018-11-07 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez Sam On Wednesday, 31 October 2018 12:18:34 (CET) Iago Toral Quiroga wrote: > nir_alu_type_get_type_size takes a type as parameter and we were > passing a bit-size instead, which did what we wanted by accident, > since a bit-size of zero matches nir_type_inv

Re: [Mesa-dev] [PATCH] intel/compiler: fix node interference of simd16 instructions

2018-11-07 Thread Samuel Iglesias Gonsálvez
On Wednesday, 17 October 2018 12:05:42 (CET) Iago Toral Quiroga wrote: > SIMD16 instructions need to have additional interferences to prevent > source / destination hazards when the source and destination registers > are off by one register. > > While we already have code to handle this, it was on

Re: [Mesa-dev] [PATCH] nir/constant_folding: fix incorrect bit-size check

2018-11-07 Thread Iago Toral
This is still waiting for a review. Iago On Wed, 2018-10-31 at 12:18 +0100, Iago Toral Quiroga wrote: > nir_alu_type_get_type_size takes a type as parameter and we were > passing a bit-size instead, which did what we wanted by accident, > since a bit-size of zero matches nir_type_invalid, which h

Re: [Mesa-dev] [PATCH] glsl/test: Fix use after free in test_optpass.

2018-11-07 Thread Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108636 Reviewed-by: Tapani Pälli On 11/7/18 10:01 AM, Hanno Böck wrote: The variable state is free'd and afterwards state->error is used as the return value, resulting in a use after free bug detected by memory safety tools like address sa

Re: [Mesa-dev] [PATCH 00/13] query validation fixes

2018-11-07 Thread Tapani Pälli
FYI there's a whole lot of tests that start to fail when this series running on Intel CI. It includes dEQP but also Piglit tests, can you do Intel CI run or do you want me to send you results? // Tapani On 11/7/18 5:58 PM, Erik Faye-Lund wrote: Here's a bunch of patches for missing error gene

Re: [Mesa-dev] [PATCH] i965: Lift restriction in external textures for EGLImage support

2018-11-07 Thread Tapani Pälli
On 11/7/18 9:51 PM, Kenneth Graunke wrote: On Wednesday, October 31, 2018 5:12:40 PM PST Aditya Swarup wrote: For Intel platforms, we support external textures only for EGLImages created with EGL_EXT_image_dma_buf_import. This restriction seems to be Intel specific and not present for other pl

Re: [Mesa-dev] [PATCH] st/mesa: don't do L3 thread pinning for Blender

2018-11-07 Thread Marek Olšák
Thanks a lot man. I'll reconsider this depending on the results I receive. I may also just pin the Mesa threads and keep the app thread intact. It should perform OK with glthread, but not without glthread. Another option is to have the gallium and winsys threads "chase" the main thread within the

[Mesa-dev] [PATCH] ac/surface: remove the overallocation workaround for Vega12

2018-11-07 Thread Marek Olšák
From: Marek Olšák not needed anymore (probably since the tile_swizzle fix) --- src/amd/common/ac_surface.c | 4 1 file changed, 4 deletions(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index 1f7e2344625..edd710a968c 100644 --- a/src/amd/common/ac_surface.c +++

[Mesa-dev] [PATCH] gallivm: fix improper clamping of vertex index when fetching gs inputs

2018-11-07 Thread sroland
From: Roland Scheidegger Because we only have one file_max for the (2d) gs input file, the value actually represents the max of attrib and vertex index (although I'm not entirely sure if we really want the max, since the max valid value of the vertex dimension can be easily deduced from the input

Re: [Mesa-dev] [PATCH v2] mesa: expose NV_conditional_render on GLES

2018-11-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Nov 7, 2018 at 4:19 PM Erik Faye-Lund wrote: > The extension spec has been updated to include GLES 2 support, so let's > enable it there. > > Signed-off-by: Erik Faye-Lund > --- > Here's a V2 of this patch. The only difference is that this also expose >

Re: [Mesa-dev] [PATCH 6/9] intel/fs: Use the new nir_src_is_const and friends

2018-11-07 Thread Jason Ekstrand
On Wed, Nov 7, 2018 at 4:06 PM Kenneth Graunke wrote: > On Wednesday, November 7, 2018 1:45:59 PM PST Jason Ekstrand wrote: > > On Wed, Nov 7, 2018 at 12:20 PM Kenneth Graunke > > wrote: > > > > > On Saturday, October 20, 2018 10:55:44 AM PST Jason Ekstrand wrote: > > > > @@ -553,14 +552,18 @@ >

Re: [Mesa-dev] [PATCH 6/9] intel/fs: Use the new nir_src_is_const and friends

2018-11-07 Thread Kenneth Graunke
On Wednesday, November 7, 2018 1:45:59 PM PST Jason Ekstrand wrote: > On Wed, Nov 7, 2018 at 12:20 PM Kenneth Graunke > wrote: > > > On Saturday, October 20, 2018 10:55:44 AM PST Jason Ekstrand wrote: > > > @@ -553,14 +552,18 @@ > > fs_visitor::optimize_frontfacing_ternary(nir_alu_instr *instr, >

Re: [Mesa-dev] [PATCH 08/12] meson doesn't use env vars, WAS: configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Dylan Baker
Quoting Jan Vesely (2018-11-07 12:56:30) > On Wed, 2018-11-07 at 11:34 -0800, Dylan Baker wrote: > > Quoting Jan Vesely (2018-11-07 10:39:48) > > > On Tue, 2018-11-06 at 12:09 +, Emil Velikov wrote: > > > > On Thu, 1 Nov 2018 at 16:13, Michel Dänzer wrote: > > > > > On 2018-11-01 5:03 p.m., Ja

Re: [Mesa-dev] [PATCH 1/3] nir: add new linking opt nir_move_out_const_to_consumer()

2018-11-07 Thread Eric Anholt
Timothy Arceri writes: > On 7/11/18 7:40 pm, Samuel Pitoiset wrote: >> IIRC, I wrote a pass similar to this one a while ago, but never finished >> it. >> >> I don't really like the helper name though, how about >> nir_link_immediate_varyings()? or nir_link_constant_varyings()? > > Sure. Happy

[Mesa-dev] [Bug 108611] [radv] [regression, bisected]: LLVM 8.0 breaks lighting in Mass Effect Andromeda

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108611 Nicolai Hähnle changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 108611] [radv] [regression, bisected]: LLVM 8.0 breaks lighting in Mass Effect Andromeda

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108611 --- Comment #6 from Nicolai Hähnle --- I'm reverting the commit to LLVM for now. The change exposed a bug in how divergence analysis info is passed through code generation, and it looks like I will have to touch common code to fix that bug. --

Re: [Mesa-dev] [PATCH 6/9] intel/fs: Use the new nir_src_is_const and friends

2018-11-07 Thread Jason Ekstrand
On Wed, Nov 7, 2018 at 12:20 PM Kenneth Graunke wrote: > On Saturday, October 20, 2018 10:55:44 AM PST Jason Ekstrand wrote: > > @@ -553,14 +552,18 @@ > fs_visitor::optimize_frontfacing_ternary(nir_alu_instr *instr, > > if (src0->intrinsic != nir_intrinsic_load_front_face) > >return f

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #20 from zefkerri...@gmail.com --- (In reply to Samuel Pitoiset from comment #18) > Are you guys still able to reproduce that problem? I'm trying to reproduce > it. With commit 16f10230 this bug unfortunately is still present. -- Y

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #19 from zefkerri...@gmail.com --- Created attachment 142402 --> https://bugs.freedesktop.org/attachment.cgi?id=142402&action=edit The Witcher 3 savegame file in the location where easy to reproduce this bug. -- You are receiving

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Jan Vesely
On Wed, 2018-11-07 at 13:05 -0800, Matt Turner wrote: > On Wed, Nov 7, 2018 at 12:53 PM Jan Vesely wrote: > > On Wed, 2018-11-07 at 18:51 +, Emil Velikov wrote: > > > On Wed, 7 Nov 2018 at 18:39, Jan Vesely wrote: > > > > On Tue, 2018-11-06 at 12:09 +, Emil Velikov wrote: > > > > > On Thu

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #26 from Ahmed Elsayed --- One more thing that I forgot to add: All the games that I used with Wined3d, the textures are so dark. It is described in this issue: https://bugs.winehq.org/show_bug.cgi?id=46073 -- You are receiving th

[Mesa-dev] [PATCH v2] mesa: expose NV_conditional_render on GLES

2018-11-07 Thread Erik Faye-Lund
The extension spec has been updated to include GLES 2 support, so let's enable it there. Signed-off-by: Erik Faye-Lund --- Here's a V2 of this patch. The only difference is that this also expose the extension on ES2. The piglit patches has also been updated: https://patchwork.freedesktop.org/seri

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108508 Ahmed Elsayed changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

Re: [Mesa-dev] [PATCH EGL/MESA] EGL/mesa: Initial writeup for MESA_query_renderer

2018-11-07 Thread Veluri Mithun
Hi all, Thanks Adam for your interest in this. > +New Tokens > > + > > +Accepted as an in EGLQueryRendererIntegerMESA and > > +EGLQueryCurrentRendererIntegerMESA: > > + > > +EGL_RENDERER_VENDOR_ID_MESA 0x > > +EGL_RENDERER_DEVICE_ID_MESA

[Mesa-dev] [Bug 35268] initial-exec TLS model breaks dlopen'ed libGL

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35268 --- Comment #28 from Rich Felker --- Note that removing the asm would also fix sparc, for which I don't feel qualified to fix the asm. It would also make it possible to support x86 targets that lack TLSDESC support at the ldso level (maybe some o

[Mesa-dev] [Bug 105328] Can't include gl and gles headers simultaneously on non-64 bit architectures

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105328 Matt Turner changed: What|Removed |Added Assignee|fdo-b...@engestrom.ch |emil.l.veli...@gmail.com Bloc

[Mesa-dev] [Bug 108530] [Tracker] Mesa 18.3 Release Tracker

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108530 Matt Turner changed: What|Removed |Added Depends on||105328 Referenced Bugs: https://bugs.fr

[Mesa-dev] [Bug 108530] [Tracker] Mesa 18.3 Release Tracker

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108530 Matt Turner changed: What|Removed |Added Alias||mesa-18.3 -- You are receiving this mail

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Matt Turner
On Wed, Nov 7, 2018 at 12:53 PM Jan Vesely wrote: > > On Wed, 2018-11-07 at 18:51 +, Emil Velikov wrote: > > On Wed, 7 Nov 2018 at 18:39, Jan Vesely wrote: > > > On Tue, 2018-11-06 at 12:09 +, Emil Velikov wrote: > > > > On Thu, 1 Nov 2018 at 16:13, Michel Dänzer wrote: > > > > > On 2018

[Mesa-dev] [Bug 35268] initial-exec TLS model breaks dlopen'ed libGL

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35268 --- Comment #27 from Rich Felker --- A couple issues with latest patches by Sora Lee: 1. There is no need for __attribute__((__tls_model__("global-dynamic"))). It's rightly the default whenever it's needed by the ABI. The attribute should just b

[Mesa-dev] [PATCH v2] radv: use LOAD_CONTEXT_REG when loading fast clear values

2018-11-07 Thread Samuel Pitoiset
This avoids syncing the Micro Engine. This is only supported for VI+ currently. There is probably a way for using LOAD_CONTEXT_REG on previous chips but that could be done later. v2: - always use LOAD_CONTEXT_REG for depth/stencil values - remove radv_device::has_load_context_reg Signed-off-b

Re: [Mesa-dev] [PATCH 08/12] meson doesn't use env vars, WAS: configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Jan Vesely
On Wed, 2018-11-07 at 11:34 -0800, Dylan Baker wrote: > Quoting Jan Vesely (2018-11-07 10:39:48) > > On Tue, 2018-11-06 at 12:09 +, Emil Velikov wrote: > > > On Thu, 1 Nov 2018 at 16:13, Michel Dänzer wrote: > > > > On 2018-11-01 5:03 p.m., Jan Vesely wrote: > > > > > On Wed, 2018-10-31 at 18:

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Jan Vesely
On Wed, 2018-11-07 at 18:51 +, Emil Velikov wrote: > On Wed, 7 Nov 2018 at 18:39, Jan Vesely wrote: > > On Tue, 2018-11-06 at 12:09 +, Emil Velikov wrote: > > > On Thu, 1 Nov 2018 at 16:13, Michel Dänzer wrote: > > > > On 2018-11-01 5:03 p.m., Jan Vesely wrote: > > > > > On Wed, 2018-10-3

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #24 from Samuel Pitoiset --- You closed the DXVK issue, what's the status of this bug report? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [PATCH] EGL/mesa: Initial write up for MESA_query_renderer

2018-11-07 Thread Veluri Mithun
--- docs/specs/EGL_MESA_query_renderer.txt | 186 + 1 file changed, 186 insertions(+) create mode 100644 docs/specs/EGL_MESA_query_renderer.txt diff --git a/docs/specs/EGL_MESA_query_renderer.txt b/docs/specs/EGL_MESA_query_renderer.txt new file mode 100644 index 000

Re: [Mesa-dev] [PATCH] i965: Lift restriction in external textures for EGLImage support

2018-11-07 Thread Kenneth Graunke
On Wednesday, October 31, 2018 5:12:40 PM PST Aditya Swarup wrote: > For Intel platforms, we support external textures only for EGLImages > created with EGL_EXT_image_dma_buf_import. This restriction seems to > be Intel specific and not present for other platforms. > > While running SKQP test - un

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #18 from Samuel Pitoiset --- Are you guys still able to reproduce that problem? I'm trying to reproduce it. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

Re: [Mesa-dev] [PATCH 08/12] meson doesn't use env vars, WAS: configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Dylan Baker
Quoting Jan Vesely (2018-11-07 10:39:48) > On Tue, 2018-11-06 at 12:09 +, Emil Velikov wrote: > > On Thu, 1 Nov 2018 at 16:13, Michel Dänzer wrote: > > > On 2018-11-01 5:03 p.m., Jan Vesely wrote: > > > > On Wed, 2018-10-31 at 18:40 +, Emil Velikov wrote: > > > > > On Wed, 31 Oct 2018 at 1

Re: [Mesa-dev] [PATCH 4/4] bin/get-pick-list.sh: add fixes handling

2018-11-07 Thread Emil Velikov
On Wed, 7 Nov 2018 at 12:08, Emil Velikov wrote: > - fixes=`git show --pretty=medium -s $sha | tr -d "\n" | sed -e > 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e > 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'` > + grep "fixes:" | sed -e 's/\(fixes:[a-fA-F0-9]*\).*$/\1/'

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Emil Velikov
On Wed, 7 Nov 2018 at 18:39, Jan Vesely wrote: > > On Tue, 2018-11-06 at 12:09 +, Emil Velikov wrote: > > On Thu, 1 Nov 2018 at 16:13, Michel Dänzer wrote: > > > On 2018-11-01 5:03 p.m., Jan Vesely wrote: > > > > On Wed, 2018-10-31 at 18:40 +, Emil Velikov wrote: > > > > > On Wed, 31 Oct

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Jan Vesely
On Tue, 2018-11-06 at 12:09 +, Emil Velikov wrote: > On Thu, 1 Nov 2018 at 16:13, Michel Dänzer wrote: > > On 2018-11-01 5:03 p.m., Jan Vesely wrote: > > > On Wed, 2018-10-31 at 18:40 +, Emil Velikov wrote: > > > > On Wed, 31 Oct 2018 at 17:41, Jan Vesely wrote: > > > > > On Wed, 2018-10-

Re: [Mesa-dev] [PATCH 6/9] intel/fs: Use the new nir_src_is_const and friends

2018-11-07 Thread Kenneth Graunke
On Saturday, October 20, 2018 10:55:44 AM PST Jason Ekstrand wrote: > @@ -553,14 +552,18 @@ fs_visitor::optimize_frontfacing_ternary(nir_alu_instr > *instr, > if (src0->intrinsic != nir_intrinsic_load_front_face) >return false; > > - nir_const_value *value1 = nir_src_as_const_value

Re: [Mesa-dev] [PATCH mesa 1/3] mesa: drop unused & deprecated lib

2018-11-07 Thread Dylan Baker
Quoting Eric Engestrom (2018-11-07 05:20:20) > DeprecationWarning: the imp module is deprecated in favour of importlib > > Signed-off-by: Eric Engestrom > --- > src/mesa/main/get_hash_generator.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/get_hash_

Re: [Mesa-dev] [PATCH] radv: use LOAD_CONTEXT_REG when loading fast clear values

2018-11-07 Thread Samuel Pitoiset
On 11/7/18 3:29 PM, Samuel Pitoiset wrote: This avoids syncing the Micro Engine. This is only supported for VI+ currently. There is probably a way for using LOAD_CONTEXT_REG on previous chips but that could be done later. Signed-off-by: Samuel Pitoiset --- src/amd/common/sid.h |

Re: [Mesa-dev] [PATCH mesa 3/3] egl: remove dead code in glvnd dispatch generation code

2018-11-07 Thread Emil Velikov
On Wed, 7 Nov 2018 at 13:20, Eric Engestrom wrote: > > g_egldispatchstubs.[ch] are completely identical before and after this > patch. > In theory I agree with the idea here, but I'm quite wary about this. While the moment nobody uses this code, as we do ... it'll be rather unlikely that we'll fi

Re: [Mesa-dev] [PATCH v2 12/32] intel/isl: Disallow Yf and Ys for 1D depth surfaces

2018-11-07 Thread Pohjolainen, Topi
On Wed, Nov 07, 2018 at 11:17:38AM -0600, Jason Ekstrand wrote: > On Wed, Nov 7, 2018 at 10:38 AM Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Fri, Oct 12, 2018 at 01:46:42PM -0500, Jason Ekstrand wrote: > > > --- > > > src/intel/isl/isl_gen7.c | 9 + > > > 1 file cha

Re: [Mesa-dev] [PATCH v2 12/32] intel/isl: Disallow Yf and Ys for 1D depth surfaces

2018-11-07 Thread Jason Ekstrand
On Wed, Nov 7, 2018 at 10:38 AM Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Oct 12, 2018 at 01:46:42PM -0500, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl_gen7.c | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/src/intel/isl/isl_gen7.c b/src/inte

Re: [Mesa-dev] [PATCH mesa 2/3] egl: fix python lib deprecation warning

2018-11-07 Thread Eric Engestrom
On Wednesday, 2018-11-07 09:51:12 -0700, Kyle Brenneman wrote: > On 11/07/2018 06:20 AM, Eric Engestrom wrote: > >DeprecationWarning: the imp module is deprecated in favour of importlib > > > > importlib is available since python 2.7 and 3.1, and we already require > > 2.7 and 3.4 so we can si

Re: [Mesa-dev] [PATCH mesa 3/3] egl: remove dead code in glvnd dispatch generation code

2018-11-07 Thread Kyle Brenneman
On 11/07/2018 06:20 AM, Eric Engestrom wrote: g_egldispatchstubs.[ch] are completely identical before and after this patch. Signed-off-by: Eric Engestrom --- src/egl/generate/eglFunctionList.py | 203 +++ src/egl/generate/gen_egl_dispatch.py | 61 ++-- 2 files

Re: [Mesa-dev] [PATCH v2 25/32] intel/isl: Add a max_miptail_levels field to isl_tile_info

2018-11-07 Thread Pohjolainen, Topi
On Fri, Oct 12, 2018 at 01:46:55PM -0500, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 5 + > src/intel/isl/isl.h | 7 +++ > 2 files changed, 12 insertions(+) Matches PRM: Reviewed-by: Topi Pohjolainen > > diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > index 4a8380ad5

Re: [Mesa-dev] [PATCH mesa 2/3] egl: fix python lib deprecation warning

2018-11-07 Thread Kyle Brenneman
On 11/07/2018 06:20 AM, Eric Engestrom wrote: DeprecationWarning: the imp module is deprecated in favour of importlib importlib is available since python 2.7 and 3.1, and we already require 2.7 and 3.4 so we can simply use the new lib. Signed-off-by: Eric Engestrom --- src/egl/generate/ge

Re: [Mesa-dev] [PATCH] gm107/ir: fix compile time warning in getTEXSMask

2018-11-07 Thread Karol Herbst
On Wed, Nov 7, 2018 at 3:21 PM Ilia Mirkin wrote: > > Reviewed-by: Ilia Mirkin > > Although I'd rather the return go into the "default:" case, after the > assert, which is the reason for the warning. sure, I'll move it. > On Wed, Nov 7, 2018 at 7:50 AM Karol Herbst wrote: > > > > In function '

Re: [Mesa-dev] [PATCH v2 04/13] intel/genxml: Add engine definition to render engine instructions (gen4)

2018-11-07 Thread Toni Lönnberg
On Tue, Nov 06, 2018 at 12:40:43PM +, Lionel Landwerlin wrote: > On 31/10/2018 13:12, Toni Lönnberg wrote: > > Instructions meant for the render engine now have a definition > > specifying that so that can differentiate instructions meant for > > different engines due to shared opcodes. v2: Div

Re: [Mesa-dev] [PATCH v2 24/32] intel/isl: Add initial data-structure support for miptails

2018-11-07 Thread Pohjolainen, Topi
On Fri, Oct 12, 2018 at 01:46:54PM -0500, Jason Ekstrand wrote: > This commit just adds a miptail start field to isl_surf and wires it up > in the RENDER_SURFACE_STATE and 3DSTATE_DEPTH code. We also add a > minimum miptail LOD so that client drivers have a knob to control the > miptails a bit. >

[Mesa-dev] [PATCH v3 09/10] intel/genxml: Add engine definition to render engine instructions (gen10)

2018-11-07 Thread Toni Lönnberg
Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen v3: Added additional engine definitions. --- src/intel/genxml/gen10.xml | 224

Re: [Mesa-dev] [PATCH v2 12/32] intel/isl: Disallow Yf and Ys for 1D depth surfaces

2018-11-07 Thread Pohjolainen, Topi
On Fri, Oct 12, 2018 at 01:46:42PM -0500, Jason Ekstrand wrote: > --- > src/intel/isl/isl_gen7.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/intel/isl/isl_gen7.c b/src/intel/isl/isl_gen7.c > index f6f7e1ba7dc..fe420e4fbd8 100644 > --- a/src/intel/isl/isl_gen7.c > +++ b/s

[Mesa-dev] [PATCH v3 11/11] intel/genxml: Add engine definition to render engine instructions (gen11)

2018-11-07 Thread Toni Lönnberg
Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen v3: Added additional engine definitions. --- src/intel/genxml/gen11.xml | 230

[Mesa-dev] [PATCH v3 08/10] intel/genxml: Add engine definition to render engine instructions (gen9)

2018-11-07 Thread Toni Lönnberg
Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen v3: Added additional engine definitions. --- src/intel/genxml/gen9.xml | 226 +

[Mesa-dev] [PATCH v3 10/10] intel/genxml: Add engine definition to render engine instructions (gen11)

2018-11-07 Thread Toni Lönnberg
Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen v3: Added additional engine definitions. --- src/intel/genxml/gen11.xml | 230

[Mesa-dev] [PATCH v3 05/10] intel/genxml: Add engine definition to render engine instructions (gen7)

2018-11-07 Thread Toni Lönnberg
Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen v3: Added additional engine definitions. --- src/intel/genxml/gen7.xml | 166 +

[Mesa-dev] [PATCH v3 06/10] intel/genxml: Add engine definition to render engine instructions (gen75)

2018-11-07 Thread Toni Lönnberg
Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen v3: Added additional engine definitions. --- src/intel/genxml/gen75.xml | 214

[Mesa-dev] [PATCH v3 07/10] intel/genxml: Add engine definition to render engine instructions (gen8)

2018-11-07 Thread Toni Lönnberg
Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen v3: Added additional engine definitions. --- src/intel/genxml/gen8.xml | 228 +

[Mesa-dev] [PATCH v3 04/10] intel/genxml: Add engine definition to render engine instructions (gen6)

2018-11-07 Thread Toni Lönnberg
Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen v3: Added additional engine definitions --- src/intel/genxml/gen6.xml | 106 ++

[Mesa-dev] [PATCH v3 03/10] intel/genxml: Add engine definition to render engine instructions (gen5)

2018-11-07 Thread Toni Lönnberg
Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen v3: Added additional engine definitions. --- src/intel/genxml/gen5.xml | 60 ++

[Mesa-dev] [PATCH v3 02/10] intel/genxml: Add engine definition to render engine instructions (gen45)

2018-11-07 Thread Toni Lönnberg
Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen v3: Added addition engine definitions. --- src/intel/genxml/gen45.xml | 54 +++

[Mesa-dev] [PATCH v3 01/10] intel/genxml: Add engine definition to render engine instructions (gen4)

2018-11-07 Thread Toni Lönnberg
Instructions meant for the render engine now have a definition specifying that so that can differentiate instructions meant for different engines due to shared opcodes. v2: Divided into individual patches for each gen v3: Added additional engine definitions. --- src/intel/genxml/gen4.xml | 50 ++

Re: [Mesa-dev] [PATCH v2 17/32] intel/blorp: Adjust the compressed copy rectangle before convert_to_single_slice

2018-11-07 Thread Pohjolainen, Topi
On Fri, Oct 12, 2018 at 01:46:47PM -0500, Jason Ekstrand wrote: > It doesn't matter for the actual copy rectangle and this makes the > asserts a bit nicer as we don't need to bother with the intratile > offsets because there aren't any yet. Reviewed-by: Topi Pohjolainen > --- > src/intel/blorp/

Re: [Mesa-dev] [PATCH EGL/MESA] EGL/mesa: Initial write up for EGL_MESA_query_driver

2018-11-07 Thread Adam Jackson
On Mon, 2018-11-05 at 23:33 +0530, Veluri Mithun wrote: > +New Procedures and Functions > + > +const char* EGLGetDriverConfig(const char *driverName); This is difficult to implement in a GLVND environment. The frontend would need a way to distinguish responses from the vendor library for "I d

Re: [Mesa-dev] [PATCH v2 09/32] intel/isl: Implement correct tile size calculations for Ys/Yf

2018-11-07 Thread Pohjolainen, Topi
On Fri, Oct 12, 2018 at 01:46:39PM -0500, Jason Ekstrand wrote: > The tile size calculations use a clever bit of math to make them short > and simple. We add unit tests to assert that they identically match the > tables in the PRM. Compared both the equations and tests against the PRM: Reviewed-

Re: [Mesa-dev] [PATCH EGL/MESA] EGL/mesa: Initial writeup for MESA_query_renderer

2018-11-07 Thread Adam Jackson
On Mon, 2018-11-05 at 10:04 +0530, Veluri Mithun wrote: > Signed-off-by: Veluri Mithun Thanks for looking into this! Many of these comments apply equally to the GLX extension I think; if you wanted to write a patch for the equivalent text for that extension too, that'd be awesome. > +EGL 1.

[Mesa-dev] [PATCH] radv: only expose VK_SUBGROUP_FEATURE_ARITHMETIC_BIT for VI+

2018-11-07 Thread Samuel Pitoiset
Inclusive and exclusives scan are missing because older chips don't have llvm.amdgcn.update.dpp. This fixes crashes with dEQP-VK.subgroups.arithmetic.*. CC: mesa-sta...@lists.freedesktop.org Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+),

[Mesa-dev] [PATCH 3/3] docs: document the staging branch and add reference to it

2018-11-07 Thread Emil Velikov
From: Emil Velikov A while back we agreed that having a live/staging branch is beneficial. Sadly we forgot to document that, so here is my first attempt. Document the caveat that the branch history is not stable. CC: Andres Gomez CC: Dylan Baker CC: Juan A. Suarez Romero Signed-off-by: Emil

[Mesa-dev] [PATCH 1/3] docs/releasing.html: polish cherry-picking/testing text

2018-11-07 Thread Emil Velikov
From: Emil Velikov Reword slightly and highlight the important parts of the text. CC: Andres Gomez CC: Dylan Baker CC: Juan A. Suarez Romero Signed-off-by: Emil Velikov --- docs/releasing.html | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/

[Mesa-dev] [PATCH 2/3] docs/submittingpatches.html: correctly handle the tag

2018-11-07 Thread Emil Velikov
From: Emil Velikov As pointed out by the w3c validator. Signed-off-by: Emil Velikov --- docs/submittingpatches.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index e5350bdb2cf..b84f01c3b37 100644 --- a/docs/submittingpatches

[Mesa-dev] [PATCH 11/13] mesa/main: fix validation of ARB_query_buffer_object

2018-11-07 Thread Erik Faye-Lund
ctx->Extensions.ARB_query_buffer_object is set based on the driver- capabilities, not based on the context type. We need to check against _mesa_has_ARB_query_buffer_object(ctx) instead to figure out if the extension is really supported. This turns attempts to read queries into buffer objects on ES

[Mesa-dev] [PATCH 13/13] mesa/main: remove overly strict query-validation

2018-11-07 Thread Erik Faye-Lund
The rules encoded in this code also applies to OpenGL ES 3.0 and up, but the per-enum validation has already been taught about these rules. So let's get rid of this duplicate, narrow version of the validation. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 14 -- 1 file

[Mesa-dev] [PATCH 10/13] mesa/main: fix validation of transform-feedback overflow queries

2018-11-07 Thread Erik Faye-Lund
ctx->Extensions.ARB_transform_feedback_overflow_query is set based on the driver-capabilities, not based on the context type. We need to check against _mesa_has_RB_transform_feedback_overflow_query(ctx) instead to figure out if the extension is really supported. This turns usage of GL_TRANSFORM_FE

[Mesa-dev] [PATCH 06/13] mesa/main: fix validation of GL_ANY_SAMPLES_PASSED

2018-11-07 Thread Erik Faye-Lund
ctx->Extensions.ARB_occlusion_query2 is set based on the driver- capabilities, not based on the context type. We need to check against _mesa_has_ARB_occlusion_query2(ctx) instead to figure out if the extension is really supported. In addition, EXT_occlusion_query_boolean should also allow this beh

[Mesa-dev] [PATCH 07/13] mesa/main: fix validation of GL_ANY_SAMPLES_PASSED_CONSERVATIVE

2018-11-07 Thread Erik Faye-Lund
ctx->Extensions.ARB_ES3_compatibility is set based on the driver- capabilities, not based on the context type. We need to check against _mesa_has_ARB_ES3_compatibility(ctx) instead to figure out if the extension is really supported. In addition, EXT_occlusion_query_boolean should also allow this b

[Mesa-dev] [PATCH 05/13] mesa/main: fix validation of GL_SAMPLES_PASSED

2018-11-07 Thread Erik Faye-Lund
ctx->Extensions.ARB_occlusion_query is set based on the driver- capabilities, not based on the context type. We need to check against _mesa_has_ARB_occlusion_query(ctx) instead to figure out if the extension is really supported. This turns usage of GL_SAMPLES_PASSED into an error on ES 3, as is re

[Mesa-dev] [PATCH 12/13] mesa/main: fix validation of GL_TIMESTAMP

2018-11-07 Thread Erik Faye-Lund
ctx->Extensions.ARB_timer_query is set based on the driver- capabilities, not based on the context type. We need to check against _mesa_has_ARB_timer_query(ctx) instead to figure out if the extension is really supported. This shouln't have any functional effect, as this entry-point is only valid o

[Mesa-dev] [PATCH 08/13] mesa/main: fix validation of GL_TIME_ELAPSED

2018-11-07 Thread Erik Faye-Lund
ctx->Extensions.EXT_timer_query is set based on the driver- capabilities, not based on the context type. We need to check against _mesa_has_EXT_timer_query(ctx) instead to figure out if the extension is really supported. This turns usage of GL_TIME_ELAPSED into an error on ES 3, as is required by

[Mesa-dev] [PATCH 09/13] mesa/main: fix validation of transform-feedback queries

2018-11-07 Thread Erik Faye-Lund
ctx->Extensions.EXT_transform_feedback is set based on the driver- capabilities, not based on the context type. We need to check against _mesa_has_EXT_transform_feedback(ctx) instead to figure out if the extension is really supported. This turns usage of GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN in

[Mesa-dev] [PATCH 01/13] mesa/main: correct requirement for EXT_occlusion_query_boolean

2018-11-07 Thread Erik Faye-Lund
EXT_occlusion_query_boolean require support for GL_ANY_SAMPLES_PASSED, which ARB_occlusion_query doesn't supply. We need ARB_occlusion_query2 for this instead. This is still not 100% accurate, as we also require support for the GL_SAMPLES_PASSED_CONSERVATIVE target, which isn't guaranteed by eithe

[Mesa-dev] [PATCH 03/13] mesa/main: use non-prefixed enums for consistency

2018-11-07 Thread Erik Faye-Lund
These enums all have the same values as their non-prefixed versions, and there's several aliases for some of them. So let's switch to the non-prefixed versions for simplicity. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 66 1 file changed

[Mesa-dev] [PATCH 02/13] mesa/main: correct year for EXT_occlusion_query_boolean

2018-11-07 Thread Erik Faye-Lund
According to the extension spec, this was initially released in 2011, so let's set this to the correct value. The value of 2001 could be a copy-paste mistake, as ARB_occlusion_query which this is based on was released then. Signed-off-by: Erik Faye-Lund --- src/mesa/main/extensions_table.h | 2

[Mesa-dev] [PATCH 00/13] query validation fixes

2018-11-07 Thread Erik Faye-Lund
Here's a bunch of patches for missing error generation in the query buffer code. The general pattern, is that code that directly checks ctx->Extensions.FOO_bar instead of using _mesa_has_FOO_bar(ctx) will often end up drawing the wrong conclusion on ES, because the flag in ctx->Extensions only tel

[Mesa-dev] [PATCH 04/13] mesa/main: simplify pipeline-statistics query validation

2018-11-07 Thread Erik Faye-Lund
The _mesa_has_ARB_pipeline_statistics_query(ctx)-helper will already check the GLES-version according to the extension-table, so if this extension would ever be back-ported to ES, we only need to update the table to support this. This shouln't have any functional effect. Signed-off-by: Erik Faye-

[Mesa-dev] [PATCH v4] mesa/driconf: rotation of 0-vector

2018-11-07 Thread Sergii Romantsov
Specification doesn't define behaviour for rotation of 0-vector. In https://github.com/KhronosGroup/OpenGL-API/issues/41 said that behaviour is undefined and agreed that it would be fine for implementation to do something useful for this. Windows and Nvidia drivers have a workaround for that. For c

[Mesa-dev] [PATCH v3] intel/decoder: tools: Use engine for decoding batch instructions

2018-11-07 Thread Toni Lönnberg
The engine to which the batch was sent to is now set to the decoder context when decoding the batch. This is needed so that we can distinguish between instructions as the render and video pipe share some of the instruction opcodes. v2: The engine is now in the decoder context and the batch decoder

[Mesa-dev] [PATCH v3] intel/decoder: Engine parameter for instructions

2018-11-07 Thread Toni Lönnberg
Preliminary work for adding handling of different pipes to gen_decoder. Each instruction needs to have a definition describing which engine it is meant for. If left undefined, by default, the instruction is defined for all engines. v2: Changed to use the engine class definitions from UAPI v3: Cha

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-07 Thread Ilia Mirkin
On Wed, Nov 7, 2018 at 7:45 AM Gert Wollny wrote: > > Am Dienstag, den 06.11.2018, 15:28 -0500 schrieb Ilia Mirkin: > > On Tue, Nov 6, 2018 at 3:15 PM Gert Wollny > > wrote: > > > > > > > > > The extension has the status "not complete" but after reading is it > > > seems to describe what is neede

[Mesa-dev] [PATCH] radv: use LOAD_CONTEXT_REG when loading fast clear values

2018-11-07 Thread Samuel Pitoiset
This avoids syncing the Micro Engine. This is only supported for VI+ currently. There is probably a way for using LOAD_CONTEXT_REG on previous chips but that could be done later. Signed-off-by: Samuel Pitoiset --- src/amd/common/sid.h | 1 + src/amd/vulkan/radv_cmd_buffer.c | 60 +++

Re: [Mesa-dev] [PATCH] gm107/ir: fix compile time warning in getTEXSMask

2018-11-07 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Although I'd rather the return go into the "default:" case, after the assert, which is the reason for the warning. On Wed, Nov 7, 2018 at 7:50 AM Karol Herbst wrote: > > In function 'uint8_t nv50_ir::getTEXSMask(uint8_t)': > warning: control reaches end of non-void funct

Re: [Mesa-dev] [PATCH 2/4] bin/get-pick-list.sh: prefix output with "[stable] "

2018-11-07 Thread Eric Engestrom
On Wednesday, 2018-11-07 13:38:26 +, Eric Engestrom wrote: > On Wednesday, 2018-11-07 12:07:16 +, Emil Velikov wrote: > > From: Emil Velikov > > > > With later commits we'll fold all the different scripts into one. > > Add the explicit prefix, so that we know the origin of the nomination

Re: [Mesa-dev] [PATCH 2/4] bin/get-pick-list.sh: prefix output with "[stable] "

2018-11-07 Thread Eric Engestrom
On Wednesday, 2018-11-07 12:07:16 +, Emil Velikov wrote: > From: Emil Velikov > > With later commits we'll fold all the different scripts into one. > Add the explicit prefix, so that we know the origin of the nomination > > Signed-off-by: Emil Velikov > --- > bin/get-pick-list.sh | 21

Re: [Mesa-dev] [PATCH mesa 1/3] mesa: drop unused & deprecated lib

2018-11-07 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 07/11/2018 13:20, Eric Engestrom wrote: DeprecationWarning: the imp module is deprecated in favour of importlib Signed-off-by: Eric Engestrom --- src/mesa/main/get_hash_generator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

  1   2   >