Re: [Mesa-dev] [PATCH 01/10] mesa: Rename gl_vertex_array_object::_Enabled -> Enabled.

Good Morning, On Tuesday, 20 November 2018 23:49:28 CET Marek Olšák wrote: > For the series: > > Reviewed-by: Marek Olšák Thanks! and pushed now! best Mathias ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] virgl: don't mark buffers as unclean after a write

On Tue, Nov 20, 2018 at 3:34 PM Ilia Mirkin wrote: > > I'm unfamiliar with the surrounding code, but wanted to point out that > a single buffer may be mapped as a SSBO, UBO, TBO, etc. > transfer_map/unmap isn't really aware of how the buffer is used. You > can, however, keep track of such

Re: [Mesa-dev] [PATCH 03/22] nir/spirv: initial handling of OpenCL.std extension opcodes

On Tue, Nov 13, 2018 at 9:48 AM Karol Herbst wrote: > Not complete, mostly just adding things as I encounter them in CTS. But > not getting far enough yet to hit most of the OpenCL.std instructions. > > Anyway, this is better than nothing and covers the most common builtins. > > Signed-off-by:

[Mesa-dev] [PATCH 0/7] Reduce worst-case memory usage in NIR

Work on soft fp64 support has uncovered some pessimal memory usage inside NIR. Code that uses soft fp64 hits two problems: huge numbers of basic blocks and huge numbers of values. Several places in the compiler use straight forward, naive data structures that consume massive amounts of memory in

[Mesa-dev] [PATCH 3/7] util/slab: Add function to flush allocations from a child pool

From: Ian Romanick Ralloc has a feature that all allocations from a temporary memory context can be whisked away in a single call without fear of leaks. As the slab allocator is designed for use in multhreaded scenarios with a child pool per CPU, it lacks this feature. However, many users will

[Mesa-dev] [PATCH 2/7] nir/phi_builder: Use hash table to store [value, block] -> def mapping

From: Ian Romanick Changes in peak memory usage according to Valgrind massif: mean soft fp64 using uint64: 5,499,881,802 => 1,343,998,123 gfxbench5 aztec ruins high 11:62,415,414 =>62,415,414 deus ex mankind divided 148: 62,317,965 =>62,317,965 deus ex mankind divided 2890:

[Mesa-dev] [PATCH 6/7] nir: Add function to release memory used for liveness tracking

From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/nir/nir.h | 2 ++ src/compiler/nir/nir_liveness.c | 17 + 2 files changed, 19 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 74c700026ad..ac20864c6ca 100644 ---

[Mesa-dev] [PATCH 5/7] nir: Fix holes in nir_instr

From: Ian Romanick Found using pahole. Changes in peak memory usage according to Valgrind massif: mean soft fp64 using uint64: 1,343,998,123 => 1,342,766,051 gfxbench5 aztec ruins high 11:62,415,414 =>62,369,974 deus ex mankind divided 148: 62,317,965 =>62,290,717 deus ex

[Mesa-dev] [PATCH 4/7] nir/phi_builder: Use slab allocator for temporary data structures

From: Ian Romanick This pass allocates a large number of two different data structures. This data only lives during the pass. Use the slab allocator to reduce the memory overhead (from 5 pointers + possible padding per allocation to nearly zero per allocation) and potentially improve

[Mesa-dev] [PATCH 1/7] nir/phi_builder: Internal users should use nir_phi_builder_value_set_block_def too

From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/nir/nir_phi_builder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_phi_builder.c b/src/compiler/nir/nir_phi_builder.c index cc5ce81d120..add3efd2dfc 100644 ---

[Mesa-dev] [PATCH 7/7] intel/compiler: Release memory used by NIR metadata before generating machine code

From: Ian Romanick Changes in peak memory usage according to Valgrind massif: mean soft fp64 using uint64: 1,342,766,051 => 1,010,677,195 gfxbench5 aztec ruins high 11:62,369,974 =>62,369,974 deus ex mankind divided 148: 62,290,717 =>62,290,717 deus ex mankind divided 2890:

Re: [Mesa-dev] [PATCH 1/2] st/mesa: regularly re-pin driver threads to the CCX where the app thread is

On Wed, 21 Nov 2018 at 10:16, Marek Olšák wrote: > > On Tue, Nov 20, 2018 at 7:06 PM Dave Airlie wrote: >> >> Seems to be a more reasonable solution than previously, >> >> Reviewed-by: Dave Airlie > > > For the series? Yes for both series. Dave. ___

Re: [Mesa-dev] [PATCH 2/2] radeonsi: go back to using bottom-of-pipe for beginning of TIME_ELAPSED

On Tue, Nov 20, 2018 at 7:06 PM Dave Airlie wrote: > Reviewed-by: Dave Airlie > For the series? Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] st/mesa: regularly re-pin driver threads to the CCX where the app thread is

On Tue, Nov 20, 2018 at 7:06 PM Dave Airlie wrote: > Seems to be a more reasonable solution than previously, > > Reviewed-by: Dave Airlie > For the series? Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 3/3] drirc: enable glthread for Talos Principle

Can we get some stats and preferably the cpu/gpu hardware combo used to go in the commit message? Or in the comment above the drirc entry? With that: Reviewed-by: Timothy Arceri On 10/11/18 5:29 pm, Marek Olšák wrote: From: Marek Olšák Immediate mode was needed. ---

[Mesa-dev] [AppVeyor] mesa master #9378 completed

Build mesa 9378 completed Commit 25d95ed535 by Marek Olšák on 11/21/2018 12:06 AM: gallium/u_tests: fix MSVC build by using old-style zero initializers Configure your notification preferences ___ mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa/glthread: enable immediate mode

Reviewed-by: Timothy Arceri On 10/11/18 5:29 pm, Marek Olšák wrote: From: Marek Olšák --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/vbo/vbo_exec_api.c | 14 ++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

Re: [Mesa-dev] [PATCH 1/3] mesa/glthread: pass the function name to _mesa_glthread_restore_dispatch

Can we add the printf inside #if 0 #endif So that we know why the name is passed? With that: Reviewed-by: Timothy Arceri On 10/11/18 5:29 pm, Marek Olšák wrote: From: Marek Olšák If you insert printf there, you'll know why glthread was disabled. --- src/mapi/glapi/gen/gl_marshal.py |

Re: [Mesa-dev] [PATCH 1/2] st/mesa: regularly re-pin driver threads to the CCX where the app thread is

Seems to be a more reasonable solution than previously, Reviewed-by: Dave Airlie On Wed, 21 Nov 2018 at 09:50, Marek Olšák wrote: > > Ping > > On Mon, Nov 12, 2018 at 7:21 PM Marek Olšák wrote: >> >> From: Marek Olšák >> >> This is used when glthread is disabled. >> >> Mesa pretty much chases

Re: [Mesa-dev] [PATCH 2/2] radeonsi: go back to using bottom-of-pipe for beginning of TIME_ELAPSED

Reviewed-by: Dave Airlie On Wed, 21 Nov 2018 at 09:51, Marek Olšák wrote: > > Ping > > On Tue, Nov 13, 2018 at 4:23 PM Marek Olšák wrote: >> >> From: Marek Olšák >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102597 >> >> Cc: 18.3 >> --- >>

[Mesa-dev] [AppVeyor] mesa master #9376 failed

Build mesa 9376 failed Commit 0d17b685b1 by Marek Olšák on 11/14/2018 9:41 PM: gallium/u_tests: add a compute shader test that clears an image Configure your notification preferences ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 2/2] radeonsi: go back to using bottom-of-pipe for beginning of TIME_ELAPSED

Ping On Tue, Nov 13, 2018 at 4:23 PM Marek Olšák wrote: > From: Marek Olšák > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102597 > > Cc: 18.3 > --- > src/gallium/drivers/radeonsi/si_query.c | 15 --- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/2] st/mesa: regularly re-pin driver threads to the CCX where the app thread is

Ping On Mon, Nov 12, 2018 at 7:21 PM Marek Olšák wrote: > From: Marek Olšák > > This is used when glthread is disabled. > > Mesa pretty much chases the app thread on the CPU. > The performance is the same as pinning the app thread. > --- > src/mesa/state_tracker/st_context.h | 2 ++ >

Re: [Mesa-dev] [PATCH 1/3] mesa/glthread: pass the function name to _mesa_glthread_restore_dispatch

Ping On Sat, Nov 10, 2018 at 1:29 AM Marek Olšák wrote: > From: Marek Olšák > > If you insert printf there, you'll know why glthread was disabled. > --- > src/mapi/glapi/gen/gl_marshal.py | 2 +- > src/mesa/main/glthread.c | 4 ++-- > src/mesa/main/glthread.h | 2 +- >

Re: [Mesa-dev] [PATCH] virgl: don't mark buffers as unclean after a write

I'm unfamiliar with the surrounding code, but wanted to point out that a single buffer may be mapped as a SSBO, UBO, TBO, etc. transfer_map/unmap isn't really aware of how the buffer is used. You can, however, keep track of such bindings on either the resource or the context, and know that buffer

[Mesa-dev] [PATCH] virgl: don't mark buffers as unclean after a write

Texture buffers and SSBOs are always unclean, while other buffers are not modified by compute/rendering. This improves dEQP-GLES3.performance.buffer.data_upload.function_call.map_buffer_range.new_specified_buffer.flag_write_full.stream_draw from 9.58 MB/s to 451.17 MB/s. Regression tested

Re: [Mesa-dev] [PATCH 01/10] mesa: Rename gl_vertex_array_object::_Enabled -> Enabled.

For the series: Reviewed-by: Marek Olšák Marek On Sat, Nov 17, 2018 at 7:15 AM wrote: > From: Mathias Fröhlich > > Mark the up to now derived bitfield value now as primary > value by removing the underscore. > > Signed-off-by: Mathias Fröhlich > --- > src/mesa/main/arrayobj.c | 20

Re: [Mesa-dev] [PATCH 0/4] Some prep work for fixing multi context issues in Nouveau

On Tue, Nov 20, 2018 at 10:34 PM Ilia Mirkin wrote: > > On Tue, Nov 20, 2018 at 4:12 PM Karol Herbst wrote: > > > > On Tue, Nov 20, 2018 at 8:42 PM Ilia Mirkin wrote: > > > > > > On Tue, Nov 20, 2018 at 2:22 PM Karol Herbst wrote: > > > > > > > > This series cleans up some code in preparation

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

Those are all good points. I would suggest putting the commit explanations into the code instead of commit messages, keeping the commit messages empty. When we have a good commit message, we can just copy it into the code as a comment. It's understandable that people don't understand some of my

Re: [Mesa-dev] [PATCH 0/4] Some prep work for fixing multi context issues in Nouveau

On Tue, Nov 20, 2018 at 4:12 PM Karol Herbst wrote: > > On Tue, Nov 20, 2018 at 8:42 PM Ilia Mirkin wrote: > > > > On Tue, Nov 20, 2018 at 2:22 PM Karol Herbst wrote: > > > > > > This series cleans up some code in preparation for the real fix and > > > contains > > > cleanups we want to have

[Mesa-dev] [PATCH] vulkan: Allow storage images in the WSI.

Since apps also have to follow the ImageFormatProperties query, we can disallow formats that don't allow image stores (for AMD that would be SRGB formats). Note that this only affects anything if the app actually decides to use the flag. Had someone ask for this on IRC and at least on the AMD

[Mesa-dev] [PATCH RFC] dri2: add support for linux-dmabuf-unstable-v1 version 4

This only implements the "primary_device" part. This allows EGL to work without relying on wl_drm anymore. --- This simple patch implements version 4, which is still in review on wayland-devel [1]. [1]: https://patchwork.freedesktop.org/series/52370/ src/egl/drivers/dri2/platform_wayland.c |

Re: [Mesa-dev] [PATCH 0/4] Some prep work for fixing multi context issues in Nouveau

On Tue, Nov 20, 2018 at 8:42 PM Ilia Mirkin wrote: > > On Tue, Nov 20, 2018 at 2:22 PM Karol Herbst wrote: > > > > This series cleans up some code in preparation for the real fix and contains > > cleanups we want to have regardless. > > > > The approach in soon to follow patches is to give each

Re: [Mesa-dev] [PATCH mesa] vulkan/wsi: fix s/,/;/ typo

Reviewed-by: Jason Ekstrand On Tue, Nov 20, 2018 at 11:38 AM Eric Engestrom wrote: > Fixes: 59e58c348e6af16a5f2dd "vulkan/wsi: Only wait on semaphores on the > first swapchain" > Cc: Jason Ekstrand > Signed-off-by: Eric Engestrom > --- > src/vulkan/wsi/wsi_common.c | 4 ++-- > 1 file

Re: [Mesa-dev] [PATCH] Revert "nir/builder: Assert that intN_t immediates fit"

Yeah, I think this is fine. We could expand the assert further to cover all possible casting cases but it's probably not worth it. Reviewed-by: Jason Ekstrand --Jason On Tue, Nov 20, 2018 at 4:14 AM Juan A. Suarez Romero wrote: > On Tue, 2018-11-20 at 09:47 +0100, Iago Toral Quiroga wrote:

Re: [Mesa-dev] [PATCH 0/4] Some prep work for fixing multi context issues in Nouveau

On Tue, Nov 20, 2018 at 2:22 PM Karol Herbst wrote: > > This series cleans up some code in preparation for the real fix and contains > cleanups we want to have regardless. > > The approach in soon to follow patches is to give each contexts its own > nouveau_client, nouveau_pushbuf and fence list

Re: [Mesa-dev] [PATCH] radv: ignore subpass self-dependencies

Reviewed-by: Bas Nieuwenhuizen On Tue, Nov 20, 2018 at 4:41 PM Samuel Pitoiset wrote: > > Unnecessary as they allow the app to call vkCmdPipelineBarrier() > inside the render pass. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pass.c | 10 ++ > 1 file changed, 10

Re: [Mesa-dev] [PATCH] Revert "nir/builder: Assert that intN_t immediates fit"

"Juan A. Suarez Romero" writes: > On Tue, 2018-11-20 at 11:13 +0100, Juan A. Suarez Romero wrote: >> On Tue, 2018-11-20 at 09:47 +0100, Iago Toral Quiroga wrote: >> > This reverts commit . >> > >> > For this to work the compiler must ensure that it never puts >> > the values that arrive to this

[Mesa-dev] [PATCH 4/4] nouveau: access client and pushbuf from context directly

preparation for fixing our multi context issues. Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nv30/nv30_context.c | 4 ++-- src/gallium/drivers/nouveau/nv30/nv30_draw.c | 4 ++-- src/gallium/drivers/nouveau/nv50/nv50_compute.c | 4 ++--

[Mesa-dev] [PATCH 2/4] nouveau: extract nouveau_context functions into a new file

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/Makefile.sources | 1 + src/gallium/drivers/nouveau/meson.build | 1 + src/gallium/drivers/nouveau/nouveau_context.c | 19 +++ src/gallium/drivers/nouveau/nouveau_screen.c | 18 -- 4 files

[Mesa-dev] [PATCH 0/4] Some prep work for fixing multi context issues in Nouveau

This series cleans up some code in preparation for the real fix and contains cleanups we want to have regardless. The approach in soon to follow patches is to give each contexts its own nouveau_client, nouveau_pushbuf and fence list and have operations triggered through a context only use objects

[Mesa-dev] [PATCH 3/4] nv50,nvc0: simplify screen.fence

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 4 ++-- src/gallium/drivers/nouveau/nv50/nv50_screen.h | 1 - src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 4 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 1 - 4 files changed, 4 insertions(+), 6

[Mesa-dev] [PATCH 1/4] nouveau: include all compile dependencies for nouveau_context.h

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nouveau_context.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/nouveau/nouveau_context.h b/src/gallium/drivers/nouveau/nouveau_context.h index c3bbb11bd60..38c19790ec3 100644 ---

Re: [Mesa-dev] [PATCH] gallium/tests/trivial, meson build: Add dep_thread to build dependencies

Am Dienstag, den 20.11.2018, 09:07 -0800 schrieb Dylan Baker: > > > I can't reproduce this in any configuration I can come up with, > what's your meson configuration line? I there a way to get the command line from a configured directory? - because I didn't do it in one go. In fact, I added the

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

I meant Wine games and games ported from DX9 to GL, and all GL games designed for DX9-level hardware. I suggest you simply ignore what the specs are saying. GL was a mess at that time and didn't match what the hardware was capable of. GL and extensions started being reasonably defined for

[Mesa-dev] [PATCH mesa] vulkan/wsi: fix s/,/;/ typo

Fixes: 59e58c348e6af16a5f2dd "vulkan/wsi: Only wait on semaphores on the first swapchain" Cc: Jason Ekstrand Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vulkan/wsi/wsi_common.c

Re: [Mesa-dev] [PATCH mesa 2/2] meson: make passing an invalid pointer a hard error

Quoting Eric Engestrom (2018-11-20 04:36:23) > Signed-off-by: Eric Engestrom > --- > meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meson.build b/meson.build > index fde1cb3b34440f27c6c5..780dbc77ee0ad6f259cb 100644 > --- a/meson.build > +++ b/meson.build > @@ -788,6

Re: [Mesa-dev] [PATCH] gallium/tests/trivial, meson build: Add dep_thread to build dependencies

Quoting Gert Wollny (2018-11-20 03:50:35) > From: Gert Wollny > > When moving the CPU tests to src/util the needed bits were no longer pulled > here in when doing debug builds resulting in > > g++ -o src/gallium/tests/trivial/quad-tex ... > > src/util/libmesa_util.a(u_cpu_detect.c.o): In

Re: [Mesa-dev] [PATCH mesa 00/13] Make standard function available on non-standard platforms

Eric Engestrom writes: > ... instead of making standard platforms use non-standard functions. > > This also reduces the likelihood of someone forgetting to use the > non-standard function, and reduces the fix to a simple #include. Thank you so much for doing this! Reviewed-by: Eric Anholt

Re: [Mesa-dev] [PATCH 10/10] mesa: Remove unneeded bitfield widths from the VAO.

Hi Timothy, On Tuesday, 20 November 2018 12:16:58 CET Timothy Arceri wrote: > I have mixed feeling about the comment as things like that tend to get > out of date. I think this change is fine as is. Ok, so I will leave that as is. > By the way thanks for all your work cleaning all this stuff

[Mesa-dev] [PATCH v1] virgl: add assert and missing function parameter

Verify the pipe_fd_type to be of PIPE_FD_TYPE_NATIVE_SYNC. Suggested-by: Eric Engestrom Signed-off-by: Robert Foss --- src/gallium/drivers/virgl/virgl_context.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_context.c

[Mesa-dev] [PATCH] radv: ignore subpass self-dependencies

Unnecessary as they allow the app to call vkCmdPipelineBarrier() inside the render pass. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pass.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c index

[Mesa-dev] [PATCH] radv: only sync CP DMA for transfer operations or bottom pipe

CP DMA can only be busy when the driver copies buffers. The only affected Vulkan commands are vkCmdCopyBuffer() and vkCmdUpdateBuffer() (because we fallback to a copy depending on a threshold). Clear operations are currently not concerned because the driver always syncs after the last DMA

Re: [Mesa-dev] [PATCH] nir/derefs: Add a nir_derefs_do_not_alias enum value

It's based on the "support casts in comparisons" patch but they're easy enough to reorder. On November 20, 2018 02:07:59 Thomas Helland wrote: It seems this patch is not based on current master? However, it is trivial enough and I like the change, so with a rebase on current master this

Re: [Mesa-dev] [PATCH] nir/from_ssa: fix bit-size of temporary register

Good catch. R-b On November 20, 2018 03:44:21 Iago Toral Quiroga wrote: --- src/compiler/nir/nir_from_ssa.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_from_ssa.c b/src/compiler/nir/nir_from_ssa.c index e13c510c11..8419b28576 100644 ---

Re: [Mesa-dev] [PATCH mesa 1/2] virgl: add missing function parameter

On Tuesday, 2018-11-20 14:36:28 +0100, Robert Foss wrote: > Hey Eric, > > On 2018-11-20 13:36, Eric Engestrom wrote: > > Fixes: d1a1c21e7621b5177feb "virgl: native fence fd support" > > Cc: Robert Foss > > Cc: Emil Velikov > > Signed-off-by: Eric Engestrom > > --- > > I don't know if something

Re: [Mesa-dev] [PATCH mesa 1/2] virgl: add missing function parameter

Hey Eric, On 2018-11-20 13:36, Eric Engestrom wrote: Fixes: d1a1c21e7621b5177feb "virgl: native fence fd support" Cc: Robert Foss Cc: Emil Velikov Signed-off-by: Eric Engestrom --- I don't know if something should be done with the fd type in this function, so one of you might want to send

[Mesa-dev] [PATCH mesa 06/13] util: use standard name for strncmp()

Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/hud/hud_context.c | 2 +- src/util/u_string.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index

[Mesa-dev] [PATCH mesa 07/13] util: use standard name for strcmp()

Signed-off-by: Eric Engestrom --- src/util/u_debug.c | 18 +- src/util/u_string.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/util/u_debug.c b/src/util/u_debug.c index 787d6c255ebbd382d4c9..fde2d60406572fbcf64b 100644 --- a/src/util/u_debug.c

[Mesa-dev] [PATCH mesa 10/13] util: use standard name for vasprintf()

Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/util/u_async_debug.c | 2 +- src/gallium/auxiliary/util/u_log.c | 2 +- src/util/u_string.h| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_async_debug.c

[Mesa-dev] [PATCH mesa 13/13] util: use standard name for vsnprintf()

Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/driver_trace/tr_dump.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_debug.h | 2 +- src/gallium/auxiliary/hud/hud_context.c | 2 +- src/gallium/auxiliary/tgsi/tgsi_dump.c| 2 +- src/gallium/auxiliary/util/u_dump_state.c

[Mesa-dev] [PATCH mesa 12/13] util: use standard name for snprintf()

Signed-off-by: Eric Engestrom --- src/compiler/glsl/ir_builder_print_visitor.cpp | 2 +- src/compiler/glsl/ir_print_visitor.cpp | 12 ++-- src/compiler/glsl/link_interface_blocks.cpp | 4 ++-- src/compiler/glsl/linker.cpp | 2 +-

[Mesa-dev] [PATCH mesa 02/13] util: use standard name for strcasecmp()

Signed-off-by: Eric Engestrom --- src/util/u_string.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/u_string.h b/src/util/u_string.h index cb0895a71a3f50867327..5687fa8aed1ff98287e6 100644 --- a/src/util/u_string.h +++ b/src/util/u_string.h @@ -200,7 +200,7 @@

[Mesa-dev] [PATCH mesa 11/13] util: use standard name for vsprintf()

Signed-off-by: Eric Engestrom --- src/util/u_string.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/u_string.h b/src/util/u_string.h index 28035df44bf1e1ed4de5..3e4807aaba0e29708ecd 100644 --- a/src/util/u_string.h +++ b/src/util/u_string.h @@ -94,6 +94,7 @@

[Mesa-dev] [PATCH mesa 08/13] util: use standard name for strchr()

Signed-off-by: Eric Engestrom --- src/util/u_debug.c | 2 +- src/util/u_string.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/u_debug.c b/src/util/u_debug.c index fde2d60406572fbcf64b..adf62ae9b4a6153c2a2c 100644 --- a/src/util/u_debug.c +++

[Mesa-dev] [PATCH mesa 09/13] util: use standard name for sprintf()

Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/postprocess/pp_mlaa.c | 2 +- src/gallium/auxiliary/util/u_debug_describe.c | 22 +-- .../drivers/freedreno/freedreno_batch.c | 2 +- src/gallium/drivers/svga/svga_msg.c | 2 +-

[Mesa-dev] [PATCH mesa 04/13] util: use standard name for strstr()

Signed-off-by: Eric Engestrom --- src/util/u_string.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/u_string.h b/src/util/u_string.h index d74ce1db8537bda54e48..94080e540d66b9fd8381 100644 --- a/src/util/u_string.h +++ b/src/util/u_string.h @@ -185,6 +185,7 @@

[Mesa-dev] [PATCH mesa 00/13] Make standard function available on non-standard platforms

... instead of making standard platforms use non-standard functions. This also reduces the likelihood of someone forgetting to use the non-standard function, and reduces the fix to a simple #include. Changes generated using this shell function for each function name: fix() { files=$(ag -lw

[Mesa-dev] [PATCH mesa 03/13] util: use standard name for strdup()

Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/util/u_debug_symbol.c | 2 +- src/mesa/program/symbol_table.c | 4 ++-- src/util/u_string.h | 3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH mesa 01/13] util: use standard name for strchrnul()

Signed-off-by: Eric Engestrom --- src/amd/common/ac_debug.c | 2 +- src/gallium/auxiliary/pipe-loader/pipe_loader.c | 2 +- src/gallium/drivers/radeonsi/si_debug.c | 2 +- src/gallium/drivers/radeonsi/si_shader.c| 2 +- src/util/u_string.h

[Mesa-dev] [PATCH mesa 05/13] util: use standard name for strncat()

Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/gallivm/lp_bld_printf.c | 6 +++--- src/util/u_debug.c| 8 src/util/u_string.h | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] meson: Add tests to suites

On Monday, 2018-11-19 13:49:15 -0800, Dylan Baker wrote: > Meson test has a concepts of suites, which allow tests to be grouped > together. This allows for a subtest of tests to be run only (say only > the tests for nir). A test can be added to more than one suite, but for > the most part I've

[Mesa-dev] [PATCH mesa 2/2] meson: make passing an invalid pointer a hard error

Signed-off-by: Eric Engestrom --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index fde1cb3b34440f27c6c5..780dbc77ee0ad6f259cb 100644 --- a/meson.build +++ b/meson.build @@ -788,6 +788,7 @@ endif c_args = [] foreach a :

[Mesa-dev] [PATCH mesa 1/2] virgl: add missing function parameter

Fixes: d1a1c21e7621b5177feb "virgl: native fence fd support" Cc: Robert Foss Cc: Emil Velikov Signed-off-by: Eric Engestrom --- I don't know if something should be done with the fd type in this function, so one of you might want to send another patch to fix this? Otherwise, at least this fixes

[Mesa-dev] [PATCH] gallium/tests/trivial, meson build: Add dep_thread to build dependencies

From: Gert Wollny When moving the CPU tests to src/util the needed bits were no longer pulled here in when doing debug builds resulting in g++ -o src/gallium/tests/trivial/quad-tex ... src/util/libmesa_util.a(u_cpu_detect.c.o): In function `call_once': ../include/c11/threads_posix.h:96:

Re: [Mesa-dev] [PATCH] meson: Add tests to suites

Great! Tested-By: Gert Wollny Am Montag, den 19.11.2018, 13:49 -0800 schrieb Dylan Baker: > Meson test has a concepts of suites, which allow tests to be grouped > together. This allows for a subtest of tests to be run only (say only > the tests for nir). A test can be added to more than one

Re: [Mesa-dev] [PATCH 10/10] mesa: Remove unneeded bitfield widths from the VAO.

On 20/11/18 10:10 pm, Mathias Fröhlich wrote: Hi, Yes thank you. In more actively changed code I guess it would make more sense to leave the bitfield width but as this is unlikely to change much in future you have convinced me its probably not worth leaving it. Thanks. Oh, you mean as it

Re: [Mesa-dev] [PATCH 10/10] mesa: Remove unneeded bitfield widths from the VAO.

Hi, > Yes thank you. In more actively changed code I guess it would make more > sense to leave the bitfield width but as this is unlikely to change much > in future you have convinced me its probably not worth leaving it. Thanks. Oh, you mean as it would have documented what value ranges you

Re: [Mesa-dev] [PATCH 10/10] mesa: Remove unneeded bitfield widths from the VAO.

On 20/11/18 8:51 pm, Mathias Fröhlich wrote: Hi, On Tuesday, 20 November 2018 09:23:53 CET Timothy Arceri wrote: Just curious. Why is this change better? Why not just leave these as is if it's not hurting anything? Well, you mean the unsigned char -> GLubyte? That very similar part Brian

[Mesa-dev] [Bug 108530] [Tracker] Mesa 18.3 Release Tracker

https://bugs.freedesktop.org/show_bug.cgi?id=108530 Andrés Gómez García changed: What|Removed |Added CC||ago...@igalia.com -- You are

Re: [Mesa-dev] [PATCH] Revert "nir/builder: Assert that intN_t immediates fit"

On Tue, 2018-11-20 at 11:13 +0100, Juan A. Suarez Romero wrote: > On Tue, 2018-11-20 at 09:47 +0100, Iago Toral Quiroga wrote: > > This reverts commit . > > > > For this to work the compiler must ensure that it never puts > > the values that arrive to this helper into unsigned variables > > at

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

On 20/11/18 5:46 pm, Marek Olšák wrote: On Tue, Nov 20, 2018 at 12:08 AM Dave Airlie > wrote: On Tue, 20 Nov 2018 at 14:42, Marek Olšák mailto:mar...@gmail.com>> wrote: > > On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen

Re: [Mesa-dev] [PATCH] Revert "nir/builder: Assert that intN_t immediates fit"

On Tue, 2018-11-20 at 09:47 +0100, Iago Toral Quiroga wrote: > This reverts commit . > > For this to work the compiler must ensure that it never puts > the values that arrive to this helper into unsigned variables > at any point in its processing, since that would not apply sign > extension to

Re: [Mesa-dev] [PATCH 24/30] mesa/main: do not allow EXT_texture_sRGB_R8 enums before gles3

Thanks for cleaning up my mess, Reviewed-By: Gert Wollny Am Montag, den 19.11.2018, 13:15 +0100 schrieb Erik Faye-Lund: > ctx->Extensions.EXT_texture_sRGB_R8 is set regardless of the API > that's used, so checking for those direcly will always allow the > enums from this extensions when they

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

On Tue, 2018-11-20 at 10:08 +0100, Erik Faye-Lund wrote: > On Tue, 2018-11-20 at 01:21 -0500, Marek Olšák wrote: > > I'd like to keep ARB_texture_float enabled on drivers that don't > > support linear interpolation. ARB_texture_float is required by DX9, > > which doesn't require linear

Re: [Mesa-dev] [PATCH 10/10] mesa: Remove unneeded bitfield widths from the VAO.

Hi, On Tuesday, 20 November 2018 09:23:53 CET Timothy Arceri wrote: > Just curious. Why is this change better? Why not just leave these as is > if it's not hurting anything? Well, you mean the unsigned char -> GLubyte? That very similar part Brian requested with patch #9. So I assume this is

[Mesa-dev] [PATCH] nir/from_ssa: fix bit-size of temporary register

--- src/compiler/nir/nir_from_ssa.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_from_ssa.c b/src/compiler/nir/nir_from_ssa.c index e13c510c11..8419b28576 100644 --- a/src/compiler/nir/nir_from_ssa.c +++ b/src/compiler/nir/nir_from_ssa.c @@

Re: [Mesa-dev] [PATCH 4/4] i965: Add support for and expose EXT_texture_sRGB_R8

Am Montag, den 19.11.2018, 12:18 -0800 schrieb Mark Janes: > Eric Engestrom writes: > > > Patches 1-3 are: > > Reviewed-by: Eric Engestrom > > > > Patch 4 is: > > Acked-by: Eric Engestrom > > For external contributors, patches like this should not be R-B or > Acked unless they have been

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

On Tue, 2018-11-20 at 01:21 -0500, Marek Olšák wrote: > I'd like to keep ARB_texture_float enabled on drivers that don't > support linear interpolation. ARB_texture_float is required by DX9, > which doesn't require linear interpolation. This logic sounds circular. Since ARB_texture_float *does*

Re: [Mesa-dev] [PATCH] ac/nir: fix intrinsic name string size

Reviewed-by: Bas Nieuwenhuizen On Tue, Nov 20, 2018 at 9:58 AM Samuel Pitoiset wrote: > > Fixes an assertion in SoTTR. > > Fixes: dd0172e865 ("radv: Use structured intrinsics instead of indexing > workaround for GFX9.") > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

wow, I apologize for wording this in a way that looks like an attack :( What I'm primarily concerned with is that this logic is effectively second-guessing addrlib, which breaks when we second-guess the wrong value for pre-existing addrlib (as was the case with the Raven issue), or when addrlib

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

On Mon, 2018-11-19 at 19:17 +, Roland Scheidegger wrote: > FWIW this looks like a rather similar incident to me what happened > when mesa began to verify the max vertex stride (which needs to be > 2048 with GL 4.4 whereas r600 can only do 2047) where I argued it's a > much better idea to lie

[Mesa-dev] [PATCH] ac/nir: fix intrinsic name string size

Fixes an assertion in SoTTR. Fixes: dd0172e865 ("radv: Use structured intrinsics instead of indexing workaround for GFX9.") Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH] Revert "nir/builder: Assert that intN_t immediates fit"

This reverts commit 1f29f4db1e867357a119c0c7c34fb54dc27fb682. For this to work the compiler must ensure that it never puts the values that arrive to this helper into unsigned variables at any point in its processing, since that would not apply sign extension to the value and it would break the

Re: [Mesa-dev] [PATCH 10/10] mesa: Remove unneeded bitfield widths from the VAO.

Just curious. Why is this change better? Why not just leave these as is if it's not hurting anything? On 20/11/18 6:24 pm, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich With the current VAO layout we do not need to make these fields a bitfield. We get a tight struct layout with

[Mesa-dev] [PATCH 03/11] nir: add a new nir_cf_list_clone_and_reinsert() helper

--- src/compiler/nir/nir_control_flow.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compiler/nir/nir_control_flow.h b/src/compiler/nir/nir_control_flow.h index 2ea460e5df..9111b30a29 100644 --- a/src/compiler/nir/nir_control_flow.h +++

[Mesa-dev] [PATCH 09/11] nir: add partial loop unrolling support

This adds partial loop unrolling support and makes use of a guessed trip count based on array access. The code is written so that we could use partial unrolling more generally, but for now it's only use when we have guessed the trip count. We use partial unrolling for this guessed trip count

[Mesa-dev] [PATCH 10/11] nir: calculate trip count for more loops

This adds support to loop analysis for loops where the induction variable is compared to the result of min(variable, constant). For example: for (int i = 0; i < imin(x, 4); i++) ... We add a new bool to the loop terminator struct in order to differentiate terminators with this exit

[Mesa-dev] [PATCH 04/11] nir: make use of new nir_cf_list_clone_and_reinsert() helper

--- src/compiler/nir/nir_opt_loop_unroll.c | 74 ++ 1 file changed, 28 insertions(+), 46 deletions(-) diff --git a/src/compiler/nir/nir_opt_loop_unroll.c b/src/compiler/nir/nir_opt_loop_unroll.c index 0e9966320b..935429add4 100644 ---

[Mesa-dev] [PATCH 02/11] nir: clarify some nit_loop_info member names

Following commits will introduce additional fields such as guessed_trip_count. Renaming these will help avoid confusion as our unrolling feature set grows. --- src/compiler/nir/nir.h | 8 +--- src/compiler/nir/nir_loop_analyze.c| 14 +++---

  1   2   >