Re: [Mesa-dev] [PATCH] util: fix off-by-one when loading source

2019-01-20 Thread Eric Engestrom
On January 19, 2019 11:40:41 PM UTC, Caio Marcelo de Oliveira Filho wrote: > One extra character is leaking from the text into the copied line. > The "+ 1" is an artifact from when malloc was used, strndup will add > the extra '\0' after copying text_size bytes (if available). Yeah, I had that

[Mesa-dev] [Bug 109396] [radeonsi, regression, bisected, d3d trace] NFS Underground - 18.2.8 render fine, flickering present in 18.3.2

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109396 --- Comment #1 from Axel Davy --- Replaying the trace indeed shows the issue, but after playing with the code a bit, and restoring to initial git state, I cannot reproduce the issue. I guess there must some uninitialized memory access and you ca

[Mesa-dev] [Bug 109396] [radeonsi, regression, bisected, d3d trace] NFS Underground - 18.2.8 render fine, flickering present in 18.3.2

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109396 --- Comment #2 from smoki --- I am more than absolutely sure that this is a commit... tried even manually to apply be0bd95abf69920fc11fb50384ffc2f886a5f9e8 on top of fa595e3d0c47be1e91d8d24cce90c756fed23044 and issue appear every time. Did e

[Mesa-dev] [Bug 109396] [radeonsi, regression, bisected, d3d trace] NFS Underground - 18.2.8 render fine, flickering present in 18.3.2

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109396 --- Comment #3 from Stuart Young --- Could this be an LLVM issue like https://bugs.freedesktop.org/show_bug.cgi?id=108594 at all? I note that the fix for that issue in LLVM hasn't yet made it into the llvm in Debian (via release or distro patch

[Mesa-dev] [Bug 109396] [radeonsi, regression, bisected, d3d trace] NFS Underground - 18.2.8 render fine, flickering present in 18.3.2

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109396 --- Comment #4 from smoki --- Well, who knows might be. I will rebuild mesa 18.3.2 against llvm 8 nightly packages from apt.llvm.org and to report if anything happens. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 109396] [radeonsi, regression, bisected, d3d trace] NFS Underground - 18.2.8 render fine, flickering present in 18.3.2

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109396 --- Comment #5 from smoki --- Yeah, corruptions disappeared for this bug too with llvm8 trunk instead of llvm 7.0.1 llvm8 svn351543 that is i tried now... so likely that is. -- You are receiving this mail because: You are the assignee for

Re: [Mesa-dev] [PATCH] util: fix off-by-one when loading source

2019-01-20 Thread Caio Marcelo de Oliveira Filho
On Sun, Jan 20, 2019 at 09:09:56AM +, Eric Engestrom wrote: > Yeah, I had that change locally, but didn't push it :] > > Reviewed-by: Eric Engestrom > > > > > 7c8ee3f0f "util: simplify string duplication logic" > > "Fixes:" ? Fixed "Fixes" and pushed :-) Caio ___

[Mesa-dev] [Bug 109396] [radeonsi, regression, bisected, d3d trace] NFS Underground - 18.2.8 render fine, flickering present in 18.3.2

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109396 --- Comment #6 from smoki --- Actually 18.3.2 and llvm 8 does not like each other, throwing in console: '+vgpr-spilling' is not a recognized feature for this target (ignoring feature) So take previous comment as grain of salt :D --- Comme

[Mesa-dev] [Bug 109401] [DXVK] Project Cars rendering problems

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109401 Bug ID: 109401 Summary: [DXVK] Project Cars rendering problems Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 109401] [DXVK] Project Cars rendering problems

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109401 --- Comment #1 from Gregor Münch --- Created attachment 143172 --> https://bugs.freedesktop.org/attachment.cgi?id=143172&action=edit broken reflections -- You are receiving this mail because: You are the QA Contact for the bug. You are the a

[Mesa-dev] [Bug 109396] [radeonsi, regression, bisected, d3d trace] NFS Underground - 18.2.8 render fine, flickering present in 18.3.2

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109396 --- Comment #8 from smoki --- Git unrelease fixed, so closing. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH v10 09/20] clover: Track flags per module section

2019-01-20 Thread Pierre Moreau
On 2019-01-18 — 16:04, Francisco Jerez wrote: [snip] > > diff --git a/src/gallium/state_trackers/clover/core/module.hpp > > b/src/gallium/state_trackers/clover/core/module.hpp > > index 2ddd26426fb..ff7e9b6234a 100644 > > --- a/src/gallium/state_trackers/clover/core/module.hpp > > +++ b/src/galliu

Re: [Mesa-dev] [PATCH v10 06/20] clover/api: Rework the validation of devices for building

2019-01-20 Thread Pierre Moreau
Thank you for the review. Do you think you’ll have the opportunity to have a look at patches 13 and 16? (Patch 15 is also missing a review, but I found some improvements to be made there.) Thanks, Pierre On 2019-01-18 — 15:52, Francisco Jerez wrote: > Pierre Moreau writes: > > > Reviewed-by: Fr

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #72 from bmil...@gmail.com --- (In reply to Thomas Crider from comment #71) > Created attachment 143118 [details] [review] > patch to make divinity work > > Here's the modified patch that allows the vendor to be set in the driconf > v

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 bmil...@gmail.com changed: What|Removed |Added CC||bmil...@gmail.com -- You are receivi

[Mesa-dev] [PATCH] nv50,nvc0: mark textures dirty on fb update

2019-01-20 Thread Ilia Mirkin
We may have to flush the cache if there are any textures presently bound that refer to the outgoing framebuffer. This is only checked at validation time. Fixes a number of dEQP-GLES3.functional.fbo.color.repeated_clear.sample.* tests, which would bind a texture, then clear it while the binding was

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #73 from Thomas Crider --- the patch works fine here, you may have better luck trying the shim if you're just trying to play the game. you dont need any envvar set with my patch. you just compile mesa with it and play the game. additi

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #74 from Thomas Crider --- 4.2* sorry -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2019-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #75 from bmil...@gmail.com --- Tried the patch again with no luck but the shim worked fine for my rx580. Thanks for the answer. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH] relnotes: Add newly added Vulkan extensions

2019-01-20 Thread Tapani Pälli
Acked-by: Tapani Pälli On 1/19/19 9:11 PM, Jason Ekstrand wrote: Both the Intel and RADV people have been really bad about adding things to the release notes. We should start actually paying attention. --- docs/relnotes/19.0.0.html | 7 +++ 1 file changed, 7 insertions(+) diff --git a/

Re: [Mesa-dev] [PATCH] anv: Only parse pImmutableSamplers if the descriptor has samplers

2019-01-20 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 1/19/19 9:04 PM, Jason Ekstrand wrote: --- src/intel/vulkan/anv_descriptor_set.c | 43 +++ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index

[Mesa-dev] [PATCH 1/4] etnaviv: extend etna_resource with an addressing mode

2019-01-20 Thread Christian Gmeiner
Defines how sampler (and pixel pipes) needs to access the data represented with a resource. The used default is mode is ETNA_ADDRESSING_MODE_TILED. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 17 +++-- src/gallium/drivers/etnaviv/etnaviv_reso

[Mesa-dev] [PATCH 2/4] etnaviv: update headers from rnndb

2019-01-20 Thread Christian Gmeiner
Update to etna_viv commit 4d2f857. Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/hw/cmdstream.xml.h| 8 +- src/gallium/drivers/etnaviv/hw/common.xml.h | 171 +- .../drivers/etnaviv/hw/common_3d.xml.h| 12 +- src/gallium/drivers/etnaviv/hw/isa.xml.h

[Mesa-dev] [PATCH 4/4] etnaviv: hook up linear texture sampling support

2019-01-20 Thread Christian Gmeiner
If the GPU supports linear sampling, linear addressing mode will be used as default. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 10 +++--- src/gallium/drivers/etnaviv/etnaviv_texture.c | 4 +++- 2 files changed, 10 insertions(+), 4 deletions(-) d

[Mesa-dev] [PATCH 3/4] etnaviv: add linear sampling support

2019-01-20 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/etnaviv_texture_state.c | 21 +++ .../drivers/etnaviv/etnaviv_texture_state.h | 1 + 2 files changed, 22 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_texture_state.c b/src/gallium/drivers/etnaviv/etn