Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

2019-05-02 Thread Mathias Fröhlich
Good Morning, On Wednesday, 1 May 2019 21:43:08 CEST Marek Olšák wrote: > BTW, swrast doesn't have to exist on the system. It's not uncommon for me > to have no swrast on my development system. Ok. I see. I use swrast regularly to test changes with different backend drivers. Also especially clas

[Mesa-dev] [AppVeyor] mesa master #11014 failed

2019-05-02 Thread AppVeyor
Build mesa 11014 failed Commit 512a31a412 by Dave Airlie on 4/29/2019 3:17 AM: util/bitset: fix bitset range mask calculations.\n\nThe MASK macro is used in the RANGE macro, and it should\nreturn the pre-bitset word mask for the (b) value.\n\ni.e.\nBITSET_MASK(

Re: [Mesa-dev] [PATCH 03/10] mesa: Implement _mesa_array_element by walking enabled arrays.

2019-05-02 Thread Mathias Fröhlich
Hi Brian, On Friday, 3 May 2019 00:17:51 CEST Brian Paul wrote: > On 05/02/2019 03:27 AM, mathias.froehl...@gmx.net wrote: > > From: Mathias Fröhlich > > > > In glArrayElement, use the bitmask trick to just walk the enabled > > vao arrays. This should be about equivalent in execution time to > >

Re: [Mesa-dev] [PATCH 02/10] mesa: Use glVertexAttrib*NV functions for fixed function attribs.

2019-05-02 Thread Mathias Fröhlich
On Friday, 3 May 2019 00:17:45 CEST Brian Paul wrote: > On 05/02/2019 03:27 AM, mathias.froehl...@gmx.net wrote: > > From: Mathias Fröhlich > > > > In the glArrayElement implementation, use glVertexAttrib*NV type > > functions for fixed function attributes. We do the same in display > > execution

Re: [Mesa-dev] [PATCH 01/10] mesa: Factor out index function that will have multiple use.

2019-05-02 Thread Mathias Fröhlich
Good Morning, On Friday, 3 May 2019 00:17:38 CEST Brian Paul wrote: > On 05/02/2019 03:27 AM, mathias.froehl...@gmx.net wrote: > > From: Mathias Fröhlich > > > > For access to glArrayElement methods factor out a function to > > get the table lookup index for normalized/integer/double access. > >

[Mesa-dev] [PATCH] util/drirc: add workarounds for bugs in Doom 3: BFG

2019-05-02 Thread Timothy Arceri
This makes the game playable on radeonsi. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110143 Cc: "19.0" "19.1" --- src/util/00-mesa-defaults.conf | 5 + 1 file changed, 5 insertions(+) diff --git a/src/util/00-mesa-defaults.conf b/src/util/00-mesa-defaults.conf index f62315498b2

Re: [Mesa-dev] [PATCH] nir: fix lower vars to ssa for larger vector sizes.

2019-05-02 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Thu, May 2, 2019 at 10:25 PM Dave Airlie wrote: > From: Dave Airlie > > This has a couple of hardcoded vec4 limits in it, change them > to the proper sizing to avoid future issues. > --- > src/compiler/nir/nir_lower_vars_to_ssa.c | 8 > 1 file changed,

Re: [Mesa-dev] [PATCH] spirv: fix SpvOpBitSize return value.

2019-05-02 Thread Jason Ekstrand
Drp... Reviewed-by: Jason Ekstrand On Thu, May 2, 2019 at 10:25 PM Dave Airlie wrote: > From: Dave Airlie > > The spir-v spec says this returns a bool. > --- > src/compiler/spirv/vtn_alu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/compiler/spirv/vtn_alu.

[Mesa-dev] [PATCH] nir: fix lower vars to ssa for larger vector sizes.

2019-05-02 Thread Dave Airlie
From: Dave Airlie This has a couple of hardcoded vec4 limits in it, change them to the proper sizing to avoid future issues. --- src/compiler/nir/nir_lower_vars_to_ssa.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_lower_vars_to_ssa.c b/src/co

[Mesa-dev] [PATCH] spirv: fix SpvOpBitSize return value.

2019-05-02 Thread Dave Airlie
From: Dave Airlie The spir-v spec says this returns a bool. --- src/compiler/spirv/vtn_alu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/compiler/spirv/vtn_alu.c b/src/compiler/spirv/vtn_alu.c index d8ffc18d495..6d4347887cd 100644 --- a/src/compiler/spirv/vtn_alu.c

[Mesa-dev] [Bug 110590] [Regression][Bisected] GTAⅣ under wine fails with GLXBadFBConfig

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110590 Hi-Angel changed: What|Removed |Added CC||zegen...@protonmail.com -- You are receivin

[Mesa-dev] [Bug 110590] [Regression][Bisected] GTAⅣ under wine fails with GLXBadFBConfig

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110590 Bug ID: 110590 Summary: [Regression][Bisected] GTAⅣ under wine fails with GLXBadFBConfig Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All

Re: [Mesa-dev] [PATCH 03/10] mesa: Implement _mesa_array_element by walking enabled arrays.

2019-05-02 Thread Brian Paul
On 05/02/2019 03:27 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich In glArrayElement, use the bitmask trick to just walk the enabled vao arrays. This should be about equivalent in execution time to walk the prepare aelt_context list. Finally this will allow us to reduce the _mesa_u

Re: [Mesa-dev] [PATCH 01/10] mesa: Factor out index function that will have multiple use.

2019-05-02 Thread Brian Paul
On 05/02/2019 03:27 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich For access to glArrayElement methods factor out a function to get the table lookup index for normalized/integer/double access. The function will be used in the next patch at least twice. Signed-off-by: Mathias Fröh

Re: [Mesa-dev] [PATCH 02/10] mesa: Use glVertexAttrib*NV functions for fixed function attribs.

2019-05-02 Thread Brian Paul
On 05/02/2019 03:27 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich In the glArrayElement implementation, use glVertexAttrib*NV type functions for fixed function attributes. We do the same in display execution when the list is replayed using immediate mode attribute functions. By th

Re: [Mesa-dev] [PATCH] nir/algebraic: Don't emit empty initializers for MSVC

2019-05-02 Thread Brian Paul
On 05/02/2019 02:34 PM, Connor Abbott wrote: Just don't emit the transform array at all if there are no transforms for a state, and avoid trying to walk over it. --- Brian, does this build on Windows? I tested it on my shader-db on radeonsi. Yes, it compiles. Thanks! Tested-by: Brian Paul T

[Mesa-dev] [Bug 110540] [AMD TAHITI XT] valve artifact broken

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110540 --- Comment #11 from Sylvain BERTRAND --- I did report the regression ages ago: since there is a year in time lag, could be anywhere, even in linux drm or worse, in llvm: https://bugs.freedesktop.org/show_bug.cgi?id=110540 -- You are receiving

[Mesa-dev] [Bug 110540] [AMD TAHITI XT] valve artifact broken

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110540 --- Comment #10 from Samuel Pitoiset --- Okay thanks! Can you fill a new bug report for RoTR? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [Bug 110540] [AMD TAHITI XT] valve artifact broken

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110540 --- Comment #9 from Sylvain BERTRAND --- sorry, it fixed valve artifact only -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev

[Mesa-dev] [Bug 110540] [AMD TAHITI XT] valve artifact broken

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110540 --- Comment #8 from Samuel Pitoiset --- It fixed what? The original report or/and Rise Of The Tomb Raider as well? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

[Mesa-dev] [Bug 110540] [AMD TAHITI XT] valve artifact broken

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110540 --- Comment #7 from Sylvain BERTRAND --- yep, this patch fixed it -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing lis

Re: [Mesa-dev] [PATCH] nir/algebraic: Don't emit empty initializers for MSVC

2019-05-02 Thread Dylan Baker
Quoting Connor Abbott (2019-05-02 13:34:07) > Just don't emit the transform array at all if there are no transforms > for a state, and avoid trying to walk over it. > --- > Brian, does this build on Windows? I tested it on my shader-db > on radeonsi. > > --- > src/compiler/nir/nir_algebraic.py |

[Mesa-dev] [AppVeyor] mesa master #11007 failed

2019-05-02 Thread AppVeyor
Build mesa 11007 failed Commit 1291c68c9c by Eric Engestrom on 4/16/2019 4:06 PM: gitlab-ci: merge meson-glvnd into meson-swr\n\nThere's no need to have a whole build just for that flag, we can add it\nto any build.\n\nv2: Add a note about why we put glvnd wher

[Mesa-dev] [PATCH] nir/algebraic: Don't emit empty initializers for MSVC

2019-05-02 Thread Connor Abbott
Just don't emit the transform array at all if there are no transforms for a state, and avoid trying to walk over it. --- Brian, does this build on Windows? I tested it on my shader-db on radeonsi. --- src/compiler/nir/nir_algebraic.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) di

Re: [Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

2019-05-02 Thread Brian Paul
On 05/02/2019 01:35 PM, Connor Abbott wrote: This will crash at runtime, since it'll construct a "struct transform" with all NULL pointers, and then the loop below in ${pass_name}_block() will see that there's one transform in the array since it uses ARRAY_SIZE and then crash trying to access i

[Mesa-dev] [Bug 110540] [AMD TAHITI XT] valve artifact broken

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110540 --- Comment #6 from Samuel Pitoiset --- Actually, can you try with https://patchwork.freedesktop.org/series/60220/ ? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

[Mesa-dev] [Bug 110540] [AMD TAHITI XT] valve artifact broken

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110540 --- Comment #5 from Sylvain BERTRAND --- no luck, crashing the same way on git c14b13d0ff0d04a2aec239734621fcfa79c629cc (I also have a nasty regression on "rise of the tomb raider", unfortunately, no way to reasonably bisect, this has to be deb

[Mesa-dev] [Bug 110573] Mesa vulkan-radeon 19.0.3 system freeze and visual artifacts (RADV)

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110573 --- Comment #11 from Samuel Pitoiset --- What you can do is to try to record a renderdoc capture with 19.0.2 and see if you can reproduce the problem by replaying it with 19.0.3. You probably need to be a bit lucky to record the right frame. :)

Re: [Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

2019-05-02 Thread Connor Abbott
Whoops, that should be "radeonsi with radeonsi_enable_nir=true" since NIR isn't enabled by default yet. On Thu, May 2, 2019 at 9:35 PM Connor Abbott wrote: > This will crash at runtime, since it'll construct a "struct transform" > with all NULL pointers, and then the loop below in ${pass_name}_b

Re: [Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

2019-05-02 Thread Connor Abbott
This will crash at runtime, since it'll construct a "struct transform" with all NULL pointers, and then the loop below in ${pass_name}_block() will see that there's one transform in the array since it uses ARRAY_SIZE and then crash trying to access it. Running piglit with i965, or radeonsi will re

[Mesa-dev] [AppVeyor] mesa master #11001 failed

2019-05-02 Thread AppVeyor
Build mesa 11001 failed Commit ff4168c418 by Lionel Landwerlin on 2/28/2019 1:02 PM: vulkan/overlay: add TODO list\n\nKeen on having other people contribute.\n\nSigned-off-by: Lionel Landwerlin \nReviewed-by: Eric Engestrom Configure your notificatio

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/5] intel/fs: Lower integer multiply correctly when destination stride equals 4.

2019-05-02 Thread Dylan Baker
Quoting Francisco Jerez (2019-04-29 16:04:19) > Francisco Jerez writes: > > > Because the "low" temporary needs to be accessed with word type and > > twice the original stride, attempting to preserve the alignment of the > > original destination can potentially lead to instructions with illegal >

[Mesa-dev] [PATCH] nir: don't emit empty initializers for MSVC

2019-05-02 Thread Brian Paul
This fixes a build failure with MSVC. --- I've compiled tested this, but not sure how to runtime test it. --- src/compiler/nir/nir_algebraic.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py index 6db749e..dc25421 100

[Mesa-dev] [Bug 110291] Vega 64 GPU hang running Space Engineers

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110291 --- Comment #7 from Peter --- I can't reproduce the hang anymore with latest Mesa. Thanks for your help. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

[Mesa-dev] [Bug 110573] Mesa vulkan-radeon 19.0.3 system freeze and visual artifacts (RADV)

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110573 --- Comment #10 from ant...@gmx.de --- Is there any other trace I can provide for debugging purposes? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

[Mesa-dev] [AppVeyor] mesa staging/19.0 #11000 completed

2019-05-02 Thread AppVeyor
Build mesa 11000 completed Commit b1e4884285 by Samuel Pitoiset on 5/2/2019 12:56 PM: radv: set WD_SWITCH_ON_EOP=1 when drawing primitives from a stream output buffer\n\nAccording to RadeonSI, this seems to be required by the hardware\nto avoid GPU hangs. I thi

Re: [Mesa-dev] [PATCH] docs: link to the meson_options.txt file gitlab.freedesktop.org

2019-05-02 Thread Eric Engestrom
On Monday, 2019-03-11 19:58:42 -0600, Brian Paul wrote: > --- > docs/meson.html | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/docs/meson.html b/docs/meson.html > index 09b45be..08e4d1a 100644 > --- a/docs/meson.html > +++ b/docs/meson.html > @@ -103,7 +103,8 @@ runnin

Re: [Mesa-dev] [PATCH] docs: separate information for compiler selection and compiler options

2019-05-02 Thread Eric Engestrom
On Monday, 2019-03-11 19:52:47 -0600, Brian Paul wrote: > Split up the "Environment Variables" section into "Compiler Options" > and "Compiler Specification". I think this makes the information > easier to find and understand. Reviewed-by: Eric Engestrom > --- > docs/meson.html | 58 > +++

Re: [Mesa-dev] [PATCH] llvmpipe: init some vars to NULL to silence MinGW compiler warnings

2019-05-02 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger Am 01.05.19 um 18:48 schrieb Brian Paul: > --- > src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c > b/src/gallium/auxiliary/gallivm/

Re: [Mesa-dev] [PATCH] docs: document MESA_GLSL=errors keyword

2019-05-02 Thread Eric Engestrom
On Thursday, 2019-04-18 15:58:35 +0200, Alejandro Piñeiro wrote: > Added with commit 0161691f3518, still checked on shaderapi.c > _mesa_get_shader_flag method. Fixes: 0161691f3518db310411 "mesa: add GLSL_REPORT_ERRORS debug flag" Reviewed-by: Eric Engestrom and pushed, thanks! > --- > docs/sha

[Mesa-dev] [PATCH mesa] meson: expose glapi through osmesa

2019-05-02 Thread Eric Engestrom
Suggested-by: Pierre Guillou Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109659 Cc: Brian Paul Cc: Dylan Baker Signed-off-by: Eric Engestrom --- src/gallium/targets/osmesa/meson.build | 4 ++-- src/mesa/drivers/osmesa/meson.build| 3 ++- 2 files changed, 4 insertions(+), 3 delet

[Mesa-dev] [PATCH] radv: fix radv_get_aspect_format() for D+S formats

2019-05-02 Thread Samuel Pitoiset
This restores the previous behaviour before YCBCR landed. For D+S formats, it returns the depth format. This fixes an assertion with Thrones of Britannia. Fixes: 66507cc6563 ("radv: Add single plane image views & meta operations") Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c |

[Mesa-dev] [PATCH] radv: only need to force emit the TCS regs on Vega10 and Ravenv1

2019-05-02 Thread Samuel Pitoiset
Other GFX9 chips aren't affected. Cc: "19.0" "19.1" Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index b4a19aa2e5d..796d78e34f4

[Mesa-dev] [AppVeyor] mesa master #10999 failed

2019-05-02 Thread AppVeyor
Build mesa 10999 failed Commit ad7c9ba0ec by Tomeu Vizoso on 4/22/2019 3:06 PM: panfrost/midgard: Skip liveness analysis for instructions without dest\n\n[Alyssa: Add comment explanation]\n\nSigned-off-by: Tomeu Vizoso \nReviewed-by: Alyssa Rosenzweig

Re: [Mesa-dev] [PATCH] radv: do not need to force emit the TCS regs on Vega20

2019-05-02 Thread Samuel Pitoiset
On 5/2/19 5:35 PM, Marek Olšák wrote: This bug is only on Vega10 and Raven1. Yep, I figured after pushing... I will update the workaround. Thanks Marek! Marek On Wed, May 1, 2019 at 10:10 AM Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: This chip doesn't need the fixup

Re: [Mesa-dev] [PATCH] radv: do not need to force emit the TCS regs on Vega20

2019-05-02 Thread Marek Olšák
This bug is only on Vega10 and Raven1. Marek On Wed, May 1, 2019 at 10:10 AM Samuel Pitoiset wrote: > This chip doesn't need the fixup. This fixes a bunch of > dEQP-VK.tessellation tests and avoid random GPU hangs. > > Cc: "19.0" > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_n

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #19 from Jan Vesely --- (In reply to Eric Engestrom from comment #18) > (In reply to Jan Vesely from comment #17) > > Ideally, meson would use '-Wl,--no-undefined' by default to catch this kind > > of errors. > > It does; it's contr

[Mesa-dev] [AppVeyor] mesa master #10997 failed

2019-05-02 Thread AppVeyor
Build mesa 10997 failed Commit a34ee4dec7 by Eric Engestrom on 4/12/2019 4:47 PM: egl: hard-code destroy function instead of passing it around as a pointer\n\nSigned-off-by: Eric Engestrom \nReviewed-by: Tapani Pälli \nReviewed-by: Emil Velikov Confi

Re: [Mesa-dev] [PATCH v1] panfrost/midgard: Skip register allocation if there's no work to do

2019-05-02 Thread Alyssa Rosenzweig
As I mentioned over IRC, I'm not sure how this case would be possible to hit under normal circumstances. Do you have a sample affected shader? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v1] panfrost/midgard: Skip liveness analysis for instructions without dest

2019-05-02 Thread Alyssa Rosenzweig
Just for future reader's reference, could you add a comment above this line: /* This skips store_vary instructions, which are not yet SSA */ > +if (ins->ssa_args.dest < 0) continue; With that small change, Reviewed-by AR :)

[Mesa-dev] [PATCH v3] ac, radv: remove the vec3 restriction with LLVM 9+

2019-05-02 Thread Samuel Pitoiset
This changes requires LLVM r356755. 32706 shaders in 16744 tests Totals: SGPRS: 1448848 -> 1455984 (0.49 %) VGPRS: 1016684 -> 1016220 (-0.05 %) Spilled SGPRs: 25871 -> 25815 (-0.22 %) Spilled VGPRs: 122 -> 122 (0.00 %) Scratch size: 11964 -> 11956 (-0.07 %) dwords per thread Code Size: 55324500 ->

Re: [Mesa-dev] [PATCH v2] anv: fix alphaToCoverage when there is no color attachment

2019-05-02 Thread Jason Ekstrand
On Thu, May 2, 2019 at 5:46 AM Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsálvez > > There tests in CTS for for alpha to coverage without a color attachment. > First the test draws a primitive with alpha 0 and a subpass with only > a depth buffer. No writes to a depth buffer are expect

[Mesa-dev] [Bug 110291] Vega 64 GPU hang running Space Engineers

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110291 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 110540] [AMD TAHITI XT] valve artifact broken

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110540 --- Comment #4 from Sylvain BERTRAND --- Sure, tonight (UTC+2). I have not started the bisection anyway. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

[Mesa-dev] [Bug 110291] Vega 64 GPU hang running Space Engineers

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110291 --- Comment #5 from Samuel Pitoiset --- Actually, the correct fix should be https://patchwork.freedesktop.org/series/60204/ It fixes the GPU hang on my Vega20. -- You are receiving this mail because: You are the QA Contact for the bug. You ar

[Mesa-dev] [PATCH] radv: set WD_SWITCH_ON_EOP=1 when drawing primitives from a stream output buffer

2019-05-02 Thread Samuel Pitoiset
According to RadeonSI, this seems to be required by the hardware to avoid GPU hangs. I think I just forgot to set that bit when I implemented VK_EXT_transform_feedback. This fixes a GPU hang with Space Engineers and DXVK. Cc: "19.0" "19.1" Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv

[Mesa-dev] [Bug 110291] Vega 64 GPU hang running Space Engineers

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110291 --- Comment #4 from Samuel Pitoiset --- Created attachment 144128 --> https://bugs.freedesktop.org/attachment.cgi?id=144128&action=edit hack Does the attached hack fix the hang for you? -- You are receiving this mail because: You are the QA

[Mesa-dev] [Bug 110573] Mesa vulkan-radeon 19.0.3 system freeze and visual artifacts (RADV)

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110573 --- Comment #9 from Samuel Pitoiset --- Yeah, the trace crashes and doesn't expose the problem for me. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #18 from Eric Engestrom --- (In reply to Jan Vesely from comment #17) > Ideally, meson would use '-Wl,--no-undefined' by default to catch this kind > of errors. It does; it's controlled by `b_lundef`, which is `true` by default, and

[Mesa-dev] [Bug 109202] nv50_ir.cpp:749:19: error: cannot use typeid with -fno-rtti

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109202 Eric Engestrom changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/8] etnaviv: create optional 2d pipe in screen

2019-05-02 Thread Christian Gmeiner
Hi Lucas, Am Fr., 12. Apr. 2019 um 19:38 Uhr schrieb Lucas Stach : > > The 2D pipe is useful to implement fast planar and interleaved YUV buffer > imports. Not all systems have a 2D capable core, so this is strictly > optional. > do you have planed to send out a new version of this patch-set? -

[Mesa-dev] [PATCH v2] anv: fix alphaToCoverage when there is no color attachment

2019-05-02 Thread Iago Toral Quiroga
From: Samuel Iglesias Gonsálvez There tests in CTS for for alpha to coverage without a color attachment. First the test draws a primitive with alpha 0 and a subpass with only a depth buffer. No writes to a depth buffer are expected. Then a second draw with a color buffer and the same depth buffer

[Mesa-dev] [Bug 110573] Mesa vulkan-radeon 19.0.3 system freeze and visual artifacts (RADV)

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110573 --- Comment #8 from osch...@web.de --- I recorded an apitrace of AC:O back in october to help debug a dxvk issue, but at least back then it crashed with apitrace before you could load a savegame, so it might not be possible to reproduce this issu

[Mesa-dev] [Bug 110573] Mesa vulkan-radeon 19.0.3 system freeze and visual artifacts (RADV)

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110573 --- Comment #7 from Samuel Pitoiset --- apitrace will catch D3D11 and then we can replay the trace through Wine/DXVK/RADV. See the DXVK wiki for more info about that. -- You are receiving this mail because: You are the assignee for the bug. Y

[Mesa-dev] [Bug 110573] Mesa vulkan-radeon 19.0.3 system freeze and visual artifacts (RADV)

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110573 --- Comment #6 from james.dut...@gmail.com --- apitrace will not help us here. Use case: ACO (Windows Game) -> Wine -> DXVK -> vulkan apitrace cannot catch vulkan stuff. Is there a better tool to trace the vulkan api ? -- You are receiving t

[Mesa-dev] [PATCH v1] panfrost/midgard: Skip register allocation if there's no work to do

2019-05-02 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index 348ec861404a..d4d26b9a25e9 100644 --

[Mesa-dev] [PATCH v1] panfrost/midgard: Skip liveness analysis for instructions without dest

2019-05-02 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index d4d26b9a25e9..f5d8c3e0f2c1 100644 --- a

[Mesa-dev] [AppVeyor] mesa master #10991 completed

2019-05-02 Thread AppVeyor
Build mesa 10991 completed Commit 13c423629e by Rhys Perry on 4/26/2019 2:39 PM: radv: fix set_output_usage_mask() with composite and 64-bit types\n\nIt previously used var->type instead of deref_instr->type and didn't\nhandle 64-bit outputs.\n\nThis fixes lots

[Mesa-dev] [Bug 110573] Mesa vulkan-radeon 19.0.3 system freeze and visual artifacts (RADV)

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110573 --- Comment #5 from Samuel Pitoiset --- Can you record an apitrace of the problem? I would like to understand it before doing a revert eventually. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

[Mesa-dev] [PATCH 03/10] mesa: Implement _mesa_array_element by walking enabled arrays.

2019-05-02 Thread Mathias . Froehlich
From: Mathias Fröhlich In glArrayElement, use the bitmask trick to just walk the enabled vao arrays. This should be about equivalent in execution time to walk the prepare aelt_context list. Finally this will allow us to reduce the _mesa_update_state calls in a few patches. Signed-off-by: Mathias

[Mesa-dev] [PATCH 04/10] mesa: Rip out now unused gl_context::aelt_context.

2019-05-02 Thread Mathias . Froehlich
From: Mathias Fröhlich Now this part of gl_context state is unused and can be removed. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/r200/r200_context.c | 1 - src/mesa/drivers/dri/radeon/radeon_context.c | 1 - src/mesa/main/api_arrayelt.c | 180

[Mesa-dev] [PATCH 06/10] mesa: Constify static const array in api_arrayelt.c

2019-05-02 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/main/api_arrayelt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/api_arrayelt.c b/src/mesa/main/api_arrayelt.c index 6d4e548e7bd..48b2d9b2357 100644 --- a/src/mesa/main/api_arrayelt.c +++ b/

[Mesa-dev] [PATCH 08/10] mesa: Set CurrentSavePrimitive in vbo_save_NotifyBegin.

2019-05-02 Thread Mathias . Froehlich
From: Mathias Fröhlich That seems to be lost somewhere. Is needed for correct outside begin/end detection in display list compilation. And is needed for correct aliasing in dlists restablished in the next changes. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save_api.c | 2 ++ 1 file c

[Mesa-dev] [PATCH 05/10] mesa: Remove the now unused _NEW_ARRAY state change flag.

2019-05-02 Thread Mathias . Froehlich
From: Mathias Fröhlich Is no longer used, so we have less occasions where NewState is non zero. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_state_upload.c | 1 - src/mesa/main/arrayobj.c | 1 - src/mesa/main/attrib.c | 1 - src

[Mesa-dev] [PATCH 10/10] mesa: Leave aliasing of vertex and generic0 attribute to the dlist code.

2019-05-02 Thread Mathias . Froehlich
From: Mathias Fröhlich Now that dlist compilation again knows if it is inside glBegin/glEnd, we can leave the decision if aliasing should occur to the vertex attribute setter functions instead of doing that at glArrayElement time. Signed-off-by: Mathias Fröhlich --- src/mesa/main/api_arrayelt.

[Mesa-dev] [PATCH 01/10] mesa: Factor out index function that will have multiple use.

2019-05-02 Thread Mathias . Froehlich
From: Mathias Fröhlich For access to glArrayElement methods factor out a function to get the table lookup index for normalized/integer/double access. The function will be used in the next patch at least twice. Signed-off-by: Mathias Fröhlich --- src/mesa/main/api_arrayelt.c | 29 ++

[Mesa-dev] [PATCH 09/10] mesa: Correct the is_vertex_position decision for dlists.

2019-05-02 Thread Mathias . Froehlich
From: Mathias Fröhlich We have to use _mesa_inside_dlist_begin_end instead of _mesa_inside_begin_end to see if we are inside a glBegin/glEnd block in case of display lists. So split the is_vertex_position function used in vertex attribute processing into a imm and dlist variant and use the approp

[Mesa-dev] [PATCH 07/10] mesa: Remove the _glapi_table argument from _mesa_array_element.

2019-05-02 Thread Mathias . Froehlich
From: Mathias Fröhlich The value is now unused. Signed-off-by: Mathias Fröhlich --- src/mesa/main/api_arrayelt.c | 8 +++- src/mesa/main/api_arrayelt.h | 3 +-- src/mesa/vbo/vbo_save_api.c | 17 +++-- 3 files changed, 11 insertions(+), 17 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 00/10] Get rid of _NEW_ARRAY finally.

2019-05-02 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi, This is the second part of the _NEW_ARRAY mesa state bit removal. The code basically unifies the _mesa_array_element implementation by using a cheap to compute vertex attribute setter selection together with the bitmask iteration trick. Once this is in place we can rem

[Mesa-dev] [PATCH 02/10] mesa: Use glVertexAttrib*NV functions for fixed function attribs.

2019-05-02 Thread Mathias . Froehlich
From: Mathias Fröhlich In the glArrayElement implementation, use glVertexAttrib*NV type functions for fixed function attributes. We do the same in display execution when the list is replayed using immediate mode attribute functions. By that use a loop to walk the attributes. Signed-off-by: Mathi

[Mesa-dev] [AppVeyor] mesa staging/19.1 #10990 failed

2019-05-02 Thread AppVeyor
Build mesa 10990 failed Commit 492e828848 by Samuel Pitoiset on 4/26/2019 10:49 AM: ac: tidy up ac_build_llvm8_tbuffer_{load,store}\n\nFor consistency with ac_build_llvm8_buffer_{load,store}_common\nhelpers and that will help a bit for removing the vec3 restric

[Mesa-dev] [Bug 110530] [CTS] dEQP-VK.ycbcr.format.g8_b8_r8_3plane_420* reports VM faults on Vega10

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110530 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 110540] [AMD TAHITI XT] valve artifact broken

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110540 --- Comment #3 from Samuel Pitoiset --- Can you try with latest master? We fixed some ycbcr failures lately. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

Re: [Mesa-dev] [PATCH] glsl: work around MinGW 7.x compiler bug

2019-05-02 Thread Eric Engestrom
On 2019-05-01 at 21:35, Brian Paul wrote: > I'm not sure what triggered this, but building with > scons platform=windows toolchain=crossmingw machine=x86 build=profile > with MinGW g++ 7.3 or 7.4 causes an internal compiler error. > > We can work around it by forcing -O1 optimization. > --- > sr

Re: [Mesa-dev] [PATCH] anv: fix alphaToCoverage when there is no color attachment

2019-05-02 Thread Iago Toral
On Tue, 2019-04-30 at 17:29 -0500, Jason Ekstrand wrote: > On Tue, Apr 30, 2019 at 4:36 AM Iago Toral wrote: > > Hi Jason, > > > > it seems that this was never addressed so I'll try to take it from > > here. A couple of comments regarding your feedback: > > > > We always setup a null render targ

[Mesa-dev] [Bug 110573] Mesa vulkan-radeon 19.0.3 system freeze and visual artifacts (RADV)

2019-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110573 --- Comment #4 from Samuel Pitoiset --- This is really weird, the fix is actually for LLVM 8 and it just breaks... -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

Re: [Mesa-dev] Mesa (staging/19.0): radv: enable descriptor indexing capabilities

2019-05-02 Thread Samuel Pitoiset
On 5/2/19 2:27 AM, Bas Nieuwenhuizen wrote: Well, kinda a fix. Jason noticed that there were parts of the ext I disabled but apparently implementations are required to enable them (see 028ce527395642b68612d10c6030be5d4706a65e). Though, I think this was backported under the assumption that 028c