Marek,
sure, for that part:
Reviewed-by: Mathias Fröhlich
Well, there are really magnitudes of DEBUG defines that are inactive since
meson.
Either let meson builds also define DEBUG or lets
sed -i 's,#ifdef DEBUG,#ifndef NDEBUG,g'
them now?
best
Mathias
On Friday, 10 May 2019 07:21:15
https://bugs.freedesktop.org/show_bug.cgi?id=110673
--- Comment #4 from zhoulei ---
(In reply to Boyuan Zhang from comment #3)
> Hi Zhoulei,
>
> Please use the latest patch to test again:
> https://lists.freedesktop.org/archives/mesa-dev/2019-May/219613.html
>
> Regards,
> Boyuan
I have
On Mon, 2019-05-27 at 16:10 -0400, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeonsi/si_fence.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_fence.c
> b/src/gallium/drivers/radeonsi/si_fence.c
>
Am 27.05.19 um 11:39 schrieb Juan A. Suarez Romero:
> On Fri, 2019-05-24 at 03:08 +0200, srol...@vmware.com wrote:
>> From: Roland Scheidegger
>>
>> The default null_output really needs to be static, otherwise the values
>> we'll eventually get later are doubly random (they are not initialized,
On Mon, May 20, 2019 at 1:04 PM Jan Vesely wrote:
> On Mon, May 13, 2019 at 6:40 PM Marek Olšák wrote:
> >
> > From: Marek Olšák
> >
> > ---
> > src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
> > src/gallium/drivers/radeonsi/si_query.c | 7 ---
> > 2 files changed, 5 insertions(+), 4
From: Marek Olšák
Bugzilla: https://bugzilla.freedesktop.org/show_bug.cgi?id=109754
Cc: 19.0 19.1
---
src/gallium/auxiliary/util/u_blitter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_blitter.c
b/src/gallium/auxiliary/util/u_blitter.c
r-b for the series
On Mon, May 27, 2019 at 5:39 PM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_meta_resolve_cs.c | 56 +--
> 1 file changed, 36 insertions(+), 20 deletions(-)
>
> diff --git
Reviewed-by: Bas Nieuwenhuizen
On Mon, May 27, 2019 at 10:10 PM Marek Olšák wrote:
>
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeonsi/si_fence.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_fence.c
>
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_fence.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_fence.c
b/src/gallium/drivers/radeonsi/si_fence.c
index 1d67fd87b90..6d914a1b184 100644
---
Ping
On Fri, May 10, 2019 at 1:21 AM Marek Olšák wrote:
> From: Marek Olšák
>
> debugoptimized builds don't define NDEBUG, but they also don't define
> DEBUG. We want to enable cheap debug code for these builds.
> I only chose those occurences that I care about.
> ---
>
Reviewed-by: Marek Olšák
Marek
On Mon, May 27, 2019 at 6:07 AM Timothy Arceri
wrote:
> This reverts commit 55376cb31e2f495a4d872b4ffce2135c3365b873.
>
> It's been over a year and both QT 5.9.5 and 5.11.0 contained a fix for the
> original issue. It seems i965 only ever applied this workaround
Reviewed-by: Marek Olšák
Marek
On Sun, May 26, 2019 at 9:57 PM Timothy Arceri
wrote:
> Cc: "19.0" "19.1"
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110711
> ---
> src/util/00-mesa-defaults.conf | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git
https://bugs.freedesktop.org/show_bug.cgi?id=110673
--- Comment #3 from Boyuan Zhang ---
Hi Zhoulei,
Please use the latest patch to test again:
https://lists.freedesktop.org/archives/mesa-dev/2019-May/219613.html
Regards,
Boyuan
--
You are receiving this mail because:
You are the QA Contact
Now that we have the util function for the default values, we can get
rid of the boilerplate.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_screen.c | 157 ---
1 file changed, 157 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c
From: Boyuan Zhang
MaxPicOrderCntLsb should be at least 16 according to the spec,
therefore add minimum value check.
Also use poc value passed from st instead of calculation
in slice header encoding.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110673
Cc:
From: Boyuan Zhang
MaxPicOrderCntLsb should be at least 16 according to the spec,
therefore add minimum value check.
Also use poc value passed from st instead of calculation
in slice header encoding.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110673
Cc:
From: Boyuan Zhang
MaxPicOrderCntLsb should be at 16 according to the spec,
therefore add minimum value check.
Also use poc value passed from st instead of calculation
in slice header encoding.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110673
Cc: mesa-sta...@lists.freedesktop.org
From: Boyuan Zhang
MaxPicOrderCntLsb should be at 16 according to the spec,
therefore add minimum value check.
Also use poc value passed from st instead of calculation
in slice header encoding.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110673
Cc: mesa-sta...@lists.freedesktop.org
On 2019/05/27, mathias.froehl...@gmx.net wrote:
> From: Mathias Fröhlich
>
> Hi Emil,
>
> thanks for that hint to look at _mesa_get_incomplete_framebuffer.
> That one seems definitely more appropriate!
>
> Though, I miss a bit the idea how I can create either a sensible
> helper function for
On Mon, May 27, 2019 at 5:38 PM Samuel Pitoiset
wrote:
>
> Only supported with vkCreateRenderPass2().
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pass.c| 30 +-
> src/amd/vulkan/radv_private.h | 3 +++
> 2 files changed, 32 insertions(+), 1
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_resolve_cs.c | 56 +--
1 file changed, 36 insertions(+), 20 deletions(-)
diff --git a/src/amd/vulkan/radv_meta_resolve_cs.c
b/src/amd/vulkan/radv_meta_resolve_cs.c
index 76612672b1c..67df4800023 100644
---
This makes use of radv_meta_resolve_compute_image() by filling
a VkImageResolve region instead of duplicating code.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_resolve_cs.c | 85 +--
1 file changed, 29 insertions(+), 56 deletions(-)
diff --git
This path supports layers but it requires to decompress HTILE
before resolving. The driver also needs to fixup HTILE after
the resolve. This path is probably slower than the graphics one.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_resolve_cs.c | 491 ++
The driver might need to clear one aspect of the depth/stencil
resolve attachment before performing the resolve itself.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_clear.c | 73
1 file changed, 55 insertions(+), 18 deletions(-)
diff --git
Only supported with vkCreateRenderPass2().
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pass.c| 30 +-
src/amd/vulkan/radv_private.h | 3 +++
2 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_pass.c
It's required to decompress HTILE before resolving with the
compute path.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_resolve.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/src/amd/vulkan/radv_meta_resolve.c
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_device.c | 21 +
src/amd/vulkan/radv_extensions.py | 1 +
2 files changed, 22 insertions(+)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 4203074a4cd..ead6d63f1c5 100644
---
When using graphics, the driver doesn't need to decompress HTILE
before resolving. This path currently doesn't support layers
so we have to fallback to the compute path.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_resolve_fs.c | 597 +-
Only fallback to the compute path for layers.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_resolve.c | 77 +-
1 file changed, 64 insertions(+), 13 deletions(-)
diff --git a/src/amd/vulkan/radv_meta_resolve.c
b/src/amd/vulkan/radv_meta_resolve.c
index
Hi,
This series implements depth/stencil resolves inside a subpass as
required by VK_KHR_depth_stencil_resolve. I implemented all resolve
modes with graphics and compute. Graphics doesn't support layers but
it's not required to decompress HiZ before resolving. While compute
supports layers but it
Reviewed-by: Marek Olšák
M.
On Mon, May 27, 2019, 4:17 AM wrote:
> From: Mathias Fröhlich
>
> Hi Emil,
>
> thanks for that hint to look at _mesa_get_incomplete_framebuffer.
> That one seems definitely more appropriate!
>
> Though, I miss a bit the idea how I can create either a sensible
>
https://bugs.freedesktop.org/show_bug.cgi?id=110761
Jakub Okoński changed:
What|Removed |Added
CC||ja...@okonski.org
--
You are
On Mon, May 27, 2019 at 4:39 AM Erik Faye-Lund
wrote:
>
> On Mon, 2019-05-27 at 13:37 +0200, Erik Faye-Lund wrote:
> > On Mon, 2019-05-27 at 04:23 -0700, Rob Clark wrote:
> > > On Mon, May 27, 2019 at 2:50 AM Erik Faye-Lund
> > > wrote:
> > > > On Sat, 2019-05-25 at 15:44 -0700, Rob Clark wrote:
On Mon, 2019-05-27 at 13:37 +0200, Erik Faye-Lund wrote:
> On Mon, 2019-05-27 at 04:23 -0700, Rob Clark wrote:
> > On Mon, May 27, 2019 at 2:50 AM Erik Faye-Lund
> > wrote:
> > > On Sat, 2019-05-25 at 15:44 -0700, Rob Clark wrote:
> > > > This ends up embedded in a for loop expression, ie. the C
On Mon, 2019-05-27 at 04:23 -0700, Rob Clark wrote:
> On Mon, May 27, 2019 at 2:50 AM Erik Faye-Lund
> wrote:
> > On Sat, 2019-05-25 at 15:44 -0700, Rob Clark wrote:
> > > This ends up embedded in a for loop expression, ie. the C part in
> > > an
> > > for (A;B;C)
> > >
> > > iirc, that means it
On Mon, May 27, 2019 at 2:50 AM Erik Faye-Lund
wrote:
>
> On Sat, 2019-05-25 at 15:44 -0700, Rob Clark wrote:
> > This ends up embedded in a for loop expression, ie. the C part in an
> > for (A;B;C)
> >
> > iirc, that means it needs to be a C expr rather than statement.. or
> > something roughly
r-b
On Wed, May 22, 2019 at 3:35 PM Samuel Pitoiset
wrote:
>
> This helper will be useful for clearing HTILE after some
> depth/stencil resolves.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 7 +--
> src/amd/vulkan/radv_meta.h | 3 +++
>
r-b
On Thu, May 23, 2019 at 2:53 PM Samuel Pitoiset
wrote:
>
> The old code was not wrong because the transitions performed
> after the resolves should re-emit the framebuffer if needed.
>
> This change is mostly a no-op but it improves consistency
> regarding other meta operations that need to
This reverts commit 55376cb31e2f495a4d872b4ffce2135c3365b873.
It's been over a year and both QT 5.9.5 and 5.11.0 contained a fix for the
original issue. It seems i965 only ever applied this workaround to the
18.0 branch.
---
src/mesa/state_tracker/st_context.c| 2 +-
On Sat, 2019-05-25 at 15:44 -0700, Rob Clark wrote:
> This ends up embedded in a for loop expression, ie. the C part in an
> for (A;B;C)
>
> iirc, that means it needs to be a C expr rather than statement.. or
> something roughly like that, I'm too lazy to dig out my C grammar
>
Can't you just
On Fri, 2019-05-24 at 03:08 +0200, srol...@vmware.com wrote:
> From: Roland Scheidegger
>
> The default null_output really needs to be static, otherwise the values
> we'll eventually get later are doubly random (they are not initialized,
> and even if they were it's a pointer to a local stack
On Sun, May 26, 2019 at 01:52:44AM +, Alyssa Rosenzweig wrote:
> I noticed this pattern in glmark's jellyfish scene.
>
> v2: Add inexact qualifier to avoid changing NaN behaviour
>
> I would appreciate if someone did a shader-db run.
>
> Signed-off-by: Alyssa Rosenzweig
Reviewed-by: Elie
Am Sonntag, den 26.05.2019, 21:06 +0200 schrieb Christian Gmeiner:
> Fixes following piglit and does not introduce any regressions.
> spec@ext_packed_depth_stencil@fbo-depth-gl_depth24_stencil8-blit
>
> Signed-off-by: Christian Gmeiner
Reviewed-by: Lucas Stach
> ---
>
R-b
On Mon, May 27, 2019, 10:16 AM Samuel Pitoiset
wrote:
> Based on ANV.
>
> v2: - remove the if statement
> - update the comment
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_meta_resolve.c | 12 +++-
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff
From: Mathias Fröhlich
Hi Emil,
thanks for that hint to look at _mesa_get_incomplete_framebuffer.
That one seems definitely more appropriate!
Though, I miss a bit the idea how I can create either a sensible
helper function for that task or how I can create something above
in the call stack to
Based on ANV.
v2: - remove the if statement
- update the comment
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_resolve.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/src/amd/vulkan/radv_meta_resolve.c
b/src/amd/vulkan/radv_meta_resolve.c
On 5/26/19 2:50 PM, Bas Nieuwenhuizen wrote:
On Wed, May 22, 2019 at 11:20 AM Samuel Pitoiset
wrote:
Based on ANV.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_resolve.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git
On So, 2019-05-26 at 21:45 +0200, Bas Nieuwenhuizen wrote:
> r600g does not have a nir compiler,
I'm working on this in an out of tree bruch, but well, I can always re-
introduce the flag when I start to upstream this, so keep it or leave
it.
Ack-by: Gert Wollny
> and radeonsi does not use
48 matches
Mail list logo
