Re: [Mesa-dev] [PATCH] radv: Only save the descriptor set if we have one.

2019-07-16 Thread Dave Airlie
Reviewed-by: Dave Airlie On Wed, 17 Jul 2019 at 11:01, Bas Nieuwenhuizen wrote: > > After reset, if valid does not contain the relevant bit the descriptor > can be != NULL but still not be valid. > > CC: > --- > src/amd/vulkan/radv_meta.c | 2 +- > 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH] radv: use correct register setter for ngg hw addr

2019-07-16 Thread Dave Airlie
From: Dave Airlie this shouldn't matter, but it's good to be correct. --- src/amd/vulkan/radv_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 5cdfe6d24eb..c7660c2900c 100644 ---

[Mesa-dev] [Bug 111107] 726a31df705b causes pipeline creation to use up to 5x more memory (which is not freed on pipeline destruction)

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=07 --- Comment #2 from Timothy Arceri --- Fix: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1360 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH] radv: Only save the descriptor set if we have one.

2019-07-16 Thread Bas Nieuwenhuizen
After reset, if valid does not contain the relevant bit the descriptor can be != NULL but still not be valid. CC: --- src/amd/vulkan/radv_meta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_meta.c b/src/amd/vulkan/radv_meta.c index

[Mesa-dev] [Bug 110703] libGL conflicts with Exagear's X11

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110703 Timothy Arceri changed: What|Removed |Added Product|Mesa|Spam QA

Re: [Mesa-dev] [PATCH] radv/gfx10: implement VK_EXT_post_depth_coverage

2019-07-16 Thread Bas Nieuwenhuizen
r-b On Tue, Jul 16, 2019 at 5:11 PM Samuel Pitoiset wrote: > > I did implement this extension a while ago but it didn't work > on pre GFX10 for some reasons. Now all CTS pass. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_extensions.py | 1 + >

Re: [Mesa-dev] [PATCH 2/2] radv/gfx10: fallback to the legacy path if tess and extreme geometry

2019-07-16 Thread Bas Nieuwenhuizen
r-b for the series On Tue, Jul 16, 2019 at 4:39 PM Samuel Pitoiset wrote: > > This is unsupported and hangs. > > This fixes GPU hangs with > dEQP-VK.tessellation.geometry_interaction.limits.output_required_*. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pipeline.c | 12

Re: [Mesa-dev] [PATCH] radv/gfx10: disable the TC compat zrange workaround

2019-07-16 Thread Bas Nieuwenhuizen
r-b On Tue, Jul 16, 2019 at 5:35 PM Samuel Pitoiset wrote: > > Unnecessary. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 7 ++- > src/amd/vulkan/radv_device.c | 2 ++ > src/amd/vulkan/radv_image.c | 7 --- > src/amd/vulkan/radv_private.h| 1

[Mesa-dev] [Bug 111151] vkGetRandROutputDisplayEXT returns VK_SUCCESS on failure

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51 Drew DeVault changed: What|Removed |Added CC||kei...@keithp.com, |

[Mesa-dev] [Bug 111151] vkGetRandROutputDisplayEXT returns VK_SUCCESS on failure

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51 Bug ID: 51 Summary: vkGetRandROutputDisplayEXT returns VK_SUCCESS on failure Product: Mesa Version: git Hardware: Other OS: All Status:

[Mesa-dev] [AppVeyor] mesa master #11902 failed

2019-07-16 Thread AppVeyor
Build mesa 11902 failed Commit 856e84083e by Rob Clark on 7/15/2019 4:05 PM: mesa/st: add sampler uniforms\n\nAdd sampler uniforms for the UV plane(s), so driver can count the\nuniforms and get the correct sampler count.\n\nFixes lowered YUV on a6xx which

[Mesa-dev] [Bug 111150] [BRW] WRC 5 asserts with gallium nine and iris.

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50 --- Comment #1 from Nanley Chery --- Is the tiling of the surface X-tiled? My guess is that this commit enables CCS for X-tiled images used for display. This now causes us to fast-clear the image in NineSurface9_ctor. When resource_get_handle

[Mesa-dev] [PATCH] radv/gfx10: disable the TC compat zrange workaround

2019-07-16 Thread Samuel Pitoiset
Unnecessary. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 7 ++- src/amd/vulkan/radv_device.c | 2 ++ src/amd/vulkan/radv_image.c | 7 --- src/amd/vulkan/radv_private.h| 1 + 4 files changed, 13 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH] radv/gfx10: implement VK_EXT_post_depth_coverage

2019-07-16 Thread Samuel Pitoiset
I did implement this extension a while ago but it didn't work on pre GFX10 for some reasons. Now all CTS pass. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_nir_to_llvm.c | 1 + src/amd/vulkan/radv_pipeline.c| 1 +

[Mesa-dev] [PATCH 2/2] radv/gfx10: fallback to the legacy path if tess and extreme geometry

2019-07-16 Thread Samuel Pitoiset
This is unsupported and hangs. This fixes GPU hangs with dEQP-VK.tessellation.geometry_interaction.limits.output_required_*. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 12 src/amd/vulkan/radv_shader.c | 2 +- 2 files changed, 13 insertions(+), 1

[Mesa-dev] [PATCH 1/2] radv/gfx10: always build the GS copy shader but uses it on-demand

2019-07-16 Thread Samuel Pitoiset
It should be possible to build it on-demand too but it requires more work. On GFX10, the GS copy shader is required when tess is enabled with extreme geometry. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 8 src/amd/vulkan/radv_pipeline.c | 21

[Mesa-dev] [Bug 111141] [REGRESSION] [BISECTED] [DXVK] 1-bit booleans and Elite Dangerous shader mis-optimization

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41 --- Comment #6 from Steven Newbury --- GPU is a POLARIS10 (RX470) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing

[Mesa-dev] [Bug 111150] [BRW] WRC 5 asserts with gallium nine and iris.

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50 Illia Iorin changed: What|Removed |Added CC||illia.io...@gmail.com,

[Mesa-dev] [Bug 111150] [BRW] WRC 5 asserts with gallium nine and iris.

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50 Bug ID: 50 Summary: [BRW] WRC 5 asserts with gallium nine and iris. Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 111141] [REGRESSION] [BISECTED] [DXVK] 1-bit booleans and Elite Dangerous shader mis-optimization

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41 --- Comment #5 from Jason Ekstrand --- Could you also please say what GPU you're seeing the corruption on? It might matter and it's certainly needed in order for the RenderDoc taxes to be off any use. -- You are receiving this mail because:

[Mesa-dev] [Bug 111141] [REGRESSION] [BISECTED] [DXVK] 1-bit booleans and Elite Dangerous shader mis-optimization

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41 --- Comment #4 from Steven Newbury --- Created attachment 144802 --> https://bugs.freedesktop.org/attachment.cgi?id=144802=edit RenderDoc capture before commit -- You are receiving this mail because: You are the assignee for the bug. You

[Mesa-dev] [Bug 111141] [REGRESSION] [BISECTED] [DXVK] 1-bit booleans and Elite Dangerous shader mis-optimization

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41 --- Comment #3 from Steven Newbury --- Created attachment 144801 --> https://bugs.freedesktop.org/attachment.cgi?id=144801=edit RenderDoc capture after commit -- You are receiving this mail because: You are the QA Contact for the bug. You

[Mesa-dev] [Bug 111146] Problems with windows full version

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=46 Timothy Arceri changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

[Mesa-dev] [Bug 110703] libGL conflicts with Exagear's X11

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110703 Timothy Arceri changed: What|Removed |Added CC||neonp...@ya.ru --- Comment #9 from

[Mesa-dev] [Bug 111147] Processing of SPIR-V shader leads to display/machine freeze

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47 --- Comment #1 from Alastair Donaldson --- Running the attached test using Amber (https://github.com/google/amber): amber -d unreachable-barrier-in-loops.amber should lead to the test passing. Instead, I find that my system immediately locks

[Mesa-dev] [Bug 111147] Processing of SPIR-V shader leads to display/machine freeze

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47 Bug ID: 47 Summary: Processing of SPIR-V shader leads to display/machine freeze Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All

[Mesa-dev] [Bug 111146] Problems with windows full version

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=46 Bug ID: 46 Summary: Problems with windows full version Product: Mesa Version: unspecified Hardware: Other OS: Windows (All) Status: NEW Severity:

[Mesa-dev] [Bug 111145] Problems with windows

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45 Timothy Arceri changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

[Mesa-dev] [Bug 111145] Problems with windows

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45 Bug ID: 45 Summary: Problems with windows Product: Mesa Version: unspecified Hardware: Other OS: Windows (All) Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] android: radv/gfx10: generate gfx10_format_table.h

2019-07-16 Thread Samuel Pitoiset
Acked-by: Samuel Pitoiset On 7/10/19 9:13 AM, Mauro Rossi wrote: This patch adds gfx10_format_table.h in Makefile.sources and the rules for Android to fix following building errors: In file included from external/mesa/src/amd/vulkan/radv_debug.c:35: In file included from

Re: [Mesa-dev] [PATCH] android: radv/gfx10: generate gfx10_format_table.h

2019-07-16 Thread Mauro Rossi
Hi, kind reminder for Review or Ack, apart from Android makefile changes Makefile.sources was modified to add gfx10_format_table.h generated file. Mauro On Wed, Jul 10, 2019 at 9:13 AM Mauro Rossi wrote: > This patch adds gfx10_format_table.h in Makefile.sources > and the rules for Android to

[Mesa-dev] [PATCH 2/2] radv: update LATE_ALLOC_VS.LIMIT

2019-07-16 Thread Samuel Pitoiset
Mirror RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/si_cmd_buffer.c | 60 -- 1 file changed, 42 insertions(+), 18 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c index a832dbd89eb..e996fa250a9 100644 ---

Re: [Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used

2019-07-16 Thread Newton, Jeremy
Sorry about that, I've only used git email maybe three times in my life :) On 2019-07-15 10:09 a.m., Michel Dänzer wrote: > On 2019-07-15 3:58 p.m., Jeremy Newton wrote: >> Thanks Marek and Michel, see the updated patch below: > FYI, this kind of commentary should be after the --- line, or it

[Mesa-dev] [PATCH 1/2] radv/gfx10: support pixel shaders without exports

2019-07-16 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index fdb0ed29ea4..31495ec078d 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

[Mesa-dev] [Bug 111141] [REGRESSION] [BISECTED] [DXVK] 1-bit booleans and Elite Dangerous shader mis-optimization

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41 --- Comment #2 from Steven Newbury --- Created attachment 144794 --> https://bugs.freedesktop.org/attachment.cgi?id=144794=edit Before commit 3b3081479163475f25b908008250d83c31716c34 -- You are receiving this mail because: You are the QA

[Mesa-dev] [Bug 111141] [REGRESSION] [BISECTED] [DXVK] 1-bit booleans and Elite Dangerous shader mis-optimization

2019-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41 --- Comment #1 from Steven Newbury --- Created attachment 144793 --> https://bugs.freedesktop.org/attachment.cgi?id=144793=edit After commit 3b3081479163475f25b908008250d83c31716c34 -- You are receiving this mail because: You are the

[Mesa-dev] [PATCH] radv: fix gathering clip/cull distance masks for GS

2019-07-16 Thread Samuel Pitoiset
For NGG, the driver relies on the VS outinfo struct. This fixes dEQP-VK.clipping.user_defined.clip_*_vert_tess_geom_* Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c