Re: [Mesa-dev] [PATCH kmscube] texturator: Use !! for boolean assignment

2020-03-31 Thread Fabio Estevam
Hi Jason and Ian, On Tue, Mar 31, 2020 at 5:39 PM Jason Ekstrand wrote: > My feelings aren't usually all that strong on this point though I > generally prefer !=. That said, this is a float. I very strongly > prefer != 0.0f. Thanks for the feedback. I did as suggested: https://gitlab.freedesk

Re: [Mesa-dev] [PATCH kmscube] meson.build: Do not set c_std

2020-03-31 Thread Fabio Estevam
On Tue, Mar 31, 2020 at 10:25 PM Fabio Estevam wrote: > > Hi Rob, > > On Tue, Mar 31, 2020 at 7:40 PM Rob Clark wrote: > > > thx.. I don't suppose I could talk you in to sending a gitlab merge request? > > Please find it at > https://gitlab.freedesktop.org/mesa/kmscube/-/merge_requests/22 Sorry,

Re: [Mesa-dev] [PATCH kmscube] meson.build: Do not set c_std

2020-03-31 Thread Fabio Estevam
Hi Rob, On Tue, Mar 31, 2020 at 7:40 PM Rob Clark wrote: > thx.. I don't suppose I could talk you in to sending a gitlab merge request? Please find it at https://gitlab.freedesktop.org/mesa/kmscube/-/merge_requests/22 Let me know if this is the correct process. Thanks

Re: [Mesa-dev] [PATCH kmscube] meson.build: Do not set c_std

2020-03-31 Thread Fabio Estevam
Hi Rob, On Tue, Mar 31, 2020 at 7:40 PM Rob Clark wrote: > thx.. I don't suppose I could talk you in to sending a gitlab merge request? I never did it, but let me try to learn it how to do it. Thanks ___ mesa-dev mailing list mesa-dev@lists.freedeskt

Re: [Mesa-dev] [PATCH kmscube] meson.build: Do not set c_std

2020-03-31 Thread Rob Clark
On Mon, Mar 30, 2020 at 5:28 PM Fabio Estevam wrote: > > Hi Rob, > > On Mon, Mar 30, 2020 at 6:29 PM Fabio Estevam wrote: > > > > When building kmscube in Buildroot for ARM the following > > errors are seen: > > > > ../common.c: In function 'get_time_ns': > > ../common.c:376:18: error: storage si

Re: [Mesa-dev] [PATCH kmscube] texturator: Use !! for boolean assignment

2020-03-31 Thread Jason Ekstrand
On Tue, Mar 31, 2020 at 3:00 PM Ian Romanick wrote: > > On 3/31/20 12:25 PM, Fabio Estevam wrote: > > The 'complemented' variable is a pointer to boolean. Use the !! operator > > to fix the following build warning: > > > > ../texturator.c:603:45: warning: '*' in boolean context, suggest '&&' > >

Re: [Mesa-dev] [PATCH kmscube] texturator: Use !! for boolean assignment

2020-03-31 Thread Ian Romanick
On 3/31/20 12:25 PM, Fabio Estevam wrote: > The 'complemented' variable is a pointer to boolean. Use the !! operator > to fix the following build warning: > > ../texturator.c:603:45: warning: '*' in boolean context, suggest '&&' instead > [-Wint-in-bool-context] > *complemented = (((float)rgba[

[Mesa-dev] [PATCH kmscube] texturator: Use !! for boolean assignment

2020-03-31 Thread Fabio Estevam
The 'complemented' variable is a pointer to boolean. Use the !! operator to fix the following build warning: ../texturator.c:603:45: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] *complemented = (((float)rgba[2]) / 255.0) / 0.25; Signed-off-by: Fabio Estevam --

[Mesa-dev] [AppVeyor] mesa-webhook master #15103 completed

2020-03-31 Thread AppVeyor
Build mesa-webhook 15103 completed Commit 7a53e67816 by Jason Ekstrand on 3/30/2020 4:25 PM: spirv: Implement OpCopyObject and OpCopyLogical as blind copies\n\nBecause the types etc. are required to logically match, we can just\ncopy-propagate the guts of the v

[Mesa-dev] [AppVeyor] mesa-webhook master #15102 failed

2020-03-31 Thread AppVeyor
Build mesa-webhook 15102 failed Commit 88c046a6d3 by Lionel Landwerlin on 11/26/2019 2:22 PM: isl: don't warn in physical extent calculation for yuv formats\n\nThose format have correct descriptions already with the exception of\nthe planar format. In that case

[Mesa-dev] [PATCH kmscube] texturator: Only define png variable when libpng is present

2020-03-31 Thread Fabio Estevam
When libpng is not present the following build warning is seen: ../texturator.c:98:13: warning: 'png' defined but not used [-Wunused-variable] static bool png; Fix it by only defining the png variable when HAVE_LIBPNG is defined. Signed-off-by: Fabio Estevam --- texturator.c | 2 ++ 1 file ch