Re: [Mesa-dev] [PATCH v5] mesa: Remove gallium draw_arrays() and draw_arrays_instanced() functions

2013-06-07 Thread Arnas Milaševičius
Someone, please, check this patch. On Fri, Jun 7, 2013 at 1:21 AM, Arnas Milasevicius wrote: > > Moved draw_arrays() to st_draw_feedback.c and removed draw_arrays_instanced() > --- > v5: combined patches together > src/gallium/auxiliary/draw/draw_context.h | 11 - > src/gallium/auxiliar

Re: [Mesa-dev] [PATCH] Remove gallium draw_arrays() and draw_arrays_instanced() functions

2013-06-06 Thread Arnas Milaševičius
This is a v2 version, by the way. On Thu, Jun 6, 2013 at 11:56 AM, Arnas Milasevicius wrote: > > Because draw_arrays() is only sued in state_tracker's st_draw_feedback.c > file, I moved it from draw_pt.c to there and mate it static. > --- > v2: removed draw_arrays_instanced() function and modif

Re: [Mesa-dev] [PATCH] Rename api_validate.[ch] to draw_validate.[ch]

2013-06-06 Thread Arnas Milaševičius
So, should I resend it with `git mv` or we will leave this file's name as it is? On Thu, Jun 6, 2013 at 3:23 AM, Brian Paul wrote: > On 06/05/2013 03:25 PM, Kenneth Graunke wrote: > >> On 06/05/2013 12:09 PM, Arnas Milasevicius wrote: >> >>> --- >>> src/mesa/Makefile.sources | 2 +- >>>

Re: [Mesa-dev] [PATCH v3] Rename the _mesa_lookup_enum_by_nr() function Renamed function _mesa_lookup_prim_by_nr() to _mesa_prim_string() _mesa_lookup_enum_by_nr() to _mesa_enum_string() _mesa_lookup_

2013-06-06 Thread Arnas Milaševičius
function in that and that file, because they were together with _mesa_lookup_prim_by_nr() function." I think this patch is good and shouldn't be seperated into 3 parts. On Thu, Jun 6, 2013 at 1:17 AM, Kenneth Graunke wrote: > On 06/05/2013 03:02 PM, Arnas Milaševičius wrote: >

Re: [Mesa-dev] [PATCH v3] Rename the _mesa_lookup_enum_by_nr() function Renamed function _mesa_lookup_prim_by_nr() to _mesa_prim_string() _mesa_lookup_enum_by_nr() to _mesa_enum_string() _mesa_lookup_

2013-06-05 Thread Arnas Milaševičius
And how should I deal with the files, which has all the 3 functions in them? Should I add them in one of the 3 patches or should I add them in all the 3 patches? On Thu, Jun 6, 2013 at 12:24 AM, Kenneth Graunke wrote: > This patch is really doing three related, but independent things: > 1. Renam

Re: [Mesa-dev] [PATCH v2] Renamed functions for file enums.c

2013-06-05 Thread Arnas Milaševičius
_mesa_lookup_enum_by_nr() -> _mesa_enum_string() _mesa_lookup_prim_by_nr() -> _mesa_prim_string() _mesa_lookup_enum_by_name() -> _mesa_enum_value() On Wed, Jun 5, 2013 at 8:20 PM, Eric Anholt wrote: > Arnas Milasevicius writes: > > > _mesa_prim_nr changed in: > > > > src/mesa/main/api_validate

Re: [Mesa-dev] [PATCH v2] Renamed functions for file enums.c

2013-06-05 Thread Arnas Milaševičius
Will it be approved or I need to resend this patch with a better commit massage? On Wed, Jun 5, 2013 at 8:47 PM, Arnas Milaševičius wrote: > _mesa_lookup_enum_by_nr() -> _mesa_enum_string() > _mesa_lookup_prim_by_nr() -> _mesa_prim_string() > _mesa_lookup_enum_by_name() ->

Re: [Mesa-dev] How do I start contributing to Mesa?

2013-06-05 Thread Arnas Milaševičius
Okay, I've sent the patch to the mailing list, I hope it will be accepted. By the way, could someone add some a little bit harder bugs or something to bugzilla for beginners? Not just renaming functions. On Wed, Jun 5, 2013 at 12:44 AM, Arnas Milaševičius wrote: > I've fixed the fi

Re: [Mesa-dev] How do I start contributing to Mesa?

2013-06-04 Thread Arnas Milaševičius
3 21:54, Brian Paul a écrit : >> >>> On 06/04/2013 06:37 AM, Arnas Milaševičius wrote: >>> >>>> Hello, >>>> >>>> First of all, I'm not sure if it's the right place to ask such a >>>> question, but I'll try. I'

[Mesa-dev] How do I start contributing to Mesa?

2013-06-04 Thread Arnas Milaševičius
Hello, First of all, I'm not sure if it's the right place to ask such a question, but I'll try. I've started learning OpenGL and I really want to contribute to Mesa project, but the way to do it had always been a mistery for me. As a beginner contributor, I still don't understand which bugs should