Re: [Mesa-dev] [PATCH] meson: add option to statically link llvm

2018-09-18 Thread Christoph Haag
On 9/18/18 6:56 PM, Dylan Baker wrote: > I can't say I'm entirely thrilled, but: > Reviewed-by: Dylan Baker > > Do you need me to push this for you? > > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mai

[Mesa-dev] [PATCH] meson: add option to statically link llvm

2018-09-17 Thread Christoph Haag
From: Christoph Haag --- meson.build | 4 meson_options.txt | 6 ++ 2 files changed, 10 insertions(+) diff --git a/meson.build b/meson.build index 0588ebf8e7a..5e250470ed1 100644 --- a/meson.build +++ b/meson.build @@ -1188,6 +1188,8 @@ else _llvm_version = '>= 3.3.0

Re: [Mesa-dev] [PATCH] xf86drm: Fix error path in drmGetDevice2

2018-07-29 Thread Christoph Haag
I've reported this here: https://bugs.freedesktop.org/show_bug.cgi?id=107384 The patch in the comments initializing drmDevicePtr device to NULL makes it work properly for me. I don't think the patch is on the mailing list yet. It's probably a good idea to check if there are more places where this

[Mesa-dev] [PATCH] radv: fix VK_EXT_descriptor_indexing

2018-05-20 Thread Christoph Haag
GetPhysicalDeviceProperties2KHR() was crashing because features was null Signed-off-by: Christoph Haag --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index c52b3a591f..d6abab338e

Re: [Mesa-dev] [PATCH] winsys/amdgpu: Set RADEON_FLAG_GTT_WC for UVD buffer

2018-01-26 Thread Christoph Haag
Yes, vaapi decoding works with your patch. On 26.01.2018 13:12, Marek Olšák wrote: > Hi Christoph, > > Can you test this patch instead? > > Thanks, > Marek > > On Fri, Jan 19, 2018 at 3:24 PM, Christoph Haag wrote: >> without this flag, it fails an assertion

[Mesa-dev] [PATCH] meson: Add new picture_{h264, hevc}_enc.c files to meson too

2018-01-25 Thread Christoph Haag
--- Very nice that this finally arrives. Can you add the files to meson too, something like this patch? I can't test it because I only have Polaris here. src/gallium/state_trackers/va/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/m

[Mesa-dev] [PATCH] meson: remove lib prefix from libd3dadapter9.so

2018-01-20 Thread Christoph Haag
--- src/gallium/targets/d3dadapter9/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/d3dadapter9/meson.build b/src/gallium/targets/d3dadapter9/meson.build index 61bb5649ae..5476e80e70 100644 --- a/src/gallium/targets/d3dadapter9/meson.build +++ b/src/gallium/tar

[Mesa-dev] [PATCH] winsys/amdgpu: Set RADEON_FLAG_GTT_WC for UVD buffer

2018-01-19 Thread Christoph Haag
without this flag, it fails an assertion with assertions disabled it retries with this flag set --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c

[Mesa-dev] [PATCH] meson: fix the install path of amdgpu.ids

2018-01-18 Thread Christoph Haag
--- amdgpu/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/amdgpu/meson.build b/amdgpu/meson.build index 55ab9d1d..8b045205 100644 --- a/amdgpu/meson.build +++ b/amdgpu/meson.build @@ -19,7 +19,7 @@ # SOFTWARE. -datadir_amdgpu = join_paths(get_option('datad

Re: [Mesa-dev] [PATCH] mesa: only copy requested compressed teximage faces

2017-08-20 Thread Christoph Haag
It would probably be also good for mesa stable, right? On 20.08.2017 02:07, Ilia Mirkin wrote: > Reviewed-by: Ilia Mirkin > > Will push this out tomorrow unless there are any objections. > > On Sat, Aug 19, 2017 at 7:59 PM, Christoph Haag > wrote: >> From: Chris

[Mesa-dev] [PATCH] mesa: only copy requested compressed teximage faces

2017-08-19 Thread Christoph Haag
From: Christoph Haag This is analogous to commit 2259b11 which missed the compressed case Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102308 Signed-off-by: Christoph Haag --- src/mesa/main/teximage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-21 Thread Christoph Haag
maine Lee wrote: > > Hi Christoph, > > Can you provide an apitrace of the test that crashes? > > Thanks. > -Charmaine > > > From: mesa-dev on behalf of > Christoph Haag > Sent: Friday, July 21, 2017 4:52:41 PM > To:

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-21 Thread Christoph Haag
This patch breaks steam for me. Segfault backtrace: #0 0x0023 in ?? () No symbol table info available. #1 0xf6b1a417 in _mesa_hash_table_search (ht=0x585bb7e8, key=0x5820ee88) at hash_table.c:246 __PRETTY_FUNCTION__ = "_mesa_hash_table_search" #2 0xf6a4488e in st_framebuffer_iface_

[Mesa-dev] [PATCH v2] gallium/hud: use double values for all graphs

2017-07-14 Thread Christoph Haag
rounding. Using doubles also allows the hud to show small variations instead of being clamped to discrete values. v2: Don't print decimals in the dump file when not necessary Signed-off-by: Christoph Haag --- src/gallium/auxiliary/hud/hud_context.c | 14 ++ src/gallium/auxiliar

[Mesa-dev] [PATCH 1/1] gallium/hud: use double values for all graphs

2017-06-17 Thread Christoph Haag
ing to integer improves the fps graph, but it may be useful to inspect fps variations more closely by increasing the width and height of the graphs. Signed-off-by: Christoph Haag --- src/gallium/auxiliary/hud/hud_context.c | 6 +++--- src/gallium/auxiliary/hud/hud_fps.c | 4 ++-- src/g

[Mesa-dev] [PATCH 0/1] gallium/hud: use double values for all graphs

2017-06-17 Thread Christoph Haag
t but curiously hud_graph_add_value() casts the value to float for drawing the graph and number_to_human_readable() casts the value to double for displaying the number below the graph, so using always a double value doesn't even change much. Christoph Haag (1): gallium/hud: use double values

[Mesa-dev] [PATCH v2] ac: fix build after LLVM 5.0 SVN r300718

2017-04-20 Thread Christoph Haag
v2: previously getWithDereferenceableBytes() exists, but addAttr() doesn't take that type Signed-off-by: Christoph Haag --- src/amd/common/ac_llvm_helper.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/common/ac_llvm_helper.cpp b/src/amd/common/ac_llvm_helper.cpp

[Mesa-dev] [PATCH] ac: fix build after LLVM 5.0 SVN r300718

2017-04-20 Thread Christoph Haag
From: Christoph Haag Signed-off-by: Christoph Haag --- src/amd/common/ac_llvm_helper.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/common/ac_llvm_helper.cpp b/src/amd/common/ac_llvm_helper.cpp index d9ea4b162e..69d65ddffe 100644 --- a/src/amd/common

[Mesa-dev] [PATCH] doc: document GALLIUM_DRIVER

2016-09-08 Thread Christoph Haag
v2: Add dot at end of sentence --- docs/envvars.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 789f5e9..cf57ca5 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -217,6 +217,8 @@ Mesa EGL supports different sets of environment variabl

[Mesa-dev] [PATCH] doc: document GALLIUM_DRIVER

2016-09-08 Thread Christoph Haag
--- docs/envvars.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 789f5e9..24f4d0d 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -217,6 +217,8 @@ Mesa EGL supports different sets of environment variables. See the disable for

[Mesa-dev] [PATCH] doc: fix typo of GALLIUM_HUD_TOGGLE_SIGNAL

2016-09-06 Thread Christoph Haag
From: Christoph Haag In the original commit message in 56a1c10 it was wrongly used too: - env GALLIUM_HUD_SIGNAL_TOGGLE: toggle visibility via signal --- docs/envvars.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/envvars.html b/docs/envvars.html index 6d79398