Re: [Mesa-dev] [PATCH v3 2/4] gallium/auxiliary: Add helper support for bptc format compress/decompress

s/6774 > > Marek > > On Tue, Sep 22, 2020 at 4:33 AM Denis Pauk wrote: > >> Hi Dave, >> >> Could you please check >> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6809/diffs ? >> >> It contains possible fixes for bptc rgba unorm. Bug is rela

Re: [Mesa-dev] [PATCH v3 2/4] gallium/auxiliary: Add helper support for bptc format compress/decompress

23, 2020 at 12:47 PM Denis Pauk wrote: > Hi Dave, > > I had tested code before only with bptc-modes and bptc-float-modes from > piglit. It was free time project, so no real tests. > > Code had reused implementation from intel classic driver if i correctly > remember. >

Re: [Mesa-dev] [PATCH v3 2/4] gallium/auxiliary: Add helper support for bptc format compress/decompress

, 2020 at 10:26 AM Dave Airlie wrote: > On Wed, 27 Jun 2018 at 06:36, Denis Pauk wrote: > > > > Reuse code shared with mesa/main/texcompress_bptc. > > > > v2: Use block decompress function > > v3: Include static bptc code from texcompress_bptc_tmp.h

[Mesa-dev] [PATCH v2 2/2] docs/features: mark GL_ARB_texture_compression_bptc as done for llvmpipe, softpipe, swr

Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry CC: Bruce Cherniak CC: Matt Turner --- docs/features.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index 9ccf803d47..ce6595320c 100644 --- a/docs/features.txt +++ b/docs

[Mesa-dev] [PATCH v2 1/2] gallium/swr: Enable support bptc format.

Reuse Code from: f69bc797e1 gallium/auxiliary: Add helper support for bptc format compress/decompress Signed-off-by: Denis Pauk Reviewed-by: Bruce Cherniak CC: Marek Olšák CC: Tim Rowley --- src/gallium/drivers/swr/swr_screen.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[Mesa-dev] (no subject)

Hi! Could you please review changes? And could you also merge changes if it is ok. First patch is already reviewed by Bruce Cherniak and does not have any changes. Second patch contains updates for docs/features.txt for status bptc support. [PATCH v2 1/2] gallium/swr: Enable support bptc

[Mesa-dev] [PATCH 1/2] gallium/swr: Enable support bptc format.

Reuse Code from: f69bc797e1 gallium/auxiliary: Add helper support for bptc format compress/decompress Signed-off-by: Denis Pauk Reviewed-by: Bruce Cherniak CC: Marek Olšák CC: Tim Rowley --- src/gallium/drivers/swr/swr_screen.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 2/2] docs/features: mark GL_ARB_texture_compression_bptc as done for llvmpipe, softpipe, swr

Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry CC: Bruce Cherniak CC: Matt Turner --- docs/features.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index 9ccf803d47..ce6595320c 100644 --- a/docs/features.txt +++ b/docs

Re: [Mesa-dev] [PATCH] gallium/swr: Enable support bptc format.

Hi, Could you please merge patch to master? On Wed, Aug 1, 2018 at 10:33 PM Denis Pauk wrote: > Hi Bruce, > > Thank you. Best wishes to Alok. > > Could someone also update docs/features.txt with bptc/astc support? Look > like we can mark bptc as done for all galliu

Re: [Mesa-dev] [PATCH] gallium/swr: Enable support bptc format.

, Bruce wrote: > > On Aug 1, 2018, at 8:10 AM, Denis Pauk wrote: > > Hi Marek, > > Could you merge this changes to master? Or someone else with push rights? > > Do mesa have some formal rule what amount of commits/contribution required > for recieve "merge" rig

Re: [Mesa-dev] [PATCH] gallium/swr: Enable support bptc format.

Hi Marek, Could you merge this changes to master? Or someone else with push rights? Do mesa have some formal rule what amount of commits/contribution required for recieve "merge" rights? On Sat, Jul 28, 2018 at 11:03 PM Denis Pauk wrote: > Hi Bruce, > > Thank you, cou

Re: [Mesa-dev] [PATCH] gallium/swr: Enable support bptc format.

Hi Bruce, Thank you, could you please merge commits? (I don't have commit rights.) On Fri, Jul 27, 2018 at 11:02 PM Cherniak, Bruce wrote: > Reviewed-by: Bruce Cherniak > > > On Jul 27, 2018, at 1:45 PM, Denis Pauk wrote: > > > > Reuse Code from: > > f69bc797e1

[Mesa-dev] [PATCH] gallium/swr: Enable support bptc format.

Reuse Code from: f69bc797e1 gallium/auxiliary: Add helper support for bptc format compress/decompress Signed-off-by: Denis Pauk CC: Marek Olšák CC: Bruce Cherniak CC: Tim Rowley --- src/gallium/drivers/swr/swr_screen.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v3 4/4] gallium/llvmpipe: Enable support bptc format.

Thank you. Best regards, Denis. On Sun, Jul 1, 2018, 10:44 PM Marek Olšák wrote: > Pushed, thanks for the patches. > > Marek > > On Sun, Jul 1, 2018 at 2:25 AM, Denis Pauk wrote: > > HI Marek, > > > > Thank you, could you merge commits? &g

Re: [Mesa-dev] [PATCH v3 4/4] gallium/llvmpipe: Enable support bptc format.

HI Marek, Thank you, could you merge commits? I don't have commit rights. On Sat, Jun 30, 2018 at 12:29 AM Marek Olšák wrote: > For the series: > > Reviewed-by: Marek Olšák > > Marek > > On Tue, Jun 26, 2018 at 4:30 PM, Denis Pauk wrote: > > v2: none >

Re: [Mesa-dev] [PATCH v3 0/4] Add support GL_ARB_texture_compression_bptc in llvmpipe and softpipe.

If someone can test I can also add support for bptc to swr tracker. (I have no access to Intel CPUs with avx* support.) Best regards, Denis. On Tue, Jun 26, 2018, 11:44 PM Denis Pauk wrote: > Sorry for mess, i forgot to send cover letter and used "git send-email -

Re: [Mesa-dev] [PATCH v3 0/4] Add support GL_ARB_texture_compression_bptc in llvmpipe and softpipe.

same patches. On Tue, Jun 26, 2018 at 11:31 PM Denis Pauk wrote: > This series add code for reuse in gallium bptc decode logic from > mesa/main/texcompress_bptc.c. > > Checked on x86_64 by: > * LIBGL_ALWAYS_SOFTWARE=true GALLIUM_DRIVER={llvmpipe,softpipe} > * piglit/bin/bpt

[Mesa-dev] [PATCH v3 4/4] gallium/llvmpipe: Enable support bptc format.

v2: none v3: none Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry CC: Matt Turner --- src/gallium/drivers/llvmpipe/lp_screen.c | 3 +-- src/gallium/drivers/llvmpipe/lp_test_format.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH v3 3/4] gallium/softpipe: Enable support bptc format.

v2: none v3: none Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry --- src/gallium/drivers/softpipe/sp_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index 8fbcbc8bac

[Mesa-dev] [PATCH v3 2/4] gallium/auxiliary: Add helper support for bptc format compress/decompress

Reuse code shared with mesa/main/texcompress_bptc. v2: Use block decompress function v3: Include static bptc code from texcompress_bptc_tmp.h Suggested-by: Marek Olšák Signed-off-by: Denis Pauk CC: Nicolai Hähnle CC: Marek Olšák CC: Gert Wollny --- src/gallium/auxiliary

[Mesa-dev] [PATCH v3 1/4] mesa: add header for share bptc decompress functions

block decompress function v3: Move all shared code to header Suggested-by: Marek Olšák Signed-off-by: Denis Pauk CC: Marek Olšák --- src/mesa/Makefile.sources|1 + src/mesa/main/texcompress_bptc.c | 1451 + src/mesa/main/texcompress_bptc_tmp.h | 1743

[Mesa-dev] [PATCH v3 0/4] Add support GL_ARB_texture_compression_bptc in llvmpipe and softpipe.

This series add code for reuse in gallium bptc decode logic from mesa/main/texcompress_bptc.c. Checked on x86_64 by: * LIBGL_ALWAYS_SOFTWARE=true GALLIUM_DRIVER={llvmpipe,softpipe} * piglit/bin/bptc-float-modes * piglit/bin/bptc-modes * piglit/bin/compressedteximage

[Mesa-dev] [PATCH v3 2/4] gallium/auxiliary: Add helper support for bptc format compress/decompress

Reuse code shared with mesa/main/texcompress_bptc. v2: Use block decompress function v3: Include static bptc code from texcompress_bptc_tmp.h Suggested-by: Marek Olšák Signed-off-by: Denis Pauk CC: Nicolai Hähnle CC: Marek Olšák CC: Gert Wollny --- src/gallium/auxiliary

[Mesa-dev] [PATCH v3 4/4] gallium/llvmpipe: Enable support bptc format.

v2: none v3: none Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry CC: Matt Turner --- src/gallium/drivers/llvmpipe/lp_screen.c | 3 +-- src/gallium/drivers/llvmpipe/lp_test_format.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH v3 3/4] gallium/softpipe: Enable support bptc format.

v2: none v3: none Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry --- src/gallium/drivers/softpipe/sp_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index 8fbcbc8bac

[Mesa-dev] [PATCH v3 1/4] mesa: add header for share bptc decompress functions

block decompress function v3: Move all shared code to header Suggested-by: Marek Olšák Signed-off-by: Denis Pauk CC: Marek Olšák --- src/mesa/Makefile.sources|1 + src/mesa/main/texcompress_bptc.c | 1451 + src/mesa/main/texcompress_bptc_tmp.h | 1743

Re: [Mesa-dev] [PATCH v2 1/4] mesa: add header for share bptc decompress functions

conflicts. > > Marek > > > > On Sat, Jun 23, 2018 at 9:19 AM, Denis Pauk wrote: > > Make functions public: > > * fetch_rgba_unorm_from_block > > * fetch_rgb_float_from_block > > * compress_rgba_unorm > > * compress_rgb_float > > > > Creat

[Mesa-dev] [PATCH v2 2/4] gallium/auxiliary: Add helper support for bptc format compress/decompress

Reuse code shared with mesa/main/texcompress_bptc. v2: Use block decompress function Signed-off-by: Denis Pauk CC: Nicolai Hähnle CC: Marek Olšák CC: Gert Wollny --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/meson.build| 2 + src/gallium

[Mesa-dev] [PATCH v2 4/4] gallium/llvmpipe: Enable support bptc format.

v2: none Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry CC: Matt Turner --- src/gallium/drivers/llvmpipe/lp_screen.c | 3 +-- src/gallium/drivers/llvmpipe/lp_test_format.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/llvmpipe

[Mesa-dev] [PATCH v2 1/4] mesa: add header for share bptc decompress functions

-off-by: Denis Pauk CC: Marek Olšák --- src/mesa/Makefile.sources | 1 + src/mesa/main/texcompress_bptc.c | 303 - src/mesa/main/texcompress_bptc_share.h | 58 + 3 files changed, 358 insertions(+), 4 deletions(-) create mode 100644 src/mesa/main

[Mesa-dev] [PATCH v2 3/4] gallium/softpipe: Enable support bptc format.

v2: none Signed-off-by: Denis Pauk CC: Marek Olšák CC: Rhys Perry --- src/gallium/drivers/softpipe/sp_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index 8fbcbc8bac

[Mesa-dev] [PATCH v2 0/4] Add support GL_ARB_texture_compression_bptc in llvmpipe and softpipe.

This series add code for reuse in gallium bptc decode logic from mesa/main/texcompress_bptc.c. Checked on x86_64 by: * LIBGL_ALWAYS_SOFTWARE=true GALLIUM_DRIVER={llvmpipe,softpipe} * piglit/bin/bptc-float-modes * piglit/bin/bptc-modes * piglit/bin/compressedteximage

[Mesa-dev] [PATCH 3/4] gallium/softpipe: Enable support bptc format.

--- src/gallium/drivers/softpipe/sp_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index f9c916d938..676cd0812a 100644 --- a/src/gallium/drivers/softpipe/sp_screen.c +++

[Mesa-dev] [PATCH 4/4] gallium/llvmpipe: Enable support bptc format.

--- src/gallium/drivers/llvmpipe/lp_screen.c | 3 +-- src/gallium/drivers/llvmpipe/lp_test_format.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c index f12ad09298..c1a2fd3379 100644

[Mesa-dev] [PATCH 2/4] gallium/auxiliary: Add helper support for bptc format compress/decompress

Reuse code shared with mesa/main/texcompress_bptc. --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/meson.build| 2 + src/gallium/auxiliary/util/u_format_bptc.c | 322 +++ src/gallium/auxiliary/util/u_format_bptc.h | 122 +++

[Mesa-dev] Add support GL_ARB_texture_compression_bptc in llvmpipe and softpipe.

Add code for reuse bptc decode logic from mesa/main/texcompress_bptc.c by make several function public(nonstatic) and define functions in texcompress_bptc_share.h. I have made minimal changes in code without possible performance improvements. And code decodes image by pixels instead possible

[Mesa-dev] [PATCH 1/4] mesa: add header for share bptc decompress functions

Make functions public: * fetch_rgba_unorm_from_block * fetch_rgb_float_from_block * compress_rgba_unorm * compress_rgb_float Functions will be reused in gallium/auxiliary code. --- src/mesa/Makefile.sources | 1 + src/mesa/main/texcompress_bptc.c | 9 ++---

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

Hi! As for me, patch is too minor and be in future 18.+ release is enough, As i know application can't cause segfault by public API by this path(only by private api). On Tue, Nov 28, 2017 at 4:48 PM, Marek Olšák wrote: > On Tue, Nov 28, 2017 at 3:46 PM, Emil Velikov

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

Thank you. I have closed https://bugs.freedesktop.org/show_bug.cgi?id=102552 Best regards, Denis. On Sep 14, 2017 2:01 AM, "Marek Olšák" <mar...@gmail.com> wrote: > I pushed the patch. Thanks. > > Marek > > On Wed, Sep 13, 2017 at 9:27 PM, D

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

ák <mar...@gmail.com> wrote: > I've changed my mind. The patch is OK: > > Reviewed-by: Marek Olšák <marek.ol...@amd.com> > > Marek > > On Wed, Sep 13, 2017 at 4:45 PM, Denis Pauk <pauk.de...@gmail.com> wrote: > > What do you think about

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

What do you think about replace all checks in patch to asserts? Best regards, Denis. On Sep 13, 2017 1:00 PM, "Marek Olšák" wrote: > On Wed, Sep 13, 2017 at 6:54 AM, Денис Паук wrote: > > Do you mean delete check in u_format.c::

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

This only example of code, that we can use for check is_format_supported call. Its not real world code. Best regards, Denis. On Sep 13, 2017 11:15 AM, "Nicolai Hähnle" <nhaeh...@gmail.com> wrote: > On 13.09.2017 08:26, Denis Pauk wrote: > >

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

d therefore drivers don't >> > have to work around it. >> >> Or any other invalid formats, for that matter. >> >> Marek >> >> > >> > Marek >> > >> > On Tue, Sep 12, 2017 at 10:38 PM, Denis Pauk <pauk.de...@

[Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102552 v2: Patch cleanup proposed by Nicolai Hähnle. * deleted changes in si_translate_texformat. Cc: Nicolai Hähnle Cc: Ilia Mirkin --- src/gallium/auxiliary/util/u_format.c| 4

[Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102552 --- src/gallium/auxiliary/util/u_format.c| 4 src/gallium/drivers/r600/r600_state_common.c | 4 src/gallium/drivers/radeonsi/si_state.c | 13 - 3 files changed, 20 insertions(+), 1 deletion(-) diff