Re: [Mesa-dev] last call for autotools

2018-12-12 Thread Dylan Baker
Quoting Marek Olšák (2018-12-12 12:42:01) > Most assertions and checks are enabled, because NDEBUG is not defined, but > DEBUG is not defined either, which is a Mesa-specific definition. > > The default debug build for autotools is debugoptimized (-g -O2 -DDEBUG). > meson > changed that behavior

Re: [Mesa-dev] last call for autotools

2018-12-12 Thread Dylan Baker
Quoting Marek Olšák (2018-12-12 13:07:10) > On Wed, Dec 12, 2018 at 3:52 PM Rob Clark wrote: > > On Wed, Dec 12, 2018 at 3:45 PM Marek Olšák wrote: > > > > On Wed, Dec 12, 2018 at 3:37 PM Rob Clark wrote: > >> > >> On Wed, Dec 12, 2018 at 3:13 PM Bas Nieuwenhuizen > >>

Re: [Mesa-dev] [PATCH 2/2] Fix typo preventing xxf86vm being used in meson build

2018-12-12 Thread Dylan Baker
x11_xcb, dep_xcb_dri2, dep_xext, dep_xfixes, dep_xdamage, > + dep_x11_xcb, dep_xcb_dri2, dep_xext, dep_xfixes, dep_xdamage, > dep_xxf86vm, >extra_deps_libgl, > ], > version : gl_lib_version, > -- > 2.17.0 > Reviewed-by: Dylan Baker signature.asc

Re: [Mesa-dev] [RFC PATCH 0/5] last call for autotools (meson travis fixes)

2018-12-12 Thread Dylan Baker
Quoting Emil Velikov (2018-12-12 04:16:51) > On Wed, 12 Dec 2018 at 07:45, Rhys Kidd wrote: > > > > Emil and Dylan, > > > > I took a go at addressing the limited number of remaining meson-based > > travis-ci errors. This series applies on top of the work Dylan circulated > > yesterday, and which

Re: [Mesa-dev] [RFC PATCH 5/5] meson: libfreedreno depends upon libdrm (for fence support)

2018-12-12 Thread Dylan Baker
Thanks for looking into these. I've gone ahead and added the Fixes and Emil's rb, plus my rb and pushed *this* patch to master. I've pulled all of the others except the "delete me" fixup into my branch (since I'll drop that patch before sending out the v2, that's just to make travis turn around

Re: [Mesa-dev] last call for autotools

2018-12-11 Thread Dylan Baker
Quoting Emil Velikov (2018-12-11 10:48:56) > On Tue, 11 Dec 2018 at 18:18, Eric Anholt wrote: > > > > Emil Velikov writes: > > > > > On Mon, 10 Dec 2018 at 23:11, Dylan Baker wrote: > > >> > > >> Meson 0.49.0 has been out for a couple of d

Re: [Mesa-dev] [PATCH v2] glx: mandate xf86vidmode only for "drm" dri platforms

2018-12-11 Thread Dylan Baker
pendency. > > v2: terminate the GLX_USE_WINDOWSGL hunk > > Cc: Jon TURNEY > Cc: Dylan Baker > Cc: Eric Engestrom > Fixes: 5bc509363b6 ("glx: make xf86vidmode mandatory for direct rendering") > Signed-off-by: Emil Velikov > --- > This time it's actually tes

Re: [Mesa-dev] [PATCH mesa] meson/vdpau: add missing soversion

2018-12-11 Thread Dylan Baker
Thanks for fixing this, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-12-11 09:13:54) > This mirrors what autotools does in > src/gallium/state_trackers/vdpau/Makefile.am > and src/gallium/targets/vdpau/Makefile.am: > > VDPAU_MAJOR = 1 >

[Mesa-dev] last call for autotools

2018-12-10 Thread Dylan Baker
Meson 0.49.0 has been out for a couple of days now, and I'd like to make the final call for autotools. My patch is so massive that it's a huge pain to send to the list, the latest versions is here: https://gitlab.freedesktop.org/dbaker/mesa/commits/delete-autotools Dylan signature.asc

Re: [Mesa-dev] [PATCH] docs: extends 18.2 lifecycle

2018-12-10 Thread Dylan Baker
Acked-by: Dylan Baker Quoting Juan A. Suarez Romero (2018-12-10 04:25:36) > As 18.3 was published with some delay, let's extend 18.2 life for > another extra release. > > CC: Andres Gomez > CC: Dylan Baker > CC: Emil Velikov > --- > docs/release-calendar.html | 8 ++

Re: [Mesa-dev] [PATCH] meson: Bump version to 0.46 for python module

2018-12-10 Thread Dylan Baker
Quoting Dylan Baker (2018-12-10 09:13:59) > Quoting Matt Turner (2018-12-08 12:49:06) > > On Thu, Nov 22, 2018 at 1:05 PM Matt Turner wrote: > > > > > > On Wed, Nov 21, 2018 at 10:48 AM Matt Turner wrote: > > > > > > > > Thanks Arfrev

Re: [Mesa-dev] [PATCH] meson: Bump version to 0.46 for python module

2018-12-10 Thread Dylan Baker
Quoting Matt Turner (2018-12-08 12:49:06) > On Thu, Nov 22, 2018 at 1:05 PM Matt Turner wrote: > > > > On Wed, Nov 21, 2018 at 10:48 AM Matt Turner wrote: > > > > > > Thanks Arfrever and Dylan. > > > > > > Acked-by: Matt Turner > > > > Hmm, actually this doesn't seem to work for me. With it

[Mesa-dev] [PATCH] meson: Add nir_algebraic_parser_test to suites

2018-12-07 Thread Dylan Baker
Just to make it easier to run a nir tests together. Fixes: a0ae12ca91a45f81897e774019cde9bd081f03a0 ("nir/algebraic: Add unit tests for bitsize validation") --- src/compiler/nir/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/meson.build

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-06 Thread Dylan Baker
ing Patches > > + > + To participate in code review, you should monitor the > + https://lists.freedesktop.org/mailman/listinfo/mesa-dev;> > + mesa-dev email list and the GitLab > + Mesa href="https://gitlab.freedesktop.org/mesa/mesa/merge_requests;

Re: [Mesa-dev] [PATCH] meson: link LLVM 'native' component when LLVM is available

2018-12-06 Thread Dylan Baker
'irreader', > 'lto', 'option', 'objcarcopts', 'profiledata', >] >llvm_optional_modules += ['coroutines'] > -- > 2.19.1 > Reviewed-by: Dylan Baker signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3] nir/algebraic: Rewrite bit-size inference

2018-12-05 Thread Dylan Baker
For the python bits: Reviewed-by: Dylan Baker Quoting Connor Abbott (2018-12-05 04:20:30) > Before this commit, there were two copies of the algorithm: one in C, > that we would use to figure out what bit-size to give the replacement > expression, and one in Python, that emulated

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Dylan Baker
Quoting Marek Olšák (2018-12-04 16:04:11) > On Tue, Dec 4, 2018 at 7:01 PM Dylan Baker wrote: > > Quoting Marek Olšák (2018-12-04 14:52:19) > > CFLAGS="-fno-omit-frame-pointer" \ > > CXXFLAGS="-fno-omit-frame-pointer" \ > > LDFLAGS=&

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-04 Thread Dylan Baker
Quoting Gert Wollny (2018-12-04 15:42:58) > Am Dienstag, den 04.12.2018, 14:01 -0800 schrieb Matt Turner: > > On Tue, Dec 4, 2018 at 12:48 PM Gert Wollny > > wrote: > > > FWIW, I also don't understand the urge to remove the automake build > > > system files, they account for less then 1% of line

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Dylan Baker
Quoting Marek Olšák (2018-12-04 14:52:19) > CFLAGS="-fno-omit-frame-pointer" \ > CXXFLAGS="-fno-omit-frame-pointer" \ > LDFLAGS="-fuse-ld=gold" \ >     meson $reconfigure build \ >     --prefix /usr --libdir /usr/lib/$archdir --buildtype debugoptimized > --native-file $llvm_config \ >    

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Dylan Baker
Quoting Eric Engestrom (2018-12-04 09:36:53) > On Tuesday, 2018-12-04 09:16:18 -0800, Dylan Baker wrote: > > There are now no known distributions using autotools, meson has all of > > the features that autotools does. We don't need two build systems to do > > exactly

Re: [Mesa-dev] [PATCH] build: remove autotools

2018-12-04 Thread Dylan Baker
Quoting Marek Olšák (2018-12-04 12:21:58) > There is still the issue that DEBUG is not defined in debug builds if I set > CFLAGS and CXXFLAGS. > > Marek What does you command line look like, and what version of meson do you have? I can do: $ CFLAGS=-Dfoobar CXXFLAGS=-Dfoobar meson build

[Mesa-dev] [PATCH 2/5] meson: Fix ppc64 little endian detection

2018-12-04 Thread Dylan Baker
Old versions of meson returned ppc64le as the cpu_family for little endian power8 cpus, versions >=0.48 don't do this, so the check wouldn't work in that case. This generalizes the check to work for both old and new versions of meson. Fixes: 34bbb24ce7702658cdc4e9d34a650e169716c39e

[Mesa-dev] [PATCH 4/5] meson: Add support for gnu hurd

2018-12-04 Thread Dylan Baker
--- meson.build | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 0785609c4b0..3f835e2b952 100644 --- a/meson.build +++ b/meson.build @@ -220,8 +220,6 @@ elif system_has_kms_drm else # FIXME: haiku doesn't use dri, and xlib doesn't use

[Mesa-dev] [PATCH 3/5] meson: Override C++ standard to gnu++11 when building with altivec on ppc64le

2018-12-04 Thread Dylan Baker
Otherwise there will be symbol collisions for the vector name. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108943 Fixes: 34bbb24ce7702658cdc4e9d34a650e169716c39e ("meson: Add support for ppc assembly/optimizations") --- meson.build | 12

[Mesa-dev] [PATCH 0/5] Fixueps for ppc64 and gnu hurd

2018-12-04 Thread Dylan Baker
This little series is aimed at fixing problems reported by fedora and debian when using meson, there's a couple of patches in here for fixing ppc64 detection (tested without llvm), and a couple for gnu hurd (not tested). Dylan Baker (5): meson: remove duplicate definition meson: Fix ppc64

[Mesa-dev] [PATCH 1/5] meson: remove duplicate definition

2018-12-04 Thread Dylan Baker
--- meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/meson.build b/meson.build index 1aeef95f722..48ba8127f95 100644 --- a/meson.build +++ b/meson.build @@ -34,8 +34,6 @@ cpp = meson.get_compiler('cpp') null_dep = dependency('', required : false) -system_has_kms_drm =

[Mesa-dev] [PATCH 5/5] meson: Add toggle for glx-direct

2018-12-04 Thread Dylan Baker
GNU Hurd needs to turn off glx-direct, rather than special case it, we'll just add a toggle. --- meson.build | 4 +--- meson_options.txt | 6 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 3f835e2b952..3aacfa04900 100644 ---

Re: [Mesa-dev] [PATCH 1/2] nir/algebraic: Rewrite bit-size inference

2018-12-04 Thread Dylan Baker
Quoting Connor Abbott (2018-12-04 01:58:28) > On Mon, Dec 3, 2018 at 11:39 PM Dylan Baker wrote: > > > > Quoting Jason Ekstrand (2018-12-03 14:12:41) > > > On Mon, Dec 3, 2018 at 3:50 PM Dylan Baker wrote: > > > > > > Quoting Connor Abbott (2018-11-2

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-04 Thread Dylan Baker
Quoting Eric Engestrom (2018-12-03 10:26:01) > On Monday, 2018-12-03 10:06:30 -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-12-03 09:46:29) > > > On Monday, 2018-12-03 09:25:48 -0800, Dylan Baker wrote: > > > > Can I admit I was really wanted to send

[Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Dylan Baker
There are now no known distributions using autotools, meson has all of the features that autotools does. We don't need two build systems to do exactly the same thing, meson is faster, easier to maintain, and used by more devs than autotools. Let's reduce the ongoing burden of maintaining

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-03 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-12-03 14:14:19) > On Mon, Dec 3, 2018 at 7:30 PM Jan Vesely wrote: > > > > On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > > > Cc: Emil Velikov > > > Cc: Andres Gomez > > > Cc: Juan A. Suarez Romero > &

Re: [Mesa-dev] [PATCH 1/2] nir/algebraic: Rewrite bit-size inference

2018-12-03 Thread Dylan Baker
Quoting Jason Ekstrand (2018-12-03 14:12:41) > On Mon, Dec 3, 2018 at 3:50 PM Dylan Baker wrote: > > Quoting Connor Abbott (2018-11-29 10:32:02) > > Before this commit, there were two copies of the algorithm: one in C, > > that we would use to figure out

Re: [Mesa-dev] [PATCH 1/2] nir/algebraic: Rewrite bit-size inference

2018-12-03 Thread Dylan Baker
Quoting Jason Ekstrand (2018-12-03 14:12:41) > On Mon, Dec 3, 2018 at 3:50 PM Dylan Baker wrote: > > Quoting Connor Abbott (2018-11-29 10:32:02) > > Before this commit, there were two copies of the algorithm: one in C, > > that we would use to figure out

Re: [Mesa-dev] [PATCH 1/2] nir/algebraic: Rewrite bit-size inference

2018-12-03 Thread Dylan Baker
Quoting Connor Abbott (2018-11-29 10:32:02) > Before this commit, there were two copies of the algorithm: one in C, > that we would use to figure out what bit-size to give the replacement > expression, and one in Python, that emulated the C one and tried to > prove that the C algorithm would never

Re: [Mesa-dev] Lets talk about autotools

2018-12-03 Thread Dylan Baker
Quoting Timo Aaltonen (2018-12-03 11:03:59) > On 3.12.2018 20.54, Dylan Baker wrote: > > Quoting Timo Aaltonen (2018-12-03 10:36:12) > >> On 3.12.2018 20.25, Emil Velikov wrote: > >>> On Mon, 3 Dec 2018 at 17:49, Dylan Baker wrote: > >>>> >

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-03 Thread Dylan Baker
Quoting Jan Vesely (2018-12-03 10:30:37) > On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > > Cc: Emil Velikov > > Cc: Andres Gomez > > Cc: Juan A. Suarez Romero > > Cc: Dylan Baker > > Signed-off-by: Eric Engestrom > > --- > > This pat

Re: [Mesa-dev] Lets talk about autotools

2018-12-03 Thread Dylan Baker
Quoting Timo Aaltonen (2018-12-03 10:36:12) > On 3.12.2018 20.25, Emil Velikov wrote: > > On Mon, 3 Dec 2018 at 17:49, Dylan Baker wrote: > >> > >> Quoting Emil Velikov (2018-12-03 07:54:38) > >>> Hi all, > >>> > >>> On Thu, 29 Nov

Re: [Mesa-dev] Lets talk about autotools

2018-12-03 Thread Dylan Baker
Quoting Emil Velikov (2018-12-03 10:25:48) > On Mon, 3 Dec 2018 at 17:49, Dylan Baker wrote: > > > > Quoting Emil Velikov (2018-12-03 07:54:38) > > > Hi all, > > > > > > On Thu, 29 Nov 2018 at 17:44, Emil Velikov > > > wrote: > > > &g

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-03 Thread Dylan Baker
Quoting Eric Engestrom (2018-12-03 09:46:29) > On Monday, 2018-12-03 09:25:48 -0800, Dylan Baker wrote: > > Can I admit I was really wanted to send this patch out and it actually > > makes me > > sad that you beat me too it? > > Heh, I think many (most?) of us w

Re: [Mesa-dev] Lets talk about autotools

2018-12-03 Thread Dylan Baker
Quoting Dave Airlie (2018-11-30 12:16:10) > > On Wed., 28 Nov. 2018, 03:06 Matt Turner > On Tue, Nov 27, 2018 at 1:13 AM Timo Aaltonen wrote: > > > > On 17.11.2018 6.04, Dylan Baker wrote: > > > Quoting Dylan Baker (2018-09-17 09:44:07) > &g

Re: [Mesa-dev] Lets talk about autotools

2018-12-03 Thread Dylan Baker
Quoting Emil Velikov (2018-12-03 07:54:38) > Hi all, > > On Thu, 29 Nov 2018 at 17:44, Emil Velikov wrote: > > > > Hi all, > > > > I can see why people may opt to not use or maintain the autotools build. > > Although I would kindly ask that we do not remove it just yet. > > > > In Mesa, we have

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-03 Thread Dylan Baker
Can I admit I was really wanted to send this patch out and it actually makes me sad that you beat me too it? That said there are a couple things you missed. Dylan Quoting Eric Engestrom (2018-12-03 02:21:33) > Cc: Emil Velikov > Cc: Andres Gomez > Cc: Juan A. Suarez Romero > Cc:

Re: [Mesa-dev] [Mesa-stable] [PATCH] amd/vulkan: meson build - use radv_deps for libvulkan_radeon

2018-12-03 Thread Dylan Baker
uild b/src/amd/vulkan/meson.build > index 0f1261d480..cc2aa7fd17 100644 > --- a/src/amd/vulkan/meson.build > +++ b/src/amd/vulkan/meson.build > @@ -140,7 +140,7 @@ libvulkan_radeon = shared_library( > ], >dependencies : [ > dep_llvm, dep_libdrm_amdgpu, dep_thread,

Re: [Mesa-dev] Lets talk about autotools

2018-11-29 Thread Dylan Baker
Quoting Timo Aaltonen (2018-11-29 10:33:30) > On 29.11.2018 20.22, Matt Turner wrote: > > On Thu, Nov 29, 2018 at 9:47 AM Emil Velikov > > wrote: > >> In Mesa, we have different parts not used by different teams. As such > >> we tend to remove stuff when nobody is around to maintain it anymore.

Re: [Mesa-dev] [PATCH mesa 1/2] docs: add meson cross compilation instructions

2018-11-29 Thread Dylan Baker
stem. > + > + > +32-bit build on x86 linux: > + > +[binaries] > +c = '/usr/bin/gcc' > +cpp = '/usr/bin/g++' > +ar = '/usr/bin/ar' It's better if possible to use gcc-ar instead of ar, you can't LTO without gcc-ar, for example. Without or without the above, Reviewed-by: Dylan Baker

Re: [Mesa-dev] [PATCH mesa] meson: skip asm check when asm is disabled

2018-11-29 Thread Dylan Baker
build() > +if with_asm and meson.is_cross_build() >if build_machine.system() != host_machine.system() > # TODO: It may be possible to do this with an exe_wrapper (like wine). > message('Cross compiling from one OS to another, disabling assembly.') > -- > Cheers, > Eric

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-28 Thread Dylan Baker
Quoting Jason Ekstrand (2018-11-28 11:30:32) > Yes, but the point is that we (the reviewers) know that we're conflicting.  > That's very different from what I could easily see happening *a lot* were ML > reviewer A is perfectly happy with some bit of code but MR reviewer B asks for > it to be

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-28 Thread Dylan Baker
Quoting Jordan Justen (2018-11-28 10:21:13) > On 2018-11-28 09:22:35, Dylan Baker wrote: > > Quoting Matt Turner (2018-11-27 19:20:09) > > > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen > > > wrote: > > > > > > > > This do

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-28 Thread Dylan Baker
Quoting Matt Turner (2018-11-27 19:20:09) > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen > wrote: > > > > This documents a mechanism for using GitLab Merge Requests as an > > optional, secondary way to get code reviews for patchsets. > > > > We still require all patches to be emailed. > > > >

Re: [Mesa-dev] Lets talk about autotools

2018-11-26 Thread Dylan Baker
t. If I keep --reconfigure in the script > and the build directory doesn't exist, it doesn't configure. > > There has to be a better solution than "meson ... || meson --reconfigure ...". > > Marek > > On Mon, Sep 17, 2018 at 12:46 PM Dylan Baker wrote: > > I fee

Re: [Mesa-dev] Lets talk about autotools

2018-11-26 Thread Dylan Baker
are, Inc. > > > On Fri, Nov 23, 2018 at 8:46 PM Marek Olšák wrote: > > On Fri, Nov 16, 2018 at 11:05 PM Dylan Baker wrote: > > Quoting Dylan Baker (2018-09-17 09:44:07) > > I feel like for !windows meson is in good enough shape at this point

Re: [Mesa-dev] [PATCH mesa 2/2] build: stop defining unused VERSION

2018-11-26 Thread Dylan Baker
version()), > > '-DPACKAGE_BUGREPORT="https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa;', > ] > > -- > Cheers, > Eric > for the series: Reviewed-by: Dylan Baker signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC 12/13] fixup! wip

2018-11-23 Thread Dylan Baker
Ah, but you only *think* it's the lamest message you've ever seen! Quoting Jason Ekstrand (2018-11-23 15:12:25) > That is the lamest commit message I think I've ever seen. > > On Fri, Nov 23, 2018 at 4:29 PM Dylan Baker wrote: > > --- >  src/mapi/glapi/gen/khr_xml.

[Mesa-dev] [RFC 13/13] wip: use new generator for marshal.c

2018-11-23 Thread Dylan Baker
--- src/mapi/glapi/gen/gl_marshal_h.py | 4 ++-- src/mapi/glapi/gen/meson.build | 10 ++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mapi/glapi/gen/gl_marshal_h.py b/src/mapi/glapi/gen/gl_marshal_h.py index 91948177e33..76dd4f17108 100644 ---

[Mesa-dev] [RFC 03/13] glapi/gen: Add some helpers that will be used generators

2018-11-23 Thread Dylan Baker
This is mostly mako related stuff. --- src/mapi/glapi/gen/helpers.py | 33 + src/mapi/glapi/gen/templates/copyright.mako | 25 src/mapi/glapi/gen/templates/helpers.mako | 29 ++ 3 files changed, 87 insertions(+) create mode

[Mesa-dev] [RFC 12/13] fixup! wip

2018-11-23 Thread Dylan Baker
--- src/mapi/glapi/gen/khr_xml.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/khr_xml.py b/src/mapi/glapi/gen/khr_xml.py index 7909afb922d..c3efa5007d9 100644 --- a/src/mapi/glapi/gen/khr_xml.py +++ b/src/mapi/glapi/gen/khr_xml.py @@ -182,7 +182,7 @@

[Mesa-dev] [RFC 08/13] mapi/glapi/gen: Use new infastructure for gl_marshal_h.py

2018-11-23 Thread Dylan Baker
This is identical, except for 240 new entries that weren't generated. I believe this is a bug in the current implementation because the mesa XML is wrong (surprise!), namely that it lacks metadata for a number of functions that take arrays about the length of those arrays. ---

[Mesa-dev] [RFC 04/13] gl.xml: update to git commit 58fcee1918e90cb817693c6df8c1f8d3e4f3e48e

2018-11-23 Thread Dylan Baker
--- src/mapi/glapi/registry/gl.xml | 4332 +++- 1 file changed, 3193 insertions(+), 1139 deletions(-) diff --git a/src/mapi/glapi/registry/gl.xml b/src/mapi/glapi/registry/gl.xml index 13882eff7bb..3b7805e9400 100644 --- a/src/mapi/glapi/registry/gl.xml +++

[Mesa-dev] [RFC 02/13] glapi/gen: use main function in gl_marshal_h.py

2018-11-23 Thread Dylan Baker
It's more idiomatic python. --- src/mapi/glapi/gen/gl_marshal_h.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_marshal_h.py b/src/mapi/glapi/gen/gl_marshal_h.py index d870bba5ed6..619754e05c6 100644 --- a/src/mapi/glapi/gen/gl_marshal_h.py +++

[Mesa-dev] [RFC 01/13] glapi/gen: gl_marshal_h.py: Use argparse instead of getopt

2018-11-23 Thread Dylan Baker
It's more modern and has more useful features, like automatic usage generation, which means less code. --- src/mapi/glapi/gen/gl_marshal_h.py | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/src/mapi/glapi/gen/gl_marshal_h.py

[Mesa-dev] [RFC 00/13] Start using Khronos XML for generators

2018-11-23 Thread Dylan Baker
easy. Dylan Baker (13): glapi/gen: gl_marshal_h.py: Use argparse instead of getopt glapi/gen: use main function in gl_marshal_h.py glapi/gen: Add some helpers that will be used generators gl.xml: update to git commit 58fcee1918e90cb817693c6df8c1f8d3e4f3e48e gen_mesa_data: script to convert

[Mesa-dev] [RFC 07/13] mapi/glapi/gen: Add python module with abstractions from Khronos XML

2018-11-23 Thread Dylan Baker
These helpers form an abstraction over the krhonos XML and help deal with some of the warts of the XML format, as well as generally making the XML easier to work with. --- src/mapi/glapi/gen/Makefile.am | 3 +- src/mapi/glapi/gen/khr_xml.py | 180 + 2 files

[Mesa-dev] [RFC 10/13] wip

2018-11-23 Thread Dylan Baker
--- src/mapi/glapi/gen/khr_xml.py | 81 +-- 1 file changed, 78 insertions(+), 3 deletions(-) diff --git a/src/mapi/glapi/gen/khr_xml.py b/src/mapi/glapi/gen/khr_xml.py index 784931b5059..7909afb922d 100644 --- a/src/mapi/glapi/gen/khr_xml.py +++

[Mesa-dev] [RFC 05/13] gen_mesa_data: script to convert mesa xml into mesa_data entries

2018-11-23 Thread Dylan Baker
--- src/mapi/glapi/gen/gen_mesa_data.py | 62 + 1 file changed, 62 insertions(+) create mode 100755 src/mapi/glapi/gen/gen_mesa_data.py diff --git a/src/mapi/glapi/gen/gen_mesa_data.py b/src/mapi/glapi/gen/gen_mesa_data.py new file mode 100755 index

[Mesa-dev] [RFC 09/13] begin generalizing gl_marshal_h.py for doing both.

2018-11-23 Thread Dylan Baker
This is undiffed, but does generate successfully. --- src/mapi/glapi/gen/gl_marshal_h.py | 166 + src/mesa/main/meson.build | 3 +- 2 files changed, 145 insertions(+), 24 deletions(-) diff --git a/src/mapi/glapi/gen/gl_marshal_h.py

Re: [Mesa-dev] [PATCH 12/18] meson: wire the new generator for es1 and es2

2018-11-23 Thread Dylan Baker
Quoting Emil Velikov (2018-11-23 05:26:18) > On 2018/11/21, Dylan Baker wrote: > > > > diff --git a/src/mapi/glapi/gen/meson.build > > > b/src/mapi/glapi/gen/meson.build > > > index f494e9707b6..fa06c7c5458 100644 > > > --- a/src/mapi/glapi/gen/

Re: [Mesa-dev] [PATCH 06/18] mapi/new: use the static_data offsets in the new generator

2018-11-23 Thread Dylan Baker
Quoting Emil Velikov (2018-11-23 05:35:31) > On 2018/11/21, Dylan Baker wrote: > > Quoting Emil Velikov (2018-11-21 04:04:03) > > > > > > > +import os > > > +GLAPI = os.path.join(os.path.dirname(sys.argv[0]), "..", "glapi/gen") > >

Re: [Mesa-dev] [PATCH] meson: Bump version to 0.46 for python module

2018-11-23 Thread Dylan Baker
uoting Eero Tamminen (2018-11-23 01:40:22) > Hi, > > On 21.11.2018 20.13, Dylan Baker wrote: > > From: Arfrever Frehtes Taifersar Arahesis > > > > Meson has two modules for finding python, the python3 module and the > > python module. Python3 is older, and has some

[Mesa-dev] [PATCH] meson: Bump version to 0.46 for python module

2018-11-21 Thread Dylan Baker
-by: Dylan Baker --- docs/meson.html | 2 +- meson.build | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 68f80d6ac42..af109d3d8b0 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -24,7 +24,7 @@ for production The meson build

Re: [Mesa-dev] [PATCH 12/18] meson: wire the new generator for es1 and es2

2018-11-21 Thread Dylan Baker
Quoting Emil Velikov (2018-11-21 04:04:09) > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/mapi/es1api/meson.build| 6 +++--- > src/mapi/es2api/meson.build| 6 +++--- > src/mapi/glapi/gen/meson.build | 7 +++ > src/mapi/meson.build | 1 + > 4 files

Re: [Mesa-dev] [PATCH 08/18] mapi/new: don't print info we don't need for ES1/ES2

2018-11-21 Thread Dylan Baker
Quoting Emil Velikov (2018-11-21 04:04:05) > There is no need for the noop function, the public_stubs table or table > size defines. Remove those. > > Might what to look and merge this back to GLVND - from a quick look > they don't need them either. > > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH 06/18] mapi/new: use the static_data offsets in the new generator

2018-11-21 Thread Dylan Baker
Quoting Emil Velikov (2018-11-21 04:04:03) > From: Emil Velikov > > Otherwise the incorrect ones will be used, effecitvely breaking the ABI. > > Note: some entries in static_data.py list a suffixed API, while (for ES* > at least) we expect the one w/o suffix. > > Signed-off-by: Emil Velikov >

Re: [Mesa-dev] [PATCH mesa 2/2] meson: make passing an invalid pointer a hard error

2018-11-20 Thread Dylan Baker
ath-errno', '-fno-trapping-math', > '-Qunused-arguments'] >if cpp.has_argument(a) > -- > Cheers, > Eric > for this patch, Reviewed-by: Dylan Baker signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium/tests/trivial, meson build: Add dep_thread to build dependencies

2018-11-20 Thread Dylan Baker
Quoting Gert Wollny (2018-11-20 03:50:35) > From: Gert Wollny > > When moving the CPU tests to src/util the needed bits were no longer pulled > here in when doing debug builds resulting in > > g++ -o src/gallium/tests/trivial/quad-tex ... > > src/util/libmesa_util.a(u_cpu_detect.c.o): In

[Mesa-dev] [PATCH] meson: Add tests to suites

2018-11-19 Thread Dylan Baker
Meson test has a concepts of suites, which allow tests to be grouped together. This allows for a subtest of tests to be run only (say only the tests for nir). A test can be added to more than one suite, but for the most part I've only added a test to a single suite, though I've added a compiler

Re: [Mesa-dev] Lets talk about autotools

2018-11-19 Thread Dylan Baker
Quoting Gert Wollny (2018-11-18 02:56:00) > Am Freitag, den 16.11.2018, 20:04 -0800 schrieb Dylan Baker: > > > > Is there anything else we're missing in meson to be able to drop > > autotools? > > One thing that I notes is that it seems to be impossible to run th

Re: [Mesa-dev] Lets talk about autotools

2018-11-19 Thread Dylan Baker
Quoting Gert Wollny (2018-11-18 02:56:00) > Am Freitag, den 16.11.2018, 20:04 -0800 schrieb Dylan Baker: > > > > Is there anything else we're missing in meson to be able to drop > > autotools? > > One thing that I notes is that it seems to be impossible to run th

Re: [Mesa-dev] Lets talk about autotools

2018-11-19 Thread Dylan Baker
Sorry, cell phones are really bad for responding to email... The file has the same rules as cross files, it can be a local file, passed as an absolute path, or read from $XDG directories (local files will be read before XDG ones). Dylan Quoting Dylan Baker (2018-11-18 09:01:27) > That file

Re: [Mesa-dev] [PATCH] meson: Don't set -Wall

2018-11-19 Thread Dylan Baker
Quoting Juan A. Suarez Romero (2018-11-19 07:17:14) > On Fri, 2018-11-09 at 13:28 -0800, Dylan Baker wrote: > > meson does this for you with it's warn levels, so we don't need to set > > it ourselves. > > > > Fixes: d1992255bb29054fa51763376d125183a9f602f3 > >

Re: [Mesa-dev] Lets talk about autotools

2018-11-18 Thread Dylan Baker
That file can live anywhere and can be referenced by absolute path. On November 17, 2018 9:15:20 AM PST, "Kai Wasserbäch" wrote: >Hey Dylan, >Dylan Baker wrote on 17.11.18 05:04: >> Quoting Dylan Baker (2018-09-17 09:44:07) >>> I feel like for !window

Re: [Mesa-dev] Lets talk about autotools

2018-11-16 Thread Dylan Baker
Quoting Dylan Baker (2018-09-17 09:44:07) > I feel like for !windows meson is in good enough shape at this point that we > can start having the discussion about deleting the autotools build. So, is > there > anything left that autotools can do that meson cannot (that we a

Re: [Mesa-dev] [PATCH] meson: strip rpath when installing megadrivers

2018-11-16 Thread Dylan Baker
I should test this on MacOS... I will do that before pushing. Quoting Dylan Baker (2018-11-16 10:28:36) > This is the script that meson uses to install megadrivers. Meson always > sets rpath for in tree dependencies at build time, and normally rpaths > are stripped at install time. Th

Re: [Mesa-dev] [PATCH] meson: strip rpath when installing megadrivers

2018-11-16 Thread Dylan Baker
Quoting Eric Engestrom (2018-11-16 11:46:02) > > > On November 16, 2018 6:29:55 PM UTC, Dylan Baker wrote: > > This is the script that meson uses to install megadrivers. Meson > > always > > sets rpath for in tree dependencies at build time, and normally rpaths >

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

2018-11-16 Thread Dylan Baker
Quoting Roland Scheidegger (2018-11-13 18:41:00) > Am 14.11.18 um 03:21 schrieb Matt Turner: > > On Tue, Nov 13, 2018 at 6:03 PM Roland Scheidegger > > wrote: > >> > >> Am 13.11.18 um 23:49 schrieb Dylan Baker: > >>> Quoting Roland Scheidegger (201

Re: [Mesa-dev] [PATCH 2/2] travis: adding missing x11-xcb for meson+vulkan

2018-11-16 Thread Dylan Baker
For this patch, Reviewed-by: Dylan Baker For the first one Xenial was never really supported by travis AFAICT, but cosmic cuttlefish does seem to be supported, so if we need to move from trusty it should be to cosmic. Dylan Quoting Emil Velikov (2018-09-07 06:58:56) > From: Emil Veli

[Mesa-dev] [PATCH] meson: strip rpath when installing megadrivers

2018-11-16 Thread Dylan Baker
This is the script that meson uses to install megadrivers. Meson always sets rpath for in tree dependencies at build time, and normally rpaths are stripped at install time. The install megadrivers script breaks this by bypassing meson's normal install machinery. To fix this I've imported the

Re: [Mesa-dev] [PATCH 1/2] travis: drop unneeded x11proto-xf86vidmode-dev

2018-11-16 Thread Dylan Baker
This all seems reasonable, although I'll admit I didn't read too closely, for the series: Acked-by: Dylan Baker Quoting Emil Velikov (2018-11-16 05:59:00) > From: Emil Velikov > > The only place where the package is needed is for building the DRI > based libGL library. >

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

2018-11-13 Thread Dylan Baker
Quoting Roland Scheidegger (2018-11-13 14:13:00) > Am 13.11.18 um 18:00 schrieb Dylan Baker: > > Quoting Erik Faye-Lund (2018-11-13 01:34:53) > >> On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: > >>> Quoting Erik Faye-Lund (2018-11-12 04:51:47) > >&

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

2018-11-13 Thread Dylan Baker
Quoting Erik Faye-Lund (2018-11-13 01:34:53) > On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: > > Quoting Erik Faye-Lund (2018-11-12 04:51:47) > > > On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote: > > > > Which has the same behavior. > > > >

Re: [Mesa-dev] [PATCH mesa] xmlpool: update translation po files

2018-11-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-11-12 09:47:22) > On Monday, 2018-11-12 16:56:32 +, Emil Velikov wrote: > > On Mon, 12 Nov 2018 at 14:24, Eric Engestrom > > wrote: > > > > > > These files are close to 4 years out of date; a lot's changed since. > > > Let's just check in a recently-regenerated

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

2018-11-12 Thread Dylan Baker
Quoting Erik Faye-Lund (2018-11-12 04:51:47) > On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote: > > Which has the same behavior. > > Does it? I'm not so sure... IROUND_POS seems to round to nearest > integer depending on the FPU rounding mode, _mesa_roundevenf rounds to &

Re: [Mesa-dev] [PATCH mesa 3/3] meson: fix wayland-less builds

2018-11-12 Thread Dylan Baker
ld with wayland disabled > > since meson was introduced, but I guess it's a good thing ^^' > > Humble ping for this series? > It is currently impossible to build Mesa without support for wayland, > which I think is quite an important bug :) > for the series: Reviewed-by: Dy

Re: [Mesa-dev] [PATCH mesa] xmlpool: update translation po files

2018-11-12 Thread Dylan Baker
This is fine with me, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-11-12 06:24:33) > These files are close to 4 years out of date; a lot's changed since. > Let's just check in a recently-regenerated version. > > Changes generated by running `ninja xmlpool-{pot,update-po,gm

Re: [Mesa-dev] [PATCH 22/28] util: promote u_memory to src/util

2018-11-09 Thread Dylan Baker
Quoting Rob Clark (2018-11-09 14:27:35) > On Fri, Nov 9, 2018 at 1:41 PM Dylan Baker wrote: > > > > as well as os_memory* > > Thanks, I think this will be useful for me to extract freedreno/ir3 > out to src/compiler :-) Shouldn't that be src/qualcomm? :) > > R

Re: [Mesa-dev] [PATCH 04/28] r200: use preprocessor for big vs little endian checks

2018-11-09 Thread Dylan Baker
Quoting Dylan Baker (2018-11-09 15:52:05) > Quoting Timothy Arceri (2018-11-09 13:45:27) > > On 10/11/18 5:39 am, Dylan Baker wrote: > > > Instead of using a function at runtime we can just build the right code > > > for the right platform. > > > --- > >

Re: [Mesa-dev] [PATCH 04/28] r200: use preprocessor for big vs little endian checks

2018-11-09 Thread Dylan Baker
Quoting Timothy Arceri (2018-11-09 13:45:27) > On 10/11/18 5:39 am, Dylan Baker wrote: > > Instead of using a function at runtime we can just build the right code > > for the right platform. > > --- > > src/mesa/drivers/dri/r200/r200_blit.c | 76 ++-

Re: [Mesa-dev] [PATCH] meson: fix libatomic tests

2018-11-09 Thread Dylan Baker
Quoting Matt Turner (2018-11-09 15:26:50) > The underscore change alone is enough to fix the build on 32-bit ppc > and sparc. It's unclear to me if the dep_atomic even changes anything. > Without it I still see -latomic in the command to build > src/util/u_atomic_test. I would just drop that part.

[Mesa-dev] [PATCH] meson: Don't set -Wall

2018-11-09 Thread Dylan Baker
meson does this for you with it's warn levels, so we don't need to set it ourselves. Fixes: d1992255bb29054fa51763376d125183a9f602f3 ("meson: Add build Intel "anv" vulkan driver") --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build

[Mesa-dev] [PATCH] meson: fix libatomic tests

2018-11-09 Thread Dylan Baker
There are two problems: 1) the extra underscore in MISSING_64BIT_ATOMICS 2) we should ink with libatomic if the previous test decided we needed it CC: Matt Turner Fixes: d1992255bb29054fa51763376d125183a9f602f3 ("meson: Add build Intel "anv" vulkan driver") --- meson.build | 3 ++- 1

[Mesa-dev] [PATCH 28/28] remove final imports.h bits

2018-11-09 Thread Dylan Baker
This moves the fi_types to a new mesa_private.h and removes the imports.c file. The vast majority of this patch is just removing pound includes of imports.h and fixing up the recursive includes. --- src/Makefile.am | 1 - src/compiler/glsl/glsl_to_nir.cpp

<    1   2   3   4   5   6   7   8   9   10   >