[Mesa-dev] [PATCH v4 07/49] glapi: export glapi_destroy_multithread when building shared-glapi on windows

2018-08-22 Thread Dylan Baker
Which will allow meson to build a shared glapi build with mingw. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- src/mapi/glapi/glapi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/glapi.h b/src/mapi/glapi/glapi.h index d5d4e0a03a6..cbdef2e4c5a

[Mesa-dev] [PATCH v4 18/49] meson: build gallium gdi winsys

2018-08-22 Thread Dylan Baker
Reviewed-by: Eric Anholt --- src/gallium/meson.build | 6 ++ src/gallium/winsys/sw/gdi/meson.build | 27 +++ 2 files changed, 33 insertions(+) create mode 100644 src/gallium/winsys/sw/gdi/meson.build diff --git a/src/gallium/meson.build

[Mesa-dev] [PATCH v4 11/49] meson: Add a platform for windows

2018-08-22 Thread Dylan Baker
This mirrors the haiku build which uses a platform. v2: - Fix some rebase problems Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 8 ++-- meson_options.txt | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v4 43/49] tests/vma: fix build with MSVC

2018-08-22 Thread Dylan Baker
--- src/util/tests/vma/vma_random_test.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/util/tests/vma/vma_random_test.cpp b/src/util/tests/vma/vma_random_test.cpp index 1f194fcdf92..9246176cbf2 100644 --- a/src/util/tests/vma/vma_random_test.cpp +++

[Mesa-dev] [PATCH v4 30/49] meson: for incluse of inttypes.h for glcpp with msvc

2018-08-22 Thread Dylan Baker
Because we provide a copy if MSVC doesn't, and we need it to make flex do what we want. --- src/compiler/glsl/glcpp/meson.build | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index

[Mesa-dev] [PATCH v4 06/49] meson: add a expat subproject

2018-08-22 Thread Dylan Baker
For Windows Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build| 2 +- subprojects/expat.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/expat.wrap diff --git a/meson.build b/meson.build index d75762295ac

[Mesa-dev] [PATCH v4 14/49] meson: add windows compiler checks and libraries

2018-08-22 Thread Dylan Baker
v4: - Fix typo in warning code (4246 -> 4267) - Copy comments from scons for what MSVC warnings codes do - Merge linker argument changes into this commit --- meson.build | 155 +++- 1 file changed, 106 insertions(+), 49 deletions(-) diff

[Mesa-dev] [PATCH v4 32/49] meson: add switches for SWR with MSVC

2018-08-22 Thread Dylan Baker
--- src/gallium/drivers/swr/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/meson.build b/src/gallium/drivers/swr/meson.build index b95c8bc1bf8..ec4d80e4bb2 100644 --- a/src/gallium/drivers/swr/meson.build +++

[Mesa-dev] [PATCH v4 48/49] appveyor: Add a wrap for llvm

2018-08-22 Thread Dylan Baker
The appveyor build has a copy of llvm 5.0.1 that scons uses, meson can also use this to build llvm pipe (though not swr, which requires 6.0.0) as well. This requires a plain buildtype, since we need to compile single threaded to link with the provided LLVM, as well as a 32 bit build for the same

[Mesa-dev] [PATCH v4 21/49] meson: build graw-gdi target

2018-08-22 Thread Dylan Baker
--- src/gallium/meson.build | 4 ++- src/gallium/targets/graw-gdi/meson.build | 36 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 src/gallium/targets/graw-gdi/meson.build diff --git a/src/gallium/meson.build

[Mesa-dev] [PATCH v4 09/49] meson: fix dl detection on non cygwin windows

2018-08-22 Thread Dylan Baker
v4: - Don't run checks on Windows that will always fail Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt (v3) Reviewed-by: Eric Engestrom --- meson.build | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 9298c5ecce6

[Mesa-dev] [PATCH v4 22/49] meson: fix gallium-osmesa to build for windows

2018-08-22 Thread Dylan Baker
v2: - set so_version to '' (only affects windows) - always set lib prefix to 'lib', even on msvc --- src/gallium/state_trackers/osmesa/meson.build | 12 ++-- src/gallium/targets/osmesa/meson.build| 11 ++- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v4 01/49] move u_math to src/util

2018-08-22 Thread Dylan Baker
Currently we have two sets of functions for bit counts, one in gallium and one in core mesa. The ones in core mesa are header only in many cases, since they reduce to "#define _mesa_bitcount popcount", but they provide a fallback implementation. This is important because 32bit msvc doesn't have

[Mesa-dev] [PATCH v4 44/49] meson: maintain names of shared API libraries

2018-08-22 Thread Dylan Baker
Mesa uses the lib prefix, and doesn't use a version for it's dynamic libraries, which meson defaults to. v2: - this patch --- src/mapi/es1api/meson.build | 2 ++ src/mapi/es2api/meson.build | 2 ++ src/mapi/shared-glapi/meson.build | 2 ++ 3 files changed, 6 insertions(+) diff --git

[Mesa-dev] [PATCH v4 12/49] meson: don't build glx or dri by default on windows

2018-08-22 Thread Dylan Baker
Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 1af610573d5..5102ffe0c7c 100644 --- a/meson.build +++ b/meson.build @@ -264,8 +264,12 @@ if with_glx == 'auto' elif

[Mesa-dev] [PATCH v4 08/49] glsl: fix general_ir_test with mingw

2018-08-22 Thread Dylan Baker
Somewhere down in the depths of the mingw headers 'interface' is defined, change it to iface like a similar patch did. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- src/compiler/glsl/tests/general_ir_test.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

[Mesa-dev] mesa 18.1.7 Notice

2018-08-22 Thread Dylan Baker
Hi everyone, Just a friendly reminder that the plan is to have the mesa 18.1.7 release this Friday (the 24th) at or around 10am PDT. The patches currently in the staging/18.1 branch represent what will be in the release, barring any critical nominations between then and now. Dylan

Re: [Mesa-dev] [PATCH v3 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-22 Thread Dylan Baker
Thanks! I was going to push these today if someone didn't give me an r-b, but I wanted to give people proper time. Dylan Quoting Mathieu Bridon (2018-08-22 07:35:39) > I just learned I was supposed to send this :) > > Reviewed-by: Mathieu Bridon > > On Fri, 2018-08-17 at 11:

Re: [Mesa-dev] [PATCH] anv/lower_ycbcr: Use the binding array size for bounds checks

2018-08-20 Thread Dylan Baker
Quoting Lionel Landwerlin (2018-08-20 08:59:38) > From: Jason Ekstrand > > Because lower_ycbcr gets called before apply_pipeline_layout, the > indices are all logical and the binding layout HW size is actually too > big for the bounds check. We should just use the regular logical array > size

Re: [Mesa-dev] [PATCH] autotools: include git_sha1.h in dist tarball

2018-08-20 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Juan A. Suarez Romero (2018-08-20 07:22:35) > This fixes `make distcheck`. > > Fixes: 471f708ed6 ("git_sha1: simplify logic") > CC: Eric Engestrom > --- > src/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &g

Re: [Mesa-dev] [PATCH 1/5] anv/lower_ycbcr: Use the binding array size for bounds checks

2018-08-20 Thread Dylan Baker
Quoting Jason Ekstrand (2018-08-08 01:12:49) > Because lower_ycbcr gets called before apply_pipeline_layout, the > indices are all logical and the binding layout HW size is actually too > big for the bounds check. We should just use the regular logical array > size instead. > > Fixes:

Re: [Mesa-dev] [PATCH 3/3] meson: Run the test with Python 3

2018-08-17 Thread Dylan Baker
Quoting Mathieu Bridon (2018-08-17 12:32:18) > --- > src/compiler/glsl/glcpp/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/glsl/glcpp/meson.build > b/src/compiler/glsl/glcpp/meson.build > index 09d44ddd687..769406f5331 100644 > ---

Re: [Mesa-dev] [PATCH 1/3] python: difflib prefers unicode strings

2018-08-17 Thread Dylan Baker
for the series: Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-08-17 12:32:16) > Python 3 does not automatically convert from bytes to unicode strings > like Python 2 used to do. > > This commit makes sure we pass unicode strings to difflib.unified_diff, > so that t

Re: [Mesa-dev] [PATCH mesa] util/xmlpool: make indentation coherent

2018-08-17 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-08-16 08:03:23) > Signed-off-by: Eric Engestrom > --- > src/util/xmlpool/t_options.h | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/src/util/xmlpool/t_options.h

Re: [Mesa-dev] [PATCH] docs: update required mako version

2018-08-17 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Emil Velikov (2018-08-16 09:58:53) > From: Emil Velikov > > The requirement was bumped a while back, but we forgot to update the > docs. > > Fixes: ed871af91c2 ("configure.ac: raise Mako required version to > 0.8.0") > Cc: Eri

Re: [Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
Quoting Mathieu Bridon (2018-08-17 11:01:23) > On Fri, 2018-08-17 at 10:45 -0700, Dylan Baker wrote: > > Quoting Mathieu Bridon (2018-08-16 15:00:39) > > > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote: > > > > --- > > > > > > > > I di

[Mesa-dev] [PATCH v3 2/2] meson: Use python3 to run glsl tests

2018-08-17 Thread Dylan Baker
--- src/compiler/glsl/tests/meson.build | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index fc7b863a278..2a41e30a28d 100644 --- a/src/compiler/glsl/tests/meson.build +++

[Mesa-dev] [PATCH v3 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
v2: - explicitly decode the output of subprocesses - handle bytes and string types consistently rather than relying on python 2's coercion for bytes and ignoring them in python 3 v3: - explicitly set encode as well as decode - python 2.7 and 3.x `bytes` instead of defining an alias

Re: [Mesa-dev] [PATCH v2 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
Quoting Mathieu Bridon (2018-08-17 10:58:38) > On Fri, 2018-08-17 at 10:51 -0700, Dylan Baker wrote: > > diff --git a/src/compiler/glsl/tests/optimization_test.py > > b/src/compiler/glsl/tests/optimization_test.py > > index 577d2dfc20f..65bac676963 100755 > > --

Re: [Mesa-dev] [PATCHv2 1/2] meson: Use python to run glsl tests

2018-08-17 Thread Dylan Baker
Quoting Emil Velikov (2018-08-17 04:11:32) > From: Dylan Baker > > There are multiple reasons why the python scripts are executed > explicitly via $PYTHON or equivalent. In random order: > > - env is rarely a thing on Windows windows does something completely diffe

Re: [Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

2018-08-17 Thread Dylan Baker
a script is python2, python3, or both (using python is supposed to mean python 2 and 3 compatible.) You have my r-b, but please wait to push thisfor the other patches to land or you'll break the meson build and make Mark and Clayton grumpy: Reviewed-by: Dylan Baker Quoting Emil Velikov (2018-08-17 04

[Mesa-dev] [PATCH v2 2/2] meson: Use python3 to run glsl tests

2018-08-17 Thread Dylan Baker
--- src/compiler/glsl/tests/meson.build | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index fc7b863a278..2a41e30a28d 100644 --- a/src/compiler/glsl/tests/meson.build +++

[Mesa-dev] [PATCH v2 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
v2: - explicitly decode the output of subprocesses - handle bytes and string types consistently rather than relying on python 2's coercion for bytes and ignoring them in python 3 --- src/compiler/glsl/tests/lower_jump_cases.py | 2 +- src/compiler/glsl/tests/optimization_test.py | 6

Re: [Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
Quoting Mathieu Bridon (2018-08-16 15:00:39) > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote: > > --- > > > > I didn't see any patches from anyone else, so I wrote some real > > quick. Please > > point to them if other patches already exist. > >

Re: [Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
Quoting Mathieu Bridon (2018-08-16 15:00:39) > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote: > > --- > > > > I didn't see any patches from anyone else, so I wrote some real > > quick. Please > > point to them if other patches already exist. > >

Re: [Mesa-dev] [PATCH 1/2] configure: use AM_PATH_PYTHON to look for the python version

2018-08-17 Thread Dylan Baker
Quoting Emil Velikov (2018-08-17 03:12:56) > On 16 August 2018 at 21:28, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-08-16 09:52:05) > >> On Thursday, 2018-08-16 17:18:56 +0100, Emil Velikov wrote: > >> > From: Emil Velikov > >> > >

[Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-16 Thread Dylan Baker
--- I didn't see any patches from anyone else, so I wrote some real quick. Please point to them if other patches already exist. src/compiler/glsl/tests/lower_jump_cases.py | 2 +- src/compiler/glsl/tests/optimization_test.py | 6 -- src/compiler/glsl/tests/sexps.py | 9

[Mesa-dev] [PATCH 2/2] meson: Use python3 to run glsl tests

2018-08-16 Thread Dylan Baker
--- src/compiler/glsl/tests/meson.build | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index fc7b863a278..2a41e30a28d 100644 --- a/src/compiler/glsl/tests/meson.build +++

Re: [Mesa-dev] [PATCH v2 3/5] configure: Enforce python 2.7.x

2018-08-16 Thread Dylan Baker
Quoting Emil Velikov (2018-08-16 09:19:06) > On 16 August 2018 at 14:27, Emil Velikov wrote: > > On 15 August 2018 at 17:18, Dylan Baker wrote: > >> We don't want to support older versions of python 2 anymore, and we > >> don't support python

Re: [Mesa-dev] [PATCH 1/2] configure: use AM_PATH_PYTHON to look for the python version

2018-08-16 Thread Dylan Baker
across the > > different OS. > > > > Use the handy AM_PATH_PYTHON which finds the correct name and checks for > > the version. > > > > Note: python2.7 has been an unofficial requirement for quite some time. > > Update the docs to reflect that. > > >

Re: [Mesa-dev] [PATCH 2/2] configure: use distutils in ax_check_python_mako_module

2018-08-16 Thread Dylan Baker
Quoting Emil Velikov (2018-08-16 09:18:57) > From: Emil Velikov > > Handling the version comparison by hand is a bad idea. Python has a handy > module distutils for that - use it. > > Cc: Dylan Baker > Signed-off-by: Emil Velikov > --- > Not entirely sure if Loo

Re: [Mesa-dev] [PATCH mesa] intel: various python cleanups

2018-08-16 Thread Dylan Baker
print(" %-36s %s%s;" % (type, self.name, dim)) > > prefix = "" > -if len(self.values) > 0 and self.default == None: > +if self.values and self.default == None: Since you changed the other instances to be correct, 'self.

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Fix missing Android platform define.

2018-08-15 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-08-15 09:34:41) > On Wed, Aug 15, 2018 at 6:08 PM, Dylan Baker wrote: > > Quoting Bas Nieuwenhuizen (2018-08-09 17:27:46) > >> CC: > >> --- > >> src/amd/vulkan/Android.mk | 2 ++ > >> src/amd/vulkan/Makefile.am | 2

[Mesa-dev] [PATCH v2 2/5] meson: use python3 module to find python3

2018-08-15 Thread Dylan Baker
This handy helper is nice for OSes that are not linux or BSD like (mac and windows) as it knows how to find python3 in odd places. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5dc9b45eb42..c8bac35659f 100644 --- a/meson.build

[Mesa-dev] [PATCH v2 1/5] meson: Ensure that mako is >= 0.8.0

2018-08-15 Thread Dylan Baker
It's what autotools has required for a long time. --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 7436164946b..5dc9b45eb42 100644 --- a/meson.build +++ b/meson.build @@ -698,9 +698,9 @@ if with_platform_haiku endif

[Mesa-dev] [PATCH v2 5/5] scons: Check for mako 0.8.0

2018-08-15 Thread Dylan Baker
v2: - Use distutils to do the version checking Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107565 --- scons/gallium.py | 13 + 1 file changed, 13 insertions(+) diff --git a/scons/gallium.py b/scons/gallium.py index 659da72c1c3..aa7201a9715 100755 --- a/scons/gallium.py

[Mesa-dev] [PATCH v2 3/5] configure: Enforce python 2.7.x

2018-08-15 Thread Dylan Baker
We don't want to support older versions of python 2 anymore, and we don't support python 3.x in autotools currently. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index c2155a541b0..78672734d06 100644 --- a/configure.ac +++ b/configure.ac

[Mesa-dev] [PATCH v2 4/5] scons: Require python 2.7

2018-08-15 Thread Dylan Baker
less than 2.7 is not supported. v2: - Remove check for python >= 2.0, since we've already enforced 2.7 --- SConstruct | 1 + scons/gallium.py | 4 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/SConstruct b/SConstruct index 6e034fb968f..51dc301a9a8 100644 ---

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Fix missing Android platform define.

2018-08-15 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-08-09 17:27:46) > CC: > --- > src/amd/vulkan/Android.mk | 2 ++ > src/amd/vulkan/Makefile.am | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk > index cee3744f40b..51b03561fa7 100644

Re: [Mesa-dev] [PATCH 5/5] scons: Check for mako 0.8.0

2018-08-14 Thread Dylan Baker
Quoting Jose Fonseca (2018-08-14 11:30:48) > On 14/08/18 18:34, Dylan Baker wrote: > > Bugzilla: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2Fshow_bug.cgi%3Fid%3D107565data=02%7C01%7Cjfonseca%40vmware.com%7C2d939ac68f9948737

Re: [Mesa-dev] [PATCH mesa 3/3] bin: whitespace cleanup

2018-08-14 Thread Dylan Baker
With the one nit, patches 1 and 3 are: Reviewed-by: Dylan Baker I'm not confident on patch 2 to give you an rb. Quoting Eric Engestrom (2018-08-14 10:24:13) > Signed-off-by: Eric Engestrom > --- > bin/git_sha1_gen.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(

Re: [Mesa-dev] [PATCH mesa 1/3] bin: split `write_if_different()` out

2018-08-14 Thread Dylan Baker
Quoting Eric Engestrom (2018-08-14 10:24:11) > Signed-off-by: Eric Engestrom > --- > bin/git_sha1_gen.py | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py > index 68a87e72ec563ce6298f..bc0279ccef16d42bb88d

[Mesa-dev] [PATCH 2/5] meson: use python3 module to find python3

2018-08-14 Thread Dylan Baker
This handy helper is nice for OSes that are not linux or BSD like (mac and windows) as it knows how to find python3 in odd places. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5dc9b45eb42..c8bac35659f 100644 --- a/meson.build

[Mesa-dev] [PATCH 1/5] meson: Ensure that mako is >= 0.8.0

2018-08-14 Thread Dylan Baker
It's what autotools has required for a long time. --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 7436164946b..5dc9b45eb42 100644 --- a/meson.build +++ b/meson.build @@ -698,9 +698,9 @@ if with_platform_haiku endif

[Mesa-dev] [PATCH 4/5] scons: Require python 2.7

2018-08-14 Thread Dylan Baker
less than 2.7 is not supported. --- SConstruct | 1 + 1 file changed, 1 insertion(+) diff --git a/SConstruct b/SConstruct index 6e034fb968f..51dc301a9a8 100644 --- a/SConstruct +++ b/SConstruct @@ -31,6 +31,7 @@ import common # Minimal scons version EnsureSConsVersion(2, 4)

[Mesa-dev] [PATCH 3/5] configure: Enforce python 2.7.x

2018-08-14 Thread Dylan Baker
We don't want to support older versions of python 2 anymore, and we don't support python 3.x in autotools currently. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index c2155a541b0..78672734d06 100644 --- a/configure.ac +++ b/configure.ac

[Mesa-dev] [PATCH 5/5] scons: Check for mako 0.8.0

2018-08-14 Thread Dylan Baker
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107565 --- scons/gallium.py | 13 + 1 file changed, 13 insertions(+) diff --git a/scons/gallium.py b/scons/gallium.py index 92a762a0c1e..e05fb40f157 100755 --- a/scons/gallium.py +++ b/scons/gallium.py @@ -29,6 +29,7 @@

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

2018-08-14 Thread Dylan Baker
I don't think this will be picked up by the stable spotting scripts, does it need a Fixes: tag? Dylan Quoting Jason Ekstrand (2018-08-08 12:05:00) > Commit 4434591bf56a6b0 caused substantially more URB messages in > geometry and tessellation shaders. Before we can really enable this > sort of

Re: [Mesa-dev] [PATCH mesa] travis: install correct version of mako for each build system

2018-08-14 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-08-13 04:15:06) > Meson now uses python3, so let's add a block for Autotools, move that > line into the buildsys-specific blocks, and set the correct version for > Meson. > > Fixes: 2ee1c86d71bee5ddca2c "meson: Build wit

Re: [Mesa-dev] [PATCH] travis: make drivers explicit in Meson targets

2018-08-14 Thread Dylan Baker
Quoting Emil Velikov (2018-08-14 03:00:45) > On 8 August 2018 at 15:36, Juan A. Suarez Romero wrote: > > Like in the autotools target, make the list of drivers to be built in > > each of the Meson targets explicit. > > > > This will help to identify missing dependencies and other issues more > >

Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-13 Thread Dylan Baker
This probably should have a Fixes tag? Quoting Alejandro Piñeiro (2018-08-13 07:50:38) > From AppVeyor #8582, it seems that MSVC doesn't like uint, so this > patch replaces it with unsigned. > --- > > Note that Im not sure if this is the usual solution. As far as I see, > uint is used on other

[Mesa-dev] [ANNOUNCE] mesa 18.1.6

2018-08-13 Thread Dylan Baker
Hi list, I'm announcing the general availability of the 18.1.6 release. This is an 18.1 bugfix release. There are two more 18.1 bug fix releases planned at this time. We've had another busy cycle the last two weeks, there have been roughly 3 dozen fixes in this release. In brief: -

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-13 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-08-13 09:25:01) > On Mon, Aug 13, 2018 at 5:54 PM, Dylan Baker wrote: > > Quoting Emil Velikov (2018-08-13 03:38:13) > >> On 10 August 2018 at 00:57, Dylan Baker wrote: > >> > Quoting Chad Versace (2018-08-09 10:37:33) > >> &

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-13 Thread Dylan Baker
Quoting Emil Velikov (2018-08-13 03:38:13) > On 10 August 2018 at 00:57, Dylan Baker wrote: > > Quoting Chad Versace (2018-08-09 10:37:33) > >> On Tue 07 Aug 2018, Dylan Baker wrote: > >> > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) > >> > &g

Re: [Mesa-dev] [Mesa-stable] [PATCH v2 1/2] i965/miptree: Fix can_blit_slice()

2018-08-10 Thread Dylan Baker
's row_pitch in can_blit_slice instead of its blt_pitch. > > Fixes 0288fe8d0417730bdd5b3477130dd1dc32bdbcd3 > ("i965/miptree: Use the correct BLT pitch") For the scripts in stable to pick this up I believe you need a ":", as in Fixes: abc123 ("some patch") Dylan >

[Mesa-dev] Mesa 18.1.6 Release Notice

2018-08-10 Thread Dylan Baker
Hi list, Due to a busy week and a slip of my mind I didn't get out the announcement for 18.1.6 on Wednesday. Therefore, I'm planning to make the release Monday August 13th, at or around 10AM PDT. It's been another busy cycle for 18.1, currently we have: - 40 Queued - 0 Nominated - 0 Rejected

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-09 Thread Dylan Baker
Quoting Chad Versace (2018-08-09 10:37:33) > On Tue 07 Aug 2018, Dylan Baker wrote: > > Quoting Bas Nieuwenhuizen (2018-08-07

Re: [Mesa-dev] [PATCH v2 7/9] python: Simplify list sorting

2018-08-09 Thread Dylan Baker
All patches up to here (including this one) have been pushed to master. I had comments on patch 8, and I want to follow up with our CI team to make sure we have all the dependencies for python 3 in our CI. Dylan Quoting Mathieu Bridon (2018-08-09 01:27:24) > Instead of copying the list, then

Re: [Mesa-dev] [PATCH v2 8/9] python: Rework bytes/unicode string handling

2018-08-09 Thread Dylan Baker
ain, but assuming everything still looks good I'll be merging everything but this patch and the next patch today. For every patch up to this point: Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-08-09 01:27:25) > In both Python 2 and 3, opening a file without specifying the mode will >

Re: [Mesa-dev] [PATCH v3 08/48] meson: fix dl detection on non cygwin windows

2018-08-09 Thread Dylan Baker
Quoting Eric Engestrom (2018-08-09 08:36:55) > On Monday, 2018-08-06 17:50:48 -0700, Dylan Baker wrote: > > --- > > meson.build | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/meson.build b/meson.build > >

Re: [Mesa-dev] [PATCH v3 20/48] meson: build graw-gdi target

2018-08-09 Thread Dylan Baker
Quoting Eric Anholt (2018-08-07 11:14:16) > Dylan Baker writes: > > > --- > > src/gallium/meson.build | 4 ++- > > src/gallium/targets/graw-gdi/meson.build | 36 > > 2 files changed, 39 insertions(+), 1 deletion(-) >

Re: [Mesa-dev] [PATCH v3 19/48] meson: build libgl-gdi target

2018-08-09 Thread Dylan Baker
Quoting Eric Anholt (2018-08-07 11:12:27) > Dylan Baker writes: > > > --- > > src/gallium/meson.build | 1 + > > src/gallium/targets/libgl-gdi/meson.build | 44 +++ > > 2 files changed, 45 insertions(+) > > create mode

Re: [Mesa-dev] [Mesa-stable] [PATCH v4 1/2] wayland/egl: initialize window surface size to window size

2018-08-09 Thread Dylan Baker
Quoting Juan A. Suarez Romero (2018-08-07 08:49:36) > When creating a windows surface with eglCreateWindowSurface(), the > width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is > invalid until buffers are updated (like calling glClear()). > > But according to EGL 1.5 spec, section

Re: [Mesa-dev] [PATCH v3 14/48] meson: Make shader-cache a trillean instead of boolean

2018-08-08 Thread Dylan Baker
Quoting Eric Anholt (2018-08-07 10:58:52) > Dylan Baker writes: > > > So that it can be implicitly disabled on windows, where it doesn't > > compile. > > I don't see how this option successfully controls the shader cache being > built. The entire shader cache code

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Dylan Baker
Quoting Emil Velikov (2018-08-08 04:04:51) > On 8 August 2018 at 06:42, Marek Olšák wrote: > > From: Marek Olšák > > > > This is needed for exposing the samplerBuffer functions under > > EXT_gpu_shader4. > > > > glTexBufferEXT is defined in glapi, but "make check" fails. > > What am I doing

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-08 Thread Dylan Baker
Quoting Eric Engestrom (2018-08-08 03:46:05) > On Tuesday, 2018-08-07 16:49:17 -0700, Dylan Baker wrote: > > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) > > > > > > anv_extensions_c = custom_target( > > > @@ -36,10 +37,11 @@ anv_extensio

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-07 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) >

Re: [Mesa-dev] [PATCH 12/26] python: Fix unequality comparisons

2018-08-07 Thread Dylan Baker
Quoting Mathieu Bridon (2018-07-06 02:25:53) > On Thu, 2018-07-05 at 09:10 -0700, Dylan Baker wrote: > > Quoting Mathieu Bridon (2018-07-05 06:17:43) > > > +def __ne__(self, other): > > > +return not self.__eq__(other) > > > > This can be

Re: [Mesa-dev] [PATCH 15/26] python: Specify the template output encoding

2018-08-07 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-05 06:17:46) > We're trying to write a unicode string (i.e decoded) to a file opened > in binary (i.e encoded) mode. > > In Python 2 this works, because of the automatic conversion between > byte and unicode strings. &

Re: [Mesa-dev] [PATCH 15/26] python: Specify the template output encoding

2018-08-07 Thread Dylan Baker
Quoting Mathieu Bridon (2018-07-06 02:34:56) > On Thu, 2018-07-05 at 09:14 -0700, Dylan Baker wrote: > > Does it make more sense to encode, or to use io.open and open the > > file in text mode? I've gone back and forth on this myself several > > times. > > Same here, bo

Re: [Mesa-dev] [PATCH 16/26] python: Explicitly use lists

2018-08-07 Thread Dylan Baker
Quoting Mathieu Bridon (2018-07-06 02:43:46) > On Thu, 2018-07-05 at 09:31 -0700, Dylan Baker wrote: > > Quoting Mathieu Bridon (2018-07-05 06:17:47) > > > On Python 2, the builtin functions filter() and zip() would return > > > lists. > > > >

Re: [Mesa-dev] [PATCH v3 05/48] gallium: fix ddebug on windows

2018-08-07 Thread Dylan Baker
e content of the patch. > > Marek > > On Mon, Aug 6, 2018 at 8:50 PM, Dylan Baker wrote: > > By including the proper headers for getpid and for mkdir. > > > > Signed-off-by: Dylan Baker > > Reviewed-by: Marek Olšák > > --- > > src/gallium/auxiliary

Re: [Mesa-dev] [PATCH v2 11/26] python: Fix rich comparisons

2018-08-07 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-17 13:57:39) > Python 3 doesn't call objects __cmp__() methods any more to compare > them. Instead, it requires implementing the rich comparison methods > explicitly: __eq__(), __ne(), __lt__(), __le__(), __gt__() a

Re: [Mesa-dev] [PATCH v3 10/26] python: Use explicit integer divisions

2018-08-07 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-25 02:53:54) > In Python 2, divisions of integers return an integer: > > >>> 32 / 4 > 8 > > In Python 3 though, they return floats: > > >>> 32 / 4 > 8.0 > > However,

Re: [Mesa-dev] [PATCH 1/3] meson: use dependency()+find_program() for wayland-scanner

2018-08-07 Thread Dylan Baker
Quoting Emil Velikov (2018-08-07 08:41:36) > On 6 August 2018 at 17:39, Dylan Baker wrote: > > Quoting Emil Velikov (2018-06-28 07:35:44) > >> From: Emil Velikov > >> > >> Helps when the native wayland-scanner is located outside of PATH. > >> Inspire

[Mesa-dev] [PATCH v3 38/48] meson: don't build gallium trivial tests on windows

2018-08-06 Thread Dylan Baker
They require the pipe-loaders, which require xmlconfig, which doesn't build with msvc. --- src/gallium/tests/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 0ee04350c87..15b9f549647 100644 ---

[Mesa-dev] [PATCH v3 34/48] util/tests: Use define instead of VLA

2018-08-06 Thread Dylan Baker
To allow the this test to be built with MSVC, which doesn't support VLAs. --- src/util/tests/hash_table/clear.c | 13 +++-- src/util/tests/hash_table/delete_management.c | 13 +++-- src/util/tests/hash_table/insert_many.c | 11 ++-

[Mesa-dev] [PATCH v3 43/48] meson: maintain names of shared API libraries

2018-08-06 Thread Dylan Baker
Mesa uses the lib prefix, and doesn't use a version for it's dynamic libraries, which meson defaults to. v2: - this patch --- src/mapi/es1api/meson.build | 2 ++ src/mapi/es2api/meson.build | 2 ++ src/mapi/shared-glapi/meson.build | 2 ++ 3 files changed, 6 insertions(+) diff --git

[Mesa-dev] [PATCH v3 14/48] meson: Make shader-cache a trillean instead of boolean

2018-08-06 Thread Dylan Baker
So that it can be implicitly disabled on windows, where it doesn't compile. v2: - Use an auto-option rather than automagic. - fix shader_cache check (== -> !=) --- meson.build | 16 +--- meson_options.txt | 5 +++-- 2 files changed, 16 insertions(+), 5 deletions(-) diff

[Mesa-dev] [PATCH v3 37/48] meson: Set visibility and compat args for graw

2018-08-06 Thread Dylan Baker
--- src/gallium/targets/graw-gdi/meson.build | 1 + src/gallium/targets/graw-null/meson.build | 2 ++ src/gallium/targets/graw-xlib/meson.build | 1 + 3 files changed, 4 insertions(+) diff --git a/src/gallium/targets/graw-gdi/meson.build b/src/gallium/targets/graw-gdi/meson.build index

[Mesa-dev] [PATCH v3 35/48] meson: Don't build glsl cache_test for windows

2018-08-06 Thread Dylan Baker
v2: - Use new with_shader_cache variable instead of host_machine.system() == 'windows' --- src/compiler/glsl/tests/meson.build | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build

[Mesa-dev] [PATCH v3 24/48] util/xmlconfig: include strndup.h for windows

2018-08-06 Thread Dylan Baker
--- src/util/xmlconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/xmlconfig.c b/src/util/xmlconfig.c index ba657294c1c..e204e52b71d 100644 --- a/src/util/xmlconfig.c +++ b/src/util/xmlconfig.c @@ -36,6 +36,7 @@ #include #include #include +#include "strndup.h" #include

[Mesa-dev] [PATCH v3 46/48] appveyor: Add support for meson as well as scons

2018-08-06 Thread Dylan Baker
--- appveyor.yml | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 86440f0d76a..26f50ce2596 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -42,20 +42,29 @@ os: Visual Studio 2015 environment:

[Mesa-dev] [PATCH v3 30/48] meson: disable sse4.1 optimizations with msvc

2018-08-06 Thread Dylan Baker
There isn't an obvious command line switch here, /arch:AVX *might* be the right thing, but meson doesn't know what to do here either and leaves the -msse4.1 and -mstackrealign. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v3 04/48] meson: add a expat subproject

2018-08-06 Thread Dylan Baker
--- meson.build| 2 +- subprojects/expat.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/expat.wrap diff --git a/meson.build b/meson.build index 6960db9e9de..c7dd5ddfec6 100644 --- a/meson.build +++ b/meson.build @@ -1064,7

[Mesa-dev] [PATCH v3 00/48] Meson for windows

2018-08-06 Thread Dylan Baker
Mostly this is the same thing as before, just rebased on master. A couple of the patches from v2 have already landed. I've also fix the bad rebase of Erik's patch to use the python module for finding python, and updated the appveyor instance to work, and use msbuild instead of ninja. Dylan Baker

[Mesa-dev] [PATCH v3 36/48] glsl/tests: define ssize_t on windows

2018-08-06 Thread Dylan Baker
--- src/compiler/glsl/tests/blob_test.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl/tests/blob_test.c b/src/compiler/glsl/tests/blob_test.c index 1cc97236e7e..21b8b1efdc1 100644 --- a/src/compiler/glsl/tests/blob_test.c +++ b/src/compiler/glsl/tests/blob_test.c @@

[Mesa-dev] [PATCH v3 39/48] meson: Fix gtest linkage on msvc

2018-08-06 Thread Dylan Baker
We need to add an extra flag (/SUBSYSTEM:CONSOLE) to get the msvc linker to find main() in a static library. --- src/gtest/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gtest/meson.build b/src/gtest/meson.build index 91a49240416..ed0d6974bd3 100644 ---

[Mesa-dev] [PATCH v3 31/48] meson: add switches for SWR with MSVC

2018-08-06 Thread Dylan Baker
--- src/gallium/drivers/swr/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/meson.build b/src/gallium/drivers/swr/meson.build index b95c8bc1bf8..ec4d80e4bb2 100644 --- a/src/gallium/drivers/swr/meson.build +++

[Mesa-dev] [PATCH v3 44/48] meson: Use python module to find python2 on windows

2018-08-06 Thread Dylan Baker
Signed-off-by: Eric Engestrom Reviewed-by: Dylan Baker --- meson.build | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 100d12f475d..bbfd7c3c73f 100644 --- a/meson.build +++ b/meson.build @@ -710,7 +710,15 @@ if with_platform_haiku

<    3   4   5   6   7   8   9   10   11   12   >