Reviewed by Serge Martin <edb+m...@sigluy.net>
Can it be pushed to master, and if so, can it also be pushed to 11.0 branch?
Serge
> ---
> src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a
On Wednesday 19 August 2015 11:56:08 Zoltan Gilian wrote:
There is no MDOperand in llvm 3.5.
v2: Check if kernel metadata is present to avoid crash (EdB).
v3: Second attempt to avoid crash: switch off metadata query for llvm 3.6.
Since the change you made for image support won't be backport
On Sunday 09 August 2015 11:52:13 orome wrote:
On Sun, 2015-08-09 at 15:39 +0200, Zoltan Gilian wrote:
There is no MDOperand in llvm 3.5.
v2: Check if kernel metadata is present to avoid crash (EdB).
still builds for me.
Sadly, it's still crashing for me.
auto kernel_node
EdB
On Saturday 15 August 2015 16:28:55 Zoltan Gilian wrote:
---
src/gallium/state_trackers/clover/api/transfer.cpp | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/gallium/state_trackers/clover/api/transfer.cpp
b/src/gallium/state_trackers/clover/api/transfer.cpp
As sugested by Tom a long time ago
and in order to be able to create Piglit tests
v2:
replace NOT_SUPPORTED_BY_CL_1_1 macro with an inline function
remove extra space in clLinkProgram arg
v3:
use __func__
v4:
back to a macro, it make more sense to use it with __func__
---
As sugested by Tom a long time ago
and in order to be able to create Piglit tests
v2:
replace NOT_SUPPORTED_BY_CL_1_1 macro with an inline function
remove extra space in clLinkProgram arg
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 10 -
As sugested by Tom a long time ago
and in order to be able to create Piglit tests
v2:
replace NOT_SUPPORTED_BY_CL_1_1 macro with an inline function
remove extra space in clLinkProgram arg
v3:
use __func__
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 10 -
As a side effect, this fix clRetain/ReleaseEvent Piglit test
---
src/gallium/state_trackers/clover/api/transfer.cpp | 29 --
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/src/gallium/state_trackers/clover/api/transfer.cpp
---
src/gallium/state_trackers/clover/api/dispatch.hpp | 23 +-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/src/gallium/state_trackers/clover/api/dispatch.hpp
b/src/gallium/state_trackers/clover/api/dispatch.hpp
index ffae1ae..781b54e 100644
---
---
src/gallium/state_trackers/clover/api/dispatch.hpp | 23 +-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/src/gallium/state_trackers/clover/api/dispatch.hpp
b/src/gallium/state_trackers/clover/api/dispatch.hpp
index ffae1ae..781b54e 100644
---
EdB (2):
clover: make dispatch matches functions defs
clover: stub missing CL 1.2 functions
src/gallium/state_trackers/clover/api/dispatch.cpp | 10 -
src/gallium/state_trackers/clover/api/dispatch.hpp | 23 +++-
src/gallium/state_trackers/clover/api/kernel.cpp
As sugested by Tom a long time ago
and in order to be able to create Piglit tests
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 10 -
src/gallium/state_trackers/clover/api/kernel.cpp | 8 +++
src/gallium/state_trackers/clover/api/memory.cpp | 25 --
---
src/gallium/state_trackers/clover/api/program.cpp | 33 ++
src/gallium/state_trackers/clover/core/program.hpp | 4 +--
2 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/src/gallium/state_trackers/clover/api/program.cpp
---
src/gallium/state_trackers/clover/api/program.cpp | 33 +++
1 file changed, 33 insertions(+)
diff --git a/src/gallium/state_trackers/clover/api/program.cpp
b/src/gallium/state_trackers/clover/api/program.cpp
index 553bc83..086f952 100644
---
---
src/gallium/state_trackers/clover/api/program.cpp | 35 ++
src/gallium/state_trackers/clover/core/error.hpp | 7 +
src/gallium/state_trackers/clover/core/program.cpp | 4 +++
src/gallium/state_trackers/clover/core/program.hpp | 1 +
---
src/gallium/state_trackers/clover/api/program.cpp | 19 +-
.../state_trackers/clover/core/compiler.hpp| 7 +-
src/gallium/state_trackers/clover/core/error.hpp | 7 +
src/gallium/state_trackers/clover/core/program.cpp | 41 +++-
This serie add OpenCL 1.2 clLinkProgram.
However, it lacks the binary type part that is mandatory for input validation
and also for CL_PROGRAM_BINARY_TYPE query. This will be adressed
in another serie once we agree on the way to store it.
EdB (3):
clover: separate compile and link stages
Return an API object from an intrusive reference to a Clover object,
incrementing the reference count of the object.
Reviewed-by: Francisco Jerez curroje...@riseup.net
---
src/gallium/state_trackers/clover/api/util.hpp | 12
1 file changed, 12 insertions(+)
diff --git
Hello
Would you prefer --enable-opencl-icd that install in
$sysconfdir/OpenCL/vendors by default and can be forced to /etc/OpenCL/vendors
with something like --enable-opencl-icd=standard-path?
EdB
On Wednesday 06 May 2015 23:34:26 EdB wrote:
The standard ICD file path is /etc/OpenCL/vendor
s/build_error/compile_error in order to match the stored OpenCL status code.
Make program::build catch and log every OpenCL error.
Make tgsi error triggering uniform with the llvm one.
---
Note that compile_error class is keep for later use
.../state_trackers/clover/core/compiler.hpp| 3
This serie add OpenCL 1.2 clLinkProgram.
However, it lacks the binary type part that is mandatory for input validation
and also for CL_PROGRAM_BINARY_TYPE query. This will be adressed
in another serie once we agree on the way to store it.
EdB (3):
clover: separate compile and link stages
Return an API object from an intrusive smart reference Clover object,
incrementing the reference count of the object.
---
src/gallium/state_trackers/clover/api/util.hpp | 12
1 file changed, 12 insertions(+)
diff --git a/src/gallium/state_trackers/clover/api/util.hpp
(resending because git send-email crashed)
This serie add OpenCL 1.2 clLinkProgram.
However, it lacks the binary type part that is mandatory for input validation
and also for CL_PROGRAM_BINARY_TYPE query. This will be adressed
in another serie once we agree on the way to store it.
EdB (3
---
src/gallium/state_trackers/clover/api/program.cpp | 6 +-
.../state_trackers/clover/core/compiler.hpp| 7 +-
src/gallium/state_trackers/clover/core/error.hpp | 21 ++
src/gallium/state_trackers/clover/core/program.cpp | 93 ++-
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-
src/gallium/state_trackers/clover/api/program.cpp | 31 ++
src/gallium/state_trackers/clover/core/program.cpp | 4 +++
src/gallium/state_trackers/clover/core/program.hpp | 1 +
4 files changed, 37
On Sunday 05 July 2015 18:15:33 Francisco Jerez wrote:
Hi EdB, a bunch of comments inline,
Hello
EdB edb+m...@sigluy.net writes:
---
src/gallium/state_trackers/clover/api/program.cpp | 6 +-
.../state_trackers/clover/core/compiler.hpp| 7 +-
src/gallium
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-
src/gallium/state_trackers/clover/api/program.cpp | 31 +++
.../state_trackers/clover/core/compiler.hpp| 6 +
src/gallium/state_trackers/clover/core/error.hpp | 7 +
src/gallium/state_trackers/clover/core/program.cpp
they shouldn't produce the same output
---
src/gallium/state_trackers/clover/api/program.cpp | 2 +-
.../state_trackers/clover/core/compiler.hpp| 9 +++-
src/gallium/state_trackers/clover/core/program.cpp | 46 +---
src/gallium/state_trackers/clover/core/program.hpp | 5 +-
EdB (3):
clover: seperate build and compile stages
clover: override ret_object
clover: add clLinkProgram
src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-
src/gallium/state_trackers/clover/api/program.cpp | 33 ++-
src/gallium/state_trackers/clover/api/util.hpp | 12
Return an API object from an intrusive smart reference Clover object,
incrementing the reference count of the object.
---
src/gallium/state_trackers/clover/api/util.hpp | 12
1 file changed, 12 insertions(+)
diff --git a/src/gallium/state_trackers/clover/api/util.hpp
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm/invocation.cpp
index 7d2d941..fc7ab9c 100644
---
, no other directories overridden in configure command.
thanks
EdB
--Aaron
On Wed, May 6, 2015 at 4:34 PM, EdB edb+m...@sigluy.net wrote:
The standard ICD file path is /etc/OpenCL/vendor/.
However it doesn't fit well with custom build.
This option allow ICD vendor file installation path
The standard ICD file path is /etc/OpenCL/vendor/.
However it doesn't fit well with custom build.
This option allow ICD vendor file installation path override
---
configure.ac | 46 +++---
src/gallium/targets/opencl/Makefile.am | 2 +-
2
The standard ICD file path is /etc/OpenCL/vendor/.
However it doesn't fit well with custom build.
This option allow ICD vendor file installation path override
---
configure.ac | 6 ++
src/gallium/targets/opencl/Makefile.am | 2 +-
2 files changed, 7 insertions(+), 1
---
src/gallium/state_trackers/clover/Makefile.sources | 1 -
src/gallium/state_trackers/clover/api/program.cpp | 14 +-
.../state_trackers/clover/core/compiler.hpp| 4 +-
src/gallium/state_trackers/clover/core/error.hpp | 2 -
src/gallium/state_trackers/clover/core/kernel.cpp
---
src/gallium/state_trackers/clover/Makefile.sources | 1 -
src/gallium/state_trackers/clover/api/program.cpp | 2 +-
.../state_trackers/clover/core/compiler.hpp| 2 +-
src/gallium/state_trackers/clover/core/error.hpp | 6 ++--
src/gallium/state_trackers/clover/util/compat.cpp |
Since clover should compile use -std=c++11,
compat classes are no longer neccessary
EdB (4):
clover: remove compat class that matche std one
clover: remove compat::string
clover: make module::symbol::name a string
clover: remove util/compat
src/gallium/state_trackers/clover
---
src/gallium/state_trackers/clover/api/program.cpp | 3 +--
src/gallium/state_trackers/clover/core/module.cpp | 21 +
src/gallium/state_trackers/clover/core/module.hpp | 4 ++--
3 files changed, 24 insertions(+), 4 deletions(-)
diff --git
---
src/gallium/state_trackers/clover/api/program.cpp | 2 +-
.../state_trackers/clover/core/compiler.hpp| 14 +--
src/gallium/state_trackers/clover/core/error.hpp | 4 +-
src/gallium/state_trackers/clover/core/program.cpp | 2 +-
.../state_trackers/clover/llvm/invocation.cpp
On Tuesday 21 April 2015 12:54:28 Emil Velikov wrote:
On 20/04/15 21:34, EdB wrote:
Later we can remove the compat code.
---
src/gallium/state_trackers/clover/Makefile.am | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/state_trackers/clover
Later we can remove the compat code
According to Francisco Jerez, it happen that some time llvm requiring exotic
compilation flags and it would be preferable not to to contaminate the rest of
the clover build and keep the 3 statics libs
---
src/gallium/state_trackers/clover/Makefile.am | 3 ++-
Later we can remove the compat code.
---
src/gallium/state_trackers/clover/Makefile.am | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/state_trackers/clover/Makefile.am
b/src/gallium/state_trackers/clover/Makefile.am
index 62c13fa..54b6fff 100644
---
Clover not longer compile with llvm = 3.5.0 since e1d363b3.
e1d363b3 implies c++11 and llvm 3.5.0 CXXFLAGS provided it.
No one seems to have noticed it, it's now official.
---
configure.ac | 32 +++-
1 file changed, 11 insertions(+), 21 deletions(-)
diff --git
Clover not longer compile with llvm = 3.5.0 since e1d363b3
e1d363b3 implies c++11 and llvm 3.5.0 CXXFLAGS provided it
No one seems to have noticed it. It's now official.
---
configure.ac | 32 ---
Ping
Le 2014-12-14 11:31, EdB a écrit :
Hello,
This serie add the neccesary bits needed for clLinkProgram.
Patches from 1 to 2 are llvm/invocation.cpp little reorganisation.
Patches 3 to 5 rework our clCompileProgram implementation.
Patch 6 is for returning clover smart ptr to the API side
detecting the fpclassify function. So, for now, we'll
just disable it until we actually have a C++ user.
Tested-by: Tom Stellard thomas.stell...@amd.com
Tested-by: EdB edb+m...@sigluy.net
Reported-by: Tom Stellard t...@stellard.net
Should use my AMD email here too ^ or you can drop
---
depends on clLinkProgram serie
src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-
src/gallium/state_trackers/clover/api/dispatch.hpp | 8 +-
src/gallium/state_trackers/clover/api/kernel.cpp | 51
src/gallium/state_trackers/clover/core/kernel.cpp | 6 ++
CL_PROGRAM_BINARY_TYPE have been added to clGetProgramBuildInfo in CL1.2
---
src/gallium/state_trackers/clover/api/program.cpp | 4 +++
src/gallium/state_trackers/clover/core/program.cpp | 31 +-
src/gallium/state_trackers/clover/core/program.hpp | 1 +
3 files changed, 29
---
src/gallium/state_trackers/clover/api/device.cpp | 21 +
src/gallium/state_trackers/clover/core/device.cpp | 11 +++
src/gallium/state_trackers/clover/core/device.hpp | 2 ++
3 files changed, 34 insertions(+)
diff --git
patch 1 depends on clLinkProgram serie
patch 2 should be fine on master
EdB (2):
clover: support CL_PROGRAM_BINARY_TYPE (CL1.2)
clover: add missing clGetDeviceInfo CL1.2 queries
src/gallium/state_trackers/clover/api/device.cpp | 21 +++
src/gallium/state_trackers/clover/api
On Friday, December 19, 2014 01:08:31 PM Tom Stellard wrote:
On Sun, Dec 14, 2014 at 11:31:22AM +0100, EdB wrote:
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/clover
On Friday, December 19, 2014 01:14:47 PM Tom Stellard wrote:
On Sun, Dec 14, 2014 at 11:31:23AM +0100, EdB wrote:
OpenCL 1.2 make distinction between 3 binaries kind:
executable as produce by clBuildProgram and clLinkProgam
compiled as produce by clCompileProgram
library as produce
OpenCL 1.2 make distinction between 3 binaries kind:
executable as produce by clBuildProgram and clLinkProgam
compiled as produce by clCompileProgram
library as produce by clLinkProgam with -create-library option
---
src/gallium/state_trackers/clover/core/kernel.cpp | 2 +-
they produce different binaries
---
src/gallium/state_trackers/clover/api/program.cpp | 2 +-
.../state_trackers/clover/core/compiler.hpp| 12 ++-
src/gallium/state_trackers/clover/core/program.cpp | 48 +++--
src/gallium/state_trackers/clover/core/program.hpp | 6 +-
clCreateKernel should check that there is a least one executable
available, otherwise it has to trigger CL_INVALID_PROGRAM_EXECUTABLE
---
src/gallium/state_trackers/clover/api/kernel.cpp | 3 +++
src/gallium/state_trackers/clover/core/program.cpp | 11 +++
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm/invocation.cpp
index 10dbe08..510e195 100644
---
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-
src/gallium/state_trackers/clover/api/program.cpp | 31 +
.../state_trackers/clover/core/compiler.hpp| 6 +
src/gallium/state_trackers/clover/core/error.hpp | 7 ++
Return an API object from an intrusive smart reference Clover object,
incrementing the reference count of the object.
---
src/gallium/state_trackers/clover/api/util.hpp | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/gallium/state_trackers/clover/api/util.hpp
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-
src/gallium/state_trackers/clover/api/program.cpp | 31 +
.../state_trackers/clover/core/compiler.hpp| 6 +
src/gallium/state_trackers/clover/core/error.hpp | 7 ++
---
.../state_trackers/clover/llvm/invocation.cpp | 26 +-
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm/invocation.cpp
index 5265d10..10dbe08 100644
---
on this version.
As I said 1 to 6 can be pushed before 7 as clean up and fixes.
And I also want to be sure 7 is the right way to go.
Regards
EdB
EdB (7):
clover: move CLOVER_DEBUG stuff into anonymous ns
clover: Dump the OpenCL C code earlier
clover: split module::section::text
clover: clCreateKernel
On Sunday, December 14, 2014 11:31:28 AM EdB wrote:
This one went out by mistake (I forgot to remove -1 option on git send-email).
It's the same as [Patch 7/7]
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-
src/gallium/state_trackers/clover/api/program.cpp | 31
those flags have been introduced in OpenCL 1.2
---
src/gallium/state_trackers/clover/api/memory.cpp | 15 --
src/gallium/state_trackers/clover/api/transfer.cpp | 32 --
2 files changed, 42 insertions(+), 5 deletions(-)
diff --git
On Monday 10 November 2014 19:04:54 Francisco Jerez wrote:
EdB edb+m...@sigluy.net writes:
clCompileProgram should return CL_INVALID_COMPILER_OPTIONS
instead of CL_INVALID_BUILD_OPTIONS
Looks good to me,
Reviewed-by: Francisco Jerez curroje...@riseup.net
I don't have commit access. Can
clCreateContext no longer crash when CL_CONTEXT_PLATFORM is invalid
---
src/gallium/state_trackers/clover/api/context.cpp | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/clover/api/context.cpp
This serie add CL_MEM_HOST_WRITE_ONLY, CL_MEM_HOST_READ_ONLY and
CL_MEM_HOST_NO_ACCESS checks
Those flags should be inherited when creting sub buffer.
So I change clGetMemObjectInfo to report them and the otherd that should also
be reported.
EdB (2):
clover: add CL_MEM_HOST_* flags checks
those flags have been introduced in OpenCL 1.2
---
src/gallium/state_trackers/clover/api/memory.cpp | 15 --
src/gallium/state_trackers/clover/api/transfer.cpp | 32 --
2 files changed, 42 insertions(+), 5 deletions(-)
diff --git
when call cbCreateSubBuffer when followings memory flags are not set
they should be inherited from parent buffer.
Report them when calling clGetMemObjectInfo
flags:
CL_MEM_READ_WRITE, CL_MEM_READ_ONLY, CL_MEM_WRITE_ONLY,
CL_MEM_USE_HOST_PTR, CL_MEM_ALLOC_HOST_PTR, CL_MEM_COPY_HOST_PTR,
On Tuesday 11 November 2014 17:42:42 EdB wrote:
those flags have been introduced in OpenCL 1.2
---
src/gallium/state_trackers/clover/api/memory.cpp | 15 --
src/gallium/state_trackers/clover/api/transfer.cpp | 32
-- 2 files changed, 42 insertions(+), 5 deletions
On Monday 10 November 2014 19:03:43 Francisco Jerez wrote:
EdB edb+m...@sigluy.net writes:
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm/invocation.cpp
index 3a4fcf0..d29f5a6 100644
---
/invocation.cpp. It could have been a stand-alone one
EdB (2):
clover: fix tab/space and alignement
clover: clCompileProgram CL_INVALID_COMPILER_OPTIONS
src/gallium/state_trackers/clover/api/program.cpp | 2 ++
src/gallium/state_trackers/clover/llvm/invocation.cpp | 8
2 files
clCompileProgram should return CL_INVALID_COMPILER_OPTIONS
instead of CL_INVALID_BUILD_OPTIONS
---
src/gallium/state_trackers/clover/api/program.cpp | 2 ++
src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git
should trigger CL_INVALID_VALUE
if device_list is NULL and num_devices is greater than zero.
introduced by e5468dfa523be2a7a0d04bb9efcf8ae780957563
---
src/gallium/state_trackers/clover/api/program.cpp | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git
to allow empty objs() list checks
---
src/gallium/state_trackers/clover/core/object.hpp | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/gallium/state_trackers/clover/core/object.hpp
b/src/gallium/state_trackers/clover/core/object.hpp
index 697565c..01fa779 100644
---
Le 2014-10-20 09:42, Francisco Jerez a écrit :
Francisco Jerez curroje...@riseup.net writes:
EdB edb+m...@sigluy.net writes:
Sorry, I didn't test it enought.
It needs the two following patch in order to work ok
EdB (2):
clover: add allow_empty_tag
clover: don't return CL_INVALID_VALUE
Le 2014-10-20 10:56, Emil Velikov a écrit :
Seems to be a typo judging from the overall declaration of the
template.
Right. Thanks
EdB
Cc: EdB edb+m...@sigluy.net
Cc: Francisco Jerez curroje...@riseup.net
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/gallium/state_trackers
On Friday 10 October 2014 15:45:51 Tom Stellard wrote:
On Fri, Oct 10, 2014 at 07:51:40PM +0200, EdB wrote:
On Friday 10 October 2014 10:16:08 Tom Stellard wrote:
On Thu, Oct 09, 2014 at 09:22:46PM +0200, EdB wrote:
On Thursday, October 09, 2014 06:29:40 AM Tom Stellard wrote
Sorry, I didn't test it enought.
It needs the two following patch in order to work ok
EdB (2):
clover: add allow_empty_tag
clover: don't return CL_INVALID_VALUE if there is no header
src/gallium/state_trackers/clover/api/program.cpp | 2 +-
src/gallium/state_trackers/clover/core/object.hpp
---
src/gallium/state_trackers/clover/api/program.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/clover/api/program.cpp
b/src/gallium/state_trackers/clover/api/program.cpp
index 1b9311f..e3ef8d0 100644
---
On Friday 10 October 2014 10:16:08 Tom Stellard wrote:
On Thu, Oct 09, 2014 at 09:22:46PM +0200, EdB wrote:
On Thursday, October 09, 2014 06:29:40 AM Tom Stellard wrote:
On Sun, Sep 28, 2014 at 12:57:22PM +0200, EdB wrote:
---
src/gallium/state_trackers/clover/api/dispatch.cpp
On Thursday, October 09, 2014 06:29:40 AM Tom Stellard wrote:
On Sun, Sep 28, 2014 at 12:57:22PM +0200, EdB wrote:
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-
src/gallium/state_trackers/clover/api/program.cpp | 39
+++--- .../state_trackers/clover
://cgit.freedesktop.org/~currojerez/mesa/log/?h=clover-compile-program
and it's ok
EdB edb+m...@sigluy.net writes:
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-
src/gallium/state_trackers/clover/api/program.cpp | 39
+++--- .../state_trackers/clover/core/compiler.hpp
---
src/gallium/state_trackers/clover/util/compat.hpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/state_trackers/clover/util/compat.hpp
b/src/gallium/state_trackers/clover/util/compat.hpp
index dd20ef0..f938e74 100644
--- a/src/gallium/state_trackers/clover/util/compat.hpp
This serie add clCompile function as mandatory for CL 1.2
EdB (3):
clover: add a simple compat::pair
clover: add vector_ref default constructor
clover: add clCompile
src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-
src/gallium/state_trackers/clover/api/program.cpp | 39
std::pair is not c++98/c++11 safe
---
src/gallium/state_trackers/clover/util/compat.hpp | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/gallium/state_trackers/clover/util/compat.hpp
b/src/gallium/state_trackers/clover/util/compat.hpp
index 7305577..dd20ef0 100644
---
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +-
src/gallium/state_trackers/clover/api/program.cpp | 39 +++---
.../state_trackers/clover/core/compiler.hpp| 12 ---
src/gallium/state_trackers/clover/core/error.hpp | 2 +-
On Friday, September 05, 2014 09:30:52 AM Francisco Jerez wrote:
Jan Vesely jan.ves...@rutgers.edu writes:
It's unsafe as compat::string is not null terminated.
Fixes garbage log on successful build.
Signed-off-by: Jan Vesely jan.ves...@rutgers.edu
---
It's obviously not needed in
Le 2014-08-20 16:03, Francisco Jerez a écrit :
EdB e...@sigluy.net writes:
Each time you call c_str() it will grow up, may be you could check if
the string is already \0 terminated before adding it.
Nope, that's not how it works. Every time c_str() is called the size
of
the underlying
On Monday, August 18, 2014 09:20:03 AM Francisco Jerez wrote:
EdB edb+m...@sigluy.net writes:
compact::string is not \0 terminated.
size() need to be used for std::string creation
---
src/gallium/state_trackers/clover/core/program.cpp | 4 ++--
1 file changed, 2 insertions(+), 2
On Monday, August 18, 2014 09:29:02 AM Francisco Jerez wrote:
EdB edb+m...@sigluy.net writes:
make resize work like std::vector
reserve take advantage of capacity
rename members to be uniform with other class
---
src/gallium/state_trackers/clover/core/module.cpp | 2 +-
src
On Sunday, August 17, 2014 11:50:12 PM Francisco Jerez wrote:
EdB edb+m...@sigluy.net writes:
Hello
There is a crash with your version.
This one works
Oops, sorry for that. It seems like a hack to me to force the kernel
reference count to one to keep it from being destroyed... Can
On Saturday, August 16, 2014 04:37:08 PM Francisco Jerez wrote:
EdB edb+m...@sigluy.net writes:
program build should failed if there is created kernel attached to program
piglit error:
Trigger CL_INVALID_OPERATION if there are kernel objects attached to
program
[...]
How about
Hello
There is a crash with your version.
This one works
---
diff --git a/src/gallium/state_trackers/clover/api/program.cpp
b/src/gallium/state_trackers/clover/api/program.cpp
index b81ce69..ab6cf7c 100644
--- a/src/gallium/state_trackers/clover/api/program.cpp
+++
On Saturday, August 16, 2014 08:57:01 PM Francisco Jerez wrote:
EdB edb+m...@sigluy.net writes:
---
src/gallium/state_trackers/clover/api/program.cpp | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/gallium/state_trackers/clover/api/program.cpp
b/src
program build should failed if there is created kernel attached to program
piglit error:
Trigger CL_INVALID_OPERATION if there are kernel objects attached to program
---
src/gallium/state_trackers/clover/api/kernel.cpp | 10 --
src/gallium/state_trackers/clover/core/kernel.cpp | 1 +
On Saturday, August 09, 2014 01:18:57 AM Ilia Mirkin wrote:
On Fri, Aug 8, 2014 at 10:10 PM, EdB edb+m...@sigluy.net wrote:
---
src/gallium/state_trackers/clover/api/program.cpp | 3 +++
src/gallium/state_trackers/clover/core/program.cpp | 8
src/gallium/state_trackers
---
src/gallium/state_trackers/clover/api/program.cpp | 4
src/gallium/state_trackers/clover/core/program.cpp | 8
src/gallium/state_trackers/clover/core/program.hpp | 1 +
3 files changed, 13 insertions(+)
diff --git a/src/gallium/state_trackers/clover/api/program.cpp
---
src/gallium/state_trackers/clover/api/program.cpp | 3 +++
src/gallium/state_trackers/clover/core/program.cpp | 8
src/gallium/state_trackers/clover/core/program.hpp | 1 +
3 files changed, 12 insertions(+)
diff --git a/src/gallium/state_trackers/clover/api/program.cpp
make resize work like std::vector
reserve take advantage of capacity
rename members to be uniform with other class
---
src/gallium/state_trackers/clover/core/module.cpp | 2 +-
src/gallium/state_trackers/clover/util/compat.hpp | 113 +++---
2 files changed, 78 insertions(+), 37
1 - 100 of 114 matches
Mail list logo
