[Mesa-dev] [ANNOUNCE] mesa 21.1.0-rc2

2021-04-21 Thread Eric Engestrom
Hello everyone, The second release candidate is now available, with many fixes across many drivers. Please test it and report report any issue here: https://gitlab.freedesktop.org/mesa/mesa/-/issues/new Issues that should block the release of 21.1.0 should be added to the corresponding milestone:

[Mesa-dev] [ANNOUNCE] mesa 21.1.0-rc1

2021-04-14 Thread Eric Engestrom
Hello everyone! Once again, a new release cycle has started. Please test this first release candidate, and report any issue here: https://gitlab.freedesktop.org/mesa/mesa/-/issues/new Issues that should block the release of 21.1.0 should be added to the corresponding milestone: https://gitlab.fre

[Mesa-dev] [ANNOUNCE] mesa 20.1.10

2020-10-14 Thread Eric Engestrom
C RAW Hazard Avoidance Bas Nieuwenhuizen (2): radv: Use atomics to read query results. radv: Fix mipmap extent adjustment on GFX9+. Dylan Baker (1): glsl/xxd.py: fix imports Eric Engestrom (6): docs/relnotes: add sha256 sums to 20.1.9 .pick_status.json: Upda

[Mesa-dev] [ANNOUNCE] mesa 20.1.9

2020-09-30 Thread Eric Engestrom
ratch stores Dylan Baker (1): meson/anv: Use variable that checks for --build-id Eric Engestrom (11): docs/relnotes: add sha256 sums to 20.1.8 .pick_status.json: Update to d74fe47101995d2659b1e59495d2f77b9dc14f3d .pick_status.json: Update to c669db0b503c10faf2d1c67c9340d7222b4

[Mesa-dev] [ANNOUNCE] mesa 20.1.8

2020-09-16 Thread Eric Engestrom
lt (2): gallium/tgsi_exec: Fix up NumOutputs counting freedreno: Make the pack struct have a .qword for wide addresses. Eric Engestrom (6): docs/relnotes: add sha256 sums to 20.1.7 .pick_status.json: Update to 123bdb61cc0be64ee29b63cf27565ec98c2a0ab8 .pick_status.json:

[Mesa-dev] [ANNOUNCE] mesa 20.1.7

2020-09-02 Thread Eric Engestrom
restrict exported symbols with static llvm Eric Engestrom (12): docs/relnotes: add sha256 sums to 20.1.6 .pick_status.json: Update to e94c22429b64f419d9a66f04fa5ecdad33f7f5ef .pick_status.json: Mark 9146f596ed1e8854a2a6c9137396a902bc92946c as denominated .pick_status.js

[Mesa-dev] [ANNOUNCE] mesa 20.1.6

2020-08-19 Thread Eric Engestrom
itten between geometry stages spirv: Only require bare types to match when copying variables Dave Airlie (2): llvmpipe: only read 0 for channels being read llvmpipe/cs: update compute counters not fragment shader. Eric Engestrom (9): docs/relnotes: add sha256 sums to 2

Re: [Mesa-dev] CI for vallium question

2020-08-16 Thread Eric Engestrom
I think you should add vallium to whichever builds will be the least extended by adding vallium; I'm guessing that's going to be the gallium build? On 2020-08-16 at 23:01, Dave Airlie wrote: > meson-gallium builds all the gallium drivers but no vulkan drivers. > meson-vulkan builds all the vulk

Re: [Mesa-dev] Rename "master" branch to "main"?

2020-08-06 Thread Eric Engestrom
On Tuesday, 2020-08-04 11:27:43 -0500, Jason Ekstrand wrote: > On Tue, Aug 4, 2020 at 5:54 AM Daniel Stone wrote: > > > > Hi, > > > > On Mon, 3 Aug 2020 at 17:16, Jason Ekstrand wrote: > > > On Mon, Aug 3, 2020 at 11:12 AM Kenneth Graunke > > > wrote: > > > > Seems reasonable to me...in the old

[Mesa-dev] [ANNOUNCE] mesa 20.1.5

2020-08-05 Thread Eric Engestrom
ch cross element_size boundaries aco: don't split store data if it was already split into more elements aco: prevent infinite recursion in RA for subdword variables Daryl W. Grunau (1): prevent multiply defined symbols Eric Engestrom (7): docs/relnotes: add sha256 s

Re: [Mesa-dev] Rename "master" branch to "main"?

2020-08-03 Thread Eric Engestrom
On Monday, 2020-08-03 13:42:28 -0500, Jason Ekstrand wrote: > On Mon, Aug 3, 2020 at 1:38 PM Eric Engestrom wrote: > > > > On Monday, 2020-08-03 13:31:19 -0500, Jason Ekstrand wrote: > > > On Mon, Aug 3, 2020 at 1:24 PM Eric Engestrom wrote: > > > > > >

Re: [Mesa-dev] Rename "master" branch to "main"?

2020-08-03 Thread Eric Engestrom
On Monday, 2020-08-03 13:31:19 -0500, Jason Ekstrand wrote: > On Mon, Aug 3, 2020 at 1:24 PM Eric Engestrom wrote: > > > > On Monday, 2020-08-03 10:30:29 -0500, Jason Ekstrand wrote: > > > All, > > > > > > I'm sure by now you've all seen the

Re: [Mesa-dev] Rename "master" branch to "main"?

2020-08-03 Thread Eric Engestrom
On Monday, 2020-08-03 10:30:29 -0500, Jason Ekstrand wrote: > All, > > I'm sure by now you've all seen the articles, LKML mails, and other > chatter around inclusive language in software. While mesa doesn't > provide a whole lot of documentation (hah!), we do have a website, a > code-base, and a

[Mesa-dev] [ANNOUNCE] mesa 20.1.4

2020-07-22 Thread Eric Engestrom
panfrost: Fix fence leak panfrost: Fix write to free'd memory panfrost: Revert "Disable frame throttling" Bas Nieuwenhuizen (1): meson: Add mising git_sha1.h dependency. Danylo Piliaiev (1): nir/opt_if: Fix opt_if_simplification when else branch ha

[Mesa-dev] [ANNOUNCE] mesa 20.1.3

2020-07-08 Thread Eric Engestrom
r option in arm64 kernels. ci: Build a cheza kernel. ci: Add scripts for controlling bare-metal chezas. ci: Switch cheza (freedreno a630) testing to baremetal. ci: Don't build an arm_test container now that the last user is gone. ci: Rename x86_cross_arm_test to jus

[Mesa-dev] [ANNOUNCE] mesa 20.1.2

2020-06-24 Thread Eric Engestrom
ot;, per-mipmap level textures in CopyImageSubData Eric Anholt (2): freedreno/ir3: Fix register allocation assertion failures. freedreno/ir3: Fix register allocation assertion failures. Eric Engestrom (5): docs/relnotes: add sha256 sums to 20.1.0 .pick_status.

[Mesa-dev] [ANNOUNCE] mesa 20.1.1

2020-06-10 Thread Eric Engestrom
n Baker (1): vulkan-overlay/meson: use install_data instead of configure_file Eric Engestrom (7): docs/relnotes add sha256 sums to 20.1.0 docs: drop new_features.txt .pick_status.json: Update to 3a1a40b4431d505fa6487cd012ddb4b64387aee5 glapi: remove deprecated .getchildren() tha

Re: [Mesa-dev] [ANNOUNCE] mesa 20.1.0

2020-06-03 Thread Eric Engestrom
x27;s one more signature of the same file :) Sorry about the mixup, Eric On Thursday, 2020-05-28 00:50:40 +0200, Eric Engestrom wrote: > Hi all, > > I'd like to announce Mesa 20.1.0, the first release for the 20.1 branch. > > Being the first release of this new branch, there

[Mesa-dev] [ANNOUNCE] mesa 20.1.0

2020-05-27 Thread Eric Engestrom
tion for memory zeroing custom new mesa: Fix double-lock of Shared->FrameBuffers and usage of wrong mutex intel/fs: Work around dual-source blending hangs in combination with SIMD16 Dave Airlie (1): llvmpipe: compute shaders work better with all the threads.

[Mesa-dev] [ANNOUNCE] mesa 20.1.0-rc4

2020-05-20 Thread Eric Engestrom
Make tests aware of meson test wrapper Emmanuel Gil Peyrot (1): Expose EGL_KHR_platform_* when EXT is supported Eric Engestrom (5): .pick_status.json: Update to 5a6beb6a24aa084adfd6c57edd0a64f0a044611a post_version.py: fix branch name construction for release candi

[Mesa-dev] [ANNOUNCE] mesa 20.1.0-rc3

2020-05-13 Thread Eric Engestrom
intel/compiler: fix alignment assert in nir_emit_intrinsic Axel Davy (1): gallium/util: Fix leak in the live shader cache Blaž Tomažič (1): radeonsi: Fix omitted flush when moving suballocated texture Daniel Schürmann (1): aco: either copy-propagate or inline create_vector

Re: [Mesa-dev] New Mesa3D.org website proposal

2020-05-07 Thread Eric Engestrom
On Thursday, 2020-05-07 16:26:19 +0200, Erik Faye-Lund wrote: > On Thu, 2020-05-07 at 16:18 +0200, Eric Engestrom wrote: > > On Thursday, 2020-05-07 16:07:00 +0200, Erik Faye-Lund wrote: > > > On Thu, 2020-05-07 at 09:05 -0500, Jason Ekstrand wrote: > > > > Looks shi

Re: [Mesa-dev] New Mesa3D.org website proposal

2020-05-07 Thread Eric Engestrom
On Thursday, 2020-05-07 16:07:00 +0200, Erik Faye-Lund wrote: > On Thu, 2020-05-07 at 09:05 -0500, Jason Ekstrand wrote: > > Looks shiny but > > > > We need to be very careful here. One of the big no-nos with Khronos > > trademark rules is using logos for things where implementations > > aren'

[Mesa-dev] [ANNOUNCE] mesa 20.1.0-rc2

2020-05-06 Thread Eric Engestrom
rray Index for gen12 anv,iris: Fix input vertex max for tcs on gen12 Danylo Piliaiev (1): i965: Fix out-of-bounds access to brw_stage_state::surf_offset Dave Airlie (2): draw/tess: free tessellation control shader i/o memory. llvmpipo/nir: free compute shader NI

[Mesa-dev] [ANNOUNCE] mesa 20.1.0-rc1

2020-04-29 Thread Eric Engestrom
I'd like to announce the first release candidate of the 20.1 branch, Mesa 20.1.0-rc1. Please test it, and report any issues you might find to: https://gitlab.freedesktop.org/mesa/mesa/issues/new We also have a GitLab milestone to track issues that need to be fixed and MRs that need to be merged b

[Mesa-dev] [ANNOUNCE] mesa 20.0.4

2020-04-03 Thread Eric Engestrom
Hi all, I'd like to announce the emergency release of Mesa 20.0.4, which reverts a serious SPIR-V regression in the 20.0.3 release. Users of 20.0.3 are recommended to upgrade immediately. Sorry about this. Cheers, Eric --- Git shortlog ==== Eric Engestrom (4): docs/rel

Re: [Mesa-dev] [ANNOUNCE] mesa 20.0.3

2020-04-02 Thread Eric Engestrom
> > https://gitlab.freedesktop.org/mesa/mesa/-/commit/68f325b256d96dca923f6c7d84bc6faf43911245 > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4375 > > I'm not sure if it's already known or how important it is, but I'd better > > say it than not. > > > > On

[Mesa-dev] [ANNOUNCE] mesa 20.0.3

2020-04-01 Thread Eric Engestrom
orted .pick_status.json: Mark c923de68dd0ab10a5a5fb3196f539707d046d897 as backported .pick_status.json: Mark 56de6f698e3f164d97f132203e8159ef0b8e9bb8 as denominated .pick_status.json: Update to aee004a7c8900938d1c17f0ac299d40001b383b0 Eric Engestrom (8): .pick_status.json: Upda

Re: [Mesa-dev] Remove classic drivers or fork src/mesa for gallium?

2020-03-29 Thread Eric Engestrom
On 2020-03-29 at 20:58, Jason Ekstrand wrote: > On Sun, Mar 29, 2020 at 11:45 AM Kristian Høgsberg > wrote: > > > > As for loading, doesn't glvnd solve that? > > Not really. There are still problems if you have HW drivers from both > repos on the same system and someone has to decide which o

Re: [Mesa-dev] [ANNOUNCE] Mesa 19.3.5

2020-03-10 Thread Eric Engestrom
On 2020-03-10 at 10:32, Erik Faye-Lund wrote: > On Mon, 2020-03-09 at 23:55 +0100, Eric Engestrom wrote: > > I'd like to announce the release of Mesa 19.3.5, final release of the > > 19.3.x series. > > You are encouraged to migrate to 20.0.1, released a few days ago, in

[Mesa-dev] [ANNOUNCE] Mesa 19.3.5

2020-03-09 Thread Eric Engestrom
.pick_status.json: Update to 01496e3d1ea0370af03e6645dbd2b864c2ace94c Eric Engestrom (12): .pick_status.json: Update to 74e4cda64b9d114321216eefe536f80644b0f0fd .pick_status.json: Mark dba71de5c63617677fe44558f995d35fad643413 as denominated .pick

Re: [Mesa-dev] Requiring a full author name when contributing to mesa?

2019-12-11 Thread Eric Engestrom
On 2019-12-11 at 23:46, Timothy Arceri wrote: > On 12/12/19 10:38 am, Eric Engestrom wrote: > > On 2019-12-11 at 23:09, Eric Anholt wrote: > >> On Wed, Dec 11, 2019 at 2:35 PM Timothy Arceri > >> wrote: > >>> > >>> Hi, > >>> >

Re: [Mesa-dev] Requiring a full author name when contributing to mesa?

2019-12-11 Thread Eric Engestrom
On 2019-12-11 at 23:09, Eric Anholt wrote: > On Wed, Dec 11, 2019 at 2:35 PM Timothy Arceri wrote: > > > > Hi, > > > > So it seems lately we have been increasingly merging patches with made > > up names, or single names etc [1]. The latest submitted patch has the > > name Icecream95. This seems w

Re: [Mesa-dev] Remove classic drivers or fork src/mesa for gallium?

2019-12-04 Thread Eric Engestrom
On 2019-12-04 at 18:54, Dylan Baker wrote: > Quoting Kristian Høgsberg (2019-12-04 10:43:46) > > On Wed, Dec 4, 2019 at 10:31 AM Rob Clark wrote: > > > > > > On Wed, Dec 4, 2019 at 9:48 AM Eric Anholt wrote: > > > > > > > > On Tue, Dec 3, 2019 at 4:39 PM Marek Olšák wrote: > > > > > > > > > > H

Re: [Mesa-dev] Remove classic drivers or fork src/mesa for gallium?

2019-12-04 Thread Eric Engestrom
On Wednesday, 2019-12-04 09:48:28 -0800, Eric Anholt wrote: > On Tue, Dec 3, 2019 at 4:39 PM Marek Olšák wrote: > > > > Hi, > > > > Here are 2 proposals to simplify and better optimize the GL->Gallium > > translation. > > > > 1) Move classic drivers to a fork of Mesa, and remove them from master.

Re: [Mesa-dev] [PATCH] i965: update Makefile.sources for perf changes

2019-11-29 Thread Eric Engestrom
On Thursday, 2019-11-28 16:57:23 +1100, Jonathan Gray wrote: > brw_performance_query_metrics.h was removed in > 134e750e16bfc53480e0bba6f0ae3e1d2a7fb87c and > brw_performance_query.h was removed in > 8ae6667992ccca41d08884d863b8aeb22a4c4e65 > > remove reference to these files from Makefile.sources

Re: [Mesa-dev] [PATCH v2] mapi: avoid text relocation in x86 tsd stubs

2019-11-29 Thread Eric Engestrom
On Wednesday, 2019-11-27 10:20:04 -0800, Lepton Wu wrote: > OK, I didn't know there is a patch in mail list. BTW, it seems there is no > meaningful difference > with the generated code: when it's trying to align to 32 bytes border, > since the actual code size > is between 32 and 64, actually the

Re: [Mesa-dev] [PATCH] egl: Mention if swrast is being forced

2019-10-31 Thread Eric Engestrom
,8 @@ _eglMatchDriver(_EGLDisplay *disp) > /* set options */ > disp->Options.ForceSoftware = >env_var_as_boolean("LIBGL_ALWAYS_SOFTWARE", false); > + if (disp->Options.ForceSoftware) > + _eglLog(_EGL_DEBUG, "Found 'LIBGL_ALWAYS_SOFTWARE&#

Re: [Mesa-dev] [Nine] 'meson: add -Werror=empty-body to disallow `if(x); `' - 'broke' Nine

2019-10-25 Thread Eric Engestrom
ut this, Axel? > > Thanks & best regards, > Tim > > On Fri, 2019-10-25 at 11:48 +0100, Eric Engestrom wrote: > > (for the record, the MR has been reviewed and will be merged when the > > pipeline comes back all green) > > > > The problem is that the CI d

Re: [Mesa-dev] [Nine] 'meson: add -Werror=empty-body to disallow `if(x); `' - 'broke' Nine

2019-10-25 Thread Eric Engestrom
I don't have time to look into this more right now, but I've posted a WIP MR for it: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2469 On Friday, 2019-10-25 11:48:47 +0100, Eric Engestrom wrote: > (for the record, the MR has been reviewed and will be merged when the >

Re: [Mesa-dev] [Nine] 'meson: add -Werror=empty-body to disallow `if(x); `' - 'broke' Nine

2019-10-25 Thread Eric Engestrom
(for the record, the MR has been reviewed and will be merged when the pipeline comes back all green) The problem is that the CI does debug builds, while this was a release-build-only issue. We could perform multiple types of builds each time, but that would multiply the CI time/cost; I'll take a

Re: [Mesa-dev] [Nine] 'meson: add -Werror=empty-body to disallow `if(x); `' - 'broke' Nine

2019-10-24 Thread Eric Engestrom
Indeed, Axel's solution is the right one: you can make it a `(void) something` or `do {} while (0)` for instance. Sorry for not catching this before landing my commit; I'll give it a look tomorrow, tag me (@eric) if you send an MR before I get around to fixing it. On Thursday, 2019-10-24 23:31:0

Re: [Mesa-dev] libdrm versioning - switch to 19.0.0?

2019-10-11 Thread Eric Engestrom
On Thursday, 2019-10-10 16:14:47 -0400, Marek Olšák wrote: > Hi, > > I expect to make a new libdrm release soon. Any objections to changing the > versioning scheme? > > Current: 2.4.n > n = starts from 0, incremented per release > > New proposals: > year.n.0 (19.0.0) > year.month.n (19.10.0) > y

Re: [Mesa-dev] [PATCH] egl/gbm: Fix config validation

2019-10-01 Thread Eric Engestrom
On Tuesday, 2019-10-01 14:01:09 +0100, Robin Murphy wrote: > [ + some CCs that I probably should have figured out first time around... ] > > On 23/09/2019 16:40, Adam Jackson wrote: > > On Sat, 2019-09-21 at 18:07 +0100, Robin Murphy wrote: > > > In converting to shift/size-based validation, we lo

Re: [Mesa-dev] gitlab issue migration, labels & triage

2019-10-01 Thread Eric Engestrom
On Tuesday, 2019-10-01 13:30:39 +0300, Denys wrote: > Thanks a lot, works fine. > > Also I would suggest to apply a template for issue creation as we finally > moved most of sub-projects and users started new issues creation at gitlab. Agreed, I started looking into this. I'll post a WIP MR for

Re: [Mesa-dev] [PATCH 3/3] android: aco: add support for libmesa_aco

2019-09-27 Thread Eric Engestrom
On Friday, 2019-09-27 09:56:36 +0200, Mauro Rossi wrote: > Hi, > for this 3rd patch I'm in contact with John Stultz > > Could you please give me both some advice on how to perform Merge Request > (newbie) > > I have pushed an android_aco branch in my gitlab repo with account > issor.oruam (same u

Re: [Mesa-dev] [PATCH] android: anv: libmesa_vulkan_common: add libmesa_util static dependency

2019-09-08 Thread Eric Engestrom
ns.h' file not found > ^~~ > 1 error generated. > > Fixes: 4dcb1ff ("anv: add support for driconf") Oh sorry, I didn't think about Android 🤦‍♀️ `Reviewed-by: Eric Engestrom ` > Signed-off-by: Mauro Rossi > --- > src/intel/Android.vulkan.mk | 3 ++- > 1 fi

Re: [Mesa-dev] [PATCH] meson: Always include 'coroutines' in llvm optional modules

2019-09-07 Thread Eric Engestrom
There's an open MR by Vinson for that issue: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1878 On 2019-09-07 at 15:20, Mike Lothian wrote: > Without this I get build failures: > > error: undefined reference to 'LLVMAddCoroEarlyPass' > error: undefined reference to 'LLVMAddCoroSplitPas

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-09-05 Thread Eric Engestrom
On Thursday, 2019-09-05 17:58:22 +0200, Mauro Rossi wrote: > Hi Eric, Emil, > we have Tapani ok, in my understanding > > Please follow up on this one Sure, feel free to push the android revert until we can figure out a fix: Acked-by: Eric Engestrom > Mauro > > On Fri, Au

Re: [Mesa-dev] Moving libglvnd to FreeDesktop Gitlab

2019-09-04 Thread Eric Engestrom
On Wednesday, 2019-09-04 15:44:58 +0100, Daniel Stone wrote: > Hi, > > On Wed, 4 Sep 2019 at 15:12, Chuck Atkins wrote: > > Can we use Gitlab's GitHub import feature? > > > > https://gitlab.freedesktop.org/help/user/project/import/github.md > > > > I haven't used it before but it looks like it wi

Re: [Mesa-dev] Moving libglvnd to FreeDesktop Gitlab

2019-09-01 Thread Eric Engestrom
On 2019-09-01 at 20:56, Daniel Stone wrote: > Hi, > > On Sat, 31 Aug 2019 at 20:34, Matt Turner wrote: > > Getting patches into libglvnd has proven quite difficult (see [0] for > > example). There was some talk of moving it to FreeDesktop Gitlab on > > IRC recently. Can we move forward with that

Re: [Mesa-dev] Switching to Gitlab Issues instead of Bugzilla?

2019-08-30 Thread Eric Engestrom
Just adding to the pile of :+1: I think an empty repo for drm with just issues enabled is a good solution. On Thursday, 2019-08-29 11:52:51 -0700, Kenneth Graunke wrote: > Hi all, > > As a lot of you have probably noticed, Bugzilla seems to be getting a > lot of spam these days - several of us h

Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration

2019-08-27 Thread Eric Engestrom
t; volume of merges and merge requests? > > Jose > > > From: Eric Engestrom > Sent: Tuesday, August 27, 2019 14:23 > To: Jose Fonseca > Cc: mesa-dev@lists.freedesktop.org ; Brian > Paul > Subject: Re: Mesa GitLab <-> AppVeyor integration > > On Tue

Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration

2019-08-27 Thread Eric Engestrom
On Tuesday, 2019-08-27 10:30:07 +, Jose Fonseca wrote: > FYI, I've followed Eric Engestroms' instructions for better Mesa <-> AppVeyor > integration. (Thanks Eric.) > > I haven't tested, but hopefully this new integration method should now > trigger Appveyor builds on pull requests too, whi

Re: [Mesa-dev] [PATCH 2/4] util: Prevent implicit declaration of function getenv.

2019-08-27 Thread Eric Engestrom
On Tuesday, 2019-08-27 10:57:38 +, Jose Fonseca wrote: > With MinGW cross compilation. 2-4 are Acked-by: Eric Engestrom > --- > src/util/os_misc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/util/os_misc.c b/src/util/os_misc.c > index 755970430b

Re: [Mesa-dev] [PATCH 1/4] glx: Fix incompatible function pointer types.

2019-08-27 Thread Eric Engestrom
On Tuesday, 2019-08-27 10:57:36 +, Jose Fonseca wrote: > I don't know how Meson didn't hit this issue, when it too already uses > -Werror=incompatible-pointer-types Not sure either... Fixes: 3dd299c3d5b88114894e ("glx: Sync with Khronos") Reviewed-by: Eric Eng

Re: [Mesa-dev] [PATCH] panfrost/ci: Diff results when printing

2019-08-22 Thread Eric Engestrom
On Thursday, 2019-08-22 08:22:28 +0200, Tomeu Vizoso wrote: > On 8/21/19 7:48 PM, Alyssa Rosenzweig wrote: > > Otherwise, there is too much noise to see what's going on. > > I'm afraid this doesn't improve things much, as you can see below: > > https://gitlab.freedesktop.org/tomeu/mesa/-/jobs/524

Re: [Mesa-dev] Mesa (update-reviewers-for-vmware): i965/clear: clear_value better precision

2019-08-02 Thread Eric Engestrom
On Friday, 2019-08-02 17:50:17 +0200, Michel Dänzer wrote: > On 2019-08-02 5:37 p.m., Brian Paul wrote: > > Ugh, I didn't mean to do this.  I'm trying to figure out how to make a > > merge request with gitlab. > > Just push to a branch in your personal repository, and the output of git > push cont

Re: [Mesa-dev] [PATCH] gitlab-ci: remove software-properties-common

2019-07-31 Thread Eric Engestrom
t;> > >>> Currently we use the python package to manage repositories. At the same > >>> time we also do that by hand - since it's a trivial echo to a file. > >>> > >>> Stay consistent, remove the package and manage things manually. > >>

Re: [Mesa-dev] Mesa 19.2.0 release plan

2019-07-31 Thread Eric Engestrom
On 2019-07-31 at 09:38, Emil Velikov wrote: > Hi all, > > Here is the tentative release plan for 19.2.0. > > As many of you are well aware, it's time to the next branch point. > The calendar is already updated, so these are the tentative dates: > > Aug 06 2019 - Feature freeze/Release candidat

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

2019-07-19 Thread Eric Engestrom
On Friday, 2019-07-19 21:23:24 +0200, Tobias Klausmann wrote: > > Am 19.07.19 um 18:18 schrieb Ilia Mirkin: > > On Fri, Jul 19, 2019 at 12:07 PM Tobias Klausmann > > wrote: > > > On 19.07.19 15:39, Eric Engestrom wrote: > > > > On Friday, 2019-07-

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

2019-07-19 Thread Eric Engestrom
On Friday, 2019-07-19 13:56:30 +0200, Mark Menzynski wrote: > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=111007 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=67 `Fixes:` is used to indicate the commit that introduced the code being fixed, such as: Fixes: 1c4e6d7ca83578caf521

Re: [Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used

2019-07-15 Thread Eric Engestrom
On 2019-07-15 at 16:01, Jeremy Newton wrote: > Thanks Marek and Michel, see the updated patch below: > > The amdgpu dri is used for the closed source AMD driver. Since this driver > does not implement multimedia, we fall back to radeonsi in mesa to do > multimedia. This corrects the Gallium dri

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-07-14 Thread Eric Engestrom
See also this MR which reverts the other half of that commit: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1283 On 2019-07-14 at 11:17, Mauro Rossi wrote: > This patch partially reverts 20294dc ("mesa: Enable asm unconditionally, ...") > > Android makefile build logic needs to disable

Re: [Mesa-dev] [PATCH] egl/android: Update color_buffer[] querying for buffer age

2019-07-09 Thread Eric Engestrom
egl_surface > __DRIimage *dri_image_front; > > /* Used to record all the buffers created by ANativeWindow and their ages. > -* Usually Android uses at most triple buffers in ANativeWindow > -* so hardcode the number of color_buffers to 3. Might be good to upda

Re: [Mesa-dev] [MR] Update README to recommend MRs instead of `git send-email`

2019-07-08 Thread Eric Engestrom
r many of us to want to eventually not let anyone push anything that hasn't gone through that CI, so while this is *not* what we're talking about here, let's be clear that it's the end-goal for many of us. > > Cheers, > > -ilia > > On Sat, Jul 6, 2019 at 7:

[Mesa-dev] [MR] Update README to recommend MRs instead of `git send-email`

2019-07-06 Thread Eric Engestrom
Hi, I sent an MR to update the README, but as pointed out there I should make sure people who don't look at MRs are also aware of it, so here is: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1223 ---8<--- diff --git a/README.rst b/README.rst index 4ccd72eca38a0845571c..eba097e652edde4

Re: [Mesa-dev] [PATCH] egl/drm: ensure the backing gbm is set before using it

2019-07-05 Thread Eric Engestrom
> Move the gbm_dri initialization as early as possible. To be on the extra > safe side add a NULL check in the teardown. > > Reported-by: Christian Gmeiner > Cc: Christian Gmeiner > Cc: Eric Engestrom > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-

Re: [Mesa-dev] What does WIP really mean in an MR?

2019-06-29 Thread Eric Engestrom
On Saturday, 2019-06-29 22:59:21 +0200, apinheiro wrote: > > On 29/6/19 2:30, Rob Clark wrote: > > I had interpreted it as literally the "block the gitlab merge button" > > option, ie. "I want to get feedback but it is not ready to merge and > > I'll drop the WIP tag when I think it is".. > > >

Re: [Mesa-dev] [PATCH 3/8] android: anv: fix improper use of LOCAL_WHOLE_STATIC_LIBRARIES

2019-06-25 Thread Eric Engestrom
ibmesa_anv_gen9 \ > libmesa_anv_gen10 \ > libmesa_anv_gen11 \ > - libmesa_intel_compiler \ > - libmesa_anv_entrypoints > + libmesa_intel_compiler This removal of libmesa_anv_entrypoints belongs in patch 6/8, right? I don

Re: [Mesa-dev] about building radeonsi drivers with meson

2019-06-24 Thread Eric Engestrom
On 2019-06-24 at 08:21, cloudwin wrote: > Hi > I used to build radeonsi drivers, like radeonsi_dri.so and > radeonsi_drv_video.so by autogen in old version mesa, but when I switch > to meson which is the only way to build mesa driver now, I find > radeonsi_dri.so can not be generated, I used th

Re: [Mesa-dev] [RFC 0/2] Alternate default config mechanism

2019-05-24 Thread Eric Engestrom
On Friday, 2019-05-24 07:49:37 +0300, Tapani Pälli wrote: > > > On 5/23/19 8:22 PM, Sumit Semwal wrote: > > Hi Eric, > > > > On Thu, 23 May 2019 at 20:25, Eric Engestrom > > wrote: > > > > > > On Thursday, 2019-05-23 08:34:40 +0300, Tapani P

Re: [Mesa-dev] [RFC 0/2] Alternate default config mechanism

2019-05-23 Thread Eric Engestrom
On Thursday, 2019-05-23 08:34:40 +0300, Tapani Pälli wrote: > Hi; > > On 5/22/19 9:20 PM, Alistair Strachan wrote: > > On Tue, May 21, 2019 at 10:10 PM Tapani Pälli > > wrote: > > > > > > > > > On 5/21/19 4:53 PM, Sumit Semwal wrote: > > > > Hello everyone, > > > > > > > > First up, my apolog

Re: [Mesa-dev] [PATCH] docs/features: don't list EXT extensions in a list for KHR/ARB/OES extensions

2019-05-17 Thread Eric Engestrom
On 2019-05-16 at 18:34, Ian Romanick wrote: > On 5/15/19 7:39 AM, Gert Wollny wrote: > > How about moving these extensions to another (new) section? I think it > > is nice to have a one-stop place to find out what is supported. > > Given the existence of mesamatrix.net, is that useful? mesamatr

Re: [Mesa-dev] [PATCH] docs: advice to resolve discussion on gitlab MR doc

2019-05-16 Thread Eric Engestrom
The corrected text is: > > After an update, for the feedback you handled, close the feedback > discussion with the "Resolve Discussion" button. This way the reviewer > knows which feedback got handled and which didn't. > > I definitely didn't notice this when I st

Re: [Mesa-dev] [radeonsi] meson vs autotools used disk space observations

2019-05-13 Thread Eric Engestrom
On Monday, 2019-05-13 01:05:10 +0200, Dieter Nützel wrote: > Am 13.05.2019 00:03, schrieb Jason Ekstrand: > > Likely you're either getting slightly different build flags for some > > reason it else something extra is getting linked into the gallium > > driver that want before. Not all they concerni

Re: [Mesa-dev] [PATCH] intel/tools: Fix build with glibc < 2.27.

2019-05-10 Thread Eric Engestrom
include "dev/gen_device_info.h" > > +#ifdef OVERFLOW > +#undef OVERFLOW > +#endif You don't need the #ifdef, you can just #undef. Can you add the first line of the commit message as an online comment here? Acked-by: Eric Engestrom > + > void yyerror (char *);

Re: [Mesa-dev] [PATCH] kmsro: add _dri.so to two of the kmsro drivers.

2019-05-07 Thread Eric Engestrom
'repaper_dri.so', > 'rockchip_dri.so', > - 'st7586.so', > - 'st7735r.so', > + 'st7586_dri.so', > + 'st7735r_dri.so', Reviewed-by: Eric Engestrom &g

Re: [Mesa-dev] [PATCH] docs: link to the meson_options.txt file gitlab.freedesktop.org

2019-05-02 Thread Eric Engestrom
ions.txt file at the root of the project. > + href="https://gitlab.freedesktop.org/mesa/mesa/blob/master/meson_options.txt";> > +meson_options.txt file at the root of the project. Reviewed-by: Eric Engestrom > > > > -- > 1.8.5.6 >

Re: [Mesa-dev] [PATCH] docs: separate information for compiler selection and compiler options

2019-05-02 Thread Eric Engestrom
On Monday, 2019-03-11 19:52:47 -0600, Brian Paul wrote: > Split up the "Environment Variables" section into "Compiler Options" > and "Compiler Specification". I think this makes the information > easier to find and understand. Reviewed-by: Eric En

Re: [Mesa-dev] [PATCH] docs: document MESA_GLSL=errors keyword

2019-05-02 Thread Eric Engestrom
On Thursday, 2019-04-18 15:58:35 +0200, Alejandro Piñeiro wrote: > Added with commit 0161691f3518, still checked on shaderapi.c > _mesa_get_shader_flag method. Fixes: 0161691f3518db310411 "mesa: add GLSL_REPORT_ERRORS debug flag" Reviewed-by: Eric Engestrom and pushed, thanks

[Mesa-dev] [PATCH mesa] meson: expose glapi through osmesa

2019-05-02 Thread Eric Engestrom
Suggested-by: Pierre Guillou Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109659 Cc: Brian Paul Cc: Dylan Baker Signed-off-by: Eric Engestrom --- src/gallium/targets/osmesa/meson.build | 4 ++-- src/mesa/drivers/osmesa/meson.build| 3 ++- 2 files changed, 4 insertions(+), 3

Re: [Mesa-dev] [PATCH] glsl: work around MinGW 7.x compiler bug

2019-05-02 Thread Eric Engestrom
On 2019-05-01 at 21:35, Brian Paul wrote: > I'm not sure what triggered this, but building with > scons platform=windows toolchain=crossmingw machine=x86 build=profile > with MinGW g++ 7.3 or 7.4 causes an internal compiler error. > > We can work around it by forcing -O1 optimization. > --- > sr

Re: [Mesa-dev] [PATCH] util: include missing stdlib header

2019-05-01 Thread Eric Engestrom
t; return NULL; >^~~~ >_DLL > src/util/os_file.c:126:11: note: each undeclared identifier is reported > only once for each function it appears in > > Fixes: 316964709e2 ("util: add os_read_file() helper") > CC: Eric Engestrom > --- > src/util/os_file.h | 1 + >

Re: [Mesa-dev] [PATCH] vulkan/wsi: document libdrm version introducing drmIsMaster()

2019-04-30 Thread Eric Engestrom
On 2019-04-30 at 12:04, Emil Velikov wrote: > From: Emil Velikov > > To avoid pulling the latest libdrm we copy the helper locally. Document > when it was introduced, making it easier to purge in the future. > > Cc: Eric Engestrom > Suggested-by: Eric Engestrom > Sig

Re: [Mesa-dev] [PATCH v2] vulkan/wsi: check if the display_fd given is master

2019-04-26 Thread Eric Engestrom
library. Could you specify the actual version in this comment, so that we can drop this copy once we start depending on that version anyway? With that: Acked-by: Eric Engestrom > + */ > +static int > +local_drmIsMaster(int fd) > +{ > + /* Detect master by attempting something

Re: [Mesa-dev] [PATCH] android: fix LLVM version string related building errors

2019-04-13 Thread Eric Engestrom
t fix (because of the `eval`, if anyone's wondering). Reviewed-by: Eric Engestrom Unfortunately, I'm on holiday for a week now. Can you push the fix yourself? Otherwise, Tapani can :) > > Mauro > > On Sat, Apr 13, 2019 at 1:27 AM Mauro Rossi wrote: > > > >

Re: [Mesa-dev] [PATCH] mesa: don't overwrite existing shader files with MESA_SHADER_CAPTURE_PATH

2019-04-12 Thread Eric Engestrom
On Friday, 2019-04-12 11:50:11 -0400, Marek Olšák wrote: > On Fri, Apr 12, 2019 at 11:41 AM Eric Engestrom > wrote: > > > On Friday, 2019-04-12 11:00:56 -0400, Marek Olšák wrote: > > > On Thu, Apr 11, 2019 at 2:53 AM Tapani Pälli > > wrote: > > >

Re: [Mesa-dev] [PATCH] mesa: don't overwrite existing shader files with MESA_SHADER_CAPTURE_PATH

2019-04-12 Thread Eric Engestrom
On Friday, 2019-04-12 11:00:56 -0400, Marek Olšák wrote: > On Thu, Apr 11, 2019 at 2:53 AM Tapani Pälli wrote: > > On 4/11/19 3:32 AM, Marek Olšák wrote: > > > - file = fopen(filename, "w"); > > > + } > > > + FILE *file = fopen(filename, "r"); > > > + if (!file) > > >

Re: [Mesa-dev] [PATCH] panfrost: split asserts in pandecode

2019-04-11 Thread Eric Engestrom
On Thursday, 2019-04-11 09:11:12 +0200, Tomeu Vizoso wrote: > Signed-off-by: Tomeu Vizoso Reviewed-by: Eric Engestrom > --- > src/gallium/drivers/panfrost/pandecode/mmap.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/drivers/

Re: [Mesa-dev] [PATCH 1/2] draw: fix undefined shift of (1 << 31)

2019-04-11 Thread Eric Engestrom
On Thursday, 2019-04-11 20:32:18 +1000, Dave Airlie wrote: > From: Dave Airlie > > Pointed out by a coverity scan. This patch is: Reviewed-by: Eric Engestrom > --- > src/gallium/auxiliary/draw/draw_pipe_aapoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Mesa-dev] [PATCH 1/2] swrast: fix undefined shift of 1 << 31

2019-04-11 Thread Eric Engestrom
On Thursday, 2019-04-11 20:40:13 +1000, Dave Airlie wrote: > From: Dave Airlie > > Pointed out by coverity Series is: Reviewed-by: Eric Engestrom > --- > src/mesa/swrast/s_span.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/sw

Re: [Mesa-dev] [PATCH 2/2] meson: upgrade minimum meson version

2019-04-09 Thread Eric Engestrom
On Tuesday, 2019-04-09 13:16:16 +0200, Ernst Sjöstrand wrote: > For people building newer Mesa pip3 install --user meson is quite a > lot better and more accessible. Agreed: if users want a recent version of meson, they might as well install the current one from pip instead of some slightly less o

Re: [Mesa-dev] [PATCH] wsi: allow to override the present mode with MESA_VK_WSI_PRESENT_MODE

2019-04-09 Thread Eric Engestrom
On 2019-04-09 at 10:56, Michel Dänzer wrote: > On 2019-04-09 10:03 a.m., Eric Engestrom wrote: > > On Tuesday, 2019-04-09 09:08:36 +0200, Samuel Pitoiset wrote: > >> > >> + if (!strcmp(mode, "fifo")) { > >> + swapchain->present_mode

Re: [Mesa-dev] [PATCH] wsi: allow to override the present mode with MESA_VK_WSI_PRESENT_MODE

2019-04-09 Thread Eric Engestrom
nreachable() means the compiler is allowed to do anything, including considering the application as dead. Not something we want user to be able to do with a simple `MESA_VK_WSI_PRESENT_MODE=0` :) With an assert() instead, this is: Reviewed-by: Eric Engestrom > + } > + } > +} > +

Re: [Mesa-dev] [crucible PATCH] add a command line option for selecting the Vulkan device

2019-04-05 Thread Eric Engestrom
On Friday, 2019-04-05 12:27:14 +0200, Samuel Pitoiset wrote: > In a multi-GPU scenario. > > Signed-off-by: Samuel Pitoiset FYI, crucible now uses merge requests on gitlab :) https://gitlab.freedesktop.org/mesa/crucible/merge_requests > --- > doc/crucible-run.1.txt | 4 > incl

Re: [Mesa-dev] [PATCH v7 1/5] util: Get program name based on path when possible

2019-03-21 Thread Eric Engestrom
ng wine programs. > > > > Cc: Timothy Arceri > > Signed-off-by: Nicholas Kazlauskas > > Reviewed-by: Eric Engestrom > > --- > > src/util/u_process.c | 23 ++- > > 1 file changed, 22 insertions(+), 1 deletion(-) > > > >

Re: [Mesa-dev] [PATCH] vulkan/util: meson build - add wayland client include

2019-03-18 Thread Eric Engestrom
On Monday, 2019-03-18 10:32:17 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2019-03-17 11:33:23) > > On Saturday, 2019-03-16 20:32:46 +, Lionel Landwerlin wrote: > > > There is merge request opened about this issue : > > > https://gitlab.freedesktop.org/m

Re: [Mesa-dev] [PATCH] vulkan/util: meson build - add wayland client include

2019-03-17 Thread Eric Engestrom
On Saturday, 2019-03-16 20:32:46 +, Lionel Landwerlin wrote: > There is merge request opened about this issue : > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/429 > > I think the deps need to be moved from src/vulkan/wsi/meson.build into > src/vulkan/meson.build as they apply to the

Re: [Mesa-dev] [PATCH] radv: remove sisched hack for talos

2019-03-15 Thread Eric Engestrom
On Friday, 2019-03-15 21:25:33 +1100, Timothy Arceri wrote: > This was added in 8a7d4092d260 but no longer seems to have any > impact on performance. > --- > src/amd/vulkan/radv_device.c | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/src/amd/vulkan/radv_device.

<    1   2   3   4   5   6   7   8   9   10   >