Re: [Mesa-dev] [PATCH] util/disk_cache: Remove unneeded free() on always null string

On Monday, 2017-12-04 11:47:33 +0200, vadim.shovkopl...@gmail.com wrote: > From: Vadym Shovkoplias > > At this point dc_job->cache_item_metadata.keys always equals > NULL, so call to free() is useless > > Fixes: b86ecea3446 ("util/disk_cache: write cache item metadata to disk") > Signed-off-by:

[Mesa-dev] [PATCH mesa v2] meson: fix pl111 dependency on vc4

src/gallium/winsys/pl111/drm/libpl111winsys.a(pl111_drm_winsys.c.o): In function `pl111_drm_screen_create': pl111_drm_winsys.c:(.text+0x33): undefined reference to `vc4_drm_screen_create_renderonly' Signed-off-by: Eric Engestrom Reviewed-by: Dylan Baker (v1) --- (sent a v2 because

[Mesa-dev] [PATCH mesa] meson: fix keyword argument in declare_dependency()

`declare_dependency()` takes `compile_args`, not `c_args`. It was correct in all the other `declare_dependency()` from that commit. Fixes: 0bbecc5a8548883f76a71 "meson: define driver dependencies" Cc: Dylan Baker Signed-off-by: Eric Engestrom --- src/gallium/winsys/imx/drm/meson.b

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

uld be grouped, whereas different kind of issues or different modules should be separate. Don't worry too much about it though, if people ask you to merge or split commits, it's not that complicated to do for a v2 :) > > 2017-12-01 17:41 GMT+02:00 Eric Engestrom : > >

Re: [Mesa-dev] [PATCH 3/3] nv50/ir: Fix unused var warnings in release build

>src(0).getImmediate(val); > > Can you write a comment mentioning that getImmediate() has > side-effects on the argument, so this *shouldn't* get folded into the > assert? My concern is that with the MAYBE_UNUSED there, someone with a > twitchy thumb may be tempted to press that b

Re: [Mesa-dev] [PATCH 0/3] Fix linkage for libEGL and libGLX without dri3

ri3 > meson: Fix overlinkage of dri3 loader Reviewed-by: Eric Engestrom > > src/egl/meson.build| 2 +- > src/glx/meson.build| 14 +- > src/loader/meson.build | 3 +-- > 3 files changed, 11 insertions(+), 8 deletions(-) > > -- > 2.15.0 > > ___

Re: [Mesa-dev] [PATCH] meson: Install dri.pc file when building gallium dri drivers

trich > Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom > --- > src/mesa/drivers/dri/meson.build | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/drivers/dri/meson.build > b/src/mesa/drivers/dri/meson.build >

Re: [Mesa-dev] [PATCH] Android: disable warnings causing errors

On Thursday, 2017-11-30 14:20:08 +, Emil Velikov wrote: > On 29 November 2017 at 18:12, Rob Herring wrote: > > On Wed, Nov 29, 2017 at 11:01 AM, Emil Velikov > > wrote: > >> On 27 November 2017 at 19:36, Rob Herring wrote: > >>> AOSP master has changed the build default to -Werror making al

Re: [Mesa-dev] [PATCH 00/14] meson: most of gallium

On Thursday, 2017-11-30 10:34:06 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-29 07:44:08) > > On Tuesday, 2017-11-28 15:30:21 -0800, Dylan Baker wrote: > > > This series is the gallium media state trackers, the "nine" Direct3D state > > > tracke

[Mesa-dev] [PATCH mesa] meson: fix pl111 dependency on vc4

src/gallium/winsys/pl111/drm/libpl111winsys.a(pl111_drm_winsys.c.o): In function `pl111_drm_screen_create': pl111_drm_winsys.c:(.text+0x33): undefined reference to `vc4_drm_screen_create_renderonly' Signed-off-by: Eric Engestrom --- meson.build | 4

[Mesa-dev] [PATCH mesa] i915: add missing 0 defines

Thanks to Emil's -Wundef, t_dd_dmatmp.h now complains that intel_render.c is missing a couple `#define`s. Assigning them to 0 keeps the existing behaviour; I'll let someone else turn them on if this is the behaviour that was intended. Signed-off-by: Eric Engestrom --- src/mesa/driver

Re: [Mesa-dev] [PATCH] freedreno: add -Wno-packed-bitfield-compat for meson build

ed me how to do this in meson. > > Cc: Eric Engestrom > Signed-off-by: Rob Clark Not sure it makes much sense to r-b my own patch, but... ^^ Reviewed-by: Eric Engestrom > --- > src/gallium/drivers/freedreno/meson.build | 14 -- > 1 file changed, 12 insertions(+)

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

On Friday, 2017-12-01 17:08:53 +0200, vadim.shovkopl...@gmail.com wrote: > From: Vadym Shovkoplias > > In this condition dri2_dpy->driver_name string always equals > NULL, so call to free() is useless > > Signed-off-by: Vadym Shovkoplias Reviewed and pushed :) Are you finding all of these by

Re: [Mesa-dev] [PATCH] glx/dri3: Remove unused deviceName variable

Indeed, been like this since creation, never changed. Reviewed-by: Eric Engestrom and pushed, thanks :) > > Signed-off-by: Vadym Shovkoplias > > --- > src/glx/dri3_glx.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/src/glx/dri3_glx.c

Re: [Mesa-dev] [PATCH 1/2] meson: install dri internal headers.

On Thursday, 2017-11-30 10:40:11 -0800, Dylan Baker wrote: > Reported-by: Marc Dietrich > Signed-off-by: Dylan Baker Both patches are: Reviewed-by: Eric Engestrom > --- > include/meson.build | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/

Re: [Mesa-dev] [PATCH] st/va: Enable vaExportSurfaceHandle()

On Friday, 2017-12-01 00:31:48 +, Mark Thompson wrote: > It will be present from libva 2.1 (VAAPI 1.1.0 or higher). > > Signed-off-by: Mark Thompson > --- > See: > >

Re: [Mesa-dev] [PATCH 1/2] meson: fix GLES3/gl31.h install

On Wednesday, 2017-11-29 11:19:54 -0800, Dylan Baker wrote: > This is a typo, gl32.h is installed twice. > > Reported-by: Marc Dietrich > Signed-off-by: Dylan Baker Both are Reviewed-by: Eric Engestrom > --- > include/meson.build | 2 +- > 1 file changed, 1 ins

Re: [Mesa-dev] [PATCH mesa] u_debug: do not compile asserts when they are disabled

On Thursday, 2017-11-30 12:16:06 +, Eric Engestrom wrote: > Commit f0ba7d897d1c22202531a added this code to expose asserts to the > compiler in an attempt to hide 'unused variable' warnings, incorrectly > claiming it was a no-op. This has two bad effects: > - any assert

[Mesa-dev] [PATCH mesa] u_debug: do not compile asserts when they are disabled

in the rest of Mesa. Fixes: f0ba7d897d1c22202531a "util: better fix for unused variable warnings with asserts" Cc: Keith Whitwell Reported-by: Gert Wollny Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/util/u_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

On Tuesday, 2017-11-28 20:19:46 +0100, Gert Wollny wrote: > Am Dienstag, den 28.11.2017, 10:53 + schrieb Eric Engestrom: > > > > > The parameters to a preprocessor macro are (basically) just > > > text.  They are not evaluated until after the macro is > > >

Re: [Mesa-dev] Refactored st/omx/tizonia commits

On Wednesday, 2017-11-29 16:23:26 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-29 07:19:02) > > On Wednesday, 2017-11-29 09:32:09 +0530, Gurkirpal Singh wrote: > > > These are the refactored commits related to the GSoC project involving > > > adding a

Re: [Mesa-dev] [PATCH 00/14] meson: most of gallium

ylan Baker (14): > meson: Combine gallium target subdirs > meson: sort gallium drivers after winsys > meson: define driver dependencies > meson: use the driver dependencies for the gallium dri target Nice cleanups! ^ I much prefer the code after your patches. I had a quick

Re: [Mesa-dev] Refactored st/omx/tizonia commits

On Wednesday, 2017-11-29 09:32:09 +0530, Gurkirpal Singh wrote: > These are the refactored commits related to the GSoC project involving > adding a st/omx state tracker using tizonia. > There are still some parts of code that i didn't refactor yet as > explained below: > 1) I wasn't sure if it's ok

Re: [Mesa-dev] [PATCH 03/23] radeonsi: move r600_test_dma.c into si_test_dma.c

On Tuesday, 2017-11-28 22:38:31 +0100, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/Makefile.sources| 1 - > src/gallium/drivers/radeon/r600_pipe_common.h | 3 --- > src/gallium/drivers/radeonsi/Makefile.sources | 1 + > src/gallium/drivers/rad

[Mesa-dev] [PATCH mesa] gallium/hud: use #ifdef to test for macro existence

Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/hud/hud_context.c | 10 +- src/gallium/auxiliary/hud/hud_cpufreq.c | 2 +- src/gallium/auxiliary/hud/hud_diskstat.c | 2 +- src/gallium/auxiliary/hud/hud_nic.c | 2 +- src/gallium/auxiliary/hud

Re: [Mesa-dev] [PATCH] anv: Check if memfd_create is already defined.

644 > --- a/meson.build > +++ b/meson.build > @@ -617,7 +617,7 @@ foreach h : ['xlocale.h', 'sys/sysctl.h', 'linux/futex.h'] >endif > endforeach > > -foreach f : ['strtof', 'mkostemp', 'posix_memalign', 'timespe

Re: [Mesa-dev] [PATCH 2/3] meson: Add lmsensors support

cc.find_library('libsensors') > + pre_args += '-DHAVE_LIBSENSORS=1' > +endif I'd write it like this maybe? _sensors = get_option('lmsensors') if _sensors != 'false' dep_lmsensors = cc.find_library('libsensors', required : _sensors ==

[Mesa-dev] [PATCH mesa] mesa: suppress -Wundef warning for DEBUG_{FP, VP}

EBUG/ The third option, which this patch does, is keep it as dead code, but it can be enabled by adding a `#define DEBUG_{FP,VP}` locally. Signed-off-by: Eric Engestrom --- src/mesa/program/arbprogparse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/pro

Re: [Mesa-dev] [PATCH 0/7] [RFC] meson: build src/glx/windows

cygwin > meson: don't require dri2proto for darwin or windows > meson: fix deps and underlinkage of libGL all the above, ie. 1-4 & 6-7, are: Reviewed-by: Eric Engestrom > meson: build src/glx/windows this one, ie. 5/7, with dylan's comments, is: Acked-by: Eric En

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

On Tuesday, 2017-11-28 21:59:52 +0900, Tomasz Figa wrote: > On Tue, Nov 28, 2017 at 7:12 PM, Eric Engestrom > wrote: > > On Monday, 2017-11-27 22:00:43 +0100, Robert Foss wrote: > >> Hey Rob, > >> > >> On Mon, 2017-11-27 at 13:42 -0600, Rob Herring wrote:

Re: [Mesa-dev] [PATCH 11/24] spirv_extensions: add list of extensions and to_string method

On Tuesday, 2017-11-28 14:01:38 +0100, Alejandro Piñeiro wrote: > On 28/11/17 11:36, Eric Engestrom wrote: > > On Monday, 2017-11-27 13:21:31 +0200, Tapani Pälli wrote: > >> > >> On 11/15/2017 03:22 PM, Eduardo Lima Mitev wrote: > >>> From: Alejandro Piñe

Re: [Mesa-dev] [PATCH mesa] mapi: use variable to reference generated 'glapi_gentable.c' file

On Tuesday, 2017-11-28 11:51:32 +, Emil Velikov wrote: > Dylan/Jon already beat you to it ;-) > See patch "meson: fix generated source inclusion on macOS and Windows" Indeed, thanks ^^ I saw that series though, but somehow forgot about it. Reviewing it now. > > -Emil

[Mesa-dev] [PATCH mesa] mapi: use variable to reference generated 'glapi_gentable.c' file

Signed-off-by: Eric Engestrom --- src/mapi/glapi/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/meson.build b/src/mapi/glapi/meson.build index 14ffa68ad0daa06a32ed..470431de33d81a26d367 100644 --- a/src/mapi/glapi/meson.build +++ b/src/mapi/glapi

Re: [Mesa-dev] [PATCH mesa 04/16] amd: remove always-true BRAHMA_BUILD define

On Friday, 2017-11-24 19:20:12 +0100, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Fri, Nov 24, 2017 at 7:07 PM, Eric Engestrom > wrote: > > Signed-off-by: Eric Engestrom > > --- > > src/amd/Android.addrlib.mk | 2

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

On Monday, 2017-11-27 12:53:39 -0800, Ian Romanick wrote: > On 11/27/2017 10:46 AM, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-27 09:46:57) > >> On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote: > >>> Am Freitag, den 24.11.2017, 18:0

Re: [Mesa-dev] [PATCH 11/24] spirv_extensions: add list of extensions and to_string method

On Monday, 2017-11-27 13:21:31 +0200, Tapani Pälli wrote: > > > On 11/15/2017 03:22 PM, Eduardo Lima Mitev wrote: > > From: Alejandro Piñeiro > > > > Ideally this should be generated somehow. One option would be gather > > all the extension dependencies listed on the core grammar, but there > >

Re: [Mesa-dev] [PATCH 2/3] radv: Use the suffixed versions of VK_QUEUE_GLOBAL_PRIORITY_*

On Monday, 2017-11-27 19:08:42 -0800, Jason Ekstrand wrote: > On Mon, Nov 27, 2017 at 7:00 PM, Ian Romanick wrote: > > > I am strongly in favor of this precedent. One thing that has annoyed me > > for years about Mesa's OpenGL code is the use of mixed suffixes through > > the code base as an ext

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

On Monday, 2017-11-27 22:00:43 +0100, Robert Foss wrote: > Hey Rob, > > On Mon, 2017-11-27 at 13:42 -0600, Rob Herring wrote: > > On Mon, Nov 27, 2017 at 8:14 AM, Robert Foss > om> wrote: > > > From: Tomasz Figa > > > > > > There is no API available to properly query the > > > IMPLEMENTATION_DE

Re: [Mesa-dev] [PATCH 1/2] docs/llvmpipe.html: Add ppc64le as alternative architecture to x86.

On Monday, 2017-11-27 14:44:58 -0500, Ben Crocker wrote: > Power8, Power8NV, and Power9 are supported on an equal footing > with X86. > > Cc: "17.2" "17.3" > Signed-off-by: Ben Crocker > --- > docs/llvmpipe.html | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > >

Re: [Mesa-dev] [PATCH mesa 02/16] anv: tie anv_assert() enablement to regular assert()

On Sunday, 2017-11-26 10:12:46 +1100, Timothy Arceri wrote: > On 25/11/17 08:02, Timothy Arceri wrote: > > On 25/11/17 05:07, Eric Engestrom wrote: > > > Signed-off-by: Eric Engestrom > > > --- > > >   src/intel/vulkan/anv_private.h | 2 +- > > >

Re: [Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote: > Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom: > > Signed-off-by: Eric Engestrom > > --- > >  src/util/ralloc.c | 18 +- > >  src/util/slab.c   |  4 ++-- > >  2 fi

[Mesa-dev] [PATCH mesa] i965: const a few structs and vars to avoid writing to them by accident

Signed-off-by: Eric Engestrom --- This is why I like to const everything ;) Feel free to push this patch when you land yours. --- src/mesa/drivers/dri/i965/genX_state_upload.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH mesa] util: add mesa-sha1 test to meson

Fixes: 513d7ffa23d42e96f831 "util: Add a SHA1 unit test program" Signed-off-by: Eric Engestrom --- src/util/meson.build | 9 + 1 file changed, 9 insertions(+) diff --git a/src/util/meson.build b/src/util/meson.build index ac86c9e111eeb89a0249..b54c20796ff01012759b 100644 ---

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

On Sunday, 2017-11-26 17:24:09 -0800, Eric Anholt wrote: > Eric Engestrom writes: > > > On Wednesday, 2017-11-22 12:28:17 -0800, Eric Anholt wrote: > >> Jordan Justen writes: > >> > >> > On 2017-11-22 09:59:34, Eric Engestrom wrote: > >> >

Re: [Mesa-dev] [PATCH 1/5] configure.ac: add Wundef to the build flags

On Friday, 2017-11-24 18:14:41 +, Emil Velikov wrote: > On 24 November 2017 at 14:32, Eric Engestrom > wrote: > > On Friday, 2017-11-24 14:25:02 +, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> From the manual: > >> Warn if

[Mesa-dev] [PATCH mesa 15/16] anv: use NDEBUG to guard asserts

Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index 907b24a758deb7181115..1dbef4f14a33302300d4 100644 --- a/src/intel/vulkan/anv_pipeline.c

[Mesa-dev] [PATCH mesa 13/16] compiler: fix typo

Signed-off-by: Eric Engestrom --- src/compiler/nir/nir_lower_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/nir_lower_io.c index 3879f0297d3959e720ff..df91febd68dd1f5fa7af 100644 --- a/src/compiler/nir/nir_lower_io.c

[Mesa-dev] [PATCH mesa 08/16] amd/addrlib: fix DEBUG guards

Use the normal `#ifdef` style used by the rest of Mesa, instead of sometimes locally defining DEBUG on non-debug builds and then relying on the precompiler converting #undef'ed macros to 0 when checking. Signed-off-by: Eric Engestrom --- I would argue this block should go, as all it do

[Mesa-dev] [PATCH mesa 16/16] util: use NDEBUG to guard asserts

Signed-off-by: Eric Engestrom --- src/util/ralloc.c | 18 +- src/util/slab.c | 4 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/util/ralloc.c b/src/util/ralloc.c index 42cfa2e391d52df68db2..b52079ac075a0fe11944 100644 --- a/src/util/ralloc.c +++ b

[Mesa-dev] [PATCH mesa 12/16] compiler: use NDEBUG to guard asserts

nir_validate.c's #endif already had the correct NDEBUG comment Fixes: dcb1acdea00a8f2c29777 "nir/validate: Only build in debug mode" Fixes: 9ff71b649b4b3808a9e17 "i965/nir: Validate that NIR passes call nir_metadata_preserve()" Signed-off-by: Eric Engestrom --

[Mesa-dev] [PATCH mesa 06/16] amd/addrlib: fix macro test

Check macro existence instead of relying on the compiler turning undef into 0. Signed-off-by: Eric Engestrom --- src/amd/addrlib/core/addrlib1.cpp | 2 +- src/amd/addrlib/r800/egbaddrlib.cpp | 4 ++-- src/amd/addrlib/r800/siaddrlib.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions

[Mesa-dev] [PATCH mesa 14/16] util/cache: use NDEBUG to guard asserts

Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/util/u_cache.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_cache.c b/src/gallium/auxiliary/util/u_cache.c index c748cb99dd0c468f4342..f14ba97996873a716aff 100644 --- a/src

[Mesa-dev] [PATCH mesa 09/16] amd/addrlib: add comment about breakpoint not working in some cases

Signed-off-by: Eric Engestrom --- src/amd/addrlib/core/addrcommon.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/addrlib/core/addrcommon.h b/src/amd/addrlib/core/addrcommon.h index 1a7473a4d33c1271f077..9261c5890903d0dc1c0b 100644 --- a/src/amd/addrlib/core

[Mesa-dev] [PATCH mesa 11/16] broadcom: use NDEBUG to guard asserts

Signed-off-by: Eric Engestrom --- src/broadcom/cle/v3d_packet_helpers.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/broadcom/cle/v3d_packet_helpers.h b/src/broadcom/cle/v3d_packet_helpers.h index c86cad85266f503dbeba..bc1bf3eb76ec94aff16d 100644 --- a/src

[Mesa-dev] [PATCH mesa 07/16] amd/addrlib: use NDEBUG to guard asserts

Signed-off-by: Eric Engestrom --- src/amd/addrlib/core/addrelemlib.cpp | 2 +- src/amd/addrlib/core/addrlib1.cpp| 8 src/amd/addrlib/core/addrlib2.h | 2 +- src/amd/addrlib/gfx9/gfx9addrlib.cpp | 4 ++-- src/amd/addrlib/r800/egbaddrlib.cpp | 2 +- 5 files changed, 9 insertions

[Mesa-dev] [PATCH mesa 10/16] vc4: check preprocessor token existence using #ifdef instead of #if

(other uses of USE_VC4_SIMULATOR are already correct) Signed-off-by: Eric Engestrom --- src/gallium/drivers/vc4/vc4_screen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_screen.c b/src/gallium/drivers/vc4/vc4_screen.c index

[Mesa-dev] [PATCH mesa 04/16] amd: remove always-true BRAHMA_BUILD define

Signed-off-by: Eric Engestrom --- src/amd/Android.addrlib.mk | 2 -- src/amd/Makefile.addrlib.am | 3 +-- src/amd/addrlib/core/addrcommon.h| 15 ++- src/amd/addrlib/meson.build | 2 +- src/gallium/winsys/amdgpu/drm/Android.mk | 4

[Mesa-dev] [PATCH mesa 02/16] anv: tie anv_assert() enablement to regular assert()

Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 6d4e43f2e687cbf26ccd..6474abf0f3694c7fcd3a 100644 --- a/src/intel/vulkan/anv_private.h +++ b

[Mesa-dev] [PATCH mesa 03/16] radv: tie radv_assert() enablement to regular assert()

Signed-off-by: Eric Engestrom --- src/amd/vulkan/radv_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h index addd35e5ce10fa37bd3f..327ce5415947abc1712d 100644 --- a/src/amd/vulkan/radv_private.h +++ b/src

[Mesa-dev] [PATCH mesa 05/16] amd/addrlib: remove duplicate definition of ADDR_DBG_BREAK()

It's already defined above (around line 60). Signed-off-by: Eric Engestrom --- src/amd/addrlib/core/addrcommon.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/amd/addrlib/core/addrcommon.h b/src/amd/addrlib/core/addrcommon.h index 99bb62e77f446f912d35..80ea0eb247aa48dcb176 1

[Mesa-dev] [PATCH mesa 01/16] c99_{compat, math}.h: check for macro existance before using it

Fixes thousands of warnings when using -Wundef, which is about to land, as these two files are included virtually everywhere. Signed-off-by: Eric Engestrom --- include/c99_compat.h | 6 +++--- include/c99_math.h | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include

Re: [Mesa-dev] [PATCH 1/5] configure.ac: add Wundef to the build flags

in the less commonly used codepaths. > > Note: this will trigger a lot of extra warnings, with ~60 of those being > unique. Once all those are resolved we'd want to promote the warning to > an error. Yes please; series is Reviewed-by: Eric Engestrom > &g

Re: [Mesa-dev] [PATCH 44/51] glsl: WIP: Add lowering pass for treating mediump as float16

On Friday, 2017-11-24 14:27:11 +0200, Topi Pohjolainen wrote: > At least the following need more thought: > > 1) Converting right-hand-side of assignments from 16-bits to 32-bits >- More correct thing to do is to treat rhs as 32-bits latest in the > expression producing the value > > 2)

Re: [Mesa-dev] [PATCH mesa] compiler: use proper guard for asserts

I ended up looking at all the uses of DEBUG in Mesa, and will send a whole series next week, including more changes in nir & compiler, so you can disregard this patch for now. On Thursday, 2017-11-23 13:24:25 +0000, Eric Engestrom wrote: > nir_validate.c's #endif already had the co

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

On Thursday, 2017-11-23 16:32:06 +, Emil Velikov wrote: > On 23 November 2017 at 16:04, Eric Engestrom > wrote: > > On Thursday, 2017-11-23 13:32:47 +, Emil Velikov wrote: > >> Hi Eric, > >> > >> On 22 November 2017 at 17:59, Eric Engestrom >

[Mesa-dev] [PATCH mesa] st/dri: replace hard-coded array size with ARRAY_SIZE()

Signed-off-by: Eric Engestrom --- Could've sworn I had already seen someone post this patch; guess either I was mistaken, or it got lost on the way. --- src/gallium/state_trackers/dri/dri_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_tracker

Re: [Mesa-dev] [PATCH 2/3] util: Add a SHA1 unit test program

On Friday, 2017-11-24 10:08:55 +, Eric Engestrom wrote: > On Thursday, 2017-11-23 11:08:05 -0800, Matt Turner wrote: > > --- > > src/util/Makefile.am | 3 ++- > > src/util/mesa-sha1_test.c | 65 > > +++ > >

Re: [Mesa-dev] [PATCH] gl_table.py: add extern C guard for the generated glapitable.h

On Thursday, 2017-11-23 19:01:22 +, Emil Velikov wrote: > From: Emil Velikov > > Cc: mesa-sta...@lists.freedesktop.org > Cc: Dylan Baker > Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom > --- > src/mapi/glapi/gen/gl_table.py | 8 > 1 fi

Re: [Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

On Thursday, 2017-11-23 11:08:04 -0800, Matt Turner wrote: > The code defines a macro blk0(i) based on the preprocessor condition > BYTE_ORDER == LITTLE_ENDIAN. If true, blk0(i) is defined as a byte swap > operation. Unfortunately, if the preprocessor macros used in the test > are no defined, then

Re: [Mesa-dev] [PATCH 2/3] util: Add a SHA1 unit test program

ocks! 300", "b2180263e37d3bed6a4be0afe41b1a82ebbcf4c3"}, > + {"Mesa Rocks! 583", "7fb9734108a62503e8a149c1051facd7fb112d05"}, > + }; > + > + bool failed = false; > + int i; > + > + for (i = 0; i < ARRAY_SIZE(test_data); i++) { >

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

On Thursday, 2017-11-23 13:32:47 +, Emil Velikov wrote: > Hi Eric, > > On 22 November 2017 at 17:59, Eric Engestrom > wrote: > > A recent thread [1] made me check our local specs to see which ones were > > upstream. This series removes the ones that are identical u

[Mesa-dev] [PATCH mesa] compiler: use proper guard for asserts

nir_validate.c's #endif already had the correct NDEBUG comment Fixes: dcb1acdea00a8f2c29777 "nir/validate: Only build in debug mode" Fixes: 9ff71b649b4b3808a9e17 "i965/nir: Validate that NIR passes call nir_metadata_preserve()" Signed-off-by: Eric Engestrom --

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

On Wednesday, 2017-11-22 12:28:17 -0800, Eric Anholt wrote: > Jordan Justen writes: > > > On 2017-11-22 09:59:34, Eric Engestrom wrote: > >> A recent thread [1] made me check our local specs to see which ones were > >> upstream. This series removes the on

[Mesa-dev] [PATCH mesa 4/7] docs/specs: remove upstreamed spec EXT_shader_integer_mix

Spec is now available on Khronos: https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_shader_integer_mix.txt Signed-off-by: Eric Engestrom --- docs/specs/EXT_shader_integer_mix.spec | 138 - 1 file changed, 138 deletions(-) delete mode 100644 docs/specs

[Mesa-dev] [PATCH mesa 5/7] docs/specs: remove upstreamed spec MESA_agp_offset

Spec is now available on Khronos: https://www.khronos.org/registry/OpenGL/extensions/MESA/GLX_MESA_agp_offset.txt Signed-off-by: Eric Engestrom --- docs/specs/MESA_agp_offset.spec | 95 - 1 file changed, 95 deletions(-) delete mode 100644 docs/specs

[Mesa-dev] [PATCH mesa 7/7] docs/specs: remove upstreamed spec MESA_set_3dfx_mode

Spec is now available on Khronos: https://www.khronos.org/registry/OpenGL/extensions/MESA/GLX_MESA_set_3dfx_mode.txt Signed-off-by: Eric Engestrom --- docs/specs/MESA_set_3dfx_mode.spec | 85 -- 1 file changed, 85 deletions(-) delete mode 100644 docs/specs

[Mesa-dev] [PATCH mesa 6/7] docs/specs: remove upstreamed spec MESA_pixmap_colormap

Spec is now available on Khronos: https://www.khronos.org/registry/OpenGL/extensions/MESA/GLX_MESA_pixmap_colormap.txt Signed-off-by: Eric Engestrom --- docs/specs/MESA_pixmap_colormap.spec | 90 1 file changed, 90 deletions(-) delete mode 100644 docs/specs

[Mesa-dev] [PATCH mesa 3/7] docs/specs: remove upstreamed spec MESA_shader_integer_functions

Spec is now available on Khronos: https://www.khronos.org/registry/OpenGL/extensions/MESA/MESA_shader_integer_functions.txt Signed-off-by: Eric Engestrom --- docs/specs/MESA_shader_integer_functions.txt | 522 --- 1 file changed, 522 deletions(-) delete mode 100644 docs

[Mesa-dev] [PATCH mesa 1/7] docs/specs: remove upstreamed spec EGL_MESA_platform_surfaceless

Spec is now available on Khronos: https://www.khronos.org/registry/EGL/extensions/MESA/EGL_MESA_platform_surfaceless.txt Signed-off-by: Eric Engestrom --- docs/specs/EGL_MESA_platform_surfaceless.txt | 120 --- 1 file changed, 120 deletions(-) delete mode 100644 docs

[Mesa-dev] [PATCH mesa 2/7] docs/specs: remove upstreamed spec MESA_image_dma_buf_export

Spec is now available on Khronos: https://www.khronos.org/registry/EGL/extensions/MESA/EGL_MESA_image_dma_buf_export.txt Signed-off-by: Eric Engestrom --- docs/specs/MESA_image_dma_buf_export.txt | 147 --- 1 file changed, 147 deletions(-) delete mode 100644 docs

[Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

sa-dev/2017-November/177861.html Eric Engestrom (7): docs/specs: remove upstreamed spec EGL_MESA_platform_surfaceless docs/specs: remove upstreamed spec MESA_image_dma_buf_export docs/specs: remove upstreamed spec MESA_shader_integer_functions docs/specs: remove upstreamed spec EXT_shader_inte

Re: [Mesa-dev] [PATCH v2 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

On Tuesday, 2017-11-21 11:24:48 -0800, Jordan Justen wrote: > On 2017-11-21 05:45:36, Eric Engestrom wrote: > > On Monday, 2017-11-20 14:27:27 -0800, Jordan Justen wrote: > > > Similar idea to Tim's "spec: MESA_program_binary", but simplified

Re: [Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

On Tuesday, 2017-11-21 10:50:29 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-21 10:38:25) > > On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote: > > > This is still not fully correct (haiku and BSD is notably probably not > > > correct), but Linu

[Mesa-dev] [PATCH mesa] genxml: fix assert guards

This removes a few hundred warnings on debug builds with asserts off. Signed-off-by: Eric Engestrom --- src/intel/genxml/gen_pack_header.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/genxml/gen_pack_header.py b/src/intel/genxml/gen_pack_header.py

Re: [Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote: > This is still not fully correct (haiku and BSD is notably probably not > correct), but Linux is not regressed and this should be correct for > macOS and Windows. > > v2: - set the dri_platform to windows on Cygwin as well (Jon) R-b stand

[Mesa-dev] [PATCH mesa 2/2] meson: add variable for mapi_abi.py instead of going back up the tree

Signed-off-by: Eric Engestrom --- src/mapi/es1api/meson.build | 2 +- src/mapi/es2api/meson.build | 2 +- src/mapi/glapi/gen/meson.build| 2 +- src/mapi/meson.build | 2 ++ src/mapi/shared-glapi/meson.build | 2 +- 5 files changed, 6 insertions(+), 4 deletions

[Mesa-dev] [PATCH mesa 1/2] meson: reorder subdirs to avoid directly including more than one level

Signed-off-by: Eric Engestrom --- src/mapi/glapi/meson.build | 2 ++ src/mapi/meson.build | 2 +- src/meson.build| 1 - 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/meson.build b/src/mapi/glapi/meson.build index d2d86afd6c1f07e06489

[Mesa-dev] [PATCH mesa] meson: fix strtof locale support check

Fixes: d1992255bb29054fa5176 "meson: Add build Intel "anv" vulkan driver" Signed-off-by: Eric Engestrom --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 383ebb366625edf9f262..4918194de48799f594d3 100644 ---

Re: [Mesa-dev] [PATCH 0/6] meson: some non-linux OS work

e > meson: Fix LLVM requires for radeonsi > meson: add logic to select apple and windows dri > meson: replace with_*dri with with_dri_platform Series is Reviewed-by: Eric Engestrom > > meson.build| 77 > +++--- >

Re: [Mesa-dev] [PATCH 7/8] glapi: Don't search through subdirs from glapitable.h

+ -I$(top_builddir)/src/mapi/glapi \ > + -I$(top_srcdir)/src/mapi/glapi \ do we need srcdir here? Other than that, the series is Reviewed-by: Eric Engestrom > -I$(top_builddir)/src/mesa \ > -I$(top_srcdir)/src/mesa \ > -I$(top_srcdir)/include \ > -- > 2.15.0

Re: [Mesa-dev] [PATCH v2 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

On Monday, 2017-11-20 14:27:27 -0800, Jordan Justen wrote: > Similar idea to Tim's "spec: MESA_program_binary", but simplified and > written to support both ARB_get_program_binary and > OES_get_program_binary. > > This spec was merged into the OpenGL Registry in version > 667c5a253781834b40a6ae9eb

Re: [Mesa-dev] [PATCH 12/12] spirv: Generate SPIR-V builder infrastructure

On Monday, 2017-11-20 17:24:10 -0800, Ian Romanick wrote: > From: Ian Romanick > > v2: Don't try to automatically set SpvCapabilityGeometry or > SpvCapabilityTessellation. > > v3: Move some changes from a later patch back into this patch. They > were only in the later patch because of rebase fa

Re: [Mesa-dev] [PATCH 11/12] spirv: Generate code to track SPIR-V capability dependencies

On Monday, 2017-11-20 17:24:09 -0800, Ian Romanick wrote: > From: Ian Romanick > > v2: Clean ups. Remove some functions that never ended up being used. > > v3: After updating spirv.core.grammar.json, fix the handling of > ShaderViewportMaskNV. See the comment around line 71 of > spirv_capabili

Re: [Mesa-dev] [PATCH 10/12] spirv: Move SPIR-V building to Makefile.spirv.am and spirv/meson.build

.spirv.am (and > it would be silly anyway). > > v2: Do it for meson too. Reviewed-by: Eric Engestrom # for the meson bits > > Signed-off-by: Ian Romanick > --- > src/compiler/Makefile.am | 2 ++ > src/compiler/Makefile.nir.am | 31 ++

Re: [Mesa-dev] [PATCH v4 2/4] meson: disable x86 asm in fewer cases.

building on Linux I can't test this and I > don't want to write/enable code that cannot even be build tested. > > v4: - set condition to build == x86_64 and host == 'x86' and > build.system == host.system > > Signed-off-by: Dylan Baker Reviewed-by: Er

Re: [Mesa-dev] [PATCH v5 07/13] meson: extend install_megadrivers script to handle symmlinking

the > DSO and the script will automatically generate the appropriate > symlinks as necessary. I'm ok with this solution :) One typo in the commit title ("symmlinking" s/mm/m/), but this patch and patch 8/13 are: Reviewed-by: Eric Engestrom (sorry for being a bit o

Re: [Mesa-dev] [PATCH] mapi: Teach es{1, 2}api/ABI-check shared library names on Cygwin

_1_extension_pack.pdf) > > -if [ $(uname) == "Darwin" ] > -then > +case $(uname) in Please quote this :) > +"Darwin") >LIB=${1-es1api/.libs/libGLESv1_CM.dylib} > -else > + ;; > +"CYGWIN"*) Quotes here and on `"Darwin"` don

Re: [Mesa-dev] [PATCH 1/4] meson: Enable SSE4.1 optimizations

On Friday, 2017-11-17 12:34:12 -0800, Dylan Baker wrote: > Quoting Emil Velikov (2017-11-17 03:11:50) > > On 16 November 2017 at 22:21, Dylan Baker wrote: > > > Quoting Emil Velikov (2017-11-16 03:35:17) > > >> Hi Dylan, > > >> > > >> On 16 November 2017 at 01:10, Dylan Baker wrote: > > >> > This

Re: [Mesa-dev] [PATCH v3] meson: Enable SSE4.1 optimizations

.1 (Matt) Maybe add this sentence as a comment just before the `if`? > v3: - x64 -> x86_64 (Matt) > > Signed-off-by: Dylan Baker > Reviewed-by: Eric Engestrom (v1) R-b refreshed :) > --- > meson.build | 15 ++- > src/mesa/meson.build | 14 +

Re: [Mesa-dev] [PATCH v4 07/13] meson: extend install_megadrivers script to handle symmlinking

On Thursday, 2017-11-16 16:27:35 -0800, Dylan Baker wrote: > Which is required for the gallium media state trackers. > > v4: - Make the full version the hard link and the partial so versiions > the symlinks > > Signed-off-by: Dylan Baker > --- > bin/install_megadrivers.py | 19 +++

<    7   8   9   10   11   12   13   14   15   16   >