Re: [Mesa-dev] [PATCH v2] swr: move msaa resolve to generalized StoreTile

2017-04-27 Thread Ilia Mirkin
Erm, so ... what happens if I render to FB1, then render to FB2, then render to FB1 again (and I have blending enabled)? Doesn't the resolve lose the per-sample information? Or does the resolve merely precompute the resolved version on the off chance that it's needed, without losing the source data

Re: [Mesa-dev] [PATCH] Android: fix r300g only build

2017-04-27 Thread Ilia Mirkin
On Thu, Apr 27, 2017 at 12:31 PM, Rob Herring wrote: > On Thu, Apr 27, 2017 at 11:18 AM, Ilia Mirkin wrote: >> On Thu, Apr 27, 2017 at 11:36 AM, Emil Velikov >> wrote: >>> On 27 April 2017 at 16:11, Rob Herring wrote: >>> >>>> >>>&

Re: [Mesa-dev] [PATCH] Android: fix r300g only build

2017-04-27 Thread Ilia Mirkin
On Thu, Apr 27, 2017 at 11:36 AM, Emil Velikov wrote: > On 27 April 2017 at 16:11, Rob Herring wrote: > >> >> BTW, mesa lists this as the LLVM version requirements: >> >> LLVM_REQUIRED_GALLIUM=3.3.0 > src/gallium/auxiliary/{draw,gallivm}, used by > - nouveau (nv30), i915, r300, softpipe (yes) an

Re: [Mesa-dev] [PATCH v2 3/4] nvc0: Add new launch descriptor format for GP100

2017-04-26 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Apr 26, 2017 at 9:21 AM, Boyan Ding wrote: > v2: > Also handle the the new format in indirect dispatch > Use compute class check instead of chipset check > > Signed-off-by: Boyan Ding > --- > src/gallium/drivers/nouveau/nvc0

Re: [Mesa-dev] [PATCH 2/2] swr: Fix polygonmode for front==back

2017-04-25 Thread Ilia Mirkin
This will cause asserts on piglit and dEQP runs instead of failures. This is incredibly inconvenient, as e.g. dEQP runs everything in a single process. On Apr 25, 2017 7:29 PM, "George Kyriazis" wrote: > Add logic for converting enums and also making sure stipple works. > > CC: > > --- > src/g

Re: [Mesa-dev] [PATCH 3/4] radeonsi: disable the TGSI merge registers pass

2017-04-25 Thread Ilia Mirkin
I've hated this pass for quite a while. It is necessary for nv30 but is actively harmful for nv50+ due to the undef issue nha points out. I haven't looked closely at the impl details, but the idea is acked-by me. On Apr 25, 2017 5:44 AM, "Samuel Pitoiset" wrote: > > > On 04/25/2017 08:47 AM, Nic

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

2017-04-25 Thread Ilia Mirkin
On Tue, Apr 25, 2017 at 8:51 AM, Christian König wrote: > Am 21.04.2017 um 15:38 schrieb Emil Velikov: >> >> On 21 April 2017 at 13:31, Christian König >> wrote: >>> >>> Am 21.04.2017 um 14:11 schrieb Emil Velikov: Both headers are used everywhere, plus they both provide interop me

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: drop the merge_registers() pass

2017-04-24 Thread Ilia Mirkin
It would kill nv30, I believe. On Apr 24, 2017 10:30 PM, "Roland Scheidegger" wrote: > Am 24.04.2017 um 23:12 schrieb Rob Clark: > > so I guess this is likely to hurt pipe drivers that don't (yet?) > > have a real compiler backend. (Ie. etnaviv and freedreno/a2xx.) So > > maybe it should be op

Re: [Mesa-dev] [RFC 4/4] nvc0: Enable compute support for Pascal

2017-04-23 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin I'd like to get some testing on this to make sure that things do kinda work, at least as well as on maxwell. Perhaps a deqp run, which has a lot of compute/image/etc tests? On Sun, Apr 23, 2017 at 11:19 AM, Boyan Ding wrote: > Signed-off-by: Bo

Re: [Mesa-dev] [PATCH 1/7] gallium: fold u_trim_pipe_prim call from st/mesa to drivers

2017-04-20 Thread Ilia Mirkin
On Thu, Apr 20, 2017 at 12:00 PM, Marek Olšák wrote: > On Fri, Apr 14, 2017 at 6:47 PM, Ilia Mirkin wrote: >> On Fri, Apr 14, 2017 at 12:42 PM, Marek Olšák wrote: >>> On Fri, Apr 14, 2017 at 5:45 PM, Ilia Mirkin wrote: >>>> On Fri, Apr 14, 2017 at 11:07 AM, Marek

Re: [Mesa-dev] [PATCH 2/2] nvc0: Add support for ARB_vertex_shader{layer, viewport_index}

2017-04-19 Thread Ilia Mirkin
On Wed, Apr 19, 2017 at 5:10 PM, Lyude wrote: > Enables support for the ARB_vertex_shader_layer and > ARB_vertex_shader_layer_viewport_index extensions for the GM200. There are no such extensions. There are AMD_bla bla extensions. Also, Nicolai recently added a new cap called PIPE_CAP_TGSI_TES_L

Re: [Mesa-dev] [PATCH 1/2] nvc0/ir: Export viewport index in fragment shaders

2017-04-19 Thread Ilia Mirkin
On Wed, Apr 19, 2017 at 5:10 PM, Lyude wrote: > Since ABR_vertex_shader_layer/viewport_index enables the ability to > interact with gl_ViewportIndex from the fragment shader, we don't want > to skip emitting the viewport index for fragment shaders. > > As well, only save the viewport index into a

Re: [Mesa-dev] [RFC PATCH 03/26] glsl: introduce new base types for bindless samplers/images

2017-04-19 Thread Ilia Mirkin
On Wed, Apr 19, 2017 at 5:47 AM, Nicolai Hähnle wrote: > By the way, this is also how Ilia's example would be implemented. When > inlined, it could become something like: > > layout (bound_sampler) uniform sampler2D u_tex; > in sampler2D in_tex; > > void main() > { > ... > sampler2

Re: [Mesa-dev] [RFC PATCH 03/26] glsl: introduce new base types for bindless samplers/images

2017-04-18 Thread Ilia Mirkin
On Tue, Apr 18, 2017 at 5:26 PM, Nicolai Hähnle wrote: > On 18.04.2017 21:49, Dave Airlie wrote: >> >> On 19 April 2017 at 05:30, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 04/18/2017 08:14 PM, Nicolai Hähnle wrote: On 11.04.2017 18:48, Samuel Pitoiset wrote: > > > Bi

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-18 Thread Ilia Mirkin
On Tue, Apr 18, 2017 at 2:21 AM, Michel Dänzer wrote: > On 18/04/17 01:02 PM, Ilia Mirkin wrote: >> On Tue, Apr 18, 2017 at 12:00 AM, Ilia Mirkin wrote: >>> val_bool and val_int are in a union. val_bool gets the first byte, which >>> happens to work on LE when setting

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-17 Thread Ilia Mirkin
On Tue, Apr 18, 2017 at 12:00 AM, Ilia Mirkin wrote: > val_bool and val_int are in a union. val_bool gets the first byte, which > happens to work on LE when setting via the int, but breaks on BE. By > setting the value properly, we are able to use DRI3 on BE architectures. > Teste

[Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

2017-04-17 Thread Ilia Mirkin
val_bool and val_int are in a union. val_bool gets the first byte, which happens to work on LE when setting via the int, but breaks on BE. By setting the value properly, we are able to use DRI3 on BE architectures. Tested by running glxgears with a NV34 in a G5 PPC. Signed-off-by: Ilia Mirkin Cc

Re: [Mesa-dev] Draft ARB_parallel_shader_compile RFC

2017-04-17 Thread Ilia Mirkin
On Mon, Apr 17, 2017 at 7:55 PM, Edward O'Callaghan wrote: > > > On 04/18/2017 12:22 AM, Ilia Mirkin wrote: >> The whole point of this extension is to allow applications to query >> compilation status without stalling, waiting for the compile. That >> means th

Re: [Mesa-dev] Draft ARB_parallel_shader_compile RFC

2017-04-17 Thread Ilia Mirkin
The whole point of this extension is to allow applications to query compilation status without stalling, waiting for the compile. That means that glCompileShader/glLinkProgram should return immediately while the real work proceeds in the background. I don't think you've done that here. As an aside

Re: [Mesa-dev] [PATCH 04/12] i965/cnl: Implement new pipe control workaround

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 8:35 PM, Anuj Phogat wrote: > From: Ben Widawsky > > GEN10 requires flushing all previous pipe controls before issuing a render > target cache flush. The docs seem to fairly explicitly say this is gen10 only. > > v2: Rebased on > commit 04f74d66293222d5e1905cfb930bfa083e30

Re: [Mesa-dev] [PATCH] swr: Add polygon stipple support

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 2:52 PM, Kyriazis, George wrote: > > > + /* work around the fact that poly stipple also affects lines */ > > > + /* and points, since we rasterize them as triangles, too */ > > > + /* Has to be before fragment shader, since it sets SWR_NEW_FS */ > > > + if (p_draw_i

Re: [Mesa-dev] [PATCH] mesa: replace _mesa_index_buffer::type with index_size

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 12:45 PM, Marek Olšák wrote: > On Fri, Apr 14, 2017 at 5:12 PM, Ilia Mirkin wrote: >> On Fri, Apr 14, 2017 at 11:06 AM, Marek Olšák wrote: >>> diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h >>> index d62ab4e..79f7538 100644 >>>

Re: [Mesa-dev] [PATCH 1/7] gallium: fold u_trim_pipe_prim call from st/mesa to drivers

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 12:42 PM, Marek Olšák wrote: > On Fri, Apr 14, 2017 at 5:45 PM, Ilia Mirkin wrote: >> On Fri, Apr 14, 2017 at 11:07 AM, Marek Olšák wrote: >>> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_vbo.c >>> b/src/gallium/drivers/nouveau/nv30/n

Re: [Mesa-dev] [PATCH] swr: Add polygon stipple support

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 11:18 AM, Ilia Mirkin wrote: > On Thu, Apr 13, 2017 at 4:30 PM, George Kyriazis > wrote: >> Add polygon stipple functionality to the fragment shader. >> >> Explicitly turn off polygon stipple for lines and points, since we >> do them usin

Re: [Mesa-dev] [PATCH 7/7] st/mesa: use one big translation table in st_pipe_vertex_format

2017-04-14 Thread Ilia Mirkin
Patches 2-7 are Reviewed-by: Ilia Mirkin On Fri, Apr 14, 2017 at 11:07 AM, Marek Olšák wrote: > From: Marek Olšák > > for lower overhead. > --- > src/mesa/state_tracker/st_atom_array.c | 469 > - > 1 file changed, 227 insertions(+), 242

Re: [Mesa-dev] [PATCH 2/7] gallium/util: remove util_draw_range_elements helper

2017-04-14 Thread Ilia Mirkin
on (which appears to be the case), then whatever. Reviewed-by: Ilia Mirkin > --- > src/gallium/auxiliary/util/u_draw.h | 23 --- > 1 file changed, 23 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_draw.h > b/src/gallium/auxiliary/util/u_draw.h >

Re: [Mesa-dev] [PATCH 1/7] gallium: fold u_trim_pipe_prim call from st/mesa to drivers

2017-04-14 Thread Ilia Mirkin
On Fri, Apr 14, 2017 at 11:07 AM, Marek Olšák wrote: > diff --git a/src/gallium/drivers/nouveau/nv30/nv30_vbo.c > b/src/gallium/drivers/nouveau/nv30/nv30_vbo.c > index bc9b9a1..295c394 100644 > --- a/src/gallium/drivers/nouveau/nv30/nv30_vbo.c > +++ b/src/gallium/drivers/nouveau/nv30/nv30_vbo.c >

Re: [Mesa-dev] [PATCH] swr: Add polygon stipple support

2017-04-14 Thread Ilia Mirkin
On Thu, Apr 13, 2017 at 4:30 PM, George Kyriazis wrote: > Add polygon stipple functionality to the fragment shader. > > Explicitly turn off polygon stipple for lines and points, since we > do them using tris. > --- > src/gallium/drivers/swr/swr_context.h | 4 ++- > src/gallium/drivers/swr/swr_s

Re: [Mesa-dev] [PATCH] mesa: replace _mesa_index_buffer::type with index_size

2017-04-14 Thread Ilia Mirkin
ged, this is Reviewed-by: Ilia Mirkin Might want to wait for another reviewer just in case, as this is all shared code. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/5] gallium: add PIPE_CAP_TGSI_TES_LAYER_VIEWPORT

2017-04-13 Thread Ilia Mirkin
On Thu, Apr 13, 2017 at 4:30 PM, Nicolai Hähnle wrote: > +* ``PIPE_CAP_TGSI_TES_LAYER_VIEWPORT``: Whether ``TGSI_SEMANTIC_LAYER`` and > + ``TGSI_SEMANTIC_VIEWPORT_INDEX`` are supported as tessellation evaluation > + shader outputs. Not that I'm opposed, but is there hardware that can support it

Re: [Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants and #define to enum.

2017-04-12 Thread Ilia Mirkin
On Thu, Apr 13, 2017 at 1:45 AM, Matthew Mondazzi wrote: > More relevant ISA constants put in place of chipset compares. This helps > better display which features are available to card than previous chipset > compares, making future development easier continue with. > > Signed-off-by: Matthew M

Re: [Mesa-dev] [PATCH] anv: Limit VkDeviceMemory objects to 2GB

2017-04-11 Thread Ilia Mirkin
On Tue, Apr 11, 2017 at 1:58 PM, Jason Ekstrand wrote: > Cc: "Juan A. Suárez" > --- > src/intel/vulkan/anv_device.c | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 35ef4c4..b24c739 100644 > --- a/sr

Re: [Mesa-dev] [RFC PATCH 06/26] glsl: add new 'bindless' parameter to get_{sampler, image}_instance()

2017-04-11 Thread Ilia Mirkin
On Tue, Apr 11, 2017 at 12:48 PM, Samuel Pitoiset wrote: > For replacing sampler/image types to the corresponding bindless > type, it's convenient to re-use get_{sampler,image}_instance() > instead of doing a one-by-one comparison. > > Signed-off-by: Samuel Pitoiset > --- > src/compiler/glsl/sha

Re: [Mesa-dev] [RFC PATCH 05/26] glsl: add new glsl_type helpers for bindless sampler/image types

2017-04-11 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Apr 11, 2017 at 12:48 PM, Samuel Pitoiset wrote: > Similar to existing helpers for sampler/image types. > > Signed-off-by: Samuel Pitoiset > --- > src/compiler/glsl_types.cpp | 31 +++ > src/compiler/g

Re: [Mesa-dev] [RFC PATCH 04/26] glsl: declare new bindless sampler/image types

2017-04-11 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Apr 11, 2017 at 12:48 PM, Samuel Pitoiset wrote: > The new bindless sampler/image types are similar to the existing > ones, except the base type. > > The new types are not added to the list of symbols, which means > it's invalid to de

Re: [Mesa-dev] [RFC PATCH 03/26] glsl: introduce new base types for bindless samplers/images

2017-04-11 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Apr 11, 2017 at 12:48 PM, Samuel Pitoiset wrote: > Bindless sampler/image types are really different from the existing > sampler/image types. They are considered 64-bit unsigned integers, > they can be declared as temporary, shader inputs/outputs and

Re: [Mesa-dev] [RFC PATCH 02/26] glsl: add ARB_bindless_texture enable

2017-04-11 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Apr 11, 2017 at 12:48 PM, Samuel Pitoiset wrote: > This also adds the extension to the standalone GLSL compiler. > > Signed-off-by: Samuel Pitoiset > --- > src/compiler/glsl/glsl_parser_extras.cpp | 1 + > src/compiler/glsl/glsl_parser_

Re: [Mesa-dev] [RFC PATCH 01/26] mesa: add ARB_bindless_texture to the extensions list

2017-04-11 Thread Ilia Mirkin
On Tue, Apr 11, 2017 at 12:48 PM, Samuel Pitoiset wrote: > This is required for the following GLSL bits. > > Signed-off-by: Samuel Pitoiset > --- > src/mesa/main/extensions_table.h | 1 + > src/mesa/main/mtypes.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/mesa/main/

Re: [Mesa-dev] [PATCH] swr: return true for PIPE_CAP_DOUBLES

2017-04-11 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Apr 11, 2017 at 12:53 PM, Tim Rowley wrote: > --- > src/gallium/drivers/swr/swr_screen.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/swr/swr_screen.cpp > b/src/gallium/drivers/swr/swr_screen.cpp > i

Re: [Mesa-dev] [PATCH] nv50/ir: Change chipset constants to ISA constants.

2017-04-10 Thread Ilia Mirkin
I wanted to flip things over and use smxx notation... On Apr 10, 2017 6:20 PM, "Samuel Pitoiset" wrote: > Not sure why you get confused here. The chipset names are globally > consistent inside the codegen part and we never use SMxx. Maybe add a > comment like: > > #define NVISA_GK104_CHIPSET

Re: [Mesa-dev] [PATCH] nvc0: increase texture buffer object alignment to 256 for pre-GM107

2017-04-10 Thread Ilia Mirkin
I assume Pascal is the same as Maxwell. Using tic, it gets 16... On Apr 10, 2017 5:32 AM, "Samuel Pitoiset" wrote: > How about Pascal? > > On 04/08/2017 09:10 PM, Ilia Mirkin wrote: > >> We currently don't pass the low byte of the address via the surface >>

Re: [Mesa-dev] [PATCH v2 9/9] nvc0: Enable ARB_shader_ballot on Kepler+

2017-04-09 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > readInvocationARB() and readFirstInvocationARB() need SHFL.IDX > instruction which is introduced in Kepler. > --- > docs/features.txt | 2 +- > docs/relno

Re: [Mesa-dev] [PATCH v2 8/9] nvc0/ir: Implement TGSI_OPCODE_BALLOT and TGSI_OPCODE_READ_*

2017-04-09 Thread Ilia Mirkin
On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > --- > .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 28 > ++ > 1 file changed, 28 insertions(+) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp > b/src/gallium/drivers/nouveau/codegen/nv50_

Re: [Mesa-dev] [PATCH v2 7/9] nvc0/ir: Implement TGSI_SEMANTIC_SUBGROUP_*

2017-04-09 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > --- > .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 27 > ++ > 1 file changed, 27 insertions(+) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cp

Re: [Mesa-dev] [PATCH v2 5/9] nvc0/ir: Allow 0/1 immediate value as source of OP_VOTE

2017-04-09 Thread Ilia Mirkin
On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > Implementation of readFirstInvocationARB() on nvidia hardware needs a > ballotARB(true) used to decide the first active thread. This expressed > in gm107 asm as (supposing output is $r0): > vote any $r0 0x1 0x1 > > To model the always tru

Re: [Mesa-dev] [PATCH v2 6/9] nvc0/ir: Add SV_LANEMASK_* system values.

2017-04-09 Thread Ilia Mirkin
Please add these to nv50_ir_print.cpp's list of names too. On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 5 + > src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 5 + > src/gallium/drivers/nouveau/codegen

Re: [Mesa-dev] [PATCH v2 3/9] nvc0/ir: Emit OP_SHFL

2017-04-09 Thread Ilia Mirkin
On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > v2: (Samuel Pitoiset) > Add an assertion to check if the target is Kepler > Make sure that asImm() is not NULL > --- > .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 59 > ++ > 1 file changed, 59 insertions(+) > > diff

Re: [Mesa-dev] [PATCH v2 2/9] nvc0/ir: Properly handle a "split form" of predicate destination

2017-04-09 Thread Ilia Mirkin
Wow, great find! On Sun, Apr 9, 2017 at 8:58 PM, Boyan Ding wrote: > GF100's ISA encoding has a weird form of predicate destination where its > 3 bits are split across whole the instruction. Use a dedicated setPDSTL > function instead of original defId which is incorrect in this case. > --- > sr

Re: [Mesa-dev] [PATCH v2 2/3] nv50/ir: handle logops with NOT in AlgebraicOpt

2017-04-09 Thread Ilia Mirkin
On Mon, Apr 3, 2017 at 11:58 AM, Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp > b/src/gallium/drivers/nou

Re: [Mesa-dev] [PATCH v2 1/3] nv50/ir: fix AlgebraicOpt for slcts with mods

2017-04-09 Thread Ilia Mirkin
On Mon, Apr 3, 2017 at 11:58 AM, Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp > b/src/gal

[Mesa-dev] [PATCH] nouveau: when mapping a persistent buffer, synchronize on former xfers

2017-04-08 Thread Ilia Mirkin
If the buffer is being used, we should wait for those uses to be complete before returning the map. Fixes: GL45-CTS.direct_state_access.buffers_functional Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/nouveau/nouveau_buffer.c | 6 ++ 1 file changed

[Mesa-dev] [PATCH] nvc0: increase texture buffer object alignment to 256 for pre-GM107

2017-04-08 Thread Ilia Mirkin
Fixes GL45-CTS.texture_buffer.texture_buffer_texture_buffer_range Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c ind

Re: [Mesa-dev] [PATCH 9/9] nvc0: Enable ARB_shader_ballot on Kepler+

2017-04-08 Thread Ilia Mirkin
Meh, caution to the wind. It'll be easy to fix when/if someone complains. On Sat, Apr 8, 2017 at 8:59 AM, Samuel Pitoiset wrote: > I would just suggest to only enable the feature on GK110 for now. Except if > someone else can test on GK104 and GM107+. > > > On 04/08/2017 11:51 AM, Boyan Ding wrot

Re: [Mesa-dev] [PATCH 1/2] mesa: move glMultiDrawArray to vbo and fix error handling

2017-04-07 Thread Ilia Mirkin
On Fri, Apr 7, 2017 at 12:30 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > When any count[i] is negative, we must skip all draws. > > Moving to vbo makes the subsequent change easier. > --- > src/mapi/glapi/gen/gl_API.xml | 2 +- > src/mesa/main/api_validate.c | 38 +

Re: [Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

2017-04-07 Thread Ilia Mirkin
On Fri, Apr 7, 2017 at 9:43 AM, Yu, Qiang wrote: > >>> +dnl Directory for GBM >>> + >>> +AC_ARG_WITH([gbm-configdir], >>> +[AS_HELP_STRING([--with-gbm-configdir=DIR], >>> +[directory for the GBM configs @<:@/etc/gbm.conf.d@:>@])], >>> +[GBM_CONFIG_DIR="$withval"], >>> +[GBM_CON

Re: [Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

2017-04-07 Thread Ilia Mirkin
On Fri, Apr 7, 2017 at 3:28 AM, Qiang Yu wrote: > V2: > 1. export gbmint.h and test backend/libgbm ABI compatible > 2. drop GBM_BACKEND_DIR, specify backend path in config file > 3. add GBM_CONFIG_DIR for config file > 4. add per backend priority > 5. take care of thread safe > > Third-p

Re: [Mesa-dev] [PATCH v3] glsl/blob: avoid NULL ptr in blob_write_string/blob_read_string

2017-04-05 Thread Ilia Mirkin
On Wed, Apr 5, 2017 at 1:12 PM, Gregory Hainaut wrote: > Context: > Nouveau uses NULL strings for unnamed parameter of texture gather > offsets opcode. To be clear, this isn't a "nouveau" thing, as it is well downstream of all this GLSL stuff. And FWIW llvmpipe/softpipe also support the 4-offset

Re: [Mesa-dev] [PATCH v3] tgsi: add BALLOT/READ_* opcodes

2017-04-04 Thread Ilia Mirkin
On Tue, Apr 4, 2017 at 10:41 AM, Nicolai Hähnle wrote: > From: Ilia Mirkin > > v2 (Nicolai): > - BALLOT isn't per-channel > - expand the documentation (also for VOTE_*) > > v3: > - only BALLOT returns a 64-bit lanemask (Boyan) > - relax the requirement on READ

Re: [Mesa-dev] [PATCH 07/19] tgsi: add BALLOT/READ_* opcodes

2017-04-03 Thread Ilia Mirkin
On Mon, Apr 3, 2017 at 10:01 PM, Boyan Ding wrote: > 2017-04-01 1:14 GMT+08:00 Nicolai Hähnle : >> From: Ilia Mirkin >> >> v2 (Nicolai): >> - BALLOT isn't per-channel >> - expand the documentation (also for VOTE_*) >> >> Signed-off

Re: [Mesa-dev] [PATCH] intel/vec4: Add some fall through comments

2017-04-03 Thread Ilia Mirkin
On Mon, Apr 3, 2017 at 7:24 PM, Jason Ekstrand wrote: > --- > src/intel/compiler/brw_vec4_nir.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/intel/compiler/brw_vec4_nir.cpp > b/src/intel/compiler/brw_vec4_nir.cpp > index 2384265..613c695 100644 > --- a/src/intel/compiler/br

[Mesa-dev] [PATCH] gallium: fix some math formulas to display better

2017-04-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/tgsi.rst | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index 05b06ce..ca31924 100644 --- a/src/gallium/docs/source

Re: [Mesa-dev] [PATCH v2 6/6] nvc0: Add support for NV_fill_rectangle for the GM200+

2017-03-31 Thread Ilia Mirkin
I've pushed the amended series which fixed these trivial comments. Thanks for your contribution! On Thu, Mar 30, 2017 at 7:23 PM, Ilia Mirkin wrote: > On Thu, Mar 30, 2017 at 5:40 PM, Lyude wrote: >> This enables support for the GL_NV_fill_rectangle extension on the >> GM200

Re: [Mesa-dev] Fwd: [PATCH 1/1] glsl/blob: handle copy of NULL ptr in blob_write_string

2017-03-31 Thread Ilia Mirkin
On Fri, Mar 31, 2017 at 6:12 AM, Gregory Hainaut wrote: >> Others have reported this crashing on Nouveau. I haven't seen the problem on >> radeonsi or i965. > > Hello Timothy (sorry for the double mail, email is a complex tool:) ) > > Hum, tbh. I was quite surprised to hit this bug. I guess you s

Re: [Mesa-dev] [PATCH 2/3] nvc0/ir: Handle TGSI_OPCODE_CLOCK

2017-03-30 Thread Ilia Mirkin
On Thu, Mar 30, 2017 at 10:33 PM, Boyan Ding wrote: > Signed-off-by: Boyan Ding > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp > b/src/gallium/drivers/nouve

Re: [Mesa-dev] [PATCH 1/3] gm107/ir: Emit SV_CLOCK system value

2017-03-30 Thread Ilia Mirkin
Did you check what the blob does? There's clocklo/hi and globaltimerlo/hi. Without additional documentation, it's a bit hard to tell the difference... Note that envydis's gf100.c/gk110.c disagree on which is which. Probably not due to any architectural reasons, but due to RE methodology. (From befo

Re: [Mesa-dev] [PATCH v2 6/6] nvc0: Add support for NV_fill_rectangle for the GM200+

2017-03-30 Thread Ilia Mirkin
On Thu, Mar 30, 2017 at 5:40 PM, Lyude wrote: > This enables support for the GL_NV_fill_rectangle extension on the > GM200+ for Desktop OpenGL. > > Signed-off-by: Lyude > > Changes since v1: > - Fix commit message > - Add note to reldocs > > Signed-off-by: Lyude > --- > docs/relnotes/17.1.0.htm

Re: [Mesa-dev] [PATCH v2 2/6] mesa: Add support for GL_NV_fill_rectangle

2017-03-30 Thread Ilia Mirkin
On Thu, Mar 30, 2017 at 5:40 PM, Lyude wrote: > + /* From the GL_NV_fill_rectangle spec: > +* > +* "An INVALID_OPERATION error is generated by Begin or any Draw command > if > +* only one of the front and back polygon mode is FILL_RECTANGLE_NV." > +*/ > + if ((ctx->Polygon.Fr

Re: [Mesa-dev] [PATCH] i965: expose BRW_OPCODE_[F32TO16/F16TO32] opcode_descs on gen8+

2017-03-29 Thread Ilia Mirkin
I guess you want GEN_GE(GEN7), no? On Mar 29, 2017 7:48 AM, "Alejandro Piñeiro" wrote: > Technically those hw operations are only available on gen7, as gen8+ > support the conversion on the MOV. But, when using the builder to > implement nir operations (example: nir_op_fquantize2f16), it is not

Re: [Mesa-dev] [RFC 3/3] mesa: expose KHR_no_error for GL

2017-03-27 Thread Ilia Mirkin
On Tue, Mar 28, 2017 at 1:12 AM, Ilia Mirkin wrote: > On Tue, Mar 28, 2017 at 1:10 AM, Timothy Arceri wrote: >> On 28/03/17 15:39, Ilia Mirkin wrote: >>> >>> Why can't we just have this on ES as-is? It should support context >>> flags just fine... tha

Re: [Mesa-dev] [RFC 3/3] mesa: expose KHR_no_error for GL

2017-03-27 Thread Ilia Mirkin
On Tue, Mar 28, 2017 at 1:10 AM, Timothy Arceri wrote: > On 28/03/17 15:39, Ilia Mirkin wrote: >> >> Why can't we just have this on ES as-is? It should support context >> flags just fine... that's how e.g. robustness is done there, no? (Note >> that ES makes n

Re: [Mesa-dev] [RFC 3/3] mesa: expose KHR_no_error for GL

2017-03-27 Thread Ilia Mirkin
Why can't we just have this on ES as-is? It should support context flags just fine... that's how e.g. robustness is done there, no? (Note that ES makes no requirement for EGL - an ES context can be created with GLX as well, in case it matters.) On Tue, Mar 28, 2017 at 12:35 AM, Timothy Arceri wro

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

2017-03-24 Thread Ilia Mirkin
Antía Puentes wrote: > Reviewed-by: Antia Puentes > > > On jue, 2017-01-26 at 00:47 -0500, Ilia Mirkin wrote: >> When a texture is immutable, we can't tack on extra levels >> after-the-fact like we could with glTexImage. So check against that >> level limit and

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

2017-03-24 Thread Ilia Mirkin
Does the nouveau winsys create function also need to be added? I'm not sure I understand what problem this is solving... But afaik it's possible to use va + nouveau. On Mar 23, 2017 8:00 PM, "Marek Olšák" wrote: From: Marek Olšák This should fix this radeonsi error: "mesa: for the -simplifyc

Re: [Mesa-dev] [PATCH 0/4] Code style fixes

2017-03-23 Thread Ilia Mirkin
Series is: Reviewed-by: Ilia Mirkin On Wed, Mar 22, 2017 at 8:51 PM, Lyude wrote: > While working on adding NV_fill_polygon support for mesa, I noticed a good > number of parts of mesa that had somewhat broken indenting, trailing > whitespace, etc. So I decided to fix up anything clo

Re: [Mesa-dev] [PATCH 0/6] Add support for GL_NV_fill_rectangle

2017-03-23 Thread Ilia Mirkin
On Thu, Mar 23, 2017 at 3:33 PM, Marek Olšák wrote: > On Thu, Mar 23, 2017 at 7:45 PM, Lyude Paul wrote: >> On Thu, 2017-03-23 at 14:22 -0400, Alex Deucher wrote: >>> On Thu, Mar 23, 2017 at 2:18 PM, Marek Olšák >>> wrote: >>> > Is there any user of this extension? >>> >>> Based on the spec, it

Re: [Mesa-dev] [PATCH 0/6] Add support for GL_NV_fill_rectangle

2017-03-23 Thread Ilia Mirkin
On Thu, Mar 23, 2017 at 2:45 PM, Lyude Paul wrote: > On Thu, 2017-03-23 at 14:22 -0400, Alex Deucher wrote: >> On Thu, Mar 23, 2017 at 2:18 PM, Marek Olšák >> wrote: >> > Is there any user of this extension? >> >> Based on the spec, it seems like it would be useful for glamor. No >> idea is anyo

Re: [Mesa-dev] [PATCH] radeonsi: fix dvec[34] attributes sourced from current attribute state

2017-03-23 Thread Ilia Mirkin
attributes and buffers :) On Thu, Mar 23, 2017 at 1:29 PM, Nicolai Hähnle wrote: > On 23.03.2017 18:19, Ilia Mirkin wrote: >> >> Wait, you can have constant attribs that are dvec4's? Those don't get >> split up into multiple constant attribs (2x dvec2, as it would

Re: [Mesa-dev] [PATCH] radeonsi: fix dvec[34] attributes sourced from current attribute state

2017-03-23 Thread Ilia Mirkin
Wait, you can have constant attribs that are dvec4's? Those don't get split up into multiple constant attribs (2x dvec2, as it would for a regular VBO)? Or am I misunderstanding the circumstances? On Thu, Mar 23, 2017 at 1:14 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The state tracker

Re: [Mesa-dev] [PATCH 6/6] nvc0: Add support for NV_fill_rectangle for the GM200+

2017-03-23 Thread Ilia Mirkin
On Thu, Mar 23, 2017 at 11:27 AM, Lyude wrote: > This enables support for the GL_NV_fill_rectangle extension on the > GM200+ for OpenGL 4.3. For desktop GL. Also please add a note in docs/17.1.0/relnotes.html. > > Signed-off-by: Lyude > --- > src/gallium/drivers/nouveau/nvc0/nvc0_3d.xml.h |

Re: [Mesa-dev] [PATCH 4/6] gallium/auxiliary: Add NV_fill_rectangle to pipe state

2017-03-23 Thread Ilia Mirkin
On Thu, Mar 23, 2017 at 11:27 AM, Lyude wrote: > Signed-off-by: Lyude > --- > src/gallium/include/pipe/p_defines.h | 1 + > src/gallium/include/pipe/p_state.h | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/include/pipe/p_defines.h > b/src/gallium/inc

Re: [Mesa-dev] [PATCH 3/6] mesa: Add support for GL_NV_fill_rectangle

2017-03-23 Thread Ilia Mirkin
On Thu, Mar 23, 2017 at 11:27 AM, Lyude wrote: > Since we don't have the bits required to support this in OpenGLES yet, > this only enables support for OpenGL 4.3. I think the reference to GL 4.3 isn't quite right. Probably meant to say "Desktop OpenGL". Also, one usually writes it as "OpenGL ES"

Re: [Mesa-dev] [PATCH 2/6] gallium: Add a cap to check if the driver supports fill_rectangle

2017-03-23 Thread Ilia Mirkin
This misses etnaviv, freedreno, swr, and virgl. On Thu, Mar 23, 2017 at 11:27 AM, Lyude wrote: > Signed-off-by: Lyude > --- > src/gallium/docs/source/screen.rst | 4 > src/gallium/drivers/i915/i915_screen.c | 1 + > src/gallium/drivers/llvmpipe/lp_screen.c | 1 + >

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-21 Thread Ilia Mirkin
On Tue, Mar 21, 2017 at 11:13 AM, Grazvydas Ignotas wrote: > everyone building graphics stacks or contributing to > mesa should already be comfortable with cmake thanks to piglit and > llvm, which might not be the case for meson. Or they could be contributing to mesa because it's the last project

Re: [Mesa-dev] [PATCH] nvc0/target: treat FMA like MAD

2017-03-18 Thread Ilia Mirkin
Oops :) This probably triggers a lot since they use fma() all over the place. Internally these map to the same opcode, only the optimizer treats them differently. Thanks! Reviewed-by: Ilia Mirkin On Sat, Mar 18, 2017 at 8:08 PM, Karol Herbst wrote: > helps mainly feral ported games > &g

Re: [Mesa-dev] [PATCH 1/4] i965: Fall back to GL 4.2 on Haswell if the kernel isn't new enough.

2017-03-16 Thread Ilia Mirkin
On Thu, Mar 16, 2017 at 6:12 PM, Kenneth Graunke wrote: > In commit d2590eb65ff28a9cbd592353d15d7e6cbd2c6fc6 I enabled GL 4.5 > on Haswell...but failed to check if we could do indirect compute > shader dispatch...and query buffer objects. > > Indirect compute shader dispatch requires command parse

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-16 Thread Ilia Mirkin
On Thu, Mar 16, 2017 at 5:25 PM, Dylan Baker wrote: > Why bother, and why would we want this? >│~ > > First it's written in python, which means the potential developer base > is massive. And it provides a recursive view for humans, but

Re: [Mesa-dev] Mesa 17.0.1 release candidate

2017-03-15 Thread Ilia Mirkin
On Wed, Mar 15, 2017 at 11:05 PM, Matt Turner wrote: > On Mon, Mar 13, 2017 at 11:16 AM, Ilia Mirkin wrote: >> On Mon, Mar 13, 2017 at 2:13 PM, Matt Turner wrote: >>> I think Bcc'ing also means my gmail filters wouldn't know it came from >>>

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: set result writemask based on ir type

2017-03-14 Thread Ilia Mirkin
e ? > > Thanks > Emil > > On 10 March 2017 at 11:07, Marek Olšák wrote: > > Reviewed-by: Marek Olšák > > > > Marek > > > > On Sat, Mar 4, 2017 at 7:52 PM, Ilia Mirkin > wrote: > >> This prevents textureQueryLevels, which maps as LODQ, from end

Re: [Mesa-dev] Mesa 17.0.1 release candidate

2017-03-13 Thread Ilia Mirkin
On Mon, Mar 13, 2017 at 2:13 PM, Matt Turner wrote: > I think Bcc'ing also means my gmail filters wouldn't know it came from > the announce list. listid:mesa-announce.freedesktop.org should pick it up - even though it's bcc'd, the mailing list distribution logic should still throw in its List-Id

Re: [Mesa-dev] [PATCH kmscube v2 1/2] drm.h: Include libdrm headers

2017-03-13 Thread Ilia Mirkin
On Mon, Mar 13, 2017 at 10:14 AM, Fabio Estevam wrote: > Include and headers to avoid > the following build errors on sparc64: > > http://autobuild.buildroot.net/results/d7e/d7e82c67e0b04b0aea990bfb19dd6e4fd914bebe/build-end.log > > This also fixes the build error reported by Gary Bisson on ARM

Re: [Mesa-dev] [PATCH 1/2] drm.h: Include libdrm headers

2017-03-13 Thread Ilia Mirkin
On Mon, Mar 13, 2017 at 10:04 AM, Fabio Estevam wrote: > Hi Ilia, > > On Mon, Mar 13, 2017 at 11:03 AM, Ilia Mirkin wrote: >> Which repository do these patches apply to? Also the proper way of >> including drm headers is > > These patches apply against

Re: [Mesa-dev] [PATCH 1/2] drm.h: Include libdrm headers

2017-03-13 Thread Ilia Mirkin
Which repository do these patches apply to? Also the proper way of including drm headers is #include etc. pkg-config --cflags libdrm should show you "-I/usr/include/libdrm". On Mon, Mar 13, 2017 at 9:32 AM, Fabio Estevam wrote: > Include and headers to avoid > the following build errors on s

Re: [Mesa-dev] [PATCH] st/mesa: set result writemask based on ir type

2017-03-08 Thread Ilia Mirkin
Could I get a review for this? I'll do some testing on it, hopefully tonight, but I don't really anticipate issues. Seems like it should be obviously correct - we do the same thing in visit(ir_operation *). On Sat, Mar 4, 2017 at 2:05 PM, Ilia Mirkin wrote: > On Sat, Mar 4, 2017 at

Re: [Mesa-dev] [PATCH 0/5] Gallium support for TXF and TXL with level = 0

2017-03-07 Thread Ilia Mirkin
On Tue, Mar 7, 2017 at 10:28 AM, Roland Scheidegger wrote: > (Another question would then be, does this really warrant a cap bit (the > ever-increasing cap hell...), or should it just be mandatory.) This would be trivial to add in nv50_ir_from_tgsi.cpp, and not too hard for nvfx_fragprog.c, I thi

Re: [Mesa-dev] [PATCH 0/5] Gallium support for TXF and TXL with level = 0

2017-03-07 Thread Ilia Mirkin
On Tue, Mar 7, 2017 at 9:13 AM, Marek Olšák wrote: > On Tue, Mar 7, 2017 at 1:38 PM, Ilia Mirkin wrote: >> Why can't the compiler perform this opt? At least we do that in nouveau... > > Our LLVM sample intrinsics don't preserve the texture target > information. It

Re: [Mesa-dev] [PATCH] Enable EXT_shader_integer_mix prototypes on 440

2017-03-07 Thread Ilia Mirkin
On Tue, Mar 7, 2017 at 7:58 AM, Eduardo Lima Mitev wrote: > On 03/07/2017 01:34 PM, Ilia Mirkin wrote: >> Nak. That's not what that means... >> > > Ok, I see, it is only core in 450, and for 440 it requires the > extension. Sorry for the confusion. More preci

Re: [Mesa-dev] [PATCH 0/5] Gallium support for TXF and TXL with level = 0

2017-03-07 Thread Ilia Mirkin
Why can't the compiler perform this opt? At least we do that in nouveau... On Mar 7, 2017 7:33 AM, "Marek Olšák" wrote: > Hi, > > These new TGSI opcodes are for better code generation in drivers. If you > know the mipmap level or LOD is 0, you don't have to pass 0 to texture > instructions on ha

Re: [Mesa-dev] [PATCH] Enable EXT_shader_integer_mix prototypes on 440

2017-03-07 Thread Ilia Mirkin
Nak. That's not what that means... On Mar 7, 2017 6:17 AM, "Eduardo Lima Mitev" wrote: This extension is written against the OpenGL 4.4 (core) specification and the GLSL 4.40 specification. Right now it is enable only on 450. --- src/compiler/glsl/builtin_functions.cpp | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] dir-locals.el: use appropriate c-file-style

2017-03-06 Thread Ilia Mirkin
What's the difference between c-file-style linux and stroustrup? On Mon, Mar 6, 2017 at 1:43 PM, Damien Grassart wrote: > Add .dir-locals.el and .editorconfig files in src/amd/vulkan and > src/amd/common since they don't use the coding style defined in the > root .dir-locals.el. Also update the s

[Mesa-dev] [PATCH v2] nv50: don't assume a rast is set when validating for clears

2017-03-05 Thread Ilia Mirkin
Clears can happen before a rast is set, which can in turn cause scissors and fragprog to be validated. Make sure that we handle this case. Reported-by: Andrew Randrianasulu Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_shader_state.c | 3 +++ src/gallium/drivers

<    6   7   8   9   10   11   12   13   14   15   >