This might be python3-compatible, but it's not the same thing. str !=
unicode. Not sure where "names" can come from, but if it can come in
as a unicode string, this won't work.
On Tue, Sep 19, 2017 at 10:14 AM, Eric Engestrom
wrote:
> Signed-off-by: Eric Engestrom
> ---
> scons/custom.py | 2 +-
Signed-off-by: Ilia Mirkin
---
Note that the use of ICMS_INNER_CONSERVATIVE disagrees with the GL driver.
Perhaps it's more performant than ICMS_NORMAL and is otherwise permitted?
Not sure, so I left it as-is.
Also note that there are no tests for this, and I have not verified anything
be
Allow the capability to be exposed, and convert the new execution mode
into fs state.
Signed-off-by: Ilia Mirkin
---
src/compiler/spirv/nir_spirv.h| 1 +
src/compiler/spirv/spirv_to_nir.c | 9 +
2 files changed, 10 insertions(+)
diff --git a/src/compiler/spirv/nir_spirv.h b/src
On Mon, Sep 11, 2017 at 10:57 AM, Nicolai Hähnle wrote:
> On 11.09.2017 16:47, Ilia Mirkin wrote:
>>
>> On Mon, Sep 11, 2017 at 10:44 AM, Nicolai Hähnle
>> wrote:
>>>
>>> From: Nicolai Hähnle
>>>
>>> It breaks integer inputs and outp
On Mon, Sep 11, 2017 at 10:44 AM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> It breaks integer inputs and outputs on vertex processing stages
> (e.g. geometry stages). Instead, rely on the driver to choose
> smooth interpolation by default.
> ---
>
> How about this instead? I haven't fully
h" interpolation. I'm not sure
what the assert is guarding against, but the pass does handle everything
properly. Remove the assert.
Signed-off-by: Ilia Mirkin
---
src/compiler/glsl/lower_packed_varyings.cpp | 8
1 file changed, 8 deletions(-)
diff --git a/src/compiler/glsl/lower_
On Mon, Sep 11, 2017 at 1:59 AM, Timothy Arceri wrote:
> On 11/09/17 14:07, Ilia Mirkin wrote:
>>
>> On Sun, Sep 10, 2017 at 8:03 PM, Timothy Arceri
>> wrote:
>>>
>>> At the risk of sounding like a broken record. Why not just
>>> updat
On Mon, Sep 11, 2017 at 12:07 AM, Ilia Mirkin wrote:
> On Sun, Sep 10, 2017 at 8:03 PM, Timothy Arceri wrote:
>> At the risk of sounding like a broken record. Why not just update/re-factor
>> cross_validate_outputs_to_inputs()?
>>
>> If there is a good reason not to ha
On Sun, Sep 10, 2017 at 8:03 PM, Timothy Arceri wrote:
> At the risk of sounding like a broken record. Why not just update/re-factor
> cross_validate_outputs_to_inputs()?
>
> If there is a good reason not to have these checks in a single location
> that's fine but you haven't answered the question
with_mixed_types
KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_interpolation
KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_auxiliary_storage
See https://github.com/KhronosGroup/OpenGL-API/issues/13 for some more
info, where I asked about patch vs non-patch locations.
On Wed, Sep 6, 2017 at 12:29 PM, Emil Velikov wrote:
> On 6 September 2017 at 17:17, Ilia Mirkin wrote:
>> One might ask the question of why st/mesa is being built at all
>> without HAVE_GALLIUM...
>>
> The following snippet might answer your question (that or I'm h
One might ask the question of why st/mesa is being built at all
without HAVE_GALLIUM...
On Wed, Sep 6, 2017 at 12:11 PM, Emil Velikov wrote:
> Hi Gert,
>
> This seems to have broken the "classic only" build - see
> https://travis-ci.org/evelikov/Mesa/jobs/272529714.
> In there the following is ex
On Wed, Sep 6, 2017 at 12:13 AM, Timothy Arceri wrote:
>
>
> On 06/09/17 11:59, Ilia Mirkin wrote:
>>
>> On Tue, Sep 5, 2017 at 9:54 PM, Timothy Arceri
>> wrote:
>>>
>>>
>>> On 06/09/17 11:23, Ilia Mirkin wrote:
>>>>
>>&g
On Tue, Sep 5, 2017 at 9:54 PM, Timothy Arceri wrote:
>
> On 06/09/17 11:23, Ilia Mirkin wrote:
>>
>> The enhanced layouts spec has all kinds of restrictions about what can
>> and cannot be mixed in a location. Integer/float(/presumably double)
>> can't occupy a
_types
KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_interpolation
KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_auxiliary_storage
See https://github.com/KhronosGroup/OpenGL-API/issues/13 for some more
info, where I asked about patch vs non-patch locations.
Signed-off-by: Ilia Mirkin
---
src/compiler/glsl/link_varyings.cpp | 2
On Thu, Aug 31, 2017 at 1:45 PM, Bas Nieuwenhuizen
wrote:
>
>
> On Wed, Aug 30, 2017, at 14:59, Ilia Mirkin wrote:
>> On Wed, Aug 30, 2017 at 3:17 AM, Bas Nieuwenhuizen
>> wrote:
>> > So as a random drive-by review, I think the risk in this implementation
>>
On Wed, Aug 30, 2017 at 3:17 AM, Bas Nieuwenhuizen
wrote:
> So as a random drive-by review, I think the risk in this implementation
> is that apps just set maxdrawcount to some high value . If I'm reading
> the spec correctly there is no real bound on the value except for the
> max-representable v
On Mon, Aug 28, 2017 at 4:23 AM, Nicolai Hähnle wrote:
> On 27.08.2017 12:59, Karol Herbst wrote:
>>
>> this way Nouveau can report 128 inputs, but only 124 varyings.
>>
>> Fixes: 'KHR-GL45.limits.max_fragment_input_components'
>
>
> Can you explain a bit more why this is necessary? The GL CTS tes
Reviewed-by: Ilia Mirkin
On Sun, Aug 27, 2017 at 12:00 PM, Karol Herbst wrote:
> cs_invocations are currently unsupported, but leaving the field uninitialized
> is even worse.
>
> fixes on nvc0:
> * KHR-GL45.pipeline_statistics_query_tests_ARB.functional_default_qo_values
&
The is_double_vertex_input needs to be set for arrays of doubles as
well.
Fixes KHR-GL45.enhanced_layouts.varying_array_locations
Signed-off-by: Ilia Mirkin
Cc: mesa-sta...@lists.freedesktop.org
---
v1 -> v2: reflow code, per mattst88
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 +++-
The is_double_vertex_input needs to be set for arrays of doubles as
well.
Fixes KHR-GL45.enhanced_layouts.varying_array_locations
Signed-off-by: Ilia Mirkin
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion
The argument to count_attribute_slots should only be set to true for
vertex inputs, not for all vertex shader varyings.
Fixes KHR-GL45.enhanced_layouts.varying_locations
Signed-off-by: Ilia Mirkin
Cc: mesa-sta...@lists.freedesktop.org
---
src/compiler/glsl/link_varyings.cpp | 3 ++-
1 file
On Sat, Aug 26, 2017 at 3:49 AM, Karol Herbst wrote:
> On Sat, Aug 26, 2017 at 3:36 AM, Ilia Mirkin wrote:
>> On Fri, Aug 25, 2017 at 8:23 PM, Karol Herbst wrote:
>>> On Sat, Aug 26, 2017 at 1:38 AM, Ilia Mirkin wrote:
>>>> On Fri, Aug 25, 2017 at 7:37 PM, Karol
On Fri, Aug 25, 2017 at 8:23 PM, Karol Herbst wrote:
> On Sat, Aug 26, 2017 at 1:38 AM, Ilia Mirkin wrote:
>> On Fri, Aug 25, 2017 at 7:37 PM, Karol Herbst wrote:
>>> On Sat, Aug 26, 2017 at 1:30 AM, Ilia Mirkin wrote:
>>>> Why is this necessary? If data is no
On Fri, Aug 25, 2017 at 7:37 PM, Karol Herbst wrote:
> On Sat, Aug 26, 2017 at 1:30 AM, Ilia Mirkin wrote:
>> Why is this necessary? If data is not initialized, then presumably
>> pipe->get_query_result will have returned false.
>>
>
> but it didn't. It mig
Why is this necessary? If data is not initialized, then presumably
pipe->get_query_result will have returned false.
On Fri, Aug 25, 2017 at 7:15 PM, Karol Herbst wrote:
> otherwise the result might contain random data.
>
> fixes on nvc0:
> * KHR-GL45.pipeline_statistics_query_tests_ARB.functiona
The rest should be possible too, just needs some additional
investigation. Passes fbo-*-formats piglit tests.
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a2xx/fd2_gmem.c | 5 +
src/gallium/drivers/freedreno/a2xx/fd2_screen.c | 7 ++-
2 files changed, 11 insertions
My personal inclination would have been the inverse (i.e. alias
glPolygonOffsetClampEXT to glPolygonOffsetClamp), but ... you've been
through enough silly revisions, and I don't sufficiently care.
Reviewed-by: Ilia Mirkin
On Thu, Aug 24, 2017 at 5:00 PM, Adam Jackson wrote:
>
On Thu, Aug 24, 2017 at 2:40 PM, Adam Jackson wrote:
> Semantically identical to the EXT version (whose string is still valid
> for GLES), so rename the bit but expose both extension strings.
> (Suggested by Ilia Mirkin and Ian Romanick.)
>
> Signed-off-by: Adam Jackson
On Thu, Aug 24, 2017 at 9:54 AM, Alejandro Piñeiro wrote:
> From: Eduardo Lima Mitev
>
> Adds new INT16, UINT16 and FLOAT16 base types.
>
> The corresponding GL types for half floats were reused from the
> AMD_gpu_shader_half_float extension. The int16 and uint16 types come from
> NV_gpu_shader_5
On Thu, Aug 24, 2017 at 9:57 AM, Samuel Pitoiset
wrote:
>
>
> On 08/24/2017 03:24 PM, Ilia Mirkin wrote:
>>
>> On Thu, Aug 24, 2017 at 9:21 AM, Samuel Pitoiset
>> wrote:
>>>
>>> Signed-off-by: Samuel Pitoiset
>>
On Thu, Aug 24, 2017 at 9:21 AM, Samuel Pitoiset
wrote:
> Signed-off-by: Samuel Pitoiset
> ---
> src/mesa/main/transformfeedback.c | 28 ++--
> 1 file changed, 18 insertions(+), 10 deletions(-)
>
> diff --git a/src/mesa/main/transformfeedback.c
> b/src/mesa/main/transfor
-GL45.robust_buffer_access_behavior.texel_fetch
Reported-by: Karol Herbst
Signed-off-by: Ilia Mirkin
Cc: mesa-sta...@lists.freedesktop.org
---
src/gallium/drivers/nouveau/codegen/nv50_ir.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp
You might consider also including whether the interpolation method was
forced or not. i.e. if you have
flat varying vec4 gl_Color;
then it doesn't matter whether shade model is flat or not, it'll be
interpolated as flat. (Same with the other qualifiers made available
in GL 3.0.)
So you only have
This is a functional change, e.g. what if
glDepthBoundsEXT(2, 1)
is called? Either way, I suspect it's fine, but just pointing it out
in case it wasn't considered.
On Wed, Aug 23, 2017 at 10:43 AM, Samuel Pitoiset
wrote:
> Signed-off-by: Samuel Pitoiset
> ---
> src/mesa/main/depth.c | 10
On Wed, Aug 23, 2017 at 10:48 AM, Nicolai Hähnle wrote:
> On 23.08.2017 16:36, Ilia Mirkin wrote:
>>
>> On Wed, Aug 23, 2017 at 10:30 AM, Nicolai Hähnle
>> wrote:
>>>
>>> On 23.08.2017 15:15, Nicolai Hähnle wrote:
>>>>
>>>>
>&g
On Wed, Aug 23, 2017 at 10:30 AM, Nicolai Hähnle wrote:
> On 23.08.2017 15:15, Nicolai Hähnle wrote:
>>
>> On 22.08.2017 19:32, Marek Olšák wrote:
>>>
>>> On Tue, Aug 22, 2017 at 7:28 PM, Ilia Mirkin
>>> wrote:
>>>>
>>>> H
On Wed, Aug 23, 2017 at 9:20 AM, Nicolai Hähnle wrote:
> On 22.08.2017 16:56, Ilia Mirkin wrote:
>>
>> On Tue, Aug 22, 2017 at 10:51 AM, Roland Scheidegger
>> wrote:
>>>
>>> I am probably missing something here, but why do you need a new register
>
On Tue, Aug 22, 2017 at 7:41 PM, Timothy Arceri wrote:
>
>
> On 23/08/17 09:28, Ilia Mirkin wrote:
>>
>> On Tue, Aug 22, 2017 at 7:25 PM, Timothy Arceri
>> wrote:
>>>
>>>
>>>
>>> On 23/08/17 09:08, Ilia Mirkin wrote:
>>>
On Tue, Aug 22, 2017 at 7:25 PM, Timothy Arceri wrote:
>
>
> On 23/08/17 09:08, Ilia Mirkin wrote:
>>
>> On Tue, Aug 22, 2017 at 6:55 PM, Timothy Arceri
>> wrote:
>>>
>>>
>>>
>>> On 23/08/17 00:56, Ilia Mirkin wrote:
>
On Tue, Aug 22, 2017 at 6:55 PM, Timothy Arceri wrote:
>
>
> On 23/08/17 00:56, Ilia Mirkin wrote:
>>
>> On Tue, Aug 22, 2017 at 10:51 AM, Roland Scheidegger
>> wrote:
>>>
>>> I am probably missing something here, but why do you need a new regist
On Tue, Aug 22, 2017 at 1:32 PM, Marek Olšák wrote:
> On Tue, Aug 22, 2017 at 7:28 PM, Ilia Mirkin wrote:
>> How do you propose defining the semantics for e.g. loading a 16-bit
>> value from a constbuf/ssbo? Would those get separate instructions?
>
> st/mesa should use U
How do you propose defining the semantics for e.g. loading a 16-bit
value from a constbuf/ssbo? Would those get separate instructions?
On Tue, Aug 22, 2017 at 1:10 PM, Marek Olšák wrote:
> Hi,
>
> I'd like to discuss 16-bit float and integer support in TGSI. I'm
> proposing this:
>
> struct tgsi
On Tue, Aug 22, 2017 at 10:51 AM, Roland Scheidegger wrote:
> I am probably missing something here, but why do you need a new register
> file? Since you couldn't use LOAD with TGSI_FILE_CONSTANT before, can't
> you just allow LOAD with TGSI_FILE_CONSTANT and achieve the same thing?
> Or do you nee
On Mon, Aug 21, 2017 at 5:54 PM, Andy Furniss wrote:
> Ilia Mirkin wrote:
>
>> As I don't have the hardware myself, I was hoping someone could
>> confirm that this is a nouveau issue and not a more general one.
>> Ideally this would be done by testing VDPAU on both
I3 and the DRI2 paths. Please use mplayer for
this, not mpv or mplayer2 or anything else -- all those have various
differences in how the rendering is done from mplayer, which could
account for a different final result.
Thanks,
Ilia Mirkin
imir...@alum.mit.edu
_
On Mon, Aug 21, 2017 at 12:52 AM, Harish Krupo
wrote:
> Hi Ilia,
>
> On 08/18/2017 07:20 PM, Ilia Mirkin wrote:
>>
>> Why the static data changes? Also, I haven't double checked the code, but
>> I'm almost certain this is incomplete. You have to add code disa
On Sun, Aug 20, 2017 at 3:42 AM, Christoph Haag
wrote:
> On 20.08.2017 02:07, Ilia Mirkin wrote:
>> Reviewed-by: Ilia Mirkin
>>
>> Will push this out tomorrow unless there are any objections.
>
> It would probably be also good for mesa stable, right?
>
Yep, I hav
On Sun, Aug 20, 2017 at 6:51 AM, Marek Olšák wrote:
> On Sun, Aug 20, 2017 at 4:29 AM, Roland Scheidegger
> wrote:
>> For 1-3/8, I don't think anything ever used these, and 5/8 (DPH) we
>> don't need neither, so
>> Reviewed-by: Roland Scheidegger
>>
>> 4,6,7, well we can live fine without them,
Reviewed-by: Ilia Mirkin
Will push this out tomorrow unless there are any objections.
On Sat, Aug 19, 2017 at 7:59 PM, Christoph Haag
wrote:
> From: Christoph Haag
>
> This is analogous to commit 2259b11 which missed the compressed case
>
> Bugzilla: https://bugs.freedesktop.o
On Sat, Aug 19, 2017 at 11:37 AM, Andres Gomez wrote:
> nouveau's nv50 has gotten a fix for a problem involving ConstantFolding
> with saturation that was visible in Hitman Absolution and, possibly, in
> some other games. Also, it has gotten fixes for the srcMask
> computation, for TG4, TXF and TX
Why the static data changes? Also, I haven't double checked the code, but
I'm almost certain this is incomplete. You have to add code disallowing the
other enums from being used on es2.
On Aug 18, 2017 6:42 AM, "Harish Krupo" wrote:
> It passes dEQP-GLES2.capability.extensions.other.GL_EXT_
> oc
So ... how do you handle the case of a query that hasn't completed yet
and one of the no-wait enums is passed in?
On Thu, Aug 17, 2017 at 4:43 PM, Tobias Klausmann
wrote:
> Wether we wait on an inverted rendering condition or not, we should not render
> on a passed query.
>
> This fixes the CTS t
Fixes KHR-GL45.shader_ballot_tests.ShaderBallotAvailability, which
causes some silly swizzles to appear, triggering this optimization to
get hit.
Signed-off-by: Ilia Mirkin
Cc: mesa-sta...@lists.freedesktop.org
---
src/compiler/glsl/ir_constant_expression.cpp | 2 ++
src/compiler/glsl
This affects which inputs are marked as used. In a situation where only
the texture instruction uses an input, it might have been ignored as
unused due to input masks.
Affects subtests of KHR-GL45.texture_cube_map_array.sampling
Signed-off-by: Ilia Mirkin
Cc: mesa-sta...@lists.freedesktop.org
[adding Julien, who did the nouveau va-api integration.]
On Tue, Aug 15, 2017 at 9:59 AM, Philipp Kerling wrote:
> Hi,
>
> I recently noticed that hardware video decoding with the nouveau driver
> and libva does not play nicely with Wayland and decided to dig a bit.
>
> To use libva in conjunctio
though the state has been marked as an error state).
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101766
Signed-off-by: Ilia Mirkin
---
src/compiler/glsl/ast_to_hir.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl
On Tue, Aug 15, 2017 at 11:27 AM, wrote:
> From: Roland Scheidegger
>
> The driver was supposed to support this since way before the GL spec for it
> existed, albeit it was apparently broken, so fix and enable it.
> ---
> docs/features.txt| 2 +-
> src/gallium/drivers/so
The rasterizer being empty can happen e.g. during clears
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_emit.c
b/src/gallium/drivers/freedreno/a2xx
This passes both gl-1.0-logicop and gl-1.1-xor piglits.
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a2xx/fd2_blend.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_blend.c
b/src/gallium/drivers/freedreno/a2xx
Don't you also need to add support for the ShaderViewportIndexLayerEXT
spir-v capability somewhere?
On Mon, Aug 14, 2017 at 8:02 PM, Bas Nieuwenhuizen
wrote:
> We were using it internally already.
> ---
> src/amd/vulkan/radv_device.c | 4
> src/amd/vulkan/radv_entrypoints_gen.py |
On Sat, Aug 12, 2017 at 3:33 PM, Tobias Klausmann
wrote:
> On using builtin functions we have to move the input to registers $0 and $1,
> if
> one of the input value is an immediate, we fail to propagate the immediate:
>
> ...
> mov u32 $r477 0x0003 (0)
> ...
> mov u32 $r0 %r473 (0)
> mov u32
antFolding with saturation")
Reported-by: Tobias Klausmann
Signed-off-by: Ilia Mirkin
---
v1 -> v2:
use the more complete getImmediate() when we don't know for sure that
the argument is an actual ImmediateValue, to pick up potential additional
cases.
src/gallium/drivers/nouveau/
On Wed, Aug 9, 2017 at 4:09 PM, Kenneth Graunke wrote:
> Also, silence an obnoxious finishme that started occurring for all
> GL applications which use stencil after the i965 ISL conversion.
Without commenting on the correctness of the patch, either this or
something like it should really end up
On Tue, Aug 8, 2017 at 12:50 PM, Rob Herring wrote:
> Commit e794f8bf8bdb ("gallium: move loading of drirc to pipe-loader")
> moved the option cache to the pipe_loader_device. However, the
> screen->dev pointer is not set when dri_init_options() is called. Move
> the call to after the pipe_loader_
IMHO this should be implemented differently. There is no change of
functionality vis-a-vis the EXT version, just a name change. So a
single enable flag should be preserved, and a single function
entrypoint. I'd rename it to the plain name, and make the EXT one an
alias of the non-suffixed one.
Che
On Tue, Aug 8, 2017 at 11:52 AM, Adam Jackson wrote:
> Taken from c21e602b9fda1d3bbaecb08194592f67e6a0649b from
> OpenGL-Registry.
>
> Signed-off-by: Adam Jackson
Acked-by: Ilia Mirkin
I glanced through the diff, and looks like you carefully preserved
mesa's modifications
freedreno_screen.c- return 16.0f;
src/gallium/drivers/virgl/virgl_screen.c: case
PIPE_CAPF_MAX_TEXTURE_ANISOTROPY:
src/gallium/drivers/virgl/virgl_screen.c- return 16.0;
Also add it to relnotes/17.3.0.html
Reviewed-by: Ilia Mirkin
__
On Tue, Aug 8, 2017 at 11:34 AM, Roland Scheidegger wrote:
> Am 08.08.2017 um 17:21 schrieb Ilia Mirkin:
>> On Tue, Aug 8, 2017 at 11:16 AM, Adam Jackson wrote:
>>> On Wed, 2017-06-28 at 16:50 +0300, Plamena Manolova wrote:
>>>> ARB_texture_filter_aniso
On Tue, Aug 8, 2017 at 11:16 AM, Adam Jackson wrote:
> On Wed, 2017-06-28 at 16:50 +0300, Plamena Manolova wrote:
>> ARB_texture_filter_anisotropic is the ARB variation of
>> EXT_texture_fitter_anisotropic and it operates in the
>> same way, so there's no reason not to advertise it.
>
> Nak. The A
On Mon, Aug 7, 2017 at 6:14 PM, Ian Romanick wrote:
> On 06/28/2017 06:50 AM, Plamena Manolova wrote:
>> ARB_polygon_offset_clamp is just the ARB variation
>> of EXT_polygon_offset_clamp and they operate in an
>> identical manner, so there's no reason for us not
>> to advertise it.
>>
>> Signed-of
On Mon, Aug 7, 2017 at 5:37 PM, Bas Nieuwenhuizen
wrote:
> Also adds an assert because you never know how the winsys changes, and
> multiprocess format differences are annoying.
>
> Fixes: 1e696b962b7 "radv: add separate fmask tile swizzle counter."
> ---
> src/amd/vulkan/radv_image.c | 5 -
>
On Mon, Aug 7, 2017 at 9:45 AM, Emil Velikov wrote:
> On 7 August 2017 at 12:56, Tapani Pälli wrote:
>> Hi;
>>
>> On 08/07/2017 02:15 PM, Yuan, Feng wrote:
>>>
>>> Hi,
>>>
>>>What’s the status of GLES 3.1 compute shaders support in Linux and
>>> Android.
>>
>>
>> It is supported.
>>
>>>
but not the builtins) always available. Seems reasonable
enough, although I might have gone with a new availability predicate
that did old one || 460.
Either way, this is
Reviewed-by: Ilia Mirkin
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
We already expose glMultiDrawElementsBaseVertexEXT as part of the
EXT_draw_elements_base_vertex chunk, so this one can just be removed.
Signed-off-by: Ilia Mirkin
---
src/mapi/glapi/gen/es_EXT.xml | 10 --
1 file changed, 10 deletions(-)
diff --git a/src/mapi/glapi/gen/es_EXT.xml b/src
There was a previous error in the gl.xml and generated files that
referenced glMultiDrawElementsBaseVertexOES. This function should not
exist, only the EXT-suffixed version should.
Leaving the other headers alone to avoid conflicts with GL 4.6 work.
Signed-off-by: Ilia Mirkin
---
include/GLES2
On Fri, Aug 4, 2017 at 10:49 AM, Samuel Pitoiset
wrote:
>
>
> On 08/04/2017 04:27 PM, Ilia Mirkin wrote:
>>
>>
>>
>> On Aug 4, 2017 02:02, "Samuel Pitoiset" > <mailto:samuel.pitoi...@gmail.com>> wrote:
>>
>>
>>
>>
On Aug 4, 2017 02:02, "Samuel Pitoiset" wrote:
On 08/03/2017 07:36 PM, Ilia Mirkin wrote:
> On Thu, Aug 3, 2017 at 5:24 AM, Samuel Pitoiset
> wrote:
>
>> Other ones are either unsupported or don't have any helper
>> function checks.
>>
>
On Thu, Aug 3, 2017 at 3:12 PM, Marek Olšák wrote:
> I'm OK with the patch. I think most drivers support nr_samples of 0
> and 1, which have the same behavior.
That's definitely true for nouveau, in fact we've gone to some lengths
to support nr_samples == 1...
>
> Reviewed-by: Marek Olšák
>
> M
On Thu, Aug 3, 2017 at 5:24 AM, Samuel Pitoiset
wrote:
> Other ones are either unsupported or don't have any helper
> function checks.
>
> v4: - drop ARB suffix for shader_group_vote/arb_shader_atomic_counter_ops
> v3: - always add gl_BaseVertex & co when 460 is enabled
> v2: - fix ARB_shader_draw
Can you go through all the others and work out the suffixes too? Just going
by memory, but the vote extension functions have suffixes, as do the atomic
counter ones, maybe there's other stuff too...
On Aug 2, 2017 2:15 PM, "Samuel Pitoiset" wrote:
> Other ones are either unsupported or don't hav
On Aug 2, 2017 6:56 AM, "Samuel Pitoiset" wrote:
Other ones are either unsupported or don't have any helper
function checks.
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl/builtin_functions.cpp | 6 --
src/compiler/glsl/builtin_variables.cpp | 2 +-
src/compiler/glsl/glsl_parser_extr
Can be done in another patch, but you should go through all the relevant
extension checks and update the with something that also considers the
features enabled for 460. Should be fairly mechanical.
On Aug 1, 2017 5:26 AM, "Samuel Pitoiset" wrote:
> Signed-off-by: Samuel Pitoiset
> ---
> src/c
On Jul 30, 2017 5:38 PM, "Timothy Arceri" wrote:
Also add a comment that this should only be used by the ir_reader
interface for testing purposes.
---
src/compiler/glsl/ir.cpp | 8 ++--
src/compiler/glsl/ir.h | 14 +++---
2 files changed, 9 insertions(+), 13 deletions(-)
diff --g
On Thu, Jul 27, 2017 at 2:45 PM, Kyriazis, George
wrote:
>
> On Jul 27, 2017, at 1:25 PM, Ilia Mirkin wrote:
>
> On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis
> wrote:
>
> The shader that is used to copy vertex data out of the vs/gs shaders to
> the user-specified
On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis
wrote:
> The shader that is used to copy vertex data out of the vs/gs shaders to
> the user-specified buffer (streamout or SO shader) was not using the
> correct offsets.
>
> Adjust the offsets that are used just for the SO shader:
> - Make sure tha
On Tue, Jul 25, 2017 at 3:39 PM, Samuel Pitoiset
wrote:
> The slower convert-and-copy process performs a bad conversion
> because it converts the value to signed 64-bit integer, but
> bindless uniform handles are considered unsigned 64-bit.
>
> This fixes "Check glUniform*() with mixed texture uni
On Tue, Jul 25, 2017 at 9:09 AM, Samuel Pitoiset
wrote:
>
>
> On 07/25/2017 03:08 PM, Brian Paul wrote:
>>
>> On 07/25/2017 02:04 AM, Nicolai Hähnle wrote:
>>>
>>> On 21.07.2017 15:16, Samuel Pitoiset wrote:
To reduce code duplication.
Signed-off-by: Samuel Pitoiset
---
>
On Sun, Jul 23, 2017 at 12:27 PM, Kyriazis, George
wrote:
>
> On Jul 23, 2017, at 11:21 AM, Ilia Mirkin wrote:
>
> On Sun, Jul 23, 2017 at 12:08 PM, George Kyriazis
> wrote:
>
> The shader that is used to copy vertex data out of the vs/gs shaders to
> the user-specified
This approach is generally right but implemented in the wrong place.
This "lowerPOW" happens pre-ssa. What actually needs to happen is that
this type of optimization is done at SSA time as part of
ConstantFolding. And the fallback for POW should be implemented as
part of the "legalize" step. That w
On Sun, Jul 23, 2017 at 12:08 PM, George Kyriazis
wrote:
> The shader that is used to copy vertex data out of the vs/gs shaders to
> the user-specified buffer (streamout os SO shader) was not using the
> correct offsets.
>
> Adjust the offsets that are used just for the SO shader:
> - Make sure th
Reviewed-by: Ilia Mirkin
On Tue, Jul 18, 2017 at 6:01 AM, wrote:
> From: "Wladimir J. van der Laan"
>
> This is the equivalent of util_format_is_s3tc, but for
> ETC.
>
> Signed-off-by: Wladimir J. van der Laan
> ---
> src/gallium/auxiliary/util/u_for
;On Mon, Jul 17, 2017 at 12:56 PM, Wladimir J. van der Laan
wrote:
> Add support for ETC2 compressed textures in the etnaviv driver.
>
> One step closer towards GL ES 3 support.
>
> For now, treat SRGB and RGB formats the same. It looks like these are
> distinguished using a different bit in sampl
time back:
https://people.freedesktop.org/~imirkin/nv10-comparison/problems.html
in case you're curious. I guess this is consistent with your results -
no change from doing this, until we get to borders.
With or without that function name change, this is
Reviewed-by: Ilia Mirkin
[apologies
-frontfacing-not.shader_test and
dEQP-GLES3.functional.shaders.builtin_variable.frontfacing on A530.
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/freedreno/ir3
We were using the "cp" union fields, which are only valid for compute
shaders. The threads calculation affects the availabel GPRs, so just
pick a small number for other shader types to avoid limiting available
registers.
Signed-off-by: Ilia Mirkin
Cc: mesa-sta...@lists.freedesktop.or
d we want this patch in -stable ?
>
> On Fri, 2017-07-07 at 20:34 -0400, Ilia Mirkin wrote:
>> Fixes a bunch of gl_BackColor interpolation tests that had explicit
>> interpolation specified on the fragment shader gl_Color.
>>
>> Signed-off-by: Ilia Mirkin
>&g
The register values depend on the currently set program, so make sure to
revalidate when the program changes.
Fixes glsl-1.10-fragdepth as well as
dEQP-GLES3.functional.shaders.fragdepth.compare.*
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a5xx/fd5_emit.c | 2 +-
1 file
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a5xx/a5xx.xml.h | 3 ++-
src/gallium/drivers/freedreno/a5xx/fd5_emit.c | 32 ++-
2 files changed, 23 insertions(+), 12 deletions(-)
diff --git a/src/gallium/drivers/freedreno/a5xx/a5xx.xml.h
b/src/gallium
Fixes a bunch of gl_BackColor interpolation tests that had explicit
interpolation specified on the fragment shader gl_Color.
Signed-off-by: Ilia Mirkin
---
src/compiler/nir/nir_lower_two_sided_color.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/compiler/nir
801 - 900 of 5930 matches
Mail list logo
