Re: [Mesa-dev] [PATCH 1/5] swr/rast: Remove unneeded virtual from methods

2018-05-17 Thread Kyriazis, George
Whole series Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> Thanks! On May 16, 2018, at 11:14 AM, Alok Hota mailto:alok.h...@intel.com>> wrote: --- src/gallium/drivers/swr/rasterizer/jitter/JitManager.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/s

Re: [Mesa-dev] [PATCH] swr: Fix include for createInstructionCombiningPass with llvm-7.0.

2018-05-03 Thread Kyriazis, George
It would be nice to avoid the extra #if LLVM_VERSION_MAJOR and include InstCombine.h into the same #if below, as follows: --- a/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp +++ b/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp @@ -69,6 +69,7 @@ using PassManager = llvm::legacy::Pas

Re: [Mesa-dev] [PATCH] swr/rast: Fix WriteBitcodeToFile usage with llvm-7.0.

2018-05-01 Thread Kyriazis, George
Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On May 1, 2018, at 2:05 AM, Vinson Lee mailto:v...@freedesktop.org>> wrote: Fix build error after llvm-7.0svn r325155 ("Pass a reference to a module to the bitcode writer."). CXX rasterizer/jitter/libmesaswr_la-JitManager.l

Re: [Mesa-dev] [PATCH] swr: Fix include for createInstructionCombiningPass with llvm-7.0.

2018-04-30 Thread Kyriazis, George
This patch does not address all the compile issues with llvm trunk (at least the ones that I see in my build). The following patch, however, works: diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp index aadcca2..efb

Re: [Mesa-dev] [PATCH 2/3] Autotools: Add passes.h to sources so it will be included in the tarball

2018-04-23 Thread Kyriazis, George
I agree on the commit message wording. Sorry about missing passes.h in the original check-in. Reviewed-by: George Kyriazis mailto:george.kyria...@intel.com>> On Apr 20, 2018, at 10:00 PM, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote: On Friday, April 20, 2018 7:19:50 PM PDT Dylan Bake

Re: [Mesa-dev] [PATCH] swr: Remove unnecessary memset call

2018-04-16 Thread Kyriazis, George
Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Apr 12, 2018, at 8:49 PM, Vlad Golovkin mailto:vlad.golovkin.m...@gmail.com>> wrote: Zeroing memory after calloc is not necessary. This also allows to avoid possible crash when allocation fails, because memset is called before

Re: [Mesa-dev] [PATCH v3 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-04 Thread Kyriazis, George
Thank you! Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Apr 4, 2018, at 3:22 AM, Mike Lothian mailto:m...@fireburn.co.uk>> wrote: Include llvm/Transforms/Utils.h with the newest LLVM 7 v2: Include with " " rather than < > (Vinson Lee) v3: Use LLVM_VERSION_MAJOR rather t

Re: [Mesa-dev] [PATCH 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-02 Thread Kyriazis, George
Please use LLVM defines consistent with the surrounding code. Surrounding code uses LLVM_VERSION_MAJOR / LLVM_VERSION_MINOR. This code should then be: #if LLVM_VERSION_MAJOR >= 7 … #endif Thank you! George > On Apr 1, 2018, at 3:05 PM, Vinson Lee wrote: > > On Sun, Apr 1, 2018 at 1:10 AM,

Re: [Mesa-dev] [PATCH] autotools: include all meson.build files

2018-03-08 Thread Kyriazis, George
Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Mar 2, 2018, at 12:00 PM, Dylan Baker mailto:dy...@pnwbakers.com>> wrote: Otherwise SWR cannot be built with meson from an autotools generated tarball, such as the 18.0.0-rc4 tarball. CC: George Kyriazis mailto:george.kyria...

Re: [Mesa-dev] [PATCH] swr/rast: Fix macOS macro.

2018-02-28 Thread Kyriazis, George
Yes, a typo on our end. Thank you! Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Feb 24, 2018, at 5:55 PM, Vinson Lee mailto:v...@freedesktop.org>> wrote: Fixes: a25093de7188 ("swr/rast: Implement JIT shader caching to disk") Signed-off-by: Vinson Lee mailto:v...@freedesk

Re: [Mesa-dev] Patch submit question

2018-02-26 Thread Kyriazis, George
It’s a commit that needs to be slightly different in master and 18.0, hence 2x the # of commits. Thanks for the 662cff8f pointer. Perfect example! George > On Feb 26, 2018, at 4:14 PM, Emil Velikov wrote: > > On 26 February 2018 at 20:18, Kyriazis, George > wrote: >

Re: [Mesa-dev] Patch submit question

2018-02-26 Thread Kyriazis, George
Thanks Jordan, Since I won’t be checking this in to mesa master, what do I need to do to actually push it to the stable branch, after I get a review on mesa-dev? George > On Feb 23, 2018, at 5:43 PM, Justen, Jordan L > wrote: > > On 2018-02-23 13:20:21, Kyriazis, George wrote: &

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

2018-02-26 Thread Kyriazis, George
It also fixes the errors that I was getting with gcc 5.4.0 with configure build on ubuntu 16.04. Tested-By: George Kyriazis mailto:george.kyria...@intel.com>> On Feb 25, 2018, at 6:52 PM, Roland Scheidegger mailto:srol...@vmware.com>> wrote: Am 25.02.2018 um 21:12 schrieb Francisco Jerez: Rol

Re: [Mesa-dev] Mesa (master): glsl: Switch ast_type_qualifier to a 128-bit bitset.

2018-02-26 Thread Kyriazis, George
Hello Francisco, This change breaks my ubuntu 16.04 build with gcc 5.4.0. Here’t where it breaks: CXX glsl/glsl_lexer.lo In file included from ../../../src/compiler/glsl/glsl_lexer.ll:27:0: ../../../src/compiler/glsl/ast.h:643:16: error: member ‘ast_type_qualifier::bitset_t ast_type_qua

[Mesa-dev] Patch submit question

2018-02-23 Thread Kyriazis, George
Hello mesa-dev, I have a quick patch submission question: I have a patch that I’d like to also nominate to mesa-stable (specifically 18.0.1 or 18.0.2), however the same patch is different between master and stable branches, due to neighboring code having changed in the meantime. What’s the bes

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Kyriazis, George
uck On Wed, Feb 21, 2018 at 12:36 PM, Kyriazis, George mailto:george.kyria...@intel.com>> wrote: Chuck, In which cases do you hit this? When an architecture is not supported, then swr_create_screen() falls back to a different (older) architecture. Thanks, George > On Feb 21, 2018

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Kyriazis, George
Chuck, In which cases do you hit this? When an architecture is not supported, then swr_create_screen() falls back to a different (older) architecture. Thanks, George > On Feb 21, 2018, at 8:26 AM, Chuck Atkins wrote: > > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is >

Re: [Mesa-dev] [PATCH] swr: remove dead LLVM code paths

2018-02-20 Thread Kyriazis, George
Thank you, Emil, for the cleanup! Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Feb 20, 2018, at 12:03 PM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: From: Emil Velikov mailto:emil.veli...@collabora.com>> LLVM requirement was bumped to 4.0.0 with earlier commi

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 4.0

2018-02-13 Thread Kyriazis, George
> On Feb 13, 2018, at 4:54 PM, Dylan Baker wrote: > > Quoting Andres Gomez (2018-02-13 14:42:57) > [snip] >> >> -if with_amd_vk or with_gallium_radeonsi >> +if with_amd_vk or with_gallium_radeonsi or with_gallium_swr >> _llvm_version = '>= 4.0.0' >> -elif with_gallium_opencl or with_gallium_s

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 4.0

2018-02-13 Thread Kyriazis, George
I am not an expert on all the changes needed for travis and packaging, but the swr changes look good. Reviewed-by: George Kyriazis mailto:george.kyria...@intel.com>> On Feb 13, 2018, at 4:42 PM, Andres Gomez mailto:ago...@igalia.com>> wrote: Since radv and radeonsi removed support for LLVM 3.

Re: [Mesa-dev] [PATCH] travis: radeonsi and radv need LLVM 4.0

2018-02-06 Thread Kyriazis, George
SWR is OK with moving to LLVM 4.0 and above. Just to clarify: This goes to master, which means mesa 18.0 is not affected, just 18.1 and later. Correct? Thanks, George > On Feb 6, 2018, at 11:07 AM, Kyriazis, George > wrote: > > As far as SWR is concerned, we’ll have to ask o

Re: [Mesa-dev] [PATCH] travis: radeonsi and radv need LLVM 4.0

2018-02-06 Thread Kyriazis, George
As far as SWR is concerned, we’ll have to ask our customers. Will respond shortly. Thanks, George > On Feb 6, 2018, at 9:42 AM, Andres Gomez wrote: > > Fixes: 3bf1e036e8a ("amd: remove support for LLVM 3.9") > Cc: Marek Olšák > Cc: Emil Velikov > Cc: Jan Vesely > Signed-off-by: Andres Gom

Re: [Mesa-dev] [PATCH] swr: don't export swr_create_screen_internal

2018-01-29 Thread Kyriazis, George
Yep, tested on our side, and looks good. Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Jan 29, 2018, at 9:42 AM, Chuck Atkins mailto:chuck.atk...@kitware.com>> wrote: Lgtm, should probably get a rb from Intel though to make sure it doesn't break anything they're trying t

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr/rast: support llvm 3.9 type declarations

2018-01-24 Thread Kyriazis, George
On Jan 24, 2018, at 11:43 AM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: On 24 January 2018 at 15:30, George Kyriazis mailto:george.kyria...@intel.com>> wrote: LLVM 3.9 was not taken into in initial check-in. Fixes: 01ab218bbc ("swr/rast: Initial work for debugging support.") cc: me

Re: [Mesa-dev] [PATCH 04/20] swr/rast: Initial work for debugging support.

2018-01-23 Thread Kyriazis, George
Emil, I’m already working on it. Thanks! George > On Jan 23, 2018, at 10:04 AM, Emil Velikov wrote: > > Hi George, > > On 19 January 2018 at 21:46, George Kyriazis > wrote: >> Adds ability to step into jitted llvm IR in Visual Studio. >> - Updated llvm type generation script to also genera

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

2018-01-22 Thread Kyriazis, George
Chuck, Change verified on my end; check-in coming coming up soon. George On Jan 22, 2018, at 2:11 PM, Kyriazis, George mailto:george.kyria...@intel.com>> wrote: On Jan 22, 2018, at 12:02 PM, Chuck Atkins mailto:chuck.atk...@kitware.com>> wrote: Hi Emil, Fixes: a4be2bcee2f (&

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

2018-01-22 Thread Kyriazis, George
On Jan 22, 2018, at 12:02 PM, Chuck Atkins mailto:chuck.atk...@kitware.com>> wrote: Hi Emil, Fixes: a4be2bcee2f ("swr: allow a single swr architecture to be builtin") It doesn't fix anything that was broken from that commit. The issues with error handling were already present before then, it

Re: [Mesa-dev] [PATCH] gallivm: avx-512 changes for texel fetcher

2018-01-18 Thread Kyriazis, George
On Jan 18, 2018, at 1:10 PM, Roland Scheidegger mailto:srol...@vmware.com>> wrote: Am 17.01.2018 um 23:33 schrieb George Kyriazis: The texture swizzle was not doing the right thing for avx512-style 16-wide loads. Special-case the post-load swizzle operations for avx512 so that we move the xyzw

Re: [Mesa-dev] [PATCH] gallivm: avx-512 changes for texel fetcher

2018-01-18 Thread Kyriazis, George
On Jan 18, 2018, at 1:10 PM, Roland Scheidegger mailto:srol...@vmware.com>> wrote: Am 17.01.2018 um 23:33 schrieb George Kyriazis: The texture swizzle was not doing the right thing for avx512-style 16-wide loads. Special-case the post-load swizzle operations for avx512 so that we move the xyzw c

Re: [Mesa-dev] Mesa 18.0.0 release plan

2018-01-16 Thread Kyriazis, George
Hello Emil, For the swr driver we are planning on getting some features in in the last couple of days, but one extra week will help us out. Specifically, we are thinking of checking in: - FE 16-wide shader support. This will entail calling lp_build_tgsi_soa() with width 16. Having some proble

Re: [Mesa-dev] [PATCH v2] swr: Correct texture allocation and limit max size to 2GB

2017-11-30 Thread Kyriazis, George
Looks good. Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Nov 30, 2017, at 11:51 AM, Bruce Cherniak mailto:bruce.chern...@intel.com>> wrote: This patch fixes piglit tex3d-maxsize by correcting 4 things: The total_size calculation was using 32-bit math, therefore a >4GB al

Re: [Mesa-dev] [PATCH v3] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-16 Thread Kyriazis, George
The problem that I’m seeing with timespec_get is that centos6 does not have it. I’ve put some changes out for review that actually remove timespec_get() in favor of using a variation of os_time_get_nano(). It’s good to always use the same time functions, and not have multiple ways of doing simi

Re: [Mesa-dev] add util_queue_fence_wait_timeout checkin breaks centos6 build

2017-11-10 Thread Kyriazis, George
ortable it is. Of course, the most fool-proof solution would be a configure script check, but it could be redundant. George > On Nov 10, 2017, at 2:41 PM, Nicolai Hähnle wrote: > > On 10.11.2017 19:20, Kyriazis, George wrote: >> Hello Nicolai, >> Your commit e3a8013 (uti

[Mesa-dev] add util_queue_fence_wait_timeout checkin breaks centos6 build

2017-11-10 Thread Kyriazis, George
Hello Nicolai, Your commit e3a8013 (util/u_queue: add util_queue_fence_wait_timeout), breaks the centos6 build. Specifically, I am getting: CC libmesautil_la-u_queue.lo ../../../src/util/u_queue.c: In function '_util_queue_fence_wait_timeout': ../../../src/util/u_queue.c:173:7: error: imp

Re: [Mesa-dev] [PATCH] swr: Fixed an uncommon freed-memory access during state validation

2017-11-09 Thread Kyriazis, George
Looks good.. Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Nov 8, 2017, at 6:39 PM, Bruce Cherniak mailto:bruce.chern...@intel.com>> wrote: State validation is performed during clear and draw calls. Validation during clear was still accessing vertex buffer state. When th

Re: [Mesa-dev] Piglit on windows

2017-10-10 Thread Kyriazis, George
> On Oct 10, 2017, at 1:23 PM, Dylan Baker wrote: > > Quoting Kyriazis, George (2017-10-10 11:02:26) >> >>> On Oct 10, 2017, at 12:46 PM, Dylan Baker wrote: >>> >>> Quoting Jose Fonseca (2017-10-10 08:41:49) >>>> On 10/10/17 16:31, Kyria

Re: [Mesa-dev] Piglit on windows

2017-10-10 Thread Kyriazis, George
> On Oct 10, 2017, at 12:46 PM, Dylan Baker wrote: > > Quoting Jose Fonseca (2017-10-10 08:41:49) >> On 10/10/17 16:31, Kyriazis, George wrote: >>> Hello… >>> >>> Piglit on windows prints out a message saying “Timeout are not implemented >>>

Re: [Mesa-dev] Piglit on windows

2017-10-10 Thread Kyriazis, George
On Oct 10, 2017, at 10:41 AM, Jose Fonseca mailto:jfons...@vmware.com>> wrote: On 10/10/17 16:31, Kyriazis, George wrote: Hello… Piglit on windows prints out a message saying “Timeout are not implemented on Windows.”. These timeouts are the test timeouts in case a test hangs. What do

[Mesa-dev] Piglit on windows

2017-10-10 Thread Kyriazis, George
Hello… Piglit on windows prints out a message saying “Timeout are not implemented on Windows.”. These timeouts are the test timeouts in case a test hangs. What do people do when running piglit on windows and they hit a timeout? I would imagine there would be a non-zero number of people runnin

Re: [Mesa-dev] [OS]Mesa MinGW AppVeyor Repository

2017-10-02 Thread Kyriazis, George
Emil, I’m working with Trevor to upstream the correct versions of the swr patches. Thanks, George > On Oct 2, 2017, at 9:04 AM, Emil Velikov wrote: > > Hi Trevor, > > On 2 October 2017 at 13:48, Trevor Sandy wrote: >> Hi George, >> >> You might be interested to know I have set up a CI env

Re: [Mesa-dev] [PATCH 2/2] swr: Report format max_samples=1 to maintain support for "fake" msaa.

2017-09-01 Thread Kyriazis, George
Discussed with Bruce. Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Aug 31, 2017, at 11:09 PM, Brian Paul mailto:bri...@vmware.com>> wrote: I'm not familiar with this driver so I'll give this an Acked-by: Brian Paul mailto:bri...@vmware.com>> Roland gave me his R-b for t

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

2017-07-27 Thread Kyriazis, George
> On Jul 27, 2017, at 1:49 PM, Ilia Mirkin wrote: > > On Thu, Jul 27, 2017 at 2:45 PM, Kyriazis, George > wrote: >> >> On Jul 27, 2017, at 1:25 PM, Ilia Mirkin wrote: >> >> On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis >> wrote: >> >&

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

2017-07-27 Thread Kyriazis, George
On Jul 27, 2017, at 1:25 PM, Ilia Mirkin mailto:imir...@alum.mit.edu>> wrote: On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis mailto:george.kyria...@intel.com>> wrote: The shader that is used to copy vertex data out of the vs/gs shaders to the user-specified buffer (streamout or SO shader) was

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

2017-07-23 Thread Kyriazis, George
On Jul 23, 2017, at 1:51 PM, Ilia Mirkin mailto:imir...@alum.mit.edu>> wrote: On Sun, Jul 23, 2017 at 12:27 PM, Kyriazis, George mailto:george.kyria...@intel.com>> wrote: On Jul 23, 2017, at 11:21 AM, Ilia Mirkin mailto:imir...@alum.mit.edu>> wrote: On Sun, Jul 23, 2017 a

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

2017-07-23 Thread Kyriazis, George
On Jul 23, 2017, at 1:42 PM, Rowley, Timothy O mailto:timothy.o.row...@intel.com>> wrote: On Jul 23, 2017, at 11:08 AM, George Kyriazis mailto:george.kyria...@intel.com>> wrote: The shader that is used to copy vertex data out of the vs/gs shaders to the user-specified buffer (streamout os SO

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

2017-07-23 Thread Kyriazis, George
On Jul 23, 2017, at 11:21 AM, Ilia Mirkin mailto:imir...@alum.mit.edu>> wrote: On Sun, Jul 23, 2017 at 12:08 PM, George Kyriazis mailto:george.kyria...@intel.com>> wrote: The shader that is used to copy vertex data out of the vs/gs shaders to the user-specified buffer (streamout os SO shader) wa

Re: [Mesa-dev] [PATCH] swr: invalidate attachment on transition change

2017-07-07 Thread Kyriazis, George
+Bruce Andres, VTK/Kitware has already modified their code to enable dual depth peeling for Mesa version >= 17.2. From that perspective, it doesn’t matter if the change goes into the 17.1.x releases or 17.2. Having said that, we haven’t seen any issues with that check-in, so if it makes it t

Re: [Mesa-dev] [PATCH 02/11] mesa/glthread: remove HAVE_PTHREAD guards

2017-06-26 Thread Kyriazis, George
I can verify that the fix works. Thank you! George > On Jun 26, 2017, at 3:24 PM, Marek Olšák wrote: > > I just pushed the fix. > > Marek > > On Mon, Jun 26, 2017 at 10:01 PM, Kyriazis, George > wrote: >> Marek >> >> Our windows mesa build broke

Re: [Mesa-dev] [PATCH 02/11] mesa/glthread: remove HAVE_PTHREAD guards

2017-06-26 Thread Kyriazis, George
Marek Our windows mesa build broke with your checkin: "mesa/glthread: remove HAVE_PTHREAD guards”. Namely: Compiling src\mesa\main\context.c ... context.c c:\users\gkyriazi\src\mesa\src\mesa\main\glthread.h(34): fatal error C1083: Cannot open include file: 'pthread.h': No such file or direct

Re: [Mesa-dev] [PATCH 2/2] swr: Fix polygonmode for front==back

2017-04-25 Thread Kyriazis, George
I am perfectly fine not submitting into stable. And can remove the assert, since it’s causing trouble. FWIW, piglit llvmpipe.py fixes 3 tests with no regressions. George On Apr 25, 2017, at 9:23 PM, Rowley, Timothy O mailto:timothy.o.row...@intel.com>> wrote: Additionally I don’t think this

Re: [Mesa-dev] [PATCH 10/14] travis: add "scons swr" to the build matrix

2017-04-24 Thread Kyriazis, George
As discussed, If you run scons with a small -j number, it would work (verified by Emil). With that change Reviewed-by: George Kyriazis mailto:george.kyria...@intel.com>> For the rest of the series, I don’t have enough experience with travis to review.. George On Apr 21, 2017, at 7:08 AM, Em

Re: [Mesa-dev] [PATCH 10/14] travis: add "scons swr" to the build matrix

2017-04-21 Thread Kyriazis, George
rasterizer.cpp takes a lot of resources to compile. Looks like the autotools build runs -j2, which limits the exposure, because of fewer parallel jobs, while scons, by default is more aggressive. Suggest running scons -j 1 or scons -j 2 for swr. Thanks, George > On Apr 21, 2017, at 7:08 AM,

Re: [Mesa-dev] [PATCH] swr: Fix swr osmesa build

2017-04-14 Thread Kyriazis, George
Thanks Emil, I will attempt to un-meh a bit at checkin. George > On Apr 14, 2017, at 5:52 PM, Emil Velikov wrote: > > Commit summary is a bit meh, but regardless. > > Reviewed-by: Emil Velikov > > -Emil ___ mesa-dev mailing list mesa-dev@lists.fr

Re: [Mesa-dev] [PATCH] swr: Enable MSAA in OpenSWR software renderer

2017-04-14 Thread Kyriazis, George
Reviewed-by: George Kyriazis mailto:george.kyria...@intel.com>> With the assumption that there are additional changes forthcoming. On Apr 13, 2017, at 5:40 PM, Bruce Cherniak mailto:bruce.chern...@intel.com>> wrote: This patch enables multisample antialiasing in the OpenSWR software renderer.

Re: [Mesa-dev] [PATCH] swr: Add polygon stipple support

2017-04-14 Thread Kyriazis, George
On Apr 14, 2017, at 11:35 AM, Ilia Mirkin mailto:imir...@alum.mit.edu>> wrote: On Fri, Apr 14, 2017 at 11:18 AM, Ilia Mirkin mailto:imir...@alum.mit.edu>> wrote: On Thu, Apr 13, 2017 at 4:30 PM, George Kyriazis mailto:george.kyria...@intel.com>> wrote: Add polygon stipple functionality to the f

Re: [Mesa-dev] [PATCH] swr: add linux to scons build

2017-04-14 Thread Kyriazis, George
On Apr 14, 2017, at 12:44 PM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: On 13 April 2017 at 20:17, George Kyriazis mailto:george.kyria...@intel.com>> wrote: Make swr compile for both linux and windows. --- src/gallium/drivers/swr/SConscript| 7 +-- src/gallium/targets/lib

Re: [Mesa-dev] [PATCH] docs: document the C++14 SWR requirement

2017-04-12 Thread Kyriazis, George
On Apr 12, 2017, at 10:03 AM, Rowley, Timothy O mailto:timothy.o.row...@intel.com>> wrote: On Apr 12, 2017, at 9:11 AM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: From: Emil Velikov mailto:emil.veli...@collabora.com>> Earlier commit bumped the requirement for the SWR driver. Cc:

Re: [Mesa-dev] [PATCH v2 10/10] swr: [rasterizer codegen] Fix windows build

2017-03-27 Thread Kyriazis, George
Tried Depends(), but it doesn’t work all the time. There are some cases where it works, and some others where it doesn’t. I’ll need to investigate more. Fix in a separate checkin later? George On Mar 27, 2017, at 8:38 PM, Rowley, Timothy O mailto:timothy.o.row...@intel.com>> wrote: On close

Re: [Mesa-dev] [PATCH 01/10] swr: [rasterizer codegen] Refactor codegen

2017-03-27 Thread Kyriazis, George
Apart from 01/10 and 10/10 (that have been discussed in other emails), patches 02/10 to 09/10 Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Mar 25, 2017, at 7:00 AM, Tim Rowley mailto:timothy.o.row...@intel.com>> wrote: Move common codegen functions into gen_common.py. -

Re: [Mesa-dev] [PATCH v2 01/10] swr: [rasterizer codegen] Refactor codegen

2017-03-27 Thread Kyriazis, George
With this v2 change PATCH 10/10 has to be updated. V2 of 10/10 coming in a separate envelope. With the 10/10 update, this patch: Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> George On Mar 27, 2017, at 11:17 AM, Tim Rowley mailto:timothy.o.row...@intel.com>> wrote: Move c

Re: [Mesa-dev] [PATCH v2 1/2] [util] add extern "C" guards

2017-02-16 Thread Kyriazis, George
> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Wednesday, February 15, 2017 10:04 PM > To: Kyriazis, George > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v2 1/2] [util] add exte

Re: [Mesa-dev] [PATCH] [swr] fix windows build

2017-02-15 Thread Kyriazis, George
You mean use extern "C" (inside a c++ guard) on u_upload_mgr.h and friends? Thanks, George > -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Wednesday, February 15, 2017 4:25 PM > To: Kyriazi

Re: [Mesa-dev] [PATCH] [swr] fix index buffers with non-zero indices

2017-01-31 Thread Kyriazis, George
Thanks, Good point. I'll send a new version our for review. George > -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Tuesday, January 31, 2017 11:50 AM > To: Kyriazis, George > Cc: mesa-dev@lists.fr

Re: [Mesa-dev] [PATCH] [swr] fix index buffers with non-zero indices

2017-01-31 Thread Kyriazis, George
x and index buffers, which is the case that this fixes). What do you think? Thanks, George > -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Tuesday, January 31, 2017 11:17 AM > To: Kyriazis, Ge

Re: [Mesa-dev] [PATCH 7/9] scons: swr: remove explicit __STDC_.*_MACROS defines

2017-01-26 Thread Kyriazis, George
Signed-off: George Kyriazis > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, January 26, 2017 7:24 AM > To: mesa-dev@lists.freedesktop.org > Cc: emil.l.veli...@gmail.com; Kyriazis, George > Subject: [PATCH 7/9] scons: sw

Re: [Mesa-dev] [PATCH] swr: Prune empty nodes in CalculateProcessorTopology.

2017-01-19 Thread Kyriazis, George
Bruce, I think you have to add the cc: line in the message body, and not cc mesa-stable explicitly, as described in http://www.mesa3d.org/devinfo.html. I could be wrong, though. Otherwise, Reviewed-By: George Kyriazis Thanks, George > -Original Message- > From: mesa-dev [mailto:me

Re: [Mesa-dev] [PATCH v3] swr: fix windows build break

2017-01-04 Thread Kyriazis, George
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ilia Mirkin > Sent: Wednesday, January 4, 2017 2:30 PM > To: Kyriazis, George > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v3] swr: fix window

Re: [Mesa-dev] [PATCH v3] swr: fix windows build break

2017-01-04 Thread Kyriazis, George
> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Wednesday, January 4, 2017 2:22 PM > To: Kyriazis, George > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v3] swr: fix windows bu

Re: [Mesa-dev] [PATCH] swr: remove unneeded llvm version check

2017-01-03 Thread Kyriazis, George
Reviewed-by: George Kyriazis George > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tim Rowley > Sent: Tuesday, January 3, 2017 10:25 AM > To: Cherniak, Bruce ; mesa- > d...@lists.freedesktop.org > Subject: [

Re: [Mesa-dev] [PATCH] swr: Implement fence attached work queues for deferred deletion.

2016-12-15 Thread Kyriazis, George
Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Bruce Cherniak > Sent: Monday, December 12, 2016 7:25 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: Implement fence attached work

Re: [Mesa-dev] [PATCH] swr: Templetize std::max to work on windows

2016-11-29 Thread Kyriazis, George
> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Tuesday, November 29, 2016 1:54 PM > To: Kyriazis, George > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] swr: Templetize std::max

Re: [Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and GALLIUM_RBUG to gdi

2016-11-28 Thread Kyriazis, George
I'll retract this diff for now, then. George > -Original Message- > From: Jose Fonseca [mailto:jfons...@vmware.com] > Sent: Thursday, November 24, 2016 1:42 PM > To: Emil Velikov ; Kyriazis, George > > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH]

Re: [Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and GALLIUM_RBUG to gdi

2016-11-23 Thread Kyriazis, George
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Wednesday, November 23, 2016 11:37 AM > To: Kyriazis, George ; Jose Fonseca > > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH] gd

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-23 Thread Kyriazis, George
Thanks, I'll update the docs explaining the *-By: a bit better and send it out for review. George > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ilia Mirkin > Sent: Wednesday, November 23, 2016 10:59 AM > To: Ky

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-23 Thread Kyriazis, George
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Wednesday, November 23, 2016 10:02 AM > To: Ilia Mirkin > Cc: Kyriazis, George ; ML mesa-dev d...@lists.freedesktop.org> > Subject: Re: [M

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-23 Thread Kyriazis, George
. George > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Monday, November 21, 2016 10:27 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for > windows > > O

Re: [Mesa-dev] [PATCH v5 09/11] swr: Modify gen_knobs.{cpp|h} creation script

2016-11-21 Thread Kyriazis, George
Thank you for the reviews, Emil. Tim will check-in the series, since he has check-in privileges. George > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Saturday, November 19, 2016 4:23 PM > To: Kyriazis, George > Cc: ML mesa-dev >

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-18 Thread Kyriazis, George
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Friday, November 18, 2016 5:24 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added sw

Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related changes

2016-11-17 Thread Kyriazis, George
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Thursday, November 17, 2016 11:12 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related c

Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related changes

2016-11-17 Thread Kyriazis, George
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Thursday, November 17, 2016 11:12 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related c

Re: [Mesa-dev] [PATCH v3 10/10] swr: Modify gen_knobs.{cpp|h} creation script

2016-11-17 Thread Kyriazis, George
> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, November 17, 2016 11:22 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v3 10/10] swr: Modify gen_knobs.{cpp|h} > creation script > > O

Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver

2016-11-10 Thread Kyriazis, George
vember 10, 2016 12:13 PM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver > > On 10 November 2016 at 17:27, Kyriazis, George > wrote: > >> -Original Message- > >> From: Emil Velikov [mail

Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver

2016-11-10 Thread Kyriazis, George
> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, November 10, 2016 8:14 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver > > "gallium/targets: scon

Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc HAS_TRIVIAL_DESTRUCTOR implementation

2016-11-09 Thread Kyriazis, George
Alright, I won't include that particular change in my v2 of the other changes that I have, then. Thanks! George > -Original Message- > From: Brian Paul [mailto:bri...@vmware.com] > Sent: Wednesday, November 9, 2016 4:03 PM > To: Kyriazis, George ; Marek Olšák

Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc HAS_TRIVIAL_DESTRUCTOR implementation

2016-11-09 Thread Kyriazis, George
tested on my end. Thanks, George > -Original Message- > From: Marek Olšák [mailto:mar...@gmail.com] > Sent: Wednesday, November 9, 2016 3:31 PM > To: Brian Paul > Cc: Kyriazis, George ; mesa- > d...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 2/3] mesa: adde

Re: [Mesa-dev] [PATCH 1/3] gallium/scons: OpenSWR Windows support

2016-11-08 Thread Kyriazis, George
> -Original Message- > From: Jose Fonseca [mailto:jfons...@vmware.com] > Sent: Tuesday, November 8, 2016 4:17 PM > To: Kyriazis, George ; mesa- > d...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 1/3] gallium/scons: OpenSWR Windows > support > >

Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc HAS_TRIVIAL_DESTRUCTOR implementation

2016-11-08 Thread Kyriazis, George
> -Original Message- > From: Jose Fonseca [mailto:jfons...@vmware.com] > Sent: Tuesday, November 8, 2016 4:12 PM > To: Kyriazis, George ; mesa- > d...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc > HAS_TRIVIAL_DESTRUCTOR implementatio

Re: [Mesa-dev] [PATCH 3/3] swr: Support windows builds

2016-11-08 Thread Kyriazis, George
> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Tuesday, November 8, 2016 10:54 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH 3/3] swr: Support windows builds > > On 8 November 2016 at 15:48, K

Re: [Mesa-dev] [PATCH 3/3] swr: Support windows builds

2016-11-08 Thread Kyriazis, George
Comments inline.. > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Tuesday, November 8, 2016 8:25 AM > To: Kyriazis, George > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH 3/3] swr: Support windows builds > > On 7 Novemb

Re: [Mesa-dev] [PATCH 1/3] gallium/scons: OpenSWR Windows support

2016-11-08 Thread Kyriazis, George
Thank you for the review. Comments inline. > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Tuesday, November 8, 2016 7:52 AM > To: Kyriazis, George ; Jose Fonseca > > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH 1/3] g

Re: [Mesa-dev] [PATCH] swr: Removed stalling SwrWaitForIdle from queries.

2016-09-30 Thread Kyriazis, George
Reviewed-by: George Kyriazis mailto:george.kyria...@intel.com>> From: Bruce Cherniak mailto:bruce.chern...@intel.com>> Subject: [PATCH] swr: Removed stalling SwrWaitForIdle from queries. Date: September 27, 2016 at 1:27:08 PM CDT To: mailto:mesa-dev@lists.freedesktop.org>> Cc: Bruce Cherniak ma

Re: [Mesa-dev] [PATCH] gallium: detect avx512 cpu features

2016-05-26 Thread Kyriazis, George
All good, but I would suggest matching the already existing editing style (ie correct tabulation, and zero-padding of cpuid() args. Reviewed-By: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tim Rowley > Sent: Wedne

Re: [Mesa-dev] [PATCH] swr: Add missing break in query switch statement.

2016-05-09 Thread Kyriazis, George
Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of BruceCherniak > Sent: Monday, May 9, 2016 9:00 AM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: Add missing break in query switch > s

Re: [Mesa-dev] [PATCH] swr: Remove stall waiting for core query counters.

2016-05-04 Thread Kyriazis, George
Reviewed-By: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of BruceCherniak > Sent: Thursday, April 28, 2016 12:13 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: Remove stall waiting for core q

Re: [Mesa-dev] [PATCH v2] swr: fix memory leaks from vs/fs compilation

2016-04-22 Thread Kyriazis, George
Reviewed by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tim Rowley > Sent: Wednesday, April 20, 2016 7:42 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH v2] swr: fix memory leaks from vs/fs > c

Re: [Mesa-dev] [PATCH] swr: support samplers in vertex shaders

2016-04-12 Thread Kyriazis, George
Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tim Rowley > Sent: Friday, April 1, 2016 8:03 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: support samplers in vertex shaders >

Re: [Mesa-dev] [PATCH] swr: handle pci cap requests

2016-04-12 Thread Kyriazis, George
Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tim Rowley > Sent: Friday, April 1, 2016 8:03 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: handle pci cap requests > > --- > sr

Re: [Mesa-dev] [PATCH] gallium/swr: Resource management

2016-03-11 Thread Kyriazis, George
Reviewed-By: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of BruceCherniak > Sent: Wednesday, March 9, 2016 7:30 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] gallium/swr: Resource management > >

Re: [Mesa-dev] [PATCH v3 2/2] Hang off screen destructor off main XCloseDisplay() callback.

2016-03-03 Thread Kyriazis, George
n Paul [mailto:bri...@vmware.com] > Sent: Thursday, March 3, 2016 11:32 AM > To: Kyriazis, George ; mesa- > d...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v3 2/2] Hang off screen destructor off main > XCloseDisplay() callback. > > On 03/02/2016 06:28 PM, George Kyriazis wr

Re: [Mesa-dev] [PATCH v2] Support unlimited number of display connections

2016-03-03 Thread Kyriazis, George
v-boun...@lists.freedesktop.org] On > Behalf Of Kyriazis, George > Sent: Wednesday, March 2, 2016 7:03 PM > To: Brian Paul ; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v2] Support unlimited number of display > connections > > I am re-sending an updated patch that f

  1   2   >