Re: [Mesa-dev] [PATCH 3/3] android: aco: add support for libmesa_aco

2019-09-27 Thread Mauro Rossi
e branches between source issor.oruam/mesa branch android_aco and the mesa/mesa branch master Is it mandatory that I push to a mesa/mesa branch android_aco to be able to perform MR/Compare to master? Thanks for the info/help Mauro On Sun, Sep 22, 2019 at 12:00 PM Mauro Rossi wrote: > And

[Mesa-dev] [PATCH 1/3] android: aco: fix undefined template 'std::__1::array' build errors

2019-09-22 Thread Mauro Rossi
'std::__1::array' _T2 second; ^ Fixes: 93c8ebf ("aco: Initial commit of independent AMD compiler") Signed-off-by: Mauro Rossi --- src/amd/compiler/aco_instruction_selection.cpp | 1 + src/amd/compiler/aco_instruction_selection_setup.cpp | 1 + src/amd/compil

[Mesa-dev] [PATCH 2/3] android: compiler/nir: build nir_divergence_analysis.c

2019-09-22 Thread Mauro Rossi
'nir_divergence_analysis' clang.real: error: linker command failed with exit code 1 (use -v to see invocation) Fixes: df86c5f ("nir: add divergence analysis pass.") Signed-off-by: Mauro Rossi --- src/compiler/Makefile.sources | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compile

[Mesa-dev] [PATCH 3/3] android: aco: add support for libmesa_aco

2019-09-22 Thread Mauro Rossi
path in RADV to support the experimental ACO compiler") Signed-off-by: Mauro Rossi --- src/amd/Android.compiler.mk | 93 + src/amd/Android.mk | 1 + src/amd/Makefile.sources| 32 + src/amd/vulkan/Android.mk | 4 +- 4 files cha

[Mesa-dev] [PATCH] android: anv: libmesa_vulkan_common: add libmesa_util static dependency

2019-09-08 Thread Mauro Rossi
add support for driconf") Signed-off-by: Mauro Rossi --- src/intel/Android.vulkan.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/Android.vulkan.mk b/src/intel/Android.vulkan.mk index 624b440560..468ddfc65f 100644 --- a/src/intel/Android.vulka

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-09-05 Thread Mauro Rossi
Hi Eric, Emil, we have Tapani ok, in my understanding Please follow up on this one Mauro On Fri, Aug 16, 2019 at 4:29 AM Mauro Rossi wrote: > Hi Tapani, Eric, > > On Thu, Aug 15, 2019 at 1:00 PM Tapani Pälli > wrote: > >> >> On 8/15/19 12:52 PM, Mauro Rossi wrote: &

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-08-15 Thread Mauro Rossi
Hi Tapani, Eric, On Thu, Aug 15, 2019 at 1:00 PM Tapani Pälli wrote: > > On 8/15/19 12:52 PM, Mauro Rossi wrote: > > Hi Tapani, > > > > On Thu, Aug 15, 2019 at 7:29 AM Tapani Pälli > <mailto:tapani.pa...@intel.com>> wrote: > > > > > >

Re: [Mesa-dev] Concern about proposed patch "egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support"

2019-08-15 Thread Mauro Rossi
port from egl/android SurfaceFlinger will just crash with SIGABRT on nouveau > > On Thu, Aug 15, 2019 at 12:49 PM Mauro Rossi > wrote: > > > > Hi, > > > > sorry if I'm communicating in dedicated thread, but I don't know how to > reply to existing o

[Mesa-dev] Concern about proposed patch "egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support"

2019-08-15 Thread Mauro Rossi
Hi, sorry if I'm communicating in dedicated thread, but I don't know how to reply to existing one. The proposed patch is based on the wrong assumption that all drivers used with Android have RGBA_, which is not correct, for example nouveau does not support RGBA on primary planes, infact we ha

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-08-15 Thread Mauro Rossi
Hi Tapani, On Thu, Aug 15, 2019 at 7:29 AM Tapani Pälli wrote: > > On 8/13/19 9:55 PM, Mauro Rossi wrote: > > Hi, > > > > On Tue, Aug 13, 2019 at 3:51 PM Tapani Pälli > <mailto:tapani.pa...@intel.com>> wrote: > > > > > >

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-08-13 Thread Mauro Rossi
Hi, On Tue, Aug 13, 2019 at 3:51 PM Tapani Pälli wrote: > > On 8/13/19 3:32 PM, Mauro Rossi wrote: > > Hi, > > > > On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli > <mailto:tapani.pa...@intel.com>> wrote: > > > > Hi; > > > >

[Mesa-dev] [PATCH] i965/gen11: fix genX_bits.h include path

2019-08-13 Thread Mauro Rossi
Instead of "genX_bits.h" use "genxml/genX_bits.h" as already done in other similar cases Besides being more correct, it also fixes building error in Android. Fixes: f0d2923 ("i965/gen11: Emit SLICE_HASH_TABLE when pipes are unbalanced.") Signed-off-by: Mauro Rossi

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-08-13 Thread Mauro Rossi
Hi, On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli wrote: > Hi; > > On 8/13/19 2:43 PM, Mauro Rossi wrote: > > Hi Tapani, > > > > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi > <mailto:issor.or...@gmail.com>> wrote: > > > > On Sat, Jul 27,

[Mesa-dev] [PATCH] android: intel/perf: fix missing include path in makefile

2019-08-09 Thread Mauro Rossi
erf_begin_query into gen_perf") Signed-off-by: Mauro Rossi --- src/intel/Android.perf.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/Android.perf.mk b/src/intel/Android.perf.mk index 0d7d746a63..c99d84c4be 100644 --- a/src/intel/Android.perf.mk +++ b/src/i

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-07-27 Thread Mauro Rossi
On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi wrote: > > On Thu, Jul 18, 2019 at 1:07 PM Chih-Wei Huang > wrote: > > > > Mauro Rossi 於 2019年7月14日 週日 下午5:17寫道: > > > > > > This patch partially reverts 20294dc ("mesa: Enable asm unconditionally, &g

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-07-27 Thread Mauro Rossi
On Thu, Jul 18, 2019 at 1:07 PM Chih-Wei Huang wrote: > > Mauro Rossi 於 2019年7月14日 週日 下午5:17寫道: > > > > This patch partially reverts 20294dc ("mesa: Enable asm unconditionally, > > ...") > > > > Android makefile build logic needs to disable assem

Re: [Mesa-dev] [PATCH] android: radv/gfx10: generate gfx10_format_table.h

2019-07-16 Thread Mauro Rossi
Hi, kind reminder for Review or Ack, apart from Android makefile changes Makefile.sources was modified to add gfx10_format_table.h generated file. Mauro On Wed, Jul 10, 2019 at 9:13 AM Mauro Rossi wrote: > This patch adds gfx10_format_table.h in Makefile.sources > and the rules for Andr

[Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-07-14 Thread Mauro Rossi
unconditionally, now that gen_matypes is gone.") Signed-off-by: Mauro Rossi --- Android.common.mk | 3 +++ Android.mk | 7 +++ src/mesa/Android.libmesa_dricore.mk | 2 ++ src/mesa/Android.libmesa_st_mesa.mk | 2 ++ 4 files changed, 14 inserti

Re: [Mesa-dev] [PATCH 3/3] android: amd/addrlib: add gfx10 support

2019-07-10 Thread Mauro Rossi
x86 My series of fixes on amdgpu/radeonsi Android build rules did not touch src/egl build rules and looking at Chih-Wei they seem also unrelated, he may confirm that Mauro > > I'd like to leverage your work to improve our automation, so we don't > break your tree again. >

Re: [Mesa-dev] [PATCH 3/3] android: amd/addrlib: add gfx10 support

2019-07-10 Thread Mauro Rossi
s, we got: > > src/egl/main/egldevice.c:126:11: error: implicit declaration of function > 'drmDevicesEqual' > > I'd like to leverage your work to improve our automation, so we don't > break your tree again. > > -Mark > > Mauro Rossi writes: > >

[Mesa-dev] [PATCH] android: radv/gfx10: generate gfx10_format_table.h

2019-07-10 Thread Mauro Rossi
#x27; file not found ^~ 1 error generated. Fixes: 3dc5ec5d16 ("radv/gfx10: generate gfx10_format_table.h") Signed-off-by: Mauro Rossi --- src/amd/vulkan/Android.mk | 15 +++ src/amd/vulkan/Makefile.sources | 3 ++- 2 files changed, 17 insertions(+), 1 del

[Mesa-dev] [PATCH 2/3] android: amd/common/gfx10: add register JSON

2019-07-06 Thread Mauro Rossi
7; case V_008F0C_BUF_DATA_FORMAT_8: format = V_008F0C_IMG_FORMAT_8_UINT; break; ^ Fixes: 74a26af ("amd/common/gfx10: add register JSON") Signed-off-by: Mauro Rossi --- src/amd/Android.common.mk | 34 ++ 1 file changed, 26 insert

[Mesa-dev] [PATCH 3/3] android: amd/addrlib: add gfx10 support

2019-07-06 Thread Mauro Rossi
Fix the following building error: external/mesa/src/amd/addrlib/src/gfx10/gfx10addrlib.cpp:35:10: fatal error: 'gfx10_gb_reg.h' file not found ^~~~ 1 error generated. Fixes: 78cdf9a ("amd/addrlib: add gfx10 support") Signed-off-by: Mauro

[Mesa-dev] [PATCH 1/3] android: radeonsi/gfx10: generate gfx10_format_table.h (v2)

2019-07-06 Thread Mauro Rossi
~~ 1 error generated. Fixes: 0ffa229 ("radeonsi/gfx10: generate gfx10_format_table.h") Signed-off-by: Mauro Rossi --- src/gallium/drivers/radeonsi/Android.mk | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/drivers/radeonsi/Android.mk b/src/gallium/drivers

Re: [Mesa-dev] [PATCH] android: radeonsi/gfx10: generate gfx10_format_table.h

2019-07-06 Thread Mauro Rossi
Hi, there are more issues to resove with gfx10 new code, this patch does not suffice. I am sending a separate series with updated patches. I added Nicolai and Marek because some of their commits need those fixes. Please follow the new thread Mauro On Sat, Jul 6, 2019 at 4:01 PM Mauro Rossi

[Mesa-dev] [PATCH] android: radeonsi/gfx10: generate gfx10_format_table.h

2019-07-06 Thread Mauro Rossi
Fix Android building rules for gfx10_format_table.h generated header Fixes: 0ffa229 ("radeonsi/gfx10: generate gfx10_format_table.h") Signed-off-by: Mauro Rossi --- src/gallium/drivers/radeonsi/Android.mk | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/galli

Re: [Mesa-dev] [PATCH] android: virgl: fix libmesa_virgil_common build and dependencies

2019-06-29 Thread Mauro Rossi
Hi, On Tue, Jun 25, 2019 at 12:07 PM Chih-Wei Huang wrote: > Mauro Rossi 於 2019年6月25日 週二 下午5:52寫道: > > > > Hi, > > > > On Mon, Jun 24, 2019 at 8:55 AM Chih-Wei Huang > wrote: > >> > >> Mauro Rossi 於 2019年6月15日 週六 下午1:39寫道: > >> >

Re: [Mesa-dev] [PATCH] android: virgl: fix generated virgl_driinfo.h building rules

2019-06-25 Thread Mauro Rossi
Hi Chih-Wei, On Mon, Jun 24, 2019 at 7:26 AM Chih-Wei Huang wrote: > Mauro Rossi 於 2019年6月22日 週六 上午2:06寫道: > > > > Changelog in Android makefile: > > - Add LOCAL_MODULE_CLASS, intermediates and LOCAL_GENERATED_SOURCES > > - Use LOCAL_EXPORT_C_INCLUDE_DIRS to e

Re: [Mesa-dev] [PATCH] android: virgl: fix libmesa_virgil_common build and dependencies

2019-06-25 Thread Mauro Rossi
Hi, On Mon, Jun 24, 2019 at 8:55 AM Chih-Wei Huang wrote: > Mauro Rossi 於 2019年6月15日 週六 下午1:39寫道: > > > > Fixes the following building errors and resolves Bug 110922 > > Fixes gallium_dri target missing symbols at linking. > > > > external/mesa/src/ga

[Mesa-dev] [PATCH] android: virgl: fix generated virgl_driinfo.h building rules

2019-06-21 Thread Mauro Rossi
Fixes: cf800998a ("virgl: Add driinfo file and tie it into the build") Signed-off-by: Mauro Rossi --- src/gallium/drivers/virgl/Android.mk | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/virgl/Android.mk b/src/gallium/drivers/virgl

Re: [Mesa-dev] [PATCH] android: virgl: fix libmesa_virgil_common build and dependencies

2019-06-14 Thread Mauro Rossi
Hi, there is a typo in the commit title, the library is libmesa_winsys_virgl_common I will correct it in the final commit Mauro On Sat, Jun 15, 2019 at 7:39 AM Mauro Rossi wrote: > Fixes the following building errors and resolves Bug 110922 > Fixes gallium_dri target missing symbols at l

[Mesa-dev] [PATCH] android: virgl: fix libmesa_virgil_common build and dependencies

2019-06-14 Thread Mauro Rossi
es: b18f09a ("virgl: Introduce virgl_resource_cache") Signed-off-by: Mauro Rossi --- src/gallium/Android.mk| 2 +- src/gallium/drivers/virgl/Android.mk | 2 +- src/gallium/winsys/virgl/drm/Android.mk | 2 ++ src/gallium/winsys/virgl/vtest/Android.mk | 2 ++ 4 files changed, 6 i

[Mesa-dev] [PATCH] android: winsys/amdgpu, radv: fix generated amdgfxregs.h header dependecies

2019-06-14 Thread Mauro Rossi
on path in includes Fixes: f480b8a ("amd/common: use generated register header") Signed-off-by: Mauro Rossi --- src/amd/Android.common.mk| 3 ++- src/amd/vulkan/Android.mk| 2 +- src/gallium/winsys/amdgpu/drm/Android.mk | 2 +- 3 files changed, 4 insert

Re: [Mesa-dev] [PATCH] android: radv: fix necessary dependecies

2019-06-08 Thread Mauro Rossi
Hi, please provide Reviewed-by when possible There is another patch sent to ML which his already reviewed by Tapani and waiting for this one Mauro On Wed, Apr 24, 2019 at 3:44 PM Mauro Rossi wrote: > Fixes building errors due to missing libmesa_util generated files include > and li

[Mesa-dev] [PATCH] android: amd/common: fix missing include path

2019-05-05 Thread Mauro Rossi
/compiler/nir_types.h:36: external/mesa/src/compiler/glsl_types.h:37:10: fatal error: 'main/config.h' file not found ^~~ 1 error generated. Fixes: bd4c661 ("ac,ac/nir: use a better sync scope for shared atomics") Signed-off-by: Mauro Rossi --- src/amd/Androi

[Mesa-dev] [PATCH] android: radv: fix necessary dependecies

2019-04-24 Thread Mauro Rossi
ode 1 (use -v to see invocation) Fixes: 3c2e826 ("radv: Add support for driconf.") Signed-off-by: Mauro Rossi --- src/amd/vulkan/Android.mk | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk index 9574bf54e5..a

Re: [Mesa-dev] [PATCH] android: fix LLVM version string related building errors

2019-04-13 Thread Mauro Rossi
Hi, On Sat, Apr 13, 2019 at 6:32 PM Eric Engestrom wrote: > > On 2019-04-13 at 01:36, Mauro Rossi wrote: > > Just a message to Eric, > > > > as per our previous private thread, > > Sorry, I completely forgot to actually send the fix :facepalm: No problem &

[Mesa-dev] [PATCH] draw: fix building error in draw_gs_init()

2019-04-13 Thread Mauro Rossi
ersion] if (!draw->gs.tgsi.machine->Primitives[i] || !draw->gs.tgsi.machine->PrimitiveOffsets) ^~~~ 1 error generated. Fixes: 7720ce3 ("draw: add support to tgsi paths for geometry streams.

Re: [Mesa-dev] [PATCH] android: fix LLVM version string related building errors

2019-04-12 Thread Mauro Rossi
t touching Android.mk solves the problem for me Mauro On Sat, Apr 13, 2019 at 1:27 AM Mauro Rossi wrote: > > Fixes the following building errors: > > external/mesa/src/gallium/drivers/r600/r600_pipe_common.c:1290:14: > error: expected ')' >

[Mesa-dev] [PATCH] android: fix LLVM version string related building errors

2019-04-12 Thread Mauro Rossi
nal/mesa/src/gallium/drivers/r600/r600_pipe_common.c:1287:10: note: to match this '(' snprintf(rscreen->renderer_string, sizeof(rscreen->renderer_string), ^ 1 error generated. Fixes: 05b114e ("simplify LLVM version string printing") Signed-off-by

Re: [Mesa-dev] [PATCH] android: nouveau: add support for nir

2019-03-17 Thread Mauro Rossi
Hi Karol, On Sun, Mar 17, 2019 at 11:25 PM Karol Herbst wrote: > > On Sun, Mar 17, 2019 at 10:52 PM Mauro Rossi wrote: > > > > Add the necessary build rules for android, to avoid building errors. > > > > Fixes: f014ae3 ("nouveau: add support for n

[Mesa-dev] [PATCH] android: nouveau: add support for nir

2019-03-17 Thread Mauro Rossi
Add the necessary build rules for android, to avoid building errors. Fixes: f014ae3 ("nouveau: add support for nir") Signed-off-by: Mauro Rossi --- src/gallium/drivers/nouveau/Android.mk | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/drive

Re: [Mesa-dev] Building error in android-x86 due to recent mesa commit

2019-03-16 Thread Mauro Rossi
Hi Bas, many thanks Mauro On Sat, Mar 16, 2019 at 11:02 PM Bas Nieuwenhuizen wrote: > > Should be fixed when > > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/456 > > is merged. > > On Sat, Mar 16, 2019 at 10:16 PM Mauro Rossi wrote: > > > > Hi Mare

[Mesa-dev] Building error in android-x86 due to recent mesa commit

2019-03-16 Thread Mauro Rossi
Hi Marek, I'm getting the following building error after commit [1] but I don't understand why. Mauro external/mesa/src/gallium/drivers/radeonsi/si_compute.c:807:8: error: initializing 'uint *' (aka 'unsigned int *') with an expression of type 'uint const[3]' discards qualifiers [-Werror,-Wincom

Re: [Mesa-dev] [PATCH] android, autotools: st/mesa: fix location of float64_glsl.h

2019-03-10 Thread Mauro Rossi
Hi Jordan, On Wed, Mar 6, 2019 at 10:01 PM Jordan Justen wrote: > > On 2019-03-04 16:11:33, Jordan Justen wrote: > > On 2019-03-04 15:21:26, Mauro Rossi wrote: > > > Hi, > > > On Mon, Mar 4, 2019 at 7:50 PM Mauro Rossi wrote: > > > > > > >

Re: [Mesa-dev] [PATCH] android, autotools: st/mesa: fix location of float64_glsl.h

2019-03-04 Thread Mauro Rossi
Hi, On Mon, Mar 4, 2019 at 7:50 PM Mauro Rossi wrote: > > Hi, > Sounds good to me. > > The way it could have been prevented was to avoid having fp64 generated file > as the only one with with different path in sources. > > Could you just confirm that inc_compiler is n

Re: [Mesa-dev] [PATCH] android, autotools: st/mesa: fix location of float64_glsl.h

2019-03-04 Thread Mauro Rossi
tried to build with meson and it's ok Il lun 4 mar 2019, 18:59 Dylan Baker ha scritto: > Quoting Mauro Rossi (2019-03-04 01:21:05) > > Hi Tapani, > > On Mon, Mar 4, 2019 at 6:51 AM Tapani Pälli > wrote: > > > > > > Hi; > > > > > > O

[Mesa-dev] [PATCH] android: anv: fix generated files depedencies (v2)

2019-03-04 Thread Mauro Rossi
$(VULKAN_API_XML) reference Fixes: 9a508b7 ("android: anv/extensions: fix generated sources build") Fixes: dd088d4bec7 ("anv/extensions: Generate a header file with extension tables") Signed-off-by: Mauro Rossi Cc: "19.0" --- src/intel/Android.vulkan.mk | 40 +++

Re: [Mesa-dev] [PATCH] android, autotools: st/mesa: fix location of float64_glsl.h

2019-03-04 Thread Mauro Rossi
Hi Tapani, On Mon, Mar 4, 2019 at 6:51 AM Tapani Pälli wrote: > > Hi; > > On 3/3/19 10:10 PM, Mauro Rossi wrote: > > Necessary to avoid building error in Android, > > due to 'compiler/glsl/float64_glsl.h' file not found > > > > Fixes: cb4e3e3 ("s

[Mesa-dev] [PATCH] android, autotools: st/mesa: fix location of float64_glsl.h

2019-03-03 Thread Mauro Rossi
Necessary to avoid building error in Android, due to 'compiler/glsl/float64_glsl.h' file not found Fixes: cb4e3e3 ("st/mesa: add support for lowering fp64/int64 for nir drivers") Signed-off-by: Mauro Rossi --- src/mesa/Android.libmesa_st_mesa.mk | 1 + src/m

[Mesa-dev] [PATCH 1/2] android: anv: fix generated files depedencies

2019-03-03 Thread Mauro Rossi
: anv/extensions: fix generated sources build") Fixes: dd088d4bec7 ("anv/extensions: Generate a header file with extension tables") Signed-off-by: Mauro Rossi Cc: "19.0" --- src/intel/Android.vulkan.mk | 38 +++-- 1 file changed, 24 insert

[Mesa-dev] [PATCH 2/2] android: anv: fix libexpat shared dependency

2019-03-03 Thread Mauro Rossi
Fixes undefined reference building errors for XML_* functions Signed-off-by: Mauro Rossi Cc: "19.0" --- src/intel/Android.vulkan.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/Android.vulkan.mk b/src/intel/Android.vulkan.mk index 2e99ac6294..c9bce50

[Mesa-dev] [PATCH] android: intel/isl: remove redundant building rules

2019-02-21 Thread Mauro Rossi
.ninja] Error 1 ISL_TILED_MEMCPY_FILES is isl/isl_tiled_memcpy_normal.c and that source file includes isl_tiled_memcpy.c source Fixes: 96bb328 ("iris: add Android build") Signed-off-by: Mauro Rossi --- src/intel/Android.isl.mk | 13 - 1 file changed, 13 deletions(-) diff -

Re: [Mesa-dev] [PATCH 1/3] android: glsl: fix fp64 generated source path

2019-02-02 Thread Mauro Rossi
Hi, sorry I just saw that there is a similar correction is already in both 19.0 and master branches but I missed it because I searched only in mesa-dev ML Please Dylan, just check if the 3rd patch makes sense or not necessary at all. Mauro On Sat, Feb 2, 2019 at 11:30 AM Mauro Rossi wrote

[Mesa-dev] [PATCH 2/3] i965: fix glsl/float64_glsl.h include

2019-02-02 Thread Mauro Rossi
in builddir is added accordingly Signed-off-by: Mauro Rossi Fixes: 7d7b308 ("automake: Fix path to generated source") Fixes: b63a1f8 ("glsl: Create file to contain software fp64 functions") Cc: 19.0 --- src/mesa/drivers/dri/i965/Makefile.am | 1 + src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 3/3] meson: i965: add inc_compiler include

2019-02-02 Thread Mauro Rossi
With new glsl/float64_glsl.h include, required in i965 source to correctly build Android and with automake, inc_compiler is added in meson build includes. It may not be necessary for meson, but it is formally correct Signed-off-by: Mauro Rossi Fixes: 7d7b308 ("automake: Fix path to gene

[Mesa-dev] [PATCH 1/3] android: glsl: fix fp64 generated source path

2019-02-02 Thread Mauro Rossi
a_glsl_intermediates/glsl/float64_glsl.h', missing and no known rule to make it Signed-off-by: Mauro Rossi Fixes: 7d7b308 ("automake: Fix path to generated source") Fixes: b63a1f8 ("glsl: Create file to contain software fp64 functions") Cc: 19.0 --- src/compiler/Andro

[Mesa-dev] [PATCH] android: st/mesa: fix building error due to sched_getcpu()

2018-11-30 Thread Mauro Rossi
app thread is") Signed-off-by: Mauro Rossi --- src/mesa/state_tracker/st_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c index 5910ffa5bd..9600b1569d 100644 --- a/src/mesa/state_tracker/st_draw.c +++

[Mesa-dev] [PATCH] android: amd/addrlib: update Mesa's copy of addrlib

2018-11-30 Thread Mauro Rossi
Needed to fix build error in addrlib in mesa for Android Fixes: 776b911 ("amd/addrlib: update Mesa's copy of addrlib") Signed-off-by: Mauro Rossi --- src/amd/Android.addrlib.mk | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/amd/Android.addrl

Re: [Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-11-02 Thread Mauro Rossi
Hi all, could somebody provide Reviewed-by in order to apply in mesa-dev and avoid trivial building error? Thanks Mauro On Tue, Oct 30, 2018 at 10:42 PM Mauro Rossi wrote: > > libmesa_git_sha1 whole static dependency is added to get git_sha1.h header > and avoid following build

[Mesa-dev] [PATCH] android: gallium/auxiliary: add include to get u_debug.h header

2018-10-31 Thread Mauro Rossi
uot;util: Move u_debug to utils") Signed-off-by: Mauro Rossi --- src/gallium/auxiliary/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/Android.mk b/src/gallium/auxiliary/Android.mk index acd243b834..7618c6fcd9 100644 --- a/src/gallium/

[Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-10-30 Thread Mauro Rossi
Add support for VK_KHR_driver_properties.") Signed-off-by: Mauro Rossi --- src/amd/vulkan/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk index 51b03561fa..9574bf54e5 100644 --- a/src/amd/vulkan/Android.mk +++ b/src/amd/vulkan

[Mesa-dev] [PATCH] android: i965/tiled_memcpy: fix build for x86 generic target

2018-10-29 Thread Mauro Rossi
'long long' values) with an expression of incompatible type 'int' __m128i val3 = _mm_stream_load_si128(((__m128i *)src) + 3); ^ ~~~~~~~ 5 errors generated. Fixes: 11b1afdc92 ("i965/tiled_memcpy: inline movntdqa loads in tiled_to_linear")

Re: [Mesa-dev] [PATCH v3] egl/android: rework device probing

2018-09-10 Thread Mauro Rossi
> v3: > - add forward declaration for droid_load_driver() > Fixes the HAVE_DRM_GRALLOC build (Mauro) > - split dup() assignment and check in separate lines (Tomasz, Eric) > - make droid_load_driver() static (Tomasz) > - drop unused prop_set variable (Tomasz) > > Cc: Robert F

Re: [Mesa-dev] [PATCH] android: util/u_thread: fix building error with bionic pthread

2018-09-10 Thread Mauro Rossi
Hi, Il giorno lun 10 set 2018 alle ore 09:58 Tapani Pälli ha scritto: > > Marek sent a similar fix here: > https://lists.freedesktop.org/archives/mesa-dev/2018-September/204797.html Thanks a lot! So the APU L3 cache optimization will be lost for Android > > On 09/10/2018 10:52

[Mesa-dev] [PATCH] android: util/u_thread: fix building error with bionic pthread

2018-09-10 Thread Mauro Rossi
This patch is to tackle with shortcomings in Android bionic libc. Even if setting cflag -D__USE__GNU and adding include of cpuset macros may become available, bionic libc does not support pthread_{g,s}etaffinity_np() Wrappers to sched_{g,s]etaffinity() were found to here: www.spinics.net/lists/

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] android: broadcom/genxml: fix collision with intel/genxml header-gen macro

2018-09-09 Thread Mauro Rossi
Hi, Il giorno gio 6 set 2018 alle ore 18:20 Dylan Baker ha scritto: > > Quoting Rob Herring (2018-09-06 07:16:07) > > On Mon, Sep 3, 2018 at 4:27 PM Eric Anholt wrote: > > > > > > Mauro Rossi writes: > > > > > > > Fixes the following

[Mesa-dev] [PATCH 1/3] android: broadcom/genxml: fix collision with intel/genxml header-gen macro

2018-08-26 Thread Mauro Rossi
troduce XML-based packet header generation like Intel's.") Cc: "18.2" Signed-off-by: Mauro Rossi --- src/broadcom/Android.genxml.mk | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/broadcom/Android.genxml.mk b/src/broadcom/Android.genxml.mk ind

[Mesa-dev] [PATCH 3/3] android: broadcom/cle: export the broadcom top level path headers

2018-08-26 Thread Mauro Rossi
: 'cle/v3d_packet_helpers.h' file not found ^~ 1 error generated. Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.") Cc: "18.2" Signed-off-by: Mauro Rossi --- src/broadcom/Android.cle.mk | 2 ++ 1 file

[Mesa-dev] [PATCH 2/3] android: broadcom/cle: add gallium include path

2018-08-26 Thread Mauro Rossi
not found ^~~ 1 error generated. Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.") Cc: "18.2" Signed-off-by: Mauro Rossi --- src/broadcom/Android.cle.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/broadcom

Re: [Mesa-dev] [PATCH] egl/android: do not indent HAVE_DRM_GRALLOC preprocessor directive

2018-08-24 Thread Mauro Rossi
Hi, Il giorno mer 15 ago 2018 alle ore 15:13 Mauro Rossi ha scritto: > > Fixes: 3f7bca44d9 ("egl/android: #ifdef out flink name support") > Fixes: c7bb82136b ("egl/android: Add DRM node probing and filtering") > Signed-off-by: Mauro Rossi > --- > src/e

[Mesa-dev] [PATCH] egl/android: do not indent HAVE_DRM_GRALLOC preprocessor directive

2018-08-15 Thread Mauro Rossi
Fixes: 3f7bca44d9 ("egl/android: #ifdef out flink name support") Fixes: c7bb82136b ("egl/android: Add DRM node probing and filtering") Signed-off-by: Mauro Rossi --- src/egl/drivers/dri2/platform_android.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --g

Re: [Mesa-dev] [PATCH] radv/meta_decompress: fix pointer to integer conversion

2018-08-15 Thread Mauro Rossi
Hi Bas, Il giorno mar 14 ago 2018 alle ore 23:10 Bas Nieuwenhuizen < b...@basnieuwenhuizen.nl> ha scritto: > On Tue, Aug 14, 2018 at 10:48 PM, Mauro Rossi > wrote: > > (VkShaderModule) cast is added before NULL to avoid following building > error: > > >

Re: [Mesa-dev] [PATCH 1/2] egl/android: fix regression in drm_gralloc path

2018-08-15 Thread Mauro Rossi
Hi Emil, Il Mer 15 Ago 2018, 13:16 Emil Velikov ha scritto: > On 15 August 2018 at 09:13, Mauro Rossi wrote: > > Hi Robert, > > Il giorno mer 15 ago 2018 alle ore 09:37 Robert Foss > > ha scritto: > >> > >> Hey Mauro, > >> > >> Thank

Re: [Mesa-dev] [PATCH 1/2] egl/android: fix regression in drm_gralloc path

2018-08-15 Thread Mauro Rossi
Hi Robert, Il giorno mer 15 ago 2018 alle ore 09:37 Robert Foss < robert.f...@collabora.com> ha scritto: > Hey Mauro, > > Thanks for catching this. > > On 14/08/2018 22.27, Mauro Rossi wrote: > > This patch fixes a regression in mesa 18.2 and mesa-dev branches > &g

[Mesa-dev] [PATCH] radv/meta_decompress: fix pointer to integer conversion

2018-08-14 Thread Mauro Rossi
ixes: fbcd167314 ("radv: Add on-demand compilation of built-in shaders.") Signed-off-by: Mauro Rossi --- src/amd/vulkan/radv_meta_decompress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_meta_decompress.c b/src/amd/vulkan/radv_meta_decomp

Re: [Mesa-dev] [PATCH 1/2] egl/android: fix regression in drm_gralloc path

2018-08-14 Thread Mauro Rossi
2018 alle ore 22:27 Mauro Rossi ha scritto: > This patch fixes a regression in mesa 18.2 and mesa-dev branches > for HAVE_DRM_GRALLOC code path which is causing black screen on Android > and prevents boot due to SIGSEGV MAPERR crash related to unproper handling > of drm_gralloc d

[Mesa-dev] [PATCH 1/2] egl/android: fix regression in drm_gralloc path

2018-08-14 Thread Mauro Rossi
, I've tested build with hwc too. Fixes: c7bb82136b ("egl/android: Add DRM node probing and filtering") Cc: "18.2" Signed-off-by: Mauro Rossi --- src/egl/drivers/dri2/platform_android.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/e

Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-03 Thread Mauro Rossi
Hi Rob, Il giorno gio 2 ago 2018 alle ore 22:33 Rob Herring ha scritto: > On Thu, Aug 2, 2018 at 12:47 AM Mauro Rossi wrote: > > > > Hi, > > > > Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz < > john.stu...@linaro.org> ha scritto: > >> > &g

[Mesa-dev] [PATCH] android: radv: build vulkan.radv conditionally to radeonsi

2018-08-02 Thread Mauro Rossi
Reported-by: John Stultz Signed-off-by: Mauro Rossi Cc: "18.2" --- src/amd/Android.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/Android.mk b/src/amd/Android.mk index 6129e360cb..e40e7da01b 100644 --- a/src/amd/Android.mk +++ b/src/amd/Android.mk @@ -27,4 +27,6 @@

Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-02 Thread Mauro Rossi
Hi, Il giorno gio 2 ago 2018 alle ore 17:51 Emil Velikov < emil.l.veli...@gmail.com> ha scritto: > On 2 August 2018 at 07:47, Mauro Rossi wrote: > > Hi, > > > > Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz < > john.stu...@linaro.org> > > ha s

Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-01 Thread Mauro Rossi
Hi, Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz ha scritto: > Just as a heads up, with mesa3d master (plus my other build fixups I > just sent out), I'm seeing a new build failure when building under > AOSP/master: > > external/mesa3d/src/amd/vulkan/Android.mk: error: vulkan.radv > (SHAR

Re: [Mesa-dev] [PATCH 3/4] android: radv: add Android.mk for vulkan.radv HAL module

2018-07-26 Thread Mauro Rossi
Hello there, Il giorno gio 26 lug 2018 alle ore 17:09 Mauro Rossi ha scritto: > > Hi Emil, > > Il giorno gio 26 lug 2018 alle ore 16:48 Emil Velikov > ha scritto: > > > > On 22 July 2018 at 09:14, Mauro Rossi wrote: > > > radv implements the Android V

Re: [Mesa-dev] [PATCH 3/4] android: radv: add Android.mk for vulkan.radv HAL module

2018-07-26 Thread Mauro Rossi
Hi Emil, Il giorno gio 26 lug 2018 alle ore 16:48 Emil Velikov ha scritto: > > On 22 July 2018 at 09:14, Mauro Rossi wrote: > > radv implements the Android Vulkan HAL interface, this patch adds > > Android.mk building rules by porting of radv automake rules. > > vendor

[Mesa-dev] [PATCH 3/4] android: radv: add Android.mk for vulkan.radv HAL module

2018-07-22 Thread Mauro Rossi
radv implements the Android Vulkan HAL interface, this patch adds Android.mk building rules by porting of radv automake rules. vendor HAL module is installed as /vendor/lib/hw/vulkan.radv.so Signed-off-by: Mauro Rossi --- src/amd/vulkan/Android.mk | 166 ++ 1

[Mesa-dev] android: add support for vulkan radv

2018-07-22 Thread Mauro Rossi
vm70 branch (used to build libLLVM70 shared library): https://github.com/maurossi/llvm/tree/oreo-x86_llvm70_test Thanks to Chih-Wei Huang, Qiang Yu, Tapani P lli , Emil Velikov, Robert Foss, Rob Herring and Tomasz Figa for continuous help and support. Signed

[Mesa-dev] [PATCH 1/4] radv: move vk_format_table.c to generated sources

2018-07-22 Thread Mauro Rossi
Android build system will try to compile vk_format_table.c as a shipped source, but at compile time it will be missing, we move it to generated source, where it belongs Signed-off-by: Mauro Rossi --- src/amd/vulkan/Makefile.sources | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 2/4] radv: generate entrypoints for VK_ANDROID_native_buffer

2018-07-22 Thread Mauro Rossi
Patch changes radv entrypoints generator to not skip this extension even though it is set as disabled in the vk.xml Reference: 63525ba730 ("android: enable VK_ANDROID_native_buffer") Fixes: 69f447553c ("vulkan: Drop vk_android_native_buffer.xml") Signed-off-by: Mauro Rossi

[Mesa-dev] [PATCH 4/4] android: radv: enable build of vulkan.radv HAL module

2018-07-22 Thread Mauro Rossi
src/amd/Android.mk requires to include src/amd/vulkan/Android.mk to enable the build of vulkan.radv module Signed-off-by: Mauro Rossi --- src/amd/Android.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/Android.mk b/src/amd/Android.mk index 07af05287f..6129e360cb 100644 --- a/src

[Mesa-dev] [PATCH] android: util/disk_cache: fix building errors in gallium drivers

2018-07-21 Thread Mauro Rossi
9 [-Werror,-Wimplicit-function-declaration] if (disk_cache_get_function_timestamp(nouveau_disk_cache_create, ^ 1 error generated. Fixes: cc10b34 ("util/disk_cache: Fix disk_cache_get_function_timestamp with disabled cache.") Signed-off-by: Mauro Rossi --- Android.common.mk | 2 +

Re: [Mesa-dev] [PATCH] radv: winsys/amdgpu: include missing pthread.h header

2018-07-13 Thread Mauro Rossi
pposed to do something, please let me know. Mauro > > On Mon, Jul 2, 2018 at 1:25 AM, Mauro Rossi wrote: > > pthread types are used in some files without explicitely including > pthread.h. > > This leads to compile errors on Android 7.x nougat-x86 > > e.g. in src/amd/vulkan/w

Re: [Mesa-dev] [PATCH v1 0/3] Android kms_swrast support

2018-07-09 Thread Mauro Rossi
Hi Robert, Il giorno lun 9 lug 2018 alle ore 13:01 Robert Foss < robert.f...@collabora.com> ha scritto: > > NOTE: This series has not been tested successfully, and I'm seeing a > segfault > during the boot process. Which I'm currently looking into. > What is your testing setup (hwcomposer

[Mesa-dev] [PATCH] radv: winsys/amdgpu: include missing pthread.h header

2018-07-01 Thread Mauro Rossi
solves the building error Signed-off-by: Mauro Rossi --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h index d6af6052a6..40d35d557b 100644

Re: [Mesa-dev] RFC about anv change that should be applicable to radv

2018-06-27 Thread Mauro Rossi
Hi, Il giorno mer 27 giu 2018 alle ore 10:41 Tapani Pälli < tapani.pa...@intel.com> ha scritto: > Hi; > > On 06/13/2018 09:32 AM, Mauro Rossi wrote: > > +Samuel Pitoiset > > > > > > 2018-06-11 22:31 GMT+02:00 Mauro Rossi > <mailto:issor.or...@gmail.

Re: [Mesa-dev] RFC about anv change that should be applicable to radv

2018-06-12 Thread Mauro Rossi
+Samuel Pitoiset 2018-06-11 22:31 GMT+02:00 Mauro Rossi : > Hi Bas, > > commit [1] removed a check on 'supported' attribute in > src/intel/vulkan/anv_entrypoints_gen.py > > Should the check on 'supported' attribute be removed also in > src/amd/vulkan

[Mesa-dev] RFC about anv change that should be applicable to radv

2018-06-11 Thread Mauro Rossi
Hi Bas, commit [1] removed a check on 'supported' attribute in src/intel/vulkan/anv_entrypoints_gen.py Should the check on 'supported' attribute be removed also in src/amd/vulkan/radv_entrypoints_gen.py ? Thanks for your feedback Mauro [1] https://cgit.freedesktop.org/mesa/mesa/commit/?id=6352

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Mauro Rossi
Hi, 2018-06-04 0:31 GMT+02:00 Lionel Landwerlin : > On 03/06/18 21:22, Mauro Rossi wrote: > > Hi there, > > 2018-06-03 21:52 GMT+02:00 Lionel Landwerlin < > lionel.g.landwer...@intel.com>: > >> On 03/06/18 19:41, Mauro Rossi wrote: >> >>> Change to

[Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-03 Thread Mauro Rossi
^ 1 error generated. (v2) Set the correct bo_flags based on support of 48bit addresses and soft-pin Fixes: b0d50247a7 ("anv/allocator: Set the BO flags in bo_cache_alloc/import") Fixes: e7d0378bd9 ("anv: Soft-pin client-allocated memory") Signed-off-by: Mauro Rossi ---

[Mesa-dev] [PATCH] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-03 Thread Mauro Rossi
^ 1 error generated. (v2) Set the correct bo_flags based on support of 48bit addresses and soft-pin Fixes: b0d50247a7 ("anv/allocator: Set the BO flags in bo_cache_alloc/import") Fixes: e7d0378bd9 ("anv: Soft-pin client-allocated memory") Signed-off-by: Mauro Rossi ---

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Mauro Rossi
Hi there, 2018-06-03 21:52 GMT+02:00 Lionel Landwerlin : > On 03/06/18 19:41, Mauro Rossi wrote: > >> Change to avoid building error: >> >> external/mesa/src/intel/vulkan/anv_android.c:131:72: >> error: too few arguments to function call, expected 5, have 4 >&

  1   2   3   4   >