[Mesa-dev] [PATCH piglit] egl_khr_create_context: Proper invalid attributes for EGL 1.5

is lower than 1.5 before checking EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR is an invalid attribute. Signed-off-by: Miguel A Vico Moya --- .../egl/spec/egl_khr_create_context/common.c | 5 ++-- .../egl/spec/egl_khr_create_context/common.h | 8 +++ .../invalid-attribute-gles.c

Re: [Mesa-dev] [PATCH 1/2] nouveau: Add basic memory object support

On Fri, 22 Jun 2018 20:37:19 -0400 Ilia Mirkin wrote: > On Fri, Jun 22, 2018 at 8:22 PM, Miguel Angel Vico > wrote: > > > > > > On Thu, 21 Jun 2018 22:09:14 -0400 > > Ilia Mirkin wrote: > > > >> Hi Miguel, > >> > >> Pr

Re: [Mesa-dev] [PATCH 1/2] nouveau: Add basic memory object support

On Thu, 21 Jun 2018 22:09:14 -0400 Ilia Mirkin wrote: > Hi Miguel, > > Preface: I know little about this ext, so feel free to educate me on > the wrongness of my thinking. > > On Thu, Jun 21, 2018 at 10:01 PM, Miguel A. Vico wrote: > > Add memory object s

[Mesa-dev] [PATCH 1/2] nouveau: Add basic memory object support

Add memory object support for nvc0 and nv50 Signed-off-by: Miguel A Vico Moya --- .../drivers/nouveau/nv50/nv50_miptree.c | 49 + .../drivers/nouveau/nv50/nv50_resource.c | 52 +++ .../drivers/nouveau/nv50/nv50_resource.h | 33

[Mesa-dev] [PATCH 2/2] nouveau: Enable support for EXT_external_objects

Enable EXT_external_objects for nvc0 and nv50 Signed-off-by: Miguel A Vico Moya --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50

[Mesa-dev] [PATCH 0/2] nouveau: Add support for EXT_external_objects

check these changes on Gitlab here: https://gitlab.freedesktop.org/mvicomoya/mesa/tree/wip/EXT_external_objects-nouveau Thanks, Miguel. Miguel A. Vico (2): nouveau: Add basic memory object support nouveau: Enable support for EXT_external_objects src/gallium/drivers/nouveau/nv50

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

the EXT_external_objects nouveau implementation upstream. Should I just send the list of patches as a formal RFR? With respect to Allocator changes, it'd be nice getting someone else's (out of NVIDIA) feedback. Thanks. On Wed, 20 Dec 2017 08:51:51 -0800 Miguel Angel Vico <mvicom...@nvidia.com>

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

(Adding dri-devel back, and trying to respond to some comments from the different forks) James Jones wrote: > Your worst case analysis above isn't far off from our HW, give or take > some bits and axes here and there. We've started an internal discussion > about how to lay out all the bits we

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

t; > On Wed, Dec 20, 2017 at 5:51 PM, Miguel Angel Vico <mvicom...@nvidia.com> > > wrote: > >> Hi all, > >> > >> As many of you already know, I've been working with James Jones on the > >> Generic Device Allocator project lately. He started

[Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

Hi all, As many of you already know, I've been working with James Jones on the Generic Device Allocator project lately. He started a discussion thread some weeks ago seeking feedback on the current prototype of the library and advice on how to move all this forward, from a prototype stage to

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

On Wed, 6 Dec 2017 16:57:45 -0800 James Jones wrote: > On 12/06/2017 03:25 AM, Nicolai Hähnle wrote: > > On 06.12.2017 08:07, James Jones wrote: > > [snip] > >> So lets say you have a setup where both display and GPU supported > >> FOO/tiled, but only GPU

[Mesa-dev] [PATCH] libdrm: Fix QNX build by including 'sys/ioctl.h'

drm.h header includes 'sys/ioccom.h' for ioctl definitions on non-linux Unix platforms, but QNX seems to define those in 'sys/ioctl.h' instead. Signed-off-by: Miguel A Vico Moya <mvicom...@nvidia.com> --- include/drm/drm.h | 5 + 1 file changed, 5 insertions(+) diff --git a/inclu

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

On Fri, 1 Dec 2017 13:38:41 -0500 Rob Clark wrote: > On Fri, Dec 1, 2017 at 12:09 PM, Nicolai Hähnle wrote: > > On 01.12.2017 16:06, Rob Clark wrote: > >> > >> On Thu, Nov 30, 2017 at 5:43 PM, Nicolai Hähnle > >> wrote: > >>> >

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

On Wed, 29 Nov 2017 16:28:15 -0500 Rob Clark <robdcl...@gmail.com> wrote: > On Wed, Nov 29, 2017 at 2:41 PM, Miguel Angel Vico <mvicom...@nvidia.com> > wrote: > > Many of you may already know, but James is going to be out for a few > > weeks and I'll be ta

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

ots of wishy-washy concepts such as "cursor plane" which > may not map well at least not without querying the kernel about specifc > display planes. In particular, I don't want someone to feel like they need > to use $new_thing and GBM at the same time or together. Ideally, I'd

Re: [Mesa-dev] [PATCH 7/7] wayland-egl: rework and simplify wl_egl_window initialization

> Miguel I believe the comment correctly describes the design plan, while > addressing Dan's comment that things look a bit ugly. Yes. Thank you. Also, the whole series: Reviewed-by: Miguel A. Vico <mvicom...@nvidia.com> Thanks. On Fri, 29 Sep 2017 14:48:58 +0100 Danie

Re: [Mesa-dev] XDC 2017 feedback

Hi, In general, I think the organization was great. I agree having everything happen in a single room was a good point. Here's some of my personal feedback: * I didn't like the tables layout at all. I found it to be extremely uncomfortable to have to look sideways in order to see the screens

Re: [Mesa-dev] [PATCH mesa 5/5] wayland-egl: Update ABI checker

On Wed, 19 Jul 2017 12:19:30 +0100 Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 18 July 2017 at 21:49, Miguel A. Vico <mvicom...@nvidia.com> wrote: > > This change updates wayland-egl-abi-check.c with the latest changes to > > wl_egl_window. > > > >

Re: [Mesa-dev] [PATCH mesa 4/5] wayland-egl: Make wl_egl_window a versioned struct

On Wed, 19 Jul 2017 12:06:06 +0100 Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 18 July 2017 at 21:49, Miguel A. Vico <mvicom...@nvidia.com> wrote: > > We need wl_egl_window to be a versioned struct in order to keep track of > > ABI changes. > > >

Re: [Mesa-dev] [PATCH mesa 3/5] egl: Fix _eglPointerIsDereferencable() to ignore page residency

On Wed, 19 Jul 2017 11:43:43 +0100 Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 18 July 2017 at 21:49, Miguel A. Vico <mvicom...@nvidia.com> wrote: > > mincore() returns 0 on success, and -1 on failure. The last parameter > > is a vector of bytes with one

Re: [Mesa-dev] [PATCH mesa 2/5] egl: Move _eglPointerIsDereferencable() to eglglobals.[ch]

On Wed, 19 Jul 2017 11:36:59 +0100 Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 18 July 2017 at 21:49, Miguel A. Vico <mvicom...@nvidia.com> wrote: > > More _eglPointerIsDereferencable() to eglglobals.[ch] and make it a > > non-static function so it can

Re: [Mesa-dev] [PATCH mesa 1/5] wayland-egl: Add wl_egl_window ABI checker

Thanks for all the reviews, Emil. Inline. On Wed, 19 Jul 2017 11:35:04 +0100 Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi Miguel, > > Thanks for looking into this. There's a couple of small nits below but > it overall looks good. > > On 18 July 2017 at 21:49

[Mesa-dev] [PATCH mesa 5/5 v2] wayland-egl: Update ABI checker

This change updates wayland-egl-abi-check.c with the latest changes to wl_egl_window. Signed-off-by: Miguel A. Vico <mvicom...@nvidia.com> Reviewed-by: James Jones <jajo...@nvidia.com> --- .../wayland/wayland-egl/wayland-egl-abi-check.c| 90 ++ 1 file

[Mesa-dev] [PATCH mesa 4/5 v2] wayland-egl: Make wl_egl_window a versioned struct

pointer, it is an old implementation of wl_egl_window, and version points to the wl_surface proxy. - Else, the first field is the version number, and we have wl_egl_window::surface pointing to the wl_surface proxy. Signed-off-by: Miguel A. Vico <mvicom...@nvidia.com> Reviewed-by:

[Mesa-dev] [PATCH mesa 3/5 v2] egl: Fix _eglPointerIsDereferencable() to ignore page residency

is dereferenceable, so the output vector can be ignored. What matters is whether mincore succeeds. See: http://man7.org/linux/man-pages/man2/mincore.2.html Signed-off-by: Miguel A. Vico <mvicom...@nvidia.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- src/egl/main/eglgl

[Mesa-dev] [PATCH mesa 2/5 v2] egl: Move _eglPointerIsDereferencable() to eglglobals.[ch]

Move _eglPointerIsDereferencable() to eglglobals.[ch] and make it a non-static function so it can be used out of egldisplay.c Signed-off-by: Miguel A. Vico <mvicom...@nvidia.com> Reviewed-by: James Jones <jajo...@nvidia.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com>

[Mesa-dev] [PATCH mesa 1/5 v2] wayland-egl: Add wl_egl_window ABI checker

Add a small ABI checker for wl_egl_window so that we can check for backwards incompatible changes at 'make check' time. Signed-off-by: Miguel A. Vico <mvicom...@nvidia.com> Reviewed-by: James Jones <jajo...@nvidia.com> --- src/egl/wayland/wayland-egl/Makefile.am| 6 +-

[Mesa-dev] [PATCH mesa 4/5] wayland-egl: Make wl_egl_window a versioned struct

pointer, it is an old implementation of wl_egl_window, and version points to the wl_surface proxy. - Else, the first field is the version number, and we have wl_egl_window::surface pointing to the wl_surface proxy. Signed-off-by: Miguel A. Vico <mvicom...@nvidia.com> Reviewed-by:

[Mesa-dev] [PATCH mesa 5/5] wayland-egl: Update ABI checker

This change updates wayland-egl-abi-check.c with the latest changes to wl_egl_window. Signed-off-by: Miguel A. Vico <mvicom...@nvidia.com> Reviewed-by: James Jones <jajo...@nvidia.com> --- .../wayland/wayland-egl/wayland-egl-abi-check.c| 78 ++ 1 file

[Mesa-dev] [PATCH mesa 3/5] egl: Fix _eglPointerIsDereferencable() to ignore page residency

is dereferenceable, so the output vector can be ignored. What matters is whether mincore succeeds. See: http://man7.org/linux/man-pages/man2/mincore.2.html Signed-off-by: Miguel A. Vico <mvicom...@nvidia.com> --- src/egl/main/eglglobals.c | 13 - 1 file changed, 12 insertions(+), 1 de

[Mesa-dev] [PATCH mesa 1/5] wayland-egl: Add wl_egl_window ABI checker

Add a small ABI checker for wl_egl_window so that we can check for backwards incompatible changes at 'make check' time. Signed-off-by: Miguel A. Vico <mvicom...@nvidia.com> Reviewed-by: James Jones <jajo...@nvidia.com> --- src/egl/wayland/wayland-egl/Makefile.am| 10 +-

[Mesa-dev] [PATCH mesa 2/5] egl: Move _eglPointerIsDereferencable() to eglglobals.[ch]

More _eglPointerIsDereferencable() to eglglobals.[ch] and make it a non-static function so it can be used out of egldisplay.c Signed-off-by: Miguel A. Vico <mvicom...@nvidia.com> Reviewed-by: James Jones <jajo...@nvidia.com> --- src/egl/main/egldi

[Mesa-dev] [PATCH mesa 0/5] egl/wayland: Make wl_egl_window a versioned struct

Although we've always made backwards compatible changes to wl_egl_window, we are lacking of a versioning mechanism for EGL drivers that take a native wl_egl_window to check what set of features are exposed/available by the given struct. This series of patches aim to make wl_egl_window a versioned