Re: [Mesa-dev] [PATCH 1/2] nouveau: Add basic memory object support

2018-06-25 Thread Miguel Angel Vico
On Fri, 22 Jun 2018 20:37:19 -0400 Ilia Mirkin wrote: > On Fri, Jun 22, 2018 at 8:22 PM, Miguel Angel Vico > wrote: > > > > > > On Thu, 21 Jun 2018 22:09:14 -0400 > > Ilia Mirkin wrote: > > > >> Hi Miguel, > >> > >> Prefa

Re: [Mesa-dev] [PATCH 1/2] nouveau: Add basic memory object support

2018-06-22 Thread Miguel Angel Vico
On Thu, 21 Jun 2018 22:09:14 -0400 Ilia Mirkin wrote: > Hi Miguel, > > Preface: I know little about this ext, so feel free to educate me on > the wrongness of my thinking. > > On Thu, Jun 21, 2018 at 10:01 PM, Miguel A. Vico wrote: > > Add memory object support for nvc0 and nv50 > > > > Sign

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2018-01-16 Thread Miguel Angel Vico
g the EXT_external_objects nouveau implementation upstream. Should I just send the list of patches as a formal RFR? With respect to Allocator changes, it'd be nice getting someone else's (out of NVIDIA) feedback. Thanks. On Wed, 20 Dec 2017 08:51:51 -0800 Miguel Angel Vico wrote: &g

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2017-12-28 Thread Miguel Angel Vico
(Adding dri-devel back, and trying to respond to some comments from the different forks) James Jones wrote: > Your worst case analysis above isn't far off from our HW, give or take > some bits and axes here and there. We've started an internal discussion > about how to lay out all the bits we ne

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2017-12-20 Thread Miguel Angel Vico
Inline. On Wed, 20 Dec 2017 11:54:10 -0800 Kristian Høgsberg wrote: > On Wed, Dec 20, 2017 at 11:51 AM, Daniel Vetter wrote: > > Since this also involves the kernel let's add dri-devel ... Yeah, I forgot. Thanks Daniel! > > > > On Wed, Dec 20, 2017 at 5:51 PM, Mig

[Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2017-12-20 Thread Miguel Angel Vico
Hi all, As many of you already know, I've been working with James Jones on the Generic Device Allocator project lately. He started a discussion thread some weeks ago seeking feedback on the current prototype of the library and advice on how to move all this forward, from a prototype stage to produ

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-12-08 Thread Miguel Angel Vico
On Wed, 6 Dec 2017 16:57:45 -0800 James Jones wrote: > On 12/06/2017 03:25 AM, Nicolai Hähnle wrote: > > On 06.12.2017 08:07, James Jones wrote: > > [snip] > >> So lets say you have a setup where both display and GPU supported > >> FOO/tiled, but only GPU supported compressed (FOO/CC)

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-12-01 Thread Miguel Angel Vico
On Fri, 1 Dec 2017 13:38:41 -0500 Rob Clark wrote: > On Fri, Dec 1, 2017 at 12:09 PM, Nicolai Hähnle wrote: > > On 01.12.2017 16:06, Rob Clark wrote: > >> > >> On Thu, Nov 30, 2017 at 5:43 PM, Nicolai Hähnle > >> wrote: > >>> > >>> Hi, > >>> > >>> I've had a chance to look a bit more clos

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-11-29 Thread Miguel Angel Vico
On Wed, 29 Nov 2017 16:28:15 -0500 Rob Clark wrote: > On Wed, Nov 29, 2017 at 2:41 PM, Miguel Angel Vico > wrote: > > Many of you may already know, but James is going to be out for a few > > weeks and I'll be taking over this in the meantime. > > > > See

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-11-29 Thread Miguel Angel Vico
Many of you may already know, but James is going to be out for a few weeks and I'll be taking over this in the meantime. See inline for comments. On Wed, 29 Nov 2017 09:33:29 -0800 Jason Ekstrand wrote: > On Sat, Nov 25, 2017 at 1:20 PM, Rob Clark wrote: > > > On Sat, Nov 25, 2017 at 12:46 PM

Re: [Mesa-dev] [PATCH 7/7] wayland-egl: rework and simplify wl_egl_window initialization

2017-09-29 Thread Miguel Angel Vico
> Miguel I believe the comment correctly describes the design plan, while > addressing Dan's comment that things look a bit ugly. Yes. Thank you. Also, the whole series: Reviewed-by: Miguel A. Vico Thanks. On Fri, 29 Sep 2017 14:48:58 +0100 Daniel Stone wrote: > On 29 September 2017 at 13:

Re: [Mesa-dev] XDC 2017 feedback

2017-09-27 Thread Miguel Angel Vico
Hi, In general, I think the organization was great. I agree having everything happen in a single room was a good point. Here's some of my personal feedback: * I didn't like the tables layout at all. I found it to be extremely uncomfortable to have to look sideways in order to see the screens

Re: [Mesa-dev] [PATCH mesa 5/5] wayland-egl: Update ABI checker

2017-07-19 Thread Miguel Angel Vico
On Wed, 19 Jul 2017 12:19:30 +0100 Emil Velikov wrote: > On 18 July 2017 at 21:49, Miguel A. Vico wrote: > > This change updates wayland-egl-abi-check.c with the latest changes to > > wl_egl_window. > > > > Signed-off-by: Miguel A. Vico > > Reviewed-by: James Jones > > --- > > .../wayland/w

Re: [Mesa-dev] [PATCH mesa 4/5] wayland-egl: Make wl_egl_window a versioned struct

2017-07-19 Thread Miguel Angel Vico
On Wed, 19 Jul 2017 12:06:06 +0100 Emil Velikov wrote: > On 18 July 2017 at 21:49, Miguel A. Vico wrote: > > We need wl_egl_window to be a versioned struct in order to keep track of > > ABI changes. > > > > This change makes the first member of wl_egl_window the version number. > > > > An heur

Re: [Mesa-dev] [PATCH mesa 3/5] egl: Fix _eglPointerIsDereferencable() to ignore page residency

2017-07-19 Thread Miguel Angel Vico
On Wed, 19 Jul 2017 11:43:43 +0100 Emil Velikov wrote: > On 18 July 2017 at 21:49, Miguel A. Vico wrote: > > mincore() returns 0 on success, and -1 on failure. The last parameter > > is a vector of bytes with one entry for each page queried. mincore > > returns page residency information in

Re: [Mesa-dev] [PATCH mesa 2/5] egl: Move _eglPointerIsDereferencable() to eglglobals.[ch]

2017-07-19 Thread Miguel Angel Vico
On Wed, 19 Jul 2017 11:36:59 +0100 Emil Velikov wrote: > On 18 July 2017 at 21:49, Miguel A. Vico wrote: > > More _eglPointerIsDereferencable() to eglglobals.[ch] and make it a > > non-static function so it can be used out of egldisplay.c > > > s/More/Move/ Done. > > > Signed-off-by: Migu

Re: [Mesa-dev] [PATCH mesa 1/5] wayland-egl: Add wl_egl_window ABI checker

2017-07-19 Thread Miguel Angel Vico
Thanks for all the reviews, Emil. Inline. On Wed, 19 Jul 2017 11:35:04 +0100 Emil Velikov wrote: > Hi Miguel, > > Thanks for looking into this. There's a couple of small nits below but > it overall looks good. > > On 18 July 2017 at 21:49, Miguel A. Vico wrote: > > Add a small ABI checker fo