Re: [Mesa-dev] [PATCH] r600_shader.c: fix indentation

2017-03-22 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Wed, Mar 22, 2017 at 9:28 PM, Julien Isorce <julien.iso...@gmail.com> wrote: > Introduced by ad13bd2e51a5dc01b0f8a0eb927022f0deac0a0c > > Signed-off-by: Julien Isorce <jiso...@oblong.com> > --- > src/g

[Mesa-dev] [PATCH v2] st/va: remove assert for single slice

2017-03-21 Thread Nayan Deshmukh
we anyway allow for multiple slices v2: do not remove assert to check for buf->size Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/picture_mpeg12.c | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Nayan Deshmukh
Can you please push the patch. On Thu, Feb 23, 2017 at 1:46 AM, Marek Olšák <mar...@gmail.com> wrote: > OK sounds good. > > Reviewed-by: Marek Olšák <marek.ol...@amd.com> > > Marek > > On Wed, Feb 22, 2017 at 9:16 PM, Nayan Deshmukh > <nayan26deshm...@gm

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Nayan Deshmukh
On Thu, Feb 23, 2017 at 1:34 AM, Marek Olšák <mar...@gmail.com> wrote: > It would be better to return from the function in that case. > We can still execute it as it will display the video properly though the edges will be a bit jagged but it won't be much noticeable in most cases. Re

[Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/auxiliary/vl/vl_bicubic_filter.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_bicubic_filter.c b/src/gallium/auxiliary/vl/vl_bicubic_filter.c index 5

Re: [Mesa-dev] [PATCH] docs/releasing.html: reword "distro breaking changes" hunk

2017-02-20 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Tue, Feb 21, 2017 at 12:57 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Suggested-by: Eric Engestrom <eric.engest...@imgtec.com> > Si

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-11 Thread Nayan Deshmukh
On Sat, Feb 11, 2017 at 12:00 AM, Andy Furniss <adf.li...@gmail.com> wrote: > Nayan Deshmukh wrote: >> >> Hi Andy, >> >> I am attaching the patches. >> Does it cause any difference in the corruption in this video? >> >> https://drive.go

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-10 Thread Nayan Deshmukh
Hi Andy, I am attaching the patches. Does it cause any difference in the corruption in this video? https://drive.google.com/drive/folders/0BxP5-S1t9VEEbkR4dWhTUFozV2s Regards, Nayan On Fri, Feb 10, 2017 at 11:15 PM, Andy Furniss <adf.li...@gmail.com> wrote: > Nayan Deshm

[Mesa-dev] [PATCH v2] st/va: remove assert for single slice

2017-02-10 Thread Nayan Deshmukh
we anyway allow for multiple slices v2: do not remove assert to check for buf->size Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/va/picture_mpeg12.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_tr

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-10 Thread Nayan Deshmukh
On Fri, Feb 10, 2017 at 5:09 PM, Christian König <deathsim...@vodafone.de> wrote: > Sorry for the delay, as noted in the other mail I was on sick leave for a > while. > > > Am 03.02.2017 um 05:52 schrieb Nayan Deshmukh: >> >> On Thu, Feb 2, 2017 at 3:34 PM, Christi

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-02 Thread Nayan Deshmukh
On Thu, Feb 2, 2017 at 3:34 PM, Christian König <deathsim...@vodafone.de> wrote: > Am 01.02.2017 um 13:59 schrieb Nayan Deshmukh: >> >> we anyway allow for multiple slices >> >> Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> >> --- >>

[Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-01 Thread Nayan Deshmukh
we anyway allow for multiple slices Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/va/picture_mpeg12.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture_mpeg12.c b/src/gallium/state_trackers/va/picture_mp

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-23 Thread Nayan Deshmukh
The patch is Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Mon, Jan 23, 2017 at 7:01 PM, Christian König <deathsim...@vodafone.de> wrote: > Ah, yes of course. If we delay creating the decoder we need to call > begin_frame() again as well. > > Please review

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-21 Thread Nayan Deshmukh
LED; + + context->needs_begin_frame = false; } return vaStatus; -- I am wondering if calling decode_bitstream one at a time for each buffer is similar to calling it with all buffers at once? Cheers, Nayan On Thu, Jan 19, 2017 at 8:36 PM, Andy F

[Mesa-dev] [PATCH v4] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-19 Thread Nayan Deshmukh
copy them to a buffer which is send to X. v2: only send buffers with format VDP_RGBA_FORMAT_B8G8R8A8 v3: reword commit message v4: add comment explaining the code Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/output.c| 7 +++ src/g

[Mesa-dev] [PATCH v3] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-19 Thread Nayan Deshmukh
copy them to a buffer which is send to X. v2: only send buffers with format VDP_RGBA_FORMAT_B8G8R8A8 v3: reword commit message Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/output.c| 2 ++ src/gallium/state_trackers/vdpau/presentation.

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-19 Thread Nayan Deshmukh
On Thu, Jan 19, 2017 at 2:07 PM, Christian König <deathsim...@vodafone.de> wrote: > Am 19.01.2017 um 00:20 schrieb Andy Furniss: >> >> Nayan Deshmukh wrote: >>> >>> On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov <emil.l.veli...@gmail.com> >>&g

[Mesa-dev] [PATCH v2] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-18 Thread Nayan Deshmukh
PresentPixmap only works if the pixmap depth and format matches with the window, otherwise it returns a BadMatch protocol error. For other buffers we copy them to a buffer which is send to X. v2: only send buffers with format VDP_RGBA_FORMAT_B8G8R8A8 Signed-off-by: Nayan Deshmukh <nayan26de

Re: [Mesa-dev] [PATCH] st/vdpau: avoid sending buffers with 10bit channels to X

2017-01-18 Thread Nayan Deshmukh
On Wed, Jan 18, 2017 at 9:21 PM, Michel Dänzer <mic...@daenzer.net> wrote: > On 19/01/17 12:27 AM, Nayan Deshmukh wrote: >> PresentPixmap only works if the pixmap depth matches the window >> depth, otherwise it returns a BadMatch protocol error. >> >> Signed-off

[Mesa-dev] [PATCH] st/vdpau: avoid sending buffers with 10bit channels to X

2017-01-18 Thread Nayan Deshmukh
PresentPixmap only works if the pixmap depth matches the window depth, otherwise it returns a BadMatch protocol error. Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/output.c| 6 ++ src/gallium/state_trackers/vdpau/presentation.

Re: [Mesa-dev] Mesa (master): st/vdpau: use dri3 to directly send the buffer to X(v2)

2017-01-18 Thread Nayan Deshmukh
that commit? Regards, Nayan On Wed, Jan 18, 2017 at 3:26 PM, Michel Dänzer <mic...@daenzer.net> wrote: > On 18/01/17 06:47 PM, Christian König wrote: >> Am 18.01.2017 um 09:25 schrieb Michel Dänzer: >>> On 17/01/17 09:55 PM, Christian König wrote: >>>> Module:

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-17 Thread Nayan Deshmukh
On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 17 January 2017 at 14:55, Nayan Deshmukh <nayan26deshm...@gmail.com> wrote: >> On Tue, Jan 17, 2017 at 6:25 PM, Christian König >> <christian.koe...@amd.com> wrote: >>>

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-17 Thread Nayan Deshmukh
On Tue, Jan 17, 2017 at 6:25 PM, Christian König <christian.koe...@amd.com> wrote: > Hi Nayan, > > I've pushed this patch yesterday and this one just a minute ago. > Thanks for the push. I am planning on sending a similar patch for vaap

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-16 Thread Nayan Deshmukh
Hi Christian, Please push this patch. There are a couple of patches [1] which are not yet reviewed. They are trivial and are tested by Andy. Please have a look at them. Regards, Nayan [1] https://lists.freedesktop.org/archives/mesa-dev/2017-January/140395.html On Fri, Jan 13, 2017 at 11:17 PM

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
On Fri, Jan 13, 2017 at 9:54 PM, Andy Furniss <adf.li...@gmail.com> wrote: > > Nayan Deshmukh wrote: >> >> On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss <adf.li...@gmail.com> wrote: >> >>> Nayan Deshmukh wrote: >>> >>>> Hi Andy, >

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss <adf.li...@gmail.com> wrote: > Nayan Deshmukh wrote: > >> Hi Andy, >> >> Please test this patch for regressions. >> > > Do you have a testcase to show the fix? > > TBH I've not tested gstreamer with mp

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
Hi Andy, Please test this patch for regressions. Cheers, Nayan On Fri, Jan 13, 2017 at 6:45 PM, Nayan Deshmukh <nayan26deshm...@gmail.com> wrote: > If begin_frame is called before setting intra_matrix and > non_intra_matrix it leads to segmentation faults when > vl_mpeg12_de

[Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
If begin_frame is called before setting intra_matrix and non_intra_matrix it leads to segmentation faults when vl_mpeg12_decoder.c is used. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92634 Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_track

[Mesa-dev] [PATCH 2/3] st/vdpau: use dri3 to directly send the buffer to X(v2)

2017-01-11 Thread Nayan Deshmukh
lt;adf.li...@gmail.com> Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/output.c | 2 +- src/gallium/state_trackers/vdpau/presentation.c | 58 ++--- 2 files changed, 33 insertions(+), 27 deletions(-) diff -

[Mesa-dev] [PATCH 3/3] st/vdpau: remove the delayed rendering hack(v1.1)

2017-01-11 Thread Nayan Deshmukh
the hack was introduced to avoid an extra copying but now with dri3 we don't need it anymore v1.1: rebasing Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/bitmap.c| 2 - src/gallium/state_trackers/vdpau/device.c

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
extension for every frame Reviewed and Suggested-by: Leo Liu <leo@amd.com> Acked-by: Christian König <christian.koe...@amd.com> Tested-by: Andy Furniss <adf.li...@gmail.com> Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- configure.ac

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
On Wed, Jan 11, 2017 at 9:25 PM, Andy Furniss <adf.li...@gmail.com> wrote: > Nayan Deshmukh wrote: >> >> Hi Andy, >> >> Can you try this patch? This should help with the tearing. > > > Patch seems to be good - I get page flipping again so DC, modesetting

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
= PIPE_USAGE_DEFAULT; pipe_mutex_lock(dev->mutex); Regards, Nayan On Wed, Jan 11, 2017 at 5:11 PM, Andy Furniss <adf.li...@gmail.com> wrote: > Michel Dänzer wrote: >> >> On 11/01/17 05:13 PM, Nayan Deshmukh wrote: >>> >>> On Wed, Jan 11, 2017 at 1

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
On Wed, Jan 11, 2017 at 12:44 PM, Michel Dänzer <mic...@daenzer.net> wrote: > On 10/01/17 06:53 PM, Nayan Deshmukh wrote: >> On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer <mic...@daenzer.net> wrote: >>> On 06/01/17 05:50 AM, Andy Furniss wrote: >>>> Chr

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Nayan Deshmukh
On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer <mic...@daenzer.net> wrote: > On 06/01/17 05:50 AM, Andy Furniss wrote: >> Christian König wrote: >>> Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: >>>> dri3 allows us to send handle of a texture directly to

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Nayan Deshmukh
On Fri, Jan 6, 2017 at 2:20 AM, Andy Furniss <adf.li...@gmail.com> wrote: > Christian König wrote: >> >> Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: >>> >>> dri3 allows us to send handle of a texture directly to X >>> so this patch allows a sta

[Mesa-dev] [PATCH] st/va: fix incorrect argument in vl_compositor_cleanup

2017-01-05 Thread Nayan Deshmukh
This fixes the mistake introduced in commit b6737a8bcd03ea68952799144c0c6e6e6679bee9 Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/va/context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/con

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-04 Thread Nayan Deshmukh
extension for every frame Suggested-by: Leo Liu <leo@amd.com> Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- configure.ac | 2 +- src/gallium/auxiliary/vl/vl_winsys.h | 5 ++ src/gallium/auxiliary/vl/vl_winsys_

[Mesa-dev] [PATCH 2/3] st/vdpau: use dri3 to direclty send the buffer to X(v1.1)

2017-01-04 Thread Nayan Deshmukh
this avoids an extra copy which occurs in case of dri2 v1.1: fallback to dri2 if dri3 fails to initialize Suggested-by: Christian König <christian.koe...@amd.com> Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/present

[Mesa-dev] [PATCH 3/3] st/vdpau: remove the delayed rendering hack(v1.1)

2017-01-04 Thread Nayan Deshmukh
the hack was introduced to avoid an extra copying but now with dri3 we don't need it anymore v1.1: rebasing Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/bitmap.c| 2 - src/gallium/state_trackers/vdpau/device.c

[Mesa-dev] [PATCH 2/3] st/vdpau: error handling

2017-01-03 Thread Nayan Deshmukh
handle the cases when vl_compositor_set_csc_matrix(), vl_compositor_init_state() and vl_compositor_init() fail Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/vdpau/device.c | 8 +-

[Mesa-dev] [PATCH 1/3] vl/compositor: implement error handling

2017-01-03 Thread Nayan Deshmukh
pipe_buffer_map and pipe_buffer_create may return NULL Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/auxiliary/vl/vl_compositor.c | 13 +++-- src/gallium/auxiliary/vl/vl_compositor.h | 2

[Mesa-dev] [PATCH 3/3] st/va: error handling

2017-01-03 Thread Nayan Deshmukh
handle the cases when vl_compositor_set_csc_matrix(), vl_compositor_init_state() and vl_compositor_init() fail Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- src/gallium/state_trackers/va/context.c | 18 +

[Mesa-dev] [PATCH 0/3] error handling

2017-01-03 Thread Nayan Deshmukh
Hi Christian, Can you please push the patches for me. Regards, Nayan Nayan Deshmukh (3): vl/compositor: implement error handling st/vdpau: error handling st/va: error handling src/gallium/auxiliary/vl/vl_compositor.c | 13 -- src/gallium/auxiliary/vl/vl_compositor.h | 2

Re: [Mesa-dev] [PATCH 1/5] st/xvmc: use goto to make code more readable (v2)

2016-12-22 Thread Nayan Deshmukh
On Thu, Dec 22, 2016 at 4:56 PM, Christian König <deathsim...@vodafone.de> wrote: > Am 16.12.2016 um 12:58 schrieb Nayan Deshmukh: >> >> v2: add missing semicolon >> >> Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> > > > Patch #2-#4

[Mesa-dev] [PATCH 5/5] st/xvmc: error handling

2016-12-16 Thread Nayan Deshmukh
vl_compositor_set_csc_matrix may return false Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/xvmc/attributes.c | 3 ++- src/gallium/state_trackers/xvmc/context.c| 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/g

[Mesa-dev] [PATCH 4/5] st/va: error handling

2016-12-16 Thread Nayan Deshmukh
handle the cases when vl_compositor_set_csc_matrix(), vl_compositor_init_state() and vl_compositor_init() fail Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/va/context.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCH 3/5] st/vdpau: error handling

2016-12-16 Thread Nayan Deshmukh
handle the cases when vl_compositor_set_csc_matrix(), vl_compositor_init_state() and vl_compositor_init() fail Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/device.c | 8 +- src/gallium/state_trackers/vdpau/mixer.c

[Mesa-dev] [PATCH 1/5] st/xvmc: use goto to make code more readable (v2)

2016-12-16 Thread Nayan Deshmukh
v2: add missing semicolon Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/xvmc/context.c | 40 +++ 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/src/gallium/state_trackers/xvmc/context.c b/src/g

[Mesa-dev] [PATCH 2/5] vl/compositor: implement error handling

2016-12-16 Thread Nayan Deshmukh
pipe_buffer_map and pipe_buffer_create may return NULL Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/auxiliary/vl/vl_compositor.c | 13 +++-- src/gallium/auxiliary/vl/vl_compositor.h | 2 +- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

2016-12-15 Thread Nayan Deshmukh
My apologies for sending the wrong series. On Thu, Dec 15, 2016 at 7:45 PM, Christian König <deathsim...@vodafone.de> wrote: > Am 15.12.2016 um 15:07 schrieb Emil Velikov: >> >> On 15 December 2016 at 13:57, Nayan Deshmukh <nayan26deshm...@gmail.com> >> wr

[Mesa-dev] [PATCH v2 4/4] st/xvmc: remove dead code

2016-12-15 Thread Nayan Deshmukh
vl_compositor_init_state always return true so we don't need to handle false case Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/xvmc/context.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/gallium/state_tracker

[Mesa-dev] [PATCH v2 3/4] st/vdpau: check if compositor is initilized successfully

2016-12-15 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/device.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/device.c b/src/gallium/state_trackers/vdpau/device.c index 81b7582..8bae064

[Mesa-dev] [PATCH v2 1/4] st/xvmc: use goto to make code more readable

2016-12-15 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/xvmc/context.c | 40 +++ 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/src/gallium/state_trackers/xvmc/context.c b/src/gallium/state_trackers/xvmc/con

[Mesa-dev] [PATCH v2 2/4] st/vdpau: remove dead code

2016-12-15 Thread Nayan Deshmukh
vl_compositor_init_state always return true so we don't need to handle false case v2: add missing semicolon Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/presentation.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

2016-12-15 Thread Nayan Deshmukh
I send out the wrong series, the earlier one. I am sending the v2. I am not sure of the reason as to why it was returning a bool anyways. So I was hoping that someone could point out the reason. Regards, Nayan On Thu, Dec 15, 2016 at 7:24 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote:

[Mesa-dev] [PATCH 3/4] st/vdpau: check if compositor is initilized successfully

2016-12-15 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/device.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/device.c b/src/gallium/state_trackers/vdpau/device.c index 81b7582..62709e3

[Mesa-dev] [PATCH 2/4] st/vdpau: remove dead code

2016-12-15 Thread Nayan Deshmukh
vl_compositor_init_state always return true so we don't need to handle false case Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- We may as well make vl_compositor_init_state a void function but I don't know the reason as to why it is there in first place so haven't touched

[Mesa-dev] [PATCH 1/4] st/xvmc: use goto to make code more readable

2016-12-15 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/xvmc/context.c | 40 +++ 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/src/gallium/state_trackers/xvmc/context.c b/src/gallium/state_trackers/xvmc/con

[Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

2016-12-15 Thread Nayan Deshmukh
vl_compositor_init_state always return true so we don't need to handle false case Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/xvmc/context.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/gallium/state_tracker

Re: [Mesa-dev] [PATCH 11/28] st/va: fix misplaced closing bracket

2016-12-14 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Fri, Dec 9, 2016 at 12:51 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > It's been like this since the code was introduced. > > Fixes: 86eb4131a90

Re: [Mesa-dev] [PATCH 14/28] st/omx: remove unused drm_driver.h includes

2016-12-14 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Fri, Dec 9, 2016 at 1:30 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > s

Re: [Mesa-dev] [PATCH 15/28] st/omx: remove unneeded X11 include

2016-12-14 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Fri, Dec 9, 2016 at 1:30 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > s

Re: [Mesa-dev] [PATCH] vl/zscan: fix "Fix trivial sign compare warnings"

2016-12-14 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Wed, Dec 14, 2016 at 7:37 PM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > The variable actually needs to be signed, otherwise converting it to a >

Re: [Mesa-dev] [PATCH 17/28] auxiliary/vl: attempt to fix X11-less builds

2016-12-13 Thread Nayan Deshmukh
On Fri, Dec 9, 2016 at 1:30 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Use the proper guard around the include and use void * instead of > Display *. > Some part of the patch is missing. Regards, Nayan &g

Re: [Mesa-dev] [PATCH 24/28] configure: error out if building OMX w/o supported platform

2016-12-13 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Tue, Dec 13, 2016 at 11:58 PM, Nayan Deshmukh <nayan26deshm...@gmail.com> wrote: > Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> > > On Fri, Dec 9, 2016 at 1:30 AM, Emil Velikov <emil.l.veli...@g

Re: [Mesa-dev] [PATCH 26/28] configure: error out if building XVMC w/o supported platform

2016-12-13 Thread Nayan Deshmukh
Half of this patch went in 25, with that fixed both are Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Fri, Dec 9, 2016 at 1:30 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Signed-off-

Re: [Mesa-dev] [PATCH 25/28] configure: error out if building VDPAU w/o supported platform

2016-12-13 Thread Nayan Deshmukh
_XA, test "x$enable_xa" = xyes) > > +if echo $platforms | grep -q "x11"; then > +have_xvmc_platform=yes > +else > +have_xvmc_platform=no > +fi > + This is part of some other patch I guess. Regards, Nayan > +if echo $platforms | grep -q "x11"; t

Re: [Mesa-dev] [PATCH 27/28] configure: trivial whitespace cleanup

2016-12-13 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Fri, Dec 9, 2016 at 1:30 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > co

Re: [Mesa-dev] [PATCH 10/28] st/va: move variable declaration to where its used

2016-12-13 Thread Nayan Deshmukh
s/thinker/tinker. with that fixed Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Fri, Dec 9, 2016 at 12:51 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > ... and make it const, since we shouldn't

Re: [Mesa-dev] [PATCH 13/28] st/va: check if vl_*_screen_create has failed only once

2016-12-13 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Tue, Dec 13, 2016 at 11:04 PM, Nayan Deshmukh <nayan26deshm...@gmail.com> wrote: > Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> > > > On Fri, Dec 9, 2016 at 1:30 AM, Emil Velikov <emil.l.veli..

Re: [Mesa-dev] [PATCH] st/vdpau: fix compiler warning in vlVdpVideoMixerRender

2016-12-05 Thread Nayan Deshmukh
vlVdpSave4DelayedRendering() > Hi Emil, Thanks for the suggestions but I am working on a patch series which will remove the vlVdpSave4DelayedRendering() and hence the above if and else will be removed. So setting pipe to NULL will take care of the compiler warnings for the future patches too.

Re: [Mesa-dev] [PATCH] st/vdpau: fix compiler warning in vlVdpVideoMixerRender

2016-12-05 Thread Nayan Deshmukh
Christian, Thanks for the review. Can you push the patch for me? Regards, Nayan On Mon, Dec 5, 2016 at 1:17 PM, Christian König <christian.koe...@amd.com> wrote: > Am 05.12.2016 um 06:25 schrieb Nayan Deshmukh: >> >> Signed-off-by: Nayan Deshmukh <nayan26deshm...@g

Re: [Mesa-dev] [PATCH] radv: fix resource leak in radv_amdgpu_ctx_create

2016-12-05 Thread Nayan Deshmukh
Thanks for the review. Can you push the patch for me. Regards, Nayan On Mon, Dec 5, 2016 at 2:46 PM, Edward O'Callaghan <funfunc...@folklore1984.net> wrote: > Reviewed-by: Edward O'Callaghan <funfunc...@folkore1984.net> > > On 12/05/2016 04:45 AM, Nayan Deshmukh wro

[Mesa-dev] [PATCH] st/vdpau: fix compiler warning in vlVdpVideoMixerRender

2016-12-04 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/mixer.c b/src/gallium/state_trackers/vdpau/mixer.c index c205427..aca43c1 100644 ---

Re: [Mesa-dev] [PATCH] intel/aubinator: fix resource leak in aub_file_open

2016-12-04 Thread Nayan Deshmukh
Yes, you are right, sorry for the noise. Regards, Nayan. On Mon, Dec 5, 2016 at 10:14 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > Calling exit() is going to cause the program to terminate and all of its > resources will get cleaned up by the OS. There's no real reason

[Mesa-dev] [PATCH] intel/aubinator: fix resource leak in aub_file_open

2016-12-04 Thread Nayan Deshmukh
CovID: 1373563 Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/intel/tools/aubinator.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 5e3a684..f64a843 100644 --- a/src/intel

[Mesa-dev] [PATCH] radv: fix resource leak in radv_amdgpu_ctx_create

2016-12-04 Thread Nayan Deshmukh
CovID: 1396387 Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c index b8558fa..0

Re: [Mesa-dev] [PATCH] anv: Add missing error-checking to anv_block_pool_init

2016-11-20 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh <nayan26deshm...@gmail.com> On Sun, Nov 20, 2016 at 4:41 PM, Mun Gwan-gyeong <elong...@gmail.com> wrote: > When the allocation fails on u_vector_init(), it returns 0 > This fixes u_vector_init failure path on anv_block_pool_init > > CID 139431

Re: [Mesa-dev] [PATCH v3] vl/dri3: use external texture as back buffers(v3)

2016-11-07 Thread Nayan Deshmukh
On Mon, Nov 7, 2016 at 8:31 PM, Leo Liu <leo@amd.com> wrote: > > > On 11/05/2016 02:44 AM, Nayan Deshmukh wrote: > >> Hi Leo, >> >> Thanks for the reference patch. >> >> There are only a number of output surfaces taking turns as the

Re: [Mesa-dev] [PATCH v3] vl/dri3: use external texture as back buffers(v3)

2016-11-05 Thread Nayan Deshmukh
to it by the application, so we can't make any assumptions on the surface that will be provided it may or may not be the same. Instead we could have additional fields in vlVdpOutputSurface which stores the handle and pixamp of the texture. Regards, Nayan ___ mesa-dev

[Mesa-dev] [PATCH v3] vl/dri3: use external texture as back buffers(v3)

2016-11-04 Thread Nayan Deshmukh
variables handle vaapi path Suggested-by: Leo Liu <leo@amd.com> Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/auxiliary/vl/vl_winsys.h | 4 + src/gallium/auxiliary/vl/vl_winsys_dri3.c | 117 ++ 2 files changed, 10

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v2)

2016-11-04 Thread Nayan Deshmukh
On Fri, Nov 04, 2016 at 12:20:51PM -0400, Leo Liu wrote: > Hi Nayan, > > With this patch, the resizing corruption is fixed, thanks for that. > > Still a few comments below. > > > On 11/04/2016 03:08 AM, Nayan Deshmukh wrote: > > dri3 allows us to send handle of

[Mesa-dev] [PATCH 3/3] st/vdpau: remove the delayed rendering hack(v1.1)

2016-11-04 Thread Nayan Deshmukh
the hack was introduced to avoid an extra copying but now with dri3 we don't need it anymore v1.1: rebasing Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/bitmap.c| 2 - src/gallium/state_trackers/vdpau/device.c

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v2)

2016-11-04 Thread Nayan Deshmukh
ed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ src/gallium/auxiliary/vl/vl_winsys_dri3.c | 109 ++ 2 files changed, 99 insertions(+), 14 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys.h b

[Mesa-dev] [PATCH 2/3] st/vdpau: use dri3 to direclty send the buffer to X(v1.1)

2016-11-04 Thread Nayan Deshmukh
this avoids an extra copy which occurs in case of dri2 v1.1: fallback to dri2 if dri3 fails to initialize Suggested-by: Christian König <christian.koe...@amd.com> Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/present

[Mesa-dev] [PATCH 0/3] Use dri3 in vdpau to send handle of texture to X

2016-11-04 Thread Nayan Deshmukh
Hi all, This is re-send of the previous series. It contains the updated patches in response to Leo, Christian and Emil's comments. Please Review. Regards, Nayan Nayan Deshmukh (3): vl/dri3: use external texture as back buffers(v2) st/vdpau: use dri3 to direclty send the buffer to X(v1.1

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-11-02 Thread Nayan Deshmukh
Hi Leo, To support clipping of the output texture I was trying to send a xcb_xfixes_region as the fifth argument (i.e valid-area) to xcb_present_pixmap but it still displays the entire surface. Am I missing something? Regards, Nayan ___ mesa-dev

Re: [Mesa-dev] [PATCH] Revert "st/vdpau: use linear layout for output surfaces"

2016-10-31 Thread Nayan Deshmukh
Hi Guys, This not in master yet, I have tested it on my system(I+A) and it works fine. Regards, Nayan On Sat, Oct 1, 2016 at 1:57 PM, Christian König <deathsim...@vodafone.de> wrote: > Am 01.10.2016 um 00:06 schrieb Marek Olšák: > >> On Fri, Sep 30, 2016 at 11:23 PM,

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-28 Thread Nayan Deshmukh
On Fri, Oct 28, 2016 at 2:43 PM, Michel Dänzer <mic...@daenzer.net> wrote: > On 28/10/16 06:04 PM, Nayan Deshmukh wrote: > > On Fri, Oct 28, 2016 at 2:14 PM, Michel Dänzer <mic...@daenzer.net > > <mailto:mic...@daenzer.net>> wrote: > > > >

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-28 Thread Nayan Deshmukh
On Fri, Oct 28, 2016 at 2:14 PM, Michel Dänzer <mic...@daenzer.net> wrote: > On 28/10/16 03:58 PM, Nayan Deshmukh wrote: > > On Fri, Oct 28, 2016 at 7:00 AM, Michel Dänzer <mic...@daenzer.net > > <mailto:mic...@daenzer.net>> wrote: > > > >

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-28 Thread Nayan Deshmukh
.freedesktop.org/patch/110569/ seems the best candidate > for resolving the nouveau issue, but I suspect as is it might break DRI3 > PRIME. Nayan, can you check this and fix it up as necessary? Basically, > PIPE_BIND_LINEAR is only really necessary for buffers which are sent to &g

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 11:07 PM, Leo Liu <leo@amd.com> wrote: > > > On 10/27/2016 01:20 PM, Nayan Deshmukh wrote: > > > > On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu <leo@amd.com> wrote: > >> >> >> On 10/27/2016 12:20 PM, Nayan Des

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:50 PM, Nayan Deshmukh <nayan26deshm...@gmail.com> wrote: > > > On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu <leo@amd.com> wrote: > >> >> >> On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: >> >>> On Thu, Oct 27, 201

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu <leo@amd.com> wrote: > > > On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: > >> On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: >> >>> >>> On 10/24/2016 09:55 AM, Nayan Deshmukh wrote:

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: > > > On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: > > Suggested-by: Leo Liu <leo@amd.com> > > Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> > > --- > > src/gallium/auxiliary/

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
hat was it, OK with that patch. > > Though "OK", sub-optimal loosing pageflip on tonga, as a vsync test > fails top 5% of screen unless I force GPU perf high. This reason for this is that in case of single gpu, I have to recalculate its handle and get a pixmap from that

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
s/runs/null/ On Wed, Oct 26, 2016 at 01:57:12AM +0530, Nayan Deshmukh wrote: > Hi Andy, > > It seems that you have compiled mesa with DRI3 enabled but > vl_dri3_screen_create returns > runs when called in device.c and hence VDPAU fallbacks to using DRI2. > > BTW I

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Tue, Oct 25, 2016 at 11:11:13PM +0100, Andy Furniss wrote: > Nayan Deshmukh wrote: > > Hi Andy, > > > > It seems that you have compiled mesa with DRI3 enabled but > > vl_dri3_screen_create returns > > runs when called in device.c and hence VDPAU fallbacks t

[Mesa-dev] [PATCH 2/3] st/vdpau: use dri3 to direclty send the buffer to X

2016-10-27 Thread Nayan Deshmukh
this avoids an extra copy which occurs in case of dri2 Suggested-by: Christian König <christian.koe...@amd.com> Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> --- src/gallium/state_trackers/vdpau/presentation.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a

  1   2   3   >