On Wed, 2019-05-29 at 12:08 +0200, Lucas Stach wrote:
> There is no implementation and also no users, so there is no point
> in keeping it in the API.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Philipp Zabel
This makes https://patchwork.kernel.org/patch/9912089/ obsolete.
reg
Without this gbm_bo_get_offset() can return 0 where it shouldn't.
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c
b/src/gallium/drivers/etnaviv/etnaviv_resource.c
index 83179d3cd088..ab77a80c72b3
On Fri, 2019-04-12 at 19:38 +0200, Lucas Stach wrote:
> This allows color space conversion and tiling in a single step, as
> well as handling multi-planar formats like NV12, which are really
> useful when dealing with hardware video decoders.
>
> Signed-off-by: Lucas Stach
> ---
> .../drivers/et
port those
> + * formats natively, so we need a special case here to give a mostly
> + * accurate answer to the modifiers query.
> + */
"Mostly accurate" meaning that for IYUV this is correct, but for NV12 we
are assuming that the drivers will return the same mo
On Fri, 2019-04-12 at 19:33 +0200, Lucas Stach wrote:
> If the driver provides native support for YUV textures we can skip
> adding additional samplers and re-writing the shaders.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Philipp Zabel
reg
On Fri, 2019-04-12 at 19:33 +0200, Lucas Stach wrote:
> If the driver supports multi-planar formats natively we don't want to
> re-write the format of the planes on import. Split this out in a
> separate function for clarity.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Phi
scanout surfaces, so safe to use LINEAR here
> */
> return etna_resource_alloc(pscreen, layout, mode, DRM_FORMAT_MOD_LINEAR,
> templat);
> }
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ownsample_y = 0,
> +.swap_rb = 0,
> +.dither = {0x, 0x},
> +.clear_mode = VIVS_RS_CLEAR_CONTROL_MODE_DISABLED,
> +.width = blit_info->dst.box.width,
> +.height = blit_info->dst.box.height,
> + });
> +
> + /* The combined color/depth cache flush is required to avoid pixels
> stuck
> + * in the caches being flushed to the RS target. This seems to be some
> bug
> + * found on at least GC2000, with no other known workaround.
> + */
> + etna_set_state(ctx->stream, VIVS_GL_FLUSH_CACHE,
> + VIVS_GL_FLUSH_CACHE_COLOR | VIVS_GL_FLUSH_CACHE_DEPTH);
> + etna_stall(ctx->stream, SYNC_RECIPIENT_RA, SYNC_RECIPIENT_PE);
> + etna_set_state(ctx->stream, VIVS_TS_MEM_CONFIG, 0);
> + ctx->dirty |= ETNA_DIRTY_TS;
> + etna_submit_rs_state(ctx, &tile_blit);
> +
> + /* flush now, so we can get rid of the temp BO right here */
> + etna_cmd_stream_flush(ctx->stream);
> + etna_bo_del(temp_bo);
> + }
> +
> return TRUE;
> }
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri, 2019-04-12 at 19:38 +0200, Lucas Stach wrote:
> This adds a blit path using the 2D GPU for a linear YUV to tiled RGB
> blit. This allows to implement importing of planar YUV textures with
> a single copy.
>
> Signed-off-by: Lucas Stach
> ---
> src/gallium/drivers/etnaviv/Makefile.sources
er way,
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, 2019-04-15 at 12:31 +0200, Lucas Stach wrote:
> Am Montag, den 15.04.2019, 12:20 +0200 schrieb Philipp Zabel:
> > On Fri, 2019-04-12 at 19:38 +0200, Lucas Stach wrote:
> > > We copy the template resource content into the newly allocated resource.
> > > If the tem
On Fri, 2019-04-12 at 19:38 +0200, Lucas Stach wrote:
> This adds a blit path using the 2D GPU for a linear YUV to tiled RGB
> blit. This allows to implement importing of planar YUV textures with
> a single copy.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Philipp Zabel
On Fri, 2019-04-12 at 19:38 +0200, Lucas Stach wrote:
> We copy the template resource content into the newly allocated resource.
> If the template derived from a planar resource this leads to a non reference
> counted copy of the next resource pointer. Make sure to clear this out when
> allocating
ne padding of the imported resource. */
> unsigned paddingX = 0, paddingY = 0;
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri, 2019-04-12 at 19:38 +0200, Lucas Stach wrote:
> The 2D pipe is useful to implement fast planar and interleaved YUV buffer
> imports. Not all systems have a 2D capable core, so this is strictly
> optional.
>
> Signed-off-by: Lucas Stach
> ---
> src/gallium/drivers/etnaviv/etnaviv_context.
0, 0, PIPE_BIND_SAMPLER_VIEW))
> + tex_usage |= PIPE_BIND_SAMPLER_VIEW;
> +
> + if (!tex_usage)
> + return NULL;
>
> if (use & __DRI_IMAGE_USE_SCANOUT)
>tex_usage |= PIPE_BIND_SCANOUT;
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, 2019-01-29 at 10:10 +0100, Erik Faye-Lund wrote:
> On Mon, 2019-01-28 at 09:31 -0800, Matt Turner wrote:
> > Use the trick of adding and then subtracting 2**52 (52 is the number
> > of
> > explicit mantissa bits a double-precision floating-point value has)
> > to
> > implement round-to-even
On Thu, 2018-11-15 at 15:37 +0100, Lucas Stach wrote:
> Some of the status variables in the compiler are only used in asserts
> and thus may be unused in release builds. Annotate them accordingly
> to avoid 'unused but set' warnings from the compiler.
>
> Signed-off-by: Lucas Stach
> ---
> src/g
On Thu, 2018-11-15 at 15:37 +0100, Lucas Stach wrote:
> Take into account the render target format when checking if the color
> mask affects all channels of the RT. This allows to enable full
> override in a few cases where a non-alpha format is used.
>
> Signed-off-by: Lucas Stach
> ---
> src/g
>texture->format)) {
> + translate_rs_format_rb_swap(pfb->cbufs[0]->format)) {
There is another instance of this in etna_update_blend_color() below.
With that added,
Reviewed-by: Philipp Zabel
>colormask = rt0->colormask & (PIPE_MASK_A | PIPE_MASK_G);
>
2000. Flushes and stalls don't seem to make any
> difference.
>
> In order to stop the core from pushing the dirt into a precious real
> render target, plug in dummy buffer when rendering without a color
> buffer.
>
> Signed-off-by: Lucas Stach
R
On Mon, 2018-11-05 at 10:00 +, Eric Engestrom wrote:
> Cc: Dave Airlie
> Cc: Philipp Zabel
> Signed-off-by: Eric Engestrom
Reviewed-by: Philipp Zabel
> ---
> src/vulkan/wsi/wsi_common_wayland.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> dif
On Fri, 2018-10-05 at 10:13 +1000, Dave Airlie wrote:
> From: Dave Airlie
>
> If we fail the init path then don't call the free path.
>
> Found by coverity
> ---
> src/vulkan/wsi/wsi_common_wayland.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/vulkan/wsi/ws
Hi Marek,
there are two comments that will be confusing if they are not updated as
well:
On Sat, 2018-09-01 at 02:54 -0400, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/auxiliary/util/u_inlines.h | 86 +-
> 1 file changed, 43 insertions(+), 43 deletions(
On Mon, 2018-07-09 at 18:02 +0200, Lucas Stach wrote:
> This adds a blit path using the 2D GPU for a linear YUV to tiled RGB
> blit. This allows to implement importing of planar YUV textures with
> a single copy.
>
> Signed-off-by: Lucas Stach
> ---
> src/gallium/drivers/etnaviv/Makefile.sources
Hi Christian,
On Tue, 2018-06-05 at 17:43 +0200, Christian Gmeiner wrote:
> Am Di., 5. Juni 2018 um 16:40 Uhr schrieb Philipp Zabel
> :
> Thanks for this nice patch series. I have been working for too long on
> the nir topic
> for etnaviv and never pushed any patches (which is qui
On Tue, 2018-06-05 at 11:50 -0400, Rob Clark wrote:
> On Tue, Jun 5, 2018 at 10:38 AM, Philipp Zabel wrote:
> > The temporary input/output register 0 is reserved for position in the
> > fragment shader. Hardwire it to 0 and start other input/output variables
> > at 1. The int
On Tue, 2018-06-05 at 11:39 -0400, Rob Clark wrote:
> On Tue, Jun 5, 2018 at 10:38 AM, Philipp Zabel wrote:
> > Since all threads share a global temporary vec4 register file, it is
> > important to reduce temporary register use of shaders.
> > Using source swizzles and dest
: Michael Tretter
Signed-off-by: Philipp Zabel
---
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c
b/src/gallium/drivers/etnaviv/etnaviv_compiler.c
index 66553199fe19..f17b9979b705 100644
--- a/src
We represent allocated temporaries as NIR global registers. Turn local
registers left over by the nir_convert_from_ssa pass into global
registers with the correct temporary number.
Signed-off-by: Philipp Zabel
---
src/gallium/drivers/etnaviv/etnaviv_nir.c | 21 +
1 file
The temporary input/output register 0 is reserved for position in the
fragment shader. Hardwire it to 0 and start other input/output variables
at 1. The intrinsic input load and output store base corresponds to the
temporary register number.
Signed-off-by: Philipp Zabel
Signed-off-by: Michael
From: Michael Tretter
If a uniform is source to an output store operation, we have to emit an
actual mov instruction that copies from the uniform register into the
temporary register that is used as a shader output.
Signed-off-by: Michael Tretter
Signed-off-by: Philipp Zabel
---
src/gallium
From: Michael Tretter
The hardware does not allow two different uniform registers to be used
as sources in the same ALU instruction. Emit mov instructions to
temporary registers for all but one uniform register in this case.
Signed-off-by: Michael Tretter
Signed-off-by: Philipp Zabel
---
src
From: Michael Tretter
Start emitting ALU instructions for nir_alu_instr structures from the
NIR shader's main function implementation.
Signed-off-by: Michael Tretter
Signed-off-by: Philipp Zabel
---
.../drivers/etnaviv/etnaviv_compiler.c| 290 ++
1 file changed
Emit TEXLD, TEXLDB, and TEXLDL instructions from nir_texop_tex,
nir_texop_txb, and nir_texop_txl texture loads, respectively.
Signed-off-by: Philipp Zabel
Signed-off-by: Michael Tretter
---
.../drivers/etnaviv/etnaviv_compiler.c| 65 +++
1 file changed, 65 insertions
glmark2 ideas benchmark).
TODO: move this up into NIR as a lowering step.
Signed-off-by: Michael Tretter
Signed-off-by: Philipp Zabel
---
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/gallium/drivers/etnaviv
Add a debug option ETNA_MESA_DEBUG="nir" that will cause the etnaviv
gallium pipe driver to advertise support and preference for NIR shaders.
Signed-off-by: Philipp Zabel
Signed-off-by: Michael Tretter
---
src/gallium/drivers/etnaviv/etnaviv_debug.h | 3 +++
src/gallium/drive
instruction using the sources and condition flags from the
preceding conditional operation.
Signed-off-by: Philipp Zabel
Signed-off-by: Michael Tretter
---
.../drivers/etnaviv/etnaviv_compiler.c| 75 +++
src/gallium/drivers/etnaviv/etnaviv_nir.c | 18 +
2 files changed
registers with the correct num_components
we have to add additional virtual scalar, vec2, and vec3 register
classes that only allow to use the X, XY, and XYZ components.
Signed-off-by: Philipp Zabel
Signed-off-by: Michael Tretter
---
src/gallium/drivers/etnaviv/etnaviv_nir.c | 27
From: Michael Tretter
If the source to a mov instruction is undefined, the result is undefined
as well. In that case it is valid to drop the mov instruction.
Signed-off-by: Michael Tretter
Signed-off-by: Philipp Zabel
---
src/gallium/drivers/etnaviv/etnaviv_nir.c | 35
The Vivante instruction set does not allow empty shaders.
If the shader is empty, add a nop to allow execution.
Signed-off-by: Philipp Zabel
Signed-off-by: Michael Tretter
---
src/gallium/drivers/etnaviv/etnaviv_nir.c | 16
1 file changed, 16 insertions(+)
diff --git a/src
-by: Philipp Zabel
Signed-off-by: Michael Tretter
---
src/gallium/drivers/etnaviv/etnaviv_nir.c | 282 --
1 file changed, 259 insertions(+), 23 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_nir.c
b/src/gallium/drivers/etnaviv/etnaviv_nir.c
index b73d4be31bc6
From: Michael Tretter
For NIR shaders, get the shader stage from the nir_shader structure
instead from tgsi_shader_info.
Signed-off-by: Michael Tretter
Signed-off-by: Philipp Zabel
---
.../drivers/etnaviv/etnaviv_compiler.c| 37 ++-
1 file changed, 35 insertions(+), 2
From: Michael Tretter
Add etna_compile_shader_nir, set up shader inputs and outputs,
and start emitting instructions for optimized NIR shaders.
Signed-off-by: Michael Tretter
Signed-off-by: Philipp Zabel
---
.../drivers/etnaviv/etnaviv_compiler.c| 224 +-
1 file
Remove unnecessary mov instructions. If the destination of an ALU
instruction is only used in a following mov, merge that mov into the ALU
instruction.
Signed-off-by: Philipp Zabel
Signed-off-by: Michael Tretter
---
src/gallium/drivers/etnaviv/etnaviv_nir.c | 43 +++
1 file
allocation, since
they are not needed anymore.
Signed-off-by: Philipp Zabel
Signed-off-by: Michael Tretter
---
src/gallium/drivers/etnaviv/Makefile.am | 5 +-
src/gallium/drivers/etnaviv/Makefile.sources | 2 +
src/gallium/drivers/etnaviv/etnaviv_nir.c| 577 +++
s
From: Michael Tretter
Extract the mystery meat load balancing calculation into a function that
can also be called from the NIR compiler implementation.
Signed-off-by: Michael Tretter
Signed-off-by: Philipp Zabel
---
.../drivers/etnaviv/etnaviv_compiler.c| 60 +++
1
ler: generate instructions for log2
etnaviv: nir: remove undefined variables
etnaviv: compiler: ignore nir_instr_type_ssa_undef
etnaviv: nir: add extra mov for uniforms used as output
etnaviv: nir: avoid multiple uniform src for alu ops
Philipp Zabel (11):
etnaviv: prefix COMPARE_FUNC
From: Michael Tretter
Prepare for compilation from NIR. etna_compile_shader will call either
etna_compile_shader_tgsi or etna_compile_shader_nir, depending on
whether the input is TGSI or NIR.
Signed-off-by: Michael Tretter
Signed-off-by: Philipp Zabel
---
.../drivers/etnaviv
prefixed macro.
Signed-off-by: Philipp Zabel
Signed-off-by: Michael Tretter
---
src/gallium/drivers/etnaviv/hw/state_3d.xml.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/hw/state_3d.xml.h
b/src/gallium/drivers/etnaviv/hw
18.1.0/src/egl/drivers/dri2/platform_wayland.c: In function
'create_wl_buffer':
../../../Mesa-18.1.0/src/egl/drivers/dri2/platform_wayland.c:810:16: error:
implicit declaration of function 'zwp_linux_dmabuf_v1_create_params'
[-Werror=implicit-function-declaration]
Signed-o
On Tue, 2018-05-01 at 16:48 +0200, Christian Gmeiner wrote:
> We do no need to call translate_rs_format(..) as we can simplify
> things by using formats blocksize to choose the correct RS format
> for clearing.
>
> No piglit regressions.
>
> Signed-off-by: Christian Gmeiner
> ---
> src/gallium/
il/u_math.h"
>
> -#include
> -
> /* Returned when there is no match of pipe value to etna value */
> #define ETNA_NO_MATCH (~0)
Both
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
util_format_description(format);
> +
> + assert(desc);
> + if (!desc) {
> + return FALSE;
> + }
> +
> + return desc->colorspace == UTIL_FORMAT_COLORSPACE_YUV;
> +}
>
> /**
> * Calculates the depth fo
ternal_only)
> - external_only[num_modifiers] = 0;
> + external_only[num_modifiers] = util_format_is_yuv(format) ? 1 : 0;
>num_modifiers++;
> }
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@list
h
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
VIV_FE_DRAW_INSTANCED_COUNT_INSTANCE_COUNT_HI(instance_count >> 16) |
> + VIV_FE_DRAW_INSTANCED_COUNT_VERTEX_COUNT(vertex_count));
> + etna_cmd_stream_emit(stream,
> + VIV_FE_DRAW_INSTANCED_START_INDEX(offset));
> + etna_cmd_stream_emit(stream, 0);
> +}
> +
> void
> etna_emit_state(struct etna_context *ctx);
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
eloc *reloc)
> {
> etna_cmd_stream_reserve(stream, 2);
> etna_emit_load_state(stream, address >> 2, 1, 0);
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
shader_link_info *info,
> varying = &info->varyings[fsio->reg - 1];
> varying->num_components = fsio->num_components;
>
> - if (fsio->semantic.Name == TGSI_SEMANTIC_COLOR) /* colors affected by
> flat shading */
> + if (interpolate) /* colors
>DMABufPlaneModifiersHi[i].IsPresent) {
> + plane_n = i + 1;
> + }
> + }
> +
Nice, this makes sure that all planes up to the last modifier have fds
present. And since all fds are guaranteed to be present, the modifier
equality check
On Tue, 2017-08-08 at 07:29 +0300, Tapani Pälli wrote:
>
> On 08/07/2017 03:05 PM, Philipp Zabel wrote:
> > On Mon, 2017-07-31 at 18:35 +0100, Daniel Stone wrote:
> >> When using dmabuf import, make sure that the modifier is actually
> >> allowed to add planes to
BufPlaneModifiersHi[i].IsPresent) {
> +plane_n = i + 1;
Since this increments plane_n, Should a check be added that the
corresponding DMABufPlanFds[i] is present?
What if there are holes in DMABufPlaneModifiersLo/Hi?
> continue;
> + }
>
> _eglErro
On Fri, 2017-08-04 at 18:15 +0200, Wladimir J. van der Laan wrote:
> On Fri, Aug 04, 2017 at 05:07:54PM +0200, Philipp Zabel wrote:
> > Look up BOs from the name table using the name parameter instead of
> > req.handle (which at this point is always zero).
>
> Good ca
Look up BOs from the name table using the name parameter instead of
req.handle (which at this point is always zero).
Signed-off-by: Philipp Zabel
---
etnaviv/etnaviv_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/etnaviv/etnaviv_bo.c b/etnaviv/etnaviv_bo.c
index
Although etnaviv_drmif.h declared etna_bo_from_handle from the start,
there was no implementation.
Signed-off-by: Philipp Zabel
---
etnaviv/etnaviv_bo.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/etnaviv/etnaviv_bo.c b/etnaviv/etnaviv_bo.c
index 4fe877f..7566957
SIGNED_BYTE, NONE),
> V_(R8_SINT,BYTE, NONE),
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_pipe_format (int
> format)
> case __DRI_IMAGE_FORMAT_GR88:
>pf = PIPE_FORMAT_RG88_UNORM;
>break;
> + case __DRI_IMAGE_FORMAT_YUYV:
> + pf = PIPE_FORMAT_YUYV;
> + break;
> default:
>pf = PIPE_FORMAT_NONE;
>break;
Revie
rror path
if !is_format_supported().
Fixes: 83e9de25f325 ("st/mesa: EGLImageTarget* error handling")
Signed-off-by: Philipp Zabel
---
src/mesa/state_tracker/st_cb_eglimage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/state_tracker/st_cb_eglimage.c
b/src/mesa/state_tracker/
te(ctx->stream, VIVS_TS_FLUSH_CACHE,
> VIVS_TS_FLUSH_CACHE_FLUSH);
> }
>
> /* Set up color TS to source surface before blit, if needed */
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ers too. */
> + if (rsc->layout == ETNA_LAYOUT_LINEAR) {
> + /*
> + * Both sampler and pixel pipes can't handle linear, create a
> compatible
> + * base resource, where we can attach the imported buffer as an
> external
> + * resource.
> + */
> + struct pipe_resource tiled_templat = *tmpl;
> +
> + /*
> + * Remove BIND_SCANOUT to avoid recursion, as etna_resource_create uses
> + * this function to import the scanout buffer and get a tiled resource.
> + */
> + tiled_templat.bind &= ~PIPE_BIND_SCANOUT;
>
> - ptiled = etna_resource_create(pscreen, tmpl);
> + ptiled = etna_resource_create(pscreen, &tiled_templat);
>if (!ptiled)
> goto fail;
>
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
om->base, 0,
> view->texture->last_level);
> - etna_resource(res->texture)->seqno = res->seqno;
> - } else if (etna_resource_needs_flush(res)) {
> - etna_copy_resource(view->context, view->texture, view->texture, 0, 0);
&
etna_copy_resource(pctx, rsc->scanout->prime, prsc, 0, 0);
> + etna_resource(rsc->scanout->prime)->seqno = rsc->seqno;
> + }
> } else if (etna_resource_needs_flush(rsc)) {
>etna_copy_resource(pctx, prsc, prsc, 0, 0);
>rsc->flush_seqno
ipe_resource *prsc)
> {
> struct etna_resource *res = etna_resource(prsc);
>
> - res->seqno++;
> + if (res->external)
> + etna_resource(res->external)->seqno++;
> + else
> + res->seqno++;
> }
>
> static void
Reviewed-by: Phi
at.width0, padX);
> + scanout_templat.height0 = align(scanout_templat.height0, padY);
> +
> + rsc->scanout = renderonly_scanout_for_resource(&scanout_templat,
> + screen->ro, &handle);
>if (!rsc->scan
return NULL;
> + goto free_rsc;
> }
>
> rsc->bo = bo;
> @@ -223,6 +223,10 @@ etna_resource_alloc(struct pipe_screen *pscreen,
> unsigned layout,
> }
>
> return &rsc->base;
> +
> +free_rsc:
> + F
padding size.
> * The stride of the BO must be greater or equal to our padded
Reviewed-by: Philipp Zabel
regards
Philipp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri, 2017-06-23 at 17:50 +0200, Lucas Stach wrote:
> The current way of importing the resource from renderonly after allocation
> is opaque and is taking away control from the driver, which it needs in
> order to implement more advanced scenarios, than the simple linear
> scanout with matching s
hows through.
Other attempts such as adding a pipeline stall before the color flush or
a TS cache flush afterwards or flushing multiple times, with stalls
before and after each flush, have shown no effect.
Signed-off-by: Philipp Zabel
---
Changes since v1:
- Add a comment explaining why we flush c
_SHADE_MODEL_SMOOTH) |
> + cs->PA_CONFIG = (so->flatshade ? VIVS_PA_CONFIG_SHADE_MODEL_FLAT :
> VIVS_PA_CONFIG_SHADE_MODEL_SMOOTH) |
> translate_cull_face(so->cull_face, so->front_ccw) |
> translate_polygon_mode(so-&g
On Thu, 2017-06-08 at 18:25 +0200, Lucas Stach wrote:
> It seems that newer cores don't use the PA_ATTRIBUTES to decide if the
> varying should bypass the flat shading, but derive this from the component
> use. This fixes flat shading on GC880+.
>
> VARYING_COMPONENT_USE_POINTCOORD is a bit of a m
("drm/etnaviv: submit support
for out-fences") and 9ad59fea162c ("drm/etnaviv: submit support for
in-fences") to test, without ill effects.
> Signed-off-by: Christian Gmeiner
Reviewed-by: Philipp Zabel
Tested-by: Philipp Zabel
regards
Philipp
> ---
> etnaviv/etna
On Fri, 2017-05-19 at 11:41 +0200, Lucas Stach wrote:
> This gets rid of quite a bit of CPU/GPU sync on frequent vertex buffer
> uploads and I haven't seen any of the issues mentioned in the comment,
> so this one seems stale.
>
> Ignore the flag if there exists a temporary resource, as those ones
xes: c9e8b49b885 ("etnaviv: gallium driver for Vivante GPUs")
> Cc: mesa-sta...@lists.freedesktop.org
> Signed-off-by: Lucas Stach
Reviewed-by: Philipp Zabel
> ---
> src/gallium/drivers/etnaviv/etnaviv_transfer.c | 9 ++---
> 1 file changed, 6 insertions(+),
hows through.
Other attempts such as adding a pipeline stall before the color flush or
a TS cache flush afterwards or flushing multiple times, with stalls
before and after each flush, have shown no effect.
Signed-off-by: Philipp Zabel
---
src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 13 +
On Tue, 2017-05-23 at 14:40 +0530, Varad Gautam wrote:
> Hi Lucas,
>
> On Mon, May 22, 2017 at 11:16 PM, Lucas Stach wrote:
> > Am Mittwoch, den 10.05.2017, 23:15 +0530 schrieb Varad Gautam:
> >> From: Varad Gautam
> >>
> >> we currently ignore the plane count when converting from
> >> __DRI_IMA
between two frames without using the VkSwapchainCreateInfoKHR::oldSwapchain
mechanism to keep the old swapchain until after the next redraw.
Fixes: 5034c615582a ("vulkan/wsi/wayland: Use proxy wrappers for swapchain")
Signed-off-by: Philipp Zabel
Cc: mesa-sta...@lists.freedesktop.org
---
src/
On Tue, 2017-05-16 at 10:33 -0400, Rob Clark wrote:
> Don't reject YUV formats that the driver doesn't handle natively, since
> mesa/st already knows how to lower this in shader.
>
> Fixes: 83e9de2 ("st/mesa: EGLImageTarget* error handling")
> Cc: 17.1 Signed-off-by: Rob Clark
> ---
> src/mesa/s
Hi Wladimir,
On Tue, 2017-05-16 at 10:42 +0200, Wladimir J. van der Laan wrote:
> Current information shows that both extended texture/render formats
> and texture swizzling were introduced with the HALTI0 feature bit,
> available on GC2000/GC3000.
With this patch applied, trying to import R8_UNO
hilipp
>
> On Wed, May 10, 2017 at 06:01:08PM +0200, Lucas Stach wrote:
> > From: Philipp Zabel
> >
> > Just increment the resource seqno instead of setting the texture
> > seqno to be lower by one than the resource seqno.
> >
> > Signed-off-by: Phi
Signed-off-by: Philipp Zabel
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index df3eb6b29a..5c460f43d5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -455,7 +455,7 @@ int main () {
CFLAGS=$save_CFLAGS
AC_ARG_ENABLE(pwr8
On Tue, 2017-05-09 at 12:48 +0200, Volker Vogelhuber wrote:
[...]
> Ok thanks for the clarification. There is only one missing part for the
> GL_TEXTURE_2D case. The second EGLImage is created internally when
> calling eglCreateImage with EGL_LINUX_DMA_BUF_EXT, so I only
> have one return value I c
On Tue, 2017-05-09 at 12:31 +0300, Tapani Pälli wrote:
>
> On 05/09/2017 12:29 PM, Tapani Pälli wrote:
> >
> >
> > On 05/09/2017 12:14 PM, Volker Vogelhuber wrote:
> >> Hi,
> >>
> >> first sorry, for missing the subject in my mail to the mailing list,
> >> then thanks
> >> for the hint with the
On Tue, 2017-05-02 at 22:06 +0200, Christian Gmeiner wrote:
> No piglit regressions.
>
> Signed-off-by: Christian Gmeiner
Reviewed-by: Philipp Zabel
> ---
> src/gallium/drivers/etnaviv/etnaviv_format.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src
To restart interrupted system calls, use drmIoctl.
Suggested-by: Emil Velikov
Signed-off-by: Philipp Zabel
---
Applies on top of the "renderonly: drop resources on destroy" patch:
https://patchwork.freedesktop.org/patch/153274/
---
src/gallium/auxiliary/renderonly/renderonly.c | 7
To restart interrupted system calls, use drmIoctl.
Suggested-by: Emil Velikov
Signed-off-by: Philipp Zabel
---
Applies on top of the "renderonly: drop resources on destroy" patch:
https://patchwork.freedesktop.org/patch/153274/
---
src/gallium/auxiliary/renderonly/renderonly.c | 7
On Fri, 2017-04-28 at 11:19 +0100, Emil Velikov wrote:
> On 27 April 2017 at 17:44, Philipp Zabel wrote:
> > The renderonly_scanout holds a reference on its prime pipe resource,
> > which should be released when it is destroyed. If it
prime_fd is only used to transfer the scanout buffer to the GPU inside
renderonly_create_kms_dumb_buffer_for_resource. It should be closed
immediately to avoid leaking the DMA-BUF file handle.
Signed-off-by: Philipp Zabel
---
src/gallium/auxiliary/renderonly/renderonly.c | 2 ++
1 file changed
The renderonly_scanout holds a reference on its prime pipe resource,
which should be released when it is destroyed. If it was created by
renderonly_create_kms_dumb_buffer_for_resource, the dumb BO also has
to be destroyed.
Signed-off-by: Philipp Zabel
---
src/gallium/auxiliary/renderonly
Hi Wladimir,
On Thu, 2017-04-13 at 16:05 +0200, Wladimir J. van der Laan wrote:
> This patch adds support for the SINGLE_BUFFER feature on GC3000
> GPUs, which allows rendering to a single buffer using multiple pixel
> pipes.
>
> This feature is always used when it is available, which means that
Just increment the resource seqno instead of setting the texture
seqno to be lower by one than the resource seqno.
Signed-off-by: Philipp Zabel
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/gallium/drivers/etnaviv
1 - 100 of 166 matches
Mail list logo