[Mesa-dev] [PATCH] mesa: fix error handling in _mesa_TransformFeedbackVaryings

.functional.debug.negative_coverage.get_error.shader.transform_feedback_varyings Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98135 --- src/mesa/main/transformfeedback.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/08/2016 06:58 PM, Jason Ekstrand wrote: FYI, we use ralloc for a lot more than just the glsl compiler so the first few changes make me a bit nervous. There was someone working on making our driver more I undefined-memory-friendly but I don't know what happened to those patches. There's

Re: [Mesa-dev] [PATCH 2/2] mesa: throw error if bufSize negative in GetSynciv on OpenGL ES

On 10/07/2016 10:48 AM, Kenneth Graunke wrote: On Friday, October 7, 2016 8:52:19 AM PDT Tapani Pälli wrote: Fixes following dEQP tests: dEQP-GLES31.functional.debug.negative_coverage.callbacks.state.get_synciv dEQP-GLES31.functional.debug.negative_coverage.get_error.state.get_synciv

Re: [Mesa-dev] [PATCH 1/2] glsl: prohibit lowp, mediump precision on atomic_uint

On 10/07/2016 10:46 AM, Kenneth Graunke wrote: On Friday, October 7, 2016 8:52:18 AM PDT Tapani Pälli wrote: Fixes following dEQP tests: dEQP-GLES31.functional.debug.negative_coverage.callbacks.atomic_counter.atomic_precision dEQP-GLES31

[Mesa-dev] [PATCH 1/2] glsl: prohibit lowp, mediump precision on atomic_uint

.functional.debug.negative_coverage.log.atomic_counter.atomic_precision Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98131 --- src/compiler/glsl/ast_to_hir.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 8cdb917..c3c8cef 100644

[Mesa-dev] [PATCH 2/2] mesa: throw error if bufSize negative in GetSynciv on OpenGL ES

Fixes following dEQP tests: dEQP-GLES31.functional.debug.negative_coverage.callbacks.state.get_synciv dEQP-GLES31.functional.debug.negative_coverage.get_error.state.get_synciv dEQP-GLES31.functional.debug.negative_coverage.log.state.get_synciv Signed-off-by: Tapani Pälli Bugzilla

Re: [Mesa-dev] [PATCH v3] glsl: optimize copy_propagation_elements pass

On 10/06/2016 11:29 AM, Kenneth Graunke wrote: On Friday, September 30, 2016 8:12:12 AM PDT Ian Romanick wrote: From: Tapani Pälli Changes make copy_propagation_elements pass faster, reducing link time spent in test case of bug 94477. Does not fix the actual issue but brings down the total

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

On 10/04/2016 06:09 PM, Jason Ekstrand wrote: On Thu, Sep 29, 2016 at 11:27 PM, Xu,Randy > wrote: Add the miptree level/slice x/y_offset when count the surface offset in brw_emit_surface_state. The surface offset has two parts, one is from mt->offset, which

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

Hi; It seems Randy's original mail never ended up to the list (?) but patch is available for review in Patchwork: https://patchwork.freedesktop.org/patch/113278/ Thanks; On 09/30/2016 09:41 AM, Tapani Pälli wrote: I have only 6 failures in that set currently, but this patch fixes a

Re: [Mesa-dev] [PATCH v3] glsl: optimize copy_propagation_elements pass

Ah now I get what you meant and these changes make sense to me, this is easier to read. I did not spot regressions in CI run. On 09/30/2016 06:12 PM, Ian Romanick wrote: From: Tapani Pälli Changes make copy_propagation_elements pass faster, reducing link time spent in test case of bug 94477

[Mesa-dev] [PATCH] intel: fix compilation warning on gen_get_device_info

(warning: 'const' type qualifier on return type has no effect) Signed-off-by: Tapani Pälli --- src/intel/common/gen_device_info.c | 2 +- src/intel/common/gen_device_info.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/common/gen_device_info.c b

Re: [Mesa-dev] [PATCH] glsl: optimize copy_propagation_elements pass

On 09/30/2016 03:18 AM, Ian Romanick wrote: On 09/29/2016 12:17 AM, Tapani Pälli wrote: On 09/28/2016 06:14 PM, Ian Romanick wrote: On 09/16/2016 06:21 PM, Tapani Pälli wrote: Changes make copy_propagation_elements pass faster, reducing link time spent in test case of bug 94477. Does not

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

I have only 6 failures in that set currently, but this patch fixes all of them. Reason seems to be that with these cases we never up calling intel_miptree_get_tile_offsets and therefore use uninitialized values for tile_x and tile_y. Tested-by: Tapani Pälli On 09/30/2016 08:56 AM, Xu,Randy

[Mesa-dev] [PATCH v2] egl: stop claiming support for pbuffer + msaa

configs, including window ones. This one removes pbuffer bit when adding configs, now only pbuffer+msaa gets rejected and window+msaa continues to work. Fixed also comment (Emil) Signed-off-by: Tapani Pälli Cc: mesa-sta...@lists.freedesktop.org --- src/egl/drivers/dri2/egl_dri2.c | 9

Re: [Mesa-dev] [RFC] egl: stop claiming support for pbuffer + msaa (RFC)

On 09/29/2016 09:55 PM, Marek Olšák wrote: On Thu, Sep 29, 2016 at 6:23 PM, Emil Velikov wrote: On 27 September 2016 at 13:47, Marek Olšák wrote: On Tue, Sep 27, 2016 at 2:34 PM, Emil Velikov wrote: On 26 September 2016 at 08:41, Tapani Pälli wrote: This fixes a crash in egl-create

Re: [Mesa-dev] [PATCH] glsl: optimize copy_propagation_elements pass

On 09/28/2016 06:14 PM, Ian Romanick wrote: On 09/16/2016 06:21 PM, Tapani Pälli wrote: Changes make copy_propagation_elements pass faster, reducing link time spent in test case of bug 94477. Does not fix the actual issue but brings down the total time. No regressions seen in CI. How does

Re: [Mesa-dev] [RFC] egl: stop claiming support for pbuffer + msaa (RFC)

On 09/28/2016 12:19 AM, Ian Romanick wrote: On 09/26/2016 12:41 AM, Tapani Pälli wrote: This fixes a crash in egl-create-msaa-pbuffer-surface Piglit test and same crash in many dEQP EGL tests. I also found that some Qt example did a workaround because of this crash: https://bugreports.qt.io

Re: [Mesa-dev] [PATCH 10/15] glsl/standalone: Optimize dead variable declarations

move(variables, entry); + + return visit_continue; + } + + void remove_dead_variables() + { + struct set_entry *entry; + + for (entry = _mesa_set_next_entry(variables, NULL); + entry != NULL; + entry = _mesa_set_next_entry(variables, entry)) { please use set_foreach() macro he

[Mesa-dev] [RFC] egl: stop claiming support for pbuffer + msaa (RFC)

This fixes a crash in egl-create-msaa-pbuffer-surface Piglit test and same crash in many dEQP EGL tests. I also found that some Qt example did a workaround because of this crash: https://bugreports.qt.io/browse/QTBUG-47509 Signed-off-by: Tapani Pälli --- This is RFC as I'm not sure if w

Re: [Mesa-dev] [PATCH] glsl: optimize copy_propagation_elements pass

Gentle ping to Eric .. On 09/16/2016 06:21 PM, Tapani Pälli wrote: Changes make copy_propagation_elements pass faster, reducing link time spent in test case of bug 94477. Does not fix the actual issue but brings down the total time. No regressions seen in CI. Signed-off-by: Tapani Pälli

[Mesa-dev] [PATCH] glsl: optimize copy_propagation_elements pass

Changes make copy_propagation_elements pass faster, reducing link time spent in test case of bug 94477. Does not fix the actual issue but brings down the total time. No regressions seen in CI. Signed-off-by: Tapani Pälli --- For performance measurements, Martina reported in the bug 8x speedup

Re: [Mesa-dev] [PATCH] egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT

Ping .. On 08/26/2016 10:47 AM, Tapani Pälli wrote: From: Haixia Shi Set config attributes EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT to hard-coded non-zero values. These two attributes are required on Android. v2: use _EGL_MAX_PBUFFER_WIDTH/HEIGHT from egldefines.h (based on

Re: [Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

On 09/07/2016 04:06 PM, Emil Velikov wrote: On 7 September 2016 at 13:10, Mauro Rossi wrote: 2016-09-07 12:56 GMT+02:00 Emil Velikov : On 7 September 2016 at 11:01, Mauro Rossi wrote: Hi Tapani, does moving the declaration of the dependency to src/mesa/drivers/dri/i965/Android.mk also wo

Re: [Mesa-dev] [PATCH] glsl: Add a citation for uniform precision matching.

On 09/07/2016 12:37 PM, Kenneth Graunke wrote: On Wednesday, September 7, 2016 10:42:06 AM PDT Tapani Pälli wrote: On 09/07/2016 09:56 AM, Ian Romanick wrote: On 09/06/2016 03:24 PM, Kenneth Graunke wrote: On Tuesday, September 6, 2016 1:04:43 PM PDT Eric Anholt wrote: Kenneth Graunke

[Mesa-dev] [PATCH] android: depend on libmesa_genxml from i965 Android.gen.mk

Static library dependency is required to pull the generated XML headers into the generated C file. Signed-off-by: Tapani Pälli Reviewed-by: Emil Velikov --- src/mesa/drivers/dri/i965/Android.gen.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/Android.gen.mk

Re: [Mesa-dev] [PATCH] glsl: Add a citation for uniform precision matching.

On 09/07/2016 09:56 AM, Ian Romanick wrote: On 09/06/2016 03:24 PM, Kenneth Graunke wrote: On Tuesday, September 6, 2016 1:04:43 PM PDT Eric Anholt wrote: Kenneth Graunke writes: Ian added this check in commit 259fc505454ea6a67aeacf6cdebf1398d9947759. While reviewing the rules, I found a cit

Re: [Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

On 09/06/2016 06:06 PM, Emil Velikov wrote: On 6 September 2016 at 15:33, Chih-Wei Huang wrote: 2016-08-29 16:52 GMT+08:00 Tapani Pälli : make sure nir_opcodes.h is in LOCAL_GENERATED_SOURCES otherwise build fails with: "In file included from external/mesa/src/mesa/state_tr

[Mesa-dev] [PATCH] glsl: use hash instead of exec_list in copy propagation

This change makes copy propagation pass faster. Complete link time spent in test case attached to bug 94477 goes down to ~400 secs from over 500 secs on my HSW machine. Does not fix the actual issue but brings down the total. No regressions seen in CI. Signed-off-by: Tapani Pälli --- Next I&#x

[Mesa-dev] [PATCH] i965: release GLSL IR in LinkShader after it's not needed

Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_link.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/dri/i965/brw_link.cpp index 4800be0..2b1fa61 100644 --- a/src/mesa/drivers/dri/i965/brw_link.cpp

Re: [Mesa-dev] [PATCH] Android: glsl: add rules to generate ir_expression*.h header files

Hi; Thanks, I was trying to work on the same issue but did not quite get it working .. will test this one with N build. FYI this patch contains both of these (which I believe were issues already before mentioned changes, just somehow revealed only with N build?): https://patchwork.freedeskt

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On 08/31/2016 08:03 AM, Kenneth Graunke wrote: On Tuesday, August 30, 2016 3:52:12 PM PDT Ian Romanick wrote: [snip] I don't recall any native Linux games encountering this, but my memory may have faded. There were some Windows DirectX games that would exhaust VMA when run inside VMware. Once

Re: [Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

On 08/30/2016 07:59 AM, Tapani Pälli wrote: On 08/29/2016 07:11 PM, Emil Velikov wrote: On 29 August 2016 at 05:37, Tapani Pälli wrote: On 08/26/2016 03:58 PM, Emil Velikov wrote: On 26 August 2016 at 08:50, Tapani Pälli wrote: Reviewed-by: Tapani Pälli What happened with my

Re: [Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

On 08/29/2016 07:11 PM, Emil Velikov wrote: On 29 August 2016 at 05:37, Tapani Pälli wrote: On 08/26/2016 03:58 PM, Emil Velikov wrote: On 26 August 2016 at 08:50, Tapani Pälli wrote: Reviewed-by: Tapani Pälli What happened with my suggestion about getting things fixed as opposed

[Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

make sure nir_opcodes.h is in LOCAL_GENERATED_SOURCES otherwise build fails with: "In file included from external/mesa/src/mesa/state_tracker/st_glsl_to_nir.cpp:44: external/mesa/src/compiler/nir/nir.h:42:10: fatal error: 'nir_opcodes.h' file not found" Signed-off-by: Ta

Re: [Mesa-dev] [PATCH] android: fix build issues with genxml, isl

Nice work, now things build fine! Reviewed-by: Tapani Pälli On 08/28/2016 03:51 AM, Mauro Rossi wrote: Hi Emil, Jason, Tapani, this weekend I had planned to check mesa-dev with marshmallow-x86 and nougat-x86,builds, so here you can find the port to android of commit

Re: [Mesa-dev] [PATCH 3/3] isl: add support for Android libmesa_isl static library

On 08/26/2016 02:51 PM, Mauro Rossi wrote: 2016-08-26 12:27 GMT+02:00 Tapani Pälli mailto:tapani.pa...@intel.com>>: Hi; This is patch is causing build issues for me, how was this tested? Hi, thanks for highlighting the issue, My patch was tested and reviewed, the current a

Re: [Mesa-dev] [PATCH] android: fix build issues with genxml, isl

On 08/28/2016 03:51 AM, Mauro Rossi wrote: Hi Emil, Jason, Tapani, this weekend I had planned to check mesa-dev with marshmallow-x86 and nougat-x86,builds, so here you can find the port to android of commit bebc1a1d995e33f173ea207848bcddd81f6dd19a Built successfully and tested on Sandybridge.

Re: [Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

On 08/26/2016 03:58 PM, Emil Velikov wrote: On 26 August 2016 at 08:50, Tapani Pälli wrote: Reviewed-by: Tapani Pälli What happened with my suggestion about getting things fixed as opposed to adding tape over things, namely these thread [1] ? Can someone please look into that one instead

[Mesa-dev] [PATCH] android: fix build issues with genxml, isl

Android.mk files were referring to LOCAL_PATH instead of path where wanted Makefile.sources was existing. Also minor cleanups. Signed-off-by: Tapani Pälli --- src/intel/Makefile.sources | 62 ++--- src/intel/genxml/Android.mk | 4 +-- src/intel/isl

Re: [Mesa-dev] [PATCH 3/3] isl: add support for Android libmesa_isl static library

On 08/26/2016 01:27 PM, Tapani Pälli wrote: Hi; This is patch is causing build issues for me, how was this tested? (I'll send a patch proposal to fix the issues I encountered in a sec) See below for 2 questions: On 05/31/2016 01:20 AM, Mauro Rossi wrote: isl library is needed to

Re: [Mesa-dev] [PATCH 3/3] isl: add support for Android libmesa_isl static library

Hi; This is patch is causing build issues for me, how was this tested? See below for 2 questions: On 05/31/2016 01:20 AM, Mauro Rossi wrote: isl library is needed to build i965, libmesa_isl static library is added to fix related Android building errors. Any attempt to build libmesa_genxml as

Re: [Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

Reviewed-by: Tapani Pälli On 05/24/2016 08:39 AM, Nicolas Boichat wrote: platform_android.c needs to link with cutils, hardware, and sync libraries, as well as drm_gralloc libs. Also add appropriate tests in configure.ac. Signed-off-by: Nicolas Boichat --- configure.ac| 6

[Mesa-dev] [PATCH] egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT

Signed-off-by: Tapani Pälli --- src/egl/drivers/dri2/platform_android.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index e7b30b4..338f61c 100644 --- a/src/egl/drivers/dri2/platform_android.c +++ b/src

Re: [Mesa-dev] [PATCH] shaderapi: don't generate not linked error on GetProgramStage in general

Reviewed-by: Tapani Pälli On 08/23/2016 06:40 PM, Alejandro Piñeiro wrote: Both ARB_shader_subroutine and the GL core spec doesn't list any error when the program is not linked. We left a error generation for the uniform location, in order to be consistent with other methods from the

Re: [Mesa-dev] [PATCH v2] program_resource: subroutine active uniforms should return NumSubroutineUniforms

On 08/24/2016 12:31 PM, Alejandro Piñeiro wrote: On 24/08/16 11:13, Tapani Pälli wrote: Reviewed-by: Tapani Pälli Thanks for the review. (one small coding-style suggestion below) I will not use this suggestion. Reason below. On 08/23/2016 06:33 PM, Alejandro Piñeiro wrote: Before this

Re: [Mesa-dev] [PATCH v2] program_resource: subroutine active uniforms should return NumSubroutineUniforms

Reviewed-by: Tapani Pälli (one small coding-style suggestion below) On 08/23/2016 06:33 PM, Alejandro Piñeiro wrote: Before this commit, GetProgramInterfaceiv for pname ACTIVE_RESOURCES and all the _SUBROUTINE_UNIFORM programInterface were returning the count of resources on the shader

Re: [Mesa-dev] [PATCH] program_resource: subroutine active uniforms should return NumSubroutineUniforms

On 08/23/2016 10:12 AM, Alejandro Piñeiro wrote: On 22/08/16 10:03, Tapani Pälli wrote: On 08/19/2016 09:31 PM, Alejandro Piñeiro wrote: Before this commit, GetProgramInterfaceiv for pname ACTIVE_RESOURCES and all the _SUBROUTINE_UNIFORM programInterface were returning the count of

[Mesa-dev] [PATCH] android: fix build issues with glsl_parser.h

Without this I'm getting "No rule to make target ... glsl_parser.h" build error. Signed-off-by: Tapani Pälli --- src/compiler/Android.glsl.gen.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/Android.glsl.gen.mk b/src/compiler/Android.glsl.gen.mk index 1

Re: [Mesa-dev] [PATCH] program_resource: subroutine active uniforms should return NumSubroutineUniforms

On 08/19/2016 09:31 PM, Alejandro Piñeiro wrote: Before this commit, GetProgramInterfaceiv for pname ACTIVE_RESOURCES and all the _SUBROUTINE_UNIFORM programInterface were returning the count of resources on the shader program using that interface, instead of the number of active uniform resourc

[Mesa-dev] [PATCH v2 1/2] glsl: fix key used for hashing switch statement cases

Implementation previously used value itself as the key, however after hash implementation change by ee02a5e we cannot use 0 as key. v2: use constant pointer as the key and implement comparison for contents (Eric Anholt) Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org

[Mesa-dev] [PATCH v2 2/2] util: add assert that key cannot be NULL on insertion

Signed-off-by: Tapani Pälli --- src/util/hash_table.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/hash_table.c b/src/util/hash_table.c index 4cfe3d9..9e643af 100644 --- a/src/util/hash_table.c +++ b/src/util/hash_table.c @@ -295,6 +295,8 @@ hash_table_insert(struct hash_table

Re: [Mesa-dev] [PATCH] i965: fix compilation warnings in blorp

On 08/19/2016 11:34 AM, Jason Ekstrand wrote: On Fri, Aug 19, 2016 at 12:51 AM, Iago Toral mailto:ito...@igalia.com>> wrote: Reviewed-by: Iago Toral Quiroga mailto:ito...@igalia.com>> On Fri, 2016-08-19 at 10:39 +0300, Tapani Pälli wrote: > (warning: ‘surfty

[Mesa-dev] [PATCH] i965: fix compilation warnings in blorp

(warning: ‘surftype’ may be used uninitialized ...) Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/gen6_blorp.c | 2 ++ src/mesa/drivers/dri/i965/gen7_blorp.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH] glsl: fix key used for hashing switch statement cases

ought using hash_data would be more 'elegant way' to create unique values. I will check Eric's proposal also. -ilia On Thu, Aug 18, 2016 at 7:52 AM, Ilia Mirkin wrote: Can the hash value not be 0? On Aug 18, 2016 4:57 AM, "Tapani Pälli" wrote: Implementation previous

Re: [Mesa-dev] [PATCH] glsl: fix key used for hashing switch statement cases

On 08/18/2016 09:08 PM, Eric Anholt wrote: Tapani Pälli writes: Implementation previously used case value itself as the key, however afterhash implementation change by ee02a5e we cannot use 0 as key. Patch uses _mesa_hash_data to formulate a suitable key for this hash. Signed-off-by

Re: [Mesa-dev] [PATCH] mesa: fix empty program log length

On 08/18/2016 03:11 PM, Iago Toral wrote: On Wed, 2016-08-17 at 11:18 +0300, Tapani Pälli wrote: In case we have empty log (""), we should return 0. This fixes Khronos WebGL conformance test 'program-infolog'. From OpenGL ES 3.1 (and OpenGL 4.5 Core) spec: "If

Re: [Mesa-dev] [PATCH] glsl: fix key used for hashing switch statement cases

On 08/18/2016 01:08 PM, Iago Toral wrote: On Thu, 2016-08-18 at 11:57 +0300, Tapani Pälli wrote: Implementation previously used case value itself as the key, however afterhash implementation change by ee02a5e we cannot use 0 as key. Patch uses _mesa_hash_data to formulate a suitable key for

[Mesa-dev] [PATCH] glsl: fix key used for hashing switch statement cases

Implementation previously used case value itself as the key, however afterhash implementation change by ee02a5e we cannot use 0 as key. Patch uses _mesa_hash_data to formulate a suitable key for this hash. Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97309

[Mesa-dev] [PATCH] mesa: fix empty program log length

here is no info log, zero is returned." Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97321 --- src/mesa/main/shaderapi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index

Re: [Mesa-dev] [PATCH] install: check for undefined symbols in shared libraries

On 08/16/2016 10:12 PM, Jan Ziak wrote: This patch ensures that shared libraries installed by Mesa do not contain any undefined symbols. The patch should help lowering the number of users experiencing undefined symbol errors with OpenGL apps. [http://google.sk/search?q=undefined+symbol:+_glap

Re: [Mesa-dev] [PATCH] glx: Don't use current context in __glXSendError

On 08/16/2016 10:23 AM, Michel Dänzer wrote: On 16/08/16 04:11 PM, Tapani Pälli wrote: On 08/16/2016 09:49 AM, Michel Dänzer wrote: From: Michel Dänzer There's no guarantee that there is one, and we don't need one anyway. Fixes piglit tests: glx@glx-fbconfig-bad this one pas

Re: [Mesa-dev] [PATCH] glx: Don't use current context in __glXSendError

Hi; On 08/16/2016 09:49 AM, Michel Dänzer wrote: From: Michel Dänzer There's no guarantee that there is one, and we don't need one anyway. Fixes piglit tests: glx@glx-fbconfig-bad this one passes for me with and without the patch glx@glx_ext_import_context@import context, multi process g

Re: [Mesa-dev] [PATCH v4 2/2] glx: apple specific occurences of dummyContext check

On 08/12/2016 01:31 PM, Jeremy Huddleston Sequoia wrote: On Aug 12, 2016, at 00:41, Tapani Pälli wrote: On 07/18/2016 07:07 PM, Jeremy Huddleston Sequoia wrote: Will do. Thanks for pinging me. Early June was very busy and I didn't see this come through. I'll get back to yo

Re: [Mesa-dev] [PATCH v4 2/2] glx: apple specific occurences of dummyContext check

On 07/18/2016 07:07 PM, Jeremy Huddleston Sequoia wrote: Will do. Thanks for pinging me. Early June was very busy and I didn't see this come through. I'll get back to you within a couple days. a couple days passed, ping! :) --Jeremy On Jul 18, 2016, at 01:12, Tapani Pä

Re: [Mesa-dev] [PATCH 19/87] glsl: cache more uniform storage values

On 07/13/2016 05:47 AM, Timothy Arceri wrote: --- src/compiler/glsl/shader_cache.cpp | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 08f8e37..8aae1c8 100644 --- a/src/compiler/g

Re: [Mesa-dev] [PATCH v4 1/2] glx: fix error code when there is no context bound

On 07/27/2016 04:53 PM, Emil Velikov wrote: On 14 June 2016 at 16:08, Emil Velikov wrote: n 7 June 2016 at 11:33, Tapani Pälli wrote: From: Bernard Kilarski v2: change all related NULL checks to check against dummyContext v3: really check for dummyContext *only* when ctx was from

Re: [Mesa-dev] [PATCH] glsl: fix optimization of discard nested multiple levels

Reviewed-by: Tapani Pälli I've also tested that combining the conditions makes Piglit test pass. On 07/26/2016 11:14 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle The order of optimizations can lead to the conditional discard optimization being applied twice to the same discard stat

Re: [Mesa-dev] [PATCH v4 2/2] glx: apple specific occurences of dummyContext check

Jeremy, would you have time to test these changes? Patch 1 was already reviewed by Emil. // Tapani On 06/07/2016 01:33 PM, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Cc: Jeremy Huddleston Sequoia --- src/glx/apple/apple_xgl_api_stereo.c | 4 ++-- src/glx/apple

[Mesa-dev] [PATCH v4 2/2] glx: apple specific occurences of dummyContext check

Signed-off-by: Tapani Pälli Cc: Jeremy Huddleston Sequoia --- src/glx/apple/apple_xgl_api_stereo.c | 4 ++-- src/glx/apple/apple_xgl_api_viewport.c | 2 +- src/glx/glxcmds.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glx/apple

[Mesa-dev] [PATCH v4 1/2] glx: fix error code when there is no context bound

Signed-off-by: Tapani Pälli Cc: "11.2" --- src/glx/glx_error.c | 2 +- src/glx/glx_pbuffer.c | 2 +- src/glx/glxcmds.c | 30 +++--- src/glx/query_renderer.c | 4 ++-- src/glx/tests/fake_glx_scree

Re: [Mesa-dev] [PATCH v2] glx: fix crash with bad fbconfig

ping On 05/31/2016 12:53 PM, Tapani Pälli wrote: From: Daniel Czarnowski GLX documentation states: glXCreateNewContext can generate the following errors: (...) GLXBadFBConfig if config is not a valid GLXFBConfig Function checks if the given config is a valid config and sets

Re: [Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

On 06/06/2016 12:19 PM, Emil Velikov wrote: On 6 June 2016 at 10:10, Michel Dänzer wrote: On 04.06.2016 00:10, Marek Olšák wrote: On Fri, Jun 3, 2016 at 4:33 PM, Dieter Nützel wrote: Am 03.06.2016 11:47, schrieb Michel Dänzer: On 03.06.2016 18:34, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote:

[Mesa-dev] [PATCH v2] glx: fix crash with bad fbconfig

-fbconfig-bad Piglit test. v2: coding style cleanups (Emil, Topi) use DefaultScreen macro (Emil) Signed-off-by: Matt Roper Signed-off-by: Tapani Pälli Cc: "11.2" --- src/glx/glxcmds.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/glx/glxcmds.c

Re: [Mesa-dev] [PATCH v3] glx: fix error code when there is no context bound

On 05/30/2016 04:35 PM, Emil Velikov wrote: On 30 May 2016 at 07:53, Tapani Pälli wrote: From: Bernard Kilarski v2: change all related NULL checks to check against dummyContext v3: really check for dummyContext *only* when ctx was from __glXGetCurrentContext Signed-off-by: Bernard

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: fix crash with bad fbconfig

On 05/31/2016 07:44 AM, Tapani Pälli wrote: Hi; On 05/30/2016 04:48 PM, Emil Velikov wrote: Hi gents, On 30 May 2016 at 10:13, Tapani Pälli wrote: From: Daniel Czarnowski GLX documentation states: glXCreateNewContext can generate the following errors

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: fix crash with bad fbconfig

Hi; On 05/30/2016 04:48 PM, Emil Velikov wrote: Hi gents, On 30 May 2016 at 10:13, Tapani Pälli wrote: From: Daniel Czarnowski GLX documentation states: glXCreateNewContext can generate the following errors: (...) GLXBadFBConfig if config is not a valid GLXFBConfig

[Mesa-dev] [PATCH] glx: fix crash with bad fbconfig

-fbconfig-bad Piglit test. Signed-off-by: Matt Roper Signed-off-by: Tapani Pälli Cc: "11.2" --- src/glx/glxcmds.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index bff01d2..4bc7fc4 100644 --- a/src/glx/glxcmds.c +++

[Mesa-dev] [PATCH v3] glx: fix error code when there is no context bound

From: Bernard Kilarski v2: change all related NULL checks to check against dummyContext v3: really check for dummyContext *only* when ctx was from __glXGetCurrentContext Signed-off-by: Bernard Kilarski Signed-off-by: Matt Roper Signed-off-by: Tapani Pälli Cc: "11.2" --

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] glx: fix error code when there is no context bound

On 05/27/2016 08:16 PM, Emil Velikov wrote: On Friday, 27 May 2016, Tapani Pälli <mailto:tapani.pa...@intel.com>> wrote: On 05/26/2016 05:16 PM, Emil Velikov wrote: Hi all, On 29 February 2016 at 07:14, Tapani Pälli wrote: On 02/22/2016

[Mesa-dev] [PATCH v2] glx: fix error code when there is no context bound

From: Bernard Kilarski v2: change all related NULL checks to check against dummyContext Signed-off-by: Bernard Kilarski Signed-off-by: Matt Roper Cc: "11.2" currentDpy != dpy || + if (pdraw == NULL || gc == &dummyContext || gc->currentDpy != dpy || (gc->currentDrawable != drawab

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] glx: fix error code when there is no context bound

On 05/26/2016 05:16 PM, Emil Velikov wrote: Hi all, On 29 February 2016 at 07:14, Tapani Pälli wrote: On 02/22/2016 10:16 PM, Ian Romanick wrote: There are 17 total occurrences of grep -r '[(]!gc[)]' src/glx/ and grep -r 'gc[[:space:]]*==[[:space:]]*NULL

Re: [Mesa-dev] [PATCH] glsl: enforce invariant conditions for built-in variables

IMO you will need to check for the ES version too, something like this: https://patchwork.freedesktop.org/patch/36417/ On 05/06/2016 11:22 PM, Lars Hamre wrote: The conditions for which certain built-in special variables can be declared invariant were not being checked. OpenGL ES 1.00 specifi

Re: [Mesa-dev] [PATCH 2/2] glsl: Don't require matching interpolation qualifiers for newer GLSL

uxiliary qualification (e.g. centroid) may differ" Signed-off-by: Jordan Justen Cc: Tapani Pälli --- src/compiler/glsl/link_varyings.cpp | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/l

Re: [Mesa-dev] [PATCH v2] egl: support EGL_LARGEST_PBUFFER in eglCreatePbufferSurface(...)

ping Emil On 02/22/2016 08:00 AM, Tapani Pälli wrote: From: Daniel Czarnowski Patch provides a default for a set pbuffer surface size when EGL_LARGEST_PBUFFER is used by the client. MIN2 macro is moved to egldefines so that it can be shared. Fixes following Piglit test: egl-create

Re: [Mesa-dev] [PATCH] glsl: Initialize gl_shader_program::EmptyUniformLocations.

Reviewed-by: Tapani Palli On 02/29/2016 09:12 PM, Matt Turner wrote: Commit 65dfb30 added exec_list EmptyUniformLocations, but only initialized the list if ARB_explicit_uniform_location was enabled, leading to crashes if the extension was not available. Cc: "11.2" --- src/compiler/glsl/link

Re: [Mesa-dev] [PATCH 4/4] glx: fix error code when there is no context bound

s), wouldn't fixing glx-test be sufficient? On 02/11/2016 04:04 AM, Tapani Pälli wrote: From: Bernard Kilarski Signed-off-by: Bernard Kilarski Signed-off-by: Matt Roper Cc: "11.0 11.1" psc, attribute, value); @@ -166,7 +166,7 @@ glXQueryCurrentRendererStringMESA(int attribute) {

Re: [Mesa-dev] [PATCH] glsl: Detect do-while-false loops and unroll them

t does not otherwise affect the shader. The loop removed is the one the compiler inserts surrounding the switch statement. Orbital Explorer has a dead while loop because of commit 73dd50acf6d244979c2a657906aa56d3ac60d550 Author: Tapani Pälli Date: Wed Aug 6 09:46:54 2014 +0300 glsl: i

Re: [Mesa-dev] [PATCH 1/4] mapi_abi: Allow more dynamic entries

x27;t support, just add them. How about the proposal where we could calculate the amount based on the Khronos XML? https://lists.freedesktop.org/archives/mesa-dev/2016-February/107922.html On 02/11/2016 04:03 AM, Tapani Pälli wrote: From: Bernard Kilarski Signed-off-by: Bernard Kilarski S

Re: [Mesa-dev] change 396cbab, configs with accumulation buffer

On 02/22/2016 08:23 PM, Kenneth Graunke wrote: On Monday, February 22, 2016 12:25:45 PM PST Tapani Pälli wrote: On 02/22/2016 11:41 AM, Kenneth Graunke wrote: On Monday, February 22, 2016 8:06:35 AM PST Tapani Pälli wrote: Hi Marek; Was this commit fixing some issues/problems? Why would

Re: [Mesa-dev] change 396cbab, configs with accumulation buffer

On 02/22/2016 03:01 PM, Marek Olšák wrote: On Mon, Feb 22, 2016 at 1:48 PM, Tapani Pälli wrote: On 02/22/2016 02:27 PM, Marek Olšák wrote: On Mon, Feb 22, 2016 at 1:10 PM, Tapani Pälli wrote: On 02/22/2016 02:01 PM, Marek Olšák wrote: On Mon, Feb 22, 2016 at 7:06 AM, Tapani Pälli

Re: [Mesa-dev] change 396cbab, configs with accumulation buffer

On 02/22/2016 02:27 PM, Marek Olšák wrote: On Mon, Feb 22, 2016 at 1:10 PM, Tapani Pälli wrote: On 02/22/2016 02:01 PM, Marek Olšák wrote: On Mon, Feb 22, 2016 at 7:06 AM, Tapani Pälli wrote: Hi Marek; Was this commit fixing some issues/problems? Why would we not expose configs with

Re: [Mesa-dev] How to get uniform components used by uniform variables

On 02/22/2016 02:02 PM, Juan A. Suarez Romero wrote: On Mon, 2016-02-22 at 13:47 +0200, Tapani Pälli wrote: Maybe one way would be to include these matrices in UBO or SSBO and then query BUFFER_DATA_SIZE for that buffer. That should return "implementation-dependent minimum total buffer o

Re: [Mesa-dev] change 396cbab, configs with accumulation buffer

On 02/22/2016 02:01 PM, Marek Olšák wrote: On Mon, Feb 22, 2016 at 7:06 AM, Tapani Pälli wrote: Hi Marek; Was this commit fixing some issues/problems? Why would we not expose configs with accumulation buffer? EGL doesn't support accumulation buffers. So EGL would not expose

Re: [Mesa-dev] How to get uniform components used by uniform variables

On 02/22/2016 01:39 PM, Juan A. Suarez Romero wrote: Hello. I'm working on providing piglit with tests for the GL_ARB_gpu_shader_fp64 extension[1]. One of the modifications it does is referring uniform variables: "Modify Section 2.14.4, Uniform Variables, p. 89 (modify third paragraph, p.

Re: [Mesa-dev] change 396cbab, configs with accumulation buffer

On 02/22/2016 11:41 AM, Kenneth Graunke wrote: On Monday, February 22, 2016 8:06:35 AM PST Tapani Pälli wrote: Hi Marek; Was this commit fixing some issues/problems? Why would we not expose configs with accumulation buffer? --- 8< --- commit 396cbabbefaae64deac6d33c79898bb07db8a621 Aut

[Mesa-dev] change 396cbab, configs with accumulation buffer

Hi Marek; Was this commit fixing some issues/problems? Why would we not expose configs with accumulation buffer? --- 8< --- commit 396cbabbefaae64deac6d33c79898bb07db8a621 Author: Marek Olšák Date: Thu Apr 9 23:25:07 2015 +0200 egl/dri: don't expose configs with an accumulation buffer

[Mesa-dev] [PATCH v2] egl: support EGL_LARGEST_PBUFFER in eglCreatePbufferSurface(...)

From: Daniel Czarnowski Patch provides a default for a set pbuffer surface size when EGL_LARGEST_PBUFFER is used by the client. MIN2 macro is moved to egldefines so that it can be shared. Fixes following Piglit test: egl-create-largest-pbuffer-surface From EGL 1.5 spec: "Use EGL_LARGEST_P

Re: [Mesa-dev] [PATCH v2] egl_dri2: set correct error code if swapbuffers fails

On 02/19/2016 06:23 PM, Emil Velikov wrote: On 19 February 2016 at 05:40, Tapani Pälli wrote: Pinging Emil with this one .. Should have mentioned it beforehand - I pushed it yesterday. Hopefully others won't object :-) OK thanks, I cannot spot it in the current tree .. in case this c

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl: support EGL_LARGEST_PBUFFER in eglCreatePbufferSurface(...)

On 02/19/2016 07:34 AM, Tapani Pälli wrote: On 02/18/2016 08:19 PM, Emil Velikov wrote: Hi guys, On 15 February 2016 at 10:54, Tapani Pälli wrote: From: Daniel Czarnowski Patch provides a 'sane default' for a set pbuffer surface size when Perhaps too cheeky of a question but

Re: [Mesa-dev] [PATCH v2] egl_dri2: set correct error code if swapbuffers fails

Pinging Emil with this one .. On 02/15/2016 09:31 AM, Tapani Pälli wrote: From: Daniel Czarnowski A return value of '-1' means that there was error during swap with a window drawable, in this case we set error as EGL_BAD_NATIVE_WINDOW. v2: coding style cleanup, better commit messa

<    7   8   9   10   11   12   13   14   15   16   >