13,14,15
Reviewed-by: Tapani Pälli
On 11/29/2017 03:24 AM, Timothy Arceri wrote:
From: Jordan Justen
V2: call generic mesa_program_binary() helper rather than driver
function directly to allow greater code sharing.
Signed-off-by: Timothy Arceri
Signed-off-by: Jordan Justen (v1
Looks good, indeed KHR_image spec does not require KHR_image_pixmap or
KHR_image_base. Wayland might also be able to enable this but not sure
if makes sense there or not.
Reviewed-by: Tapani Pälli
On 07.12.2017 15:34, Harish Krupo wrote:
From android cts 8.0_r4, a new test case checks if
.
Reviewed-by: Tapani Pälli
On 29.11.2017 03:24, Timothy Arceri wrote:
From: Jordan Justen
V2 (Timothy Arceri):
- add extra code comment
- stop passing around void *binary and just pass
program_binary_header *hdr instead.
- move to src/mesa/main rather than src/util
V3 (Timothy Ar
Reviewed-by: Tapani Pälli
On 11/29/2017 03:24 AM, Timothy Arceri wrote:
From: Jordan Justen
The ARB_get_program_binary extension requires that uniform values in a
program be restored to their initial value just after linking.
This patch saves off the initial values just after linking. When
On 12/07/2017 01:47 PM, Tapani Pälli wrote:
Hi;
I've been testing this functionality with little app I have and I
noticed one thing by accident.
If I call link twice for a regular program like this:
glLinkProgram(program);
glLinkProgram(program);
everything's fine, sequentia
Hi;
I've been testing this functionality with little app I have and I
noticed one thing by accident.
If I call link twice for a regular program like this:
glLinkProgram(program);
glLinkProgram(program);
everything's fine, sequential calls do not generate errors. However for
program loaded v
Acked-by: Tapani Pälli
On 11/29/2017 03:24 AM, Timothy Arceri wrote:
From: Jordan Justen
Signed-off-by: Jordan Justen
---
docs/features.txt | 2 +-
docs/relnotes/17.4.0.html | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/features.txt b/docs
LGTM
Reviewed-by: Tapani Pälli
On 11/29/2017 03:24 AM, Timothy Arceri wrote:
From: Jordan Justen
This resolves an apparent game bug described in 85564. The game
doesn't properly handle ARB_get_program_binary with 0 supported
formats.
V2 (Timothy Arceri):
- less driver code as mor
On 04.12.2017 20:45, Marek Olšák wrote:
Do we need to handle B10G10R10X2 as well?
Good catch, that is missing indeed. Also noticed that dEQP wide color
test does not test BGRX.
Marek
On Wed, Nov 29, 2017 at 5:20 AM, Mario Kleiner
wrote:
This format + type combo is good for BGRA1010102 f
ping!
On 11/20/2017 09:18 AM, Tapani Pälli wrote:
This series enables mostly existing functionality but adds the disjoint
state required by this extension. WebGL tests seem to utilize desktop
extension GL_EXT_timer_query but I wrote a separate simple Piglit test
for this.
Tapani Pälli (4
Patches 9,10,11,12 LGTM
Reviewed-by: Tapani Pälli
On 29.11.2017 06:20, Mario Kleiner wrote:
Enables eglCreateImageKHR() with target set to
EGL_NATIVE_PIXMAP_KHR to handle color depth 30
X11 drawables.
Note that in theory the drawable depth 32 case in the
current implementation is ambiguous
Not sure of the end results of discussion on this drirc option but
personally I think it is good to have as temporary workaround.
Patches 7,8
Reviewed-by: Tapani Pälli
On 29.11.2017 06:20, Mario Kleiner wrote:
Allows to prevent exposing RGB10 configs and visuals to
clients.
v2: Rename
Reviewed-by: Tapani Pälli
On 29.11.2017 06:20, Mario Kleiner wrote:
Allow DRI3/Present buffer sharing for 10 bpc buffers.
Otherwise composited desktops under DRI3 will only display
black client areas for redirected windows.
Signed-off-by: Mario Kleiner
---
src/mesa/drivers/dri/i965
Reviewed-by: Tapani Pälli
On 29.11.2017 06:20, Mario Kleiner wrote:
Extend intel_miptree_blit() to handle at least
ARGB2101010 -> XRGB2101010, ARGB2101010 -> ARGB2101010,
and XRGB2101010 -> XRGB2101010 via the BLT engine,
but not XRGB2101010 -> ARGB2101010 yet.
This works as
Reviewed-by: Tapani Pälli
On 29.11.2017 06:20, Mario Kleiner wrote:
Makes compositing under X11/GLX work.
Signed-off-by: Mario Kleiner
---
src/mesa/drivers/dri/i965/intel_tex_image.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri
!
Update num_formats from 3 to 5, to keep the special Android
handling intact.
v3: Use num_formats = ARRAY_SIZE(formats) - 2 as suggested by Tapani,
to only exclude the last 2 Android formats, add Tapani's r-b.
Signed-off-by: Mario Kleiner
Reviewed-by: Tapani Pälli
---
src
TENCIL it is always intialized
but maybe initialize at declaration?
+ _mesa_unpack_float_z_row(texImage->TexFormat, 1 /* n */,
+ clearValue, &depthValue);
+ }
} else {
depthValue = 0.0f;
stencilValue = 0;
with warning c
Reviewed-by: Tapani Pälli
On 11/29/2017 09:10 PM, Chad Versace wrote:
It's array isl_drm.c:modifier_info[] .
---
src/intel/isl/isl_drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/isl/isl_drm.c b/src/intel/isl/isl_drm.c
index eb3c6f59138..31895e
On 11/30/2017 06:13 AM, Tomasz Figa wrote:
On Thu, Nov 30, 2017 at 3:43 AM, Robert Foss wrote:
Hey,
On Tue, 2017-11-28 at 11:49 +, Emil Velikov wrote:
On 28 November 2017 at 10:45, Tapani Pälli
wrote:
Hi;
On 11/27/2017 04:14 PM, Robert Foss wrote:
From: Tomasz Figa
There is no
On 29.11.2017 20:43, Robert Foss wrote:
Hey,
On Tue, 2017-11-28 at 11:49 +, Emil Velikov wrote:
On 28 November 2017 at 10:45, Tapani Pälli
wrote:
Hi;
On 11/27/2017 04:14 PM, Robert Foss wrote:
From: Tomasz Figa
There is no API available to properly query the
On 11/28/2017 07:38 PM, Rob Herring wrote:
On Tue, Nov 28, 2017 at 8:42 AM, Tomasz Figa wrote:
On Tue, Nov 28, 2017 at 11:27 PM, Rob Herring wrote:
On Tue, Nov 28, 2017 at 5:49 AM, Emil Velikov wrote:
On 28 November 2017 at 10:45, Tapani Pälli wrote:
Hi;
On 11/27/2017 04:14 PM
Hi;
On 11/27/2017 04:14 PM, Robert Foss wrote:
From: Tomasz Figa
There is no API available to properly query the IMPLEMENTATION_DEFINED
format. As a workaround we rely here on gralloc allocating either
an arbitrary YCbCr 4:2:0 or RGBX_, with the latter being recognized
by lock_ycbcr failin
On 11/15/2017 03:22 PM, Eduardo Lima Mitev wrote:
From: Alejandro Piñeiro
Ideally this should be generated somehow. One option would be gather
all the extension dependencies listed on the core grammar, but there
would be the possibility of not including some of the extensions.
Note that spir
Acked-by: Tapani Pälli
On 11/24/2017 04:25 PM, Emil Velikov wrote:
From: Emil Velikov
Add -fno-math-errno and -fno-trapping-math to the build.
Mesa does not depend on the functionality provided, thus this should
result in slightly faster code and smaller binaries.
Cc: Tapani Pälli
Cc: Rob
Acked-by: Tapani Pälli
On 11/24/2017 04:25 PM, Emil Velikov wrote:
From: Emil Velikov
The compiler will warns us when we're misusing undefined macros.
Note: this will trigger a bunch of warnings, which will be resolved
ASAP.
Cc: Tapani Pälli
Cc: Rob Herring
Signed-off-by: Emil Ve
On 11/23/2017 08:31 PM, Mario Kleiner wrote:
On 11/23/2017 06:45 PM, Ilia Mirkin wrote:
On Thu, Nov 23, 2017 at 12:35 PM, Marek Olšák wrote:
Hi everybody,
Mario, feel free to push your patches if you haven't yet. (except the
workaround)
Hi,
just started 10 minutes ago with rebasing my c
This fixes issues seen with certain versions of Unreal Engine 4 editor
and games built with that using GLSL 4.30.
v2: add driinfo_gallium change (Emil Velikov)
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97852
Bugzilla: https://bugs.freedesktop.org
On 11/23/2017 06:09 PM, Emil Velikov wrote:
On 23 November 2017 at 05:54, Tapani Pälli wrote:
This fixes issues seen with certain versions of Unreal Engine 4 editor
and games built with that using GLSL 4.30.
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id
This fixes issues seen with certain versions of Unreal Engine 4 editor
and games built with that using GLSL 4.30.
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97852
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103801
---
src/compiler/glsl
Forgot to add:
Cc: "17.3"
On 11/21/2017 08:35 AM, Tapani Pälli wrote:
When floating point textures are created on OpenGL ES 2.0, driver
is free to choose used internal format. Mesa makes this decision in
adjust_for_oes_float_texture. Error checking for glTexImage2D properly
checks
-CTS.gtf.GL2ExtensionTests.texture_float.texture_float
(when running test with MESA_GLES_VERSION_OVERRIDE=2.0)
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103227
---
src/mesa/main/teximage.c | 56 +++-
1 file changed, 55
On 11/20/2017 10:35 AM, Eduardo Lima Mitev wrote:
Ping? This patch fixes an active memory leak.
Any comments? Thanks.
How to reproduce this leak?
Eduardo
On 11/14/2017 11:18 PM, Eduardo Lima Mitev wrote:
In nir_cf_list_clone(), a state_clone object is initialized but never
freed, causin
Fixes: 4f82b1728719 ("i965: Rewrite disassembly annotation code")
Cc: Matt Turner
Signed-off-by: Tapani Pälli
---
src/intel/compiler/brw_fs_generator.cpp | 2 +-
src/intel/compiler/brw_vec4_generator.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/inte
This state will be used by EXT_disjoint_timer_query. As first
usage, patch sets DisjointOperation true when gpu reset happens.
Signed-off-by: Tapani Pälli
---
src/mesa/main/mtypes.h | 8
src/mesa/main/robustness.c | 1 +
2 files changed, 9 insertions(+)
diff --git a/src/mesa/main
This series enables mostly existing functionality but adds the disjoint
state required by this extension. WebGL tests seem to utilize desktop
extension GL_EXT_timer_query but I wrote a separate simple Piglit test
for this.
Tapani Pälli (4):
mesa: add DisjointOperation to gl_shared_state
i965
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/brw_queryobj.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_queryobj.c
b/src/mesa/drivers/dri/i965/brw_queryobj.c
index bd3f5738eb..b7885430c6 100644
--- a/src/mesa/drivers/dri/i965/brw_queryobj.c
Most entrypoints already available via other extensions like
GL_EXT_occlusion_query_boolean, GL_EXT_timer_query.
Signed-off-by: Tapani Pälli
---
src/mapi/glapi/gen/es_EXT.xml | 16
src/mapi/glapi/gen/gl_API.xml | 4 ++--
src/mesa/main/tests
imple' passes with these changes.
No changes/regression observed in Intel CI.
Signed-off-by: Tapani Pälli
---
src/mesa/main/extensions_table.h | 1 +
src/mesa/main/get.c | 17 +
src/mesa/main/get_hash_params.py | 5 +
src/mesa/main/glheader.h | 4
Reviewed-by: Tapani Pälli
On 11/16/2017 12:16 PM, Eric Engestrom wrote:
queryImage() takes an `int*`, compiler is warning about the
signed<->unsigned pointer mismatch.
Fixes: 0db36caa192b129cb4f2 "egl/wayland: Add a fallback when fourcc
query isn't supported"
I sent one small observation for patch 2, otherwise changes LGTM
Series is
Reviewed-by: Tapani Pälli
On 11/09/2017 11:57 PM, Adam Jackson wrote:
Testing the EXT_no_config_context series revealed that a bunch more
things were broken than I expected. While I work my way through that,
here'
On 11/09/2017 11:57 PM, Adam Jackson wrote:
This is perfectly legal in GL 3.0+.
Fixes piglit/glx-create-context-no-current-framebuffer.
glx-create-context-current-no-framebuffer
Signed-off-by: Adam Jackson
---
src/glx/drisw_glx.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions
Hi;
On 11/09/2017 07:03 PM, Eric Engestrom wrote:
On Thursday, 2017-11-09 09:40:43 +0200, Tapani Pälli wrote:
Patch adds support and capability to match with new surface attribute,
component type. Currently no configs with floating point type are exposed.
Have you tested android O with this
On 11/11/2017 10:14 AM, Jordan Justen wrote:
On 2017-11-09 03:16:46, Tapani Pälli wrote:
On 11/09/2017 08:42 AM, Jordan Justen wrote:
Signed-off-by: Jordan Justen
---
src/mesa/main/get_hash_params.py | 2 +-
src/mesa/main/mtypes.h | 3 +++
2 files changed, 4 insertions
On 11/09/2017 08:42 AM, Jordan Justen wrote:
Signed-off-by: Jordan Justen
---
src/mesa/main/get_hash_params.py | 2 +-
src/mesa/main/mtypes.h | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py
On 11/09/2017 11:43 AM, Tapani Pälli wrote:
AFAICT functionality is identical;
(except for the AutomaticSize check of course)
Reviewed-by: Tapani Pälli
On 11/09/2017 10:45 AM, Kenneth Graunke wrote:
This fixes the missing AutomaticSize handling in the ABO code, removes
a bunch of
AFAICT functionality is identical;
Reviewed-by: Tapani Pälli
On 11/09/2017 10:45 AM, Kenneth Graunke wrote:
This fixes the missing AutomaticSize handling in the ABO code, removes
a bunch of duplicated code, and drops an extra layer of wrapping around
brw_emit_buffer_surface_state().
---
src
-EGL.functional.choose_config.color_component_type_ext.fixed
dEQP-EGL.functional.choose_config.color_component_type_ext.float
Signed-off-by: Tapani Pälli
---
src/egl/drivers/dri2/egl_dri2.c | 2 ++
src/egl/main/eglapi.c | 1 +
src/egl/main/eglconfig.c| 9 +
src/egl/main/eglconfig.h
On 11/08/2017 08:59 AM, Timothy Arceri wrote:
On 08/11/17 16:58, Tapani Pälli wrote:
One question below ...
On 11/08/2017 03:41 AM, Timothy Arceri wrote:
When I introduced gl_shader_program_data one of the intentions was to
fix a bug where a failed linking attempt freed data required by a
On 11/08/2017 07:25 AM, Kenneth Graunke wrote:
On Thursday, November 2, 2017 1:48:34 AM PST Tapani Pälli wrote:
Patch exposes sRGB visuals and adds DRI integer query support for
__DRI2_RENDERER_HAS_FRAMEBUFFER_SRGB. Further changes make sure that
we mark if the app explicitly wanted sRGB and
One question below ...
On 11/08/2017 03:41 AM, Timothy Arceri wrote:
When I introduced gl_shader_program_data one of the intentions was to
fix a bug where a failed linking attempt freed data required by a
currently active program. However I seem to have failed to finish
hooking up the final step
On 11/06/2017 04:08 AM, Chih-Wei Huang wrote:
2017-11-03 19:02 GMT+08:00 Tapani Pälli :
On 11/03/2017 12:30 PM, Chih-Wei Huang wrote:
2017-11-03 15:47 GMT+08:00 Tapani Pälli :
Hi Chih-Wei;
This looks good to me. Only thing that causes a bit of headache is ...
what
is the difference between
On 11/03/2017 12:30 PM, Chih-Wei Huang wrote:
2017-11-03 15:47 GMT+08:00 Tapani Pälli :
Hi Chih-Wei;
This looks good to me. Only thing that causes a bit of headache is ... what
is the difference between PRODUCT_OUT, OUT_DIR and TARGET_OUT?
OUT_DIR is also set to "out" if it
Hi Chih-Wei;
This looks good to me. Only thing that causes a bit of headache is ...
what is the difference between PRODUCT_OUT, OUT_DIR and TARGET_OUT?
On 11/03/2017 09:36 AM, Chih-Wei Huang wrote:
The libraries are moved to /vendor since commit c3f75d48.
Clean all old files for incremental b
likov)
update num_formats correctly (reported by dev...@gmail.com)
v3: cleanup, remove redundant is_srgb
rename explicit_srgb as 'need_srgb' to follow style better
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102264
Bugzilla: https://bugs.
On 11/01/2017 06:33 PM, Jason Ekstrand wrote:
Do either of you mind if I cc the first one to stable? It does fix a
potential memory leak in the case where compilation fails.
IMO CC stable would be fine for that one.
On Wed, Nov 1, 2017 at 9:26 AM, Tapani Pälli <mailto:tapani
series
Reviewed-by: Tapani Pälli
On 11/01/2017 06:00 PM, Jason Ekstrand wrote:
It doesn't actually matter since the only user of push constants, i965,
ralloc_steals it back to NULL but it's more consistent and probably
fixes memory leaks in some error cases.
---
src/intel/compiler/
On 11/01/2017 04:55 PM, Jason Ekstrand wrote:
On Wed, Nov 1, 2017 at 7:53 AM, Jason Ekstrand <mailto:ja...@jlekstrand.net>> wrote:
On Fri, Oct 27, 2017 at 5:55 AM, Tapani Pälli
mailto:tapani.pa...@intel.com>> wrote:
Patch uses mem_ctx for allocation to ensure p
is OK with you. Let me know otherwise.
Yes, that is fine. I threw the stable tag in last minute 'just in case'.
On Fri, 2017-10-27 at 15:55 +0300, Tapani Pälli wrote:
Patch uses mem_ctx for allocation to ensure param array gets freed
later, in blorp clear case this happens in blorp_pa
==by 0x12EFC4AF: brw_blorp_clear_color (brw_blorp.c:1326)
==6164==by 0x12EFF72B: brw_clear (brw_clear.c:297)
Signed-off-by: Tapani Pälli
---
src/intel/compiler/brw_fs.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler
On 10/27/2017 12:57 PM, Kenneth Graunke wrote:
On Friday, October 27, 2017 2:08:36 AM PDT Emil Velikov wrote:
On 27 October 2017 at 07:52, Tapani Pälli wrote:
Valgrind shows that leak is caused by gen6_upload_push_constant, add
unref push_const_bo per stage to destructor to fix this (like
, Emil)
Fixes: 24891d7c05 ("i965: Store per-stage push constant BO pointers.")
Signed-off-by: Tapani Pälli
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/drivers/dri/i965/brw_context.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
brw_bo_unreference handles NULL case
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/brw_context.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b/src/mesa/drivers/dri/i965/brw_context.c
index c8de074638
Reviewed-by: Tapani Pälli
On 10/27/2017 01:48 AM, Mauro Rossi wrote:
Having moved gallium_dri.so library to /vendor/lib/dri
also symlinks need to be coherently created using TARGET_OUT_VENDOR insted of
TARGET_OUT
or all non Intel drivers will not be loaded with Android N and earlier,
thus
nt BO pointers.")
Signed-off-by: Tapani Pälli
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/drivers/dri/i965/brw_context.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b/src/mesa/drivers/dri/i965/brw_context.c
index c8de074638..
Reviewed-by: Tapani Pälli
On 10/26/2017 11:26 PM, Kenneth Graunke wrote:
According to the ARB_ES3_1_compatibility specification,
glGetFramebufferAttachmentParameteriv is supposed to accept BACK,
and it behaves exactly like BACK_LEFT.
Fixes a GL error in GFXBench 5 Aztec Ruins.
Cc: mesa-sta
On 10/24/2017 09:56 PM, Eric Anholt wrote:
Tapani Pälli writes:
From: Harish Krupo
Following test checking entrypoints passes:
dEQP-EGL.functional.get_proc_address.extension.gl_ext_occlusion_query_boolean
Piglit test 'ext_occlusion_query_boolean-any-samples' passes
gentle ping ..
(after this we could also enable GL_EXT_disjoint_timer_query and have
more queries available for gles)
On 10/04/2017 02:56 PM, Tapani Pälli wrote:
Some of the checks are valid for generic ES 3.2 as well.
Signed-off-by: Tapani Pälli
---
src/mesa/main/queryobj.c | 44
Maybe combine common items with ARB_texture_float check below? You could
introduce something like:
if (ctx->Extensions.ARB_texture_float ||
ctx->Extensions.OES_texture_half_float) {
...
}
if (ctx->Extensions.ARB_texture_float ||
ctx->Extensions.OES_texture_float) {
...
}
On 10/20/2017 11:
On 10/12/2017 11:14 PM, Dave Airlie wrote:
On 12 October 2017 at 18:22, Tapani Pälli wrote:
On 10/12/2017 11:14 AM, Dave Airlie wrote:
On 12 Oct. 2017 15:40, "Tapani Pälli" mailto:tapani.pa...@intel.com>> wrote:
On 10/12/2017 02:34 AM, Dave Airlie wrote:
On 10/09/2017 06:56 PM, Chad Versace wrote:
On Mon 25 Sep 2017, Tapani Pälli wrote:
On 09/22/2017 03:09 AM, Chad Versace wrote:
On Thu 21 Sep 2017, Tapani Pälli wrote:
Hi Chad;
The build works ok now on Android-IA. There is still something wrong with
'exec async' though.
On 10/12/2017 11:14 AM, Dave Airlie wrote:
On 12 Oct. 2017 15:40, "Tapani Pälli" <mailto:tapani.pa...@intel.com>> wrote:
On 10/12/2017 02:34 AM, Dave Airlie wrote:
From: Dave Airlie mailto:airl...@redhat.com>>
When I realigned the buffero
On 10/12/2017 02:34 AM, Dave Airlie wrote:
From: Dave Airlie
When I realigned the bufferobj code, I didn't see the getters
were different, realign the getters to work the same as ssbo.
Alternatively you could set these values as 0 in
bind_buffer_base_atomic_buffer()? Not sure if it's any b
ok another one too ...
On 10/10/2017 01:03 PM, Tapani Pälli wrote:
one error found below ..
On 10/10/2017 05:45 AM, Timothy Arceri wrote:
While modern pthread mutexes are very fast, they still incur a call to an
external DSO and overhead of the generality and features of pthread
mutexes
_formats = ARRAY_SIZE(formats);
else
- num_formats = 3;
+ num_formats = 5;
How about following:
num_formats = ARRAY_SIZE(formats) - 2; /* all - RGBA_ORDERING formats */
(I'm suggesting it here https://patchwork.freedesktop.org/patch/177410/)
Not a big deal though, with or without
Reviewed-by: Tapani Pälli
I think this fix can/should land separately from the set.
On 10/06/2017 07:11 PM, Mario Kleiner wrote:
Commit 731ba6924a2ed6cdf47a78fd637a91a19ddcf9ed
"expose RGBA visuals only on Android" replaced
ARRAY_SIZE(formats) by num_formats, but there are
3 loops
one error found below ..
On 10/10/2017 05:45 AM, Timothy Arceri wrote:
While modern pthread mutexes are very fast, they still incur a call to an
external DSO and overhead of the generality and features of pthread mutexes.
Most mutexes in mesa only needs lock/unlock, and the idea here is that we
It's possible that this series could help with CPU intensive 3DMark ...
FYI Yogesh.
On 10/10/2017 05:45 AM, Timothy Arceri wrote:
After a recent discussion about this code from 2015 I was curious
to give it a try. The outstanding review item was that we shouldn't
be replacing the C11 mtx type/
On 09/28/2017 03:11 AM, Chad Versace wrote:
This patch prevents compilation failures in upcoming Android Vulkan
patches, failures due to redefinition of LOG_TAG in Android system
headers.
This patch does not change the value of LOG_TAG. It remains
"INTEL-MESA". (I don't like it, though. The al
CID: 1419033
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_image.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 487ff27594..c8ebdce0b4 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
On 10/06/2017 03:00 AM, Jason Ekstrand wrote:
On Wed, Oct 4, 2017 at 6:32 AM, Tapani Pälli <mailto:tapani.pa...@intel.com>> wrote:
Change b3a44ae7a4 caused regressions on Android where DRI and
renderbuffer
can disagree on the format being used. This patch removes the c
wanted
but take format from renderbuffer instead of DRI image.
This patch fixes regressions seen with following test sets:
dEQP-EGL.functional.color_clears*
dEQP-EGL.functional.render*
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102999
---
src/mesa
Some of the checks are valid for generic ES 3.2 as well.
Signed-off-by: Tapani Pälli
---
src/mesa/main/queryobj.c | 44
1 file changed, 44 insertions(+)
diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
index 46535d7b4c..d966814a76
r Intel CI.
v2: add es2="2.0" for glapi entrypoints, clean up xml
dispatch_sanity changes (fix 'make check')
Signed-off-by: Harish Krupo
Signed-off-by: Tapani Pälli
---
src/mapi/glapi/gen/es_EXT.xml | 51 +
src/mesa/main/extensi
FYI I've tested this series using your 'preemption' branch on KBL and
'egl-context-priority' test passes. The other Piglit test I sent
('egl-context-priority-runtime') does not always pass but I think the
problem is actually in the test itself, it's making assumptions that are
not true. I will
Fixes: 848da66222 ("intel: use a flag instead of setting PYTHONPATH")
Signed-off-by: Tapani Pälli
---
src/intel/Android.compiler.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/Android.compiler.mk b/src/intel/Android.compiler.mk
index 37d75b5679..
On 10/02/2017 01:05 AM, Rob Herring wrote:
FYI, 2 Android build errors on i965 and r600 started in the last week.
I've been traveling and haven't investigated.
Sorry, I've been busy debugging some regressions we have. I'll send a
fix for the i965 build in a minute. It broke due to build syst
On 09/27/2017 08:57 PM, Rob Herring wrote:
On Wed, Sep 27, 2017 at 12:38 PM, Eric Anholt wrote:
Dylan Baker writes:
[ Unknown signature status ]
I've gone ahead and pushed the Vulkan drivers meson builds.
For those interested in helping finish the conversion, I have a branch
"wip/meson-4"
Reviewed-by: Tapani Pälli
On 09/28/2017 02:26 AM, Dylan Baker wrote:
Signed-off-by: Dylan Baker
CC: Kristian Høgsberg
---
src/intel/vulkan/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/meson.build b/src/intel/vulkan/meson.build
index
On 09/22/2017 03:09 AM, Chad Versace wrote:
On Thu 21 Sep 2017, Tapani Pälli wrote:
Hi Chad;
The build works ok now on Android-IA. There is still something wrong with
'exec async' though. It behaves differently with small/big apps but
eventually I think it just starts to block ..
Reviewed-by: Tapani Pälli
On 09/21/2017 06:28 PM, Rob Herring wrote:
As part of Treble project in Android O, all the device specific files have
to be located in a separate vendor partition. This is done by setting
LOCAL_PROPRIETARY_MODULE (the name is misleading). This change will not
break
that. Please
don't consider that to be a blocker though, we can easily carry such
patch in Android-IA and debug it further.
For this patch:
Reviewed-by: Tapani Pälli
On 09/19/2017 12:44 AM, Chad Versace wrote:
This implementation is correct (afaict), but takes two shortcuts
regarding th
Reviewed-by: Tapani Pälli
On 09/21/2017 10:22 AM, Topi Pohjolainen wrote:
CID: 1418110
Fixes: 939b53d3325 "i965/screen: Implement queryDmaBufFormatModifierAttirbs"
CC: Jason Ekstrand
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_screen.c | 2 ++
1 file
This is already done for other programs stages, fixes a leak when using
compute programs.
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102844
---
src/mesa/main/context.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/main/context.c b/src
On 09/20/2017 12:57 AM, Rob Herring wrote:
As part of Treble project in Android O, all the device specific files have
to be located in a separate vendor partition. This is done by setting
LOCAL_PROPRIETARY_MODULE (the name is misleading). This change will not
break existing platforms without a
likov)
update num_formats correctly (reported by dev...@gmail.com)
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102264
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102354
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102503
---
I've te
On 09/15/2017 07:40 PM, Matt Turner wrote:
On Thu, Sep 14, 2017 at 12:26 AM, Tapani Pälli wrote:
fixes following warning:
warning: format specifies type 'long' but the argument has type 'uint64_t'
(aka 'unsigned long long')
cast is needed to avoid this tu
On 09/15/2017 01:06 AM, Chad Versace wrote:
This implementation is correct (afaict), but takes two shortcuts
regarding the import/export of Android sync fds.
Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync
fd into a VkSemaphore or VkFence, the driver instead simply
On 09/14/2017 09:31 PM, Jordan Justen wrote:
On 2017-09-14 00:26:39, Tapani Pälli wrote:
fixes following warning:
warning: format specifies type 'long' but the argument has type 'uint64_t'
(aka 'unsigned long long')
cast is needed to avoid this turning
On 09/14/2017 07:54 PM, Rob Herring wrote:
On Thu, Sep 14, 2017 at 1:57 AM, Tapani Pälli wrote:
Following changes are made to support VK_ANDROID_native_buffer:
- bring in vk_android_native_buffer.xml
- rename target as vulkan.$(TARGET_BOARD_PLATFORM)
- use
On 09/15/2017 01:09 AM, Chad Versace wrote:
On Thu 14 Sep 2017, Emil Velikov wrote:
On 14 September 2017 at 07:57, Tapani Pälli wrote:
Other WSI implementations set has_exec_async false for WSI buffers,
so far haven't found a place to do it so we just claim to not have
async exec.
W
601 - 700 of 2141 matches
Mail list logo
