[Mesa-dev] [PATCH] glsl: make a copy of array indices that are used to deref a function out param

2018-07-15 Thread Timothy Arceri
Fixes new piglit test: tests/spec/glsl-1.20/execution/qualifiers/vs-out-conversion-int-to-float-vec4-index.shader_test --- src/compiler/glsl/ast_function.cpp | 94 ++ 1 file changed, 94 insertions(+) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/

Re: [Mesa-dev] [PATCH 9/9] winsys/amdgpu: pass the BO list via the CS ioctl on DRM >= 3.27.0

2018-07-12 Thread Timothy Arceri
On 12/07/18 19:00, Michel Dänzer wrote: On 2018-07-12 07:26 AM, Marek Olšák wrote: From: Marek Olšák TODO: requires latest libdrm for amdgpu_bo_handle_type_kms_noimport --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 6 +++ src/gallium/winsys/amdgpu/drm/amdgpu_bo.h | 2 + src/gallium/w

Re: [Mesa-dev] [PATCH 7/9] radeonsi: rework RADEON_PRIO flags to be <= 31

2018-07-11 Thread Timothy Arceri
Two suggestions below. On 12/07/18 15:26, Marek Olšák wrote: From: Marek Olšák This decreases sizeof(struct amdgpu_cs_buffer) from 24 to 16 bytes. --- src/gallium/drivers/radeon/radeon_winsys.h| 39 ++- src/gallium/drivers/radeonsi/si_debug.c | 2 +- src/gallium/

Re: [Mesa-dev] [PATCH 9/9] winsys/amdgpu: pass the BO list via the CS ioctl on DRM >= 3.27.0

2018-07-11 Thread Timothy Arceri
On 12/07/18 15:26, Marek Olšák wrote: From: Marek Olšák TODO: requires latest libdrm for amdgpu_bo_handle_type_kms_noimport Forgot to bump this? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo

Re: [Mesa-dev] [PATCH 00/18] anv/pipeline: Do cross-stage linking

2018-07-11 Thread Timothy Arceri
On 12/07/18 07:18, Jason Ekstrand wrote: I sent out a series for this almost a year ago and it just sat on the list rotting away. You can find the original series here: https://patchwork.freedesktop.org/series/32809/ This v2 is a rebase of that series. I believe Tim reviewed most of the origi

Re: [Mesa-dev] Loop unrolling and if statement opts

2018-07-11 Thread Timothy Arceri
On 11/07/18 19:45, Eero Tamminen wrote: Hi, On 11.07.2018 12:00, Timothy Arceri wrote: On 11/07/18 18:20, Eero Tamminen wrote: Have you considered partial loop unrolling support? I.e. when loop counter is known, but too high for full unroll, doing partial loop unrolling (e.g. unroll 4x

Re: [Mesa-dev] Loop unrolling and if statement opts

2018-07-11 Thread Timothy Arceri
nroll limits on the Talos benchmark for RADV. I guess it might be interesting to try partial unrolling with that Game, it would be good to know where else it might help. - Eero On 11.07.2018 09:48, Timothy Arceri wrote: This series started out as me trying to unrolls some useless lo

[Mesa-dev] [PATCH 08/10] nir: add loop unroll support for complex wrapper loops

2018-07-10 Thread Timothy Arceri
In GLSL IR we cheat with switch statements and simply convert them into loops with a single iteration. This allowed us to make use of the existing jump instruction handling provided by the loop handing code, it also allows dead code to be cleaned up once we have wrapped the code in a loop. However

[Mesa-dev] [PATCH 07/10] nir: add loop unroll support for wrapper loops

2018-07-10 Thread Timothy Arceri
This adds support for unrolling the classic do { // ... } while (false) that is used to wrap multi-line macros. GLSL IR also wraps switch statements in a loop like this. shader-db results IVB: total loops in shared programs: 2515 -> 2512 (-0.12%) loops in affected programs: 33 -

[Mesa-dev] [PATCH 06/10] nir/opt_loop_unroll: Remove unneeded phis if we make progress

2018-07-10 Thread Timothy Arceri
Now that SSA values can be derefs and they have special rules, we have to be a bit more careful about our LCSSA phis. In particular, we need to clean up in case LCSSA ended up creating a phi node for a deref. This avoids validation issues with some CTS tests with the new patch, but its possible th

[Mesa-dev] [PATCH 09/10] nir: evaluate loop terminator ior use

2018-07-10 Thread Timothy Arceri
Here we replace one side of the ior with NIR_TRUE if the src is a loop terminators condition that we know can only be true. No shader-db change. --- src/compiler/nir/nir_opt_if.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir

[Mesa-dev] [PATCH 10/10] nir: evaluate loop terminator ior use when false

2018-07-10 Thread Timothy Arceri
This allows some loops to unroll were they are guaranteed to exit after the first iteration. For example: loop { block block_1: /* preds: block_0 block_13 */ vec1 32 ssa_85 = load_const (0x0002 /* 0.00 */) vec1 32 ssa_

[Mesa-dev] [PATCH 04/10] nir: always attempt to find loop terminators

2018-07-10 Thread Timothy Arceri
This will help later patches with unrolling loops that end with a break i.e. loops the always exit on their first interation. --- src/compiler/nir/nir_loop_analyze.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir_loop_analyze.c b/src/compil

[Mesa-dev] [PATCH 05/10] nir: add complex_loop bool to loop info

2018-07-10 Thread Timothy Arceri
In order to be sure loop_terminator_list is an accurate representation of all the jumps in the loop we need to be sure we didn't encounter any other complex behaviour such as continues, nested breaks, etc during analysis. This will be used in the following patch. --- src/compiler/nir/nir.h

[Mesa-dev] [PATCH 02/10] nir: evaluate loop terminator condition uses

2018-07-10 Thread Timothy Arceri
For simple loop terminators we can evaluate all further uses of the condition in the loop because we know we must have either exited the loop or we have a known value. shader-db results IVB (all changes from dolphin uber shaders): total instructions in shared programs: 10022822 -> 10018187 (-0.05

[Mesa-dev] [PATCH 03/10] nir: allow more nested loops to be unrolled

2018-07-10 Thread Timothy Arceri
The innermost check was added to stop us from unrolling multiple loops in a single pass, and to stop outer loops from unrolling. When we successfully unroll a loop we need to run the analysis pass again before deciding if we want to go ahead an unroll a second loop. However the logic was flawed b

[Mesa-dev] Loop unrolling and if statement opts

2018-07-10 Thread Timothy Arceri
This series started out as me trying to unrolls some useless loops I spotted in some shaders from DXVK games (see patch 10), but I found some other issues and improvements along the way. The biggest winner seem like it could be the dolphin uber shaders on i965 (on radeonsi the shaders don't seem t

[Mesa-dev] [PATCH 01/10] nir: evaluate if condition uses inside the if branches

2018-07-10 Thread Timothy Arceri
Since we know what side of the branch we ended up on we can just replace the use with a constant. All helped shaders are from Unreal Engine 4 besides one shader from Dirt Showdown. shader-db results SKL: total instructions in shared programs: 13219725 -> 13219643 (<.01%) instructions in affected

Re: [Mesa-dev] [PATCH] nir/linker: fix msvc build

2018-07-03 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 04/07/18 11:51, srol...@vmware.com wrote: From: Roland Scheidegger Empty initializer braces aren't valid c (it's a gnu extension, and it's valid in c++). Hopefully fixes appveyor / msvc build... Fixes 6677e131b806b10754adcb7cf3f427a7fcc2aa09 ---

[Mesa-dev] [PATCH] mesa: enable ARB_direct_state_access in OpenGL 4.5 compat profile

2018-07-03 Thread Timothy Arceri
Its unlikely anyone will add proper ARB_direct_state_access compat support before we branch 18.2. Enabling the extension in 4.5 at least allows users to make use of MESA_GL_VERSION_OVERRIDE=4.5COMPAT for games like No Mans Sky. --- src/mapi/glapi/gen/apiexec.py| 194 +++

[Mesa-dev] [PATCH] util/drirc: turn on force_glsl_extensions_warn for No Mans Sky

2018-07-03 Thread Timothy Arceri
The game forgets to enable multiple extensions in its shaders, one of those extesions is EXT_texture_array. But enabling this config entry fixes at least one other rendering issue that enabling EXT_texture_array on its own doesn't fix. --- src/util/drirc | 4 1 file changed, 4 insertions(+)

Re: [Mesa-dev] [PATCH 4/4] Shorten u_queue names

2018-07-03 Thread Timothy Arceri
Series: Reviewed-by: Timothy Arceri On 04/07/18 09:16, Marek Olšák wrote: From: Marek Olšák There is a 15-character limit for thread names shared by the queue name and process name. Shorten the thread name to make space for the process name. --- src/gallium/auxiliary/util

Re: [Mesa-dev] [PATCH] st/nir: Disable varying packing when doing transform feedback.

2018-07-03 Thread Timothy Arceri
On 03/07/18 05:51, Eric Anholt wrote: Eric Anholt writes: [ Unknown signature status ] Timothy Arceri writes: nir_compact_varyings() is meant to skip over varyings used by xfb: /* We can't repack xfb varyings. */ if (var->data.always_a

Re: [Mesa-dev] [PATCH v2 00/16] ARB_gl_spirv series 3 v2: support for atomic counters

2018-07-02 Thread Timothy Arceri
Series looks good to me. How much to go before we can turn this extension on? On 03/07/18 00:58, Alejandro Piñeiro wrote: Hi Timothy. Thanks for the quick review! As you suggested some squash and commit drops, Im resending the v2 of the series, just in case you want a final overview of the ser

Re: [Mesa-dev] [PATCH 13/16] nir: Fix OpAtomicCounterIDecrement for uniform atomic counters

2018-07-02 Thread Timothy Arceri
Thanks. Reviewed-by: Timothy Arceri On 03/07/18 00:58, Alejandro Piñeiro wrote: From: Antia Puentes From the SPIR-V 1.0 specification, section 3.32.18, "Atomic Instructions": "OpAtomicIDecrement: The instruction's result is the Original Value

Re: [Mesa-dev] [PATCH 11/16] nir/types: Add wrappers for a couple of atomic counter methods

2018-07-02 Thread Timothy Arceri
you missed my r-b here ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 5.0

2018-07-01 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 02/07/18 05:50, Marek Olšák wrote: From: Marek Olšák Users are encouraged to switch to LLVM 6.0 released in March 2018. --- .travis.yml | 24 ++-- configure.ac | 4 +- meson.build

Re: [Mesa-dev] [PATCH 16/18] mesa/glspirv: lower workgroup access to offsets

2018-06-30 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 30/06/18 00:29, Alejandro Piñeiro wrote: From: Antia Puentes This will perform the CS shared lowering. See 8761a04d0d93 --- src/mesa/main/glspirv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c index

Re: [Mesa-dev] [PATCH 18/18] i965: Use the new nir atomic counter linker for SPIR-V shaders

2018-06-30 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 30/06/18 00:29, Alejandro Piñeiro wrote: From: Neil Roberts --- src/mesa/drivers/dri/i965/brw_link.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/dri/i965/brw_link.cpp index 8bc97fa4f3e

Re: [Mesa-dev] [PATCH 17/18] i965: enable AtomicStorage capability for gen7+

2018-06-30 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 30/06/18 00:29, Alejandro Piñeiro wrote: That is the same gen requirement for ARB_shader_atomic_counters. --- src/mesa/drivers/dri/i965/brw_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa

Re: [Mesa-dev] [PATCH 15/18] nir: Fix OpAtomicCounterIDecrement for uniform atomic counters

2018-06-30 Thread Timothy Arceri
On 30/06/18 00:29, Alejandro Piñeiro wrote: From: Antia Puentes From the SPIR-V specification, OpAtomicIDecrement: "The instruction's result is the Original Value." However, we were implementing it, for uniform atomic counters, as a pre-decrement operation. Renamed the former nir intrinsic

Re: [Mesa-dev] [PATCH 14/18] nir/linker: Add a pure NIR implementation of the atomic counter linker

2018-06-29 Thread Timothy Arceri
patches 10-14 are: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 07/18] spirv/nir: tweak nir type when storage class is SpvStorageClassAtomicCounter

2018-06-29 Thread Timothy Arceri
Patches 4-7: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 09/18] nir/spirv: Fix atomic counter (multidimensional-)arrays

2018-06-29 Thread Timothy Arceri
There is no need to pass storage_class to this function. We should just let the caller check that which it does. If you agree with the changes. This patch is: Reviewed-by: Timothy Arceri + + return atomic; +} + nir_deref_instr * vtn_pointer_to_deref(struct vtn_builder *b, struct vtn_p

Re: [Mesa-dev] [PATCH 08/18] compiler: utility to get the depth of multidimensional array

2018-06-29 Thread Timothy Arceri
NAK this shouldn't be needed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 03/18] nir/linker: use empty block info to assign uniform locations

2018-06-29 Thread Timothy Arceri
UniformRemapTable += entries; + unsigned chosen_location = Please move patch 2 to patch 1 and squash with this one with the current patch 1. This is just code churn. As with my review of patch 1 please rename chosen_location -> location Otherwise: Reviewed-by: Timothy Arceri +

Re: [Mesa-dev] [PATCH 02/18] compiler/glsl: refactor empty_uniform_block utilities to linker_util

2018-06-29 Thread Timothy Arceri
+++ b/src/compiler/glsl/linker_util.cpp @@ -24,6 +24,7 @@ #include "main/mtypes.h" #include "linker_util.h" #include "util/set.h" +#include "compiler/glsl/ir_uniform.h" /* for gl_uniform_storage */ This only needs to be #include "ir_uniform.h" With that this patch is: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/18] nir/linker: handle uniforms without explicit location

2018-06-29 Thread Timothy Arceri
On 30/06/18 16:05, Timothy Arceri wrote: On 30/06/18 00:28, Alejandro Piñeiro wrote: ARB_gl_spirv points that uniforms in general need explicit location. But there are still some cases of uniforms without location, like for example uniform atomic counters. Those doesn't have a location

Re: [Mesa-dev] [PATCH 01/18] nir/linker: handle uniforms without explicit location

2018-06-29 Thread Timothy Arceri
and use those first. */ + unsigned chosen_location = prog->NumUniformRemapTable; Can we please just rename chosen_location With those two nits this patch is: Reviewed-by: Timothy Arceri + + /* resize remap table to fit new entries */ + prog->UniformRem

Re: [Mesa-dev] [PATCH 6/6] anv: Add support for the on-disk shader cache

2018-06-29 Thread Timothy Arceri
Series: Reviewed-by: Timothy Arceri On 30/06/18 13:44, Jason Ekstrand wrote: --- src/intel/vulkan/anv_device.c | 36 ++ src/intel/vulkan/anv_pipeline_cache.c | 98 --- src/intel/vulkan/anv_private.h| 3 + 3 files changed, 126 insertions

Re: [Mesa-dev] [PATCH] glsl/cache: save and restore ExternalSamplersUsed

2018-06-29 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 30/06/18 14:59, Marek Olšák wrote: From: Marek Olšák Shaders that need special code for external samplers were broken if they were loaded from the cache. Cc: 18.1 --- src/compiler/glsl/serialize.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src

Re: [Mesa-dev] [PATCH v2 6/9] nir: Add a large constants optimization pass

2018-06-29 Thread Timothy Arceri
src_deref = nir_src_as_deref(intrin->src[0]); +break; + + case nir_intrinsic_copy_deref: Can we add a comment here? Something like: /* We always assume the src and therefore the dst are not constants * here. Copy and constant propagation passes should have taken

Re: [Mesa-dev] [PATCH 19/19] i965: Support saving the gen program with glGetProgramBinary

2018-06-29 Thread Timothy Arceri
I've sent some minor nits. Otherwise the series looks good, although I did only skim most of the actual new i965 blob changes. Series: Reviewed-by: Timothy Arceri You might want to wait for Tapani to take a look also. On 15/05/18 02:52, Jordan Justen wrote: Signed-off-by: Jordan J

Re: [Mesa-dev] [PATCH 16/19] i965: Add brw_populate_default_key

2018-06-29 Thread Timothy Arceri
On 15/05/18 02:52, Jordan Justen wrote: We will need to populate the default key for ARB_get_program_binary to allow us to retrieve the default gen program to store save in the store save - > store ??? program binary. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_cs.c

Re: [Mesa-dev] [PATCH 09/19] i965: Add brw_stage_cache_id to map gl stages to brw cache_ids

2018-06-29 Thread Timothy Arceri
On 15/05/18 02:52, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_program_cache.c | 15 +++ src/mesa/drivers/dri/i965/brw_state.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c b

Re: [Mesa-dev] [PATCH 03/19] st/mesa: i965: Use ShaderCacheSerializeDriverBlob driver function

2018-06-29 Thread Timothy Arceri
The subject line contains i965: On 15/05/18 02:52, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/state_tracker/st_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index ee76e07a7d1..0d0

Re: [Mesa-dev] [PATCH] glsl: enable EXT_texture_array by default in 1.30

2018-06-29 Thread Timothy Arceri
s exposing functions incorrectly). Guess its back to adding another drirc entry and config option. On Fri, Jun 29, 2018 at 12:42 AM, Timothy Arceri wrote: This extension was made core in OpenGL 3.0. This fixes rendering issues in No Man's Sky. --- src/compiler/glsl/builtin_functions.cpp |

[Mesa-dev] [PATCH v2 14/18] mesa: add compat profile support for ARB_multi_draw_indirect

2018-06-29 Thread Timothy Arceri
v2: add missing ARB_base_instance support --- src/mesa/main/extensions_table.h | 2 +- src/mesa/vbo/vbo_exec_array.c| 77 +++- 2 files changed, 76 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index

[Mesa-dev] [PATCH v2 12/18] mesa: add ARB_draw_indirect support to compat profile

2018-06-29 Thread Timothy Arceri
v2: add missing ARB_base_instance support --- src/mesa/main/bufferobj.c| 3 +- src/mesa/main/extensions_table.h | 2 +- src/mesa/vbo/vbo_exec_array.c| 71 +++- 3 files changed, 72 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/

[Mesa-dev] [PATCH] glsl: enable EXT_texture_array by default in 1.30

2018-06-28 Thread Timothy Arceri
This extension was made core in OpenGL 3.0. This fixes rendering issues in No Man's Sky. --- src/compiler/glsl/builtin_functions.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/builtin_functions.cpp b/src/compiler/glsl/builtin_functions.cpp index

[Mesa-dev] [PATCH 10/18] mesa: add missing display list support for ARB_compute_shader

2018-06-27 Thread Timothy Arceri
The extension is enabled for compat profile but there is currently no display list support. I filed a spec bug and it has been agreed that glDispatchComputeIndirect should generate an INVALID_OPERATION error when called during display list compilation. --- src/mesa/main/dlist.c | 39 +

[Mesa-dev] [PATCH 18/18] radeonsi: enable OpenGL 4.4 compat profile

2018-06-27 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_get.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index 0e8617d0fee..96ff2a9e46b 100644 --- a/src/gallium/drivers/radeonsi/si_get.c +++ b/src/gallium/dr

[Mesa-dev] [PATCH 17/18] mesa: enable ARB_vertex_attrib_64bit in compat profile

2018-06-27 Thread Timothy Arceri
--- src/mapi/glapi/gen/apiexec.py | 20 ++-- src/mesa/main/extensions_table.h| 2 +- src/mesa/main/tests/dispatch_sanity.cpp | 23 --- src/mesa/main/vtxfmt.c | 2 +- 4 files changed, 24 insertions(+), 23 deletions(-) diff --

[Mesa-dev] [PATCH 15/18] vbo_save: add support for doubles to display list code

2018-06-27 Thread Timothy Arceri
From: Dave Airlie Required for ARB_vertex_attrib_64bit compat profile support. --- src/mesa/main/mtypes.h | 2 +- src/mesa/vbo/vbo_private.h | 3 +++ src/mesa/vbo/vbo_save_api.c | 18 -- src/mesa/vbo/vbo_save_draw.c | 18 +- 4 files changed, 29 insertio

[Mesa-dev] [PATCH 12/18] mesa: add ARB_draw_indirect support to compat profile

2018-06-27 Thread Timothy Arceri
--- src/mesa/main/bufferobj.c| 3 +- src/mesa/main/extensions_table.h | 2 +- src/mesa/vbo/vbo_exec_array.c| 66 +++- 3 files changed, 67 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 67f9cd0a902..1

[Mesa-dev] [PATCH 16/18] mesa: add outstanding ARB_vertex_attrib_64bit dlist support

2018-06-27 Thread Timothy Arceri
--- src/mesa/main/dlist.c | 178 ++ 1 file changed, 178 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 5ff0a23018c..ae23d292837 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -471,6 +471,10 @@ typedef enum

[Mesa-dev] [PATCH 05/18] mesa: add glUniformSubroutinesuiv() display list support

2018-06-27 Thread Timothy Arceri
--- src/mesa/main/dlist.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index d49eebae00d..2425cf24f1b 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -523,6 +523,9 @@ typedef enum /* ARB_

[Mesa-dev] [PATCH 11/18] mesa: generate GL_INVALID_OPERATION using draw indirect in dlist

2018-06-27 Thread Timothy Arceri
The spec doesn't explicitly say to generate an error but since DrawArraysInstanced* and DrawElementsInstanced* do, it makes sense to do it for these functions also. --- src/mesa/main/dlist.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/src/mesa/m

[Mesa-dev] [PATCH 14/18] mesa: add compat profile support for ARB_multi_draw_indirect

2018-06-27 Thread Timothy Arceri
--- src/mesa/main/extensions_table.h | 2 +- src/mesa/vbo/vbo_exec_array.c| 75 +++- 2 files changed, 74 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index 1446a4bd421..12b796777df 100644 --- a/src/

[Mesa-dev] [PATCH 08/18] mesa: enable ARB_viewport_array in compat profile

2018-06-27 Thread Timothy Arceri
--- src/mapi/glapi/gen/apiexec.py | 16 src/mesa/main/extensions_table.h| 2 +- src/mesa/main/tests/dispatch_sanity.cpp | 17 + 3 files changed, 18 insertions(+), 17 deletions(-) diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/ap

[Mesa-dev] [PATCH 13/18] mesa: make valid_draw_indirect_multi() accessible externally

2018-06-27 Thread Timothy Arceri
We will use this to add compat support to ARB_multi_draw_indirect in the following patch. --- src/mesa/main/draw_validate.c | 24 src/mesa/main/draw_validate.h | 3 +++ 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/draw_validate.c b/src/me

[Mesa-dev] [PATCH 06/18] mesa: enable ARB_shader_subroutine in compat profile

2018-06-27 Thread Timothy Arceri
--- src/mapi/glapi/gen/apiexec.py | 16 src/mesa/main/extensions_table.h| 2 +- src/mesa/main/tests/dispatch_sanity.cpp | 19 +-- 3 files changed, 18 insertions(+), 19 deletions(-) diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/

[Mesa-dev] [PATCH 02/18] mesa: add ProgramUniform*d display list support

2018-06-27 Thread Timothy Arceri
This is required for fp64 to be enabled in compat profile. --- src/mesa/main/dlist.c | 514 ++ 1 file changed, 514 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index aec373b7ab1..d49eebae00d 100644 --- a/src/mesa/main/dlist.c +++

[Mesa-dev] [PATCH 09/18] mesa: expose some ARB_viewport_array dependent extensions in compat

2018-06-27 Thread Timothy Arceri
--- src/mesa/main/extensions_table.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index f04fea9e3bc..f79a52cee8c 100644 --- a/src/mesa/main/extensions_table.h +++ b/src/mesa/main/extensions_table.h @@ -1

[Mesa-dev] [PATCH 07/18] mesa: add ARB_viewport_array display list support

2018-06-27 Thread Timothy Arceri
--- src/mesa/main/dlist.c | 211 ++ 1 file changed, 211 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 2425cf24f1b..b2b1f723a17 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -290,6 +290,15 @@ typedef enum

[Mesa-dev] Radeonsi OpenGL 4.4 compat profile support

2018-06-27 Thread Timothy Arceri
Sorry to keep spamming the list with this stuff, but Dave helped out with ARB_vertex_attrib_64bit support and the spec bug I submitted for indirect compute dispatch was resolved so it seemed like a good idea to send it all out again together with these updates. Pretty much everything has correspon

[Mesa-dev] [PATCH 01/18] mesa: add Uniform*d support to display lists

2018-06-27 Thread Timothy Arceri
This is required so we can enable fp64 support in compat profile. --- src/mapi/glapi/gen/apiexec.py | 36 +-- src/mesa/main/dlist.c | 493 ++ 2 files changed, 511 insertions(+), 18 deletions(-) diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/ge

[Mesa-dev] [PATCH 03/18] mesa: enable ARB_gpu_shader_fp64 in compat profile

2018-06-27 Thread Timothy Arceri
--- src/mesa/main/extensions_table.h| 2 +- src/mesa/main/tests/dispatch_sanity.cpp | 38 - 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index 7af48a4ad91..5fe2e88fe98 100644 --

[Mesa-dev] [PATCH 04/18] mesa: stop hiding remaining query parameters from OpenGL compat

2018-06-27 Thread Timothy Arceri
I managed to miss these two in my last pass at this. --- src/mesa/main/get_hash_params.py | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index 83136108e95..618e306e509 100644 --- a/src/mesa/main/get_hash_

[Mesa-dev] [PATCH v2 11/11] mesa: add missing display list support for ARB_compute_shader

2018-06-27 Thread Timothy Arceri
The extension is enabled for compat profile but there is currently no display list support. I filed a spec bug and it has been agreed that glDispatchComputeIndirect should generate an INVALID_OPERATION error when called during display list compilation. --- v2: Generate an error for glDispatchCom

Re: [Mesa-dev] [PATCH] glsl: skip comparison opt when adding vars of different size

2018-06-27 Thread Timothy Arceri
On 28/06/18 09:23, Timothy Arceri wrote: The spec allows adding scalars a vector or matrix. In this case the opt was losing any swizzle or size information. This fixes a bug with Doom (2016) shaders. Forgot to add: Fixes: 34ec1a24d61f ("glsl: Optimize (x + y cmp 0) into (x c

[Mesa-dev] [PATCH] glsl: skip comparison opt when adding vars of different size

2018-06-27 Thread Timothy Arceri
The spec allows adding scalars a vector or matrix. In this case the opt was losing any swizzle or size information. This fixes a bug with Doom (2016) shaders. --- src/compiler/glsl/opt_algebraic.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compiler/glsl/opt_algebraic.cpp b/s

Re: [Mesa-dev] [PATCH 01/19] radeonsi: clean up passing the is_monolithic flag for compilation

2018-06-25 Thread Timothy Arceri
On 26/06/18 09:51, Dieter Nützel wrote: Hello Marek, after this series landed I get this: Making all in targets/pipe-loader make[4]: Verzeichnis „/opt/mesa/src/gallium/targets/pipe-loader“ wird betreten   CXXLD    pipe_r600.la ../../../../src/gallium/winsys/radeon/drm/.libs/libradeonwinsys.a

Re: [Mesa-dev] Enable/fix a bunch of OpenGL 4.0-4.3 extensions for compat profile

2018-06-25 Thread Timothy Arceri
Please note I've fixed up make check where is was broken when enabling some of these extensions. You can see all of the latests compat patches here: https://gitlab.freedesktop.org/tarceri/mesa/commits/ARB_gpu_shader_fp64 On 22/06/18 18:47, Timothy Arceri wrote: I've send all of the

[Mesa-dev] [PATCH 1/5] mesa: generate GL_INVALID_OPERATION using draw indirect in dlist

2018-06-25 Thread Timothy Arceri
The spec doesn't explicitly say to generate an error but since DrawArraysInstanced* and DrawElementsInstanced* do, it makes sense to do it for these functions also. --- src/mesa/main/dlist.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/src/mesa/m

[Mesa-dev] [PATCH 2/5] mesa: add ARB_draw_indirect support to compat profile

2018-06-25 Thread Timothy Arceri
--- src/mesa/main/bufferobj.c| 3 +- src/mesa/main/extensions_table.h | 2 +- src/mesa/vbo/vbo_exec_array.c| 66 +++- 3 files changed, 67 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 67f9cd0a902..1

[Mesa-dev] [PATCH 5/5] radeonsi: enable OpenGL 4.0 compat profile

2018-06-25 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index 0e8617d0fee..a99626416e7 100644 --- a/src/gallium/drivers/radeonsi/si_get.c +++ b/src/gallium/drivers/r

[Mesa-dev] [PATCH 3/5] mesa: make valid_draw_indirect_multi() accessible externally

2018-06-25 Thread Timothy Arceri
We will use this to add compat support to ARB_multi_draw_indirect in the following patch. --- src/mesa/main/draw_validate.c | 24 src/mesa/main/draw_validate.h | 3 +++ 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/draw_validate.c b/src/me

[Mesa-dev] [PATCH 4/5] mesa: add compat profile support for ARB_multi_draw_indirect

2018-06-25 Thread Timothy Arceri
--- src/mesa/main/extensions_table.h | 2 +- src/mesa/vbo/vbo_exec_array.c| 75 +++- 2 files changed, 74 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index cba1ef6ba7c..1a4014c646b 100644 --- a/src/

[Mesa-dev] Radeonsi OpenGL 4.0 compat profile

2018-06-25 Thread Timothy Arceri
This series is intended to be applied on top of my previous compat series [1]. Note I'm going to drop the last two patches from that series, patch 10 was sent by mistake and I've submitted a spec bug in regards to patch 11. I originally planned not to send this series until ARB_vertex_attrib_6

Re: [Mesa-dev] [PATCH 10/11] mesa: enable ARB_vertex_attrib_64bit in compat profile

2018-06-23 Thread Timothy Arceri
Whoops please ignore this patch it was sent by mistake. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Enable/fix a bunch of OpenGL 4.0-4.3 extensions for compat profile

2018-06-22 Thread Timothy Arceri
on 4.4 On Fri, 22 Jun 2018 at 09:48 Timothy Arceri <mailto:tarc...@itsqueeze.com>> wrote: I've send all of these patches out already. The only change is to the first 2 patches which fixes things so we store a double as 2 unsigned ints rather than 2 floats. E

Re: [Mesa-dev] [PATCH 11/11] mesa: add missing display list support for ARB_compute_shader

2018-06-22 Thread Timothy Arceri
On 22/06/18 18:47, Timothy Arceri wrote: The extension is enabled for compat profile but there is currently no display list support. --- src/mesa/main/dlist.c | 87 +++ 1 file changed, 87 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa

Re: [Mesa-dev] [PATCH] glsl: Make sure that packed varyings reflect always_active_io properly.

2018-06-22 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 23/06/18 06:11, Eric Anholt wrote: The always_active_io flag was only set according to the first variable that got packed in, so NIR io compaction would end up compacting XFB varyings that shouldn't move at that point. --- This doesn't fix my XFB iss

Re: [Mesa-dev] [PATCH 03/19] radeonsi: stop using ac_build_gather_values

2018-06-22 Thread Timothy Arceri
In the subject line you need to change: ac_build_gather_values -> lp_build_gather_values Series: Reviewed-by: Timothy Arceri On 23/06/18 08:31, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 45 +-- .../drivers/radeo

Re: [Mesa-dev] [PATCH 14/19] ac/surface: move cmask_size/alignment into radeon_surf

2018-06-22 Thread Timothy Arceri
This does more than moving. Can you add a commit message about why its safe to change cmask_size from uint64_t -> uint32_t On 23/06/18 08:32, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/ac_surface.c | 6 +++--- src/amd/common/ac_surface.h | 16 +

[Mesa-dev] [PATCH 09/11] mesa: expose some ARB_viewport_array dependent extensions in compat

2018-06-22 Thread Timothy Arceri
--- src/mesa/main/extensions_table.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index bc1f21a2926..b1ee0214d6c 100644 --- a/src/mesa/main/extensions_table.h +++ b/src/mesa/main/extensions_table.h @@ -1

[Mesa-dev] [PATCH 11/11] mesa: add missing display list support for ARB_compute_shader

2018-06-22 Thread Timothy Arceri
The extension is enabled for compat profile but there is currently no display list support. --- src/mesa/main/dlist.c | 87 +++ 1 file changed, 87 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index b2b1f723a17..c11b4c06fe5 100644

[Mesa-dev] [PATCH 08/11] mesa: enable ARB_viewport_array in compat profile

2018-06-22 Thread Timothy Arceri
--- src/mapi/glapi/gen/apiexec.py| 16 src/mesa/main/extensions_table.h | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/apiexec.py index e69c6b4df16..1a91785d375 100644 --- a/src/mapi/glapi/gen/apiexec.

[Mesa-dev] [PATCH 05/11] mesa: add glUniformSubroutinesuiv() display list support

2018-06-22 Thread Timothy Arceri
--- src/mesa/main/dlist.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index d49eebae00d..2425cf24f1b 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -523,6 +523,9 @@ typedef enum /* ARB_

[Mesa-dev] [PATCH 03/11] mesa: enable ARB_gpu_shader_fp64 in compat profile

2018-06-22 Thread Timothy Arceri
--- src/mesa/main/extensions_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index 1c55df8a228..423f22b4657 100644 --- a/src/mesa/main/extensions_table.h +++ b/src/mesa/main/extensions_table.h @@ -76,7

[Mesa-dev] [PATCH 10/11] mesa: enable ARB_vertex_attrib_64bit in compat profile

2018-06-22 Thread Timothy Arceri
--- src/mapi/glapi/gen/apiexec.py| 20 ++-- src/mesa/main/extensions_table.h | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/apiexec.py index 1a91785d375..44552f43f29 100644 --- a/src/mapi/glapi/gen/ap

[Mesa-dev] Enable/fix a bunch of OpenGL 4.0-4.3 extensions for compat profile

2018-06-22 Thread Timothy Arceri
I've send all of these patches out already. The only change is to the first 2 patches which fixes things so we store a double as 2 unsigned ints rather than 2 floats. Everything here has corresponding piglit tests all of which are now upstream with the exception of the compute shader display list

[Mesa-dev] [PATCH 06/11] mesa: enable ARB_shader_subroutine in compat profile

2018-06-22 Thread Timothy Arceri
--- src/mapi/glapi/gen/apiexec.py| 16 src/mesa/main/extensions_table.h | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/apiexec.py index 00c80171274..e69c6b4df16 100644 --- a/src/mapi/glapi/gen/apiexec.

[Mesa-dev] [PATCH 07/11] mesa: add ARB_viewport_array display list support

2018-06-22 Thread Timothy Arceri
--- src/mesa/main/dlist.c | 211 ++ 1 file changed, 211 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 2425cf24f1b..b2b1f723a17 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -290,6 +290,15 @@ typedef enum

[Mesa-dev] [PATCH 01/11] mesa: add Uniform*d support to display lists

2018-06-22 Thread Timothy Arceri
This is required so we can enable fp64 support in compat profile. --- src/mapi/glapi/gen/apiexec.py | 36 +-- src/mesa/main/dlist.c | 493 ++ 2 files changed, 511 insertions(+), 18 deletions(-) diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/ge

[Mesa-dev] [PATCH 04/11] mesa: stop hiding remaining query parameters from OpenGL compat

2018-06-22 Thread Timothy Arceri
I managed to miss these two in my last pass at this. --- src/mesa/main/get_hash_params.py | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index 83136108e95..618e306e509 100644 --- a/src/mesa/main/get_hash_

[Mesa-dev] [PATCH 02/11] mesa: add ProgramUniform*d display list support

2018-06-22 Thread Timothy Arceri
This is required for fp64 to be enabled in compat profile. --- src/mesa/main/dlist.c | 514 ++ 1 file changed, 514 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index aec373b7ab1..d49eebae00d 100644 --- a/src/mesa/main/dlist.c +++

[Mesa-dev] [PATCH] mesa: add missing display list support for ARB_compute_shader

2018-06-21 Thread Timothy Arceri
The extension is enabled for compat profile but there is currently no display list support. --- src/mesa/main/dlist.c | 87 +++ 1 file changed, 87 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 8b1ddb05038..e5c8f22ac80 100644

Re: [Mesa-dev] [PATCH] mesa: fix glGetInteger64v for arrays of integers

2018-06-20 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 21/06/18 11:02, Marek Olšák wrote: From: Marek Olšák Cc: 18.1 --- src/mesa/main/get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 772ca00da1f..db0079beb51 100644 --- a/src/mesa/main

<    3   4   5   6   7   8   9   10   11   12   >