Re: [Mesa-dev] [PATCH 3/3] radeon/llvm: Free elf_buffer after use

2013-11-11 Thread Tom Stellard
On Thu, Nov 07, 2013 at 06:08:16PM -0600, Aaron Watry wrote: Prevents a memory leak. --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c b/src/gallium/drivers/radeon/radeon_llvm_emit.c

Re: [Mesa-dev] [PATCH] clover: Remove dead file from Makefile.sources.

2013-11-11 Thread Tom Stellard
On Mon, Nov 11, 2013 at 03:54:48PM -0800, Matt Turner wrote: --- Reviewed-by: Tom Stellard thomas.stell...@amd.com src/gallium/state_trackers/clover/Makefile.sources | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/Makefile.sources b/src/gallium

Re: [Mesa-dev] [PATCH 2/6] radeon/llvm: Free libelf resources

2013-11-06 Thread Tom Stellard
On Wed, Nov 06, 2013 at 10:36:51AM -0600, Aaron Watry wrote: --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c b/src/gallium/drivers/radeon/radeon_llvm_emit.c index 8bf278b..20b3206 100644

Re: [Mesa-dev] [PATCH 0/6] radeon: Plug some memory leaks

2013-11-06 Thread Tom Stellard
These look good, but the indentation seems wrong in patches 2 through 6. -Tom On Wed, Nov 06, 2013 at 10:36:49AM -0600, Aaron Watry wrote: I decided to have some fun and hooked valgrind up to my 7850 while running a few OpenCL tests in piglit. This is the first batch of fixes. Aaron Watry

Re: [Mesa-dev] Fix crashes with static LLVM

2013-11-05 Thread Tom Stellard
On Wed, Oct 23, 2013 at 04:26:18PM -0400, Tom Stellard wrote: Hi, The attached patches introduce linker scripts to the pipe-loader and egl-static targets. The linker scripts prevents these targets from exporting LLVM (and other) symbols that they shouldn't be. This fixes several crashes

Re: [Mesa-dev] [PATCH] gallivm: Remove llvm::DisablePrettyStackTrace for LLVM = 3.4.

2013-11-04 Thread Tom Stellard
and newer. Otherwise, I think people may be confused about why this change was made. With that change, the patch is: Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 ++ 1 file changed, 2

Re: [Mesa-dev] [PATCH] clover: fix build with LLVM 3.4

2013-11-04 Thread Tom Stellard
On Fri, Nov 01, 2013 at 10:25:43AM -0500, Aaron Watry wrote: dso_list was added as an argument for createInternalizePass in 3.4, and then it was removed again in the same llvm version. I've pushed this patch, thanks! -Tom --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 5 -

Re: [Mesa-dev] [PATCH] r600/llvm: Store inputs in function arguments

2013-11-04 Thread Tom Stellard
On Sun, Nov 03, 2013 at 06:58:18PM +0100, Vincent Lejeune wrote: --- src/gallium/drivers/r600/r600_llvm.c | 125 - src/gallium/drivers/r600/r600_shader.c | 2 + src/gallium/drivers/radeon/radeon_llvm.h | 1 +

Re: [Mesa-dev] [PATCH] R600: Make sure OQAP defs and uses happen in the same clause

2013-10-30 Thread Tom Stellard
that queues a value, I only use LDS_RET_READ in switch case. Vincent - Mail original - De : Tom Stellard t...@stellard.net À : Vincent Lejeune v...@ovi.com Cc : llvm-comm...@cs.uiuc.edu llvm-comm...@cs.uiuc.edu; mesa-dev@lists.freedesktop.org mesa-dev@lists.freedesktop.org; Tom

Re: [Mesa-dev] [PATCH 2/2] pipe-loader: Add support for render nodes

2013-10-30 Thread Tom Stellard
On Wed, Oct 30, 2013 at 08:15:43AM +0100, David Herrmann wrote: Hi Tom On Tue, Oct 29, 2013 at 9:00 PM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com You can use the --enable-pipe-loader-render-nodes configure flag to make the pipe-loader use render

Re: [Mesa-dev] [PATCH] radeonsi: Allow longer intrinsic names

2013-10-30 Thread Tom Stellard
On Tue, Oct 29, 2013 at 08:34:16PM +0100, Kai Wasserb??ch wrote: Tom Stellard schrieb am 29.10.2013 17:48: On Sun, Oct 27, 2013 at 07:36:07PM +0100, Kai Wasserb??ch wrote: Fixes a boat load of Piglit tests for me, which crashed like fdo#70913 before. Thanks to Michel D??nzer for the tip

Re: [Mesa-dev] [PATCH] clover: Don't install headers when using the icd

2013-10-30 Thread Tom Stellard
On Wed, Oct 30, 2013 at 08:38:37AM -0500, Aaron Watry wrote: Reviewed and Tested-by: Aaron Watry awa...@gmail.com I have pushed this patch, thanks for testing. On Tue, Oct 29, 2013 at 11:48 AM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com The ICD

Re: [Mesa-dev] [PATCH] radeon/llvm: Specify the DataLayout when running optimizations

2013-10-30 Thread Tom Stellard
. --Aaron On Tue, Oct 22, 2013 at 11:28 AM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com Without DataLayout, a lot of optimization passes aren't run and the ones that are don't work as well. --- src/gallium/drivers/radeon/radeon_llvm_util.c | 4

Re: [Mesa-dev] [PATCH] R600: Expand vector FSQRT ops

2013-10-29 Thread Tom Stellard
, 2013 at 6:28 PM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com --- lib/Target/R600/AMDGPUISelLowering.cpp | 1 + test/CodeGen/R600/llvm.sqrt.ll | 54 ++ 2 files changed, 55 insertions(+) create mode 100644

Re: [Mesa-dev] [PATCH] radeonsi: Allow longer intrinsic names

2013-10-29 Thread Tom Stellard
-project.org This looks OK to me, which intrinsic names were too long? Reviewed-by: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src

[Mesa-dev] [PATCH] clover: Don't install headers when using the icd

2013-10-29 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com The ICD loader should be responsible for installing headers. --- src/gallium/state_trackers/clover/Makefile.am | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/clover/Makefile.am b

Re: [Mesa-dev] [PATCH] clover: mark gcc 4.7.0 as broken

2013-10-29 Thread Tom Stellard
It certainly not compile on 4.7.0, if I recall corectly Tom Stellard said it compile on 4.7.1. This patch is tested. I was mistaken. 4.7.3 is the oldest version that will work. This patch doesn't apply for me. It looks like your mail client is wrapping long lines, can you resend? Thanks, Tom

[Mesa-dev] [PATCH] clover: Calculate the optimal work group size when local_size is NULL

2013-10-29 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This results in huge performance improvements for applications like pyrit, which depend on the implementation to determine the optimal work group size. --- src/gallium/state_trackers/clover/api/kernel.cpp | 9 - src/gallium/state_trackers

[Mesa-dev] [PATCH] clover: Calculate the optimal work group size when local_size is NULL

2013-10-29 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This results in huge performance improvements for applications like pyrit, which depend on the implementation to determine the optimal work group size. --- src/gallium/state_trackers/clover/api/kernel.cpp | 9 - src/gallium/state_trackers

[Mesa-dev] [PATCH 2/2] pipe-loader: Add support for render nodes

2013-10-29 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com You can use the --enable-pipe-loader-render-nodes configure flag to make the pipe-loader use render nodes for talking with the device. --- configure.ac | 6 ++ src/gallium/auxiliary/pipe-loader/Makefile.am

[Mesa-dev] [PATCH 1/2] winsys/radeon: Add a work around for drmGetVersion() when using render nodes

2013-10-29 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com DRM_IOCTL_VERSION is not currently a legal ioctl for render nodes, so we need to hard code the drm version when drmGetVersion() returns NULL. --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 36 --- 1 file changed, 25

Re: [Mesa-dev] Continuous Integration

2013-10-24 Thread Tom Stellard
On Thu, Oct 24, 2013 at 02:55:36AM -0400, Yomi Ogunwumi wrote: Hello everyone. I was reading through the Help Wanted page and I was wondering if 6. Automatic Testing still needed to be done. The three continuous integration systems currently I'm looking at are : • Jenkins • Buildbot •

Re: [Mesa-dev] clover: fix build after a3ed98f7aa85636579a5696bf036ec13e5c9104a

2013-10-24 Thread Tom Stellard
On Thu, Oct 24, 2013 at 09:14:49AM -0600, Brian Paul wrote: On 10/23/2013 01:33 PM, David Heidelberger wrote: link to similiar bug: https://bugs.freedesktop.org/show_bug.cgi?id=70804 --- src/gallium/state_trackers/clover/core/kernel.cpp | 7 --- 1 file changed, 4 insertions(+), 3

Re: [Mesa-dev] [PATCH] radeonsi/compute: Add Sea Islands support

2013-10-23 Thread Tom Stellard
On Wed, Oct 23, 2013 at 09:47:30AM -0500, Jay Cornwall wrote: On 2013-10-22 21:05, Tom Stellard wrote: --- src/gallium/drivers/radeonsi/radeonsi_compute.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) [..] + si_pm4_set_reg(pm4

Re: [Mesa-dev] [PATCH] R600/SI: Add compute support for CI

2013-10-23 Thread Tom Stellard
On Wed, Oct 23, 2013 at 09:31:53AM +0200, Michel D??nzer wrote: On Die, 2013-10-22 at 22:07 -0400, Tom Stellard wrote: diff --git a/lib/Target/R600/AMDGPU.td b/lib/Target/R600/AMDGPU.td index a722f55..f63617f 100644 --- a/lib/Target/R600/AMDGPU.td +++ b/lib/Target/R600/AMDGPU.td

[Mesa-dev] [PATCH 1/3] pipe-loader: Only export necessary symbols

2013-10-23 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This makes it possible to use clover with statically linked LLVM. --- src/gallium/targets/pipe-loader/Makefile.am | 4 src/gallium/targets/pipe-loader/pipe.link | 3 +++ 2 files changed, 7 insertions(+) create mode 100644 src/gallium/targets

[Mesa-dev] [PATCH 2/3] configure.ac: Don't require shared LLVM when building OpenCL

2013-10-23 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This works now that pipe_*.so is no longer exporting LLVM symbols. --- configure.ac | 6 -- 1 file changed, 6 deletions(-) diff --git a/configure.ac b/configure.ac index dfa35b4..81403ee 100644 --- a/configure.ac +++ b/configure.ac @@ -1530,12

[Mesa-dev] Fix crashes with static LLVM

2013-10-23 Thread Tom Stellard
Hi, The attached patches introduce linker scripts to the pipe-loader and egl-static targets. The linker scripts prevents these targets from exporting LLVM (and other) symbols that they shouldn't be. This fixes several crashes in the radeon drivers when statically linking LLVM. With these

[Mesa-dev] [PATCH 3/3] egl-static: Only export necessary symbols

2013-10-23 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This fixes a crash in glamor when mesa links against static LLVM. --- src/gallium/targets/egl-static/Makefile.am | 4 src/gallium/targets/egl-static/egl.link| 3 +++ 2 files changed, 7 insertions(+) create mode 100644 src/gallium/targets/egl

[Mesa-dev] [PATCH 1/3] pipe-loader: Only export necessary symbols v2

2013-10-23 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This makes it possible to use clover with statically linked LLVM. v2: - Inline LINKER_SCRIPT variable --- src/gallium/targets/pipe-loader/Makefile.am | 2 ++ src/gallium/targets/pipe-loader/pipe.link | 3 +++ 2 files changed, 5 insertions

[Mesa-dev] [PATCH 3/3] egl-static: Only export necessary symbols v2

2013-10-23 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This fixes a crash in glamor when mesa links against static LLVM. v2: - Inline LINKER_SCRIPT variable --- src/gallium/targets/egl-static/Makefile.am | 2 ++ src/gallium/targets/egl-static/egl.link| 3 +++ 2 files changed, 5 insertions(+) create

[Mesa-dev] [PATCH] R600: Expand vector FSQRT ops

2013-10-23 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- lib/Target/R600/AMDGPUISelLowering.cpp | 1 + test/CodeGen/R600/llvm.sqrt.ll | 54 ++ 2 files changed, 55 insertions(+) create mode 100644 test/CodeGen/R600/llvm.sqrt.ll diff --git a/lib/Target/R600

[Mesa-dev] [PATCH] R600/SI: Add compute support for CI v2

2013-10-23 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com v2: - Fix LDS size calculation --- lib/Target/R600/AMDGPU.td| 2 ++ lib/Target/R600/AMDGPUAsmPrinter.cpp | 16 ++-- lib/Target/R600/AMDGPUCallingConv.td | 4 ++-- lib/Target/R600/AMDGPUSubtarget.h| 3 ++- lib/Target/R600

Re: [Mesa-dev] [PATCH] RFC clover: calculate maximum workgroup size based on device

2013-10-23 Thread Tom Stellard
On Wed, Oct 23, 2013 at 06:41:56PM -0500, Aaron Watry wrote: The maximum workgroup size for a given kernel is based on the capabilities of the device that it's being run on. Previously, we were just returning the maximum value of a size_t which is obviously wrong. This patch uses the

Re: [Mesa-dev] [PATCH] R600: Make sure OQAP defs and uses happen in the same clause

2013-10-22 Thread Tom Stellard
. Any suggestions on where I should but it? -Tom On Mon, Oct 21, 2013 at 12:40:28PM -0700, Vincent Lejeune wrote: - Mail original - De : Tom Stellard t...@stellard.net À : llvm-comm...@cs.uiuc.edu Cc : mesa-dev@lists.freedesktop.org; Tom Stellard thomas.stell...@amd.com

[Mesa-dev] [PATCH] R600/SI: Add compute support for CI

2013-10-22 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- lib/Target/R600/AMDGPU.td| 2 ++ lib/Target/R600/AMDGPUAsmPrinter.cpp | 16 ++-- lib/Target/R600/AMDGPUCallingConv.td | 4 ++-- lib/Target/R600/AMDGPUSubtarget.h| 3 ++- lib/Target/R600/Processors.td| 6

Re: [Mesa-dev] [PATCH] R600/SI: fix MIMG writemask adjustement

2013-10-22 Thread Tom Stellard
Pushed, thanks. -Tom On Tue, Oct 22, 2013 at 02:15:01AM +0200, Marek Olk wrote: From: Marek Olk marek.ol...@amd.com This fixes piglit: - shaders/glsl-fs-texture2d-masked - shaders/glsl-fs-texture2d-masked-4 Signed-off-by: Marek Olk marek.ol...@amd.com Reviewed-by: Tom

Re: [Mesa-dev] [PATCH 1/2] r600/llvm: Fix texbuf for pre EG gen

2013-10-21 Thread Tom Stellard
On Mon, Oct 21, 2013 at 10:02:12PM +0200, Vincent Lejeune wrote: Can you add an explanation to the commit messages for both patches about what was wrong with the old code? Thanks, Tom --- src/gallium/drivers/r600/r600_llvm.c | 29 + 1 file changed, 29

[Mesa-dev] PATCH: R600: Fix handling of kernel arguments

2013-10-15 Thread Tom Stellard
Hi, The attached patches fix various bugs in the handling of kernel arguments in the R600 backend. The main problem with the old implementations was that it disagreed with clover on type size and alignment, so vector arguments were not being loaded correctly into the kernel. This series depends

Re: [Mesa-dev] PATCH: R600: Fix handling of kernel arguments

2013-10-15 Thread Tom Stellard
On Tue, Oct 15, 2013 at 01:59:55PM -0400, Alex Deucher wrote: Did you forget the attachments? Yes I did. Here they are. -Tom On Tue, Oct 15, 2013 at 12:40 PM, Tom Stellard t...@stellard.net wrote: Hi, The attached patches fix various bugs in the handling of kernel arguments

Re: [Mesa-dev] [PATCH] radeon/llvm: show LLVM disassembly when available

2013-10-12 Thread Tom Stellard
On Thu, Oct 10, 2013 at 08:06:48PM -0500, Jay Cornwall wrote: With code dump enabled LLVM may generate disassembly during compilation. Show this disassembly when available and prefer it to SI bytecode dump. I've pushed this and the LLVM patch. Thanks! -Tom Signed-off-by: Jay Cornwall

[Mesa-dev] PATCH: R600: Fix crash in AMDILCFGStructurizer

2013-10-11 Thread Tom Stellard
Hi, The attached patches fix a crash in the AMDILCFGStructurizer. The first patch does some code cleanup and the second patch actually fixes the crash. -Tom From 8a95058178eba343cb6ee408677b42329e7069ed Mon Sep 17 00:00:00 2001 From: Tom Stellard thomas.stell...@amd.com Date: Fri, 11 Oct 2013

[Mesa-dev] [PATCH] clover: Link libclc before running any optimizations

2013-10-11 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This is required in order for clang to correctly handle the OpenCL C barrier() builtin which has the following restrictions acording to the OpenCL 1.1 Specification: If barrier is inside a conditional statement, then all work-items must enter

[Mesa-dev] [PATCH] r600g/compute Improve debugging output

2013-10-11 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/r600/compute_memory_pool.c | 8 +--- src/gallium/drivers/r600/evergreen_compute.c | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium

[Mesa-dev] [PATCH] R600: Make sure OQAP defs and uses happen in the same clause

2013-10-11 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com Reading the special OQAP register pops the top value off the LDS input queue and returns it to the instruction. This queue is invalidated at the end of an ALU clause and leaving values in the queue can lead to GPU hangs. This means that if we load

Re: [Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Tom Stellard
On Fri, Oct 11, 2013 at 02:09:57PM +0100, Emil Velikov wrote: On 07/10/13 18:53, Emil Velikov wrote: On 07/10/13 16:48, Tom Stellard wrote: On Sat, Sep 28, 2013 at 03:46:21PM +0100, Emil Velikov wrote: Use PKG_CHECK_MODULE over requesting the user to setup the option at configure time

Re: [Mesa-dev] [PATCH] R600/SI: Support byval arguments

2013-10-10 Thread Tom Stellard
On Thu, Oct 10, 2013 at 12:04:16AM +0200, Vincent Lejeune wrote: What is the purpose of this change? -Tom --- lib/Target/R600/AMDGPUCallingConv.td | 7 ++- lib/Target/R600/SIISelLowering.cpp | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] PATCH: R600 + SI Private memory fixes; Use more SALU instructions on SI

2013-10-10 Thread Tom Stellard
On Thu, Oct 10, 2013 at 11:29:17AM -0700, Matt Arsenault wrote: On 10/10/2013 10:55 AM, Tom Stellard wrote: Hi, The attached patches simplify the handling of OpenCL private memory space for VLIW4/VLIW5 GPUs and should fix a crash with pyrit on r600g. Also included in the series

Re: [Mesa-dev] [PATCH] R600/SI: fix MIMG writemask adjustement

2013-10-09 Thread Tom Stellard
. With that change the patch is: Reviewed-by: Tom Stellard thomas.stell...@amd.com Do you have commit access yet? -Tom +; CHECK: IMAGE_SAMPLE VGPR{{[[0-9]}}_VGPR{{[0-9]}}_VGPR{{[0-9]}}, 13 +define void @v1(i32 %a1) { +entry: + %0 = insertelement 1 x i32 undef, i32 %a1, i32 0 + %1 = call 4 x float

Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: don't export any private symbols

2013-10-07 Thread Tom Stellard
want to. Either way, the series is Reviewed-by: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/r600/Makefile.am | 3 ++- src/gallium/drivers/radeon/Makefile.am | 8 +--- src/gallium/drivers/radeonsi/Makefile.am | 4 +++- src/gallium/targets/r300/dri

Re: [Mesa-dev] [PATCH 3/3] configure.ac: report an error if LLVM shared libs are disabled and CL is enabled

2013-10-07 Thread Tom Stellard
On Mon, Oct 07, 2013 at 01:05:15PM +0200, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Reviewed-by: Tom Stellard thomas.stell...@amd.com --- configure.ac | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 559c9a3

Re: [Mesa-dev] [PATCH 4/7] gallium/targets/xorg: drop set but unused variable entity

2013-10-07 Thread Tom Stellard
On Sat, Sep 28, 2013 at 03:46:18PM +0100, Emil Velikov wrote: The function xf86GetEntityInfo() retrieves the entity rather than doing any changes. Remove this no-op code. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-by: Tom Stellard thomas.stell...@amd.com --- src/gallium

Re: [Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-10-07 Thread Tom Stellard
On Sat, Sep 28, 2013 at 03:46:21PM +0100, Emil Velikov wrote: Use PKG_CHECK_MODULE over requesting the user to setup the option at configure time. Drop unused EXPAT_INCLUDE and add EXPAT_CFLAGS to all classic/dri and gallium/dri targets. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com

[Mesa-dev] [PATCH] radeonsi/compute: Fix segfault caused by recent refactoring

2013-10-03 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/radeon/r600_pipe_common.c | 4 src/gallium/drivers/radeonsi/radeonsi_shader.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers

Re: [Mesa-dev] [PATCH 05/29] softpipe: consolidate C sources list into Makefile.sources

2013-10-01 Thread Tom Stellard
On Mon, Sep 30, 2013 at 07:55:34AM -0700, Tom Stellard wrote: On Sat, Sep 28, 2013 at 03:01:15PM +0100, Emil Velikov wrote: On 28/09/13 04:48, Tom Stellard wrote: On Sun, Sep 22, 2013 at 09:29:28PM +0100, Emil Velikov wrote: Signed-off-by: Emil Velikov emil.l.veli...@gmail.com

Re: [Mesa-dev] [PATCH 05/29] softpipe: consolidate C sources list into Makefile.sources

2013-09-30 Thread Tom Stellard
On Sat, Sep 28, 2013 at 03:01:15PM +0100, Emil Velikov wrote: On 28/09/13 04:48, Tom Stellard wrote: On Sun, Sep 22, 2013 at 09:29:28PM +0100, Emil Velikov wrote: Signed-off-by: Emil Velikov emil.l.veli...@gmail.com As long as you have build tested these with both automake and scons

Re: [Mesa-dev] [PATCH] R600: Add a ldptr intrinsic to support MSAA.

2013-09-30 Thread Tom Stellard
bits2 inst_mod = 1; let Inst{6-5} = inst_mod; + let Inst{6-5} = 1; +} With that change: Reviewed-by: Tom Stellard thomas.stell...@amd.com def TEX_GET_TEXTURE_RESINFO : R600_TEX 0x04, TEX_GET_TEXTURE_RESINFO; def TEX_GET_GRADIENTS_H : R600_TEX 0x07, TEX_GET_GRADIENTS_H; def

Re: [Mesa-dev] [PATCH 1/4] r600g/llvm: fix sample cube shadow

2013-09-30 Thread Tom Stellard
On Mon, Sep 30, 2013 at 11:46:26PM +0200, Vincent Lejeune wrote: Could you go through and wrap some on the long lines that you are adding in the other patches. With that fix, the entire series is: Reviewed-by: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH] radeon/llvm: fix TGSI_OPCODE_UCMP

2013-09-27 Thread Tom Stellard
On Wed, Sep 25, 2013 at 08:14:43PM +0200, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com This doesn't fix any known issue (I haven't run piglit with this yet), but the code was obviously completely wrong. It looks like copy-pasted from CMP. Reviewed-by: Tom Stellard thomas.stell

Re: [Mesa-dev] [PATCH] R600/SI: fix MIMG writemask adjustement

2013-09-27 Thread Tom Stellard
On Mon, Sep 23, 2013 at 09:09:14PM +0200, mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com This fixes piglit: - shaders/glsl-fs-texture2d-masked - shaders/glsl-fs-texture2d-masked-4 Signed-off-by: Marek Olšák marek.ol...@amd.com --- lib/Target/R600/SIISelLowering.cpp | 27

Re: [Mesa-dev] [PATCH 04/29] r600: use NEED_RADEON_LLVM over R600_NEED_RADEON_GALLIUM

2013-09-27 Thread Tom Stellard
On Sun, Sep 22, 2013 at 09:29:27PM +0100, Emil Velikov wrote: libllvmradeon.la is available whenever NEED_RADEON_LLVM is set, using R600_NEED_RADEON_GALLIUM is rather ambiguous and unnecessary. Drop it in favour of NEED_RADEON_LLVM. Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed

Re: [Mesa-dev] [PATCH 01/29] gallium/targets: Make use of prebuilt libdricommon.la.

2013-09-27 Thread Tom Stellard
On Sun, Sep 22, 2013 at 09:29:24PM +0100, Emil Velikov wrote: From: Johannes Obermayr johannesoberm...@gmx.de libdricommon.la is available whenever a non swrast driver is built. All the classic dri drivers make use of the prebuild library but all of the gallium ones rebuild it explicitly.

Re: [Mesa-dev] [PATCH 03/29] gallium/radeon: drop unused variable LIBGALLIUM_LIBS

2013-09-27 Thread Tom Stellard
On Sun, Sep 22, 2013 at 09:29:26PM +0100, Emil Velikov wrote: Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/drivers/radeon/Makefile.am | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH 05/29] softpipe: consolidate C sources list into Makefile.sources

2013-09-27 Thread Tom Stellard
On Sun, Sep 22, 2013 at 09:29:28PM +0100, Emil Velikov wrote: Signed-off-by: Emil Velikov emil.l.veli...@gmail.com As long as you have build tested these with both automake and scons and are prepared to deal with any fallout once they are committed. Patches 5 through 29 are: Reviewed-by: Tom

Re: [Mesa-dev] [PATCH 01/29] gallium/targets: Make use of prebuilt libdricommon.la.

2013-09-27 Thread Tom Stellard
On Sat, Sep 28, 2013 at 04:42:34AM +0100, Emil Velikov wrote: On 28/09/13 04:36, Tom Stellard wrote: On Sun, Sep 22, 2013 at 09:29:24PM +0100, Emil Velikov wrote: From: Johannes Obermayr johannesoberm...@gmx.de libdricommon.la is available whenever a non swrast driver is built. All

Re: [Mesa-dev] The long way to a faster build with shared libs and some fixes ...

2013-09-11 Thread Tom Stellard
Hi Johannes, Could explain how you tested these patches: The configure flags you used to build as well as the applications/hardware you used for testing. Thanks, Tom On Thu, Sep 12, 2013 at 12:32:38AM +0200, Johannes Obermayr wrote: [PATCH 01/21] ilo: Fix out-of-tree build. [PATCH 02/21]

Re: [Mesa-dev] [PATCH] R600: add a test for SI.tbuffer.store

2013-09-11 Thread Tom Stellard
Hi Marek, I've pushed this along with the other original tbuffer patch. -Tom On Mon, Sep 09, 2013 at 10:36:12PM +0200, Marek Olšák wrote: Signed-off-by: Marek Olšák marek.ol...@amd.com --- test/CodeGen/R600/llvm.SI.tbuffer.store.ll | 40 ++ 1 file changed, 40

[Mesa-dev] [PATCH 2/2] R600/SI: Merge offset0 and offset1 fields for single address DS instructions v2

2013-09-06 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com Also remove unused data fields from the DS_Load_Helper class. v2: - Merge fields for DS_WRITE --- lib/Target/R600/SIInstrInfo.td| 35 +++ lib/Target/R600/SIInstructions.td | 8 2 files changed, 27

Re: [Mesa-dev] [PATCH] R600/SI: expose TBUFFER_STORE_FORMAT_* for OpenGL transform feedback

2013-09-05 Thread Tom Stellard
On Mon, Sep 02, 2013 at 09:07:18PM +0200, Marek Olšák wrote: For _XYZ, the type of VDATA is v4i32, because v3i32 doesn't exist. The ADDR64 bit is not exposed. A simpler intrinsic that doesn't take a resource descriptor might be nicer. The maximum number of input SGPRs is bumped to 17.

[Mesa-dev] [PATCH 2/2] R600/SI: Merge offset0 and offset1 fields for single address DS instructions

2013-09-05 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com Also remove unused data fields from the DS_Load_Helper class. --- lib/Target/R600/SIInstrInfo.td| 28 lib/Target/R600/SIInstructions.td | 6 +++--- 2 files changed, 23 insertions(+), 11 deletions(-) diff --git a/lib

[Mesa-dev] [PATCH 1/2] R600/SI: Add isDS helper function to SIInstrInfo

2013-09-05 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- lib/Target/R600/SIDefines.h| 3 ++- lib/Target/R600/SIInstrFormats.td | 3 +++ lib/Target/R600/SIInstrInfo.cpp| 4 lib/Target/R600/SIInstrInfo.h | 1 + lib/Target/R600/SILowerControlFlow.cpp | 12

[Mesa-dev] [PATCH] R600: Don't use trans slot for instructions that read LDS source registers

2013-09-05 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This fixes some regressions in the piglit local memory store tests introduced by recent commits which made the scheduler aware of the trans slot. It's not possible to test this using lit, because there is no way to determine from the assembly dumps

[Mesa-dev] [PATCH] configure.ac: Add a more informative warning when libclc.pc is not found

2013-09-05 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- configure.ac | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index b19ab18..702a58b 100644 --- a/configure.ac +++ b/configure.ac @@ -1387,7 +1387,10 @@ if test x$enable_opencl = xyes; then fi

[Mesa-dev] [PATCH] configure.ac: Add a more informative warning when libclc.pc is not found v2

2013-09-05 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com v2: - Don't display an error message when the user doesn't ask for libclc. --- configure.ac | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index b19ab18..fcfa4f7 100644

Re: [Mesa-dev] [PATCH 0/6] radeonsi: Minor cleanups and improvements

2013-08-29 Thread Tom Stellard
and it's what made this series so big: 54 files changed, 2448 insertions(+), 2532 deletions(-) Please review. With the attached build fix for r600g, there are no compute regressions with this series with either r600g or radeonsi. Tested-by: Tom Stellard thomas.stell...@amd.com -Tom

[Mesa-dev] [PATCH] r600g/compute: Fix bug in compute memory pool

2013-08-27 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com When adding a new buffer to the beginning of the memory pool, we were accidentally deleting the buffer that was first in the buffer list. This was caused by a bug in the memory pool's linked list implementation. --- src/gallium/drivers/r600

[Mesa-dev] [PATCH] clover: Don't use PIPE_TRANSFER_UNSYNCHRONIZED for blocking copies.

2013-08-26 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com CC: 9.2 mesa-sta...@lists.freedesktop.org --- This should go to the 9.2 branch, but I know we are already in the rc stage, so it can wait until the first point release. src/gallium/state_trackers/clover/core/resource.cpp | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH] clover: Always print the compile log

2013-08-26 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This way users can see compiler warnings. --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm

[Mesa-dev] [PATCH] r600g/compute: Don't flush the cs in pipe_context::launch_grid()

2013-08-26 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This is the state tracker's responsibility. --- src/gallium/drivers/r600/evergreen_compute.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_compute.c b/src/gallium/drivers/r600

Re: [Mesa-dev] [PATCH 1/6] st/clover: Profiling support

2013-08-26 Thread Tom Stellard
I've pushed this patch, thanks. -Tom On Fri, Aug 09, 2013 at 11:59:25AM +0200, Niels Ole Salscheider wrote: Signed-off-by: Niels Ole Salscheider niels_...@salscheider-online.de --- src/gallium/state_trackers/clover/api/event.cpp | 26 - src/gallium/state_trackers/clover/core/event.cpp

Re: [Mesa-dev] [PATCH 2/6] st/clover: Add event to deps even if it has been triggered

2013-08-26 Thread Tom Stellard
I've pushed this patch, thanks. -Tom On Fri, Aug 09, 2013 at 11:59:26AM +0200, Niels Ole Salscheider wrote: The command is submitted once the event has been triggered, but it might not have completed yet. Therefore, we have to add it to deps in order to wait on it. Signed-off-by: Niels

Re: [Mesa-dev] [PATCH 1/6] st/clover: Profiling support

2013-08-23 Thread Tom Stellard
On Fri, Aug 09, 2013 at 11:59:25AM +0200, Niels Ole Salscheider wrote: I've pushed the radeonsi patches, I think Francisco is still trying to review the clover patches. -Tom Signed-off-by: Niels Ole Salscheider niels_...@salscheider-online.de ---

[Mesa-dev] [PATCH] radeonsi/compute: Fix LDS size calculation

2013-08-22 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com We need to include the number of LDS bytes allocated by the state tracker. --- src/gallium/drivers/radeonsi/radeonsi_compute.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c b

Re: [Mesa-dev] PATCH: R600 + SI: Add support for lds atomic add

2013-08-22 Thread Tom Stellard
On Thu, Aug 22, 2013 at 10:03:56AM +0200, Michel Dänzer wrote: On Mit, 2013-08-21 at 11:30 -0700, Tom Stellard wrote: The attached patches fix some LDS bugs on SI and add support for atomic add for R600 and SI. Please Review. About patch 4: diff --git a/lib/Target/R600

Re: [Mesa-dev] [PATCH] radeonsi/compute: Fix LDS size calculation

2013-08-22 Thread Tom Stellard
On Thu, Aug 22, 2013 at 05:42:34PM +0200, Michel Dänzer wrote: On Don, 2013-08-22 at 11:25 -0400, Tom Stellard wrote: From: Tom Stellard thomas.stell...@amd.com We need to include the number of LDS bytes allocated by the state tracker. --- src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH] [RFC] r600g: enable SB backend by default

2013-08-22 Thread Tom Stellard
On Thu, Aug 22, 2013 at 08:20:38PM +0400, Vadim Girlin wrote: Signed-off-by: Vadim Girlin vadimgir...@gmail.com This is fine with me. Nice work! Reviewed-by: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/r600/r600_asm.c| 3 ++- src/gallium/drivers/r600/r600_pipe.c | 4

[Mesa-dev] [PATCH] R600/SI: Fix another case of illegal VGPR to SGPR copy

2013-08-21 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This fixes a crash in Unigine Tropics. --- lib/Target/R600/SIFixSGPRCopies.cpp | 2 +- test/CodeGen/R600/sgpr-copy.ll | 145 +++- 2 files changed, 143 insertions(+), 4 deletions(-) diff --git a/lib/Target/R600

[Mesa-dev] PATCH: R600 + SI: Add support for lds atomic add

2013-08-21 Thread Tom Stellard
Hi, The attached patches fix some LDS bugs on SI and add support for atomic add for R600 and SI. Please Review. -Tom From 0447b0918efca9000e66414e9ff1bd291936f702 Mon Sep 17 00:00:00 2001 From: Tom Stellard thomas.stell...@amd.com Date: Wed, 21 Aug 2013 11:35:27 -0400 Subject: [PATCH 1/4] R600

[Mesa-dev] [PATCH] R600: Fix segfault in R600TextureIntrinsicReplacer

2013-08-21 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This pass was segfaulting when it ran into a non-intrinsic function call. Function calls are not supported, so now instead of segfaulting, we will get an assertion failure with a nice error message. I'm not sure how to test this using lit. --- lib

Re: [Mesa-dev] radeonsi: LLVM r187139 broke some piglit tests

2013-08-16 Thread Tom Stellard
On Fri, Aug 16, 2013 at 03:36:38PM +0200, Michel Dänzer wrote: On Don, 2013-08-15 at 13:50 -0700, Tom Stellard wrote: On Thu, Aug 15, 2013 at 07:50:10PM +0200, Michel Dänzer wrote: On Don, 2013-08-15 at 09:16 -0700, Tom Stellard wrote: On Thu, Aug 15, 2013 at 08:22:39AM -0700, Tom

Re: [Mesa-dev] [PATCH] R600/SI: Add pattern for xor of i1

2013-08-16 Thread Tom Stellard
On Fri, Aug 16, 2013 at 04:04:37PM +0200, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com Fixes two recent piglit regressions with radeonsi. Signed-off-by: Michel Dänzer michel.daen...@amd.com Reviewed-by: Tom Stellard thomas.stell...@amd.com --- lib/Target/R600

[Mesa-dev] [PATCH] radeonsi/compute: Let the state tracker do all the flushing

2013-08-16 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com It shouldn't be necessary to call radeon_winsys::cs_flush() from radeonsi_launch_grid(), because the state tracker is responsible for flushing the pipeline at the appropriate time. The current behavior is also wrong, because radeonsi_launch_grid

Re: [Mesa-dev] [PATCH] clover: Fix linkage of libOpenCL

2013-08-16 Thread Tom Stellard
On Wed, Aug 07, 2013 at 05:48:48PM +0200, Niels Ole Salscheider wrote: Clover needs the option component of llvm. Pushed, thanks! -Tom Signed-off-by: Niels Ole Salscheider niels_...@salscheider-online.de --- configure.ac | 4 1 Datei geändert, 4 Zeilen hinzugefügt(+) diff --git

Re: [Mesa-dev] radeonsi: LLVM r187139 broke some piglit tests

2013-08-15 Thread Tom Stellard
On Thu, Aug 15, 2013 at 11:55:36AM +0200, Michel Dänzer wrote: On Fre, 2013-08-02 at 17:58 +0200, Michel Dänzer wrote: On Mit, 2013-07-31 at 08:42 -0700, Tom Stellard wrote: On Wed, Jul 31, 2013 at 01:04:01PM +0200, Michel Dänzer wrote: LLVM revision 187139 ('Allocate local

Re: [Mesa-dev] radeonsi: LLVM r187139 broke some piglit tests

2013-08-15 Thread Tom Stellard
On Thu, Aug 15, 2013 at 08:22:39AM -0700, Tom Stellard wrote: On Thu, Aug 15, 2013 at 11:55:36AM +0200, Michel Dänzer wrote: On Fre, 2013-08-02 at 17:58 +0200, Michel Dänzer wrote: On Mit, 2013-07-31 at 08:42 -0700, Tom Stellard wrote: On Wed, Jul 31, 2013 at 01:04:01PM +0200, Michel

Re: [Mesa-dev] radeonsi: LLVM r187139 broke some piglit tests

2013-08-15 Thread Tom Stellard
On Thu, Aug 15, 2013 at 07:50:10PM +0200, Michel Dänzer wrote: On Don, 2013-08-15 at 09:16 -0700, Tom Stellard wrote: On Thu, Aug 15, 2013 at 08:22:39AM -0700, Tom Stellard wrote: On Thu, Aug 15, 2013 at 11:55:36AM +0200, Michel Dänzer wrote: On Fre, 2013-08-02 at 17:58 +0200, Michel

Re: [Mesa-dev] [PATCH] configure: link against -lLLVM to determine build type

2013-08-14 Thread Tom Stellard
On Wed, Aug 14, 2013 at 09:08:55AM +0200, Maarten Lankhorst wrote: Op 14-08-13 04:37, Tom Stellard schreef: On Tue, Aug 13, 2013 at 05:53:52PM +0200, Maarten Lankhorst wrote: Fixes a build failure of 9.2 on ubuntu, because libLLVM-3.3.so is not present in /usr/lib/llvm-3.2/lib. I'm

Re: [Mesa-dev] [PATCH] r600g/llvm: Add missing %s format string to fprintf.

2013-08-13 Thread Tom Stellard
On Sun, Aug 11, 2013 at 07:37:01PM +0200, Jon Severinsson wrote: This fixes a compilation warning with -Wformat-security. CC: 9.2 mesa-sta...@lists.freedesktop.org Reviewed-by: Tom Stellard thomas.stell...@amd.com I've pushed this patch, thanks. -Tom --- src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH] radeon/llvm: fix compile error with -Werror=format-security

2013-08-13 Thread Tom Stellard
On Tue, Aug 13, 2013 at 06:25:28PM +0200, Maarten Lankhorst wrote: Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com An identical patch was sent to the list a few days ago, and I've just pushed it now. -Tom --- diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c

Re: [Mesa-dev] [PATCH] configure: link against -lLLVM to determine build type

2013-08-13 Thread Tom Stellard
On Tue, Aug 13, 2013 at 05:53:52PM +0200, Maarten Lankhorst wrote: Fixes a build failure of 9.2 on ubuntu, because libLLVM-3.3.so is not present in /usr/lib/llvm-3.2/lib. I'm trying to understand the problem here, could you give a little more information about how Ubuntu packages LLVM? Where

<    3   4   5   6   7   8   9   10   11   12   >