Hello,
I've noticed the GLX_LARGEST_PBUFFER property is not implemented correctly
(it is, but only in Gallium). Specification:
http://www.opengl.org/sdk/docs/man2/xhtml/glXCreatePbuffer.xml
The value should be used to decrease buffer size when necessary, but also
stored so it can be retrieved by
The change is to correctly handle the value of renderType in both
fbconfig and context. Uses of renderType are commented, where needed,
to avoid confusion between the two types. The fact that float configs
can be only used for pbuffers is correctly addressed.
---
src/glx/dri2_glx.c |7 +++
The change is to correctly handle the value of renderType and
drawableType in fbconfig. This part modifies glXInitializeVisualConfigFromTags
to read the parameter value, or detect it if it's not there.
---
src/glx/glxext.c | 35 +++
src/mesa/drivers/
This change makes sure that context creation routines are provided
with the value of RENDER_TYPE retrieved from GLX attribs.
---
src/glx/dri2_glx.c |3 ++-
src/glx/dri_common.c |8
src/glx/dri_common.h |2 +-
src/glx/drisw_glx.c |2 +-
4 files changed, 8 insertions(+),
The change allows to store RENDER_TYPE value in GLX context
when indirect rendering is in use.
---
src/glx/create_context.c |4 +++-
src/glx/glxclient.h |7 +++
src/glx/glxcmds.c|1 -
src/glx/indirect_glx.c | 23 ++-
4 files changed, 28 insertio
This patch sets the correct values of renderType and drawableType
in glXCreateContext and init_fbconfig_for_chooser routines.
---
src/glx/glxcmds.c | 32 +++-
1 file changed, 27 insertions(+), 5 deletions(-)
diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c
index 5
The change is to correctly handle the value of renderType in GLX context.
In case of the value being incorrect, context creation fails.
---
src/glx/dri2_glx.c | 11 +++
src/glx/dri_glx.c |6 ++
src/glx/drisw_glx.c| 12
src/glx/g
From: Tomasz Lis
The patch defines fbconfig_float in tables of extensions and enables
reporting the extension availability.
Signed-off-by: Tomasz Lis
---
src/glx/glxextensions.c |4
src/glx/glxextensions.h |6 +-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a
From: Tomasz Lis
The patch marks __DRI_ATTRIB_FLOAT_MODE as deprecated and introduces
nrw flags to __DRI_ATTRIB_RENDER_TYPE which are to define float modes.
Both signed float (fbconfig_float) and unsigned (packed_float) is
introduced as a flag. The old attribute should be set for both float
Thank you for your feedback.
I will modify all patches to have short description below email title. I
will add "glx:" to the GLX patches.
2013/7/16 Kenneth Graunke
> On 07/15/2013 01:41 PM, Ian Romanick wrote:
>
>> On 07/15/2013 07:28 AM, Tomasz Lis wrote:
>>
&g
awableType setting in glXChooseFBConfig vs glXChooseVisual:
I will make a separate commit out of this. The justification is that visual
configs are on-screen configs - so they have to support drawing on a
window, by definition.
2013/7/15 Ian Romanick
> On 07/15/2013 07:28 AM, Tomasz Lis wrote:
&g
Thank you for your review.
I will add the white space.
I will remove the unused parameter code.
2013/7/15 Ian Romanick
> On 07/15/2013 07:28 AM, Tomasz Lis wrote:
>
>> The change allows to store RENDER_TYPE value in GLX context
>> when indirect rendering is in use.
&
Thank you.
I will rename the function to validate_renderType_against_config and make
it return bool.
I will fix the brace.
2013/7/15 Ian Romanick
> On 07/15/2013 07:28 AM, Tomasz Lis wrote:
>
>> The change is to correctly handle the value of renderType in GLX context.
>> In
There is something wrong with indentation in that file, but fixing it
should be a separate commit.
I will change the patch to keep the original whitespace convention.
2013/7/15 Ian Romanick
> On 07/15/2013 07:28 AM, Tomasz Lis wrote:
>
>> From: Tomasz Lis
>>
verify the possible clang problem - if we
can't solve this, I will just remove the whole section.
I will leave the fakeglx hunks unchanged.
2013/7/16 Brian Paul
> On 07/15/2013 12:33 PM, Ian Romanick wrote:
>
>> On 07/15/2013 07:28 AM, Tomasz Lis wrote:
>>
> [...]
Thank you.
I will change all the VER to 0,0.
I will turn this patch into last one in the series.
Regarding indirect rendering - I didn't tested it. Please let me know if I
should change any of the Y/N switches.
2013/7/15 Ian Romanick
> On 07/15/2013 07:28 AM, Tomasz Lis wrote:
&
glx: Store the value of renderType while creating context.
This patch makes sure that renderType property value is stored in GLX context
while it's being created. Further patches will be provided to make the value
correspond to fbconfig's renderType.
---
src/glx/dri2_glx.c |7 +++
src/gl
glx: Retrieve the value of RENDER_TYPE from GLX attribs array.
This change makes sure that context creation routines are provided
with the value of RENDER_TYPE retrieved from GLX attribs.
---
src/glx/dri2_glx.c |3 ++-
src/glx/dri_common.c |8
src/glx/dri_common.h |2 +-
sr
glx: Changes to visual configs initialization.
The change is to correctly handle the value of renderType and
drawableType in fbconfig. This part modifies glXInitializeVisualConfigFromTags
to read the parameter value, or detect it if it's not there.
---
src/glx/glxext.c | 37 ++
glx: Handling RENDER_TYPE in glXCreateContext and init_fbconfig_for_chooser.
This patch sets the correct values of renderType
in glXCreateContext and init_fbconfig_for_chooser routines.
---
src/glx/glxcmds.c | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff
glx: Storing the RENDER_TYPE in indirect rendering.
The change allows to store RENDER_TYPE value in GLX context
when indirect rendering is in use.
---
src/glx/create_context.c |4 +++-
src/glx/glxclient.h |7 +++
src/glx/glxcmds.c|1 -
src/glx/indirect_glx.c | 29
glx: Verification of the RENDER_TYPE value.
The change is to correctly handle the value of renderType in GLX context.
In case of the value being incorrect, context creation fails.
---
src/glx/dri2_glx.c |9 +
src/glx/dri_glx.c |5 +
src/glx/drisw_glx.c
From: Tomasz Lis
dri: Introduce new flags in __DRI_ATTRIB_RENDER_TYPE.
The patch marks __DRI_ATTRIB_FLOAT_MODE as deprecated and introduces
nrw flags to __DRI_ATTRIB_RENDER_TYPE which are to define float modes.
Both signed float (fbconfig_float) and unsigned (packed_float) is
introduced as a
From: Tomasz Lis
glx: Float configs extension strings.
The patch defines fbconfig_float in tables of extensions and enables
reporting the extension availability.
Signed-off-by: Tomasz Lis
---
src/glx/glxextensions.c |2 ++
src/glx/glxextensions.h |6 +-
2 files changed, 7
glx: Require proper drawableType in init_fbconfig_for_chooser.
This patch makes sure that init_fbconfig_for_chooser sets correct
value of drawableType for visual configs and fbconfigs.
---
src/glx/glxcmds.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/glx/glxcm
From: Tomasz Lis
This fix splits entries in dispatch table mechanism according to
framebuffer_object EXT and ARB specs. Different bind functions
allow further diferentiation in other calls, based on binded
type of object.
This patch is based on one created by Bartosz Zawistowski.
---
src/mapi
I forgot about the YNYN to YYNN change in this patch - sorry for that, will
re-submit in ~9 hours.
2013/7/16 Tomasz Lis
> From: Tomasz Lis
>
> glx: Float configs extension strings.
>
> The patch defines fbconfig_float in tables of extensions and enables
> reporting the exte
glx: Handling RENDER_TYPE in glXCreateContext and init_fbconfig_for_chooser.
This patch sets the correct values of renderType
in glXCreateContext and init_fbconfig_for_chooser routines.
---
src/glx/glxcmds.c | 28
1 file changed, 24 insertions(+), 4 deletions(-)
d
From: Tomasz Lis
glx: Float configs extension strings.
The patch defines fbconfig_float in tables of extensions and enables
reporting the extension availability.
Signed-off-by: Tomasz Lis
---
src/glx/glxextensions.c |2 ++
src/glx/glxextensions.h |6 +-
2 files changed, 7
glx: Store the value of renderType while creating context.
This patch makes sure that renderType property value is stored in GLX context
while it's being created. Further patches will be provided to make the value
correspond to fbconfig's renderType.
---
src/glx/dri2_glx.c |7 +++
src/gl
glx: Retrieve the value of RENDER_TYPE from GLX attribs array.
This change makes sure that context creation routines are provided
with the value of RENDER_TYPE retrieved from GLX attribs.
---
src/glx/dri2_glx.c |3 ++-
src/glx/dri_common.c |8
src/glx/dri_common.h |2 +-
sr
glx: Changes to visual configs initialization.
The change is to correctly handle the value of renderType and
drawableType in fbconfig. This part modifies glXInitializeVisualConfigFromTags
to read the parameter value, or detect it if it's not there.
---
src/glx/glxext.c | 37 ++
glx: Handling RENDER_TYPE in glXCreateContext and init_fbconfig_for_chooser.
This patch sets the correct values of renderType
in glXCreateContext and init_fbconfig_for_chooser routines.
---
src/glx/glxcmds.c | 28
1 file changed, 24 insertions(+), 4 deletions(-)
d
glx: Verification of the RENDER_TYPE value.
The change is to correctly handle the value of renderType in GLX context.
In case of the value being incorrect, context creation fails.
---
src/glx/dri2_glx.c |9 +
src/glx/dri_glx.c |5 +
src/glx/drisw_glx.c
glx: Storing the RENDER_TYPE in indirect rendering.
The change allows to store RENDER_TYPE value in GLX context
when indirect rendering is in use.
---
src/glx/create_context.c |4 +++-
src/glx/glxclient.h |7 +++
src/glx/glxcmds.c|1 -
src/glx/indirect_glx.c | 29
glx: Require proper drawableType in init_fbconfig_for_chooser.
This patch makes sure that init_fbconfig_for_chooser sets correct
value of drawableType for visual configs and fbconfigs.
---
src/glx/glxcmds.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/glx/glxcm
From: Tomasz Lis
dri: Introduce new flags in __DRI_ATTRIB_RENDER_TYPE.
The patch marks __DRI_ATTRIB_FLOAT_MODE as deprecated and introduces
nrw flags to __DRI_ATTRIB_RENDER_TYPE which are to define float modes.
Both signed float (fbconfig_float) and unsigned (packed_float) is
introduced as a
From: Tomasz Lis
glx: Creation of dummy X pixmap associated with float buffer.
This change addresses the fact that float configs can be only used for pbuffers,
and that 2D driver may not allow creation of an associated pixmap.
It wouldn't be needed if 2D driver could always support 12
From: Tomasz Lis
glx: Float configs extension strings.
The patch defines fbconfig_float in tables of extensions and enables
reporting the extension availability.
Signed-off-by: Tomasz Lis
---
src/glx/glxextensions.c |2 ++
src/glx/glxextensions.h |2 ++
2 files changed, 4 insertions
Is there any progress regarding this patch?
Without it, XServer will try to create a 128 bpp pixmap while creating
float pbuffers. Buffers with BPP over 32 are not supported by
xf86-video-intel, and the pixmap creation will fail.
2013/7/19 Ian Romanick
> On 07/17/2013 04:49 AM, Tomasz
From: Tomasz Lis
The change is to correctly handle the value of renderType in both
fbconfig and context. Uses of renderType are commented, where needed,
to avoid confusion between the two types. The fact that float configs
can be only used for pbuffers is correctly addressed.
Signed-off-by
From: Tomasz Lis
The patch defines fbconfig_float in tables of extensions and enables
reporting the extension availability.
Signed-off-by: Tomasz Lis
---
.../state_trackers/wgl/stw_ext_pixelformat.c | 10 +-
src/glx/glxextensions.c|4
src
From: Tomasz Lis
The patch marks __DRI_ATTRIB_FLOAT_MODE as deprecated and introduces
nrw flags to __DRI_ATTRIB_RENDER_TYPE which are to define float modes.
Both signed float (fbconfig_float) and unsigned (packed_float) is
introduced as a flag. The old attribute should be set for both float
43 matches
Mail list logo
