Re: [Mesa-dev] [PATCH v3 0/6] support config for third-party DRI driver load

2018-08-18 Thread Yu, Qiang
>>> - added HAVE_LIBDRM guard for __driConfigOptionsLoader and >>> loader_get_dri_config_driver >> My thoughts are: >> 1. __driConfigOptionsLoader and loader_get_dri_config_driver don't >> have code depend on HAVE_LIBDRM (loader_get_kernel_driver_name >> does but already has HAVE_LIBDRM), so it's

Re: [Mesa-dev] [PATCH v3 0/6] support config for third-party DRI driver load

2018-08-17 Thread Yu, Qiang
Thanks Emil. > - missing include (for PATH_MAX) in patch 1 Although I can compile without , I agree to add it explicitly. > - added HAVE_LIBDRM guard for __driConfigOptionsLoader and > loader_get_dri_config_driver My thoughts are: 1. __driConfigOptionsLoader and loader_get_dri_config_driver don'

Re: [Mesa-dev] [PATCH v3 0/6] support config for third-party DRI driver load

2018-08-15 Thread Yu, Qiang
> Pardon for the delay, Qiang Yu Series looks good and is > Reviewed-by: Emil Velikov > > The series has been on the list for a while, Michel seems happy with > it, so I'm inclined to merge this late today/early tomorrow. > Please keep an eye open for any bug reports - just a gut feeling. Thank

Re: [Mesa-dev] [PATCH v3 1/6] xmlconfig: refine driParseConfigFiles to use parseOneConfigFile

2018-08-15 Thread Yu, Qiang
Thanks, Michel. > What's the point of having the separate _parseOneConfigFile function? > It's not used outside of parseOneConfigFile AFAICT. No particular reason from mine, just move out the inline part. So should be same reason as the original code to separate the parser prepare part and the re

Re: [Mesa-dev] [PATCH v3 0/6] support config for third-party DRI driver load

2018-08-14 Thread Yu, Qiang
Ping v2. @Emil, @Michel, could you help to review this new version of patch? Thanks, Qiang From: Yu, Qiang Sent: Friday, August 10, 2018 2:22:03 PM To: mesa-dev@lists.freedesktop.org Cc: Adam Jackson; Michel Dänzer; Eric Engestrom; Emil Velikov Subject

Re: [Mesa-dev] [PATCH v3 0/6] support config for third-party DRI driver load

2018-08-09 Thread Yu, Qiang
Ping. Regards, Qiang From: Qiang Yu Sent: Monday, August 6, 2018 11:19:21 AM To: mesa-dev@lists.freedesktop.org Cc: Adam Jackson; Michel Dänzer; Eric Engestrom; Emil Velikov; Yu, Qiang Subject: [PATCH v3 0/6] support config for third-party DRI driver

Re: [Mesa-dev] [PATCH v2 2/3] driconf: move ${sysconfdir}/drirc to ${datadir}/drirc.d/00-mesa-defaults.conf

2018-08-03 Thread Yu, Qiang
Yeah, just rename. Regards, Qiang From: Emil Velikov Sent: Friday, August 3, 2018 6:38:18 PM To: Yu, Qiang Cc: ML mesa-dev; Adam Jackson; Michel Dänzer; Eric Engestrom Subject: Re: [PATCH v2 2/3] driconf: move ${sysconfdir}/drirc to ${datadir}/drirc.d

Re: [Mesa-dev] [PATCH v2 1/3] xmlconfig: read more config files from drirc.d/

2018-08-03 Thread Yu, Qiang
Hi Emil, Thanks for the review, I indeed miss the dirent free. >> +/** \brief Parse configuration files in a directory */ >> +static void >> +parseConfigDir(struct OptConfData *data, const char *dirname) >> +{ >> +int i, count; >> +struct dirent **entries = NULL; >> + >> +count = scan

Re: [Mesa-dev] [PATCH 1/2] xmlconfig: read more config files from drirc.d/

2018-08-02 Thread Yu, Qiang
OK, I'll move /etc/drirc to /usr/share/drirc.d. For /etc/drirc and /etc/drirc.d, I agree to keep /etc/drirc for keeping user convention of the previously usage of this file. As newly added /etc/drirc.d, just for admin's flexibility, I can drop it if no clear needs for now. Regards, Qiang ___

Re: [Mesa-dev] [PATCH 2/2] loader: add dri_driver drirc option to override dri driver to load

2018-08-02 Thread Yu, Qiang
tribute only affect loader device. Regards, Qiang From: Michel Dänzer Sent: Thursday, August 2, 2018 5:37:02 PM To: Yu, Qiang Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 2/2] loader: add dri_driver drirc option to override dri driver to loa

Re: [Mesa-dev] [RFC] add a config file for dri loader to choose a different dri driver

2018-07-31 Thread Yu, Qiang
54 AM To: Yu, Qiang; mesa-dev@lists.freedesktop.org Cc: Emil Velikov Subject: Re: [Mesa-dev] [RFC] add a config file for dri loader to choose a different dri driver On Tue, 2018-07-31 at 08:03 +0000, Yu, Qiang wrote: > Seems the mesa driconf infrastructure is just what I need: > https://dri.f

Re: [Mesa-dev] [RFC] add a config file for dri loader to choose a different dri driver

2018-07-31 Thread Yu, Qiang
Good idea. But adding a new device attribute seems over-kill, how about just use the driver attribute and prefix a "k:" for kernel driver like this: ? Regards, Qiang From: Michel Dänzer Sent: Tuesday, July 31, 2018 9:35:09 PM To: Yu, Qiang Cc

Re: [Mesa-dev] [RFC] add a config file for dri loader to choose a different dri driver

2018-07-31 Thread Yu, Qiang
From: mesa-dev on behalf of Yu, Qiang Sent: Tuesday, July 31, 2018 9:51:09 AM To: mesa-dev@lists.freedesktop.org Cc: Emil Velikov Subject: [Mesa-dev] [RFC] add a config file for dri loader to choose a different dri driver Hi guys, As previously talked in

[Mesa-dev] [RFC] add a config file for dri loader to choose a different dri driver

2018-07-30 Thread Yu, Qiang
Hi guys, As previously talked in: https://lists.freedesktop.org/archives/mesa-dev/2017-April/152055.html amdgpu-pro driver has interest to adopt the DRI interface to be compatable with the mesa libgbm. But using MESA_LOADER_DRIVER_OVERRIDE is not a good way to config OS GFX stack globally, so I'd

Re: [Mesa-dev] [PATCH] Android: gallium_dri: add include to get "xmlpool/options.h"

2017-12-18 Thread Yu, Qiang
I met this problem when upgrade mesa 17.2 to 17.3, and build without a make clean. A clean build won't have this problem. Regards, Qiang From: Mauro Rossi Sent: Tuesday, December 19, 2017 6:19:44 AM To: Emil Velikov Cc: ML mesa-dev; Haehnle, Nicola

Re: [Mesa-dev] [PATCH] Android: gallium_dri: add include to get "xmlpool/options.h"

2017-12-17 Thread Yu, Qiang
Looks good for me. Reviewed-by: Qiang Yu Regards, Qiang From: Mauro Rossi Sent: Monday, December 18, 2017 7:34:46 AM To: mesa-dev@lists.freedesktop.org Cc: Haehnle, Nicolai; Yu, Qiang; emil.l.veli...@gmail.com; 17.3 Subject: [PATCH] Android: gallium_dri

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-18 Thread Yu, Qiang
> gallium_dri_la_LDFLAGS += \ > -Wl,--version-script=$(top_srcdir)/src/gallium/targets/dri/dri.sym A nice trick to know about. Regards, Qiang ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/

Re: [Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

2017-04-14 Thread Yu, Qiang
Hi Emil, > What happened with the idea of reusing your existing amdgpu_dri.so ? > As mentioned before the DRI loader (libgbm) <> DRI driver (foo_dri.so) > interface is stable, so things should just work. Sorry for the late reply. I've asked our amdgpu_dri.so team for this, they seems have no inte

Re: [Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

2017-04-07 Thread Yu, Qiang
> sysconfigdir is the right place. If you want it to point to /etc, you > should run configure with --with-sysconfigdir=/etc. The point of > --prefix is to make sure that everything's contained within it. Many > distros choose to set the sysconfigdir to /etc, but that doesn't > change the fact tha

Re: [Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

2017-04-07 Thread Yu, Qiang
>> +dnl Directory for GBM >> + >> +AC_ARG_WITH([gbm-configdir], >> +[AS_HELP_STRING([--with-gbm-configdir=DIR], >> +[directory for the GBM configs @<:@/etc/gbm.conf.d@:>@])], >> +[GBM_CONFIG_DIR="$withval"], >> +[GBM_CONFIG_DIR='/etc/gbm.conf.d']) > > Without commenting on the

Re: [Mesa-dev] [PATCH] gbm: add support for loading third-party backend

2017-02-05 Thread Yu, Qiang
:28:21 PM To: Yu, Qiang; Emil Velikov; Mao, David Cc: ML mesa-dev Subject: Re: [Mesa-dev] [PATCH] gbm: add support for loading third-party backend On 06/02/17 02:58 PM, Yu, Qiang wrote: > >> * The ImgTec guys were able to tweak their binary which combined with >> a bit of mesa glue

Re: [Mesa-dev] [PATCH] gbm: add support for loading third-party backend

2017-02-05 Thread Yu, Qiang
+ David Hi Emil, > * With the discussion(s) about liballoc/libgbm2 in motion wouldn't it > be better to focus/target it ? [yuq] I think this small improvement won't conflict with libgbm2 work which is not my current focus. My purpose is getting current mesa co-exist with amdgpu-pro. BTW. will lib

Re: [Mesa-dev] [PATCH] gbm: add support for loading third-party backend

2017-02-05 Thread Yu, Qiang
Thanks Nicolai, I'll address the gbmint.h and ABI version next version. Regards, Qiang From: Nicolai Hähnle Sent: Tuesday, January 24, 2017 6:12:06 PM To: Yu, Qiang; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] gbm: add suppor

Re: [Mesa-dev] [PATCH] gbm: add support for loading third-party backend

2017-01-25 Thread Yu, Qiang
rds, Qiang From: Michel Dänzer Sent: Wednesday, January 25, 2017 4:11:40 PM To: Yu, Qiang Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] gbm: add support for loading third-party backend On 24/01/17 12:36 PM, Qiang Yu wrote: > Third-party can put

Re: [Mesa-dev] Problem using GLVND enabled mesa with Intel DDX

2016-12-15 Thread Yu, Qiang
Thanks for your info, Emil. Same bug as 98428. Regards, Qiang From: Emil Velikov Sent: Thursday, December 15, 2016 9:58:34 PM To: Yu, Qiang Cc: mesa-dev@lists.freedesktop.org; kbrenne...@nvidia.com; Daenzer, Michel Subject: Re: [Mesa-dev] Problem using

[Mesa-dev] Problem using GLVND enabled mesa with Intel DDX

2016-12-15 Thread Yu, Qiang
Hi guys, I'm trying GLVND with mesa, but the Intel DDX seems have some problem with it: [ 2970.834] (EE) AIGLX error: dlopen of /usr/lib/x86_64-linux-gnu/dri/i965_dri.so failed (/usr/lib/x86_64-linux-gnu/dri/i965_dri.so: undefined symbol: _glapi_tls_Dispatch) [ 2970.834] (EE) AIGLX: revertin

Re: [Mesa-dev] GBM backend dynamic dispatch method

2016-05-12 Thread Yu, Qiang
way, but it could be made possible. Also next question would be: why not let radeonsi handle EGL (and gbm), and have amdgpu-pro handle glx only ? That way amdgpu-pro won't need to duplicate the code for wayland support, gbm support, etc. Axel On 12/05/2016 09:10, Yu, Qiang wrote : Thanks

Re: [Mesa-dev] GBM backend dynamic dispatch method

2016-05-12 Thread Yu, Qiang
suggestion, and you'd better wait for gbm maintainers to voice theirs. Axel On 12/05/2016 04:45, Yu, Qiang wrote: Hi guys, Let me introduce myself. My name is Qiang Yu, I'm a developer of amdgpu-pro driver. As you know the amdgpu-pro adopts some open source part like GBM but due

[Mesa-dev] GBM backend dynamic dispatch method

2016-05-11 Thread Yu, Qiang
Hi guys, Let me introduce myself. My name is Qiang Yu, I'm a developer of amdgpu-pro driver. As you know the amdgpu-pro adopts some open source part like GBM but due to its close source OGL part, we implement our own GBM backend. Currently libgbm only support static selection of GBM backend