On 30 September 2016 at 06:47, Matt Whitlock <freedesk...@mattwhitlock.name> wrote: > Without this fix, duplicated file descriptors leak into child processes. > See commit aaac913e901229d11a1894f6aaf646de6b1a542c for one instance > where the same fix was employed. > > Cc: <mesa-sta...@lists.freedesktop.org> > Signed-off-by: Matt Whitlock <freedesk...@mattwhitlock.name> > --- > src/egl/drivers/dri2/platform_android.c | 3 ++- > src/gallium/auxiliary/vl/vl_winsys_drm.c | 3 ++- > src/gallium/state_trackers/dri/dri2.c | 5 +++-- > src/gallium/state_trackers/xa/xa_tracker.c | 3 ++- > src/gallium/winsys/nouveau/drm/nouveau_drm_winsys.c | 3 ++- > src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 3 ++- > src/gallium/winsys/svga/drm/vmw_screen.c | 3 ++- > src/gallium/winsys/vc4/drm/vc4_drm_winsys.c | 3 ++- > src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 2 +- > 9 files changed, 18 insertions(+), 10 deletions(-) > Being the author of some of these - thanks for correction. Out of curiosity - did you notice some of these by inspection or you were hit my the leak ?
As the above list, and lengthy one-line summary, indicates this could/should be split up a bit, even though it's quite trivial fix. Please do either - one per subsystem (file effectively) or egl, gallium/auxiliary, st/dri, st/xa & gallium/winsys ? Thanks again ! Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
