Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/vec4: Use reads_accumulator_implicitly(), not MACH checks.

2017-04-25 Thread Kenneth Graunke
On Tuesday, April 25, 2017 5:24:09 AM PDT Andres Gomez wrote: > On Tue, 2017-04-25 at 11:57 +0200, Juan A. Suarez Romero wrote: > > On Sat, 2017-04-22 at 16:28 -0700, Kenneth Graunke wrote: > > > Curro pointed out that I should not just check for MACH, but use > > > the

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/vec4: Use reads_accumulator_implicitly(), not MACH checks.

2017-04-25 Thread Andres Gomez
On Tue, 2017-04-25 at 11:57 +0200, Juan A. Suarez Romero wrote: > On Sat, 2017-04-22 at 16:28 -0700, Kenneth Graunke wrote: > > Curro pointed out that I should not just check for MACH, but use > > the reads_accumulator_implicitly() helper, which would also prevent > > the same bug with MAC and

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/vec4: Use reads_accumulator_implicitly(), not MACH checks.

2017-04-25 Thread Juan A. Suarez Romero
On Sat, 2017-04-22 at 16:28 -0700, Kenneth Graunke wrote: > Curro pointed out that I should not just check for MACH, but use > the reads_accumulator_implicitly() helper, which would also prevent > the same bug with MAC and SADA2 (if we ever decide to use them). > This seems to rely on commit

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/vec4: Use reads_accumulator_implicitly(), not MACH checks.

2017-04-23 Thread Francisco Jerez
Kenneth Graunke writes: > Curro pointed out that I should not just check for MACH, but use > the reads_accumulator_implicitly() helper, which would also prevent > the same bug with MAC and SADA2 (if we ever decide to use them). > > Cc: Francisco Jerez