Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Don't emit SURFACE_STATEs for gather workarounds on Broadwell.

2014-06-23 Thread Kenneth Graunke
It did not. But, I just ran all of those tests with and without this patch, and there were no regressions. So, I think we're good. Pushed - thanks for the review! On Thursday, May 29, 2014 07:32:21 PM Chris Forbes wrote: > Did this test run include forcing ARB_gpu_shader5 on? > > On Thu, May

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Don't emit SURFACE_STATEs for gather workarounds on Broadwell.

2014-05-29 Thread Chris Forbes
Reviewed-by: Chris Forbes On Thu, May 29, 2014 at 7:32 PM, Chris Forbes wrote: > Did this test run include forcing ARB_gpu_shader5 on? > > On Thu, May 29, 2014 at 7:06 PM, Kenneth Graunke > wrote: >> As far as I can tell, Broadwell doesn't need any of the SURFACE_STATE >> workarounds for textu

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Don't emit SURFACE_STATEs for gather workarounds on Broadwell.

2014-05-29 Thread Chris Forbes
Did this test run include forcing ARB_gpu_shader5 on? On Thu, May 29, 2014 at 7:06 PM, Kenneth Graunke wrote: > As far as I can tell, Broadwell doesn't need any of the SURFACE_STATE > workarounds for textureGather() bugs, so there's no need to emit > a second set of identical copies. > > To keep