Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

2015-12-14 Thread Nanley Chery
On Thu, Dec 10, 2015 at 01:08:37PM -0800, Nanley Chery wrote: > On Tue, Dec 08, 2015 at 04:35:57PM +, Neil Roberts wrote: > > If EGL_KHR_surfaceless_context is used then glViewport can be called > > with NULL for the draw and read surfaces. This was previously causing > > a crash because the

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

2015-12-10 Thread Nanley Chery
On Tue, Dec 08, 2015 at 04:35:57PM +, Neil Roberts wrote: > If EGL_KHR_surfaceless_context is used then glViewport can be called > with NULL for the draw and read surfaces. This was previously causing > a crash because the i965 driver tries to use this point to invalidate > the surfaces and it

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

2015-12-09 Thread Emil Velikov
On 8 December 2015 at 16:35, Neil Roberts wrote: > If EGL_KHR_surfaceless_context is used then glViewport can be called > with NULL for the draw and read surfaces. This was previously causing > a crash because the i965 driver tries to use this point to invalidate > the

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

2015-12-09 Thread Neil Roberts
Emil Velikov writes: > Worth throwing in 11.0 as well ? Yeah, that would probably be sensible. >> if (_mesa_is_winsys_fbo(ctx->DrawBuffer)) { >> - dri2InvalidateDrawable(driContext->driDrawablePriv); >> -

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

2015-12-09 Thread Emil Velikov
On 9 December 2015 at 14:57, Neil Roberts wrote: > Emil Velikov writes: > >> Worth throwing in 11.0 as well ? > > Yeah, that would probably be sensible. > >>> if (_mesa_is_winsys_fbo(ctx->DrawBuffer)) { >>> -